Re: [Intel-gfx] [PATCH 2/3] dim: auto-add remotes

2017-09-27 Thread Rodrigo Vivi
On Wed, Sep 27, 2017 at 09:48:49AM +, Daniel Vetter wrote: > Well, bother to at least prompt. Prep work for adding drm-amd.git. > > Signed-off-by: Daniel Vetter > --- > dim | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/dim b/dim >

Re: [PATCH 3/3] dim: add drm-amd.git

2017-09-27 Thread Rodrigo Vivi
On Wed, Sep 27, 2017 at 09:48:50AM +, Daniel Vetter wrote: > Unfortunately there's a little bit of hardcoded stuff still. > > Cc: Alex Deucher > Cc: Harry Wentland > Signed-off-by: Daniel Vetter Acked-by: Rodrigo

[Bug 101213] Kernel 4.11: amdgpu regression causes artifacts with OLAND amd gpu gcn 1.0

2017-09-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101213 --- Comment #7 from Francisco Lloret --- Same problem with kernel 4.12.12 i Gentoo (gentoo-sources-4.12.12) -- You are receiving this mail because: You are the assignee for the

Re: [PATCH] drm/amd: DC pull request review

2017-09-27 Thread Daniel Vetter
On Wed, Sep 27, 2017 at 6:38 PM, Sean Paul wrote: > Any chance we can address the i2c/gpio [re-]implementations as well? It's already on the list. Part of this is code that's probably dead, the other is a bit too much layer cake still left, and the final bits are not fully

Re: [PATCH] drm/amd: DC pull request review

2017-09-27 Thread Sean Paul
On Wed, Sep 27, 2017 at 6:15 AM, Daniel Vetter wrote: > Ok, here's one more attempt at scrolling through 130k diff. > > Overall verdict from me is that DC is big project, and like any big > project it's never done. So at least for me the goal isn't to make > things

[Bug 99553] Tracker bug for runnning OpenCL applications on Clover

2017-09-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99553 Bug 99553 depends on bug 99950, which changed state. Bug 99950 Summary: Add cl_khr_int64_base_atomics to Clover and make it work on radeonsi https://bugs.freedesktop.org/show_bug.cgi?id=99950 What|Removed

[Bug 99950] Add cl_khr_int64_base_atomics to Clover and make it work on radeonsi

2017-09-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99950 Jan Vesely changed: What|Removed |Added Status|NEW |RESOLVED

Re: [PATCH 1/3] dim: redo the author sob checks

2017-09-27 Thread Rodrigo Vivi
On Wed, Sep 27, 2017 at 09:48:48AM +, Daniel Vetter wrote: > This reverts commit 41dddc0287bb9ef14be8de3c3185ed6aaa809d98 and then > tries a different approach because from the commit that originally > introduced this: > > commit 3dd25f235c73f7855dc570585eb2551961a1911a > Author: Benjamin

Re: [PATCH v2 4/8] drm/rockchip/dsi: correct phy parameter setting

2017-09-27 Thread Matthias Kaehlcke
Hi Nickey, El Tue, Sep 26, 2017 at 03:55:19PM +0800 Nickey Yang ha dit: > As MIPI PHY document show, icpctrl<3..0> and lpfctrl<5..0> > should depend on frequency,so fix it. > > Signed-off-by: Nickey Yang > --- > drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 98 >

Re: [PATCH] drm/amd: DC pull request review

2017-09-27 Thread Harry Wentland
On 2017-09-27 12:48 PM, Daniel Vetter wrote: > On Wed, Sep 27, 2017 at 6:38 PM, Sean Paul wrote: >> Any chance we can address the i2c/gpio [re-]implementations as well? > > It's already on the list. Part of this is code that's probably dead, > the other is a bit too much

Re: [PATCH hwc v2 1/6] drm_hwcomposer: Remove threading

2017-09-27 Thread Sean Paul
On Wed, Sep 27, 2017 at 7:58 AM, Robert Foss wrote: > From: Sean Paul > > Since HWC2 doesn't require the use of threads to implement correct > synchronization, remove some of these threads. > My SoB seems to have been dropped (or perhaps I just

Re: [PATCH hwc v2 2/6] drm_hwcomposer: Add support for IN_FENCE_FD property to DrmPlane

2017-09-27 Thread Sean Paul
On Wed, Sep 27, 2017 at 7:58 AM, Robert Foss wrote: > Add support for the IN_FENCE_FD property to DrmPlane. > > Signed-off-by: Robert Foss Reviewed-by: Sean Paul > --- > drmplane.cpp | 8 > drmplane.h | 2

Re: [PATCH hwc v2 4/6] drm_hwcomposer: Add FENCE_OUT_PTR property to DrmCrtc

2017-09-27 Thread Sean Paul
On Wed, Sep 27, 2017 at 7:58 AM, Robert Foss wrote: > Add support for handling the FENCE_OUT_PTR property to DrmCrtc > > Signed-off-by: Robert Foss Reviewed-by: Sean Paul > --- > drmcrtc.cpp | 10 ++ >

Re: [PATCH] drm/rockchip: Fix memory leak in rockchip_drm_sys_resume()

2017-09-27 Thread Sean Paul
On Wed, Sep 27, 2017 at 08:26:42PM +0800, Jeffy Chen wrote: > Free the drm_atomic_state allocated by drm_atomic_helper_suspend(). > > Fixes: 5a5873830972 ("drm/rockchip: Use atomic PM helpers") > Signed-off-by: Jeffy Chen > --- > >

Re: [PATCH hwc v2 6/6] drm_hwcomposer: Add out-fence support

2017-09-27 Thread Sean Paul
On Wed, Sep 27, 2017 at 7:58 AM, Robert Foss wrote: > Add support for out-fences through the OUT_FENCE_PTR property. > Out-fences signal when their associated buffer may be read by a device. > > Signed-off-by: Robert Foss > --- > > Changes

[PATCH] drm/vc4: Fix pitch setup for T-format scanout.

2017-09-27 Thread Eric Anholt
The documentation said to use src_w here, and I didn't consider that we actually needed to be using pitch somewhere in our setup. Fixes scanout on my DSI panel when X11 does initial setup with 1920x1080 HDMI and 800x480 DSI both at 0,0 of the same framebuffer. Signed-off-by: Eric Anholt

Re: [PATCH] drm/amd: DC pull request review

2017-09-27 Thread Harry Wentland
On 2017-09-27 02:12 PM, Harry Wentland wrote: > On 2017-09-27 12:48 PM, Daniel Vetter wrote: >> On Wed, Sep 27, 2017 at 6:38 PM, Sean Paul wrote: >>> Any chance we can address the i2c/gpio [re-]implementations as well? >> >> It's already on the list. Part of this is code

Re: [PATCH] drm/vc4: Add the DRM_IOCTL_VC4_GEM_MADVISE ioctl

2017-09-27 Thread Eric Anholt
Boris Brezillon writes: > This ioctl will allow us to purge inactive userspace buffers when the > system is running out of contiguous memory. > > For now, the purge logic is rather dumb in that it does not try to > release only the amount of BO needed to meet

Re: [PATCH hwc v2 1/6] drm_hwcomposer: Remove threading

2017-09-27 Thread Robert Foss
Hey Emil, On Wed, 2017-09-27 at 14:34 +0100, Emil Velikov wrote: > On 27 September 2017 at 12:58, Robert Foss > wrote: > > >  16 files changed, 93 insertions(+), 724 deletions(-) > > Holly smokes, that's some amazing stat. > Please sir can I have some more ;-) > >

Re: [PATCH hwc v2 5/6] drm_hwcomposer: Add GetCrtcCount function

2017-09-27 Thread Sean Paul
On Wed, Sep 27, 2017 at 7:58 AM, Robert Foss wrote: > This GetCrtrcCount helper functions enables convenient > fetching of the number of Crtcs from DrmResources. > > Signed-off-by: Robert Foss > --- > drmresources.cpp | 4 >

[PATCH v6 1/3] drm/vc4: Move the DSI clock divider workaround closer to the clock call.

2017-09-27 Thread Eric Anholt
We want the adjusted_mode->clock to be the actual clock we're expecting to program, so that consumers see the right values for clock and vrefresh. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_dsi.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-)

[PATCH v6 0/3] RPi touchscreen panel resend.

2017-09-27 Thread Eric Anholt
I pushed a couple of the patches from the series, so here's what's left. I figured it was time for a resend at this point. Eric Anholt (3): drm/vc4: Move the DSI clock divider workaround closer to the clock call. dt-bindings: Document the Raspberry Pi Touchscreen nodes. drm/panel: Add

[PATCH 0/3] DC pull request cleanup

2017-09-27 Thread Harry Wentland
Patches to make DC use kzalloc/krealloc/kfree directly. Also updating the TODO list after a closer look at I2C in DC. Harry Wentland (3): drm/amd/display: Use kernel alloc/free drm/amd/display: Remove alloc/free macros drm/amd/display: DC I2C review drivers/gpu/drm/amd/display/TODO

[PATCH 1/3] drm/amd/display: Use kernel alloc/free

2017-09-27 Thread Harry Wentland
Abstractions are frowned upon. Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- drivers/gpu/drm/amd/display/dc/basics/logger.c | 18 --- drivers/gpu/drm/amd/display/dc/basics/vector.c | 19 +++

[PATCH 2/3] drm/amd/display: Remove alloc/free macros

2017-09-27 Thread Harry Wentland
Now that we don't abstract kernel alloc interfaces we don't need those anymore. Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dm_services.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dm_services.h

[PATCH 3/3] drm/amd/display: DC I2C review

2017-09-27 Thread Harry Wentland
While reviewing I2C in DC identified a few places. Added a couple to the TODO list. 1) Connector info read See get_ext_display_connection_info On some boards the connector information has to be read through a special I2C channel. This line is only used for this purpose and only on driver init.

Re: [PATCH hwc v2 3/6] drm_hwcomposer: Submit in-fence to DRM

2017-09-27 Thread Sean Paul
On Wed, Sep 27, 2017 at 7:58 AM, Robert Foss wrote: > Add support for in-fences through the IN_FENCE_FD property. In-fences signal > when their associated buffer may be read by DRM/KMS. > > Signed-off-by: Robert Foss > --- >

Re: [PATCH hwc v1] drm_hwcomposer: Add CONTRIBUTING file

2017-09-27 Thread Robert Foss
Hey Emil, On Wed, 2017-09-27 at 15:42 +0100, Emil Velikov wrote: > Hi Rob, > > Glad to see this. There's a couple of suggestions that I hope you'll > find worth while. > > On 22 September 2017 at 01:37, Robert Foss > wrote: > > Some basic guidelines for

Re: [PATCH] drm/rockchip: Rely on the default best_encoder() behavior

2017-09-27 Thread Sean Paul
On Wed, Sep 27, 2017 at 12:23:17PM -0600, Haneen Mohammed wrote: > Since the output has 1:1 relationship between connectors and encoders, > and the driver is relying on the atomic helpers, remove the custom > best_encoder() and let the core call drm_atomic_helper_best_encoder(). > >

Re: [PATCH 3/3] drm: rcar-du: Clip planes to screen boundaries

2017-09-27 Thread Kieran Bingham
Hi Laurent, Thanks for the patch, On 16/08/17 00:03, Laurent Pinchart wrote: > Unlike the KMS API, the hardware doesn't support planes exceeding the > screen boundaries. Clip plane coordinates to support the use case. > > Signed-off-by: Laurent Pinchart

Re: [PATCH hwc v2 3/6] drm_hwcomposer: Submit in-fence to DRM

2017-09-27 Thread Robert Foss
Hey Sean, On Wed, 2017-09-27 at 14:55 -0400, Sean Paul wrote: > On Wed, Sep 27, 2017 at 7:58 AM, Robert Foss om> wrote: > > Add support for in-fences through the IN_FENCE_FD property. In- > > fences signal > > when their associated buffer may be read by DRM/KMS. > > >

Re: [PATCH 2/3] drm: rcar-du: Reject planes located fully off-screen

2017-09-27 Thread Kieran Bingham
Hi Laurent, Thankyou for the patch, This looks good, and passes the tests. On 16/08/17 00:03, Laurent Pinchart wrote: > There is no point in accepting fully off-screen planes as they won't be > displayed. Reject them in the atomic check. > > Signed-off-by: Laurent Pinchart

[PATCH v6 2/3] dt-bindings: Document the Raspberry Pi Touchscreen nodes.

2017-09-27 Thread Eric Anholt
This doesn't yet cover input, but the driver does get the display working when the firmware is disabled from talking to our I2C lines. Signed-off-by: Eric Anholt Acked-by: Rob Herring --- .../panel/raspberrypi,7inch-touchscreen.txt| 49

[PATCH v6 3/3] drm/panel: Add support for the Raspberry Pi 7" Touchscreen.

2017-09-27 Thread Eric Anholt
This driver communicates with the Atmel microcontroller for sequencing the poweron of the TC358762 DSI-DPI bridge and controlling the backlight PWM. v2: Set the same default orientation as the closed source firmware used, which is the best for viewing angle. v3: Rewrite as an i2c client

Re: [PATCH v2 1/8] drm/rockchip/dsi: correct Feedback divider setting

2017-09-27 Thread Sean Paul
On Tue, Sep 26, 2017 at 03:55:16PM +0800, Nickey Yang wrote: > This patch correct Feedback divider setting: > 1、Set Feedback divider [8:5] when HIGH_PROGRAM_EN > 2、Due to the use of a "by 2 pre-scaler," the range of the > feedback multiplication Feedback divider is limited to even > division

Re: [PATCH hwc v1] drm_hwcomposer: Add CONTRIBUTING file

2017-09-27 Thread Rob Herring
On Wed, Sep 27, 2017 at 1:55 PM, Robert Foss wrote: > Hey Emil, > > On Wed, 2017-09-27 at 15:42 +0100, Emil Velikov wrote: >> Hi Rob, >> >> Glad to see this. There's a couple of suggestions that I hope you'll >> find worth while. >> >> On 22 September 2017 at 01:37,

Re: [PATCH 0/3] DC pull request cleanup

2017-09-27 Thread Alex Deucher
On Wed, Sep 27, 2017 at 3:46 PM, Harry Wentland wrote: > Patches to make DC use kzalloc/krealloc/kfree directly. > > Also updating the TODO list after a closer look at I2C in DC. > > Harry Wentland (3): > drm/amd/display: Use kernel alloc/free > drm/amd/display: Remove

Re: [RESEND RFC PATCH 4/7] dt-bindings: Document Allwinner DWC HDMI TX node

2017-09-27 Thread Rob Herring
On Wed, Sep 20, 2017 at 10:01:21PM +0200, Jernej Skrabec wrote: > Add documentation about Allwinner DWC HDMI TX node, found in H3 SoC. > > Signed-off-by: Jernej Skrabec > --- > .../bindings/display/sunxi/sun4i-drm.txt | 158 > - > 1 file

[PULL] drm-intel-fixes

2017-09-27 Thread Rodrigo Vivi
Hi Dave, Here goes the drm/i915 fixes for 4.14-rc3 Couple fixes for stable: - Fix ELD connector types and consequently audio on DP (Jani). - Ignore HDMI on Port A and consequently fix an ops on i915 probe when VBT advertises HDMI on Port A (Jani). And a small fix: - That removes a

[PATCH v2] drm/dp: Do not prune the last mode on the connector

2017-09-27 Thread Manasi Navare
Currently the drm_mode_prune_invalid() function will prune all the modes if it finds that the mode-status is not MODE_OK. But if it ends up pruning all modes then there are no modes left for that connector which will eventually result into a black screen as userspace sees no modes from the kernel.

[PATCH] drm/dp: Do not prune the last mode on the connector

2017-09-27 Thread Manasi Navare
Currently the drm_mode_prune_invalid() function will prune all the modes if it finds that the mode-status is not MODE_OK. But if it ends up pruning all modes then there are no modes left for that connector which will eventually result into a black screen as userspace sees no modes from the kernel.

Re: [Mesa-dev] XDC 2017 feedback

2017-09-27 Thread Rob Clark
On Wed, Sep 27, 2017 at 7:25 PM, Ian Romanick wrote: > On 09/26/2017 09:57 AM, Daniel Vetter wrote: >> Hi all, >> >> First again big thanks to Stéphane and Jennifer for organizing a great XDC. >> >> Like last year we'd like to hear feedback on how this year's XDC went, >>

Re: [PATCH] drm/dp: Do not prune the last mode on the connector

2017-09-27 Thread Keith Packard
Manasi Navare writes: > This patch fixes this problem by checking if the mode being pruned > is the last mode on that connector and if so doesnt prune it. I think you want to stop pruning when you've gotten to a single mode on the list, not at the last mode in the

Re: [PATCH] drm/dp: Do not prune the last mode on the connector

2017-09-27 Thread Manasi Navare
On Wed, Sep 27, 2017 at 05:31:56PM -0700, Keith Packard wrote: > Manasi Navare writes: > > > This patch fixes this problem by checking if the mode being pruned > > is the last mode on that connector and if so doesnt prune it. > > I think you want to stop pruning when

[PATCH v2] drm/amd/display: Use kernel alloc/free

2017-09-27 Thread Harry Wentland
Abstractions are frowned upon. cocci script: virtual context virtual patch virtual org virtual report @@ expression ptr; @@ - dm_alloc(ptr) + kzalloc(ptr, GFP_KERNEL) @@ expression ptr, size; @@ - dm_realloc(ptr, size) + krealloc(ptr, size, GFP_KERNEL) @@ expression ptr; @@ - dm_free(ptr) +

Re: [Mesa-dev] XDC 2017 feedback

2017-09-27 Thread Rob Clark
On Wed, Sep 27, 2017 at 10:49 PM, Ian Romanick wrote: > On 09/27/2017 04:55 PM, Rob Clark wrote: >> On Wed, Sep 27, 2017 at 7:25 PM, Ian Romanick wrote: >>> On 09/26/2017 09:57 AM, Daniel Vetter wrote: Hi all, First again big thanks to

Re: [Mesa-dev] XDC 2017 feedback

2017-09-27 Thread Matt Turner
On Wed, Sep 27, 2017 at 10:07 PM, Rob Clark wrote: > If you had known of the khr dates, and brought it up in Feb (or really > somewhat earlier, given that XDC is roughly same time each year +/- > few weeks), that *might* have been early enough to move things. That's unfair.

Re: [Mesa-dev] XDC 2017 feedback

2017-09-27 Thread Daniel Vetter
On Thu, Sep 28, 2017 at 7:36 AM, Matt Turner wrote: > On Wed, Sep 27, 2017 at 10:07 PM, Rob Clark wrote: >> If you had known of the khr dates, and brought it up in Feb (or really >> somewhat earlier, given that XDC is roughly same time each year +/- >>

[drm:drm-next 3/3] include/linux/stddef.h:7:14: error: positional initialization of field in 'struct' declared with 'designated_init' attribute

2017-09-27 Thread kbuild test robot
tree: git://people.freedesktop.org/~airlied/linux.git drm-next head: 754270c7c56292e97d0eff924a5d5d83f92add07 commit: 754270c7c56292e97d0eff924a5d5d83f92add07 [3/3] Merge branch 'drm-next-4.15' of git://people.freedesktop.org/~agd5f/linux into drm-next config: x86_64-randconfig-ne0-09281127

[drm:drm-next 3/3] drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/hwmgr.c:127:2: error: invalid initializer

2017-09-27 Thread kbuild test robot
tree: git://people.freedesktop.org/~airlied/linux.git drm-next head: 754270c7c56292e97d0eff924a5d5d83f92add07 commit: 754270c7c56292e97d0eff924a5d5d83f92add07 [3/3] Merge branch 'drm-next-4.15' of git://people.freedesktop.org/~agd5f/linux into drm-next config: x86_64-randconfig-it0-09281201

Re: [PATCH v4 03/10] drm/hisilicon/kirin: Use drm_gem_fb_create()

2017-09-27 Thread Xinliang Liu
On 24 September 2017 at 20:26, Noralf Trønnes wrote: > drm_fb_cma_create() is just a wrapper around drm_gem_fb_create() now, > so use the function directly. > > Cc: Xinliang Liu > Cc: Rongrong Zou > Cc: Xinwei Kong

Re: [PATCH] drm/rockchip: Fix memory leak in rockchip_drm_sys_resume()

2017-09-27 Thread jeffy
Hi Sean, On 09/28/2017 04:27 AM, Sean Paul wrote: >@@ -299,6 +300,7 @@ static int rockchip_drm_sys_resume(struct device *dev) > >priv = drm->dev_private; >drm_atomic_helper_resume(drm, priv->state); >+ drm_atomic_state_put(priv->state); Won't this be freed for you eventually in

Re: [PATCH v2 5/8] drm/rockchip/dsi: Use DRM_DEV_ERROR instead of dev_err

2017-09-27 Thread Mark yao
On 2017年09月26日 15:55, Nickey Yang wrote: Rockchip driver has been moved to using the DRM_DEV_ERROR log messages, so change all instances of dev_err. Signed-off-by: Nickey Yang Hi Nickey Haneen Mohammed already send similar patch, and it was applied, see following

Re: [PATCH v2 1/8] drm/rockchip/dsi: correct Feedback divider setting

2017-09-27 Thread Mark yao
On 2017年09月26日 15:55, Nickey Yang wrote: This patch correct Feedback divider setting: 1、Set Feedback divider [8:5] when HIGH_PROGRAM_EN 2、Due to the use of a "by 2 pre-scaler," the range of the feedback multiplication Feedback divider is limited to even division numbers, and Feedback divider

Re: [PATCH v2 2/8] drm/rockchip/dsi: add dual mipi channel support

2017-09-27 Thread Mark yao
On 2017年09月26日 15:55, Nickey Yang wrote: This patch add dual mipi channel support: 1.add definition of dsi1 register and grf operation. 2.dsi0 and dsi1 will work in master and slave mode when driving dual mipi panel. Signed-off-by: Nickey Yang Hi Nickey Can you

Re: [PATCH] drm: Call sysfs_notify after changing drm_connector::dpms

2017-09-27 Thread Jani Nikula
On Wed, 27 Sep 2017, Karsten Wiese wrote: > 2017-09-25 15:48 GMT+02:00 Jani Nikula : > >> On Tue, 19 Sep 2017, Karsten Wiese wrote: >> > This makes poll work for the >> > /sys/class/drm/cardX/connectorY/dpms attributes.

Re: [PATCH] drm/gem: use new idr deletion interface to cleanup drm_gem_handle_delete() (fwd)

2017-09-27 Thread Julia Lawall
is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Aishwarya-Pant/drm-gem-use-new-idr-deletion-interface-to-cleanup-drm_gem_handle_delete/20170927-121819 base: git://people.freedesktop.org/~airlied/li

Re: [PATCH 02/22] drm/i915: introduce simple gemfs

2017-09-27 Thread Joonas Lahtinen
On Tue, 2017-09-26 at 23:34 +0200, Greg Kroah-Hartman wrote: > On Tue, Sep 26, 2017 at 04:21:47PM +0300, Joonas Lahtinen wrote: > > On Tue, 2017-09-26 at 09:52 +0200, Greg Kroah-Hartman wrote: > > > On Mon, Sep 25, 2017 at 07:47:17PM +0100, Matthew Auld wrote: > > > > Not a fully blown gemfs, just

Re: [PATCH 1/2] drm/dp: Add defines for latency in sink

2017-09-27 Thread Puthikorn Voravootivat
On Mon, Sep 25, 2017 at 10:11 PM, Daniel Vetter wrote: > On Thu, Sep 21, 2017 at 07:42:07AM -0700, Rodrigo Vivi wrote: > > On Wed, Sep 20, 2017 at 02:32:34PM +, vathsala nagaraju wrote: > > > Add defines for dpcd register 2009 (synchronization latency > > > in sink). > > > >

[PATCH] drm/doc: Remove todo item about "This is gross" comment

2017-09-27 Thread Haneen Mohammed
This patch remove the todo item "Use new IDR deletion interface to clean up drm_gem_handle_delete()" after it has been resolved with the commit "drm: Remove obsolete "This is gross" comment". Signed-off-by: Haneen Mohammed --- Documentation/gpu/todo.rst | 6 -- 1

Re: [PATCH] drm/nouveau/fbcon: fix oops without fbdev emulation

2017-09-27 Thread Pavel Roskin
Hi Daniel, I meant Linux 4.13 of course, sorry! Can you fix the description for me please? If not, I can resend the patch with the updated description. Let me add some context to my patch. My laptop is Dell Precision 7510 with dual graphics (Intel and Nvidia). The dock is connected to two

[PATCH] drm/core: clean up references to drm_dev_unref()

2017-09-27 Thread Aishwarya Pant
This is a continuation of a previous commit ("drm: introduce drm_dev_{get/put} functions") to replace all references to drm_dev_unref() in drm core files with drm_dev_put(). Signed-off-by: Aishwarya Pant --- This patch is on top of branch drm-misc-next of drm-misc tree. I

Re: [PATCH 1/2] drm/dp: Add defines for latency in sink

2017-09-27 Thread Puthikorn Voravootivat
On Tue, Sep 26, 2017 at 10:37 AM, Puthikorn Voravootivat < put...@chromium.org> wrote: > > > On Mon, Sep 25, 2017 at 10:11 PM, Daniel Vetter wrote: > >> On Thu, Sep 21, 2017 at 07:42:07AM -0700, Rodrigo Vivi wrote: >> > On Wed, Sep 20, 2017 at 02:32:34PM +, vathsala nagaraju

[PATCH] drm/armada: Remove unused #include

2017-09-27 Thread Haneen Mohammed
Remove drmP.h as it is not needed anymore since nothing it defines is used in these files. Signed-off-by: Haneen Mohammed --- drivers/gpu/drm/armada/armada_510.c | 1 - drivers/gpu/drm/armada/armada_drv.c | 1 - drivers/gpu/drm/armada/armada_fb.c| 1 -

Re: [Outreachy kernel] [RESEND PATCH] drm: Remove obsolete "This is gross" comment

2017-09-27 Thread Haneen Mohammed
On Tue, Sep 26, 2017 at 07:24:38AM +0200, Daniel Vetter wrote: > On Thu, Sep 21, 2017 at 03:04:24PM -0600, Haneen Mohammed wrote: > > Remove obsolete comment which was initially added in 2008 to annotate > > that idr_find() was used before idr_remove() since idr_remove() didn't > > use to return

[PATCH] drm/nouveau/fbcon: fix oops without fbdev emulation

2017-09-27 Thread Pavel Roskin
This is similar to an earlier commit 52dfcc5ccfbb ("drm/nouveau: fix for disabled fbdev emulation"), but protects all other occurrences of helper.fbdev in the source. I see an oops in nouveau_fbcon_accel_save_disable() called from nouveau_fbcon_set_suspend_work() on Linux 4.13 and 4.14-rc2 when

[PATCH 1/2] drm/atomic: Remove unneeded null check for private objects

2017-09-27 Thread Maarten Lankhorst
It can be seen in drm_atomic_get_private_obj_state() that ptr will never be NULL, so skip the check for that case. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/drm_atomic.c | 3 --- include/drm/drm_atomic.h | 9 +++-- 2 files changed, 3

[PATCH 2/2] drm/atomic: Make atomic iterators less surprising

2017-09-27 Thread Maarten Lankhorst
Commit 669c9215afea ("drm/atomic: Make async plane update checks work as intended, v2.") assumed incorrectly that if only 1 plane is matched in the loop, the variables will be set to that plane. In reality we reset them to NULL every time a new plane was iterated. This behavior is surprising, so

Re: [Outreachy kernel] [PATCH] drm/doc: Remove todo item about "This is gross" comment

2017-09-27 Thread Daniel Vetter
On Tue, Sep 26, 2017 at 03:08:35PM -0600, Haneen Mohammed wrote: > This patch remove the todo item "Use new IDR deletion interface to > clean up drm_gem_handle_delete()" after it has been resolved with > the commit "drm: Remove obsolete "This is gross" comment". > > Signed-off-by: Haneen Mohammed

Re: [PATCH] drm: Call sysfs_notify after changing drm_connector::dpms

2017-09-27 Thread Daniel Vetter
On Wed, Sep 27, 2017 at 12:29:46AM +0200, Karsten Wiese wrote: > 2017-09-25 15:48 GMT+02:00 Jani Nikula : > > > On Tue, 19 Sep 2017, Karsten Wiese wrote: > > > This makes poll work for the > > > /sys/class/drm/cardX/connectorY/dpms attributes.

Re: [PATCH v2] drm/tinydrm: Move backlight helpers to a separate file

2017-09-27 Thread Daniel Vetter
On Tue, Sep 26, 2017 at 03:53:33PM +0200, Noralf Trønnes wrote: > > Den 26.09.2017 15.06, skrev Noralf Trønnes: > > > > Den 26.09.2017 13.32, skrev Daniel Vetter: > > > On Tue, Sep 26, 2017 at 04:46:53PM +0530, Meghana Madhyastha wrote: > > > > On Mon, Sep 25, 2017 at 06:31:58PM +0200, Noralf

Re: [PATCH] drm/nouveau/fbcon: fix oops without fbdev emulation

2017-09-27 Thread Daniel Vetter
On Tue, Sep 26, 2017 at 12:28:27PM -0700, Pavel Roskin wrote: > This is similar to an earlier commit 52dfcc5ccfbb ("drm/nouveau: fix for > disabled fbdev emulation"), but protects all other occurrences of > helper.fbdev in the source. > > I see an oops in nouveau_fbcon_accel_save_disable() called

Re: [Outreachy kernel] [PATCH] drm/core: clean up references to drm_dev_unref()

2017-09-27 Thread Daniel Vetter
On Tue, Sep 26, 2017 at 10:34:00PM +0530, Aishwarya Pant wrote: > This is a continuation of a previous commit ("drm: introduce drm_dev_{get/put} > functions") to replace all references to drm_dev_unref() in drm core files > with > drm_dev_put(). > > Signed-off-by: Aishwarya Pant

Re: [PATCH 8/8] phy: rockchip: add inno hdmi phy to makefile

2017-09-27 Thread kbuild test robot
Hi Algea, [auto build test ERROR on rockchip/for-next] [also build test ERROR on v4.14-rc2 next-20170927] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Algea-Cao/drm-rockchip-dw_hdmi-update

[PATCH 1/3] dim: redo the author sob checks

2017-09-27 Thread Daniel Vetter
This reverts commit 41dddc0287bb9ef14be8de3c3185ed6aaa809d98 and then tries a different approach because from the commit that originally introduced this: commit 3dd25f235c73f7855dc570585eb2551961a1911a Author: Benjamin Gaignard Date: Wed Jul 26 14:07:49 2017 +0200

[PATCH 3/3] dim: add drm-amd.git

2017-09-27 Thread Daniel Vetter
Unfortunately there's a little bit of hardcoded stuff still. Cc: Alex Deucher Cc: Harry Wentland Signed-off-by: Daniel Vetter --- dim | 1 + 1 file changed, 1 insertion(+) diff --git a/dim b/dim index

[PATCH 2/3] dim: auto-add remotes

2017-09-27 Thread Daniel Vetter
Well, bother to at least prompt. Prep work for adding drm-amd.git. Signed-off-by: Daniel Vetter --- dim | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/dim b/dim index 4d75c7a7fb0e..6ebbad2b6dfd 100755 --- a/dim +++ b/dim @@ -274,7 +274,14 @@

Re: [maintainer-tools PATCH] dim: fix remote repository lookup function

2017-09-27 Thread Andrzej Hajda
On 25.08.2017 13:31, Andrzej Hajda wrote: > dim finds remote name by matching repository urls, but different users > requires different protocols/paths for remotes (ssh/git/https). Current > code incorrectly translates provided url to alternatives, the patch > fixes it. > > Signed-off-by: Andrzej

Re: [PATCH 1/2] drm/atomic: Remove unneeded null check for private objects

2017-09-27 Thread Daniel Vetter
On Wed, Sep 27, 2017 at 10:35:31AM +0200, Maarten Lankhorst wrote: > It can be seen in drm_atomic_get_private_obj_state() that > ptr will never be NULL, so skip the check for that case. > > Signed-off-by: Maarten Lankhorst Reviewed-by: Daniel Vetter

Re: [PATCH 2/2] drm/atomic: Make atomic iterators less surprising

2017-09-27 Thread Daniel Vetter
On Wed, Sep 27, 2017 at 10:35:32AM +0200, Maarten Lankhorst wrote: > Commit 669c9215afea ("drm/atomic: Make async plane update checks work as > intended, v2.") assumed incorrectly that if only 1 plane is matched in > the loop, the variables will be set to that plane. In reality we reset > them to

Re: [PATCH] drm: Call sysfs_notify after changing drm_connector::dpms

2017-09-27 Thread Karsten Wiese
2017-09-27 9:18 GMT+02:00 Jani Nikula : > On Wed, 27 Sep 2017, Karsten Wiese wrote: > > 2017-09-25 15:48 GMT+02:00 Jani Nikula : > > > >> On Tue, 19 Sep 2017, Karsten Wiese wrote: > >> > This

[PATCH] drm/amd: DC pull request review

2017-09-27 Thread Daniel Vetter
Ok, here's one more attempt at scrolling through 130k diff. Overall verdict from me is that DC is big project, and like any big project it's never done. So at least for me the goal isn't to make things perfect, becaue if that's the hoop to jump through we wouldn't have any gpu drivers at all.

Re: [PATCH 8/8] phy: rockchip: add inno hdmi phy to makefile

2017-09-27 Thread kbuild test robot
Hi Algea, [auto build test ERROR on rockchip/for-next] [also build test ERROR on v4.14-rc2 next-20170927] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Algea-Cao/drm-rockchip-dw_hdmi-update

Re: [PATCH] drm: Call sysfs_notify after changing drm_connector::dpms

2017-09-27 Thread Karsten Wiese
2017-09-27 10:45 GMT+02:00 Daniel Vetter : > On Wed, Sep 27, 2017 at 12:29:46AM +0200, Karsten Wiese wrote: > > 2017-09-25 15:48 GMT+02:00 Jani Nikula : > > > > > On Tue, 19 Sep 2017, Karsten Wiese wrote: > > > > This makes

[PATCH] drm/Documentation: Refine TODO for backlight helpers in tinydrm

2017-09-27 Thread Meghana Madhyastha
Add a summary which resulted from discussions on what should be done to refactor backlight helpers in tinydrm so that they can be used in other drivers as well. Signed-off-by: Meghana Madhyastha --- Documentation/gpu/todo.rst | 11 ++- 1 file changed, 10

Re: [PATCH v2] drm/tinydrm: Move backlight helpers to a separate file

2017-09-27 Thread Meghana Madhyastha
On Wed, Sep 27, 2017 at 10:49:15AM +0200, Daniel Vetter wrote: > On Tue, Sep 26, 2017 at 03:53:33PM +0200, Noralf Trønnes wrote: > > > > Den 26.09.2017 15.06, skrev Noralf Trønnes: > > > > > > Den 26.09.2017 13.32, skrev Daniel Vetter: > > > > On Tue, Sep 26, 2017 at 04:46:53PM +0530, Meghana

Re: [PATCH 1/8] etnaviv: remove iommu fault handler

2017-09-27 Thread Wladimir J. van der Laan
On Fri, Sep 15, 2017 at 07:04:32PM +0200, Lucas Stach wrote: > The handler has never been used, so it's really just dead code. > > Signed-off-by: Lucas Stach Reviewed-by: Wladimir J. van der Laan > --- > drivers/gpu/drm/etnaviv/etnaviv_mmu.c | 9

Re: [PATCH 3/8] etnaviv: iommuv1: fold pagetable alloc and free into caller

2017-09-27 Thread Wladimir J. van der Laan
On Fri, Sep 15, 2017 at 07:04:34PM +0200, Lucas Stach wrote: > Those functions are simple enough to fold them into the calling > function. This also fixes a correctness issue, as the alloc/free > functions didn't specifiy the device the memory was allocated for. > > Signed-off-by: Lucas Stach

Re: [PATCH 4/8] etnaviv: iommuv1: remove map_lock

2017-09-27 Thread Wladimir J. van der Laan
On Fri, Sep 15, 2017 at 07:04:35PM +0200, Lucas Stach wrote: > It wasn't protecting anything, as the single word writes used to > set up or tear down a translation are already inherently atomic, > so the spinlock is pure overhead. > > Signed-off-by: Lucas Stach

Re: [PATCH 2/8] etnaviv: remove iova_to_phys iommu ops

2017-09-27 Thread Wladimir J. van der Laan
On Fri, Sep 15, 2017 at 07:04:33PM +0200, Lucas Stach wrote: > They are not used in any way, so can go away. > > Signed-off-by: Lucas Stach Reviewed-by: Wladimir J. van der Laan > --- > drivers/gpu/drm/etnaviv/etnaviv_iommu.c| 21

Re: [PATCH 5/8] etnaviv: iommuv1: fold pgtable_write into callers

2017-09-27 Thread Wladimir J. van der Laan
On Fri, Sep 15, 2017 at 07:04:36PM +0200, Lucas Stach wrote: > A function doing a single assignment is not really helping the > code flow. > > Signed-off-by: Lucas Stach agreed. Reviewed-by: Wladimir J. van der Laan > --- >

Re: [PATCH 6/8] etnaviv: mmu: stop using iommu map/unmap functions

2017-09-27 Thread Wladimir J. van der Laan
On Fri, Sep 15, 2017 at 07:04:37PM +0200, Lucas Stach wrote: > This is a preparation to remove the etnaviv dependency on the IOMMU > subsystem by importing the relevant parts of the iommu map/unamp > functions into the driver. > > Signed-off-by: Lucas Stach Reviewed-by:

Re: [PATCH 7/8] etnaviv: mmu: mark local functions static

2017-09-27 Thread Wladimir J. van der Laan
On Fri, Sep 15, 2017 at 07:04:38PM +0200, Lucas Stach wrote: > And clean up the header file a bit. > > Signed-off-by: Lucas Stach Reviewed-by: Wladimir J. van der Laan > --- > drivers/gpu/drm/etnaviv/etnaviv_mmu.c | 8 >

Re: [PATCH 8/8] etnaviv: remove IOMMU dependency

2017-09-27 Thread Wladimir J. van der Laan
On Fri, Sep 15, 2017 at 07:04:39PM +0200, Lucas Stach wrote: > Using the IOMMU API to manage the internal GPU MMU has been an > historical accident and it keeps getting in the way, as well as > entangling the driver with the inner workings of the IOMMU > subsystem. > > Clean this up by removing

Re: [PATCH] drm: Call sysfs_notify after changing drm_connector::dpms

2017-09-27 Thread Daniel Vetter
On Wed, Sep 27, 2017 at 12:20:21PM +0200, Karsten Wiese wrote: > 2017-09-27 9:18 GMT+02:00 Jani Nikula : > > > On Wed, 27 Sep 2017, Karsten Wiese wrote: > > > 2017-09-25 15:48 GMT+02:00 Jani Nikula : > > > > > >> On

[PATCH hwc v2 4/6] drm_hwcomposer: Add FENCE_OUT_PTR property to DrmCrtc

2017-09-27 Thread Robert Foss
Add support for handling the FENCE_OUT_PTR property to DrmCrtc Signed-off-by: Robert Foss --- drmcrtc.cpp | 10 ++ drmcrtc.h | 2 ++ 2 files changed, 12 insertions(+) diff --git a/drmcrtc.cpp b/drmcrtc.cpp index 1fbdc12..c139869 100644 --- a/drmcrtc.cpp

[PATCH hwc v2 6/6] drm_hwcomposer: Add out-fence support

2017-09-27 Thread Robert Foss
Add support for out-fences through the OUT_FENCE_PTR property. Out-fences signal when their associated buffer may be read by a device. Signed-off-by: Robert Foss --- Changes since v1: Sergi Granell - Set atomic property to be out_fences[crtc->pipe()] not

[PATCH hwc v2 5/6] drm_hwcomposer: Add GetCrtcCount function

2017-09-27 Thread Robert Foss
This GetCrtrcCount helper functions enables convenient fetching of the number of Crtcs from DrmResources. Signed-off-by: Robert Foss --- drmresources.cpp | 4 drmresources.h | 1 + 2 files changed, 5 insertions(+) diff --git a/drmresources.cpp

[PATCH hwc v2 3/6] drm_hwcomposer: Submit in-fence to DRM

2017-09-27 Thread Robert Foss
Add support for in-fences through the IN_FENCE_FD property. In-fences signal when their associated buffer may be read by DRM/KMS. Signed-off-by: Robert Foss --- drmdisplaycompositor.cpp | 35 --- 1 file changed, 16 insertions(+), 19

[PATCH hwc v2 0/6] Implement fencing

2017-09-27 Thread Robert Foss
This series removes the old thread-based synchronization utilities and replaces them with fences. It has been tested on various platforms, including etnaviv/freedreno/virgl. Robert Foss (5): drm_hwcomposer: Add support for IN_FENCE_FD property to DrmPlane drm_hwcomposer: Submit in-fence to

  1   2   >