Re: [PATCH v2 2/8] drm/rockchip/dsi: add dual mipi channel support

2017-09-27 Thread Mark yao
On 2017年09月26日 15:55, Nickey Yang wrote: This patch add dual mipi channel support: 1.add definition of dsi1 register and grf operation. 2.dsi0 and dsi1 will work in master and slave mode when driving dual mipi panel. Signed-off-by: Nickey Yang Hi Nickey Can you rebase your patches to drm-misc

Re: [PATCH] drm: Call sysfs_notify after changing drm_connector::dpms

2017-09-27 Thread Jani Nikula
On Wed, 27 Sep 2017, Karsten Wiese wrote: > 2017-09-25 15:48 GMT+02:00 Jani Nikula : > >> On Tue, 19 Sep 2017, Karsten Wiese wrote: >> > This makes poll work for the >> > /sys/class/drm/cardX/connectorY/dpms attributes. >> >> I guess the question is, what are you trying to achieve? What is the >>

Re: [PATCH] drm/gem: use new idr deletion interface to cleanup drm_gem_handle_delete() (fwd)

2017-09-27 Thread Julia Lawall
leanup-drm_gem_handle_delete/20170927-121819 base: git://people.freedesktop.org/~airlied/linux.git drm-next :: branch date: 3 hours ago :: commit date: 3 hours ago >> drivers/gpu/drm/drm_gem.c:287:2-8: preceding lock on line 284 # https://github.com/0day-ci/

Re: [PATCH 02/22] drm/i915: introduce simple gemfs

2017-09-27 Thread Joonas Lahtinen
On Tue, 2017-09-26 at 23:34 +0200, Greg Kroah-Hartman wrote: > On Tue, Sep 26, 2017 at 04:21:47PM +0300, Joonas Lahtinen wrote: > > On Tue, 2017-09-26 at 09:52 +0200, Greg Kroah-Hartman wrote: > > > On Mon, Sep 25, 2017 at 07:47:17PM +0100, Matthew Auld wrote: > > > > Not a fully blown gemfs, just

Re: [PATCH 1/2] drm/dp: Add defines for latency in sink

2017-09-27 Thread Puthikorn Voravootivat
On Mon, Sep 25, 2017 at 10:11 PM, Daniel Vetter wrote: > On Thu, Sep 21, 2017 at 07:42:07AM -0700, Rodrigo Vivi wrote: > > On Wed, Sep 20, 2017 at 02:32:34PM +, vathsala nagaraju wrote: > > > Add defines for dpcd register 2009 (synchronization latency > > > in sink). > > > > > > Cc: Rodrigo V

[PATCH] drm/doc: Remove todo item about "This is gross" comment

2017-09-27 Thread Haneen Mohammed
This patch remove the todo item "Use new IDR deletion interface to clean up drm_gem_handle_delete()" after it has been resolved with the commit "drm: Remove obsolete "This is gross" comment". Signed-off-by: Haneen Mohammed --- Documentation/gpu/todo.rst | 6 -- 1 file changed, 6 deletions(-)

Re: [PATCH] drm/nouveau/fbcon: fix oops without fbdev emulation

2017-09-27 Thread Pavel Roskin
Hi Daniel, I meant Linux 4.13 of course, sorry! Can you fix the description for me please? If not, I can resend the patch with the updated description. Let me add some context to my patch. My laptop is Dell Precision 7510 with dual graphics (Intel and Nvidia). The dock is connected to two monitor

[PATCH] drm/core: clean up references to drm_dev_unref()

2017-09-27 Thread Aishwarya Pant
This is a continuation of a previous commit ("drm: introduce drm_dev_{get/put} functions") to replace all references to drm_dev_unref() in drm core files with drm_dev_put(). Signed-off-by: Aishwarya Pant --- This patch is on top of branch drm-misc-next of drm-misc tree. I hope that's the right on

Re: [PATCH 1/2] drm/dp: Add defines for latency in sink

2017-09-27 Thread Puthikorn Voravootivat
On Tue, Sep 26, 2017 at 10:37 AM, Puthikorn Voravootivat < put...@chromium.org> wrote: > > > On Mon, Sep 25, 2017 at 10:11 PM, Daniel Vetter wrote: > >> On Thu, Sep 21, 2017 at 07:42:07AM -0700, Rodrigo Vivi wrote: >> > On Wed, Sep 20, 2017 at 02:32:34PM +, vathsala nagaraju wrote: >> > > Add

[PATCH] drm/armada: Remove unused #include

2017-09-27 Thread Haneen Mohammed
Remove drmP.h as it is not needed anymore since nothing it defines is used in these files. Signed-off-by: Haneen Mohammed --- drivers/gpu/drm/armada/armada_510.c | 1 - drivers/gpu/drm/armada/armada_drv.c | 1 - drivers/gpu/drm/armada/armada_fb.c| 1 - drivers/gpu/drm/armada/armada_fbdev

Re: [Outreachy kernel] [RESEND PATCH] drm: Remove obsolete "This is gross" comment

2017-09-27 Thread Haneen Mohammed
On Tue, Sep 26, 2017 at 07:24:38AM +0200, Daniel Vetter wrote: > On Thu, Sep 21, 2017 at 03:04:24PM -0600, Haneen Mohammed wrote: > > Remove obsolete comment which was initially added in 2008 to annotate > > that idr_find() was used before idr_remove() since idr_remove() didn't > > use to return fe

[PATCH] drm/nouveau/fbcon: fix oops without fbdev emulation

2017-09-27 Thread Pavel Roskin
This is similar to an earlier commit 52dfcc5ccfbb ("drm/nouveau: fix for disabled fbdev emulation"), but protects all other occurrences of helper.fbdev in the source. I see an oops in nouveau_fbcon_accel_save_disable() called from nouveau_fbcon_set_suspend_work() on Linux 4.13 and 4.14-rc2 when CO

[PATCH 1/2] drm/atomic: Remove unneeded null check for private objects

2017-09-27 Thread Maarten Lankhorst
It can be seen in drm_atomic_get_private_obj_state() that ptr will never be NULL, so skip the check for that case. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/drm_atomic.c | 3 --- include/drm/drm_atomic.h | 9 +++-- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a

[PATCH 2/2] drm/atomic: Make atomic iterators less surprising

2017-09-27 Thread Maarten Lankhorst
Commit 669c9215afea ("drm/atomic: Make async plane update checks work as intended, v2.") assumed incorrectly that if only 1 plane is matched in the loop, the variables will be set to that plane. In reality we reset them to NULL every time a new plane was iterated. This behavior is surprising, so fi

Re: [Outreachy kernel] [PATCH] drm/doc: Remove todo item about "This is gross" comment

2017-09-27 Thread Daniel Vetter
On Tue, Sep 26, 2017 at 03:08:35PM -0600, Haneen Mohammed wrote: > This patch remove the todo item "Use new IDR deletion interface to > clean up drm_gem_handle_delete()" after it has been resolved with > the commit "drm: Remove obsolete "This is gross" comment". > > Signed-off-by: Haneen Mohammed

Re: [PATCH] drm: Call sysfs_notify after changing drm_connector::dpms

2017-09-27 Thread Daniel Vetter
On Wed, Sep 27, 2017 at 12:29:46AM +0200, Karsten Wiese wrote: > 2017-09-25 15:48 GMT+02:00 Jani Nikula : > > > On Tue, 19 Sep 2017, Karsten Wiese wrote: > > > This makes poll work for the > > > /sys/class/drm/cardX/connectorY/dpms attributes. > > > > I guess the question is, what are you trying

Re: [PATCH v2] drm/tinydrm: Move backlight helpers to a separate file

2017-09-27 Thread Daniel Vetter
On Tue, Sep 26, 2017 at 03:53:33PM +0200, Noralf Trønnes wrote: > > Den 26.09.2017 15.06, skrev Noralf Trønnes: > > > > Den 26.09.2017 13.32, skrev Daniel Vetter: > > > On Tue, Sep 26, 2017 at 04:46:53PM +0530, Meghana Madhyastha wrote: > > > > On Mon, Sep 25, 2017 at 06:31:58PM +0200, Noralf Trø

Re: [PATCH] drm/nouveau/fbcon: fix oops without fbdev emulation

2017-09-27 Thread Daniel Vetter
On Tue, Sep 26, 2017 at 12:28:27PM -0700, Pavel Roskin wrote: > This is similar to an earlier commit 52dfcc5ccfbb ("drm/nouveau: fix for > disabled fbdev emulation"), but protects all other occurrences of > helper.fbdev in the source. > > I see an oops in nouveau_fbcon_accel_save_disable() called

Re: [Outreachy kernel] [PATCH] drm/core: clean up references to drm_dev_unref()

2017-09-27 Thread Daniel Vetter
On Tue, Sep 26, 2017 at 10:34:00PM +0530, Aishwarya Pant wrote: > This is a continuation of a previous commit ("drm: introduce drm_dev_{get/put} > functions") to replace all references to drm_dev_unref() in drm core files > with > drm_dev_put(). > > Signed-off-by: Aishwarya Pant > --- > This pat

Re: [PATCH 8/8] phy: rockchip: add inno hdmi phy to makefile

2017-09-27 Thread kbuild test robot
Hi Algea, [auto build test ERROR on rockchip/for-next] [also build test ERROR on v4.14-rc2 next-20170927] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Algea-Cao/drm-rockchip-dw_hdmi-update

[PATCH 1/3] dim: redo the author sob checks

2017-09-27 Thread Daniel Vetter
This reverts commit 41dddc0287bb9ef14be8de3c3185ed6aaa809d98 and then tries a different approach because from the commit that originally introduced this: commit 3dd25f235c73f7855dc570585eb2551961a1911a Author: Benjamin Gaignard Date: Wed Jul 26 14:07:49 2017 +0200 dim: add checks for autho

[PATCH 3/3] dim: add drm-amd.git

2017-09-27 Thread Daniel Vetter
Unfortunately there's a little bit of hardcoded stuff still. Cc: Alex Deucher Cc: Harry Wentland Signed-off-by: Daniel Vetter --- dim | 1 + 1 file changed, 1 insertion(+) diff --git a/dim b/dim index 6ebbad2b6dfd..63ffebe14781 100755 --- a/dim +++ b/dim @@ -761,6 +761,7 @@ function dim_push_

[PATCH 2/3] dim: auto-add remotes

2017-09-27 Thread Daniel Vetter
Well, bother to at least prompt. Prep work for adding drm-amd.git. Signed-off-by: Daniel Vetter --- dim | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/dim b/dim index 4d75c7a7fb0e..6ebbad2b6dfd 100755 --- a/dim +++ b/dim @@ -274,7 +274,14 @@ function url_to_remote #

Re: [maintainer-tools PATCH] dim: fix remote repository lookup function

2017-09-27 Thread Andrzej Hajda
On 25.08.2017 13:31, Andrzej Hajda wrote: > dim finds remote name by matching repository urls, but different users > requires different protocols/paths for remotes (ssh/git/https). Current > code incorrectly translates provided url to alternatives, the patch > fixes it. > > Signed-off-by: Andrzej H

Re: [PATCH 1/2] drm/atomic: Remove unneeded null check for private objects

2017-09-27 Thread Daniel Vetter
On Wed, Sep 27, 2017 at 10:35:31AM +0200, Maarten Lankhorst wrote: > It can be seen in drm_atomic_get_private_obj_state() that > ptr will never be NULL, so skip the check for that case. > > Signed-off-by: Maarten Lankhorst Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/drm_atomic.c | 3 --

Re: [PATCH 2/2] drm/atomic: Make atomic iterators less surprising

2017-09-27 Thread Daniel Vetter
On Wed, Sep 27, 2017 at 10:35:32AM +0200, Maarten Lankhorst wrote: > Commit 669c9215afea ("drm/atomic: Make async plane update checks work as > intended, v2.") assumed incorrectly that if only 1 plane is matched in > the loop, the variables will be set to that plane. In reality we reset > them to N

Re: [PATCH] drm: Call sysfs_notify after changing drm_connector::dpms

2017-09-27 Thread Karsten Wiese
2017-09-27 9:18 GMT+02:00 Jani Nikula : > On Wed, 27 Sep 2017, Karsten Wiese wrote: > > 2017-09-25 15:48 GMT+02:00 Jani Nikula : > > > >> On Tue, 19 Sep 2017, Karsten Wiese wrote: > >> > This makes poll work for the > >> > /sys/class/drm/cardX/connectorY/dpms attributes. > >> > >> I guess the qu

[PATCH] drm/amd: DC pull request review

2017-09-27 Thread Daniel Vetter
Ok, here's one more attempt at scrolling through 130k diff. Overall verdict from me is that DC is big project, and like any big project it's never done. So at least for me the goal isn't to make things perfect, becaue if that's the hoop to jump through we wouldn't have any gpu drivers at all. More

Re: [PATCH 8/8] phy: rockchip: add inno hdmi phy to makefile

2017-09-27 Thread kbuild test robot
Hi Algea, [auto build test ERROR on rockchip/for-next] [also build test ERROR on v4.14-rc2 next-20170927] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Algea-Cao/drm-rockchip-dw_hdmi-update

Re: [PATCH] drm: Call sysfs_notify after changing drm_connector::dpms

2017-09-27 Thread Karsten Wiese
2017-09-27 10:45 GMT+02:00 Daniel Vetter : > On Wed, Sep 27, 2017 at 12:29:46AM +0200, Karsten Wiese wrote: > > 2017-09-25 15:48 GMT+02:00 Jani Nikula : > > > > > On Tue, 19 Sep 2017, Karsten Wiese wrote: > > > > This makes poll work for the > > > > /sys/class/drm/cardX/connectorY/dpms attributes

[PATCH] drm/Documentation: Refine TODO for backlight helpers in tinydrm

2017-09-27 Thread Meghana Madhyastha
Add a summary which resulted from discussions on what should be done to refactor backlight helpers in tinydrm so that they can be used in other drivers as well. Signed-off-by: Meghana Madhyastha --- Documentation/gpu/todo.rst | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) dif

Re: [PATCH v2] drm/tinydrm: Move backlight helpers to a separate file

2017-09-27 Thread Meghana Madhyastha
On Wed, Sep 27, 2017 at 10:49:15AM +0200, Daniel Vetter wrote: > On Tue, Sep 26, 2017 at 03:53:33PM +0200, Noralf Trønnes wrote: > > > > Den 26.09.2017 15.06, skrev Noralf Trønnes: > > > > > > Den 26.09.2017 13.32, skrev Daniel Vetter: > > > > On Tue, Sep 26, 2017 at 04:46:53PM +0530, Meghana Mad

Re: [PATCH 1/8] etnaviv: remove iommu fault handler

2017-09-27 Thread Wladimir J. van der Laan
On Fri, Sep 15, 2017 at 07:04:32PM +0200, Lucas Stach wrote: > The handler has never been used, so it's really just dead code. > > Signed-off-by: Lucas Stach Reviewed-by: Wladimir J. van der Laan > --- > drivers/gpu/drm/etnaviv/etnaviv_mmu.c | 9 - > 1 file changed, 9 deletions(-) >

Re: [PATCH 3/8] etnaviv: iommuv1: fold pagetable alloc and free into caller

2017-09-27 Thread Wladimir J. van der Laan
On Fri, Sep 15, 2017 at 07:04:34PM +0200, Lucas Stach wrote: > Those functions are simple enough to fold them into the calling > function. This also fixes a correctness issue, as the alloc/free > functions didn't specifiy the device the memory was allocated for. > > Signed-off-by: Lucas Stach Re

Re: [PATCH 4/8] etnaviv: iommuv1: remove map_lock

2017-09-27 Thread Wladimir J. van der Laan
On Fri, Sep 15, 2017 at 07:04:35PM +0200, Lucas Stach wrote: > It wasn't protecting anything, as the single word writes used to > set up or tear down a translation are already inherently atomic, > so the spinlock is pure overhead. > > Signed-off-by: Lucas Stach Reviewed-by: Wladimir J. van der L

Re: [PATCH 2/8] etnaviv: remove iova_to_phys iommu ops

2017-09-27 Thread Wladimir J. van der Laan
On Fri, Sep 15, 2017 at 07:04:33PM +0200, Lucas Stach wrote: > They are not used in any way, so can go away. > > Signed-off-by: Lucas Stach Reviewed-by: Wladimir J. van der Laan > --- > drivers/gpu/drm/etnaviv/etnaviv_iommu.c| 21 - > drivers/gpu/drm/etnaviv/etnaviv_io

Re: [PATCH 5/8] etnaviv: iommuv1: fold pgtable_write into callers

2017-09-27 Thread Wladimir J. van der Laan
On Fri, Sep 15, 2017 at 07:04:36PM +0200, Lucas Stach wrote: > A function doing a single assignment is not really helping the > code flow. > > Signed-off-by: Lucas Stach agreed. Reviewed-by: Wladimir J. van der Laan > --- > drivers/gpu/drm/etnaviv/etnaviv_iommu.c | 16 > 1 f

Re: [PATCH 6/8] etnaviv: mmu: stop using iommu map/unmap functions

2017-09-27 Thread Wladimir J. van der Laan
On Fri, Sep 15, 2017 at 07:04:37PM +0200, Lucas Stach wrote: > This is a preparation to remove the etnaviv dependency on the IOMMU > subsystem by importing the relevant parts of the iommu map/unamp > functions into the driver. > > Signed-off-by: Lucas Stach Reviewed-by: Wladimir J. van der Laan

Re: [PATCH 7/8] etnaviv: mmu: mark local functions static

2017-09-27 Thread Wladimir J. van der Laan
On Fri, Sep 15, 2017 at 07:04:38PM +0200, Lucas Stach wrote: > And clean up the header file a bit. > > Signed-off-by: Lucas Stach Reviewed-by: Wladimir J. van der Laan > --- > drivers/gpu/drm/etnaviv/etnaviv_mmu.c | 8 > drivers/gpu/drm/etnaviv/etnaviv_mmu.h | 8 +--- > 2 files c

Re: [PATCH 8/8] etnaviv: remove IOMMU dependency

2017-09-27 Thread Wladimir J. van der Laan
On Fri, Sep 15, 2017 at 07:04:39PM +0200, Lucas Stach wrote: > Using the IOMMU API to manage the internal GPU MMU has been an > historical accident and it keeps getting in the way, as well as > entangling the driver with the inner workings of the IOMMU > subsystem. > > Clean this up by removing th

Re: [PATCH] drm: Call sysfs_notify after changing drm_connector::dpms

2017-09-27 Thread Daniel Vetter
On Wed, Sep 27, 2017 at 12:20:21PM +0200, Karsten Wiese wrote: > 2017-09-27 9:18 GMT+02:00 Jani Nikula : > > > On Wed, 27 Sep 2017, Karsten Wiese wrote: > > > 2017-09-25 15:48 GMT+02:00 Jani Nikula : > > > > > >> On Tue, 19 Sep 2017, Karsten Wiese wrote: > > >> > This makes poll work for the > >

[PATCH hwc v2 4/6] drm_hwcomposer: Add FENCE_OUT_PTR property to DrmCrtc

2017-09-27 Thread Robert Foss
Add support for handling the FENCE_OUT_PTR property to DrmCrtc Signed-off-by: Robert Foss --- drmcrtc.cpp | 10 ++ drmcrtc.h | 2 ++ 2 files changed, 12 insertions(+) diff --git a/drmcrtc.cpp b/drmcrtc.cpp index 1fbdc12..c139869 100644 --- a/drmcrtc.cpp +++ b/drmcrtc.cpp @@ -51,6 +51

[PATCH hwc v2 6/6] drm_hwcomposer: Add out-fence support

2017-09-27 Thread Robert Foss
Add support for out-fences through the OUT_FENCE_PTR property. Out-fences signal when their associated buffer may be read by a device. Signed-off-by: Robert Foss --- Changes since v1: Sergi Granell - Set atomic property to be out_fences[crtc->pipe()] not out_fences[0] drmdisplaycompositi

[PATCH hwc v2 5/6] drm_hwcomposer: Add GetCrtcCount function

2017-09-27 Thread Robert Foss
This GetCrtrcCount helper functions enables convenient fetching of the number of Crtcs from DrmResources. Signed-off-by: Robert Foss --- drmresources.cpp | 4 drmresources.h | 1 + 2 files changed, 5 insertions(+) diff --git a/drmresources.cpp b/drmresources.cpp index 762f5ef..0578cc6 10

[PATCH hwc v2 3/6] drm_hwcomposer: Submit in-fence to DRM

2017-09-27 Thread Robert Foss
Add support for in-fences through the IN_FENCE_FD property. In-fences signal when their associated buffer may be read by DRM/KMS. Signed-off-by: Robert Foss --- drmdisplaycompositor.cpp | 35 --- 1 file changed, 16 insertions(+), 19 deletions(-) diff --git a/drmd

[PATCH hwc v2 0/6] Implement fencing

2017-09-27 Thread Robert Foss
This series removes the old thread-based synchronization utilities and replaces them with fences. It has been tested on various platforms, including etnaviv/freedreno/virgl. Robert Foss (5): drm_hwcomposer: Add support for IN_FENCE_FD property to DrmPlane drm_hwcomposer: Submit in-fence to DR

[PATCH hwc v2 1/6] drm_hwcomposer: Remove threading

2017-09-27 Thread Robert Foss
From: Sean Paul Since HWC2 doesn't require the use of threads to implement correct synchronization, remove some of these threads. Signed-off-by: Robert Foss --- Android.mk| 3 - drmcomposition.cpp| 166 drmcomposition.h

[PATCH hwc v2 2/6] drm_hwcomposer: Add support for IN_FENCE_FD property to DrmPlane

2017-09-27 Thread Robert Foss
Add support for the IN_FENCE_FD property to DrmPlane. Signed-off-by: Robert Foss --- drmplane.cpp | 8 drmplane.h | 2 ++ 2 files changed, 10 insertions(+) diff --git a/drmplane.cpp b/drmplane.cpp index c4ea722..1f739ae 100644 --- a/drmplane.cpp +++ b/drmplane.cpp @@ -126,6 +126,10 @

[PATCH] drm/rockchip: Fix memory leak in rockchip_drm_sys_resume()

2017-09-27 Thread Jeffy Chen
Free the drm_atomic_state allocated by drm_atomic_helper_suspend(). Fixes: 5a5873830972 ("drm/rockchip: Use atomic PM helpers") Signed-off-by: Jeffy Chen --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_d

Re: [PATCH] drm/Documentation: Refine TODO for backlight helpers in tinydrm

2017-09-27 Thread Daniel Vetter
On Wed, Sep 27, 2017 at 04:21:23PM +0530, Meghana Madhyastha wrote: > Add a summary which resulted from discussions on what should > be done to refactor backlight helpers in tinydrm so that > they can be used in other drivers as well. > > Signed-off-by: Meghana Madhyastha Applied, thanks. One t

Re: [PATCH] drm/Documentation: Refine TODO for backlight helpers in tinydrm

2017-09-27 Thread Meghana Madhyastha
On Wed, Sep 27, 2017 at 02:32:16PM +0200, Daniel Vetter wrote: > On Wed, Sep 27, 2017 at 04:21:23PM +0530, Meghana Madhyastha wrote: > > Add a summary which resulted from discussions on what should > > be done to refactor backlight helpers in tinydrm so that > > they can be used in other drivers as

Re: [PATCH] drm: Call sysfs_notify after changing drm_connector::dpms

2017-09-27 Thread Jani Nikula
On Wed, 27 Sep 2017, Daniel Vetter wrote: > On Wed, Sep 27, 2017 at 12:20:21PM +0200, Karsten Wiese wrote: >> 2017-09-27 9:18 GMT+02:00 Jani Nikula : >> >> > On Wed, 27 Sep 2017, Karsten Wiese wrote: >> > > 2017-09-25 15:48 GMT+02:00 Jani Nikula : >> > > >> > >> On Tue, 19 Sep 2017, Karsten Wies

[PATCH v5 0/2] staging: ion: get one device per heap

2017-09-27 Thread Benjamin Gaignard
version 5: - create a configuration flag to keep legacy Ion misc device version 4: - add a configuration flag to switch between legacy Ion misc device and one device per heap version. This change has been suggested after Laura talks at XDC 2017. version 3: - change ion_device_add_heap prototy

[PATCH v5 2/2] staging: ion: create one device entry per heap

2017-09-27 Thread Benjamin Gaignard
Instead a getting only one common device "/dev/ion" for all the heaps this patch allow to create one device entry ("/dev/ionX") per heap. Getting an entry per heap could allow to set security rules per heap and global ones for all heaps. Allocation requests will be only allowed if the mask_id matc

[PATCH v5 1/2] staging: ion: simplify ioctl args checking function

2017-09-27 Thread Benjamin Gaignard
Make arguments checking more easy to read. Signed-off-by: Benjamin Gaignard --- drivers/staging/android/ion/ion-ioctl.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/android/ion/ion-ioctl.c b/drivers/staging/android/ion/ion-ioctl.c index d9f8b14

Re: [PATCH hwc v2 1/6] drm_hwcomposer: Remove threading

2017-09-27 Thread Emil Velikov
On 27 September 2017 at 12:58, Robert Foss wrote: > 16 files changed, 93 insertions(+), 724 deletions(-) Holly smokes, that's some amazing stat. Please sir can I have some more ;-) Question - this patch removes the threading implementation, while the actual substitute lands with patches 2-6. D

Re: [PATCH] drm/amd: DC pull request review

2017-09-27 Thread Daniel Vetter
On Wed, Sep 27, 2017 at 3:47 PM, Harry Wentland wrote: > On 2017-09-27 06:15 AM, Daniel Vetter wrote: >> Ok, here's one more attempt at scrolling through 130k diff. >> +19. The DC logger is still a rather sore thing, but I know that the >> DRM_DEBUG >> +stuff just isn't up to the challenges eithe

[PATCH] drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c

2017-09-27 Thread Meghana Madhyastha
Rename tinydrm_of_find_backlight to drm_of_find_backlight and move it into drm_of.c from tinydrm-helpers.c. This is because other drivers in the drm subsystem might need to call this function. In that case and otherwise, it is better from an organizational point of view to move it into drm_of.c a

Re: [PATCH] drm/amd: DC pull request review

2017-09-27 Thread Harry Wentland
On 2017-09-27 06:15 AM, Daniel Vetter wrote: > Ok, here's one more attempt at scrolling through 130k diff. > > Overall verdict from me is that DC is big project, and like any big > project it's never done. So at least for me the goal isn't to make > things perfect, becaue if that's the hoop to jum

[PATCH] drm/vc4: Add the DRM_IOCTL_VC4_GEM_MADVISE ioctl

2017-09-27 Thread Boris Brezillon
This ioctl will allow us to purge inactive userspace buffers when the system is running out of contiguous memory. For now, the purge logic is rather dumb in that it does not try to release only the amount of BO needed to meet the last CMA alloc request but instead purges all objects placed in the

Re: [PATCH hwc v1] drm_hwcomposer: Add CONTRIBUTING file

2017-09-27 Thread Emil Velikov
Hi Rob, Glad to see this. There's a couple of suggestions that I hope you'll find worth while. On 22 September 2017 at 01:37, Robert Foss wrote: > Some basic guidelines for contributions could come in handy. > > These are copied from IGT and modified to be suitable. > > Signed-off-by: Robert Fos

Re: [PATCH] drm: Call sysfs_notify after changing drm_connector::dpms

2017-09-27 Thread Karsten Wiese
2017-09-27 14:58 GMT+02:00 Jani Nikula : > On Wed, 27 Sep 2017, Daniel Vetter wrote: > > On Wed, Sep 27, 2017 at 12:20:21PM +0200, Karsten Wiese wrote: > >> 2017-09-27 9:18 GMT+02:00 Jani Nikula : > >> > >> > On Wed, 27 Sep 2017, Karsten Wiese wrote: > >> > > 2017-09-25 15:48 GMT+02:00 Jani Niku

Re: [PATCH] drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c

2017-09-27 Thread Noralf Trønnes
Den 27.09.2017 15.54, skrev Meghana Madhyastha: Rename tinydrm_of_find_backlight to drm_of_find_backlight and move it into drm_of.c from tinydrm-helpers.c. This is because other drivers in the drm subsystem might need to call this function. In that case and otherwise, it is better from an organi

Re: [PATCH] drm: Call sysfs_notify after changing drm_connector::dpms

2017-09-27 Thread Jani Nikula
On Wed, 27 Sep 2017, Karsten Wiese wrote: > 2017-09-27 14:58 GMT+02:00 Jani Nikula : >> It still feels wrong to add sysfs notify support for just one of our >> properties, for just this one use case. In particular if the reason is >> to workaround bugs in another interface. >> > > ​Would you accep

[Bug 99553] Tracker bug for runnning OpenCL applications on Clover

2017-09-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99553 Bug 99553 depends on bug 99950, which changed state. Bug 99950 Summary: Add cl_khr_int64_base_atomics to Clover and make it work on radeonsi https://bugs.freedesktop.org/show_bug.cgi?id=99950 What|Removed |Adde

[Bug 99950] Add cl_khr_int64_base_atomics to Clover and make it work on radeonsi

2017-09-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99950 Jan Vesely changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [PATCH 1/3] dim: redo the author sob checks

2017-09-27 Thread Rodrigo Vivi
On Wed, Sep 27, 2017 at 09:48:48AM +, Daniel Vetter wrote: > This reverts commit 41dddc0287bb9ef14be8de3c3185ed6aaa809d98 and then > tries a different approach because from the commit that originally > introduced this: > > commit 3dd25f235c73f7855dc570585eb2551961a1911a > Author: Benjamin Gaig

Re: [Intel-gfx] [PATCH 2/3] dim: auto-add remotes

2017-09-27 Thread Rodrigo Vivi
On Wed, Sep 27, 2017 at 09:48:49AM +, Daniel Vetter wrote: > Well, bother to at least prompt. Prep work for adding drm-amd.git. > > Signed-off-by: Daniel Vetter > --- > dim | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/dim b/dim > index 4d75c7a7fb0e..6ebba

Re: [PATCH 3/3] dim: add drm-amd.git

2017-09-27 Thread Rodrigo Vivi
On Wed, Sep 27, 2017 at 09:48:50AM +, Daniel Vetter wrote: > Unfortunately there's a little bit of hardcoded stuff still. > > Cc: Alex Deucher > Cc: Harry Wentland > Signed-off-by: Daniel Vetter Acked-by: Rodrigo Vivi > --- > dim | 1 + > 1 file changed, 1 insertion(+) > > diff --git a

[Bug 101213] Kernel 4.11: amdgpu regression causes artifacts with OLAND amd gpu gcn 1.0

2017-09-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101213 --- Comment #7 from Francisco Lloret --- Same problem with kernel 4.12.12 i Gentoo (gentoo-sources-4.12.12) -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mail

Re: [PATCH] drm/amd: DC pull request review

2017-09-27 Thread Sean Paul
On Wed, Sep 27, 2017 at 6:15 AM, Daniel Vetter wrote: > Ok, here's one more attempt at scrolling through 130k diff. > > Overall verdict from me is that DC is big project, and like any big > project it's never done. So at least for me the goal isn't to make > things perfect, becaue if that's the ho

Re: [PATCH] drm/amd: DC pull request review

2017-09-27 Thread Daniel Vetter
On Wed, Sep 27, 2017 at 6:38 PM, Sean Paul wrote: > Any chance we can address the i2c/gpio [re-]implementations as well? It's already on the list. Part of this is code that's probably dead, the other is a bit too much layer cake still left, and the final bits are not fully using drm helpers for e

Re: [PATCH v2 4/8] drm/rockchip/dsi: correct phy parameter setting

2017-09-27 Thread Matthias Kaehlcke
Hi Nickey, El Tue, Sep 26, 2017 at 03:55:19PM +0800 Nickey Yang ha dit: > As MIPI PHY document show, icpctrl<3..0> and lpfctrl<5..0> > should depend on frequency,so fix it. > > Signed-off-by: Nickey Yang > --- > drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 98 > --

Re: [PATCH] drm/amd: DC pull request review

2017-09-27 Thread Harry Wentland
On 2017-09-27 12:48 PM, Daniel Vetter wrote: > On Wed, Sep 27, 2017 at 6:38 PM, Sean Paul wrote: >> Any chance we can address the i2c/gpio [re-]implementations as well? > > It's already on the list. Part of this is code that's probably dead, > the other is a bit too much layer cake still left, an

Re: [PATCH] drm/vc4: Add the DRM_IOCTL_VC4_GEM_MADVISE ioctl

2017-09-27 Thread Eric Anholt
Boris Brezillon writes: > This ioctl will allow us to purge inactive userspace buffers when the > system is running out of contiguous memory. > > For now, the purge logic is rather dumb in that it does not try to > release only the amount of BO needed to meet the last CMA alloc request > but inst

Re: [PATCH hwc v2 1/6] drm_hwcomposer: Remove threading

2017-09-27 Thread Robert Foss
Hey Emil, On Wed, 2017-09-27 at 14:34 +0100, Emil Velikov wrote: > On 27 September 2017 at 12:58, Robert Foss > wrote: > > >  16 files changed, 93 insertions(+), 724 deletions(-) > > Holly smokes, that's some amazing stat. > Please sir can I have some more ;-) > > Question - this patch removes

Re: [PATCH hwc v2 3/6] drm_hwcomposer: Submit in-fence to DRM

2017-09-27 Thread Sean Paul
On Wed, Sep 27, 2017 at 7:58 AM, Robert Foss wrote: > Add support for in-fences through the IN_FENCE_FD property. In-fences signal > when their associated buffer may be read by DRM/KMS. > > Signed-off-by: Robert Foss > --- > drmdisplaycompositor.cpp | 35 --- > 1

Re: [PATCH hwc v1] drm_hwcomposer: Add CONTRIBUTING file

2017-09-27 Thread Robert Foss
Hey Emil, On Wed, 2017-09-27 at 15:42 +0100, Emil Velikov wrote: > Hi Rob, > > Glad to see this. There's a couple of suggestions that I hope you'll > find worth while. > > On 22 September 2017 at 01:37, Robert Foss > wrote: > > Some basic guidelines for contributions could come in handy. > > >

Re: [PATCH 2/3] drm: rcar-du: Reject planes located fully off-screen

2017-09-27 Thread Kieran Bingham
Hi Laurent, Thankyou for the patch, This looks good, and passes the tests. On 16/08/17 00:03, Laurent Pinchart wrote: > There is no point in accepting fully off-screen planes as they won't be > displayed. Reject them in the atomic check. > > Signed-off-by: Laurent Pinchart Reviewed-by: Kieran

Re: [PATCH 3/3] drm: rcar-du: Clip planes to screen boundaries

2017-09-27 Thread Kieran Bingham
Hi Laurent, Thanks for the patch, On 16/08/17 00:03, Laurent Pinchart wrote: > Unlike the KMS API, the hardware doesn't support planes exceeding the > screen boundaries. Clip plane coordinates to support the use case. > > Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham > --- > d

Re: [PATCH hwc v2 3/6] drm_hwcomposer: Submit in-fence to DRM

2017-09-27 Thread Robert Foss
Hey Sean, On Wed, 2017-09-27 at 14:55 -0400, Sean Paul wrote: > On Wed, Sep 27, 2017 at 7:58 AM, Robert Foss om> wrote: > > Add support for in-fences through the IN_FENCE_FD property. In- > > fences signal > > when their associated buffer may be read by DRM/KMS. > > > > Signed-off-by: Robert Fos

Re: [PATCH hwc v2 6/6] drm_hwcomposer: Add out-fence support

2017-09-27 Thread Sean Paul
On Wed, Sep 27, 2017 at 7:58 AM, Robert Foss wrote: > Add support for out-fences through the OUT_FENCE_PTR property. > Out-fences signal when their associated buffer may be read by a device. > > Signed-off-by: Robert Foss > --- > > Changes since v1: > Sergi Granell > - Set atomic property t

Re: [PATCH hwc v2 5/6] drm_hwcomposer: Add GetCrtcCount function

2017-09-27 Thread Sean Paul
On Wed, Sep 27, 2017 at 7:58 AM, Robert Foss wrote: > This GetCrtrcCount helper functions enables convenient > fetching of the number of Crtcs from DrmResources. > > Signed-off-by: Robert Foss > --- > drmresources.cpp | 4 > drmresources.h | 1 + > 2 files changed, 5 insertions(+) > > dif

Re: [PATCH hwc v2 1/6] drm_hwcomposer: Remove threading

2017-09-27 Thread Sean Paul
On Wed, Sep 27, 2017 at 7:58 AM, Robert Foss wrote: > From: Sean Paul > > Since HWC2 doesn't require the use of threads to implement correct > synchronization, remove some of these threads. > My SoB seems to have been dropped (or perhaps I just forgot to add it in the original thread). At any ra

Re: [PATCH hwc v2 2/6] drm_hwcomposer: Add support for IN_FENCE_FD property to DrmPlane

2017-09-27 Thread Sean Paul
On Wed, Sep 27, 2017 at 7:58 AM, Robert Foss wrote: > Add support for the IN_FENCE_FD property to DrmPlane. > > Signed-off-by: Robert Foss Reviewed-by: Sean Paul > --- > drmplane.cpp | 8 > drmplane.h | 2 ++ > 2 files changed, 10 insertions(+) > > diff --git a/drmplane.cpp b/drmpl

Re: [PATCH hwc v2 4/6] drm_hwcomposer: Add FENCE_OUT_PTR property to DrmCrtc

2017-09-27 Thread Sean Paul
On Wed, Sep 27, 2017 at 7:58 AM, Robert Foss wrote: > Add support for handling the FENCE_OUT_PTR property to DrmCrtc > > Signed-off-by: Robert Foss Reviewed-by: Sean Paul > --- > drmcrtc.cpp | 10 ++ > drmcrtc.h | 2 ++ > 2 files changed, 12 insertions(+) > > diff --git a/drmcrtc.c

[PATCH] drm/vc4: Fix pitch setup for T-format scanout.

2017-09-27 Thread Eric Anholt
The documentation said to use src_w here, and I didn't consider that we actually needed to be using pitch somewhere in our setup. Fixes scanout on my DSI panel when X11 does initial setup with 1920x1080 HDMI and 800x480 DSI both at 0,0 of the same framebuffer. Signed-off-by: Eric Anholt Fixes: 9

[PATCH v6 1/3] drm/vc4: Move the DSI clock divider workaround closer to the clock call.

2017-09-27 Thread Eric Anholt
We want the adjusted_mode->clock to be the actual clock we're expecting to program, so that consumers see the right values for clock and vrefresh. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_dsi.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers

[PATCH v6 0/3] RPi touchscreen panel resend.

2017-09-27 Thread Eric Anholt
I pushed a couple of the patches from the series, so here's what's left. I figured it was time for a resend at this point. Eric Anholt (3): drm/vc4: Move the DSI clock divider workaround closer to the clock call. dt-bindings: Document the Raspberry Pi Touchscreen nodes. drm/panel: Add s

[PATCH v6 2/3] dt-bindings: Document the Raspberry Pi Touchscreen nodes.

2017-09-27 Thread Eric Anholt
This doesn't yet cover input, but the driver does get the display working when the firmware is disabled from talking to our I2C lines. Signed-off-by: Eric Anholt Acked-by: Rob Herring --- .../panel/raspberrypi,7inch-touchscreen.txt| 49 ++ 1 file changed, 49 insertio

[PATCH v6 3/3] drm/panel: Add support for the Raspberry Pi 7" Touchscreen.

2017-09-27 Thread Eric Anholt
This driver communicates with the Atmel microcontroller for sequencing the poweron of the TC358762 DSI-DPI bridge and controlling the backlight PWM. v2: Set the same default orientation as the closed source firmware used, which is the best for viewing angle. v3: Rewrite as an i2c client driver

[PATCH 0/3] DC pull request cleanup

2017-09-27 Thread Harry Wentland
Patches to make DC use kzalloc/krealloc/kfree directly. Also updating the TODO list after a closer look at I2C in DC. Harry Wentland (3): drm/amd/display: Use kernel alloc/free drm/amd/display: Remove alloc/free macros drm/amd/display: DC I2C review drivers/gpu/drm/amd/display/TODO

[PATCH 1/3] drm/amd/display: Use kernel alloc/free

2017-09-27 Thread Harry Wentland
Abstractions are frowned upon. Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- drivers/gpu/drm/amd/display/dc/basics/logger.c | 18 --- drivers/gpu/drm/amd/display/dc/basics/vector.c | 19 +++ drivers/gpu/drm/amd/display/dc/bios/bios_

[PATCH 3/3] drm/amd/display: DC I2C review

2017-09-27 Thread Harry Wentland
While reviewing I2C in DC identified a few places. Added a couple to the TODO list. 1) Connector info read See get_ext_display_connection_info On some boards the connector information has to be read through a special I2C channel. This line is only used for this purpose and only on driver init.

[PATCH 2/3] drm/amd/display: Remove alloc/free macros

2017-09-27 Thread Harry Wentland
Now that we don't abstract kernel alloc interfaces we don't need those anymore. Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dm_services.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dm_services.h b/drivers/gpu/drm/amd/display/dc/dm_

Re: [PATCH v2 1/8] drm/rockchip/dsi: correct Feedback divider setting

2017-09-27 Thread Sean Paul
On Tue, Sep 26, 2017 at 03:55:16PM +0800, Nickey Yang wrote: > This patch correct Feedback divider setting: > 1、Set Feedback divider [8:5] when HIGH_PROGRAM_EN > 2、Due to the use of a "by 2 pre-scaler," the range of the > feedback multiplication Feedback divider is limited to even > division number

Re: [PATCH] drm/amd: DC pull request review

2017-09-27 Thread Harry Wentland
On 2017-09-27 02:12 PM, Harry Wentland wrote: > On 2017-09-27 12:48 PM, Daniel Vetter wrote: >> On Wed, Sep 27, 2017 at 6:38 PM, Sean Paul wrote: >>> Any chance we can address the i2c/gpio [re-]implementations as well? >> >> It's already on the list. Part of this is code that's probably dead, >> t

Re: [PATCH] drm/rockchip: Rely on the default best_encoder() behavior

2017-09-27 Thread Sean Paul
On Wed, Sep 27, 2017 at 12:23:17PM -0600, Haneen Mohammed wrote: > Since the output has 1:1 relationship between connectors and encoders, > and the driver is relying on the atomic helpers, remove the custom > best_encoder() and let the core call drm_atomic_helper_best_encoder(). > > Signed-off-by:

Re: [PATCH] drm/rockchip: Fix memory leak in rockchip_drm_sys_resume()

2017-09-27 Thread Sean Paul
On Wed, Sep 27, 2017 at 08:26:42PM +0800, Jeffy Chen wrote: > Free the drm_atomic_state allocated by drm_atomic_helper_suspend(). > > Fixes: 5a5873830972 ("drm/rockchip: Use atomic PM helpers") > Signed-off-by: Jeffy Chen > --- > > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 2 ++ > 1 file ch

Re: [PATCH hwc v1] drm_hwcomposer: Add CONTRIBUTING file

2017-09-27 Thread Rob Herring
On Wed, Sep 27, 2017 at 1:55 PM, Robert Foss wrote: > Hey Emil, > > On Wed, 2017-09-27 at 15:42 +0100, Emil Velikov wrote: >> Hi Rob, >> >> Glad to see this. There's a couple of suggestions that I hope you'll >> find worth while. >> >> On 22 September 2017 at 01:37, Robert Foss > > wrote: >> > Som

  1   2   >