Re: [PATCH v2 1/6] drm/msm/a6xx: Avoid freeing gmu resources multiple times

2019-05-23 Thread Jordan Crouse
On Thu, May 23, 2019 at 01:16:40PM -0400, Sean Paul wrote: > From: Sean Paul > > The driver checks for gmu->mmio as a sign that the device has been > initialized, however there are failures in probe below the mmio init. > If one of those is hit, mmio will be non-null but freed. > > In that

[PATCH] drm/mst: Fix MST sideband up-reply failure handling

2019-05-23 Thread Imre Deak
Fix the breakage resulting in the stacktrace below, due to tx queue being full when trying to send an up-reply. txmsg->seqno is -1 in this case leading to a corruption of the mstb object by txmsg->dst->tx_slots[txmsg->seqno] = NULL; in process_single_up_tx_qlock(). [ +0,005162]

[Bug 110721] graphics corruption on steam client with mesa 19.1.0 rc3 on polaris

2019-05-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110721 --- Comment #16 from Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com> --- I confirm that reverting "mesa: unreference current winsys buffers when unbinding winsys buffers" fixes the rendering issues in Spotify and Visual Studio

Re: [PATCH v15 00/17] arm64: untag user pointers passed to the kernel

2019-05-23 Thread Kees Cook
On Thu, May 23, 2019 at 06:43:46PM +0100, Catalin Marinas wrote: > On Thu, May 23, 2019 at 09:38:19AM -0700, Kees Cook wrote: > > What on this front would you be comfortable with? Given it's a new > > feature isn't it sufficient to have a CONFIG (and/or boot option)? > > I'd rather avoid

[Bug 110749] [Vega 11] [amdgpu retry page fault VM_L2_PROTECTION_FAULT_STATUS] System lock up during playing Steam version of Saints Row 3

2019-05-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110749 --- Comment #1 from Cyrax --- OS : Arch Linux with linux-next-git kernel https://aur.archlinux.org/packages/linux-next-git With latest libdrm-git, mesa-git and llvm-git packages installed. local/linux-next-git 20190523.r0.gf48b97e163b3-1

Re: [PATCH v2 2/6] drm/msm/a6xx: Remove duplicate irq disable from remove

2019-05-23 Thread Jordan Crouse
On Thu, May 23, 2019 at 01:16:41PM -0400, Sean Paul wrote: > From: Sean Paul > > a6xx_gmu_stop() already calls this function via shutdown or force_stop, > so it's not necessary to call it twice. Previously this would have > knocked the irq refcount out of sync, but now with the irqs_enabled flag

linux-next: build failure after merge of the drm-fixes tree

2019-05-23 Thread Stephen Rothwell
Hi all, After merging the drm-fixes tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function 'load_dmcu_fw': drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:667:7: error: implicit declaration of

Re: [PATCH] drm/mst: Fix MST sideband up-reply failure handling

2019-05-23 Thread Imre Deak
On Thu, May 23, 2019 at 06:09:56PM -0400, Lyude Paul wrote: > Patch mostly looks good to me, one comment below > > On Fri, 2019-05-24 at 00:24 +0300, Imre Deak wrote: > > Fix the breakage resulting in the stacktrace below, due to tx queue > > being full when trying to send an up-reply.

[PATCHv6 4/4] drm/omap: add support for manually updated displays

2019-05-23 Thread Sebastian Reichel
This adds the required infrastructure for manually updated displays, such as DSI command mode panels. While those panels often support partial updates we currently always do a full refresh. The display will be refreshed when something calls the dirty callback, such as libdrm's drmModeDirtyFB().

[PATCHv6 0/4] omapdrm: DSI command mode panel support

2019-05-23 Thread Sebastian Reichel
Hi, Here is another round of the DSI command mode panel patchset integrating the feedback from PATCHv5. The patches are based on v5.2-rc1 tag. It does not contain the patches required for OMAP3 support (it needs a workaround for a hardware bug) and for automatic display rotation. They should get

[PATCHv6 1/4] drm/omap: use DRM_DEBUG_DRIVER instead of CORE

2019-05-23 Thread Sebastian Reichel
This macro is only used by omapdrm, which should print debug messages using the DRIVER category instead of the default CORE category. Acked-by: Pavel Machek Tested-by: Tony Lindgren Tested-by: Pavel Machek Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/omap_drv.h | 4 ++-- 1

[PATCHv6 3/4] drm/omap: add framedone interrupt support

2019-05-23 Thread Sebastian Reichel
This prepares framedone interrupt handling for manual display update support. Acked-by: Pavel Machek Tested-by: Tony Lindgren Tested-by: Pavel Machek Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/omap_crtc.c | 50 +

[Bug 110712] [regression]Raven Ridge: System freeze but mouse cursor able to move when using Firefox Webrender.

2019-05-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110712 --- Comment #1 from Haxk20 --- Im have not been able to get dmesg in the past few days and will not be able to get one in upcoming few days but hopefully i will be able to get one by the end of the month. If somebody could post dmesg in the

Re: [PATCH v10 03/11] drm/sun4i: dsi: Fix video start delay computation

2019-05-23 Thread Maxime Ripard
On Mon, May 20, 2019 at 02:33:10PM +0530, Jagan Teki wrote: > The current code is computing vertical video start delay as > > delay = mode->vtotal - (mode->vsync_end - mode->vdisplay) + start; > > On which the second parameter > > mode->vsync_end - mode->vdisplay = front porch + sync timings > >

Re: [PATCH v2 3/6] drm/msm/a6xx: Check for ERR or NULL before iounmap

2019-05-23 Thread Jordan Crouse
On Thu, May 23, 2019 at 01:16:42PM -0400, Sean Paul wrote: > From: Sean Paul > > pdcptr and seqptr aren't necessarily valid, check them before trying to > unmap them. > > Changes in v2: > - None > > Cc: Jordan Crouse > Signed-off-by: Sean Paul It has always been sad to me that iounmap() has

Re: [PATCH v10 04/11] drm/sun4i: tcon: Compute DCLK dividers based on format, lanes

2019-05-23 Thread Maxime Ripard
On Mon, May 20, 2019 at 02:33:11PM +0530, Jagan Teki wrote: > pll-video => pll-mipi => tcon0 => tcon0-pixel-clock is the typical > MIPI clock topology in Allwinner DSI controller. > > TCON dotclock driver is computing the desired DCLK divider based on > panel pixel clock along with input DCLK min,

[Bug 110749] [Vega 11] [amdgpu retry page fault VM_L2_PROTECTION_FAULT_STATUS] System lock up during playing Steam version of Saints Row 3

2019-05-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110749 Bug ID: 110749 Summary: [Vega 11] [amdgpu retry page fault VM_L2_PROTECTION_FAULT_STATUS] System lock up during playing Steam version of Saints Row 3 Product: DRI

[Bug 110701] GPU faults in in Unigine Valley 1.0

2019-05-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110701 --- Comment #25 from Christoph Haag --- (In reply to Yury Zhuravlev from comment #24) > (In reply to Marek Olšák from comment #23) > > Fixed by d6053bf2a170a0fec6d232fda097d2f35f0e9eae. Closing. > > The original issue was about Vega and on

Re: [PATCH v10 02/11] drm/sun4i: dsi: Update start value in video start delay

2019-05-23 Thread Maxime Ripard
On Mon, May 20, 2019 at 02:33:09PM +0530, Jagan Teki wrote: > start value in video start delay computation done in below commit > is as per the legacy bsp drivers/video/sunxi/legacy.. > "drm/sun4i: dsi: Change the start delay calculation" > (sha1: da676c6aa6413d59ab0a80c97bbc273025e640b2) > > This

[Bug 110749] [Vega 11] [amdgpu retry page fault VM_L2_PROTECTION_FAULT_STATUS] System lock up during playing Steam version of Saints Row 3

2019-05-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110749 Cyrax changed: What|Removed |Added Priority|medium |highest -- You are receiving this mail

Re: [PATCH] drm/mst: Fix MST sideband up-reply failure handling

2019-05-23 Thread Lyude Paul
Patch mostly looks good to me, one comment below On Fri, 2019-05-24 at 00:24 +0300, Imre Deak wrote: > Fix the breakage resulting in the stacktrace below, due to tx queue > being full when trying to send an up-reply. txmsg->seqno is -1 in this > case leading to a corruption of the mstb object by

Re: [PATCH] drm/mst: Fix MST sideband up-reply failure handling

2019-05-23 Thread Lyude Paul
On Fri, 2019-05-24 at 01:28 +0300, Imre Deak wrote: > On Thu, May 23, 2019 at 06:09:56PM -0400, Lyude Paul wrote: > > Patch mostly looks good to me, one comment below > > > > On Fri, 2019-05-24 at 00:24 +0300, Imre Deak wrote: > > > Fix the breakage resulting in the stacktrace below, due to tx

[PATCHv6 2/4] drm/omap: don't check dispc timings for DSI

2019-05-23 Thread Sebastian Reichel
While most display types only forward their VM to the DISPC, this is not true for DSI. DSI calculates the VM for DISPC based on its own, but it's not identical. Actually the DSI VM is not even a valid DISPC VM making this check fail. Let's restore the old behaviour and avoid checking the DISPC VM

Re: [PATCHv6 1/4] drm/omap: use DRM_DEBUG_DRIVER instead of CORE

2019-05-23 Thread Joe Perches
On Thu, 2019-05-23 at 22:07 +0200, Sebastian Reichel wrote: > This macro is only used by omapdrm, which should print > debug messages using the DRIVER category instead of the > default CORE category. [] > diff --git a/drivers/gpu/drm/omapdrm/omap_drv.h > b/drivers/gpu/drm/omapdrm/omap_drv.h [] >

Re: [PATCH v10 01/11] drm/sun4i: dsi: Fix TCON DRQ set bits

2019-05-23 Thread Maxime Ripard
On Mon, May 20, 2019 at 02:33:08PM +0530, Jagan Teki wrote: > According to "DRM kernel-internal display mode structure" in > include/drm/drm_modes.h the current driver is trying to include > sync timings along with front porch value while checking and > computing drq set bits in non-burst mode. >

Re: [PATCH v2 5/6] drm/msm/a6xx: Drop the device reference in gmu

2019-05-23 Thread Jordan Crouse
On Thu, May 23, 2019 at 01:16:44PM -0400, Sean Paul wrote: > From: Sean Paul > > of_find_device_by_node() grabs a dev reference, so make sure we clear it > on error and remove. > > Changes in v2: > - Added to the set (Jordan) > > Cc: Jordan Crouse > Signed-off-by: Sean Paul Reviewed-by:

Re: [PATCH v2 4/6] drm/msm/a6xx: Remove devm calls from gmu driver

2019-05-23 Thread Jordan Crouse
On Thu, May 23, 2019 at 01:16:43PM -0400, Sean Paul wrote: > From: Sean Paul > > The gmu driver is initialized and cleaned up with calls from the gpu driver. > As > such, the platform device stays valid after a6xx_gmu_remove is called and the > device managed resources are not freed. In the

Re: [PATCH v2 6/6] drm/msm/a6xx: Rename a6xx_gmu_probe to a6xx_gmu_init

2019-05-23 Thread Jordan Crouse
On Thu, May 23, 2019 at 01:16:45PM -0400, Sean Paul wrote: > From: Sean Paul > > This rename makes it more clear that everything initialized in the _init > function must be cleaned up in a6xx_gmu_remove. This will hopefully > dissuade people from using device managed resources (for reasons laid

Re: [RFC][PATCH] kernel.h: Add generic roundup_64() macro

2019-05-23 Thread Linus Torvalds
On Thu, May 23, 2019 at 10:36 AM Steven Rostedt wrote: > > > > > Of course, you probably want the usual "at least use 'int'" semantics, > > in which case the "type" should be "(x)+0": > > > > #define round_up(x, y) size_fn((x)+0, round_up_size, x, y) > > > > and the 8-bit and 16-bit cases

Re: [PATCH 1/1] drm/i915: remove unused IO_TLB_SEGPAGES which should be defined by swiotlb

2019-05-23 Thread Chris Wilson
Quoting Dongli Zhang (2019-05-21 05:40:39) > This patch removes IO_TLB_SEGPAGES which is no longer used since > commit 5584f1b1d73e ("drm/i915: fix i915 running as dom0 under Xen"). > > As the define of both IO_TLB_SEGSIZE and IO_TLB_SHIFT are from swiotlb, > IO_TLB_SEGPAGES should be defined on

[Bug 110701] GPU faults in in Unigine Valley 1.0

2019-05-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110701 --- Comment #26 from Yury Zhuravlev --- (In reply to Christoph Haag from comment #25) > (In reply to Yury Zhuravlev from comment #24) > > (In reply to Marek Olšák from comment #23) > > > Fixed by d6053bf2a170a0fec6d232fda097d2f35f0e9eae.

[PATCH] drm/vmwgfx: fix a warning due to missing dma_parms

2019-05-23 Thread Qian Cai
Booting up with DMA_API_DEBUG_SG=y generates a warning below due to the driver forgot to set dma_parms appropriately. Set it after vmw_dma_masks(), so it can choose a size either DMA_BIT_MASK(64) or DMA_BIT_MASK(44). DMA-API: vmwgfx :00:0f.0: mapping sg segment longer than device claims to

[Bug 109955] amdgpu [RX Vega 64] system freeze while gaming

2019-05-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109955 --- Comment #22 from Mauro Gaspari --- I ran more tests: 1. Installed Arch Linux, vulkan, llvm8 and ran wine games with DXVK. With same kernel parameters on grub, no freezes, no crashes. Great performance. 2. Installed Ubuntu Budgie 19.04,

[git pull] drm fixes for 5.2-rc2

2019-05-23 Thread Dave Airlie
Hey Linus, Nothing too unusual here for rc2. i915: - boosting fix - bump ready task fixes - GVT - reset fix, error return, TRTT handling fix amdgpu: - DMCU firmware loading fix - Polaris 10 pci id for kfd - picasso screen corruption fix - SR-IOV fixes - vega driver reload fixes - SMU locking

Re: [PATCH 1/2] update drm.h

2019-05-23 Thread zhoucm1
anyone can pick up to gitlab for libdrm? Thanks, -David On 2019年05月22日 18:46, Koenig, Christian wrote: Am 22.05.19 um 11:07 schrieb Chunming Zhou: a) delta: only DRM_CAP_SYNCOBJ_TIMELINE b) Generated using make headers_install. c) Generated from origin/drm-misc-next commit

[Bug 110749] [Vega 11] [amdgpu retry page fault VM_L2_PROTECTION_FAULT_STATUS] System lock up during playing Steam version of Saints Row 3

2019-05-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110749 --- Comment #2 from Cyrax --- Created attachment 144338 --> https://bugs.freedesktop.org/attachment.cgi?id=144338=edit Xorg log before starting the game -- You are receiving this mail because: You are the assignee for the

RE: [PATCH 06/10] drm/ttm: fix busy memory to fail other user v10

2019-05-23 Thread Liang, Prike
Use Abaqus torturing the amdgpu driver more times will running into locking first busy BO deadlock .Then the caller will return EAGAIN and eventually dm_plane_helper_prepare_fb popups out pinned failed message .For this case, the patch#7 can we add EAGAIN as ERESTARTSYS which filter out the

[PATCH] drm_edid-load: Fix a missing-check bug in drm_load_edid_firmware()

2019-05-23 Thread Gen Zhang
In drm_load_edid_firmware(), fwstr is allocated by kstrdup(). And fwstr is dereferenced in the following codes. However, memory allocation functions such as kstrdup() may fail and returns NULL. Dereferencing this null pointer may cause the kernel go wrong. Thus we should check this kstrdup()

[PATCH] drm/komeda: Refine function to_d71_input_id

2019-05-23 Thread james qian wang (Arm Technology China)
Since the component_state->input[i] is only valid when it is active, the content of input[i] is undefined if it is inactive. The user must check the state->active_inputs with input index firstly before using state->input[i]. Refine the function to_d71_input_id and directly move such check into it.

[PATCH] drm/komeda: Accept null writeback configurations for writeback

2019-05-23 Thread james qian wang (Arm Technology China)
User may send null writeback configurations for writeback connector like: - Only bind the writeback connector to crtc. - set a fb_id(0) to writeback_fb_id_property All above configurations are meaningless for writeback, but since they are still valid configurations, accept them. Depends on: -

Re: [PATCH] drm/cirrus: remove leftover files

2019-05-23 Thread Gerd Hoffmann
On Wed, May 22, 2019 at 05:06:34PM +0200, Sam Ravnborg wrote: > On Wed, May 22, 2019 at 12:33:07PM +0200, Gerd Hoffmann wrote: > > cirrus_drv.h and cirrus_ttm.c are unused since commit ab3e023b1b4c > > ("drm/cirrus: rewrite and modernize driver"), apparently I ran "rm" > > instead of "git rm" on

Re: [PATCH 2/4] drm/virtio: remove irrelevant DRM_UNLOCKED flag

2019-05-23 Thread Gerd Hoffmann
On Wed, May 22, 2019 at 04:47:00PM +0100, Emil Velikov wrote: > From: Emil Velikov > > DRM_UNLOCKED doesn't do anything for non-legacy drivers. Remove it. Patch applied to drm-misc-next. thanks, Gerd ___ dri-devel mailing list

Re: [PATCH 06/10] drm/ttm: fix busy memory to fail other user v10

2019-05-23 Thread zhoucm1
On 2019年05月22日 20:59, Christian König wrote: [CAUTION: External Email] BOs on the LRU might be blocked during command submission and cause OOM situations. Avoid this by blocking for the first busy BO not locked by the same ticket as the BO we are searching space for. v10: completely start

Re: [PATCH v2 00/17] kunit: introduce KUnit, the Linux kernel unit testing framework

2019-05-23 Thread Daniel Vetter
On Wed, May 22, 2019 at 02:38:48PM -0700, Brendan Higgins wrote: > +Bjorn Helgaas > > On Wed, May 15, 2019 at 12:41 AM Daniel Vetter wrote: > > > > On Tue, May 14, 2019 at 11:36:18AM -0700, Brendan Higgins wrote: > > > On Tue, May 14, 2019 at 02:05:05PM +0200, Daniel Vetter wrote: > > > > On

Re: [PATCH 01/10] drm/ttm: Make LRU removal optional.

2019-05-23 Thread zhoucm1
On 2019年05月22日 20:59, Christian König wrote: [CAUTION: External Email] We are already doing this for DMA-buf imports and also for amdgpu VM BOs for quite a while now. If this doesn't run into any problems we are probably going to stop removing BOs from the LRU altogether. Signed-off-by:

[PATCH v4] drm/komeda: Add writeback support

2019-05-23 Thread james qian wang (Arm Technology China)
Komeda driver uses a individual component to describe the HW's writeback caps, but drivers doesn't define a new structure and still uses the existing "struct komeda_layer" to describe this new component. The detailed changes as follow: 1. Initialize wb_layer according to HW and report it to CORE.

Re: [PATCH 01/10] drm/ttm: Make LRU removal optional.

2019-05-23 Thread Christian König
Am 23.05.19 um 11:15 schrieb zhoucm1: On 2019年05月22日 20:59, Christian König wrote: [SNIP] @@ -203,7 +204,10 @@ void ttm_eu_fence_buffer_objects(struct ww_acquire_ctx *ticket, reservation_object_add_shared_fence(bo->resv, fence); else

[PATCH v2] drm/komeda: Added AFBC support for komeda driver

2019-05-23 Thread james qian wang (Arm Technology China)
For supporting AFBC: 1. Check if the user requested modifier can be supported by display HW. 2. Check the obj->size with AFBC's requirement. 3. Configure HW according to the modifier (afbc features) This patch depends on: - https://patchwork.freedesktop.org/series/59915/ -

Re: [Intel-gfx] [v11 00/12] Add HDR Metadata Parsing and handling in DRM layer

2019-05-23 Thread Daniel Vetter
On Thu, May 23, 2019 at 11:09:41AM +0300, Jani Nikula wrote: > On Wed, 22 May 2019, Ville Syrjälä wrote: > > Pushed the core/etc. bits to drm-misc-next so that other drivers > > can base their work on that. We'll need a backmerge to get the > > i915 stuff in via dinq. > > To avoid any confusion,

Re: [PATCH 3/5] drm/vmwgfx: use core drm to extend/check vmw_execbuf_ioctl

2019-05-23 Thread Thomas Hellstrom
On Wed, 2019-05-22 at 17:41 +0100, Emil Velikov wrote: > From: Emil Velikov > > Currently vmw_execbuf_ioctl() open-codes the permission checking, > size > extending and copying that is already done in core drm. > > Kill all the duplication, adding a few comments for clarity. > > Cc: "VMware

Re: [PATCH 5/6] dt-bindings: Add ANX6345 DP/eDP transmitter binding

2019-05-23 Thread Maxime Ripard
On Thu, May 23, 2019 at 08:54:00AM +0200, Torsten Duwe wrote: > From: Icenowy Zheng > > The anx6345 is an ultra-low power DisplayPort/eDP transmitter designed > for portable devices. > > Add a binding document for it. > > Signed-off-by: Icenowy Zheng > Signed-off-by: Vasily Khoruzhick >

Re: [PATCH 10/10] drm/amdgpu: stop removing BOs from the LRU v3

2019-05-23 Thread Christian König
Leaving BOs on the LRU is harmless. We always did this for VM page table and per VM BOs. The key point is that BOs which couldn't be reserved can't be evicted. So what happened is that an application used basically all of VRAM during CS and because of this X server couldn't pin a BO for

Re: [PATCH 1/4] drm/tegra: remove irrelevant DRM_UNLOCKED flag

2019-05-23 Thread Thierry Reding
On Wed, May 22, 2019 at 04:46:59PM +0100, Emil Velikov wrote: > From: Emil Velikov > > DRM_UNLOCKED doesn't do anything for non-legacy drivers. Remove it. > > Cc: Thierry Reding > Cc: linux-te...@vger.kernel.org > Cc: Daniel Vetter > Signed-off-by: Emil Velikov > --- >

Re: linux-next: manual merge of the drm-misc tree with Linus' tree

2019-05-23 Thread Stephen Rothwell
Hi Maxime, On Thu, 23 May 2019 10:10:22 +0200 Maxime Ripard wrote: > > Hi Stephen, > > On Tue, May 21, 2019 at 10:51:51AM +1000, Stephen Rothwell wrote: > > Hi all, > > > > Today's linux-next merge of the drm-misc tree got a conflict in: > > > >

[PULL] drm-intel-fixes

2019-05-23 Thread Joonas Lahtinen
Hi Dave & Daniel, Two scheduling fixes for to oversaturated (media transcoding scenarios) and their dependencies. On GVT side a reset robustness fix and context state restoring fix + error path fix caught by static checker. Regards, Joonas PS. As you are aware, -rc1 caused an explosion on the

<    1   2