Re: [PATCH 2/5] kernel.h: Add non_block_start/end()

2019-08-14 Thread Daniel Vetter
On Wed, Aug 14, 2019 at 08:58:05PM -0300, Jason Gunthorpe wrote: > On Wed, Aug 14, 2019 at 10:20:24PM +0200, Daniel Vetter wrote: > > In some special cases we must not block, but there's not a > > spinlock, preempt-off, irqs-off or similar critical section already > > that arms the might_sleep() de

Re: [PATCH 2/5] kernel.h: Add non_block_start/end()

2019-08-14 Thread Daniel Vetter
On Wed, Aug 14, 2019 at 01:45:58PM -0700, Andrew Morton wrote: > On Wed, 14 Aug 2019 22:20:24 +0200 Daniel Vetter > wrote: > > > In some special cases we must not block, but there's not a > > spinlock, preempt-off, irqs-off or similar critical section already > > that arms the might_sleep() debu

Re: [PATCH] dma-buf/sw_sync: Synchronize signal vs syncpt free

2019-08-14 Thread Daniel Vetter
On Wed, Aug 14, 2019 at 09:46:41PM -0400, Sasha Levin wrote: > On Wed, Aug 14, 2019 at 07:24:15PM +0200, Daniel Vetter wrote: > > Hi Sasha, > > > > On Mon, Aug 12, 2019 at 07:05:47PM +, Sasha Levin wrote: > > > Hi, > > > > > > [This is an automated email] > > > > > > This commit has been pro

Re: [PATCH 1/2] gpu: ipu-v3: enable remaining 32-bit RGB V4L2 pixel formats

2019-08-14 Thread Marco Felsch
Hi Philipp, On 19-08-14 17:10, Philipp Zabel wrote: > Support is already implemented for the corresponding DRM formats, > just hook up the remaining V4L2 pixel formats. > > Signed-off-by: Philipp Zabel > --- > drivers/gpu/ipu-v3/ipu-common.c | 16 ++-- > drivers/gpu/ipu-v3/ipu-cpmem

Re: [PATCH 3/7] Revert "ACPI / OSI: Add OEM _OSI strings to disable NVidia RTD3"

2019-08-14 Thread Karol Herbst
On Thu, Aug 15, 2019 at 1:35 AM Alex Hung wrote: > > On Wed, Aug 14, 2019 at 3:31 PM Karol Herbst wrote: > > > > This reverts commit 9251a71db62ca9cc7e7cf364218610b0f018c291. > > > > This was never discussed with anybody Nouveau related and we would have > > NACKed > > this change immediately. >

[pull] amdgpu, scheduler drm-fixes-5.3

2019-08-14 Thread Alex Deucher
Hi Dave, Daniel, A few fixes for 5.3. Nothing major. The following changes since commit d45331b00ddb179e291766617259261c112db872: Linux 5.3-rc4 (2019-08-11 13:26:41 -0700) are available in the Git repository at: git://people.freedesktop.org/~agd5f/linux tags/drm-fixes-5.3-2019-08-14 for

Re: [PATCH] dma-buf/sw_sync: Synchronize signal vs syncpt free

2019-08-14 Thread Sasha Levin
On Wed, Aug 14, 2019 at 07:24:15PM +0200, Daniel Vetter wrote: Hi Sasha, On Mon, Aug 12, 2019 at 07:05:47PM +, Sasha Levin wrote: Hi, [This is an automated email] This commit has been processed because it contains a "Fixes:" tag, fixing commit: d3862e44daa7 dma-buf/sw-sync: Fix locking ar

Re: [PATCH v2 0/2] drm/mediatek: make imported PRIME buffers contiguous

2019-08-14 Thread CK Hu
Hi, Alexandre: On Mon, 2019-07-29 at 14:33 +0900, Alexandre Courbot wrote: > The default DMA segment size was used when importing PRIME buffers, > which resulted in a chance of them not being contiguous in the virtual > IO space of the device and mtk_gem_prime_import_sg_table() complaining > that

[PATCH 09/11] ARM: dts: qcom: pm8941: add 5vs2 regulator node

2019-08-14 Thread Brian Masney
pm8941 is missing the 5vs2 regulator node so let's add it since its needed to get the external display working. This regulator was already configured in the interrupts property on the parent node. Note that this regulator is referred to as mvs2 in the downstream MSM kernel sources. Signed-off-by:

[PATCH 08/11] drm/msm/hdmi: silence -EPROBE_DEFER warning

2019-08-14 Thread Brian Masney
Silence a warning message due to an -EPROBE_DEFER error to help cleanup the system boot log. Signed-off-by: Brian Masney --- drivers/gpu/drm/msm/hdmi/hdmi_phy.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_phy.c b/drivers/gpu/drm/msm/

[PATCH 07/11] ARM: qcom_defconfig: add CONFIG_DRM_ANALOGIX_ANX78XX

2019-08-14 Thread Brian Masney
Add CONFIG_DRM_ANALOGIX_ANX78XX as a module so that the external display can be used on the Nexus 5 phones. Signed-off-by: Brian Masney --- arch/arm/configs/qcom_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/qcom_defconfig b/arch/arm/configs/qcom_defconfig index

[PATCH RFC 06/11] drm/bridge: analogix-anx78xx: add support for avdd33 regulator

2019-08-14 Thread Brian Masney
Add support for the avdd33 regulator to the analogix-anx78xx driver. Note that the regulator is currently enabled during driver probe and disabled when the driver is removed. This is currently how the downstream MSM kernel sources do this. Let's not merge this upstream for the mean time until I ge

[PATCH 03/11] drm/bridge: analogix-anx78xx: silence -EPROBE_DEFER warnings

2019-08-14 Thread Brian Masney
Silence two warning messages that occur due to -EPROBE_DEFER errors to help cleanup the system boot log. Signed-off-by: Brian Masney --- drivers/gpu/drm/bridge/analogix-anx78xx.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix-anx78xx.c

[PATCH RFC 10/11] ARM: dts: qcom: msm8974: add HDMI nodes

2019-08-14 Thread Brian Masney
Add HDMI tx and phy nodes to support an external display that can be connected over the SlimPort. This is based on work from Jonathan Marek. Signed-off-by: Brian Masney --- The hdmi-tx node in the downstream MSM sources: https://github.com/AICP/kernel_lge_hammerhead/blob/n7.1/arch/arm/boot/dts/ms

[PATCH 02/11] drm/bridge: analogix-anx78xx: add new variants

2019-08-14 Thread Brian Masney
Add support for the 7808 variant. While we're here, the of match table was missing support for the 7812 and 7818 variants, so add them as well. Signed-off-by: Brian Masney --- drivers/gpu/drm/bridge/analogix-anx78xx.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/bridge

[PATCH RFC 11/11] ARM: dts: qcom: msm8974-hammerhead: add support for external display

2019-08-14 Thread Brian Masney
Add HDMI nodes and other supporting infrastructure in order to support the external display. This is based on work from Jonathan Marek. Signed-off-by: Brian Masney --- The hdmi-tx node in the downstream MSM sources: https://github.com/AICP/kernel_lge_hammerhead/blob/n7.1/arch/arm/boot/dts/msm8974

[PATCH 05/11] drm/bridge: analogix-anx78xx: correct value of TX_P0

2019-08-14 Thread Brian Masney
When attempting to configure this driver on a Nexus 5 phone (msm8974), setting up the dummy i2c bus for TX_P0 would fail due to an -EBUSY error. The downstream MSM kernel sources [1] shows that the proper value for TX_P0 is 0x78, not 0x70, so correct the value to allow device probing to succeed. [

[PATCH 00/11] ARM: dts: qcom: msm8974: add support for external display

2019-08-14 Thread Brian Masney
This patch series begins to add support for the external display over HDMI that is supported on msm8974 SoCs. I'm testing this series on the Nexus 5, and I'm able to communicate with the HDMI bridge via the analogix-anx78xx driver, however the external display is not working yet. When I plug in th

[PATCH 01/11] dt-bindings: drm/bridge: analogix-anx78xx: add new variants

2019-08-14 Thread Brian Masney
Add support for the analogix,anx7808, analogix,anx7812, and analogix,anx7818 variants. Signed-off-by: Brian Masney --- .../devicetree/bindings/display/bridge/anx7814.txt | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/br

[PATCH 04/11] drm/bridge: analogix-anx78xx: convert to i2c_new_dummy_device

2019-08-14 Thread Brian Masney
The i2c_new_dummy() function is deprecated since it returns NULL on error. Change this to use the recommended replacement i2c_new_dummy_device() that returns an error code that can be read with PTR_ERR() and friends. Signed-off-by: Brian Masney --- drivers/gpu/drm/bridge/analogix-anx78xx.c | 15

Re: [PATCH 5/5] mm/hmm: WARN on illegal ->sync_cpu_device_pagetables errors

2019-08-14 Thread Jason Gunthorpe
On Wed, Aug 14, 2019 at 10:20:27PM +0200, Daniel Vetter wrote: > Similar to the warning in the mmu notifer, warning if an hmm mirror > callback gets it's blocking vs. nonblocking handling wrong, or if it > fails with anything else than -EAGAIN. > > Cc: Jason Gunthorpe > Cc: Ralph Campbell > Cc:

Re: [PATCH 4/5] mm, notifier: Add a lockdep map for invalidate_range_start

2019-08-14 Thread Jason Gunthorpe
On Wed, Aug 14, 2019 at 10:20:26PM +0200, Daniel Vetter wrote: > This is a similar idea to the fs_reclaim fake lockdep lock. It's > fairly easy to provoke a specific notifier to be run on a specific > range: Just prep it, and then munmap() it. > > A bit harder, but still doable, is to provoke the

Re: turn hmm migrate_vma upside down v3

2019-08-14 Thread Ralph Campbell
On 8/14/19 12:59 AM, Christoph Hellwig wrote: Hi Jérôme, Ben and Jason, below is a series against the hmm tree which starts revamping the migrate_vma functionality. The prime idea is to export three slightly lower level functions and thus avoid the need for migrate_vma_ops callbacks. Diffstat

Re: [PATCH 3/5] mm, notifier: Catch sleeping/blocking for !blockable

2019-08-14 Thread Jason Gunthorpe
On Wed, Aug 14, 2019 at 10:20:25PM +0200, Daniel Vetter wrote: > We need to make sure implementations don't cheat and don't have a > possible schedule/blocking point deeply burried where review can't > catch it. > > I'm not sure whether this is the best way to make sure all the > might_sleep() cal

Re: [PATCH 2/5] kernel.h: Add non_block_start/end()

2019-08-14 Thread Jason Gunthorpe
On Wed, Aug 14, 2019 at 10:20:24PM +0200, Daniel Vetter wrote: > In some special cases we must not block, but there's not a > spinlock, preempt-off, irqs-off or similar critical section already > that arms the might_sleep() debug checks. Add a non_block_start/end() > pair to annotate these. > > Th

Re: [PATCH v3 hmm 00/11] Add mmu_notifier_get/put for managing mmu notifier registrations

2019-08-14 Thread Ralph Campbell
On 8/6/19 4:15 PM, Jason Gunthorpe wrote: From: Jason Gunthorpe This series introduces a new registration flow for mmu_notifiers based on the idea that the user would like to get a single refcounted piece of memory for a mm, keyed to its use. For instance many users of mmu_notifiers use an in

Re: [PATCH 1/5] mm: Check if mmu notifier callbacks are allowed to fail

2019-08-14 Thread Ralph Campbell
On 8/14/19 3:14 PM, Andrew Morton wrote: On Wed, 14 Aug 2019 22:20:23 +0200 Daniel Vetter wrote: Just a bit of paranoia, since if we start pushing this deep into callchains it's hard to spot all places where an mmu notifier implementation might fail when it's not allowed to. Inspired by some

Re: [PATCH 1/5] mm: Check if mmu notifier callbacks are allowed to fail

2019-08-14 Thread Jason Gunthorpe
On Wed, Aug 14, 2019 at 03:14:47PM -0700, Andrew Morton wrote: > On Wed, 14 Aug 2019 22:20:23 +0200 Daniel Vetter > wrote: > > > Just a bit of paranoia, since if we start pushing this deep into > > callchains it's hard to spot all places where an mmu notifier > > implementation might fail when i

Re: [Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output"

2019-08-14 Thread Dave Airlie
On Thu, 15 Aug 2019 at 07:31, Karol Herbst wrote: > > This reverts commit 28586a51eea666d5531bcaef2f68e4abbd87242c. > > The original commit message didn't even make sense. AMD _does_ support it and > it works with Nouveau as well. > > Also what was the issue being solved here? No references to any

[PATCH 6/6] drm/vgem: fix cache synchronization on arm/arm64 (take two)

2019-08-14 Thread Rob Clark
From: Rob Clark drm_cflush_pages() is no-op on arm/arm64. But instead we can use arch_sync API. Fixes failures with vgem_test. Signed-off-by: Rob Clark --- drivers/gpu/drm/vgem/vgem_drv.c | 145 +--- 1 file changed, 98 insertions(+), 47 deletions(-) diff --git a/

[PATCH 5/6] drm/msm: stop abusing DMA API

2019-08-14 Thread Rob Clark
From: Rob Clark Use arch_sync_dma_for_{device,cpu}() rather than abusing the DMA API to indirectly get at the arch_sync_dma code. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 37 +++ 1 file changed, 11 insertions(+), 26 deletions(-) diff --git a

Re: [PATCH 1/5] mm: Check if mmu notifier callbacks are allowed to fail

2019-08-14 Thread Andrew Morton
On Wed, 14 Aug 2019 22:20:23 +0200 Daniel Vetter wrote: > Just a bit of paranoia, since if we start pushing this deep into > callchains it's hard to spot all places where an mmu notifier > implementation might fail when it's not allowed to. > > Inspired by some confusion we had discussing i915 m

[PATCH 4/6] arm: add arch_sync_dma_for_*()

2019-08-14 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- arch/arm/Kconfig| 2 ++ arch/arm/mm/dma-mapping-nommu.c | 14 ++ arch/arm/mm/dma-mapping.c | 28 3 files changed, 44 insertions(+) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index

[PATCH 3/6] powerpc: export arch_sync_dma_for_*()

2019-08-14 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- arch/powerpc/mm/dma-noncoherent.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/powerpc/mm/dma-noncoherent.c b/arch/powerpc/mm/dma-noncoherent.c index c617282d5b2a..80d53b950821 100644 --- a/arch/powerpc/mm/dma-noncoherent.c +++ b/arch/

[PATCH 2/6] mips: export arch_sync_dma_for_*()

2019-08-14 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- arch/arm64/mm/flush.c | 2 ++ arch/mips/mm/dma-noncoherent.c | 2 ++ drivers/gpu/drm/drm_cache.c| 20 +--- include/drm/drm_cache.h| 4 4 files changed, 25 insertions(+), 3 deletions(-) diff --git a/arch/a

[PATCH 1/6] arm64: export arch_sync_dma_for_*()

2019-08-14 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- arch/arm64/mm/dma-mapping.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/mm/dma-mapping.c b/arch/arm64/mm/dma-mapping.c index 1d3f0b5a9940..ea5ae11d07f7 100644 --- a/arch/arm64/mm/dma-mapping.c +++ b/arch/arm64/mm/dma-mapping.c @@

[PATCH 0/6] drm+dma: cache support for arm, etc

2019-08-14 Thread Rob Clark
From: Rob Clark This is a replacement for a previous patches[1] that was adding arm64 support for drm_clflush. I've also added a patch to solve a similar cache issue in vgem. The first few patches just export arch_sync_dma_for_*(). Possibly instead the EXPORT_SYMBOL_GPL() should be somewere ce

Re: [PATCH v3 hmm 11/11] mm/mmu_notifiers: remove unregister_no_release

2019-08-14 Thread Ralph Campbell
On 8/6/19 4:15 PM, Jason Gunthorpe wrote: From: Jason Gunthorpe mmu_notifier_unregister_no_release() and mmu_notifier_call_srcu() no longer have any users, they have all been converted to use mmu_notifier_put(). So delete this difficult to use interface. Signed-off-by: Jason Gunthorpe Rev

Re: [PATCH v3 hmm 05/11] hmm: use mmu_notifier_get/put for 'struct hmm'

2019-08-14 Thread Ralph Campbell
On 8/6/19 4:15 PM, Jason Gunthorpe wrote: From: Jason Gunthorpe This is a significant simplification, it eliminates all the remaining 'hmm' stuff in mm_struct, eliminates krefing along the critical notifier paths, and takes away all the ugly locking and abuse of page_table_lock. mmu_notifier_

Re: [PATCH v4 0/9] DRM panel drivers for omapdrm

2019-08-14 Thread Laurent Pinchart
Hi Sam, On Wed, Aug 14, 2019 at 10:28:01PM +0200, Sam Ravnborg wrote: > On Wed, Aug 14, 2019 at 06:44:26PM +0200, Sam Ravnborg wrote: > > On Tue, Aug 13, 2019 at 11:10:52PM +0300, Laurent Pinchart wrote: > > > Hello everybody, > > > > > > This patch series adds DT bindings and drivers for 6 panel

[PATCH 6/7] drm/nouveau/pci: save the boot pcie link speed and restore it on fini

2019-08-14 Thread Karol Herbst
Apperantly things go south if we suspend the device with a different PCIE link speed set than it got booted with. Fixes runtime suspend on my gp107. This all looks like some bug inside the pci subsystem and I would prefer a fix there instead of nouveau, but maybe there is no real nice way of doing

[PATCH 5/7] drm/nouveau/pci: add nvkm_pcie_get_speed

2019-08-14 Thread Karol Herbst
v2: fixed compilation error Signed-off-by: Karol Herbst Reviewed-by: Lyude Paul CC: Alex Hung CC: Rafael J. Wysocki CC: Dave Airlie CC: Lyude Paul CC: Ben Skeggs --- drivers/gpu/drm/nouveau/include/nvkm/subdev/pci.h | 1 + drivers/gpu/drm/nouveau/nvkm/subdev/pci/pcie.c| 8 2 f

[PATCH 0/7] Adding a proper workaround for fixing RTD3 issues with Nouveau

2019-08-14 Thread Karol Herbst
First three patches are removing ACPI workarounds which should have never landed. The last four are adding a workaround to nouveau which seem to help quite a lot with the RTD3 issues with Nouveau, so let's discuss and get wider testing of those and see if there is any fallout or laptops where the

[PATCH 4/7] drm/nouveau/pci: enable pcie link changes for pascal

2019-08-14 Thread Karol Herbst
Signed-off-by: Karol Herbst Reviewed-by: Lyude Paul CC: Alex Hung CC: Rafael J. Wysocki CC: Dave Airlie CC: Lyude Paul CC: Ben Skeggs --- drivers/gpu/drm/nouveau/nvkm/subdev/pci/gk104.c | 8 drivers/gpu/drm/nouveau/nvkm/subdev/pci/gp100.c | 10 ++ drivers/gpu/drm/nouveau/n

[PATCH 7/7] drm/nouveau: abort runtime suspend if we hit an error

2019-08-14 Thread Karol Herbst
Signed-off-by: Karol Herbst CC: Alex Hung CC: Rafael J. Wysocki CC: Dave Airlie CC: Lyude Paul CC: Ben Skeggs --- drivers/gpu/drm/nouveau/nouveau_drm.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c inde

[PATCH 3/7] Revert "ACPI / OSI: Add OEM _OSI strings to disable NVidia RTD3"

2019-08-14 Thread Karol Herbst
This reverts commit 9251a71db62ca9cc7e7cf364218610b0f018c291. This was never discussed with anybody Nouveau related and we would have NACKed this change immediately. We have a better workaround, which makes it actually work with Nouveau. No idea why the comment mentions the Nvidia driver and assu

[PATCH 2/7] Revert "ACPI / OSI: Add OEM _OSI string to enable NVidia HDMI audio"

2019-08-14 Thread Karol Herbst
This reverts commit 887532ca7ca59fcf0547a79211756791128030a3. We have a better solution for this: b516ea586d717 And same as with the last commit: "NVidia Linux driver" that's Nouveau, any out of tree driver does _not_ matter. And with Nouveau all of this works even though it required a proper fix

[PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output"

2019-08-14 Thread Karol Herbst
This reverts commit 28586a51eea666d5531bcaef2f68e4abbd87242c. The original commit message didn't even make sense. AMD _does_ support it and it works with Nouveau as well. Also what was the issue being solved here? No references to any bugs and not even explaining any issue at all isn't the way we

Re: [PATCH v3 hmm 03/11] mm/mmu_notifiers: add a get/put scheme for the registration

2019-08-14 Thread Ralph Campbell
On 8/6/19 4:15 PM, Jason Gunthorpe wrote: From: Jason Gunthorpe Many places in the kernel have a flow where userspace will create some object and that object will need to connect to the subsystem's mmu_notifier subscription for the duration of its lifetime. In this case the subsystem is usual

[Bug 111244] amdgpu kernel 5.2 blank display after resume from suspend

2019-08-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111244 --- Comment #26 from mib...@gmx.at --- Created attachment 145065 --> https://bugs.freedesktop.org/attachment.cgi?id=145065&action=edit failed suspend log Attached full log -- You are receiving this mail because: You are the assignee for the

[Bug 204241] amdgpu fails to resume from suspend

2019-08-14 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204241 --- Comment #9 from Andrey Grodzovsky (andrey.grodzov...@amd.com) --- I was able to reproduce. -- You are receiving this mail because: You are watching the assignee of the bug. ___ dri-devel mailing li

Re: [PATCH 2/5] kernel.h: Add non_block_start/end()

2019-08-14 Thread Andrew Morton
On Wed, 14 Aug 2019 22:20:24 +0200 Daniel Vetter wrote: > In some special cases we must not block, but there's not a > spinlock, preempt-off, irqs-off or similar critical section already > that arms the might_sleep() debug checks. Add a non_block_start/end() > pair to annotate these. > > This wi

Re: [PATCH v3 hmm 02/11] mm/mmu_notifiers: do not speculatively allocate a mmu_notifier_mm

2019-08-14 Thread Ralph Campbell
On 8/6/19 4:15 PM, Jason Gunthorpe wrote: From: Jason Gunthorpe A prior commit e0f3c3f78da2 ("mm/mmu_notifier: init notifier if necessary") made an attempt at doing this, but had to be reverted as calling the GFP_KERNEL allocator under the i_mmap_mutex causes deadlock, see commit 35cfa2b0b491

Re: [PATCH v4 0/9] DRM panel drivers for omapdrm

2019-08-14 Thread Sam Ravnborg
Hi Laurent. On Wed, Aug 14, 2019 at 06:44:26PM +0200, Sam Ravnborg wrote: > Hi Laurent. > > On Tue, Aug 13, 2019 at 11:10:52PM +0300, Laurent Pinchart wrote: > > Hello everybody, > > > > This patch series adds DT bindings and drivers for 6 panels used by > > omapdrm. They are meant to replace th

[PATCH 2/5] kernel.h: Add non_block_start/end()

2019-08-14 Thread Daniel Vetter
In some special cases we must not block, but there's not a spinlock, preempt-off, irqs-off or similar critical section already that arms the might_sleep() debug checks. Add a non_block_start/end() pair to annotate these. This will be used in the oom paths of mmu-notifiers, where blocking is not al

[PATCH 5/5] mm/hmm: WARN on illegal ->sync_cpu_device_pagetables errors

2019-08-14 Thread Daniel Vetter
Similar to the warning in the mmu notifer, warning if an hmm mirror callback gets it's blocking vs. nonblocking handling wrong, or if it fails with anything else than -EAGAIN. Cc: Jason Gunthorpe Cc: Ralph Campbell Cc: John Hubbard Cc: Dan Williams Cc: Dan Carpenter Cc: Matthew Wilcox Cc: Ar

[PATCH 3/5] mm, notifier: Catch sleeping/blocking for !blockable

2019-08-14 Thread Daniel Vetter
We need to make sure implementations don't cheat and don't have a possible schedule/blocking point deeply burried where review can't catch it. I'm not sure whether this is the best way to make sure all the might_sleep() callsites trigger, and it's a bit ugly in the code flow. But it gets the job d

[PATCH 0/5] hmm & mmu_notifier debug/lockdep annotations

2019-08-14 Thread Daniel Vetter
Hi all (but I guess mostly Jason), Finally gotten around to rebasing the previous version, fixing the rebase fail in there, update the commit message a bit and give this a spin with some tests. Nicely caught a lockdep splat that we're now discussing in i915, and seems to not have misfired anywhere

[PATCH 4/5] mm, notifier: Add a lockdep map for invalidate_range_start

2019-08-14 Thread Daniel Vetter
This is a similar idea to the fs_reclaim fake lockdep lock. It's fairly easy to provoke a specific notifier to be run on a specific range: Just prep it, and then munmap() it. A bit harder, but still doable, is to provoke the mmu notifiers for all the various callchains that might lead to them. But

[PATCH 1/5] mm: Check if mmu notifier callbacks are allowed to fail

2019-08-14 Thread Daniel Vetter
Just a bit of paranoia, since if we start pushing this deep into callchains it's hard to spot all places where an mmu notifier implementation might fail when it's not allowed to. Inspired by some confusion we had discussing i915 mmu notifiers and whether we could use the newly-introduced return va

Re: [PATCH v3 hmm 01/11] mm/mmu_notifiers: hoist do_mmu_notifier_register down_write to the caller

2019-08-14 Thread Ralph Campbell
On 8/6/19 4:15 PM, Jason Gunthorpe wrote: From: Jason Gunthorpe This simplifies the code to not have so many one line functions and extra logic. __mmu_notifier_register() simply becomes the entry point to register the notifier, and the other one calls it under lock. Also add a lockdep_assert

Re: [PATCH] dma-buf: Restore seqlock around dma_resv updates

2019-08-14 Thread Daniel Vetter
On Wed, Aug 14, 2019 at 07:26:44PM +0100, Chris Wilson wrote: > Quoting Chris Wilson (2019-08-14 19:24:01) > > This reverts > > 67c97fb79a7f ("dma-buf: add reservation_object_fences helper") > > dd7a7d1ff2f1 ("drm/i915: use new reservation_object_fences helper") > > 0e1d8083bddb ("dma-buf: further

Re: [RESEND][PATCH v3 00/26] drm: Kirin driver cleanups to prep for Kirin960 support

2019-08-14 Thread Sam Ravnborg
Hi Xinliang, Rongrong, Xinwei, Chen On Wed, Aug 14, 2019 at 06:46:36PM +, John Stultz wrote: > Just wanted to resend this patch set so I didn't have to > continue carrying it forever to keep the HiKey960 board running. > > This patchset contains one fix (in the front, so its easier to > event

[Bug 204241] amdgpu fails to resume from suspend

2019-08-14 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204241 --- Comment #8 from Andreas Jackisch (andreas.jacki...@gmail.com) --- Created attachment 284415 --> https://bugzilla.kernel.org/attachment.cgi?id=284415&action=edit amdgpu firmware from ryzen system -- You are receiving this mail because: You

[Bug 204241] amdgpu fails to resume from suspend

2019-08-14 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204241 --- Comment #7 from Andreas Jackisch (andreas.jacki...@gmail.com) --- Created attachment 284413 --> https://bugzilla.kernel.org/attachment.cgi?id=284413&action=edit lspci from ryzen system -- You are receiving this mail because: You are watchi

[Bug 204241] amdgpu fails to resume from suspend

2019-08-14 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204241 --- Comment #6 from Andreas Jackisch (andreas.jacki...@gmail.com) --- Created attachment 284411 --> https://bugzilla.kernel.org/attachment.cgi?id=284411&action=edit var_log_messages for amdgpu_ERROR search fro "amdgpu" to see it fail after resu

Re: [PATCH] drm/vboxvideo: Make structure vbox_fb_helper_funcs constant

2019-08-14 Thread Daniel Vetter
On Wed, Aug 14, 2019 at 08:42:27PM +0200, Sam Ravnborg wrote: > On Wed, Aug 14, 2019 at 07:51:37PM +0200, Daniel Vetter wrote: > > On Wed, Aug 14, 2019 at 07:36:55PM +0200, Hans de Goede wrote: > > > Hi, > > > > > > On 14-08-19 19:26, Daniel Vetter wrote: > > > > On Tue, Aug 13, 2019 at 09:57:19AM

[Bug 204241] amdgpu fails to resume from suspend

2019-08-14 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204241 Andreas Jackisch (andreas.jacki...@gmail.com) changed: What|Removed |Added CC||andreas.ja

[Bug 111244] amdgpu kernel 5.2 blank display after resume from suspend

2019-08-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111244 --- Comment #25 from Andrey Grodzovsky --- (In reply to miba_c from comment #24) > Having the same issue on a ThinkPad T495s (BIOS 1.06) with a Ryzen 7 PRO > 3700U, Kernel 5.2.8-arch1-1-ARCH, Mesa 19.1.4-1 and running sway (wayland) > as a windo

[Bug 204181] NULL pointer dereference regression in amdgpu

2019-08-14 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204181 Andrey Grodzovsky (andrey.grodzov...@amd.com) changed: What|Removed |Added CC||andrey.gro

[Bug 111402] amdgpu-pro-install fails to install on openSUSE Leap 15.1 due to insufficient checks of $ID [PATCH included]

2019-08-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111402 Bug ID: 111402 Summary: amdgpu-pro-install fails to install on openSUSE Leap 15.1 due to insufficient checks of $ID [PATCH included] Product: DRI Version: unspec

Re: [PATCH 4/4] dma-buf: nuke reservation_object seq number

2019-08-14 Thread Chris Wilson
Quoting Koenig, Christian (2019-08-14 18:58:32) > Am 14.08.19 um 19:48 schrieb Chris Wilson: > > Quoting Chris Wilson (2019-08-14 18:38:20) > >> Quoting Chris Wilson (2019-08-14 18:22:53) > >>> Quoting Chris Wilson (2019-08-14 18:06:18) > Quoting Chris Wilson (2019-08-14 17:42:48) > > Quot

[RESEND][PATCH v3 02/26] drm: kirin: Get rid of drmP.h includes

2019-08-14 Thread John Stultz
Remove use of drmP.h in kirin driver Cc: Rongrong Zou Cc: Xinliang Liu Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel Cc: Sam Ravnborg Suggested-by: Sam Ravnborg Signed-off-by: John Stultz --- drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 6 +- drivers/gpu/drm/hisilicon/kirin/ki

[RESEND][PATCH v3 06/26] drm: kirin: Remove out_format from ade_crtc

2019-08-14 Thread John Stultz
From: Xu YiPing As part of refactoring the kirin driver to better support different hardware revisions, this patch removes the out_format field in the struct ade_crtc, which was only ever set to LDI_OUT_RGB_888. Thus this patch removes the field and instead directly uses LDI_OUT_RGB_888. Cc: Ro

[RESEND][PATCH v3 05/26] drm: kirin: Remove uncessary parameter indirection

2019-08-14 Thread John Stultz
From: Xu YiPing In a few functions, we pass in a struct ade_crtc, which we only use to get to the underlying struct ade_hw_ctx. Thus this patch refactors the functions to just take the struct ade_hw_ctx directly. Cc: Rongrong Zou Cc: Xinliang Liu Cc: David Airlie Cc: Daniel Vetter Cc: dri-d

[RESEND][PATCH v3 26/26] drm: kirin: Move ade drm init to kirin drm drv

2019-08-14 Thread John Stultz
From: Xu YiPing As part of refactoring the kirin driver to better support different hardware revisions, this patch renames ade_data to kirin_drm_private, and moves crtc_init and plane_init to kirin drm drv too. Now that they are generic the functions can be shared between the kirin620 and (to be

[RESEND][PATCH v3 00/26] drm: Kirin driver cleanups to prep for Kirin960 support

2019-08-14 Thread John Stultz
Just wanted to resend this patch set so I didn't have to continue carrying it forever to keep the HiKey960 board running. This patchset contains one fix (in the front, so its easier to eventually backport), and a series of changes from YiPing to refactor the kirin drm driver so that it can be used

[RESEND][PATCH v3 18/26] drm: kirin: Move config max_width and max_height to driver data

2019-08-14 Thread John Stultz
From: Xu YiPing As part of refactoring the kirin driver to better support different hardware revisions, this patch moves the max_width and max_height values used in kirin_drm_mode_config_inita to hardware specific driver data. This will make it easier to add support for new devices via a new kir

[RESEND][PATCH v3 22/26] drm: kirin: Fix dev->driver_data setting

2019-08-14 Thread John Stultz
From: Xu YiPing As part of refactoring the kirin driver to better support different hardware revisions, this patch changes the dev->driver_data to point to a drm_device, not ade_data. Thus we set the driver data to drm device after alloc. Cc: Rongrong Zou Cc: Xinliang Liu Cc: David Airlie Cc

[RESEND][PATCH v3 14/26] drm: kirin: Move ade crtc/plane help functions to driver_data

2019-08-14 Thread John Stultz
From: Xu YiPing As part of refactoring the kirin driver to better support different hardware revisions, this patch moves the crtc and plane funcs/helper_funcs to the struct kirin_drm_data. This will make it easier to add support for new devices via a new kirin_drm_data structure. Cc: Rongrong Z

[RESEND][PATCH v3 11/26] drm: kirin: Move workqueue to ade_hw_ctx structure

2019-08-14 Thread John Stultz
The workqueue used to reset the display when we hit an LDI underflow error is ADE specific, so since this patch series works to make the kirin_crtc structure more generic, move the workqueue to the ade_hw_ctx structure instead. Cc: Rongrong Zou Cc: Xinliang Liu Cc: David Airlie Cc: Daniel Vette

[RESEND][PATCH v3 07/26] drm: kirin: Rename ade_plane to kirin_plane

2019-08-14 Thread John Stultz
From: Xu YiPing As part of refactoring the kirin driver to better support different hardware revisions, this patch renames the struct ade_plane to kirin_plane. The struct kirin_plane will later used by both kirin620 and future kirin960 driver, and will be moved to a common kirin_drm_drv.h in a f

[RESEND][PATCH v3 03/26] drm: kirin: Remove HISI_KIRIN_DW_DSI config option

2019-08-14 Thread John Stultz
The CONFIG_HISI_KIRIN_DW_DSI option is only used w/ kirin driver, so cut out the middleman and condense the config logic down. Cc: Rongrong Zou Cc: Xinliang Liu Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel Cc: Sam Ravnborg Reviewed-by: Sam Ravnborg Signed-off-by: John Stultz --- drive

[RESEND][PATCH v3 01/26] drm: kirin: Fix for hikey620 display offset problem

2019-08-14 Thread John Stultz
From: Da Lv The original HiKey (620) board has had a long running issue where when using a 1080p montior, the display would occasionally blink and come come back with a horizontal offset (usually also shifting the colors, depending on the value of the offset%4). After lots of analysis by HiSi de

[RESEND][PATCH v3 20/26] drm: kirin: Add register connect helper functions in drm init

2019-08-14 Thread John Stultz
From: Xu YiPing As part of refactoring the kirin driver to better support different hardware revisions, this patch adds a flag to the device specific driver data so that we can conditionally register the connectors at init. Cc: Rongrong Zou Cc: Xinliang Liu Cc: David Airlie Cc: Daniel Vetter

[RESEND][PATCH v3 25/26] drm: kirin: Pass driver data to crtc init and plane init

2019-08-14 Thread John Stultz
From: Xu YiPing As part of refactoring the kirin driver to better support different hardware revisions, this patch changes the code via a passed in driver_data pointer, rather than hardcoding them via ade_driver_data variable. This will allow those funcitons to be later moved to the generic kiri

[RESEND][PATCH v3 16/26] drm: kirin: Move mode config function to driver_data

2019-08-14 Thread John Stultz
From: Xu YiPing As part of refactoring the kirin driver to better support different hardware revisions, this patch moves the mode config initialization values into the kirin_drm_data structure. This will make it easier to add support for new devices via a new kirin_drm_data structure. Cc: Rongr

[RESEND][PATCH v3 09/26] drm: kirin: Dynamically allocate the hw_ctx

2019-08-14 Thread John Stultz
From: Xu YiPing As part of refactoring the kirin driver to better support different hardware revisions, this patch modifies the initialization function to dynamically allocate the ade_hw_ctx structure previously kept as part of struct ade_data. This is done so that later we can have the hw_ctx p

[RESEND][PATCH v3 17/26] drm: kirin: Move plane number and primay plane in driver data

2019-08-14 Thread John Stultz
From: Xu YiPing As part of refactoring the kirin driver to better support different hardware revisions, this patch moves the number of planes and the primary plane value to the kirin_drm_data structure This will make it easier to add support for new devices via a new kirin_drm_data structure. C

[RESEND][PATCH v3 21/26] drm: kirin: Rename plane_init and crtc_init

2019-08-14 Thread John Stultz
From: Xu YiPing As part of refactoring the kirin driver to better support different hardware revisions, this patch renames ade_crtc/plane_init kirin_plane/crtc_init, as they will later be moved to kirin drm drv and shared with the kirin960 hardware support. Cc: Rongrong Zou Cc: Xinliang Liu Cc

[RESEND][PATCH v3 10/26] drm: kirin: Move request irq handle in ade hw ctx alloc

2019-08-14 Thread John Stultz
From: Xu YiPing As part of refactoring the kirin driver to better support different hardware revisions, this patch modifies the initialization routines so the devm_request_irq() function is called as part of the allocation function. This will be needed in the future when we will have different a

[RESEND][PATCH v3 13/26] drm: kirin: Reanme dc_ops to kirin_drm_data

2019-08-14 Thread John Stultz
From: Xu YiPing As part of refactoring the kirin driver to better support different hardware revisions, this patch renames the struct kirin_dc_ops to struct kirin_drm_data and cleans up the related variable names. Cc: Rongrong Zou Cc: Xinliang Liu Cc: David Airlie Cc: Daniel Vetter Cc: dri-d

[RESEND][PATCH v3 12/26] drm: kirin: Move kirin_crtc, kirin_plane, kirin_format to kirin_drm_drv.h

2019-08-14 Thread John Stultz
From: Xu YiPing As part of refactoring the kirin driver to better support different hardware revisions, this patch moves some shared structures and helpers to the common kirin_drm_drv.h These structures will later used by both kirin620 and future kirin960 driver Cc: Rongrong Zou Cc: Xinliang L

[RESEND][PATCH v3 15/26] drm: kirin: Move channel formats to driver data

2019-08-14 Thread John Stultz
From: Xu YiPing As part of refactoring the kirin driver to better support different hardware revisions, this patch moves the channel format arrays into the kirin_drm_data structure. This will make it easier to add support for new devices via a new kirin_drm_data structure. Cc: Rongrong Zou Cc:

[RESEND][PATCH v3 04/26] drm: kirin: Remove unreachable return

2019-08-14 Thread John Stultz
The 'return 0' in kirin_drm_platform_probe() is unreachable code, so remove it. Cc: Rongrong Zou Cc: Xinliang Liu Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel Cc: Sam Ravnborg Reviewed-by: Sam Ravnborg Suggested by: Xu YiPing Signed-off-by: John Stultz --- drivers/gpu/drm/hisilicon/k

[RESEND][PATCH v3 24/26] drm: kirin: Add alloc_hw_ctx/clean_hw_ctx ops in driver data

2019-08-14 Thread John Stultz
From: Xu YiPing As part of refactoring the kirin driver to better support different hardware revisions, this patch changes the alloc/clean_hw_ctx functions to be called via driver_data specific funciton pointers. This will allow the ade_drm_init to later be made generic and moved to kirin_drm_dr

[RESEND][PATCH v3 08/26] drm: kirin: Rename ade_crtc to kirin_crtc

2019-08-14 Thread John Stultz
From: Xu YiPing As part of refactoring the kirin driver to better support different hardware revisions, this patch renames the struct ade_crtc to kirin_crtc. The struct kirin_crtc will later used by both kirin620 and future kirin960 driver, and will be moved to a common kirin_drm_drv.h in a futu

[RESEND][PATCH v3 23/26] drm: kirin: Make driver_data variable non-global

2019-08-14 Thread John Stultz
From: Xu YiPing As part of refactoring the kirin driver to better support different hardware revisions, this patch changes the driver_data value to not be a global variable. Instead the driver_data value is accessed via the of_device_get_match_data() when needed. Cc: Rongrong Zou Cc: Xinliang L

[RESEND][PATCH v3 19/26] drm: kirin: Move drm driver to driver data

2019-08-14 Thread John Stultz
From: Xu YiPing As part of refactoring the kirin driver to better support different hardware revisions, this patch moves the drm_driver structure to be under device specific driver data. This will allow us to more easily add support for kirin960 hardware with later patches. Cc: Rongrong Zou Cc

Re: [PATCH] drm/vboxvideo: Make structure vbox_fb_helper_funcs constant

2019-08-14 Thread Sam Ravnborg
On Wed, Aug 14, 2019 at 07:51:37PM +0200, Daniel Vetter wrote: > On Wed, Aug 14, 2019 at 07:36:55PM +0200, Hans de Goede wrote: > > Hi, > > > > On 14-08-19 19:26, Daniel Vetter wrote: > > > On Tue, Aug 13, 2019 at 09:57:19AM +0200, Hans de Goede wrote: > > > > Hi, > > > > > > > > On 13-08-19 08:2

  1   2   3   >