[PATCH v7 18/24] media/v4l2-core: pin_user_pages (FOLL_PIN) and put_user_page() conversion

2019-11-20 Thread John Hubbard
1. Change v4l2 from get_user_pages() to pin_user_pages(). 2. Because all FOLL_PIN-acquired pages must be released via put_user_page(), also convert the put_page() call over to put_user_pages_dirty_lock(). Acked-by: Hans Verkuil Cc: Ira Weiny Signed-off-by: John Hubbard ---

[PATCH v7 07/24] IB/umem: use get_user_pages_fast() to pin DMA pages

2019-11-20 Thread John Hubbard
And get rid of the mmap_sem calls, as part of that. Note that get_user_pages_fast() will, if necessary, fall back to __gup_longterm_unlocked(), which takes the mmap_sem as needed. Reviewed-by: Jan Kara Reviewed-by: Jason Gunthorpe Reviewed-by: Ira Weiny Signed-off-by: John Hubbard ---

[PATCH v7 24/24] mm, tree-wide: rename put_user_page*() to unpin_user_page*()

2019-11-20 Thread John Hubbard
In order to provide a clearer, more symmetric API for pinning and unpinning DMA pages. This way, pin_user_pages*() calls match up with unpin_user_pages*() calls, and the API is a lot closer to being self-explanatory. Reviewed-by: Jan Kara Signed-off-by: John Hubbard ---

[PATCH v7 10/24] mm/gup: introduce pin_user_pages*() and FOLL_PIN

2019-11-20 Thread John Hubbard
Introduce pin_user_pages*() variations of get_user_pages*() calls, and also pin_longterm_pages*() variations. For now, these are placeholder calls, until the various call sites are converted to use the correct get_user_pages*() or pin_user_pages*() API. These variants will eventually all set

[PATCH 3/3] drm/panel: simple: Add support for the Frida FRD350H54004 panel

2019-11-20 Thread Paul Cercueil
The FRD350H54004 is a simple 3.5" 320x240 24-bit TFT panel, found for instance inside the Anbernic RG-350 handheld gaming console. Signed-off-by: Paul Cercueil --- drivers/gpu/drm/panel/panel-simple.c | 29 1 file changed, 29 insertions(+) diff --git

[PATCH v1 4/5] fbtft: Make use of device property API

2019-11-20 Thread Andy Shevchenko
Make use of device property API in this driver so that both OF based system and ACPI based system can use this driver. Signed-off-by: Andy Shevchenko --- drivers/staging/fbtft/fbtft-core.c | 105 - 1 file changed, 58 insertions(+), 47 deletions(-) diff --git

[PATCH 2/3] dt-bindings: panel: Document Frida FRD350H54004 LCD panel

2019-11-20 Thread Paul Cercueil
Add bindings documentation for the Frida 3.5" (320x240 pixels) 24-bit TFT LCD panel. Signed-off-by: Paul Cercueil --- .../bindings/display/panel/frida,frd350h54004.txt| 12 1 file changed, 12 insertions(+) create mode 100644

Re: [Intel-gfx] linux-next: Tree for Nov 19 (i915)

2019-11-20 Thread Randy Dunlap
On 11/20/19 8:56 AM, Chris Wilson wrote: > Quoting Jani Nikula (2019-11-20 16:15:08) >> On Tue, 19 Nov 2019, Randy Dunlap wrote: >>> On 11/19/19 12:46 AM, Stephen Rothwell wrote: Hi all, Changes since 20191118: >>> >>> >>> on x86_64: >>> >>> ERROR: "pm_suspend_target_state"

[PATCH v1 2/5] fbtft: Describe function parameters in kernel-doc

2019-11-20 Thread Andy Shevchenko
Kernel documentation script complains that some of the function parameters are not described: drivers/staging/fbtft/fbtft-core.c:543: warning: Function parameter or member 'pdata' not described in 'fbtft_framebuffer_alloc' Describe function parameters where it's appropriate. Signed-off-by:

[PATCH v7 03/24] mm/gup: move try_get_compound_head() to top, fix minor issues

2019-11-20 Thread John Hubbard
An upcoming patch uses try_get_compound_head() more widely, so move it to the top of gup.c. Also fix a tiny spelling error and a checkpatch.pl warning. Reviewed-by: Jan Kara Reviewed-by: Ira Weiny Signed-off-by: John Hubbard --- mm/gup.c | 29 +++-- 1 file changed, 15

[PATCH v7 22/24] mm/gup_benchmark: support pin_user_pages() and related calls

2019-11-20 Thread John Hubbard
Up until now, gup_benchmark supported testing of the following kernel functions: * get_user_pages(): via the '-U' command line option * get_user_pages_longterm(): via the '-L' command line option * get_user_pages_fast(): as the default (no options required) Add test coverage for the new

[PATCH v7 23/24] selftests/vm: run_vmtests: invoke gup_benchmark with basic FOLL_PIN coverage

2019-11-20 Thread John Hubbard
It's good to have basic unit test coverage of the new FOLL_PIN behavior. Fortunately, the gup_benchmark unit test is extremely fast (a few milliseconds), so adding it the the run_vmtests suite is going to cause no noticeable change in running time. So, add two new invocations to run_vmtests: 1)

[PATCH v7 16/24] net/xdp: set FOLL_PIN via pin_user_pages()

2019-11-20 Thread John Hubbard
Convert net/xdp to use the new pin_longterm_pages() call, which sets FOLL_PIN. Setting FOLL_PIN is now required for code that requires tracking of pinned pages. In partial anticipation of this work, the net/xdp code was already calling put_user_page() instead of put_page(). Therefore, in order to

[PATCH v7 11/24] goldish_pipe: convert to pin_user_pages() and put_user_page()

2019-11-20 Thread John Hubbard
1. Call the new global pin_user_pages_fast(), from pin_goldfish_pages(). 2. As required by pin_user_pages(), release these pages via put_user_page(). In this case, do so via put_user_pages_dirty_lock(). That has the side effect of calling set_page_dirty_lock(), instead of set_page_dirty(). This

[PATCH v7 17/24] mm/gup: track FOLL_PIN pages

2019-11-20 Thread John Hubbard
Add tracking of pages that were pinned via FOLL_PIN. As mentioned in the FOLL_PIN documentation, callers who effectively set FOLL_PIN are required to ultimately free such pages via put_user_page(). The effect is similar to FOLL_GET, and may be thought of as "FOLL_GET for DIO and/or RDMA use".

[PATCH v7 20/24] powerpc: book3s64: convert to pin_user_pages() and put_user_page()

2019-11-20 Thread John Hubbard
1. Convert from get_user_pages() to pin_user_pages(). 2. As required by pin_user_pages(), release these pages via put_user_page(). In this case, do so via put_user_pages_dirty_lock(). That has the side effect of calling set_page_dirty_lock(), instead of set_page_dirty(). This is probably more

[PATCH v7 19/24] vfio, mm: pin_user_pages (FOLL_PIN) and put_user_page() conversion

2019-11-20 Thread John Hubbard
1. Change vfio from get_user_pages_remote(), to pin_user_pages_remote(). 2. Because all FOLL_PIN-acquired pages must be released via put_user_page(), also convert the put_page() call over to put_user_pages_dirty_lock(). Note that this effectively changes the code's behavior in

[PATCH v7 21/24] mm/gup_benchmark: use proper FOLL_WRITE flags instead of hard-coding "1"

2019-11-20 Thread John Hubbard
Fix the gup benchmark flags to use the symbolic FOLL_WRITE, instead of a hard-coded "1" value. Also, clean up the filtering of gup flags a little, by just doing it once before issuing any of the get_user_pages*() calls. This makes it harder to overlook, instead of having little "gup_flags & 1"

[PATCH v4 1/6] drm/komeda: Add side by side assembling

2019-11-20 Thread james qian wang (Arm Technology China)
Komeda HW can support side by side, which splits the internal display processing to two single halves (LEFT/RIGHT) and handle them by two pipelines separately. komeda "side by side" is enabled by DT property: "side_by_side_master", once DT configured side by side, komeda need to verify it with

[PATCH v4 2/6] drm/komeda: Add side by side plane_state split

2019-11-20 Thread james qian wang (Arm Technology China)
On side by side mode, The full display frame will be split into two parts (Left/Right), and each part will be handled by a single pipeline separately master pipeline for left part, slave for right. To simplify the usage and implementation, komeda use the following scheme to do the side by side

[PATCH v4 3/6] drm/komeda: Build side by side display output pipeline

2019-11-20 Thread james qian wang (Arm Technology China)
For side by side, the slave pipeline merges to master via image processor slave-layers -> slave-compiz-> slave-improc- \ master-layers -> master-compiz -> master-improc -> v3: Rebase. Signed-off-by: James Qian Wang (Arm Technology

[PATCH v4 0/6] arm/komeda: Add side_by_side support

2019-11-20 Thread james qian wang (Arm Technology China)
Hi: All Komeda HW (two pipelines) can work on side by side mode, which splits the internal display processing to two halves (LEFT/RIGHT) and handle them by two pipelines separately and simultaneously. And since one single pipeline only handles the half display frame, so the main engine clock

Re: [PATCH v3 4/4] dt-bindings: display: add IMX MIPI DSI host controller doc

2019-11-20 Thread Adrian Ratiu
On Wed, 20 Nov 2019, Neil Armstrong wrote: Hi, On 18/11/2019 16:25, Adrian Ratiu wrote: A small commit log would be welcome here. Signed-off-by: Sjoerd Simons Signed-off-by: Martyn Welch Signed-off-by: Adrian Ratiu --- .../bindings/display/imx/mipi-dsi.txt | 56

Re: [PATCH] drm/mgag200: Fix Kconfig indentation

2019-11-20 Thread Thomas Zimmermann
Am 20.11.19 um 14:36 schrieb Krzysztof Kozlowski: > Adjust indentation from spaces to tab (+optional two spaces) as in > coding style with command like: > $ sed -e 's/^/\t/' -i */Kconfig > > Signed-off-by: Krzysztof Kozlowski Acked-by: Thomas Zimmermann > --- >

Re: drm/komeda: Remove unnecessary komeda_wb_connector_detect

2019-11-20 Thread james qian wang (Arm Technology China)
On Wed, Nov 20, 2019 at 12:03:55PM +, Mihail Atanassov wrote: > The func is optional and the connector will report as always connected, > i.e. no change in behaviour. > > Signed-off-by: Mihail Atanassov > --- > drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c | 7 --- > 1 file

[PATCH v7 02/24] mm/gup: factor out duplicate code from four routines

2019-11-20 Thread John Hubbard
There are four locations in gup.c that have a fair amount of code duplication. This means that changing one requires making the same changes in four places, not to mention reading the same code four times, and wondering if there are subtle differences. Factor out the common code into static

[PATCH v7 13/24] mm/process_vm_access: set FOLL_PIN via pin_user_pages_remote()

2019-11-20 Thread John Hubbard
Convert process_vm_access to use the new pin_user_pages_remote() call, which sets FOLL_PIN. Setting FOLL_PIN is now required for code that requires tracking of pinned pages. Also, release the pages via put_user_page*(). Also, rename "pages" to "pinned_pages", as this makes for easier reading of

[PATCH v7 05/24] mm: devmap: refactor 1-based refcounting for ZONE_DEVICE pages

2019-11-20 Thread John Hubbard
An upcoming patch changes and complicates the refcounting and especially the "put page" aspects of it. In order to keep everything clean, refactor the devmap page release routines: * Rename put_devmap_managed_page() to page_is_devmap_managed(), and limit the functionality to "read only": return

[PATCH v7 04/24] mm: Cleanup __put_devmap_managed_page() vs ->page_free()

2019-11-20 Thread John Hubbard
From: Dan Williams After the removal of the device-public infrastructure there are only 2 ->page_free() call backs in the kernel. One of those is a device-private callback in the nouveau driver, the other is a generic wakeup needed in the DAX case. In the hopes that all ->page_free() callbacks

[PATCH v7 01/24] mm/gup: pass flags arg to __gup_device_* functions

2019-11-20 Thread John Hubbard
A subsequent patch requires access to gup flags, so pass the flags argument through to the __gup_device_* functions. Also placate checkpatch.pl by shortening a nearby line. Reviewed-by: Jan Kara Reviewed-by: Jérôme Glisse Reviewed-by: Ira Weiny Cc: Kirill A. Shutemov Signed-off-by: John

[PATCH v7 14/24] drm/via: set FOLL_PIN via pin_user_pages_fast()

2019-11-20 Thread John Hubbard
Convert drm/via to use the new pin_user_pages_fast() call, which sets FOLL_PIN. Setting FOLL_PIN is now required for code that requires tracking of pinned pages, and therefore for any code that calls put_user_page(). In partial anticipation of this work, the drm/via driver was already calling

[PATCH v7 12/24] IB/{core, hw, umem}: set FOLL_PIN via pin_user_pages*(), fix up ODP

2019-11-20 Thread John Hubbard
Convert infiniband to use the new pin_user_pages*() calls. Also, revert earlier changes to Infiniband ODP that had it using put_user_page(). ODP is "Case 3" in Documentation/core-api/pin_user_pages.rst, which is to say, normal get_user_pages() and put_page() is the API to use there. The new

[PATCH v7 15/24] fs/io_uring: set FOLL_PIN via pin_user_pages()

2019-11-20 Thread John Hubbard
Convert fs/io_uring to use the new pin_user_pages() call, which sets FOLL_PIN. Setting FOLL_PIN is now required for code that requires tracking of pinned pages, and therefore for any code that calls put_user_page(). In partial anticipation of this work, the io_uring code was already calling

[PATCH v7 06/24] goldish_pipe: rename local pin_user_pages() routine

2019-11-20 Thread John Hubbard
1. Avoid naming conflicts: rename local static function from "pin_user_pages()" to "pin_goldfish_pages()". An upcoming patch will introduce a global pin_user_pages() function. Reviewed-by: Jan Kara Reviewed-by: Jérôme Glisse Reviewed-by: Ira Weiny Signed-off-by: John Hubbard ---

[PATCH v7 00/24] mm/gup: track dma-pinned pages: FOLL_PIN

2019-11-20 Thread John Hubbard
Hi, OK, here is v7, maybe this is the last one. The corresponding git repo and branch is: g...@github.com:johnhubbard/linux.git pin_user_pages_tracking_v7 Ira, you reviewed the gup_benchmark patches a bit earlier, but I removed one or two of those review-by tags, due to invasive changes I

[PATCH v7 09/24] vfio, mm: fix get_user_pages_remote() and FOLL_LONGTERM

2019-11-20 Thread John Hubbard
As it says in the updated comment in gup.c: current FOLL_LONGTERM behavior is incompatible with FAULT_FLAG_ALLOW_RETRY because of the FS DAX check requirement on vmas. However, the corresponding restriction in get_user_pages_remote() was slightly stricter than is actually required: it forbade all

[PATCH v4 6/6] drm/komeda: Expose side_by_side by sysfs/config_id

2019-11-20 Thread james qian wang (Arm Technology China)
There are some restrictions if HW works on side_by_side, expose it via config_id to user. Signed-off-by: James Qian Wang (Arm Technology China) --- drivers/gpu/drm/arm/display/include/malidp_product.h | 3 ++- drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 1 + 2 files changed, 3

[PATCH v4 5/6] drm/komeda: Update writeback signal for side_by_side

2019-11-20 Thread james qian wang (Arm Technology China)
In side by side mode, a writeback job is completed by two pipelines: left by master and right by slave, we need to wait both pipeline finished (EOW), then can signal the writeback job completion. Signed-off-by: James Qian Wang (Arm Technology China) ---

[PATCH v7 08/24] media/v4l2-core: set pages dirty upon releasing DMA buffers

2019-11-20 Thread John Hubbard
After DMA is complete, and the device and CPU caches are synchronized, it's still required to mark the CPU pages as dirty, if the data was coming from the device. However, this driver was just issuing a bare put_page() call, without any set_page_dirty*() call. Fix the problem, by calling

[PATCH v4 4/6] drm/komeda: Add side by side support for writeback

2019-11-20 Thread james qian wang (Arm Technology China)
In side by side mode, the master pipeline writeback the left frame and the slave writeback the right part, the data flow as below: slave.compiz -> slave.wb_layer -> fb (right-part) master.compiz -> master.wb_layer -> fb (left-part) Signed-off-by: James Qian Wang (Arm Technology China) ---

Re: 2989f64510 ("dma-buf: Add selftests for dma-fence"): WARNING: CPU: 0 PID: 1 at lib/debugobjects.c:524 __debug_object_init

2019-11-20 Thread Chris Wilson
Quoting kernel test robot (2019-11-21 07:19:43) > Greetings, > > 0day kernel testing robot got the below dmesg and the first bad commit is > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > > commit 2989f6451084aed3f8cc9992477f7a9bf57a3716 > Author: Chris Wilson

Re: [PATCH 3/3] drm/msm: Don't init ww_mutec acquire ctx before needed

2019-11-20 Thread Daniel Vetter
On Wed, Nov 20, 2019 at 3:07 AM Rob Clark wrote: > > On Tue, Nov 19, 2019 at 1:08 PM Daniel Vetter wrote: > > > > For locking semantics it really doesn't matter when we grab the > > ticket. But for lockdep validation it does: the acquire ctx is a fake > > lockdep. Since other drivers might want

Re: [PATCH v2] drm/gem: Fix mmap fake offset handling for drm_gem_object_funcs.mmap

2019-11-20 Thread Daniel Vetter
On Wed, Nov 20, 2019 at 09:05:32AM +0100, Gerd Hoffmann wrote: > Hi, > > > > I can see now why you want a private address space for each object. > > > Does that imply we need an anon_inode for each gem object? Or is > > > there some more lightweight way to do this? > > > > I have no idea

Re: [PATCH v2] drm/gem: Fix mmap fake offset handling for drm_gem_object_funcs.mmap

2019-11-20 Thread Gerd Hoffmann
Hi, > > Anything building on shmem helpers should be able to use > > obj->filp->f_mapping, right? So allocating an inode unconditionally > > doesn't look like a good plan. > > Not sure the shmem helpers forward the mmap to the underlying shmem file, > so not sure this is the greatest way

Re: locking refcounting for ttm_bo_kmap/dma_buf_vmap

2019-11-20 Thread Christian König
What am I missing? The assumption is that when you want to create a vmap of a DMA-buf buffer the buffer needs to be pinned somehow. E.g. without dynamic dma-buf handling you would need to have an active attachment. With dynamic handling the requirements could be lowered to using the

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-20 Thread Karol Herbst
On Wed, Nov 20, 2019 at 1:06 PM Rafael J. Wysocki wrote: > > On Wed, Nov 20, 2019 at 12:51 PM Karol Herbst wrote: > > > > On Wed, Nov 20, 2019 at 12:48 PM Rafael J. Wysocki > > wrote: > > > > > > On Wed, Nov 20, 2019 at 12:22 PM Mika Westerberg > > > wrote: > > > > > > > > On Wed, Nov 20,

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-20 Thread Rafael J. Wysocki
On Wed, Nov 20, 2019 at 1:06 PM Rafael J. Wysocki wrote: > > On Wed, Nov 20, 2019 at 12:51 PM Karol Herbst wrote: > > > > On Wed, Nov 20, 2019 at 12:48 PM Rafael J. Wysocki > > wrote: > > > > > > On Wed, Nov 20, 2019 at 12:22 PM Mika Westerberg > > > wrote: > > > > > > > > On Wed, Nov 20,

[Bug 205589] New: Green screen crash with 3400G

2019-11-20 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205589 Bug ID: 205589 Summary: Green screen crash with 3400G Product: Drivers Version: 2.5 Kernel Version: 5.x Hardware: All OS: Linux Tree: Mainline

[PATCH] video: Fix Kconfig indentation

2019-11-20 Thread Krzysztof Kozlowski
Adjust indentation from spaces to tab (+optional two spaces) as in coding style with command like: $ sed -e 's/^/\t/' -i */Kconfig Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/Kconfig | 8 ++-- drivers/video/console/Kconfig | 76

Re: [PATCH] drm/dsc: Return unsigned long on compute offset

2019-11-20 Thread Mikita Lipski
On 20/11/2019 05:17, Ville Syrjälä wrote: On Tue, Nov 19, 2019 at 04:11:43PM -0500, Mikita Lipski wrote: On 19/11/2019 16:09, Mikita Lipski wrote: On 19/11/2019 12:11, Ville Syrjälä wrote: On Tue, Nov 19, 2019 at 04:59:40PM +, Cornij, Nikola wrote: If you're going to make all of

Re: [PATCH] video: Fix Kconfig indentation

2019-11-20 Thread Krzysztof Kozlowski
On Wed, Nov 20, 2019 at 08:45:46AM -0500, Daniel Thompson wrote: > On Wed, Nov 20, 2019 at 09:38:38PM +0800, Krzysztof Kozlowski wrote: > > Adjust indentation from spaces to tab (+optional two spaces) as in > > coding style with command like: > > $ sed -e 's/^/\t/' -i */Kconfig > > >

Re: [PATCH] video: Fix Kconfig indentation

2019-11-20 Thread Bartlomiej Zolnierkiewicz
[ added Jiri to Cc: ] On 11/20/19 2:50 PM, Krzysztof Kozlowski wrote: > On Wed, Nov 20, 2019 at 08:45:46AM -0500, Daniel Thompson wrote: >> On Wed, Nov 20, 2019 at 09:38:38PM +0800, Krzysztof Kozlowski wrote: >>> Adjust indentation from spaces to tab (+optional two spaces) as in >>> coding style

Re: [PATCH] drm: Fix Kconfig indentation

2019-11-20 Thread Jani Nikula
On Wed, 20 Nov 2019, Krzysztof Kozlowski wrote: > Adjust indentation from spaces to tab (+optional two spaces) as in > coding style with command like: > $ sed -e 's/^/\t/' -i */Kconfig > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/gpu/drm/Kconfig | 30

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-20 Thread Mika Westerberg
On Wed, Nov 20, 2019 at 12:58:00PM +0100, Karol Herbst wrote: > overall, what I really want to know is, _why_ does it work on windows? So do I ;-) > Or what are we doing differently on Linux so that it doesn't work? If > anybody has any idea on how we could dig into this and figure it out > on

Re: locking refcounting for ttm_bo_kmap/dma_buf_vmap

2019-11-20 Thread Daniel Vetter
On Wed, Nov 20, 2019 at 1:02 PM Christian König wrote: > > > What am I missing? > The assumption is that when you want to create a vmap of a DMA-buf > buffer the buffer needs to be pinned somehow. > > E.g. without dynamic dma-buf handling you would need to have an active > attachment. With

Re: [PATCH v2] drm/gem: Fix mmap fake offset handling for drm_gem_object_funcs.mmap

2019-11-20 Thread Gerd Hoffmann
Hi, > Ah, we're not going to replace the mapping on the dma-buf file. Only > the file of the vma structure. Doing the former would indeed be pretty > bad from a security pov. Now where do I get a filp from? Can I just call drm_open? cheers, Gerd

Re: [PATCH] drm/rect: remove useless call to clamp_t

2019-11-20 Thread Jani Nikula
On Tue, 19 Nov 2019, Benjamin Gaignard wrote: > Clamping a value between INT_MIN and INT_MAX always return the value itself > and generate warnings when compiling with W=1. Does that hold for 32-bit too? BR, Jani. > > Signed-off-by: Benjamin Gaignard > --- > drivers/gpu/drm/drm_rect.c | 8

Re: [PATCH v2 1/3] drm/i915: Move the code to populate ACPI device ID into intel_acpi

2019-11-20 Thread Jani Nikula
On Mon, 04 Nov 2019, Rajat Jain wrote: > Move the code that populates the ACPI device ID for devices, into > more appripriate intel_acpi.c. This is done in preparation for more > users of this code (in next patch). I don't think your use of the code makes sense (I'll explain in reply to the

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-20 Thread Karol Herbst
for newer Windows the firmware uses bit 0x80 on 0x248 (Q0L2 being the field name) on the bridge controller to turn of the device, on other versions it uses the "older"? 0xb0 register and the P0LD field, which is documented, where the former is not. On Wed, Nov 20, 2019 at 12:51 PM Mika

[PATCH] drm/komeda: Remove unnecessary komeda_wb_connector_detect

2019-11-20 Thread Mihail Atanassov
The func is optional and the connector will report as always connected, i.e. no change in behaviour. Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c | 7 --- 1 file changed, 7 deletions(-) diff --git

Re: [PATCH v2] drm/gem: Fix mmap fake offset handling for drm_gem_object_funcs.mmap

2019-11-20 Thread Daniel Vetter
On Wed, Nov 20, 2019 at 12:40 PM Gerd Hoffmann wrote: > > Hi, > > > > Anything building on shmem helpers should be able to use > > > obj->filp->f_mapping, right? So allocating an inode unconditionally > > > doesn't look like a good plan. > > > > Not sure the shmem helpers forward the mmap to

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-20 Thread Karol Herbst
On Wed, Nov 20, 2019 at 1:09 PM Mika Westerberg wrote: > > On Wed, Nov 20, 2019 at 12:58:00PM +0100, Karol Herbst wrote: > > overall, what I really want to know is, _why_ does it work on windows? > > So do I ;-) > > > Or what are we doing differently on Linux so that it doesn't work? If > >

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-20 Thread Karol Herbst
It depends on the kernel being built with ACPI_REV_OVERRIDE_POSSIBLE=y and acpi_rev_override=1 being set on the kernel command line On Wed, Nov 20, 2019 at 1:15 PM Rafael J. Wysocki wrote: > > On Wed, Nov 20, 2019 at 1:10 PM Karol Herbst wrote: > > > > On Wed, Nov 20, 2019 at 1:06 PM Rafael J.

Re: locking refcounting for ttm_bo_kmap/dma_buf_vmap

2019-11-20 Thread Daniel Vetter
On Wed, Nov 20, 2019 at 1:09 PM Daniel Vetter wrote: > On Wed, Nov 20, 2019 at 1:02 PM Christian König > wrote: > > > > > What am I missing? > > The assumption is that when you want to create a vmap of a DMA-buf > > buffer the buffer needs to be pinned somehow. > > > > E.g. without dynamic

Re: locking refcounting for ttm_bo_kmap/dma_buf_vmap

2019-11-20 Thread Daniel Vetter
On Wed, Nov 20, 2019 at 1:24 PM Christian König wrote: > > Am 20.11.19 um 13:19 schrieb Daniel Vetter: > > On Wed, Nov 20, 2019 at 1:09 PM Daniel Vetter > > wrote: > >> On Wed, Nov 20, 2019 at 1:02 PM Christian König > >> wrote: > What am I missing? > >>> The assumption is that when you

[PATCH] vga: Fix Kconfig indentation

2019-11-20 Thread Krzysztof Kozlowski
Adjust indentation from spaces to tab (+optional two spaces) as in coding style with command like: $ sed -e 's/^/\t/' -i */Kconfig Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/vga/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] drm/udl: Fix Kconfig indentation

2019-11-20 Thread Krzysztof Kozlowski
Adjust indentation from spaces to tab (+optional two spaces) as in coding style with command like: $ sed -e 's/^/\t/' -i */Kconfig Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/udl/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] drm/rockchip: Fix Kconfig indentation

2019-11-20 Thread Krzysztof Kozlowski
Adjust indentation from spaces to tab (+optional two spaces) as in coding style with command like: $ sed -e 's/^/\t/' -i */Kconfig Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/rockchip/Kconfig | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [PATCH 2/3] dma-resv: Also prime acquire ctx for lockdep

2019-11-20 Thread Maarten Lankhorst
Op 20-11-2019 om 12:30 schreef Christian König: > Am 19.11.19 um 22:08 schrieb Daniel Vetter: >> Semnatically it really doesn't matter where we grab the ticket. But >> since the ticket is a fake lockdep lock, it matters for lockdep >> validation purposes. >> >> This means stuff like grabbing a

Re: [PATCH 1/2] drm/mipi-dsi: consider low power transmission

2019-11-20 Thread Linus Walleij
On Mon, Aug 18, 2014 at 10:11 AM Inki Dae wrote: > This patch adds a new flag, MIPI_DSI-MODE_LPM, to transmit data > in low power. With this flag, msg.flags has MIPI_DSI_MSG_USE_LPM > so that host driver of each SoC can clear or set relevant register > bit for low power transmission. > > All

Re: locking refcounting for ttm_bo_kmap/dma_buf_vmap

2019-11-20 Thread Christian König
Am 20.11.19 um 13:19 schrieb Daniel Vetter: On Wed, Nov 20, 2019 at 1:09 PM Daniel Vetter wrote: On Wed, Nov 20, 2019 at 1:02 PM Christian König wrote: What am I missing? The assumption is that when you want to create a vmap of a DMA-buf buffer the buffer needs to be pinned somehow. E.g.

Re: [PATCH v2] drm/gem: Fix mmap fake offset handling for drm_gem_object_funcs.mmap

2019-11-20 Thread Daniel Vetter
On Wed, Nov 20, 2019 at 1:18 PM Gerd Hoffmann wrote: > > Hi, > > > > > I think for ttm just consistently using the one per-device mapping for > > > > everything, with all the fake offsets, is probably the quickest route. > > > > > > Hmm, not clear how to fit dmabufs into this. dmabufs already

[PATCH 1/2] drm/nouveau: move io_reserve_lru handling into the driver

2019-11-20 Thread Christian König
From: Christian König While working on TTM cleanups I've found that the io_reserve_lru used by Nouveau is actually not working at all. In general we should remove driver specific handling from the memory management, so this patch moves the io_reserve_lru handling into Nouveau instead. The

Move io_reserve_lru handling into the driver

2019-11-20 Thread Christian König
Just a gentle ping on this. Already got the Acked-by from Daniel, but I need some of the nouveau guys to test this since I can only compile test it. Regards, Christian. ___ dri-devel mailing list dri-devel@lists.freedesktop.org

[PATCH 2/2] drm/ttm: remove io_reserve_lru handling

2019-11-20 Thread Christian König
From: Christian König That is not used any more. Signed-off-by: Christian König Acked-by: Daniel Vetter --- drivers/gpu/drm/ttm/ttm_bo.c | 37 +++--- drivers/gpu/drm/ttm/ttm_bo_util.c | 114 +- drivers/gpu/drm/ttm/ttm_bo_vm.c | 33 +++--

[PATCH] drm: Fix Kconfig indentation

2019-11-20 Thread Krzysztof Kozlowski
Adjust indentation from spaces to tab (+optional two spaces) as in coding style with command like: $ sed -e 's/^/\t/' -i */Kconfig Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/Kconfig | 30 +++--- 1 file changed, 15 insertions(+), 15

Re: locking refcounting for ttm_bo_kmap/dma_buf_vmap

2019-11-20 Thread Thomas Hellstrom
On 11/20/19 1:24 PM, Christian König wrote: > Am 20.11.19 um 13:19 schrieb Daniel Vetter: >> On Wed, Nov 20, 2019 at 1:09 PM Daniel Vetter wrote: >>> On Wed, Nov 20, 2019 at 1:02 PM Christian König >>> wrote: > What am I missing? The assumption is that when you want to create a vmap of

[PATCH] drm/mgag200: Fix Kconfig indentation

2019-11-20 Thread Krzysztof Kozlowski
Adjust indentation from spaces to tab (+optional two spaces) as in coding style with command like: $ sed -e 's/^/\t/' -i */Kconfig Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/mgag200/Kconfig | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH] drm/bridge: Fix Kconfig indentation

2019-11-20 Thread Krzysztof Kozlowski
Adjust indentation from spaces to tab (+optional two spaces) as in coding style with command like: $ sed -e 's/^/\t/' -i */Kconfig Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/bridge/Kconfig | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH] drm/omap: Fix Kconfig indentation

2019-11-20 Thread Krzysztof Kozlowski
Adjust indentation from spaces to tab (+optional two spaces) as in coding style with command like: $ sed -e 's/^/\t/' -i */Kconfig Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/omapdrm/displays/Kconfig | 6 +++--- drivers/gpu/drm/omapdrm/dss/Kconfig | 12

[PATCH] drm/nouveau: Fix Kconfig indentation

2019-11-20 Thread Krzysztof Kozlowski
Adjust indentation from spaces to tab (+optional two spaces) as in coding style with command like: $ sed -e 's/^/\t/' -i */Kconfig Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/nouveau/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] drm/lima: Fix Kconfig indentation

2019-11-20 Thread Krzysztof Kozlowski
Adjust indentation from spaces to tab (+optional two spaces) as in coding style with command like: $ sed -e 's/^/\t/' -i */Kconfig Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/lima/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] video: Fix Kconfig indentation

2019-11-20 Thread Daniel Thompson
On Wed, Nov 20, 2019 at 09:38:38PM +0800, Krzysztof Kozlowski wrote: > Adjust indentation from spaces to tab (+optional two spaces) as in > coding style with command like: > $ sed -e 's/^/\t/' -i */Kconfig > > Signed-off-by: Krzysztof Kozlowski No particular objections but I

Re: [PULL] topic/drm-mipi-dsi-dsc-updates

2019-11-20 Thread Jani Nikula
On Wed, 20 Nov 2019, Maarten Lankhorst wrote: > Op 14-11-2019 om 15:35 schreef Jani Nikula: >> On Mon, 11 Nov 2019, Jani Nikula wrote: >>> Hi Sean, Maarten and Maxime - >>> >>> Here's the topic branch about DSI changes as I wrote in [1]. Once you've >>> pulled this in drm-misc, I'll follow suit

Re: [PATCH v1 3/5] fbtft: Drop useless #ifdef CONFIG_OF and dead code

2019-11-20 Thread Noralf Trønnes
Den 20.11.2019 10.57, skrev Andy Shevchenko: > First of all there is no need to guard GPIO request by CONFIG_OF. > It works for everybody independently on resource provider. While here, > rename the function to reflect the above. > > Moreover, since we have a global dependency to OF, the rest

Re: [PATCH v2] drm/gem: Fix mmap fake offset handling for drm_gem_object_funcs.mmap

2019-11-20 Thread Gerd Hoffmann
Hi, > > I can see now why you want a private address space for each object. > > Does that imply we need an anon_inode for each gem object? Or is > > there some more lightweight way to do this? > > I have no idea whether we can get a address_space struct without an inode > (and no disasters).

[Bug 80684] I2C-over-AUX drops single bytes

2019-11-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80684 Martin Peres changed: What|Removed |Added Resolution|--- |MOVED Status|NEW

Re: [PATCH v3 4/4] dt-bindings: display: add IMX MIPI DSI host controller doc

2019-11-20 Thread Neil Armstrong
Hi, On 18/11/2019 16:25, Adrian Ratiu wrote: A small commit log would be welcome here. > Signed-off-by: Sjoerd Simons > Signed-off-by: Martyn Welch > Signed-off-by: Adrian Ratiu > --- > .../bindings/display/imx/mipi-dsi.txt | 56 +++ > 1 file changed, 56

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-20 Thread Karol Herbst
On Wed, Nov 20, 2019 at 12:48 PM Rafael J. Wysocki wrote: > > On Wed, Nov 20, 2019 at 12:22 PM Mika Westerberg > wrote: > > > > On Wed, Nov 20, 2019 at 11:52:22AM +0100, Rafael J. Wysocki wrote: > > > On Wed, Nov 20, 2019 at 11:18 AM Mika Westerberg > > > wrote: > > > > > > > > Hi Karol, > > >

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-11-20 Thread Mika Westerberg
On Wed, Nov 20, 2019 at 01:22:16PM +0200, Mika Westerberg wrote: > If (((OSYS <= 0x07D9) || ((OSYS == 0x07DF) && (_REV == > 0x05 > { The OSYS comes from this (in DSDT): If (_OSI ("Windows 2009")) {

[Bug 94153] Unresponsive system on boot with radeon + HD 3870

2019-11-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94153 Martin Peres changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[PATCH] drm/msm: Don't init ww_mutec acquire ctx before needed

2019-11-20 Thread Daniel Vetter
For locking semantics it really doesn't matter when we grab the ticket. But for lockdep validation it does: the acquire ctx is a fake lockdep. Since other drivers might want to do a full multi-lock dance in their fault-handler, not just lock a single dma_resv. Therefore we must init the

Re: [PATCH 1/3] drm/modeset: Prime modeset lock vs dma_resv

2019-11-20 Thread Daniel Vetter
On Wed, Nov 20, 2019 at 09:34:03AM +0100, Christian König wrote: > Am 19.11.19 um 22:08 schrieb Daniel Vetter: > > It's kinda really hard to get this wrong on a driver with both display > > and dma_resv locking. But who ever knows, so better to make sure that > > really all drivers nest these the

locking refcounting for ttm_bo_kmap/dma_buf_vmap

2019-11-20 Thread Daniel Vetter
Hi all, I've been looking at dma_buf_v(un)map, with a goal to standardize locking for at least dynamic dma-buf exporters/importers, most likely by requiring dma_resv_lock. And I got questions around how this is supposed to work, since a big chunk of drivers seem to entirely lack locking around

[Bug 89971] HDMI out *not* working with radeon (mobile 8550g)

2019-11-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89971 Martin Peres changed: What|Removed |Added Resolution|--- |MOVED Status|NEW

[Bug 99163] Radeon HDMI audio lost after resuming from suspend on kernel >4.2

2019-11-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99163 Martin Peres changed: What|Removed |Added Resolution|--- |MOVED Status|NEW

[Bug 97157] MST displays fail to wake

2019-11-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97157 Martin Peres changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: Bugzilla to Gitlabs migration - No email updates ?

2019-11-20 Thread Pekka Paalanen
On Tue, 19 Nov 2019 09:05:13 -0600 John Donnelly wrote: > Does gitlab not generate email when a comment is added to a ticket ? It does if your Gitlab notification settings are set that way. There are your global, your per organization, and your per project notification settings, and also the

RE: [PATCH] drm/r128: make ATI PCI GART part of its only user, r128

2019-11-20 Thread Jani Nikula
On Tue, 19 Nov 2019, "Deucher, Alexander" wrote: >> -Original Message- >> From: Jani Nikula >> Sent: Tuesday, November 19, 2019 5:06 AM >> To: dri-devel@lists.freedesktop.org >> Cc: Jani Nikula ; Deucher, Alexander >> ; Daniel Vetter ; >> Dave Airlie >> Subject: [PATCH] drm/r128: make

Re: [PATCH] drm/dsc: Return unsigned long on compute offset

2019-11-20 Thread Ville Syrjälä
On Tue, Nov 19, 2019 at 04:11:43PM -0500, Mikita Lipski wrote: > > > On 19/11/2019 16:09, Mikita Lipski wrote: > > > > > > On 19/11/2019 12:11, Ville Syrjälä wrote: > >> On Tue, Nov 19, 2019 at 04:59:40PM +, Cornij, Nikola wrote: > >>> If you're going to make all of them the same, then

  1   2   >