Re: [PATCH v6 02/16] dt-bindings: mediatek: add vdosys1 MERGE property for mt8195

2021-10-15 Thread Chun-Kuang Hu
Hi, Nancy: Nancy.Lin 於 2021年10月4日 週一 下午2:21寫道: > > MT8195 vdosys1 merge1 to merge4 have HW mute function. > Add MERGE additional mute property description. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Nancy.Lin > --- > .../devicetree/bindings/display/mediatek/mediatek,merge.yaml | 4

Re: [PATCH] drm: panel: replace snprintf in show functions with sysfs_emit

2021-10-15 Thread Sam Ravnborg
Hi Qing and Sebastian. On Fri, Oct 15, 2021 at 01:11:39PM +0200, Sebastian Reichel wrote: > Hi, > > On Thu, Oct 14, 2021 at 11:48:10PM -0700, Qing Wang wrote: > > show() must not use snprintf() when formatting the value to be > > returned to user space. > > > > Fix the following coccicheck

Re: [bug report] drm/msm: dsi: Handle dual-channel for 6G as well

2021-10-15 Thread Dmitry Baryshkov
On Fri, 15 Oct 2021 at 04:43, Jessica Zhang wrote: > > Hey Dan, > > On 10/1/2021 5:31 AM, Dan Carpenter wrote: > > Hello Sean Paul, > > > > The patch a6bcddbc2ee1: "drm/msm: dsi: Handle dual-channel for 6G as > > well" from Jul 25, 2018, leads to the following > > Smatch static checker warning: >

Re: [PATCH 01/15] gpu/drm: make drm_add_edid_modes() consistent when updating connector->display_info

2021-10-15 Thread Claudio Suarez
On Fri, Oct 15, 2021 at 03:03:13PM +0300, Ville Syrjälä wrote: > On Fri, Oct 15, 2021 at 01:36:59PM +0200, Claudio Suarez wrote: > > According to the documentation, drm_add_edid_modes > > "... Also fills out the _display_info structure and ELD in @connector > > with any information which can be

Re: [PATCH 1/2] drm/msm/hdmi: use bulk regulator API

2021-10-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2021-10-14 17:10:59) > Switch to using bulk regulator API instead of hand coding loops. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH 0/3] drm/msm: drop old eDP support

2021-10-15 Thread abhinavk
Hi Dmitry No concerns from our side to drop this. Reviewed-by: Abhinav Kumar for the series. Thanks Abhinav On 2021-10-01 09:50, Dmitry Baryshkov wrote: MSM DRM driver has support for eDP block present on MSM 8x74/8x84 SoC families. However since addition back in 2015 this driver received

Re: [Intel-gfx] [PATCH] drm/i915: fix blank screen booting crashes

2021-10-15 Thread Jani Nikula
On Fri, 15 Oct 2021, John Harrison wrote: > On 10/15/2021 07:52, Tvrtko Ursulin wrote: >> On 04/10/2021 08:36, Jani Nikula wrote: >>> On Fri, 24 Sep 2021, Ville Syrjälä >>> wrote: On Tue, Sep 21, 2021 at 06:50:39PM -0700, Matthew Brost wrote: > From: Hugh Dickins > > 5.15-rc1

RE: [PATCH v3 7/7] drm/kmb: Enable support for framebuffer console

2021-10-15 Thread Chrisanthus, Anitha
Hi Thomas, Thanks for your review. > -Original Message- > From: Thomas Zimmermann > Sent: Thursday, October 14, 2021 5:50 AM > To: Chrisanthus, Anitha ; dri- > de...@lists.freedesktop.org > Cc: s...@ravnborg.org; Dea, Edmund J > Subject: Re: [PATCH v3 7/7] drm/kmb: Enable support for

Re: [PATCH RESEND v10 0/2] gpu: drm: add driver for ili9361 panel

2021-10-15 Thread Sam Ravnborg
Hi Daniel, On Fri, Oct 15, 2021 at 05:01:29PM +0200, Daniel Mack wrote: > This is v10 of the series. > > Resending without changes. Hmm... > > Changelog: > > v2 -> v3: > * Turn Documentation into yaml format > > v3 -> v4: > * Fix reference error in yaml file > > v4 -> v5: >

Re: [RFC PATCH] drm/panel: ilitek-ili9881d: add support for Wanchanglong W552946ABA panel

2021-10-15 Thread Sam Ravnborg
Hi Michael, > Add this panel's initialzation sequence and timing to ILI9881D driver. > Tested on px30-evb v11 Patch looks good, but we need the vendor and the compatible documented. > > Signed-off-by: Michael Trimarchi > --- > drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 238

Re: [PATCH] Revert "drm/ast: Zero is missing in detect function"

2021-10-15 Thread Kim Phillips
On 10/15/21 2:25 AM, Thomas Zimmermann wrote: Commit 572994bf18ff ("drm/ast: Zero is missing in detect function") prevents some systems from booting. Seen on Supermicro Super Server/X10SRL-F, BIOS 3.3 10/28/2020 . There's further a bug that results in KASAN: use-after-free in

Re: [Intel-gfx] [PATCH 01/15] gpu/drm: make drm_add_edid_modes() consistent when updating connector->display_info

2021-10-15 Thread Ville Syrjälä
On Fri, Oct 15, 2021 at 10:33:29PM +0300, Ville Syrjälä wrote: > On Fri, Oct 15, 2021 at 09:24:06PM +0200, Claudio Suarez wrote: > > On Fri, Oct 15, 2021 at 03:03:13PM +0300, Ville Syrjälä wrote: > > > On Fri, Oct 15, 2021 at 01:36:59PM +0200, Claudio Suarez wrote: > > > > According to the

Re: [Freedreno] [PATCH 1/2] drm/msm/hdmi: use bulk regulator API

2021-10-15 Thread abhinavk
On 2021-10-14 17:10, Dmitry Baryshkov wrote: Switch to using bulk regulator API instead of hand coding loops. Nice cleanup! Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/hdmi/hdmi.c | 34 +++

[Bug 214029] [bisected] [amdgpu] Several memory leaks in amdgpu and ttm

2021-10-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=214029 Erhard F. (erhar...@mailbox.org) changed: What|Removed |Added Attachment #298893|0 |1 is obsolete|

[PATCH] drm/msm/dp: Move debugfs files into subdirectory

2021-10-15 Thread Bjorn Andersson
In the cleanup path of the MSM DP driver the DP driver's debugfs files are destroyed by invoking debugfs_remove_recursive() on debug->root, which during initialization has been set to minor->debugfs_root. To allow cleaning up the DP driver's debugfs files either each dentry needs to be kept track

Re: [Freedreno] [PATCH] drm/msm/dp: Move debugfs files into subdirectory

2021-10-15 Thread abhinavk
On 2021-10-15 16:17, Bjorn Andersson wrote: In the cleanup path of the MSM DP driver the DP driver's debugfs files are destroyed by invoking debugfs_remove_recursive() on debug->root, which during initialization has been set to minor->debugfs_root. To allow cleaning up the DP driver's debugfs

Re: [PATCH v2 3/6] drm/meson: split out encoder from meson_dw_hdmi

2021-10-15 Thread Martin Blumenstingl
Hi Neil, On Fri, Oct 15, 2021 at 4:11 PM Neil Armstrong wrote: > > This moves all the non-DW-HDMI code where it should be: > an encoder in the drm/meson core driver. > > The bridge functions are copied as-is, except: > - the encoder init uses the simple kms helper > - the mode_set has been moved

Re: [PATCH v2 6/6] drm/meson: encoder_cvbs: switch to bridge with ATTACH_NO_CONNECTOR

2021-10-15 Thread Martin Blumenstingl
Hi Neil, Hi Sam, On Fri, Oct 15, 2021 at 4:11 PM Neil Armstrong wrote: [...] > +static const struct drm_bridge_funcs meson_encoder_cvbs_bridge_funcs = { > + .attach = meson_encoder_cvbs_attach, > + .enable = meson_encoder_cvbs_enable, > + .disable = meson_encoder_cvbs_disable,

[Bug 214029] [bisected] [amdgpu] Several memory leaks in amdgpu and ttm

2021-10-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=214029 --- Comment #17 from Erhard F. (erhar...@mailbox.org) --- v5.15-rc5 is still affected. However I reverted d02117f8efaa5fbc37437df1ae955a147a2a424a on top of v5.15-rc5 and can confirm this fixes the leak. -- You may reply to this email to add a

Re: [PATCH v6 04/16] dt-bindings: reset: mt8195: add vdosys1 reset control bit

2021-10-15 Thread Chun-Kuang Hu
Hi, Nancy: Nancy.Lin 於 2021年10月4日 週一 下午2:21寫道: > > Add vdosys1 reset control bit for MT8195 platform. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Nancy.Lin > --- > include/dt-bindings/reset/mt8195-resets.h | 12 > 1 file changed, 12 insertions(+) > > diff --git

Re: [Freedreno] [PATCH] drm/msm/dp: Only create debugfs for PRIMARY minor

2021-10-15 Thread abhinavk
On 2021-10-15 16:13, Bjorn Andersson wrote: dpu_kms_debugfs_init() and hence dp_debug_get() gets invoked for each minor being registered. But dp_debug_get() will allocate a new struct dp_debug for each call and this will be associated as dp->debug. As such dp_debug will create debugfs files in

[PATCH 2/2] drm/i915/pmu: Connect engine busyness stats from GuC to pmu

2021-10-15 Thread Umesh Nerlige Ramappa
With GuC handling scheduling, i915 is not aware of the time that a context is scheduled in and out of the engine. Since i915 pmu relies on this info to provide engine busyness to the user, GuC shares this info with i915 for all engines using shared memory. For each engine, this info contains: -

[PATCH 1/2] drm/i915/pmu: Add a name to the execlists stats

2021-10-15 Thread Umesh Nerlige Ramappa
In preparation for GuC pmu stats, add a name to the execlists stats structure so that it can be differentiated from the GuC stats. Signed-off-by: Umesh Nerlige Ramappa Acked-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/intel_engine_cs.c| 14 +++---

Re: [PATCH v8 04/12] iommu/mediatek: Add device_link between the consumer and the larb devices

2021-10-15 Thread Yong Wu
On Mon, 2021-10-11 at 14:36 +0200, Dafna Hirschfeld wrote: > > On 29.09.21 03:37, Yong Wu wrote: > > MediaTek IOMMU-SMI diagram is like below. all the consumer connect > > with > > smi-larb, then connect with smi-common. > > > > M4U > > | > > smi-common > > | >

Re: [PATCH v2 2/6] drm/meson: remove useless recursive components matching

2021-10-15 Thread Martin Blumenstingl
On Fri, Oct 15, 2021 at 4:11 PM Neil Armstrong wrote: > > The initial design was recursive to cover all port/endpoints, but only the > first layer > of endpoints should be covered by the components list. > This also breaks the MIPI-DSI init/bridge attach sequence, thus only parse the > first

Re: [PATCH v2 4/6] drm/meson: encoder_hdmi: switch to bridge DRM_BRIDGE_ATTACH_NO_CONNECTOR

2021-10-15 Thread Martin Blumenstingl
Hi Neil, On Fri, Oct 15, 2021 at 4:11 PM Neil Armstrong wrote: > > This implements the necessary change to no more use the embedded > connector in dw-hdmi and use the dedicated bridge connector driver > by passing DRM_BRIDGE_ATTACH_NO_CONNECTOR to the bridge attach call. > > The necessary

Re: [PATCH v2 6/6] drm/meson: encoder_cvbs: switch to bridge with ATTACH_NO_CONNECTOR

2021-10-15 Thread Martin Blumenstingl
On Fri, Oct 15, 2021 at 4:11 PM Neil Armstrong wrote: > > Drop the local connector and move all callback to bridge funcs in order > to leverage the generic CVBS display connector. > > This will also permit adding custom cvbs connectors for ADC based HPD > detection on some Amlogic SoC based

Re: [PATCH v2 5/6] drm/meson: rename venc_cvbs to encoder_cvbs

2021-10-15 Thread Martin Blumenstingl
On Fri, Oct 15, 2021 at 4:11 PM Neil Armstrong wrote: > > Rename the cvbs encoder to match the newly introduced meson_encoder_hdmi. > > Signed-off-by: Neil Armstrong > Acked-by: Sam Ravnborg Acked-by: Martin Blumenstingl

Re: [Freedreno] [PATCH 2/2] drm/msm/hdmi: switch to drm_bridge_connector

2021-10-15 Thread abhinavk
Hi Dmitry On 2021-10-14 17:11, Dmitry Baryshkov wrote: Merge old hdmi_bridge and hdmi_connector implementations. Use drm_bridge_connector instead. Can you please comment on the validation done on this change? Has basic bootup been verified on db820c as thats the only platform which shall use

[PATCH] drm/msm/dp: Only create debugfs for PRIMARY minor

2021-10-15 Thread Bjorn Andersson
dpu_kms_debugfs_init() and hence dp_debug_get() gets invoked for each minor being registered. But dp_debug_get() will allocate a new struct dp_debug for each call and this will be associated as dp->debug. As such dp_debug will create debugfs files in both the PRIMARY and the RENDER minor's

[PATCH v2] drm/msm/dp: Use the connector passed to dp_debug_get()

2021-10-15 Thread Bjorn Andersson
The debugfs code is provided an array of a single drm_connector. Then to access the connector, the list of all connectors of the DRM device is traversed and all non-DisplayPort connectors are skipped, to find the one and only DisplayPort connector. But as we move to support multiple DisplayPort

Re: [PATCH v6 03/16] dt-bindings: mediatek: add ethdr definition for mt8195

2021-10-15 Thread Chun-Kuang Hu
Hi, Nancy: Nancy.Lin 於 2021年10月4日 週一 下午2:21寫道: > > Add vdosys1 ETHDR definition. > > Signed-off-by: Nancy.Lin > --- > .../display/mediatek/mediatek,ethdr.yaml | 145 ++ > 1 file changed, 145 insertions(+) > create mode 100644 >

Re: [PATCH] [RESEND] drm/rcar: stop using 'imply' for dependencies

2021-10-15 Thread Laurent Pinchart
Hi Arnd, Thank you for the patch. On Mon, Sep 27, 2021 at 04:26:23PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > The meaning of the 'imply' keyword has changed recently, and neither the > old meaning (select the symbol if its dependencies are met) nor the new > meaning (enable it by

Re: [PATCH v2 3/4] dt-bindings: drm/bridge: ti-sn65dsi83: Add vcc supply bindings

2021-10-15 Thread Laurent Pinchart
Hi Maxime, On Thu, Oct 14, 2021 at 09:41:10AM +0200, Maxime Ripard wrote: > On Wed, Oct 13, 2021 at 12:37:47PM +0300, Laurent Pinchart wrote: > > On Wed, Oct 13, 2021 at 09:47:22AM +0200, Maxime Ripard wrote: > > > On Tue, Oct 12, 2021 at 08:48:42AM +0200, Alexander Stein wrote: > > > > Add a VCC

Re: [Freedreno] [PATCH] drm/msm/dp: Only create debugfs for PRIMARY minor

2021-10-15 Thread Bjorn Andersson
On Fri 15 Oct 18:44 CDT 2021, abhin...@codeaurora.org wrote: > On 2021-10-15 16:13, Bjorn Andersson wrote: > > dpu_kms_debugfs_init() and hence dp_debug_get() gets invoked for each > > minor being registered. But dp_debug_get() will allocate a new struct > > dp_debug for each call and this will

[PATCH V7 03/11] PCI/VGA: Split out vga_arb_update_default_device()

2021-10-15 Thread Huacai Chen
This patch is the first step of the rework: If there's no default VGA device, and we find a VGA device that owns the legacy VGA resources, we make that device the default. Split this logic out from vga_arbiter_add_ pci_device() into a new function, vga_arb_update_default_device(). Signed-off-by:

[PATCH V7 10/11] PCI/VGA: Use unsigned format string to print lock counts

2021-10-15 Thread Huacai Chen
From: Bjorn Helgaas In struct vga_device, io_lock_cnt and mem_lock_cnt are unsigned, but we previously printed them with "%d", the signed decimal format. Print them with the unsigned format "%u" instead. Signed-off-by: Bjorn Helgaas Signed-off-by: Huacai Chen --- drivers/gpu/vga/vgaarb.c |

[PATCH V7 09/11] PCI/VGA: Log bridge control messages when adding devices

2021-10-15 Thread Huacai Chen
Previously vga_arb_device_init() iterated through all VGA devices and indicated whether legacy VGA routing to each could be controlled by an upstream bridge. But we determine that information in vga_arbiter_add_pci_device(), which we call for every device, so we can log it there without iterating

[PATCH] Revert "drm/ast: Zero is missing in detect function"

2021-10-15 Thread Thomas Zimmermann
Commit 572994bf18ff ("drm/ast: Zero is missing in detect function") prevents some systems from booting. Seen on Supermicro Super Server/X10SRL-F, BIOS 3.3 10/28/2020 . There's further a bug that results in KASAN: use-after-free in enqueue_timer+0x4f/0x1e0 which is also triggered by commit

Re: [PATCH] drm/bridge: Ignore -EPROBE_DEFER when bridge attach fails

2021-10-15 Thread Guido Günther
Hi Sam, On Thu, Oct 14, 2021 at 09:35:20PM +0200, Sam Ravnborg wrote: > Hi Guido, > > > > > > > > > + if (ret != -EPROBE_DEFER) { > > > > #ifdef CONFIG_OF > > > > - DRM_ERROR("failed to attach bridge %pOF to encoder %s: %d\n", > > > > - bridge->of_node,

Re: [PATCH v6 14/16] drm/mediatek: add ovl_adaptor support for MT8195

2021-10-15 Thread AngeloGioacchino Del Regno
Add ovl_adaptor driver for MT8195. Ovl_adaptor is an encapsulated module and designed for simplified DRM control flow. This module is composed of 8 RDMAs, 4 MERGEs and an ETHDR. Two RDMAs merge into one layer, so this module support 4 layers. Signed-off-by: Nancy.Lin ---

Re: [RFC v1 3/6] drm: Add a capability flag to support additional flip completion signalling

2021-10-15 Thread Pekka Paalanen
On Fri, 15 Oct 2021 03:37:01 + "Kasireddy, Vivek" wrote: > Hi Pekka, > Thank you for reviewing this patch. > Hi Vivek! > > On Mon, 13 Sep 2021 16:35:26 -0700 > > Vivek Kasireddy wrote: > > > > > If a driver supports this capability, it means that there would be an > > > additional

Re: [PATCH] drm: msm: fix building without CONFIG_COMMON_CLK

2021-10-15 Thread Geert Uytterhoeven
Hi Dmitry, On Fri, Oct 15, 2021 at 2:26 AM Dmitry Baryshkov wrote: > On 13/10/2021 17:42, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > When CONFIG_COMMON_CLOCK is disabled, the 8996 specific > > phy code is left out, which results in a link failure: > > > > ld:

[PATCH V7 06/11] PCI/VGA: Prefer VGA device owns the firmware framebuffer

2021-10-15 Thread Huacai Chen
This patch is the fourth step of the rework: On X86 and IA64 platform, update default VGA device if the new found device owns the firmware framebuffer because it is the most preferred. Signed-off-by: Huacai Chen Signed-off-by: Bjorn Helgaas --- drivers/gpu/vga/vgaarb.c | 45

[PATCH] drm: nouveau: replace snprintf in show functions with sysfs_emit

2021-10-15 Thread Qing Wang
show() must not use snprintf() when formatting the value to be returned to user space. Fix the following coccicheck warning: drivers/gpu/drm/nouveau/nouveau_hwmon.c:43:8-16: WARNING: use scnprintf or sprintf. drivers/gpu/drm/nouveau/nouveau_hwmon.c:57:8-16: WARNING: use scnprintf or sprintf.

[PATCH] drm: arm: replace snprintf in show functions with sysfs_emit

2021-10-15 Thread Qing Wang
show() must not use snprintf() when formatting the value to be returned to user space. Fix the following coccicheck warning: drivers/gpu/drm/arm/malidp_drv.c:657:8-16: WARNING: use scnprintf or sprintf. Use sysfs_emit instead of scnprintf or sprintf makes more sense. Signed-off-by: Qing Wang

[PATCH] amdgpu: replace snprintf in show functions with sysfs_emit

2021-10-15 Thread Qing Wang
show() must not use snprintf() when formatting the value to be returned to user space. Fix the following coccicheck warning: drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c:427: WARNING: use scnprintf or sprintf. Signed-off-by: Qing Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 2 +- 1 file

[PATCH V7 11/11] PCI/VGA: Replace full MIT license text with SPDX identifier

2021-10-15 Thread Huacai Chen
From: Bjorn Helgaas Per Documentation/process/license-rules.rst, the SPDX MIT identifier is equivalent to including the entire MIT license text from LICENSES/preferred/MIT. Replace the MIT license text with the equivalent SPDX identifier. Signed-off-by: Bjorn Helgaas Signed-off-by: Huacai

[PATCH -next] drm/v3d: nullify pointer se with a NULL

2021-10-15 Thread Yang Li
Currently a plain integer is being used to nullify the pointer struct v3d_submit_ext *se. Use NULL instead. Cleans up sparse warnings: drivers/gpu/drm/v3d/v3d_gem.c:777:53: warning: Using plain integer as NULL pointer drivers/gpu/drm/v3d/v3d_gem.c:1010:45: warning: Using plain integer as NULL

Re: [bug report] drm/msm: dsi: Handle dual-channel for 6G as well

2021-10-15 Thread Dan Carpenter
On Thu, Oct 14, 2021 at 06:43:22PM -0700, Jessica Zhang wrote: > Hey Dan, > > On 10/1/2021 5:31 AM, Dan Carpenter wrote: > > Hello Sean Paul, > > > > The patch a6bcddbc2ee1: "drm/msm: dsi: Handle dual-channel for 6G as > > well" from Jul 25, 2018, leads to the following > > Smatch static checker

[PATCH v3 07/10] drm/gma500: Inline psb_gtt_{alloc, free}_range() into rsp callers

2021-10-15 Thread Thomas Zimmermann
psb_gtt_alloc_range() allocates struct gtt_range, create the GTT resource and performs some half-baked initialization. Inline the function into its only caller psb_gem_create(). For creating the GTT resource, introduce a new helper, psb_gtt_alloc_resource() that hides the details of the GTT. For

[PATCH v3 10/10] drm/gma500: Rename struct gtt_range to struct psb_gem_object

2021-10-15 Thread Thomas Zimmermann
struct gtt_range represents a GEM object. Rename the structure to struct psb_gem_object and update all users. No functional changes. Signed-off-by: Thomas Zimmermann Acked-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/framebuffer.c | 9 +- drivers/gpu/drm/gma500/gem.c |

[PATCH v3 08/10] drm/gma500: Set page-caching flags in GEM pin/unpin

2021-10-15 Thread Thomas Zimmermann
Caching of the GEM object's backing pages are unrelated to GTT management. Move the respective calls from GTT code to GEM code. Signed-off-by: Thomas Zimmermann Acked-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/gem.c | 9 - drivers/gpu/drm/gma500/gtt.c | 17 ++---

[PATCH v3 01/10] drm/gma500: Move helpers for struct gtt_range from gtt.c to gem.c

2021-10-15 Thread Thomas Zimmermann
Allocation and pinning helpers for struct gtt_range are GEM functions, so move them to gem.c. No functional changes. v2: * keep docs for psb_gtt_{attach,detach}_pages() (Patrik) Signed-off-by: Thomas Zimmermann Acked-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/framebuffer.c

[PATCH v3 09/10] drm/gma500: Rewrite GTT page insert/remove without struct gtt_range

2021-10-15 Thread Thomas Zimmermann
struct gtt_range represents a GEM object and should not be used for GTT setup. Change psb_gtt_insert() and psb_gtt_remove() to receive all necessary parameters from their caller. This also eliminates possible failure from psb_gtt_insert(). There's one exception in psb_gtt_restore(), which

[PATCH v3 04/10] drm/gma500: Allocate GTT ranges in stolen memory with psb_gem_create()

2021-10-15 Thread Thomas Zimmermann
Support private objects for stolen memory in psb_gem_create() and convert users to psb_gem_create(). For stolen memory, psb_gem_create() now initializes the GEM object via drm_gem_private_object_init(). In the fbdev setup, replace the open-coded initialization of struct gtt_range with a call to

[PATCH v3 05/10] drm/gma500: Rename psb_gtt_{pin, unpin}() to psb_gem_{pin, unpin}()

2021-10-15 Thread Thomas Zimmermann
Rename psb_gtt_pin() to psb_gem_pin() to reflect the semantics of the function. Same for psb_gtt_unpin(). No functional changes. Signed-off-by: Thomas Zimmermann Acked-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/gem.c | 8 drivers/gpu/drm/gma500/gem.h | 4 ++--

[PATCH v3 00/10] drm/gma500: Refactor GEM code

2021-10-15 Thread Thomas Zimmermann
Bring GEM code up to current standards and untangle the connection to GTT helpers. The allocation and pinning helpers for struct gtt_range are located in the GTT code, but actually part of the GEM implementation. The patchset moves them to GEM code and refactors much of the implementation. Most

[PATCH v3 03/10] drm/gma500: Reimplement psb_gem_create()

2021-10-15 Thread Thomas Zimmermann
Implement psb_gem_create() for general use. Create the GEM handle in psb_gem_create_dumb(). Allows to use psb_gem_create() for creating all of the GEM objects. While at it, clean-up drm_gem_dumb_create() to make it more readable. Signed-off-by: Thomas Zimmermann Acked-by: Patrik Jakobsson ---

[PATCH v3 06/10] drm/gma500: Inline psb_gtt_attach_pages() and psb_gtt_detach_pages()

2021-10-15 Thread Thomas Zimmermann
psb_gtt_attach_pages() are not GTT functions but deal with the GEM object's SHMEM pages. The only callers of psb_gtt_attach_pages() and psb_gtt_detach_pages() are the GEM pin helpers. Inline the calls and cleanup the resulting code. v2: * unlock gtt_mutex in pin-error handling (Patrik)

[PATCH v3 02/10] drm/gma500: Use to_gtt_range() everywhere

2021-10-15 Thread Thomas Zimmermann
Convert upcasts from struct drm_gem_object to struct gtt_range to to_gtt_range(). Some places used container_of() directly. Signed-off-by: Thomas Zimmermann Acked-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/gem.c | 4 ++-- drivers/gpu/drm/gma500/gma_display.c | 7 +++ 2 files

[PATCH V7 00/11] PCI/VGA: Rework default VGA device selection

2021-10-15 Thread Huacai Chen
My original work is at [1]. Current default VGA device selection fails in some cases: - On BMC system, the AST2500 bridge [1a03:1150] does not implement PCI_BRIDGE_CTL_VGA [1]. This is perfectly legal but means the legacy VGA resources won't reach downstream devices unless they're

[PATCH V7 07/11] PCI/VGA: Remove vga_arb_select_default_device()

2021-10-15 Thread Huacai Chen
This patch is the last step of the rework: Since vga_arb_update_default_ device() is complete, we can remove vga_arb_select_default_device() and its call-site. Signed-off-by: Huacai Chen Signed-off-by: Bjorn Helgaas --- drivers/gpu/vga/vgaarb.c | 89 1

[PATCH V7 08/11] PCI/VGA: Remove empty vga_arb_device_card_gone()

2021-10-15 Thread Huacai Chen
From: Bjorn Helgaas vga_arb_device_card_gone() has always been empty. Remove it. Signed-off-by: Bjorn Helgaas Signed-off-by: Huacai Chen --- drivers/gpu/vga/vgaarb.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/drivers/gpu/vga/vgaarb.c

[PATCH] drm: panel: replace snprintf in show functions with sysfs_emit

2021-10-15 Thread Qing Wang
show() must not use snprintf() when formatting the value to be returned to user space. Fix the following coccicheck warning: drivers/gpu/drm/panel/panel-dsi-cm.c:251: WARNING: use scnprintf or sprintf. drivers/gpu/drm/panel/panel-dsi-cm.c:271: WARNING: use scnprintf or sprintf. Use sysfs_emit

Re: [PATCH 2/7] drm/meson: remove useless recursive components matching

2021-10-15 Thread Neil Armstrong
Hi Sam, On 14/10/2021 19:49, Sam Ravnborg wrote: > Hi Neil, > > one comment below. Other than that > Acked-by: Sam Ravnborg > > Sam > > On Thu, Oct 14, 2021 at 05:26:01PM +0200, Neil Armstrong wrote: >> The initial design was recursive to cover all port/endpoints, but only the >> first

Re: [PATCH v6 02/16] dt-bindings: mediatek: add vdosys1 MERGE property for mt8195

2021-10-15 Thread AngeloGioacchino Del Regno
MT8195 vdosys1 merge1 to merge4 have HW mute function. Add MERGE additional mute property description. Signed-off-by: Nancy.Lin --- .../devicetree/bindings/display/mediatek/mediatek,merge.yaml | 4 1 file changed, 4 insertions(+) Acked-By: AngeloGioacchino Del Regno

[PATCH V7 02/11] PCI/VGA: Move vga_arb_integrated_gpu() earlier in file

2021-10-15 Thread Huacai Chen
Move vga_arb_integrated_gpu() earlier in file to prepare for future patch. No functional change intended. Signed-off-by: Huacai Chen Signed-off-by: Bjorn Helgaas --- drivers/gpu/vga/vgaarb.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git

[PATCH V7 01/11] PCI/VGA: Prefer vga_default_device()

2021-10-15 Thread Huacai Chen
Use the vga_default_device() interface consistently instead of directly testing vga_default. No functional change intended. Signed-off-by: Huacai Chen Signed-off-by: Bjorn Helgaas --- drivers/gpu/vga/vgaarb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH V7 04/11] PCI/VGA: Prefer VGA device with legacy I/O enabled

2021-10-15 Thread Huacai Chen
This patch is the second step of the rework: A VGA device with legacy I/O resources enabled is more preferred than those not enabled. Signed-off-by: Huacai Chen Signed-off-by: Bjorn Helgaas --- drivers/gpu/vga/vgaarb.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-)

[PATCH V7 05/11] PCI/VGA: Prefer VGA device belongs to integrated GPU

2021-10-15 Thread Huacai Chen
This patch is the third step of the rework: A VGA device belongs to integrated GPU is more preferred than those not belong to. Signed-off-by: Huacai Chen Signed-off-by: Bjorn Helgaas --- drivers/gpu/vga/vgaarb.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/vga/vgaarb.c

Re: [RFC v2 01/22] drm: RFC for Plane Color Hardware Pipeline

2021-10-15 Thread Pekka Paalanen
On Thu, 14 Oct 2021 19:44:25 + "Shankar, Uma" wrote: > > -Original Message- > > From: Pekka Paalanen > > Sent: Wednesday, October 13, 2021 2:01 PM > > To: Shankar, Uma > > Cc: harry.wentl...@amd.com; ville.syrj...@linux.intel.com; intel- > > g...@lists.freedesktop.org;

Re: [PATCH 3/7] drm/meson: split out encoder from meson_dw_hdmi

2021-10-15 Thread Neil Armstrong
Hi, On 14/10/2021 20:07, Sam Ravnborg wrote: > Hi Neil, > > I did not verify all the code movements - but it looked correct from a > quick glance. > A few comments below, especially the use of mode_set() should be > addressed as it is deprecated. I was not sure about mode_set, will move to

Re: [PATCH 7/7] drm/meson: encoder_cvbs: switch to bridge with ATTACH_NO_CONNECTOR

2021-10-15 Thread Neil Armstrong
Hi Sam, On 14/10/2021 20:15, Sam Ravnborg wrote: > Hi Neil, > > with include order fixed and the comment below considered: > Acked-by: Sam Ravnborg > > Sam > > > On Thu, Oct 14, 2021 at 05:26:06PM +0200, Neil Armstrong wrote: >> Drop the local connector and move all callback to bridge

Re: [PATCH 4/7] drm/bridge: synopsys: dw-hdmi: also allow interlace on bridge

2021-10-15 Thread Neil Armstrong
Hi Sam, On 14/10/2021 20:08, Sam Ravnborg wrote: > On Thu, Oct 14, 2021 at 05:26:03PM +0200, Neil Armstrong wrote: >> Since we allow interlace on the encoder, also allow it on the bridge >> so we can allow interlaced modes when using DRM_BRIDGE_ATTACH_NO_CONNECTOR. >> >> Signed-off-by: Neil

Re: [lib/stackdepot] 1cd8ce52c5: BUG:unable_to_handle_page_fault_for_address

2021-10-15 Thread Vlastimil Babka
On 10/14/21 12:16, Mike Rapoport wrote: > On Thu, Oct 14, 2021 at 11:33:03AM +0200, Vlastimil Babka wrote: >> On 10/14/21 10:54, kernel test robot wrote: >> >> In my local testing of the patch, when stackdepot was initialized through >> page owner init, it was using kvmalloc() so

RE: [PATCH v3 7/7] drm/kmb: Enable support for framebuffer console

2021-10-15 Thread Chrisanthus, Anitha
Hi Thomas, Thanks for your review. > -Original Message- > From: Thomas Zimmermann > Sent: Thursday, October 14, 2021 6:08 AM > To: Chrisanthus, Anitha ; dri- > de...@lists.freedesktop.org > Cc: s...@ravnborg.org; Dea, Edmund J > Subject: Re: [PATCH v3 7/7] drm/kmb: Enable support for

Re: [PATCH 0/9] treewide: simplify getting .driver_data

2021-10-15 Thread Bjorn Andersson
On Mon, 20 Sep 2021 11:05:12 +0200, Wolfram Sang wrote: > I got tired of fixing this in Renesas drivers manually, so I took the big > hammer. Remove this cumbersome code pattern which got copy-pasted too much > already: > > - struct platform_device *pdev = to_platform_device(dev); > -

Re: [PATCH v2 3/6] drm/meson: split out encoder from meson_dw_hdmi

2021-10-15 Thread Sam Ravnborg
Hi Neil, On Fri, Oct 15, 2021 at 04:11:04PM +0200, Neil Armstrong wrote: > This moves all the non-DW-HDMI code where it should be: > an encoder in the drm/meson core driver. > > The bridge functions are copied as-is, except: > - the encoder init uses the simple kms helper > - the mode_set has

Re: [PATCH] drm: Update MST First Link Slot Information Based on Encoding Format

2021-10-15 Thread Lyude Paul
[snip] On Thu, 2021-10-14 at 16:21 -0400, Bhawanpreet Lakha wrote: > > Thanks for the response, > > That function is per port (drm_dp_atomic_find_vcpi_slots) so not sure > how that will work, maybe I don't understand what you mean? Yeah - drm_dp_atomic_find_vcpi_slots() is just one part of

Re: [PATCH] drm: Update MST First Link Slot Information Based on Encoding Format

2021-10-15 Thread Lyude Paul
[more snip] On Fri, 2021-10-15 at 15:43 -0400, Bhawanpreet Lakha wrote: > > > Thanks for the response, > > That function is per port so not sure how that will work. Also we only > need to check this inside drm_dp_mst_atomic_check_vcpi_alloc_limit(), > which doesn't have a state. > > We could

[PATCH v3 3/6] drm/connector: use drm_sysfs_connector_hotplug_event

2021-10-15 Thread Simon Ser
In drm_connector_register, use drm_sysfs_connector_hotplug_event instead of drm_sysfs_hotplug_event, because the hotplug event only updates a single connector. Signed-off-by: Simon Ser --- drivers/gpu/drm/drm_connector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v3 5/6] drm/probe-helper: use drm_kms_helper_connector_hotplug_event

2021-10-15 Thread Simon Ser
If an hotplug event only updates a single connector, use drm_kms_helper_connector_hotplug_event instead of drm_kms_helper_hotplug_event. Signed-off-by: Simon Ser --- drivers/gpu/drm/drm_probe_helper.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git

[PATCH v3 6/6] i915/display/dp: send a more fine-grained link-status uevent

2021-10-15 Thread Simon Ser
When link-status changes, send a hotplug uevent which contains the connector and property ID. That way, user-space can more easily figure out that only the link-status property of this connector has been updated. Signed-off-by: Simon Ser --- drivers/gpu/drm/i915/display/intel_dp.c | 2 ++ 1

[PATCH v3 4/6] amdgpu: use drm_kms_helper_connector_hotplug_event

2021-10-15 Thread Simon Ser
When updating a single connector, use drm_kms_helper_connector_hotplug_event instead of drm_kms_helper_hotplug_event. Signed-off-by: Simon Ser --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 4 ++-- 2 files

[PATCH v3 0/6] drm: add per-connector hotplug events

2021-10-15 Thread Simon Ser
When a uevent only updates a single connector, add a CONNECTOR property to the uevent. This allows user-space to ignore other connectors when handling the uevent. This is purely an optimization, drivers can still send a uevent without the CONNECTOR property. The CONNECTOR property is already set

[PATCH v3 2/6] drm/probe-helper: add drm_kms_helper_connector_hotplug_event

2021-10-15 Thread Simon Ser
This function is the same as drm_kms_helper_hotplug_event, but takes a connector instead of a device. Signed-off-by: Simon Ser --- drivers/gpu/drm/drm_probe_helper.c | 23 +++ include/drm/drm_probe_helper.h | 1 + 2 files changed, 24 insertions(+) diff --git

[PATCH v3 1/6] drm/sysfs: introduce drm_sysfs_connector_hotplug_event

2021-10-15 Thread Simon Ser
This function sends a hotplug uevent with a CONNECTOR property. Signed-off-by: Simon Ser --- drivers/gpu/drm/drm_sysfs.c | 25 + include/drm/drm_sysfs.h | 1 + 2 files changed, 26 insertions(+) diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c

Re: [Intel-gfx] [PATCH 15/15] drm/i915: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-15 Thread Claudio Suarez
On Fri, Oct 15, 2021 at 03:30:49PM +0300, Ville Syrjälä wrote: > On Fri, Oct 15, 2021 at 01:37:13PM +0200, Claudio Suarez wrote: > > Once EDID is parsed, the monitor HDMI support information is available > > through drm_display_info.is_hdmi. Retriving the same information with > >

[PULL] drm-intel-next

2021-10-15 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-next-2021-10-15: Likely the last one towards 5.15. UAPI Changes: - No Functional change, but a clarification around I915_TILING values (Matt). Driver Changes: - Changes around async flip VT-d w/a (Ville) - Delete bogus NULL check in

Re: [Intel-gfx] [PATCH 15/15] drm/i915: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-15 Thread Claudio Suarez
On Fri, Oct 15, 2021 at 06:18:34PM +0300, Jani Nikula wrote: > On Fri, 15 Oct 2021, Ville Syrjälä wrote: > > On Fri, Oct 15, 2021 at 03:44:48PM +0300, Jani Nikula wrote: > >> On Fri, 15 Oct 2021, Claudio Suarez wrote: > >> > Once EDID is parsed, the monitor HDMI support information is available

Re: [PATCH] dt-bindings: display/bridge: ptn3460: Convert to YAML binding

2021-10-15 Thread Sam Ravnborg
Hi AngeloGioacchino, On Thu, Oct 07, 2021 at 09:58:22AM +0200, AngeloGioacchino Del Regno wrote: > Convert the NXP PTN3460 eDP to LVDS bridge documentation to YAML. > > Signed-off-by: AngeloGioacchino Del Regno > Applied to drm-misc-next with Rob's r-b. It will show up in -next in 1-2 weeks.

Re: [PATCH 01/15] gpu/drm: make drm_add_edid_modes() consistent when updating connector->display_info

2021-10-15 Thread Ville Syrjälä
On Fri, Oct 15, 2021 at 09:24:06PM +0200, Claudio Suarez wrote: > On Fri, Oct 15, 2021 at 03:03:13PM +0300, Ville Syrjälä wrote: > > On Fri, Oct 15, 2021 at 01:36:59PM +0200, Claudio Suarez wrote: > > > According to the documentation, drm_add_edid_modes > > > "... Also fills out the _display_info

Re: [PATCH v3 1/6] drm/sysfs: introduce drm_sysfs_connector_hotplug_event

2021-10-15 Thread Sam Ravnborg
On Fri, Oct 15, 2021 at 09:37:04PM +0200, Sam Ravnborg wrote: > Hi Simon, > > On Fri, Oct 15, 2021 at 04:33:41PM +, Simon Ser wrote: > > This function sends a hotplug uevent with a CONNECTOR property. > > A little late feedback. > > Sam If you keep current code then patch is:

Re: [PATCH v3 5/6] drm/probe-helper: use drm_kms_helper_connector_hotplug_event

2021-10-15 Thread Sam Ravnborg
Hi Simon, On Fri, Oct 15, 2021 at 04:33:45PM +, Simon Ser wrote: > If an hotplug event only updates a single connector, use > drm_kms_helper_connector_hotplug_event instead of > drm_kms_helper_hotplug_event. > > Signed-off-by: Simon Ser > --- > drivers/gpu/drm/drm_probe_helper.c | 20

Re: [PATCH] video: fbdev: replace snprintf in show functions with sysfs_emit

2021-10-15 Thread Sam Ravnborg
Hi Qing, On Tue, Oct 12, 2021 at 08:28:00PM -0700, Qing Wang wrote: > coccicheck complains about the use of snprintf() in sysfs show functions. > > Fix the coccicheck warning: > WARNING: use scnprintf or sprintf. > > Use sysfs_emit instead of scnprintf or sprintf makes more sense. > >

Re: [PATCH] video: omapfb: replace snprintf in show functions with sysfs_emit

2021-10-15 Thread Sam Ravnborg
Hi Qing, On Tue, Oct 12, 2021 at 08:28:13PM -0700, Qing Wang wrote: > coccicheck complains about the use of snprintf() in sysfs show functions. > > Fix the coccicheck warning: > WARNING: use scnprintf or sprintf. > > Use sysfs_emit instead of scnprintf or sprintf makes more sense. > >

Re: [PATCH] drm: panel-orientation-quirks: Add quirk for Aya Neo 2021

2021-10-15 Thread Sam Ravnborg
Hi Bryant, On Fri, Oct 01, 2021 at 03:16:18PM -0700, Bryant Mairs wrote: > Signed-off-by: Bryant Mairs Patch looks fine, but I do not accept empty changelogs. At a minimum describe in the changelog what device benefit from this quirk. Sam

Re: [bug report] drm/msm: dsi: Handle dual-channel for 6G as well

2021-10-15 Thread Jessica Zhang
On 10/15/2021 1:12 AM, Dan Carpenter wrote: On Thu, Oct 14, 2021 at 06:43:22PM -0700, Jessica Zhang wrote: Hey Dan, On 10/1/2021 5:31 AM, Dan Carpenter wrote: Hello Sean Paul, The patch a6bcddbc2ee1: "drm/msm: dsi: Handle dual-channel for 6G as well" from Jul 25, 2018, leads to the

Re: [PATCH v3 5/6] drm/probe-helper: use drm_kms_helper_connector_hotplug_event

2021-10-15 Thread Ville Syrjälä
On Fri, Oct 15, 2021 at 04:33:45PM +, Simon Ser wrote: > If an hotplug event only updates a single connector, use > drm_kms_helper_connector_hotplug_event instead of > drm_kms_helper_hotplug_event. > > Signed-off-by: Simon Ser > --- > drivers/gpu/drm/drm_probe_helper.c | 20

  1   2   >