[PATCH libdrm v2 18/25] tests: tegra: Add VIC support

2022-02-17 Thread Thierry Reding
From: Thierry Reding Implement a small abstraction interface to allow different versions of VIC to be used transparently. An implementation will be chosen based on the VIC version number reported by the DRM_TEGRA_IOCTL_OPEN_CHANNEL IOCTL. Signed-off-by: Thierry Reding --- tests/tegra/host1x.h

[PATCH libdrm v2 17/25] tests: tegra: Add syncpoint timeout test

2022-02-17 Thread Thierry Reding
From: Thierry Reding This test can be used to purposefully trigger a job timeout. Signed-off-by: Thierry Reding --- tests/tegra/meson.build | 9 ++ tests/tegra/syncpt-timeout.c | 163 +++ 2 files changed, 172 insertions(+) create mode 100644

[PATCH libdrm v2 16/25] tests: tegra: Add syncpt-wait test

2022-02-17 Thread Thierry Reding
From: Thierry Reding This is a very simple sanity test to check whether or not a syncpt can be incremented by a host1x client. This uses gr2d on Tegra20 through Tegra114 and VIC on Tegra124 and later. Signed-off-by: Thierry Reding --- tests/tegra/meson.build | 9 +++

[PATCH libdrm v2 15/25] tests: tegra: Add gr2d-fill test

2022-02-17 Thread Thierry Reding
From: Thierry Reding This test uses the IOCTLs for job submission and fences to fill a sub- region of the screen to a specific color using gr2d. Signed-off-by: Thierry Reding --- tests/tegra/.gitignore | 1 + tests/tegra/drm-test-tegra.c | 147 +++

[PATCH libdrm v2 14/25] tests: tegra: Add helper library for tests

2022-02-17 Thread Thierry Reding
From: Thierry Reding This library provides helpers for common functionality needed by test programs. Signed-off-by: Thierry Reding --- tests/tegra/drm-test.c | 248 tests/tegra/drm-test.h | 72 tests/tegra/meson.build | 7 ++ 3 files

[PATCH libdrm v2 13/25] tegra: Add syncpoint APIs

2022-02-17 Thread Thierry Reding
From: Thierry Reding These new functions can be used to allocate and free syncpoints, as well as wait for a syncpoint threshold to be reached. Jobs can also be waited on if a syncpoint was attached to them. Signed-off-by: Thierry Reding --- tegra/job.c | 23 +

[PATCH libdrm v2 12/25] tegra: Add job and push buffer APIs

2022-02-17 Thread Thierry Reding
From: Thierry Reding These new functions can be used to create a job on a given channel, add commands to the job using its push buffer and submit the job. Signed-off-by: Thierry Reding --- tegra/job.c | 164 tegra/meson.build | 2 +-

[PATCH libdrm v2 11/25] tegra: Add channel APIs

2022-02-17 Thread Thierry Reding
From: Thierry Reding These new functions can be used to open a channel to a given engine, map and unmap buffer objects to that channel, and close the channel. Signed-off-by: Thierry Reding --- tegra/channel.c | 195 tegra/meson.build |

[PATCH libdrm v2 10/25] tegra: Include private.h in list of source files

2022-02-17 Thread Thierry Reding
From: Thierry Reding This makes sure that the proper dependencies are created and that the file is distributed. Signed-off-by: Thierry Reding --- tegra/meson.build | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tegra/meson.build b/tegra/meson.build index

[PATCH libdrm v2 09/25] tegra: Update for new UABI

2022-02-17 Thread Thierry Reding
From: Thierry Reding This new UABI is a more modern version that works better with both old and recent chips. Signed-off-by: Thierry Reding --- include/drm/tegra_drm.h | 429 +--- 1 file changed, 404 insertions(+), 25 deletions(-) diff --git

[PATCH libdrm v2 08/25] tegra: Install tegra-openclose test

2022-02-17 Thread Thierry Reding
From: Thierry Reding Allow this simple test to be installed so that it can easily be run on a target device. Signed-off-by: Thierry Reding --- tests/tegra/.gitignore | 2 +- tests/tegra/meson.build | 7 +-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git

[PATCH libdrm v2 07/25] tegra: Make API more consistent

2022-02-17 Thread Thierry Reding
From: Thierry Reding Most functions in libdrm_tegra take as first parameter the object that they operate on. Make the device and buffer object creation functions follow the same scheme. Signed-off-by: Thierry Reding --- tegra/tegra.c | 13 +++-- tegra/tegra.h | 10

[PATCH libdrm v2 06/25] tegra: Add PRIME support helpers

2022-02-17 Thread Thierry Reding
From: Thierry Reding These helpers facilitate exporting and importing buffer objects to and from PRIME file descriptors. Signed-off-by: Thierry Reding --- Changes in v3: - add drm_public annotations --- tegra/tegra-symbols.txt | 2 ++ tegra/tegra.c | 61

[PATCH libdrm v2 03/25] tegra: Extract common buffer object allocation code

2022-02-17 Thread Thierry Reding
From: Thierry Reding All of the buffer object allocation functions use the same boilerplate code. Move that code into a separate function that can be reused. Signed-off-by: Thierry Reding --- tegra/tegra.c | 35 ++- 1 file changed, 22 insertions(+), 13

[PATCH libdrm v2 04/25] tegra: Fix mmap() of GEM buffer objects

2022-02-17 Thread Thierry Reding
From: Thierry Reding Store 64-bit offset values and use libdrm's built-in drm_mmap() function instead of mmap() to ensure the full 64-bit offset is used. Signed-off-by: Thierry Reding --- tegra/private.h | 2 +- tegra/tegra.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff

[PATCH libdrm v2 05/25] tegra: Add flink helpers

2022-02-17 Thread Thierry Reding
From: Thierry Reding Add helpers to export and import buffer objects via flink names. Signed-off-by: Thierry Reding --- Changes in v3: - add drm_public annotations --- tegra/tegra-symbols.txt | 2 ++ tegra/tegra.c | 50 + tegra/tegra.h

[PATCH libdrm v2 01/25] tegra: Indent according to .editorconfig

2022-02-17 Thread Thierry Reding
From: Thierry Reding Reindent the sources according to the settings found in the newly added .editorconfig. Signed-off-by: Thierry Reding --- tegra/private.h | 18 +-- tegra/tegra.c | 348 tegra/tegra.h | 12 +-

[PATCH libdrm v2 02/25] tegra: Remove unused IOCTL implementations

2022-02-17 Thread Thierry Reding
From: Thierry Reding The DRM_TEGRA_GEM_{GET,SET}_FLAGS and DRM_TEGRA_GEM_{GET,SET}_TILING IOCTLs were badly designed and have since been obsoleted by framebuffer modifiers. Remove these implementations to make it clear their usage is discouraged. Signed-off-by: Thierry Reding ---

[PATCH libdrm v2 00/25] Update Tegra support

2022-02-17 Thread Thierry Reding
From: Thierry Reding Hi all, this is the userspace part of the kernel patches that were recently merged into drm-next: https://patchwork.freedesktop.org/series/92378/ The goal is to provide a userspace implementation of the UAPI exposed by the kernel and show its usage in some test programs

[PATCH] drm/i915/guc/slpc: Use wrapper for reading RP_STATE_CAP

2022-02-17 Thread Vinay Belgaumkar
This will ensure correct values for Gen12+ platforms. v2: Rebase Cc: Matt Roper Reviewed-by: Matt Roper Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] drm/i915/perf: Skip the i915_perf_init for dg2

2022-02-17 Thread Umesh Nerlige Ramappa
On Tue, Feb 15, 2022 at 11:01:15AM +0530, Ramalingam C wrote: i915_perf is not enabled for dg2 yet, hence skip the feature initialization. Signed-off-by: Ramalingam C cc: Umesh Nerlige Ramappa --- drivers/gpu/drm/i915/i915_perf.c | 4 1 file changed, 4 insertions(+) diff --git

Re: [PATCH] drm/i915/guc/slpc: Correct the param count for unset param

2022-02-17 Thread Umesh Nerlige Ramappa
On Wed, Feb 16, 2022 at 10:15:04AM -0800, Vinay Belgaumkar wrote: SLPC unset param H2G only needs one parameter - the id of the param. Fixes: 025cb07bebfa ("drm/i915/guc/slpc: Cache platform frequency limits") Suggested-by: Umesh Nerlige Ramappa Signed-off-by: Vinay Belgaumkar ---

Re: [PATCH] drm/amdgpu: fix amdgpu_ras_block_late_init error handler

2022-02-17 Thread Alex Deucher
On Thu, Feb 17, 2022 at 2:04 PM Nick Desaulniers wrote: > > On Thu, Feb 17, 2022 at 8:16 AM Alex Deucher wrote: > > > > Applied. Thanks! > > > > Alex > > Alex, > Has AMD been able to set up clang builds, yet? No. I think some individual teams do, but it's never been integrated into our larger

[Bug 215618] New: vblank related lockup during start of SteamVR using Valve Index HMD

2022-02-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215618 Bug ID: 215618 Summary: vblank related lockup during start of SteamVR using Valve Index HMD Product: Drivers Version: 2.5 Kernel Version: 5.16.9 Hardware: All

[PATCH v2 1/3] drm/i915/dg2: Enable 5th port

2022-02-17 Thread Ramalingam C
From: Matt Roper DG2 supports a 5th display output which the hardware refers to as "TC1," even though it isn't a Type-C output. This behaves similarly to the TC1 on past platforms with just a couple minor differences: * DG2's TC1 bit in SDEISR is at bit 25 rather than 24 as it is on

[PATCH v4 0/3] drm/msm/dp: replace DRM_DEBUG_DP with drm_dbg_dp

2022-02-17 Thread Kuogee Hsieh
Since DRM_DEBUG_DP is deprecated in favor of drm_dbg_dp(NULL, ...), replace all DRM_DEBUG_DP with drm_dbg_dp(). Kuogee Hsieh (3): drm/msm/dp: add connector type to enhance debug messages drm/msm/dp: enhance debug info related to dp phy drm/msm/dp: replace DRM_DEBUG_DP marco with drm_dbg_dp

[PATCH v4 3/3] drm/msm/dp: replace DRM_DEBUG_DP marco with drm_dbg_dp

2022-02-17 Thread Kuogee Hsieh
Since DRM_DEBUG_DP is deprecated in favor of drm_dbg_dp(NULL, ...), this patch replace all DRM_DEBUG_DP with drm_dbg_dp(). Changes in v4: -- replace (strucr drm_dev *)NULL with drm_dev Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_audio.c | 50 ++--

[PATCH v4 2/3] drm/msm/dp: enhance debug info related to dp phy

2022-02-17 Thread Kuogee Hsieh
DP phy should be initialized and exited symmetrically to avoid clock being stucked at either on or off error. Add debug info to cover all DP phy to identify clock issues easily. Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 20 ++--

[PATCH v4 1/3] drm/msm/dp: add connector type to enhance debug messages

2022-02-17 Thread Kuogee Hsieh
DP driver is a generic driver which supports both eDP and DP. For debugging purpose it is required to have capabilities to differentiate message are generated from eDP or DP. This patch add connector type into debug messages for this purpose. Changes in v3: -- replace original patch into 3

[Bug 36522] Caught 16-bit read from uninitialized memory in drm_fb_helper_setcmap

2022-02-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=36522 Christian Casteyde (casteyde.christ...@free.fr) changed: What|Removed |Added Status|RESOLVED|CLOSED

[Bug 36522] Caught 16-bit read from uninitialized memory in drm_fb_helper_setcmap

2022-02-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=36522 Christian Casteyde (casteyde.christ...@free.fr) changed: What|Removed |Added Status|ASSIGNED|RESOLVED

Re: [PATCH v4 3/4] drm/i915/uapi: Add struct drm_i915_query_hwconfig_blob_item

2022-02-17 Thread Daniel Vetter
On Wed, Feb 9, 2022 at 11:45 PM Jordan Justen wrote: > > Also, document DRM_I915_QUERY_HWCONFIG_BLOB with this struct. > > v3: > * Add various changes suggested by Tvrtko > > Cc: Daniel Vetter > Signed-off-by: Jordan Justen > Acked-by: Jon Bloomfield Please check with make htmldocs that the

Re: [drm] *ERROR* mstb 0000000057b5b857 port 1: DPCD read on addr 0x4b0 for 1 bytes NAKed

2022-02-17 Thread Lyude Paul
Hi! Sorry for the late reply, I had to take some time off work unexpectedly. This is normal (although not great TBH, I'm not sure we should be printing an error message for that), it's the result of fwupd trying to probe the MST hub to see if it's a specific Dell dock that can receive updates over

[Bug 121831] Several kmemcheck: Caught 64-bit read from uninitialized memory in radeo

2022-02-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=121831 Christian Casteyde (casteyde.christ...@free.fr) changed: What|Removed |Added Status|RESOLVED|CLOSED

[Bug 121831] Several kmemcheck: Caught 64-bit read from uninitialized memory in radeo

2022-02-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=121831 Christian Casteyde (casteyde.christ...@free.fr) changed: What|Removed |Added Status|NEW

Re: [PATCH v2] drm/i915: Kill the fake lmem support

2022-02-17 Thread Matthew Auld
On Thu, 17 Feb 2022 at 17:55, Lucas De Marchi wrote: > > This was useful for early development of lmem, but it's not used > anymore, so remove it. > > v2: Remove unneeded fields from struct intel_memory_region > > Cc: Chris Wilson > Cc: Matthew Auld > Signed-off-by: Lucas De Marchi

[PATCH v2] drm/i915: Kill the fake lmem support

2022-02-17 Thread Lucas De Marchi
This was useful for early development of lmem, but it's not used anymore, so remove it. v2: Remove unneeded fields from struct intel_memory_region Cc: Chris Wilson Cc: Matthew Auld Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/Kconfig.unstable | 8 --

Re: [PATCH 1/3] drm/i915/dg2: Enable 5th display

2022-02-17 Thread Ramalingam C
On 2022-02-17 at 08:37:47 -0800, Matt Roper wrote: > Since it apparently caused some confusion on various websites, maybe we > should change the title of the patch to "Enable 5th port" to make it > more clear that this is only a port, not a pipe. Ok sure. > > Also, I believe one last line that

Re: [PATCH 0/2] DSI host and peripheral initialisation ordering

2022-02-17 Thread Dmitry Baryshkov
On Wed, 16 Feb 2022 at 20:00, Dave Stevenson wrote: > > Hi All > > Hopefully I've cc'ed all those that have bashed this problem around > previously, > or are otherwise linked to DRM bridges. > > There have been numerous discussions around how DSI support is currently > broken > as it doesn't

Re: [PATCH 02/16] dept: Implement Dept(Dependency Tracker)

2022-02-17 Thread Steven Rostedt
On Thu, 17 Feb 2022 19:57:38 +0900 Byungchul Park wrote: > diff --git a/include/linux/dept.h b/include/linux/dept.h > new file mode 100644 > index 000..2ac4bca > --- /dev/null > +++ b/include/linux/dept.h > @@ -0,0 +1,480 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + *

Re: [PATCH] drm/amdkfd: fix typo in setting enum value

2022-02-17 Thread Alex Deucher
Nathan just sent out the same patch and I already applied it. Thanks! Alex On Thu, Feb 17, 2022 at 11:41 AM wrote: > > From: Tom Rix > > Clang build fails with > kfd_packet_manager_v9.c:267:3: error: implicit conversion > from enumeration type 'enum mes_map_queues_extended_engine_sel_enum'

Re: [PATCH 2/8] drm/fb-helper: Add support for DRM_FORMAT_C[124]

2022-02-17 Thread Geert Uytterhoeven
Hi Simon, On Thu, Feb 17, 2022 at 5:18 PM Simon Ser wrote: > On Thursday, February 17th, 2022 at 17:12, Geert Uytterhoeven > wrote: > > > What is C0? > > > > A non-existing color-indexed mode with zero colors ;-) > > Introduced purely to make a check like in the comment below work. > > What we

RE: [Intel-gfx] [PATCH v5 15/19] drm/i915/dg2: Add DG2 unified compression

2022-02-17 Thread Chery, Nanley G
> -Original Message- > From: Juha-Pekka Heikkila > Sent: Tuesday, February 15, 2022 6:54 AM > To: Nanley Chery ; C, Ramalingam > > Cc: intel-gfx ; Chery, Nanley G > ; Auld, Matthew ; dri- > devel > Subject: Re: [Intel-gfx] [PATCH v5 15/19] drm/i915/dg2: Add DG2 unified > compression >

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Correct the param count for unset param

2022-02-17 Thread Tvrtko Ursulin
On 17/02/2022 17:04, Belgaumkar, Vinay wrote: On 2/17/2022 1:41 AM, Tvrtko Ursulin wrote: On 16/02/2022 18:15, Vinay Belgaumkar wrote: SLPC unset param H2G only needs one parameter - the id of the param. Fixes: 025cb07bebfa ("drm/i915/guc/slpc: Cache platform frequency limits") How

Re: [PATCH v5 7/7] drm/i915/gt: Adding new sysfs frequency attributes

2022-02-17 Thread Sundaresan, Sujaritha
On 2/17/2022 7:45 AM, Andi Shyti wrote: Hi, I forgot to add some note to this patch... [...] +static ssize_t throttle_reason_status_show(struct device *dev, + struct device_attribute *attr, + char *buff) +{ +

Re: [PATCH 00/16] DEPT(Dependency Tracker)

2022-02-17 Thread Matthew Wilcox
On Thu, Feb 17, 2022 at 12:00:05PM -0500, Steven Rostedt wrote: > On Thu, 17 Feb 2022 10:51:09 -0500 > "Theodore Ts'o" wrote: > > > I know that you're trying to help us, but this tool needs to be far > > better than Lockdep before we should think about merging it. Even if > > it finds 5% more

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Correct the param count for unset param

2022-02-17 Thread Belgaumkar, Vinay
On 2/17/2022 1:41 AM, Tvrtko Ursulin wrote: On 16/02/2022 18:15, Vinay Belgaumkar wrote: SLPC unset param H2G only needs one parameter - the id of the param. Fixes: 025cb07bebfa ("drm/i915/guc/slpc: Cache platform frequency limits") How serious is this? Does it need backporting? If so:

Re: [PATCH 00/16] DEPT(Dependency Tracker)

2022-02-17 Thread Steven Rostedt
On Thu, 17 Feb 2022 10:51:09 -0500 "Theodore Ts'o" wrote: > I know that you're trying to help us, but this tool needs to be far > better than Lockdep before we should think about merging it. Even if > it finds 5% more potential deadlocks, if it creates 95% more false > positive reports --- and

[PATCH] drm/amdkfd: fix typo in setting enum value

2022-02-17 Thread trix
From: Tom Rix Clang build fails with kfd_packet_manager_v9.c:267:3: error: implicit conversion from enumeration type 'enum mes_map_queues_extended_engine_sel_enum' to different enumeration type 'enum mes_unmap_queues_extended_engine_sel_enum'

Re: [PATCH v8 2/3] MIPS: Loongson64: dts: update the display controller device node

2022-02-17 Thread Rob Herring
On Thu, 17 Feb 2022 02:17:11 +0800, Sui Jingfeng wrote: > From: suijingfeng > > The display controller is a pci device, its PCI vendor id is 0x0014 > its PCI device id is 0x7a06. > > 1) In order to let the lsdc kms driver to know which chip the DC is >contained in, we add different

Re: [PATCH v9 3/4] Documentation/dt: Add descriptions for loongson display controller

2022-02-17 Thread Rob Herring
On Thu, 17 Feb 2022 18:55:22 +0800, Sui Jingfeng wrote: > From: suijingfeng > > Add DT documentation for loongson display controller found in > LS2K1000, LS2K0500, LS7A1000 and LS7A2000. > > v2: DT binding docs and includes should be a separate patch, > fix a warnning because of that. > >

Re: [PATCH 1/3] drm/i915/dg2: Enable 5th display

2022-02-17 Thread Matt Roper
Since it apparently caused some confusion on various websites, maybe we should change the title of the patch to "Enable 5th port" to make it more clear that this is only a port, not a pipe. Also, I believe one last line that we need to add to this patch is an intel_ddi_init() call for TC1 in the

Re: (subset) [PATCH] drm/vc4: hdmi: Unregister codec device on unbind

2022-02-17 Thread Maxime Ripard
On Thu, 27 Jan 2022 12:14:52 +0100, Maxime Ripard wrote: > On bind we will register the HDMI codec device but we don't unregister > it on unbind, leading to a device leakage. Unregister our device at > unbind. > > Applied to drm/drm-misc (drm-misc-fixes). Thanks! Maxime

Re: (subset) [PATCH] drm/vc4: crtc: Fix runtime_pm reference counting

2022-02-17 Thread Maxime Ripard
On Thu, 3 Feb 2022 11:20:03 +0100, Maxime Ripard wrote: > At boot on the BCM2711, if the HDMI controllers are running, the CRTC > driver will disable itself and its associated HDMI controller to work > around a hardware bug that would leave some pixels stuck in a FIFO. > > In order to avoid that

Re: [PATCH 1/3] drm/i915/dg2: Enable 5th display

2022-02-17 Thread Matt Roper
On Wed, Feb 16, 2022 at 12:02:31AM -0800, Shankar, Uma wrote: > > > > -Original Message- > > From: C, Ramalingam > > Sent: Tuesday, February 15, 2022 11:22 AM > > To: intel-gfx ; dri-devel > de...@lists.freedesktop.org> > > Cc: Ville Syrjälä ; Shankar, Uma > > ; Roper, Matthew D ; > >

Re: [PATCH] drm/amdkfd: Use proper enum in pm_unmap_queues_v9()

2022-02-17 Thread Alex Deucher
On Thu, Feb 17, 2022 at 11:22 AM Nathan Chancellor wrote: > > Clang warns: > > drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_packet_manager_v9.c:267:3: > error: implicit conversion from enumeration type 'enum > mes_map_queues_extended_engine_sel_enum' to different enumeration type > 'enum

[PATCH] drm/amdkfd: Use proper enum in pm_unmap_queues_v9()

2022-02-17 Thread Nathan Chancellor
Clang warns: drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_packet_manager_v9.c:267:3: error: implicit conversion from enumeration type 'enum mes_map_queues_extended_engine_sel_enum' to different enumeration type 'enum mes_unmap_queues_extended_engine_sel_enum' [-Werror,-Wenum-conversion]

Re: [PATCH 0/3] drm: omapdrm: Fix excessive GEM buffers DMM/CMA usage

2022-02-17 Thread Ivaylo Dimitrov
Hi Tomi, On 17.02.22 г. 15:03 ч., Tomi Valkeinen wrote: Hi Ivaylo, On 19/01/2022 12:23, Ivaylo Dimitrov wrote: This patch series fixes excessive DMM or CMA usage of GEM buffers leading to various runtime allocation failures. The series enables daily usage of devices without exausting limited

Re: [PATCH 2/8] drm/fb-helper: Add support for DRM_FORMAT_C[124]

2022-02-17 Thread Simon Ser
On Thursday, February 17th, 2022 at 17:12, Geert Uytterhoeven wrote: > > What is C0? > > A non-existing color-indexed mode with zero colors ;-) > Introduced purely to make a check like in the comment below work. > What we really want to check here is if the mode is color-indexed > or not...

Re: [PATCH] drm/vc4: crtc: Fix runtime_pm reference counting

2022-02-17 Thread Javier Martinez Canillas
Hello Maxime, On 2/3/22 11:20, Maxime Ripard wrote: > At boot on the BCM2711, if the HDMI controllers are running, the CRTC > driver will disable itself and its associated HDMI controller to work > around a hardware bug that would leave some pixels stuck in a FIFO. > > In order to avoid that

Re: [PATCH] drm/amdgpu: fix amdgpu_ras_block_late_init error handler

2022-02-17 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Feb 17, 2022 at 10:57 AM Luben Tuikov wrote: > > Thanks for catching this. > > Reviewed-by: Luben Tuikov > > Regards, > Luben > > On 2022-02-17 10:38, t...@redhat.com wrote: > > From: Tom Rix > > > > Clang build fails with > > amdgpu_ras.c:2416:7: error:

Re: [PATCH 05/23] drm/amd/display: Fix color encoding mismatch

2022-02-17 Thread Maxime Ripard
Hi Harry, On Thu, Feb 10, 2022 at 09:38:24AM -0500, Harry Wentland wrote: > On 2022-02-10 03:42, Maxime Ripard wrote: > > On Mon, Feb 07, 2022 at 01:59:38PM -0500, Harry Wentland wrote: > >> On 2022-02-07 13:57, Harry Wentland wrote: > >>> On 2022-02-07 11:34, Maxime Ripard wrote: > The

Re: [PATCH 2/8] drm/fb-helper: Add support for DRM_FORMAT_C[124]

2022-02-17 Thread Geert Uytterhoeven
Hi Thomas, Thanks for your review! On Thu, Feb 17, 2022 at 3:57 PM Thomas Zimmermann wrote: > Am 15.02.22 um 17:52 schrieb Geert Uytterhoeven: > > Add support for color-indexed frame buffer formats with two, four, and > > sixteen colors to the DRM framebuffer helper functions: > >1. Add

Re: [PATCH] drm/vc4: hdmi: Unregister codec device on unbind

2022-02-17 Thread Javier Martinez Canillas
Hello Maxime, On 1/27/22 12:14, Maxime Ripard wrote: > On bind we will register the HDMI codec device but we don't unregister > it on unbind, leading to a device leakage. Unregister our device at > unbind. > > Signed-off-by: Maxime Ripard > --- Patch looks good to me. Reviewed-by: Javier

Re: [PATCH 0/2] DSI host and peripheral initialisation ordering

2022-02-17 Thread Maxime Ripard
Hi Dave, On Wed, Feb 16, 2022 at 04:59:42PM +, Dave Stevenson wrote: > Hi All > > Hopefully I've cc'ed all those that have bashed this problem around > previously, > or are otherwise linked to DRM bridges. > > There have been numerous discussions around how DSI support is currently >

Re: [PATCH] drm/amdgpu: fix amdgpu_ras_block_late_init error handler

2022-02-17 Thread Luben Tuikov
Thanks for catching this. Reviewed-by: Luben Tuikov Regards, Luben On 2022-02-17 10:38, t...@redhat.com wrote: > From: Tom Rix > > Clang build fails with > amdgpu_ras.c:2416:7: error: variable 'ras_obj' is used uninitialized > whenever 'if' condition is true > if (adev->in_suspend ||

Re: [PATCH 10/16] dept: Add proc knobs to show stats and dependency graph

2022-02-17 Thread Steven Rostedt
On Thu, 17 Feb 2022 19:57:46 +0900 Byungchul Park wrote: > +static int __init dept_proc_init(void) > +{ > + proc_create_seq("dept_deps", S_IRUSR, NULL, _deps_ops); > + proc_create_single("dept_stats", S_IRUSR, NULL, dept_stats_show); > + return 0; > +} > + >

Re: [PATCH 02/16] dept: Implement Dept(Dependency Tracker)

2022-02-17 Thread Steven Rostedt
On Thu, 17 Feb 2022 19:57:38 +0900 Byungchul Park wrote: > diff --git a/kernel/dependency/Makefile b/kernel/dependency/Makefile > new file mode 100644 > index 000..9f7778e > --- /dev/null > +++ b/kernel/dependency/Makefile > @@ -0,0 +1,4 @@ > +# SPDX-License-Identifier: GPL-2.0 > + >

Re: [drm] *ERROR* mstb 0000000057b5b857 port 1: DPCD read on addr 0x4b0 for 1 bytes NAKed

2022-02-17 Thread Michel Dänzer
On 2022-02-16 15:39, Jocelyn Falempe wrote: > Hi, > > When using a Lenovo dock, I often get this error message on dmesg: > > [drm] *ERROR* mstb 57b5b857 port 1: DPCD read on addr 0x4b0 for 1 > bytes NAKed > > It's caused by fwupd which tries to read from /dev/drm_dp_aux4 > > I opened

Re: [Intel-gfx] [PATCH v5 5/7] drm/i915/gt: Create per-tile RC6 sysfs interface

2022-02-17 Thread Andi Shyti
Hi Tvrtko, > > Now tiles have their own sysfs interfaces under the gt/ > > directory. Because RC6 is a property that can be configured on a > > tile basis, then each tile should have its own interface > > > > The new sysfs structure will have a similar layout for the 4 tile > > case: > > > >

Re: [PATCH 00/16] DEPT(Dependency Tracker)

2022-02-17 Thread Theodore Ts'o
On Thu, Feb 17, 2022 at 07:57:36PM +0900, Byungchul Park wrote: > > I've got several reports from the tool. Some of them look like false > alarms and some others look like real deadlock possibility. Because of > my unfamiliarity of the domain, it's hard to confirm if it's a real one. > Let me add

Re: [PATCH v5 7/7] drm/i915/gt: Adding new sysfs frequency attributes

2022-02-17 Thread Andi Shyti
Hi, I forgot to add some note to this patch... [...] > +static ssize_t throttle_reason_status_show(struct device *dev, > +struct device_attribute *attr, > +char *buff) > +{ > + struct intel_gt *gt =

[PATCH] drm/amdgpu: fix amdgpu_ras_block_late_init error handler

2022-02-17 Thread trix
From: Tom Rix Clang build fails with amdgpu_ras.c:2416:7: error: variable 'ras_obj' is used uninitialized whenever 'if' condition is true if (adev->in_suspend || amdgpu_in_reset(adev)) { ^ amdgpu_ras.c:2453:6: note: uninitialized use occurs here if

Re: [Intel-gfx] [PATCH v5 5/7] drm/i915/gt: Create per-tile RC6 sysfs interface

2022-02-17 Thread Tvrtko Ursulin
On 17/02/2022 14:41, Andi Shyti wrote: Now tiles have their own sysfs interfaces under the gt/ directory. Because RC6 is a property that can be configured on a tile basis, then each tile should have its own interface The new sysfs structure will have a similar layout for the 4 tile case:

Re: [PATCH 3/3] drm: omapdrm: Do no allocate non-scanout GEMs through DMM/TILER

2022-02-17 Thread Ivaylo Dimitrov
On 17.02.22 г. 14:46 ч., Tomi Valkeinen wrote: Hi, On 19/01/2022 12:23, Ivaylo Dimitrov wrote: On devices with DMM, all allocations are done through either DMM or TILER. DMM/TILER being a limited resource means that such allocations will start to fail before actual free memory is

Re: [PATCH v4] drm/mediatek: allow commands to be sent during video mode

2022-02-17 Thread Chun-Kuang Hu
[1Hi, Julien: AngeloGioacchino Del Regno 於 2022年2月14日 週一 下午5:43寫道: > > Il 14/02/22 10:27, Julien STEPHAN ha scritto: > > Mipi dsi panel drivers can use mipi_dsi_dcs_{set,get}_display_brightness() > > to request backlight changes. > > > > This can be done during panel initialization (dsi is in

Re: [PATCH v6 13/23] drm/rockchip: dw_hdmi: Set cur_ctr to 0 always

2022-02-17 Thread Sascha Hauer
On Thu, Feb 17, 2022 at 05:00:37PM +0300, Dmitry Osipenko wrote: > 17.02.2022 11:29, Sascha Hauer пишет: > > From: Douglas Anderson > > > > Jitter was improved by lowering the MPLL bandwidth to account for high > > frequency noise in the rk3288 PLL. In each case MPLL bandwidth was > > lowered

Re: [Freedreno] [PATCH v3 12/13] drm/msm/dsi: Add support for DSC configuration

2022-02-17 Thread Marijn Suijten
Hi Vinod, Thanks for taking time to go through this review, please find some clarifications below. On 2022-02-17 16:44:04, Vinod Koul wrote: > Hi Marijn, > > On 11-12-21, 01:03, Marijn Suijten wrote: > > > > +static int dsi_dsc_update_pic_dim(struct msm_display_dsc_config *dsc, > > > +

Re: [PATCH v6 09/23] drm/rockchip: dw_hdmi: Add support for hclk

2022-02-17 Thread Sascha Hauer
On Thu, Feb 17, 2022 at 03:35:08PM +0300, Dmitry Osipenko wrote: > 17.02.2022 11:29, Sascha Hauer пишет: > > The rk3568 HDMI has an additional clock that needs to be enabled for the > > HDMI controller to work. The purpose of that clock is not clear. It is > > named "hclk" in the downstream

Re: [PATCH -next] drm/amdgpu: Remove unused function get_umc_v6_7_channel_index()

2022-02-17 Thread Alex Deucher
Acked-by: Alex Deucher On Wed, Feb 16, 2022 at 6:58 AM YueHaibing wrote: > > This is unused after commit 37ff945f804c ("drm/amdgpu: fix convert bad page > retiremt") > > Signed-off-by: YueHaibing > --- > drivers/gpu/drm/amd/amdgpu/umc_v6_7.c | 7 --- > 1 file changed, 7 deletions(-) > >

Re: [PATCH 4/8] drm/client: Use actual bpp when allocating frame buffers

2022-02-17 Thread Thomas Zimmermann
Am 15.02.22 um 17:52 schrieb Geert Uytterhoeven: When allocating a frame buffer, the number of bits per pixel needed is derived from the deprecated drm_format_info.cpp[] field. While this works for formats using less than 8 bits per pixel, it does lead to a large overallocation. Reduce

Re: [PATCH 2/8] drm/fb-helper: Add support for DRM_FORMAT_C[124]

2022-02-17 Thread Thomas Zimmermann
Hi Geert Am 15.02.22 um 17:52 schrieb Geert Uytterhoeven: Add support for color-indexed frame buffer formats with two, four, and sixteen colors to the DRM framebuffer helper functions: 1. Add support for depths 1/2/4 to the damage helper, 2. For color-indexed modes, the length of the

Re: [Intel-gfx] [PATCH 6/9] drm/i915: Separate wakeref tracking

2022-02-17 Thread Ville Syrjälä
On Thu, Feb 17, 2022 at 03:04:38PM +0100, Andrzej Hajda wrote: > -static noinline depot_stack_handle_t > +static intel_wakeref_t > track_intel_runtime_pm_wakeref(struct intel_runtime_pm *rpm) > { > - depot_stack_handle_t stack, *stacks; > - unsigned long flags; > - > - if

[PATCH v5 7/7] drm/i915/gt: Adding new sysfs frequency attributes

2022-02-17 Thread Andi Shyti
From: Sujaritha Sundaresan This patch adds the following new sysfs frequency attributes; - punit_req_freq_mhz - throttle_reason_status - throttle_reason_pl1 - throttle_reason_pl2 - throttle_reason_pl4 - throttle_reason_thermal -

[PATCH v5 6/7] drm/i915/gt: Create per-tile RPS sysfs interfaces

2022-02-17 Thread Andi Shyti
Now tiles have their own sysfs interfaces under the gt/ directory. Because RPS is a property that can be configured on a tile basis, then each tile should have its own interface The new sysfs structure will have a similar layout for the 4 tile case: /sys/.../card0 ├── gt │  

[PATCH v5 5/7] drm/i915/gt: Create per-tile RC6 sysfs interface

2022-02-17 Thread Andi Shyti
Now tiles have their own sysfs interfaces under the gt/ directory. Because RC6 is a property that can be configured on a tile basis, then each tile should have its own interface The new sysfs structure will have a similar layout for the 4 tile case: /sys/.../card0 ├── gt │  

Re: [PATCH v6, 06/15] media: mtk-vcodec: Refactor get and put capture buffer flow

2022-02-17 Thread Nicolas Dufresne
Le jeudi 17 février 2022 à 17:03 +0800, yunfei.d...@mediatek.com a écrit : > > > - ret = vdec_if_decode(ctx, bs_src, dst_buf, _chg); > > > + ret = vdec_if_decode(ctx, bs_src, NULL, _chg); > > >   if (ret) { > > >   mtk_v4l2_err(" <===[%d], src_buf[%d] sz=0x%zx pts=%llu > >

[PATCH v5 2/7] drm/i915: Prepare for multiple GTs

2022-02-17 Thread Andi Shyti
From: Tvrtko Ursulin On a multi-tile platform, each tile has its own registers + GGTT space, and BAR 0 is extended to cover all of them. Up to four GTs are supported in i915->gt[], with slot zero shadowing the existing i915->gt0 to enable source compatibility with legacy driver paths. A

[PATCH v5 4/7] drm/i915/gt: create per-tile sysfs interface

2022-02-17 Thread Andi Shyti
Now that we have tiles we want each of them to have its own interface. A directory "gt/" is created under "cardN/" that will contain as many diroctories as the tiles. In the coming patches tile related interfaces will be added. For now the sysfs gt structure simply has an id interface related to

[PATCH v5 3/7] drm/i915/gt: add gt_is_root() helper

2022-02-17 Thread Andi Shyti
The "gt_is_root(struct intel_gt *gt)" helper return true if the gt is the root gt, which means that its id is 0. Return false otherwise. Suggested-by: Michal Wajdeczko Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gt/intel_gt.h | 5 + 1 file changed, 5 insertions(+) diff --git

[PATCH v5 1/7] drm/i915: Rename INTEL_REGION_LMEM with INTEL_REGION_LMEM_0

2022-02-17 Thread Andi Shyti
With the upcoming multitile support each tile will have its own local memory. Mark the current LMEM with the suffix '0' to emphasise that it belongs to the root tile. Suggested-by: Michal Wajdeczko Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/display/intel_fb.c | 2 +-

[PATCH v5 0/7] Introduce multitile support

2022-02-17 Thread Andi Shyti
Hi, This is the second series that prepares i915 to host multitile platforms. It introduces the for_each_gt() macro that loops over the tiles to perform per gt actions. This patch is a combination of two patches developed originally by Abdiel, who introduced some refactoring during probe, and

Re: [Freedreno] [REPOST PATCH v4 13/13] drm/msm/dsi: Add support for DSC configuration

2022-02-17 Thread Marijn Suijten
Hi Vinod, On 2022-02-17 16:21:35, Vinod Koul wrote: > Hi Marijn, > > On 17-02-22, 10:27, Marijn Suijten wrote: > > Vinod, > > > > On 2022-02-10 16:04:23, Vinod Koul wrote: > > > When DSC is enabled, we need to configure DSI registers accordingly and > > > configure the respective stream

Re: [PATCH 8/8] drm/fourcc: Add DRM_FORMAT_D1

2022-02-17 Thread Pekka Paalanen
On Thu, 17 Feb 2022 11:42:29 +0100 Geert Uytterhoeven wrote: > Hi Pekka, > > On Thu, Feb 17, 2022 at 11:10 AM Pekka Paalanen wrote: > > On Tue, 15 Feb 2022 17:52:26 +0100 > > Geert Uytterhoeven wrote: > > > Introduce a fourcc code for a single-channel frame buffer format with two > > >

Re: [PATCH v9 1/4] drm/lsdc: add drm driver for loongson display controller

2022-02-17 Thread kernel test robot
Hi Sui, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on robh/for-next v5.17-rc4 next-20220217] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base

Re: [PATCH] drm/i915/ttm: fixup the mock_bo

2022-02-17 Thread Christian König
Am 16.02.22 um 18:37 schrieb Matthew Auld: When running the mock selftests we currently blow up with: <6> [299.836278] i915: Running i915_gem_huge_page_mock_selftests/igt_mock_memory_region_huge_pages <1> [299.836356] BUG: kernel NULL pointer dereference, address: 00c8 <1>

Re: [PATCH v6 21/23] drm: rockchip: Add VOP2 driver

2022-02-17 Thread Heiko Stübner
Am Donnerstag, 17. Februar 2022, 14:58:23 CET schrieb Sascha Hauer: > Hi Andy, > > Please trim the context in your answers to the relevant parts, it makes > it easier to find the things you said. > > On Thu, Feb 17, 2022 at 08:00:11PM +0800, Andy Yan wrote: > > Hi Sascha: > > > > > + > > > +

[PATCH 9/9] drm/i915: replace Intel internal tracker with kernel core ref_tracker

2022-02-17 Thread Andrzej Hajda
Beside reusing existing code, the main advantage of ref_tracker is tracking per instance of wakeref. It allows also to catch double put. On the other side we lose information about the first acquire and the last release, but the advantages outweigh it. Signed-off-by: Andrzej Hajda Reviewed-by:

[PATCH 6/9] drm/i915: Separate wakeref tracking

2022-02-17 Thread Andrzej Hajda
From: Chris Wilson Extract the callstack tracking of intel_runtime_pm.c into its own utility so that that we can reuse it for other online debugging of scoped wakerefs. Signed-off-by: Chris Wilson Reviewed-by: Andrzej Hajda Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/i915/Kconfig.debug

[PATCH 7/9] drm/i915: Track leaked gt->wakerefs

2022-02-17 Thread Andrzej Hajda
From: Chris Wilson Track every intel_gt_pm_get() until its corresponding release in intel_gt_pm_put() by returning a cookie to the caller for acquire that must be passed by on rleased. When there is an imbalance, we can see who either tried to free a stale wakeref, or who forgot to free theirs.

<    1   2   3   4   >