https://bugzilla.kernel.org/show_bug.cgi?id=216092
Bug ID: 216092
Summary: rn_vbios_smu_send_msg_with_param+0xf9/0x100 - amdgpu
Product: Drivers
Version: 2.5
Kernel Version: 5.19.0-rc1
Hardware: All
OS: Linux
Hi Rob,
I love your patch! Perhaps something to improve:
[auto build test WARNING on drm/drm-next]
[also build test WARNING on drm-intel/for-linux-next drm-tip/drm-tip v5.19-rc1
next-20220607]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we
On Fri, Jun 03, 2022 at 03:14:56AM +0800, ChiaEn Wu wrote:
> Daniel Thompson 於 2022年6月1日 週三 下午5:46寫道：
> >
> > On Tue, May 31, 2022 at 07:19:00PM +0800, ChiaEn Wu wrote:
> > > +#define MT6370_DT_PROP_DECL(_name, _type, _reg, _mask, _max, _inv) \
> > > +{
On Thu, Jun 02, 2022 at 08:47:56AM +0200, Daniel Vetter wrote:
> On Thu, 2 Jun 2022 at 08:34, Simon Ser wrote:
> >
> > On Thursday, June 2nd, 2022 at 08:25, Greg KH wrote:
> >
> > > On Thu, Jun 02, 2022 at 06:17:31AM +, Simon Ser wrote:
> > >
> > > > On Thursday, June 2nd, 2022 at 07:40,
On Tue, Jun 7, 2022 at 3:06 AM Stephen Boyd wrote:
>
> Quoting Hsin-Yi Wang (2022-06-06 08:24:24)
> > diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c
> > index f634371c717a..e12056cfeca8 100644
> > --- a/drivers/gpu/drm/drm_panel.c
> > +++ b/drivers/gpu/drm/drm_panel.c
> >
On 06/06/2022 16:21, Matt Roper wrote:
On Mon, Jun 06, 2022 at 12:55:20PM +0100, Tvrtko Ursulin wrote:
On 27/05/2022 19:42, Matt Roper wrote:
On Thu, May 26, 2022 at 11:18:17AM +0100, Tvrtko Ursulin wrote:
On 25/05/2022 19:05, Matt Roper wrote:
On Wed, May 25, 2022 at 05:03:13PM +0100,
On Tue, 31 May 2022, Thomas Zimmermann wrote:
> Enable output polling for all connectors. VGA always uses EDID for this. As
> there's currently no interrupt handling for the ast devices, we have to use
> that trick for the various DP and DVI ports as well.
In general, please don't add new helper
On 17/05/2022 19:32, Niranjana Vishwanathapura wrote:
VM_BIND and related uapi definitions
v2: Ensure proper kernel-doc formatting with cross references.
Also add new uapi and documentation as per review comments
from Daniel.
Signed-off-by: Niranjana Vishwanathapura
---
On 03/06/2022 07:53, Niranjana Vishwanathapura wrote:
On Wed, Jun 01, 2022 at 10:08:35PM -0700, Niranjana Vishwanathapura wrote:
On Wed, Jun 01, 2022 at 11:27:17AM +0200, Daniel Vetter wrote:
On Wed, 1 Jun 2022 at 11:03, Dave Airlie wrote:
On Tue, 24 May 2022 at 05:20, Niranjana
Hi All,
Gentle ping. Are we happy with this patch?
I need to post next version based on some additions in the latest
HW manual. Before that, if there is any feedback I can incorporate
the same.
Please let me know.
Cheers,
Biju
> Subject: [PATCH v3 4/4] drm: rcar-du: Add RZ/G2L DU Support
>
>
Quoting Biju Das (2022-06-07 11:58:08)
> Hi All,
>
> Gentle ping. Are we happy with this patch?
>
The patch itself looks fine to me.
Reviewed-by: Kieran Bingham
> Since RZ/G2L is using separate drm driver,
> I can drop this patch, if needed.
>
But indeed, it's not clear if the requirement
On 06/06/2022 20:54, Rob Clark wrote:
From: Rob Clark
Similar to AMD commit
874442541133 ("drm/amdgpu: Add show_fdinfo() interface"), using the
infrastructure added in previous patches, we add basic client info
and GPU engine utilisation for msm.
Example output:
# cat /proc/`pgrep
Systems with AST graphics can have multiple output; typically VGA
plus some other port. Record detected output chips in a bitmask and
initialize each output on its own.
Assume a VGA output by default and use SIL164 and DP501 if available.
For ASTDP assume that it can run in parallel with VGA.
Enable output polling for all connectors. VGA always uses EDID for this. As
there's currently no interrupt handling for the ast devices, we have to use
that trick for the various DP and DVI ports as well.
v3:
* clearly state in the docs that the EDID needs to be updated
on each
Various cleanups to ast's connector code. Simplifies the code, adds
support for using VGA and ASTDP connectors at the same time, and
initializes polling of the connector status.
Patch 1 was first posted at [1], so this patchset starts at version
2. The implementation of detect_ctx in patch 3 has
Read the display modes from the connectors DDC helper, which also
updates the connector's EDID property. The code for the connector's
.get_modes helper is now shared between VGA and SIL164.
Signed-off-by: Thomas Zimmermann
Reviewed-by: Patrik Jakobsson
---
drivers/gpu/drm/ast/ast_mode.c | 57
Expect the hardware to provide a DDC channel. Fail probing if its
initialization fails.
Signed-off-by: Thomas Zimmermann
Reviewed-by: Patrik Jakobsson
---
drivers/gpu/drm/ast/ast_drv.h | 2 --
drivers/gpu/drm/ast/ast_i2c.c | 7 ---
drivers/gpu/drm/ast/ast_mode.c | 38
Both, struct ast_vga_connector and struct ast_sil164_connector, are
now wrappers around struct drm_connector. Remove them.
Signed-off-by: Thomas Zimmermann
Reviewed-by: Patrik Jakobsson
---
drivers/gpu/drm/ast/ast_drv.h | 24 ++--
drivers/gpu/drm/ast/ast_mode.c | 18
On Thu, Jun 02, 2022 at 08:47:56AM +0200, Daniel Vetter wrote:
>
> Two expand on this:
>
> - compositor opens the drm render /dev node
> - compositor initializes the opengl or vulkan userspace driver on top of that
> - compositor asks that userspace driver to allocate some buffer, which
> can be
Hi, this is your Linux kernel regression tracker.
On 01.06.22 14:29, Jocelyn Falempe wrote:
> On 01/06/2022 12:33, Thomas Zimmermann wrote:
>> Am 01.06.22 um 11:33 schrieb Jocelyn Falempe:
>>>
>>> I've found a regression in the ast driver, for AST2600 hardware.
>>>
>>> before the upstream commit
On 27/05/2022 13:07, Andrzej Hajda wrote:
On 27.05.2022 09:24, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
We have long standing customer complaints that pressing Ctrl-C (or to the
effect of) causes engine resets with otherwise well behaving programs.
Not only is logging engine resets
On Mon, 16 May 2022, Thomas Zimmermann wrote:
> Provide drm_connector_helper_get_modes_from_ddc() to implement the
> connector's get_modes callback. The new helper updates the connector
> from DDC-provided EDID data.
When adding drm core code, please do *not* prefix with "drm/mgag200".
I, and I
Hi All,
Gentle ping. Are we happy with this patch?
Since RZ/G2L is using separate drm driver,
I can drop this patch, if needed.
Please let me know.
Cheers,
Biju
> Subject: [PATCH v3 3/4] drm: rcar-du: Add num_rpf to struct
> rcar_du_device_info
>
> Number of RPF's VSP is different on R-Car
On Tue, Jun 7, 2022 at 10:13 AM Thomas Zimmermann wrote:
>
> Hi
>
> Am 02.06.22 um 09:24 schrieb Patrik Jakobsson:
> > On Tue, May 31, 2022 at 1:15 PM Thomas Zimmermann
> > wrote:
> >>
> >> Read the display modes from the connectors DDC helper, which also
> >> updates the connector's EDID
V1:
1. The MCU FW controling ASPEED DP is loaded by BMC boot loader.
2. Driver starts after CR[3:1] == 111b that indicates Tx is ASTDP,
and CRD1[5] has been asserted by BMVC boot loader.
3. EDID is prioritized by DP monitor.
4. DP's EDID has high priority to decide resolution supporting.
V2:
of_graph_get_remote_node() returns remote device node pointer with
refcount incremented, we should use of_node_put() on it
when not need anymore.
Add missing of_node_put() to avoid refcount leak.
Fixes: 86418f90a4c1 ("drm: convert drivers to use of_graph_get_remote_node")
Signed-off-by: Miaoqian
Hi
Am 06.06.22 um 21:54 schrieb Rob Clark:
From: Rob Clark
The DEFINE_DRM_GEM_FOPS() helper is a bit limiting if a driver wants to
provide additional file ops, like show_fdinfo().
Signed-off-by: Rob Clark
---
include/drm/drm_gem.h | 26 ++
1 file changed, 18
amdgpu_get_xgmi_hive() increases the kobject reference counter of the
hive it returned. The hive returned by amdgpu_get_xgmi_hive() should be
released with the help of amdgpu_put_xgmi_hive() to balance its kobject
reference counter properly. Forgetting the amdgpu_put_xgmi_hive()
operation will
Hi
Am 02.06.22 um 09:24 schrieb Patrik Jakobsson:
On Tue, May 31, 2022 at 1:15 PM Thomas Zimmermann wrote:
Read the display modes from the connectors DDC helper, which also
updates the connector's EDID property. The code for the connector's
.get_modes helper is now shared between VGA and
To return the orientation property to drm/kms driver.
Signed-off-by: Hsin-Yi Wang
Reviewed-by: Hans de Goede
Reviewed-by: Douglas Anderson
---
drivers/gpu/drm/panel/panel-elida-kd35t133.c | 12
1 file changed, 12 insertions(+)
diff --git
Panel orientation property should be set before drm_dev_register().
Mediatek drm driver calls drm_dev_register() in .bind(). However, most
panels sets orientation property relatively late, mostly in .get_modes()
callback, since this is when they are able to get the connector and
binds the
To return the orientation property to drm/kms driver.
Signed-off-by: Hsin-Yi Wang
Reviewed-by: Hans de Goede
Reviewed-by: Douglas Anderson
---
drivers/gpu/drm/panel/panel-lvds.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-lvds.c
To return the orientation property to drm/kms driver.
Signed-off-by: Hsin-Yi Wang
Reviewed-by: Hans de Goede
Reviewed-by: Douglas Anderson
Reviewed-by: Sam Ravnborg
---
v4->v5:
sort callbacks.
---
drivers/gpu/drm/panel/panel-simple.c | 14 +-
1 file changed, 13 insertions(+), 1
To return the orientation property to drm/kms driver.
Signed-off-by: Hsin-Yi Wang
Reviewed-by: Hans de Goede
Reviewed-by: Douglas Anderson
---
drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 12
1 file changed, 12 insertions(+)
diff --git
Panels usually call drm_connector_set_panel_orientation(), which is
later than drm/kms driver calling drm_dev_register(). This leads to a
WARN()[1].
The orientation property is known earlier. For example, some panels
parse the property through device tree during probe.
The series add a panel API
Panels usually call drm_connector_set_panel_orientation(), which is
later than drm/kms driver calling drm_dev_register(). This leads to a
WARN().
The orientation property is known earlier. For example, some panels
parse the property through device tree during probe.
Add an API to return the
To return the orientation property to drm/kms driver.
Signed-off-by: Hsin-Yi Wang
Reviewed-by: Hans de Goede
Reviewed-by: Douglas Anderson
---
v4->v5:
Move the usage text from caller to function doc. Leave todo instead.
Same for other panel patches.
---
To return the orientation property to drm/kms driver.
Signed-off-by: Hsin-Yi Wang
Reviewed-by: Hans de Goede
Reviewed-by: Douglas Anderson
---
drivers/gpu/drm/panel/panel-edp.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-edp.c
Hi Dave.
On Wed, May 25, 2022 at 4:49 PM Dave Airlie wrote:
> drm/amdgpu: add nbio v7_7_0 ip headers
These header files are heavy users of large constants lacking the "U"
suffix e.g.:
#define NB_ADAPTER_ID__SUBSYSTEM_ID_MASK 0xL
Assigning this to unsigned long on 32-bit will
Hi,
ading Kunit tests for the conversion helpers is pretty cool. Thanks for
doing that.
Am 06.06.22 um 11:55 schrieb José Expósito:
Test the conversion from XRGB to RGB332.
What is tested?
- Different values for the X in XRGB to make sure it is ignored
- Different clip values:
On Fri, 03 Jun 2022 14:14:59 +
Simon Ser wrote:
> Hi,
>
> Please, read this thread:
> https://lists.freedesktop.org/archives/dri-devel/2020-March/thread.html#259615
>
> It has a lot of information about the pitfalls of cursor hotspot and
> other things done by VM software.
>
> In
Hi
Am 07.06.22 um 12:03 schrieb Jani Nikula:
On Tue, 31 May 2022, Thomas Zimmermann wrote:
Enable output polling for all connectors. VGA always uses EDID for this. As
there's currently no interrupt handling for the ast devices, we have to use
that trick for the various DP and DVI ports as
On Thu, 02 Jun 2022, Ville Syrjälä wrote:
> On Tue, May 24, 2022 at 01:39:28PM +0300, Jani Nikula wrote:
>> Add default action when .get_modes() not set. This also defines what a
>> .get_modes() hook should do.
>>
>> Cc: David Airlie
>> Cc: Daniel Vetter
>> Signed-off-by: Jani Nikula
>> ---
Hi
Am 07.06.22 um 13:02 schrieb Thorsten Leemhuis:
Hi, this is your Linux kernel regression tracker.
On 01.06.22 14:29, Jocelyn Falempe wrote:
On 01/06/2022 12:33, Thomas Zimmermann wrote:
Am 01.06.22 um 11:33 schrieb Jocelyn Falempe:
I've found a regression in the ast driver, for AST2600
A blast from the past..
On 27/07/2021 01:23, Matthew Brost wrote:
Implement a simple static mapping algorithm of the i915 priority levels
(int, -1k to 1k exposed to user) to the 4 GuC levels. Mapping is as
follows:
i915 level < 0 -> GuC low level (3)
i915 level == 0 ->
On Mon, Jun 06, 2022 at 09:30:42PM +0800, Rex-BC Chen wrote:
> On Mon, 2022-06-06 at 20:53 +0800, Rob Herring wrote:
> > On Mon, 06 Jun 2022 13:11:29 +0800, Bo-Chen Chen wrote:
> > > From: "Nancy.Lin"
> > >
> > > Add vdosys1 RDMA definition.
> > >
> > > Signed-off-by: Nancy.Lin
> > >
On Tue, Jun 07, 2022 at 07:39:55AM +0200, Christoph Hellwig wrote:
> > +static int vfio_iommu_notifier(struct notifier_block *nb, unsigned long
> > action,
> > + void *data)
> > +{
> > + struct vfio_device *vfio_device =
> > + container_of(nb, struct
Hi,
On Wed, 1 Jun 2022 07:39:25 +0400, Miaoqian Lin wrote:
> The following patchset fix two refcount leak bugs.
> The cause of the bugs are missing of_node_put()
> after of_graph_get_remote_node().
>
> changes in v2:
> - patch#2:Fixed patch in meson_encoder_hdmi_init, call of_node_put()
>
On Thu, 2 Jun 2022 at 17:43, Jagan Teki wrote:
>
> Hi Daniel,
>
> On Wed, Mar 30, 2022 at 3:27 PM Daniel Vetter wrote:
> >
> > On Wed, Mar 30, 2022 at 10:52:54AM +0200, Maxime Ripard wrote:
> > > On Tue, Mar 29, 2022 at 11:38:32PM +0530, Jagan Teki wrote:
> > > > Hi all,
> > > >
> > > > I have
On Fri, 03 Jun 2022, Ville Syrjälä wrote:
> On Tue, May 24, 2022 at 01:39:33PM +0300, Jani Nikula wrote:
>> HDMI 2.1 section 10.3.6 defines an HDMI Forum EDID Extension Override
>> Data Block, which may contain a different extension count than the base
>> block claims. Add support for reading
Hi,
> I don’t think I see how that fixes anything. In particular I don’t see
> a way of fixing the old user space at all. We require hotspot info,
> old user space doesn’t set it because there’s no way of setting it on
> atomic kms. Whether we expose cursor plane or not doesn’t change the
>
On 02/06/2022 01:38, Bjorn Andersson wrote:
During device remove care needs to be taken that no work is pending
before it removes the underlying DRM bridge etc, but this can be done on
the specific work rather than waiting for the flush of the system-wide
workqueue.
Fixes: bc6fa8676ebb
On Tue, 7 Jun 2022 at 14:32, Neil Armstrong wrote:
>
> On 02/06/2022 01:38, Bjorn Andersson wrote:
> > During device remove care needs to be taken that no work is pending
> > before it removes the underlying DRM bridge etc, but this can be done on
> > the specific work rather than waiting for the
> Why are pointer cursors misplaced on paravirtualized drivers?
>
> It is because the paravirtualized drivers or VM viewers do *not* place
> the cursor plane at the CRTC_X, CRTC_Y position in the guest CRTC area.
> This is obvious: if CRTC_X, CRTC_Y were honoured, there would be no
>
On Wed, May 11, 2022 at 01:31:44PM +0200, Javier Martinez Canillas wrote:
> The platform devices registered by sysfb match with firmware-based DRM or
> fbdev drivers, that are used to have early graphics using a framebuffer
> provided by the system firmware.
>
> DRM or fbdev drivers later are
Jocelyn, do you have a way of getting this patch tested?
Am 07.06.22 um 14:02 schrieb Thomas Zimmermann:
Include AST2600 in most of the branches for AST2500. Thereby revert
most effects of commit f9bd00e0ea9d ("drm/ast: Create chip AST2600").
The AST2600 used to be treated like an AST2500,
On 05.06.22 17:25, Daniel Vetter wrote:
> It only does a might_sleep_if(GFP_RECLAIM) check, which is already
> covered by the might_alloc() in slab_pre_alloc_hook(). And all callers
> of cache_alloc_debugcheck_before() call that beforehand already.
>
> Signed-off-by: Daniel Vetter
> Cc:
Hi,
thanks for the update, but the change is already in the DRM tree. You
need to write a patch on top of the latest DRM tree. See [1].
Best regards
Thomas
[1] https://cgit.freedesktop.org/drm/drm-tip/
Am 07.06.22 um 10:49 schrieb KuoHsiang Chou:
V1:
1. The MCU FW controling ASPEED DP is
On Tue, Jun 07, 2022 at 07:44:37AM +0200, Christoph Hellwig wrote:
> On Mon, Jun 06, 2022 at 09:34:36PM -0300, Jason Gunthorpe wrote:
> > + if (!list_empty(>device_list)) {
> > + mutex_lock(>device_list_lock);
> > +
On 27/05/2022 05:25, Rob Clark wrote:
On Thu, May 26, 2022 at 4:38 AM Tvrtko Ursulin
wrote:
On 26/05/2022 04:37, Rob Clark wrote:
On Wed, May 25, 2022 at 9:22 AM Tvrtko Ursulin
wrote:
On 25/05/2022 14:41, Rob Clark wrote:
On Wed, May 25, 2022 at 2:46 AM Tvrtko Ursulin
wrote:
On
On 05.06.22 17:25, Daniel Vetter wrote:
> ... instead of open codding it. Completely equivalent code, just
> a notch more meaningful when reading.
>
> Signed-off-by: Daniel Vetter
> Cc: Andrew Morton
> Cc: linux...@kvack.org
> ---
> mm/page_alloc.c | 5 +
> 1 file changed, 1 insertion(+),
Include AST2600 in most of the branches for AST2500. Thereby revert
most effects of commit f9bd00e0ea9d ("drm/ast: Create chip AST2600").
The AST2600 used to be treated like an AST2500, which at least gave
usable display output. After introducing AST2600 in the driver without
further updates,
Lyude Paul writes:
> Reviewed-by: Lyude Paul
>
> Will push to drm-misc-next
I don't see this patch in mainline or drm-misc-next, did it get lost?
cheers
> On Sat, 2022-03-19 at 11:27 +0100, Christophe Leroy wrote:
>> While working at fixing powerpc headers, I ended up with the
>> following
On Mon, Jun 6, 2022 at 11:56 PM Thomas Zimmermann wrote:
>
> Hi
>
> Am 06.06.22 um 21:54 schrieb Rob Clark:
> > From: Rob Clark
> >
> > The DEFINE_DRM_GEM_FOPS() helper is a bit limiting if a driver wants to
> > provide additional file ops, like show_fdinfo().
> >
> > Signed-off-by: Rob Clark
>
Hello Daniel,
On 6/7/22 17:01, Daniel Vetter wrote:
[snip]
>>
>> drivers/video/fbdev/core/fbmem.c | 11 +++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/drivers/video/fbdev/core/fbmem.c
>> b/drivers/video/fbdev/core/fbmem.c
>> index 9b035ef4d552..265efa189bcc 100644
>> ---
On Jun 07 2022, Geert Uytterhoeven wrote:
> On Wed, May 25, 2022 at 4:49 PM Dave Airlie wrote:
>> drm/amdgpu: add nbio v7_7_0 ip headers
>
> These header files are heavy users of large constants lacking the "U"
> suffix e.g.:
>
> #define NB_ADAPTER_ID__SUBSYSTEM_ID_MASK 0xL
>
>
On Fri, Jun 3, 2022 at 6:52 PM Niranjana Vishwanathapura <
niranjana.vishwanathap...@intel.com> wrote:
> On Fri, Jun 03, 2022 at 10:20:25AM +0300, Lionel Landwerlin wrote:
> > On 02/06/2022 23:35, Jason Ekstrand wrote:
> >
> > On Thu, Jun 2, 2022 at 3:11 PM Niranjana Vishwanathapura
> >
On 06/06/2022 05:18, Bo-Chen Chen wrote:
> From: "Nancy.Lin"
>
> Add vdosys1 RDMA definition.
>
> Signed-off-by: Nancy.Lin
> Reviewed-by: AngeloGioacchino Del Regno
>
> Reviewed-by: Krzysztof Kozlowski
> Tested-by: AngeloGioacchino Del Regno
>
> Signed-off-by: Bo-Chen Chen
> ---
>
Hi Thomas,
Thanks a lot for your review.
On Tue, Jun 07, 2022 at 09:22:38AM +0200, Thomas Zimmermann wrote:
> Hi,
>
> ading Kunit tests for the conversion helpers is pretty cool. Thanks for
> doing that.
>
> Am 06.06.22 um 11:55 schrieb José Expósito:
> > Test the conversion from XRGB to
From: David Galiffi
[ Upstream commit 49947b906a6bd9668eaf4f9cf691973c25c26955 ]
[How & Why]
If a value of 0 is read, then this will cause a divide-by-0 panic.
Reviewed-by: Martin Leung
Acked-by: Qingqing Zhuo
Signed-off-by: David Galiffi
Tested-by: Daniel Wheeler
Signed-off-by: Alex
From: Gong Yuanjun
[ Upstream commit a2b28708b645c5632dc93669ab06e97874c8244f ]
In radeon_fp_native_mode(), the return value of drm_mode_duplicate()
is assigned to mode, which will lead to a NULL pointer dereference
on failure of drm_mode_duplicate(). Add a check to avoid npd.
The failure
From: Gong Yuanjun
[ Upstream commit d2f4460a3d9502513419f06cc376c7ade49d5753 ]
gpu_metrics_table is allocated in yellow_carp_init_smc_tables() but
not freed in yellow_carp_fini_smc_tables().
Signed-off-by: Gong Yuanjun
Signed-off-by: Alex Deucher
Signed-off-by: Sasha Levin
---
From: Gong Yuanjun
[ Upstream commit a2b28708b645c5632dc93669ab06e97874c8244f ]
In radeon_fp_native_mode(), the return value of drm_mode_duplicate()
is assigned to mode, which will lead to a NULL pointer dereference
on failure of drm_mode_duplicate(). Add a check to avoid npd.
The failure
From: Gong Yuanjun
[ Upstream commit a2b28708b645c5632dc93669ab06e97874c8244f ]
In radeon_fp_native_mode(), the return value of drm_mode_duplicate()
is assigned to mode, which will lead to a NULL pointer dereference
on failure of drm_mode_duplicate(). Add a check to avoid npd.
The failure
On Tue, Jun 7, 2022 at 3:23 AM Geert Uytterhoeven wrote:
>
> These header files are heavy users of large constants lacking the "U"
> suffix e.g.:
>
> #define NB_ADAPTER_ID__SUBSYSTEM_ID_MASK 0xL
As Andreas says, this is not undefined behavior.
A hexadecimal integer constant will
From: Daniel Vetter
Well except when the olpc dcon fbdev driver is enabled, that thing
digs around in there in rather unfixable ways.
Cc oldc_dcon maintainers as fyi.
v2: I typoed the config name (0day)
Cc: kernel test robot
Cc: Jens Frederich
Cc: Jon Nettleton
Cc: Greg Kroah-Hartman
Cc:
From: Daniel Vetter
This reverts commit fb561bf9abde49f7e00fdbf9ed2ccf2d86cac8ee.
With
commit 27599aacbaefcbf2af7b06b0029459bbf682000d
Author: Thomas Zimmermann
Date: Tue Jan 25 10:12:18 2022 +0100
fbdev: Hot-unplug firmware fb devices on forced removal
this should be fixed properly
Hello,
The patches in this series contain mostly changes suggested by Daniel Vetter
Thomas Zimmermann. They aim to fix existing races between the Generic System
Framebuffer (sysfb) infrastructure and the fbdev and DRM device registration.
For example, it is currently possible for sysfb to
This can be used by subsystems to unregister a platform device registered
by sysfb and also to disable future platform device registration in sysfb.
Suggested-by: Daniel Vetter
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Daniel Vetter
---
Changes in v6:
- Drop sysfb_try_unregister()
This function just returned 0 on success or an errno code on error, but it
could be useful for sysfb_init() callers to have a pointer to the device.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Daniel Vetter
Reviewed-by: Thomas Zimmermann
---
(no changes since v3)
Changes in v3:
-
The platform devices registered by sysfb match with firmware-based DRM or
fbdev drivers, that are used to have early graphics using a framebuffer
provided by the system firmware.
DRM or fbdev drivers later are probed and remove all conflicting framebuffers,
leading to these platform devices for
Applied. Thanks!
Alex
On Tue, Jun 7, 2022 at 12:05 PM Xiaohui Zhang wrote:
>
> Similar to the handling of amdgpu_mode_dumb_create in commit 54ef0b5461c0
> ("drm/amdgpu: integer overflow in amdgpu_mode_dumb_create()"),
> we thought a patch might be needed here as well.
>
> args->size is a u64.
On Tue, 7 Jun 2022 at 14:08, Miaoqian Lin wrote:
>
> of_graph_get_remote_node() returns remote device node pointer with
> refcount incremented, we should use of_node_put() on it
> when not need anymore.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: 86418f90a4c1 ("drm: convert
On 6/6/22 13:57, Christian König wrote:
> Am 05.06.22 um 18:47 schrieb Daniel Vetter:
>> On Fri, 27 May 2022 at 01:55, Dmitry Osipenko
>> wrote:
>>> Introduce a common DRM SHMEM shrinker framework that allows to reduce
>>> code duplication among DRM drivers by replacing theirs custom shrinker
>>>
Hi
Am 07.06.22 um 16:58 schrieb Rob Clark:
On Mon, Jun 6, 2022 at 11:56 PM Thomas Zimmermann wrote:
Hi
Am 06.06.22 um 21:54 schrieb Rob Clark:
From: Rob Clark
The DEFINE_DRM_GEM_FOPS() helper is a bit limiting if a driver wants to
provide additional file ops, like show_fdinfo().
From: Nicholas Kazlauskas
[ Upstream commit 66a197203794339b028eedfa880bff9367fce783 ]
[Why]
A display clock change hang can occur when switching between DIO and HPO
enabled modes during the optimize_bandwidth in dc_commit_state_no_check
call.
This happens when going from 4k120 8bpc 420 to
From: Gong Yuanjun
[ Upstream commit a2b28708b645c5632dc93669ab06e97874c8244f ]
In radeon_fp_native_mode(), the return value of drm_mode_duplicate()
is assigned to mode, which will lead to a NULL pointer dereference
on failure of drm_mode_duplicate(). Add a check to avoid npd.
The failure
From: Gong Yuanjun
[ Upstream commit d2f4460a3d9502513419f06cc376c7ade49d5753 ]
gpu_metrics_table is allocated in yellow_carp_init_smc_tables() but
not freed in yellow_carp_fini_smc_tables().
Signed-off-by: Gong Yuanjun
Signed-off-by: Alex Deucher
Signed-off-by: Sasha Levin
---
From: David Galiffi
[ Upstream commit 49947b906a6bd9668eaf4f9cf691973c25c26955 ]
[How & Why]
If a value of 0 is read, then this will cause a divide-by-0 panic.
Reviewed-by: Martin Leung
Acked-by: Qingqing Zhuo
Signed-off-by: David Galiffi
Tested-by: Daniel Wheeler
Signed-off-by: Alex
From: Lijo Lazar
[ Upstream commit b0f4d663fce6a4232d3c20ce820f919111b1c60b ]
On aldebaran, when thermal throttling happens due to excessive GPU
temperature, the reason for throttling event is missed in warning
message. This patch fixes it.
Signed-off-by: Lijo Lazar
Reviewed-by: Yang Wang
From: Yury Norov
[ Upstream commit 525d6515604eb1373ce5e6372a6b6640953b2d6a ]
The smu_v1X_0_set_allowed_mask() uses bitmap_copy() to convert
bitmap to 32-bit array. This may be wrong due to endiannes issues.
Fix it by switching to bitmap_{from,to}_arr32.
CC: Alexander Gordeev
CC: Andy
From: Yury Norov
[ Upstream commit 525d6515604eb1373ce5e6372a6b6640953b2d6a ]
The smu_v1X_0_set_allowed_mask() uses bitmap_copy() to convert
bitmap to 32-bit array. This may be wrong due to endiannes issues.
Fix it by switching to bitmap_{from,to}_arr32.
CC: Alexander Gordeev
CC: Andy
From: Marek Vasut
[ Upstream commit 2dcec57b3734029cc1adc5cb872f61e21609eed4 ]
The chip register layout has nothing to do with MIPI DCS, the registers
incorrectly marked as MIPI DCS in the driver are regular chip registers
often with completely different function.
Fill in the actual register
From: Marek Vasut
[ Upstream commit c0ff7a649d62105a9308cc3ac36e52a4669d9cb4 ]
The HFP_HSW_HBP_HI register must be programmed with 2 LSbits of each
Horizontal Front Porch/Sync/Back Porch. Currently the driver programs
this register to 0, which breaks displays with either value above 255.
The
Hi,
I can see that the dts changes from this patch series has been applied
to 5.19-rc1 release. However, this patch that has the related change to
the panel driver, is not applied in the 5.19-rc1 release. Any particular
reason why it's not picked up? or just that, it got missed out? Kindly
The HDMI driver has code to configure extra GPIOs, which predates
pinctrl support. Nowadays all platforms should use pinctrl instead.
Neither of upstreamed Qualcomm pltforms uses these properties, so it's
safe to drop them.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/hdmi/hdmi.c
backlight_properties.fb_blank is deprecated. The states it represents
are handled by other properties; but instead of accessing those
properties directly, drivers should use the helpers provided by
backlight.h.
This will ultimately allow fb_blank to be removed.
Stephen Kitt (3):
drm/panel: Use
DB820c makes use of core-vcc-supply and core-vdda-supply, however the
driver code doesn't support these regulators. Enable them for HDMI on
8996 platform.
Fixes: 0afbe59edd3f ("drm/msm/hdmi: Add basic HDMI support for msm8996")
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/hdmi/hdmi.c
From: Marek Vasut
[ Upstream commit 2dcec57b3734029cc1adc5cb872f61e21609eed4 ]
The chip register layout has nothing to do with MIPI DCS, the registers
incorrectly marked as MIPI DCS in the driver are regular chip registers
often with completely different function.
Fill in the actual register
Instead of retrieving the backlight brightness in struct
backlight_properties manually, and then checking whether the backlight
should be on at all, use backlight_get_brightness() which does all
this and insulates this from future changes.
Instead of manually checking the power state in struct
1 - 100 of 222 matches
Mail list logo
