Re: [Freedreno] [RFC PATCH v2 06/13] drm/msm/dpu: switch RM to use crtc_id rather than enc_id for allocation

2023-05-23 Thread Dmitry Baryshkov
On 23/05/2023 01:22, Abhinav Kumar wrote: Sorry for the delay, other topics delayed my response on this one. On 5/18/2023 6:50 PM, Dmitry Baryshkov wrote: On 19/05/2023 02:46, Abhinav Kumar wrote: On 3/20/2023 6:18 PM, Dmitry Baryshkov wrote: Up to now the driver has been using encoder to

Re: [Freedreno] [PATCH v2 0/7] drm/msm/dpu: simplify DPU encoder init

2023-05-23 Thread Neil Armstrong
On 23/05/2023 09:20, Dmitry Baryshkov wrote: On Tue, 23 May 2023 at 04:58, Abhinav Kumar wrote: On 5/18/2023 7:38 PM, Dmitry Baryshkov wrote: Rework dpu_encoder initialization code, simplifying calling sequences and separating common init parts. Changes since v1: - Withdrawn two pathes

Re: [PATCH v4 08/12] drm/msm/dpu: Add SM6375 support

2023-05-23 Thread Konrad Dybcio
On 21.05.2023 18:10, Dmitry Baryshkov wrote: > On 19/05/2023 20:04, Konrad Dybcio wrote: >> Add basic SM6375 support to the DPU1 driver to enable display output. >> >> Signed-off-by: Konrad Dybcio >> --- >>   .../gpu/drm/msm/disp/dpu1/catalog/dpu_6_9_sm6375.h | 153 >> + >>

Re: [PATCH] drm/mgag200: set variable mgag200_modeset storage-class-specifier to static

2023-05-23 Thread Jocelyn Falempe
On 17/05/2023 15:41, Tom Rix wrote: smatch reports drivers/gpu/drm/mgag200/mgag200_drv.c:23:5: warning: symbol 'mgag200_modeset' was not declared. Should it be static? This variable is only used in its defining file, so it should be static Signed-off-by: Tom Rix ---

Re: [PATCH] drm/gma500: Clear fbdev framebuffer with fb_memset_io()

2023-05-23 Thread Patrik Jakobsson
On Mon, May 22, 2023 at 09:06:37PM +0200, Thomas Zimmermann wrote: > The fbdev framebuffer is I/O memory, so clear it with fb_memset_io(). > Fixes the following sparse warning: > > ../drivers/gpu/drm/gma500/fbdev.c:234:20: warning: incorrect type in argument > 1 (different address spaces) >

Re: [Intel-xe] [PATCH] drm/doc/rfc/xe: No STAGING in drm.

2023-05-23 Thread Lucas De Marchi
On Mon, May 22, 2023 at 03:57:12PM -0400, Rodrigo Vivi wrote: We are not using the STAGING inside drm and the uAPI needs to be in the acceptable form before we get merged upstream. Is this a change from i915, where the force_probe protection is sufficient? The email exchange with Greg KH

Re: [PATCH v2 1/3] drm/msm/adreno: Add Adreno A690 support

2023-05-23 Thread Konrad Dybcio
On 23.05.2023 03:15, Bjorn Andersson wrote: > From: Bjorn Andersson > > Introduce support for the Adreno A690, found in Qualcomm SC8280XP. > > Signed-off-by: Bjorn Andersson > Signed-off-by: Bjorn Andersson > --- Reviewed-by: Konrad Dybcio Konrad > > Changes since v1: > - Moved a690 to

[PATCH v5 06/12] drm/msm/dpu: Add SM6350 support

2023-05-23 Thread Konrad Dybcio
Add SM6350 support to the DPU1 driver to enable display output. It's worth noting that one entry dpu_qos_lut_entry was trimmed off: {.fl = 0, .lut = 0x0011223344556677 }, due to the lack of support for selecting between portrait and landscape LUT settings (for danger and safe LUTs) and no full

[PATCH v5 04/12] dt-bindings: display/msm: Add SM6350 MDSS

2023-05-23 Thread Konrad Dybcio
Document the SM6350 MDSS. Signed-off-by: Konrad Dybcio --- .../bindings/display/msm/qcom,sm6350-mdss.yaml | 214 + 1 file changed, 214 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6350-mdss.yaml

[PATCH v5 01/12] dt-bindings: display/msm: dsi-controller-main: Add SM6350

2023-05-23 Thread Konrad Dybcio
Add the DSI host found on SM6350. Acked-by: Rob Herring Signed-off-by: Konrad Dybcio --- Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml

[PATCH v5 03/12] dt-bindings: display/msm: sc7180-dpu: Describe SM6350 and SM6375

2023-05-23 Thread Konrad Dybcio
SC7180, SM6350 and SM6375 use a rather similar hw setup for DPU, with the main exception being that the last one requires an additional throttle clock. It is not well understood yet, but failing to toggle it on makes the display hardware stall and not output any frames. Document SM6350 and

[PATCH v5 07/12] drm/msm: mdss: Add SM6350 support

2023-05-23 Thread Konrad Dybcio
Add support for MDSS on SM6350. Reviewed-by: Dmitry Baryshkov Reviewed-by: Marijn Suijten Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/msm_mdss.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index

[PATCH v5 08/12] drm/msm/dpu: Add SM6375 support

2023-05-23 Thread Konrad Dybcio
Add basic SM6375 support to the DPU1 driver to enable display output. Reviewed-by: Dmitry Baryshkov Signed-off-by: Konrad Dybcio --- .../gpu/drm/msm/disp/dpu1/catalog/dpu_6_9_sm6375.h | 139 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 1 +

[PATCH v5 09/12] drm/msm: mdss: Add SM6375 support

2023-05-23 Thread Konrad Dybcio
Add support for MDSS on SM6375. Reviewed-by: Dmitry Baryshkov Reviewed-by: Marijn Suijten Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/msm_mdss.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index

[PATCH v5 10/12] iommu/arm-smmu-qcom: Sort the compatible list alphabetically

2023-05-23 Thread Konrad Dybcio
It got broken at some point, fix it up. Reviewed-by: Dmitry Baryshkov Signed-off-by: Konrad Dybcio --- drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c

[PATCH v5 00/12] SM63(50|75) DPU support

2023-05-23 Thread Konrad Dybcio
v4 -> v5: - Rebase on next-20230522 (drop regdma, drop external dependencies) - Reuse sdm845_vbif - Resize non-DSI INTFs to 0x280 (no TE block) - Fix up 6375 mdss bindings example - Rewrite reasoning of dropping the QoS LUT entry in "drm/msm/dpu: Add SM6350 support" - pick up tags - add DSC

[PATCH v5 12/12] iommu/arm-smmu-qcom: Add SM6350 DPU compatible

2023-05-23 Thread Konrad Dybcio
From: Konrad Dybcio Add the SM6350 DPU compatible to clients compatible list, as it also needs the workarounds. Signed-off-by: Konrad Dybcio Acked-by: Dmitry Baryshkov Signed-off-by: Konrad Dybcio --- drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH v5 11/12] iommu/arm-smmu-qcom: Add SM6375 DPU compatible

2023-05-23 Thread Konrad Dybcio
Add the SM6375 DPU compatible to clients compatible list, as it also needs the workarounds. Acked-by: Dmitry Baryshkov Signed-off-by: Konrad Dybcio --- drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c

[PATCH v5 02/12] dt-bindings: display/msm: dsi-controller-main: Add SM6375

2023-05-23 Thread Konrad Dybcio
Add the DSI host found on SM6375. Acked-by: Rob Herring Signed-off-by: Konrad Dybcio --- Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml

[PATCH v5 05/12] dt-bindings: display/msm: Add SM6375 MDSS

2023-05-23 Thread Konrad Dybcio
Document the SM6375 MDSS. Signed-off-by: Konrad Dybcio --- .../bindings/display/msm/qcom,sm6375-mdss.yaml | 216 + 1 file changed, 216 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6375-mdss.yaml

Re: [PATCH v4] drm/msm/dp: enable HDP plugin/unplugged interrupts at hpd_enable/disable

2023-05-23 Thread Dmitry Baryshkov
On 23/05/2023 15:35, Bjorn Andersson wrote: On Mon, May 22, 2023 at 04:02:45PM -0700, Kuogee Hsieh wrote: The internal_hpd flag is set to true by dp_bridge_hpd_enable() and set to false by dp_bridge_hpd_disable() to handle GPIO pinmuxed into DP controller case. HDP related interrupts can not be

Re: [Freedreno] [PATCH v2 0/7] drm/msm/dpu: simplify DPU encoder init

2023-05-23 Thread Dmitry Baryshkov
On 23/05/2023 10:31, Neil Armstrong wrote: On 23/05/2023 09:20, Dmitry Baryshkov wrote: On Tue, 23 May 2023 at 04:58, Abhinav Kumar wrote: On 5/18/2023 7:38 PM, Dmitry Baryshkov wrote: Rework dpu_encoder initialization code, simplifying calling sequences and separating common init parts.

Re: [PATCH] drm/amd/display: remove unused variables res_create_maximus_funcs and debug_defaults_diags

2023-05-23 Thread Hamza Mahfooz
On 5/23/23 07:49, Tom Rix wrote: gcc with W=1 reports drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_resource.c:1069:43: error: ‘res_create_maximus_funcs’ defined but not used [-Werror=unused-const-variable=] 1069 | static const struct resource_create_funcs res_create_maximus_funcs =

Re: [PATCH] drm/amd/display: avoid calling missing .resync_fifo_dccg_dio()

2023-05-23 Thread Hamza Mahfooz
On 5/23/23 04:34, Arnd Bergmann wrote: From: Arnd Bergmann The .resync_fifo_dccg_dio() callback pointer was added in an #ifdef block, but is called unconditionally: drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:2292:31: error: 'struct hwseq_private_funcs' has no

Re: [PATCH v5 06/12] drm/msm/dpu: Add SM6350 support

2023-05-23 Thread Dmitry Baryshkov
On 23/05/2023 10:46, Konrad Dybcio wrote: Add SM6350 support to the DPU1 driver to enable display output. It's worth noting that one entry dpu_qos_lut_entry was trimmed off: {.fl = 0, .lut = 0x0011223344556677 }, due to the lack of support for selecting between portrait and landscape LUT

Re: [PATCH v2 2/3] arm64: dts: qcom: sc8280xp: Add GPU related nodes

2023-05-23 Thread Konrad Dybcio
On 23.05.2023 03:15, Bjorn Andersson wrote: > From: Bjorn Andersson > > Add Adreno SMMU, GPU clock controller, GMU and GPU nodes for the > SC8280XP. > > Signed-off-by: Bjorn Andersson > Signed-off-by: Bjorn Andersson > --- It does not look like you tested the DTS against bindings. Please

Re: [PATCH v2 2/3] arm64: dts: qcom: sc8280xp: Add GPU related nodes

2023-05-23 Thread Konrad Dybcio
On 23.05.2023 09:59, Konrad Dybcio wrote: > > > On 23.05.2023 03:15, Bjorn Andersson wrote: >> From: Bjorn Andersson >> >> Add Adreno SMMU, GPU clock controller, GMU and GPU nodes for the >> SC8280XP. >> >> Signed-off-by: Bjorn Andersson >> Signed-off-by: Bjorn Andersson >> --- > It does

Re: [PATCH v5 04/12] dt-bindings: display/msm: Add SM6350 MDSS

2023-05-23 Thread Rob Herring
On Tue, 23 May 2023 09:46:15 +0200, Konrad Dybcio wrote: > Document the SM6350 MDSS. > > Signed-off-by: Konrad Dybcio > --- > .../bindings/display/msm/qcom,sm6350-mdss.yaml | 214 > + > 1 file changed, 214 insertions(+) > My bot found errors running 'make

Re: [PATCH v5 05/12] dt-bindings: display/msm: Add SM6375 MDSS

2023-05-23 Thread Rob Herring
On Tue, 23 May 2023 09:46:16 +0200, Konrad Dybcio wrote: > Document the SM6375 MDSS. > > Signed-off-by: Konrad Dybcio > --- > .../bindings/display/msm/qcom,sm6375-mdss.yaml | 216 > + > 1 file changed, 216 insertions(+) > My bot found errors running 'make

[PATCH] drm/amd/display: avoid calling missing .resync_fifo_dccg_dio()

2023-05-23 Thread Arnd Bergmann
From: Arnd Bergmann The .resync_fifo_dccg_dio() callback pointer was added in an #ifdef block, but is called unconditionally: drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:2292:31: error: 'struct hwseq_private_funcs' has no member named 'resync_fifo_dccg_dio' Add the

Re: [RESEND PATCH] drm/i915: constify pointers to hwmon_channel_info

2023-05-23 Thread Jani Nikula
On Wed, 17 May 2023, Jani Nikula wrote: > On Wed, 17 May 2023, Krzysztof Kozlowski > wrote: >> On 17/05/2023 11:28, Jani Nikula wrote: >>> On Thu, 11 May 2023, Krzysztof Kozlowski >>> wrote: Statically allocated array of pointers to hwmon_channel_info can be made const for safety.

Re: [PATCH] drm/msm/dpu: signedness bug in dpu_encoder_phys_cmd_tearcheck_config()

2023-05-23 Thread Dan Carpenter
On Mon, May 22, 2023 at 10:47:50AM +0200, Marijn Suijten wrote: > On 2023-05-22 10:48:01, Dan Carpenter wrote: > > The "vsync_hz" variable is used to store negative error codes so it > > needs to be signed for the error checking to work correctly. > > Nicely spotted, but it it looks like we have

Re: [PATCH] drm/gma500: Clear fbdev framebuffer with fb_memset_io()

2023-05-23 Thread Thomas Zimmermann
Hi Am 23.05.23 um 09:00 schrieb Patrik Jakobsson: On Mon, May 22, 2023 at 09:06:37PM +0200, Thomas Zimmermann wrote: The fbdev framebuffer is I/O memory, so clear it with fb_memset_io(). Fixes the following sparse warning: ../drivers/gpu/drm/gma500/fbdev.c:234:20: warning: incorrect type in

[PATCH 12/15] drm/msm/hdmi: set infoframes on all pre_enable calls

2023-05-23 Thread Dmitry Baryshkov
In consequent modeset calls, the atomic_pre_enable() will be called several times without calling atomic_post_disable() inbetween. Thus iframes will not be updated for the next mode. Fix this by setting the iframe outside of the !power_on check. Signed-off-by: Dmitry Baryshkov ---

[PATCH 06/15] phy: qcom-uniphy: add more registers from display PHYs

2023-05-23 Thread Dmitry Baryshkov
Import register definitions from 28nm DSI and HDMI PHYs, adding more UNI PHY registers. Signed-off-by: Dmitry Baryshkov --- drivers/phy/qualcomm/phy-qcom-uniphy.h | 33 ++ 1 file changed, 33 insertions(+) diff --git a/drivers/phy/qualcomm/phy-qcom-uniphy.h

[PATCH 14/15] drm/msm/hdmi: switch to generic PHY subsystem

2023-05-23 Thread Dmitry Baryshkov
Change the MSM HDMI driver to use generic PHY subsystem. Moving PHY drivers allows better code sharing with the rest of the PHY system. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/Makefile | 6 --- drivers/gpu/drm/msm/hdmi/hdmi.c| 58 +++--

[PATCH 10/15] drm/msm/hdmi: correct indentation of HDMI bridge functions

2023-05-23 Thread Dmitry Baryshkov
Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c b/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c index 62ce1455f974..fbcf4dd91cd9 100644 ---

[PATCH 15/15] drm/msm/hdmi: drop old HDMI PHY code

2023-05-23 Thread Dmitry Baryshkov
Drop source files used by old HDMI PHY and HDMI PLL drivers. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi_phy.c | 217 --- drivers/gpu/drm/msm/hdmi/hdmi_phy_8960.c | 51 -- drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c | 765 ---

[PATCH 13/15] drm/msm/hdmi: pair msm_hdmi_phy_powerup with msm_hdmi_phy_powerdown

2023-05-23 Thread Dmitry Baryshkov
In preparation to converting MSM HDMI driver to use PHY framework, which requires phy_power_on() calls to be paired with phy_power_off(), add a conditional call to msm_hdmi_phy_powerdown() before the call to msm_hdmi_phy_powerup(). Signed-off-by: Dmitry Baryshkov ---

[PATCH 03/15] phy: qualcomm: add MSM8960 HDMI PHY driver

2023-05-23 Thread Dmitry Baryshkov
Port the HDMI PHY driver for Qualcomm MSM8960 / APQ8064 platforms. Signed-off-by: Dmitry Baryshkov --- drivers/phy/qualcomm/Kconfig | 11 + drivers/phy/qualcomm/Makefile| 1 + drivers/phy/qualcomm/phy-qcom-hdmi-msm8960.c | 744 +++ 3 files

[PATCH 00/15] drm/msm/hdmi & phy: use generic PHY framework

2023-05-23 Thread Dmitry Baryshkov
The MSM HDMI PHYs have been using the ad-hoc approach / API instead of using the generic API framework. Move all the PHYs to drivers/phy/qualcomm and rework them to use generic PHY framework. This way all the QMP-related code is kept close. Also in future this will allow us to use a common set of

[PATCH 05/15] phy: qcom: apq8064-sata: extract UNI PLL register defines

2023-05-23 Thread Dmitry Baryshkov
The "uni" PLL is shared between several PHYS: APQ8064's SATA, MSM8974/APQ8084 HDMI, MSM8916 DSI, MSM8974/APQ8084 DSI. Signed-off-by: Dmitry Baryshkov --- drivers/phy/qualcomm/phy-qcom-apq8064-sata.c | 23 +- drivers/phy/qualcomm/phy-qcom-uniphy.h | 32 2

[PATCH 04/15] phy: qualcomm: add MSM8x60 HDMI PHY driver

2023-05-23 Thread Dmitry Baryshkov
Port the HDMI PHY driver for Qualcomm MSM8260 / MSM8660 / APQ8060 platforms. Signed-off-by: Dmitry Baryshkov --- drivers/phy/qualcomm/Kconfig | 11 + drivers/phy/qualcomm/Makefile| 1 + drivers/phy/qualcomm/phy-qcom-hdmi-msm8x60.c | 353 +++ 3

[PATCH 02/15] phy: qualcomm: add QMP HDMI PHY driver

2023-05-23 Thread Dmitry Baryshkov
Port Qualcomm QMP HDMI PHY to the generic PHY framework. Split the generic part and the msm8996 part. When adding support for msm8992/4 and msm8998 (which also employ QMP for HDMI PHY), one will have to provide the PLL programming part only. Signed-off-by: Dmitry Baryshkov ---

[PATCH 08/15] drm/msm/hdmi: move the alt_iface clock to the hpd list

2023-05-23 Thread Dmitry Baryshkov
According to the vendor kernel [1] , the alt_iface clock should be enabled together with the rest of HPD clocks, to make HPD to work properly. [1] https://git.codelinaro.org/clo/la/kernel/msm-3.18/-/commit/e07a5487e521e57f76083c0a6e2f995414ac6d03 Signed-off-by: Dmitry Baryshkov ---

[PATCH 11/15] drm/msm/hdmi: switch to atomic_pre_enable/post_disable

2023-05-23 Thread Dmitry Baryshkov
In preparation of reworking the HDMI mode setting, switch pre_enable and post_disable callbacks to their atomic variants. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git

[PATCH 09/15] drm/msm/hdmi: simplify extp clock handling

2023-05-23 Thread Dmitry Baryshkov
With the extp being the only "power" clock left, remove the surrounding loops and handle the extp clock directly. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi.c| 24 --- drivers/gpu/drm/msm/hdmi/hdmi.h| 6 +

[PATCH v2] drm/vkms: Fix race-condition between the hrtimer and the atomic commit

2023-05-23 Thread Maíra Canal
Currently, it is possible for the composer to be set as enabled and then as disabled without a proper call for the vkms_vblank_simulate(). This is problematic, because the driver would skip one CRC output, causing CRC tests to fail. Therefore, we need to make sure that, for each time the composer

Re: [PATCH 00/15] drm/msm/hdmi & phy: use generic PHY framework

2023-05-23 Thread Dmitry Baryshkov
On 23/05/2023 15:14, Dmitry Baryshkov wrote: The MSM HDMI PHYs have been using the ad-hoc approach / API instead of using the generic API framework. Move all the PHYs to drivers/phy/qualcomm and rework them to use generic PHY framework. This way all the QMP-related code is kept close. Also in

Re: [PATCH v2 3/3] arm64: dts: qcom: sc8280xp: Enable GPU related nodes

2023-05-23 Thread Konrad Dybcio
On 23.05.2023 14:28, Bjorn Andersson wrote: > On Tue, May 23, 2023 at 10:04:40AM +0200, Konrad Dybcio wrote: >> >> >> On 23.05.2023 03:15, Bjorn Andersson wrote: >>> From: Bjorn Andersson >>> >>> Add memory reservation for the zap-shader and enable the Adreno SMMU, >>> GPU clock controller,

Re: [PATCH] drm/msm/a6xx: don't set IO_PGTABLE_QUIRK_ARM_OUTER_WBWA with coherent SMMU

2023-05-23 Thread Bjorn Andersson
On Mon, Apr 10, 2023 at 09:52:26PM +0300, Dmitry Baryshkov wrote: > If the Adreno SMMU is dma-coherent, allocation will fail unless we > disable IO_PGTABLE_QUIRK_ARM_OUTER_WBWA. Skip setting this quirk for the > coherent SMMUs (like we have on sm8350 platform). > > Fixes: 54af0ceb7595 ("arm64:

Re: [PATCH 0/2] drm/panel: add fannal c3004 panel

2023-05-23 Thread Paulo Pavacic
Hello, pon, 22. svi 2023. u 10:55 napisao je: > > On 19/05/2023 16:24, Paulo Pavacic wrote: > > Fannal C3004 is a 2 lane MIPI DSI 480x800 panel which requires > > initialization with DSI DCS commands. After some commands delay is required. > > By curiosity, on which board is this panel used ? >

[PATCH 2/2] drm/i915/pmu: Make PMU sample array two-dimensional

2023-05-23 Thread Ashutosh Dixit
No functional changes but we can remove some unsightly index computation and read/write functions if we convert the PMU sample array from a one-dimensional to a two-dimensional array. Suggested-by: Tvrtko Ursulin Signed-off-by: Ashutosh Dixit --- drivers/gpu/drm/i915/i915_pmu.c | 60

[PATCH 1/2] drm/i915/pmu: Turn off the timer to sample frequencies when GT is parked

2023-05-23 Thread Ashutosh Dixit
pmu_needs_timer() keeps the timer running even when GT is parked, ostensibly to sample requested/actual frequencies. However frequency_sample() has the following: /* Report 0/0 (actual/requested) frequency while parked. */ if (!intel_gt_pm_get_if_awake(gt)) return;

[PATCH 0/2] drm/i915/pmu: couple of cleanups

2023-05-23 Thread Ashutosh Dixit
Ashutosh Dixit (2): drm/i915/pmu: Turn off the timer to sample frequencies when GT is parked drm/i915/pmu: Make PMU sample array two-dimensional drivers/gpu/drm/i915/i915_pmu.c | 72 +++-- drivers/gpu/drm/i915/i915_pmu.h | 2 +- 2 files changed, 24

Re: [PATCH] drm/i915/perf: Clear out entire reports after reading if not power of 2 size

2023-05-23 Thread Lionel Landwerlin
On 22/05/2023 23:17, Ashutosh Dixit wrote: Clearing out report id and timestamp as means to detect unlanded reports only works if report size is power of 2. That is, only when report size is a sub-multiple of the OA buffer size can we be certain that reports will land at the same place each time

[PATCH v2 resend] drm/armada: Fix off-by-one error in armada_overlay_get_property()

2023-05-23 Thread Geert Uytterhoeven
As ffs() returns one more than the index of the first bit set (zero means no bits set), the color key mode value is shifted one position too much. Fix this by using FIELD_GET() instead. Fixes: c96103b6c49ff9a8 ("drm/armada: move colorkey properties into overlay plane state") Signed-off-by:

[PATCH] Revert "drm/msm/dp: set self refresh aware based on PSR support"

2023-05-23 Thread Johan Hovold
This reverts commit 1844e680d56bb0c4e0489138f2b7ba2dc1c988e3. PSR support clearly is not ready for mainline and specifically breaks virtual terminals which are no longer updated when PSR is enabled (e.g. no keyboard input is echoed, no cursor blink). Disable PSR support for now by reverting

[PATCH] drm/i915: simplify switch to if-elseif

2023-05-23 Thread Tom Rix
clang with W=1 reports drivers/gpu/drm/i915/display/intel_display.c:6012:3: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough] case I915_FORMAT_MOD_X_TILED: ^ Only one case and the default does anything in this switch, so it

Re: [PATCH] drm/i915: simplify switch to if-elseif

2023-05-23 Thread Jani Nikula
On Tue, 23 May 2023, Tom Rix wrote: > clang with W=1 reports > drivers/gpu/drm/i915/display/intel_display.c:6012:3: error: unannotated > fall-through between switch labels [-Werror,-Wimplicit-fallthrough] > case I915_FORMAT_MOD_X_TILED: > ^ > > Only one case and

[PATCH v2] drm/fb-helper: Fix height, width, and accel_flags in fb_var

2023-05-23 Thread Geert Uytterhoeven
Fbtest contains some very simple validation of the fbdev userspace API contract. When used with shmob-drm, it reports the following warnings and errors: height changed from 68 to 0 height was rounded down width changed from 111 to 0 width was rounded down accel_flags changed

Re: [PATCH 2/6] drm/i915/uc/gsc: fixes and updates for GSC memory allocation

2023-05-23 Thread Ceraolo Spurio, Daniele
On 5/22/2023 5:13 PM, Teres Alexis, Alan Previn wrote: On Fri, 2023-05-05 at 09:04 -0700, Ceraolo Spurio, Daniele wrote: A few fixes/updates are required around the GSC memory allocation and it is easier to do them all at the same time. The changes are as follows: alan:snip @@ -109,38

Re: [PATCH] drm/msm/dp: add module parameter for PSR

2023-05-23 Thread Johan Hovold
On Fri, May 12, 2023 at 09:13:04PM +0300, Dmitry Baryshkov wrote: > On 28/04/2023 02:28, Abhinav Kumar wrote: > > On sc7280 where eDP is the primary display, PSR is causing > > IGT breakage even for basic test cases like kms_atomic and > > kms_atomic_transition. Most often the issue starts with

Re: [PATCH 4/4] drm/mgag200: Use DMA to copy the framebuffer to the VRAM

2023-05-23 Thread Jocelyn Falempe
On 09/05/2023 11:49, Jocelyn Falempe wrote: On 08/05/2023 10:04, Thomas Zimmermann wrote: Hi Jocelyn Am 05.05.23 um 14:43 schrieb Jocelyn Falempe: [cut] +    /* pad each line to 32bits boundaries see section 4.5.7 of G200 Specification */ +    int width_padded = round_up(width * cpp, 4); +

Re: [Freedreno] [PATCH v2 0/7] drm/msm/dpu: simplify DPU encoder init

2023-05-23 Thread Dmitry Baryshkov
On Tue, 23 May 2023 at 04:58, Abhinav Kumar wrote: > > > > On 5/18/2023 7:38 PM, Dmitry Baryshkov wrote: > > Rework dpu_encoder initialization code, simplifying calling sequences > > and separating common init parts. > > > > Changes since v1: > > - Withdrawn two pathes for a later consideration >

Re: [PATCH v4 06/12] drm/msm/dpu: Add SM6350 support

2023-05-23 Thread Konrad Dybcio
On 21.05.2023 17:44, Dmitry Baryshkov wrote: > On 19/05/2023 20:04, Konrad Dybcio wrote: >> Add SM6350 support to the DPU1 driver to enable display output. >> >> It's worth noting that one entry dpu_qos_lut_entry was trimmed off: >> >> {.fl = 0, .lut = 0x0011223344556677 }, >> >> due to the

Re: [PATCH v14 1/2] drm: add kms driver for loongson display controller

2023-05-23 Thread WANG Xuerui
On 2023/5/22 16:51, Sui Jingfeng wrote: Hi, On 2023/5/21 20:21, WANG Xuerui wrote: + +static void lsdc_crtc0_soft_reset(struct lsdc_crtc *lcrtc) +{ +    struct lsdc_device *ldev = lcrtc->ldev; +    u32 val; + +    val = lsdc_rreg32(ldev, LSDC_CRTC0_CFG_REG); + +    val &=

[PATCH] drm/rockchip: Replace all non-returning strlcpy with strscpy

2023-05-23 Thread Azeem Shaikh
strlcpy() reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to remove strlcpy() completely [2], replace strlcpy() here with strscpy(). No

[PATCH] drm/amd/pm: Replace all non-returning strlcpy with strscpy

2023-05-23 Thread Azeem Shaikh
strlcpy() reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to remove strlcpy() completely [2], replace strlcpy() here with strscpy(). No

Re: [PATCH] Revert "drm/msm/dp: Remove INIT_SETUP delay"

2023-05-23 Thread Leonard Lausen
Abhinav Kumar writes: There is no need to add the 100ms delay back yet. thanks for posting this but NAK on this patch till we post the fix this week. Appreciate a bit of patience till then. >>> >>> This regression is already part of the 6.3 stable release series.

Re: [Intel-gfx] [PATCH v10 0/2] drm/i915: Allow user to set cache at BO creation

2023-05-23 Thread Andi Shyti
Hi Fei, finally... pushed in drm-intel-gt-next! :) Andi On Thu, May 18, 2023 at 10:11:01PM -0700, fei.y...@intel.com wrote: > From: Fei Yang > > This series introduce a new extension for GEM_CREATE, > 1. end support for set caching ioctl [PATCH 1/2] > 2. add set_pat extension for gem_create

RE: [PATCH] drm/drm_vblank.c: avoid unsigned int to signed int cast

2023-05-23 Thread David Laight
From: 15330273...@189.cn <15330273...@189.cn> > Sent: 23 May 2023 05:27 > > On 2023/5/22 19:29, Jani Nikula wrote: > > In general, do not use unsigned types in arithmethic to avoid negative > > values, because most people will be tripped over by integer promotion > > rules, and you'll get

Re: [PATCH] drm/nouveau/acr: Abort loading ACR if no firmware was found

2023-05-23 Thread Karol Herbst
On Mon, May 22, 2023 at 10:18 PM Karol Herbst wrote: > > This fixes a NULL pointer access inside nvkm_acr_oneinit in case necessary > firmware files couldn't be loaded. > > Closes: https://gitlab.freedesktop.org/drm/nouveau/-/issues/212 > Fixes: 4b569ded09fd ("drm/nouveau/acr/ga102: initial

[PATCH] drm/drm_vblank.c: using u32 instead of the int to store frame size

2023-05-23 Thread Sui Jingfeng
From: Sui Jingfeng Both mode->crtc_htotal and mode->crtc_vtotal are u16 type, using a u32 is to store the result instead of int. Signed-off-by: Sui Jingfeng Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org

Re: [PATCH v2 RESEND 4/7] swiotlb: Dynamically allocated bounce buffers

2023-05-23 Thread Petr Tesařík
On Tue, 23 May 2023 10:54:11 +0100 Catalin Marinas wrote: > On Wed, May 17, 2023 at 01:27:48PM +0200, Petr Tesařík wrote: > > On Wed, 17 May 2023 08:35:10 +0200 > > Petr Tesařík wrote: > > > Anyway, my greatest objection to allocating additional swiotlb chunks is > > > that _all_ of them must

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Add helpers for managing rps thresholds

2023-05-23 Thread Andi Shyti
Hi Tvrtko, > > > + /* Force reset. */ > > > + rps->last_freq = -1; > > > + mutex_lock(>power.mutex); > > > + rps->power.mode = -1; > > > + mutex_unlock(>power.mutex); > > > + > > > + intel_rps_set(rps, clamp(rps->cur_freq, > > > + rps->min_freq_softlimit, > > > +

[PATCH 07/15] phy: qualcomm: add MSM8974 HDMI PHY driver

2023-05-23 Thread Dmitry Baryshkov
Port the HDMI PHY driver for Qualcomm MSM8974 / APQ8074 platforms. Signed-off-by: Dmitry Baryshkov --- drivers/phy/qualcomm/Kconfig | 11 + drivers/phy/qualcomm/Makefile| 1 + drivers/phy/qualcomm/phy-qcom-hdmi-msm8974.c | 531 +++ 3 files

[PATCH 01/15] phy: Add HDMI configuration options

2023-05-23 Thread Dmitry Baryshkov
From: Sandor Yu Allow HDMI PHYs to be configured through the generic functions through a custom structure added to the generic union. The parameters added here are based on HDMI PHY implementation practices. The current set of parameters should cover the potential users. Signed-off-by: Sandor

Re: [PATCH] drm/drm_vblank.c: avoid unsigned int to signed int cast

2023-05-23 Thread Sui Jingfeng
Hi, On 2023/5/23 12:26, Sui Jingfeng wrote: Hi, On 2023/5/22 19:29, Jani Nikula wrote: In general, do not use unsigned types in arithmethic to avoid negative values, because most people will be tripped over by integer promotion rules, and you'll get negative values anyway. Here I'm sure

[PATCH v2 3/3] drm/panel-simple: allow LVDS format override

2023-05-23 Thread Johannes Zink
Some panels support multiple LVDS data mapping formats, which can be used e.g. run displays on jeida-18 format when only 3 LVDS lanes are available. Add parsing of an optional data-mapping devicetree property, which also touches up the bits per color to match the bus format. Signed-off-by:

[PATCH v2 2/3] dt-bindings: display: simple: support non-default data-mapping

2023-05-23 Thread Johannes Zink
Some Displays support more than just a single default lvds data mapping, which can be used to run displays on only 3 LVDS lanes in the jeida-18 data-mapping mode. Add an optional data-mapping property to allow overriding the default data mapping. As it does not generally apply to any display and

[PATCH v2 1/3] dt-bindings: display: move LVDS data-mapping definition to separate file

2023-05-23 Thread Johannes Zink
As the LVDS data-mapping property is required in multiple bindings: move it to separate file and include instead of duplicating it. Signed-off-by: Johannes Zink --- Changes: v1 -> v2: worked in Rob's review findings (thank you for reviewing my work): extract common properties to

[PATCH v2 0/3] Support non-default LVDS data mapping for simple panel

2023-05-23 Thread Johannes Zink
26 ++- drivers/gpu/drm/panel/panel-simple.c | 39 +- 4 files changed, 155 insertions(+), 69 deletions(-) --- base-commit: 33a86170888b7e4aa0cea94ebb9c67180139cea9 change-id: 20230523-simplepanel_support_nondefault_datamapping-13c3f2ea28f8 Best regards, -- Johannes Zink

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Add helpers for managing rps thresholds

2023-05-23 Thread Tvrtko Ursulin
On 23/05/2023 00:09, Andi Shyti wrote: Hi Tvrtko, On Mon, May 22, 2023 at 12:59:27PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin In preparation for exposing via sysfs add helpers for managing rps thresholds. v2: * Force sw and hw re-programming on threshold change. Signed-off-by:

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-05-23 Thread Hans Verkuil
On 22/05/2023 12:18, Biju Das wrote: > Renesas PMIC RAA215300 exposes two separate i2c devices, one for the main > device and another for rtc device. > > Enhance i2c_new_ancillary_device() to instantiate a real device. > (eg: Instantiate rtc device from PMIC driver) > > Added helper function

Re: [PATCH] drm/drm_vblank.c: avoid unsigned int to signed int cast

2023-05-23 Thread Sui Jingfeng
Hi, On 2023/5/23 16:50, David Laight wrote: From: 15330273...@189.cn <15330273...@189.cn> Sent: 23 May 2023 05:27 On 2023/5/22 19:29, Jani Nikula wrote: In general, do not use unsigned types in arithmethic to avoid negative values, because most people will be tripped over by integer

[Bug 201957] amdgpu: ring gfx timeout

2023-05-23 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201957 Stuart Foster (smf-li...@virginmedia.com) changed: What|Removed |Added CC|

[PATCH] drm: mediatek: mtk_dsi: Fix NO_EOT_PACKET settings/handling

2023-05-23 Thread AngeloGioacchino Del Regno
Due to the initial confusion about MIPI_DSI_MODE_EOT_PACKET, properly renamed to MIPI_DSI_MODE_NO_EOT_PACKET, reflecting its actual meaning, both the DSI_TXRX_CON register setting for bit (HSTX_)DIS_EOT and the later calculation for horizontal sync-active (HSA), back (HBP) and front (HFP) porches

[PATCH] drm/amd/display: remove unused variables res_create_maximus_funcs and debug_defaults_diags

2023-05-23 Thread Tom Rix
gcc with W=1 reports drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_resource.c:1069:43: error: ‘res_create_maximus_funcs’ defined but not used [-Werror=unused-const-variable=] 1069 | static const struct resource_create_funcs res_create_maximus_funcs = { |

Re: [PATCH v2 3/3] arm64: dts: qcom: sc8280xp: Enable GPU related nodes

2023-05-23 Thread Bjorn Andersson
On Tue, May 23, 2023 at 10:04:40AM +0200, Konrad Dybcio wrote: > > > On 23.05.2023 03:15, Bjorn Andersson wrote: > > From: Bjorn Andersson > > > > Add memory reservation for the zap-shader and enable the Adreno SMMU, > > GPU clock controller, GMU and the GPU nodes for the SC8280XP CRD and the

Re: [PATCH] drm/msm: Use struct fb_info.screen_buffer

2023-05-23 Thread Javier Martinez Canillas
Hello Thomas, On Mon, May 22, 2023 at 9:17 PM Thomas Zimmermann wrote: > > The fbdev framebuffer is in system memory. Store the address in > the field 'screen_buffer'. Fixes the following sparse warning. > > ../drivers/gpu/drm/msm/msm_fbdev.c:124:26: warning: incorrect type in > assignment

Re: [PATCH v2 3/3] arm64: dts: qcom: sc8280xp: Enable GPU related nodes

2023-05-23 Thread Konrad Dybcio
On 23.05.2023 03:15, Bjorn Andersson wrote: > From: Bjorn Andersson > > Add memory reservation for the zap-shader and enable the Adreno SMMU, > GPU clock controller, GMU and the GPU nodes for the SC8280XP CRD and the > Lenovo ThinkPad X13s. > > Signed-off-by: Bjorn Andersson >

[PATCH] drm/mediatek: Replace all non-returning strlcpy with strscpy

2023-05-23 Thread Azeem Shaikh
strlcpy() reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to remove strlcpy() completely [2], replace strlcpy() here with strscpy(). No

Re: [PATCH v14 1/2] drm: add kms driver for loongson display controller

2023-05-23 Thread WANG Xuerui
On 5/22/23 21:13, Sui Jingfeng wrote: Hi, On 2023/5/22 18:25, WANG Xuerui wrote: On 2023/5/22 18:17, Sui Jingfeng wrote: Hi, On 2023/5/22 18:05, WANG Xuerui wrote: On 2023/5/22 17:49, Sui Jingfeng wrote: Hi, On 2023/5/22 17:28, WANG Xuerui wrote: On 2023/5/22 17:25, Sui Jingfeng wrote:

Re: [PATCH v14 1/2] drm: add kms driver for loongson display controller

2023-05-23 Thread WANG Xuerui
On 2023/5/22 16:02, Sui Jingfeng wrote: Hi, On 2023/5/21 20:21, WANG Xuerui wrote: --- /dev/null +++ b/drivers/gpu/drm/loongson/Kconfig @@ -0,0 +1,17 @@ +# SPDX-License-Identifier: GPL-2.0 + +config DRM_LOONGSON +    tristate "DRM support for Loongson Graphics" +    depends on DRM && PCI &&

Re: [PATCH v14 1/2] drm: add kms driver for loongson display controller

2023-05-23 Thread WANG Xuerui
On 2023/5/22 17:05, Sui Jingfeng wrote: Hi, On 2023/5/21 20:21, WANG Xuerui wrote: +++ b/drivers/gpu/drm/loongson/lsdc_debugfs.c @@ -0,0 +1,91 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Copyright (C) 2023 Loongson Technology Corporation Limited + */ + +#include + +#include

Re: [PATCH v14 1/2] drm: add kms driver for loongson display controller

2023-05-23 Thread WANG Xuerui
On 2023/5/22 16:29, Sui Jingfeng wrote: On 2023/5/22 16:09, WANG Xuerui wrote: On 2023/5/22 16:02, Sui Jingfeng wrote: Hi, On 2023/5/21 20:21, WANG Xuerui wrote: --- /dev/null +++ b/drivers/gpu/drm/loongson/Kconfig @@ -0,0 +1,17 @@ +# SPDX-License-Identifier: GPL-2.0 + +config DRM_LOONGSON

[PATCH] drm/i915: Replace all non-returning strlcpy with strscpy

2023-05-23 Thread Azeem Shaikh
strlcpy() reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to remove strlcpy() completely [2], replace strlcpy() here with strscpy(). No

Re: [PATCH v14 1/2] drm: add kms driver for loongson display controller

2023-05-23 Thread WANG Xuerui
On 2023/5/22 17:25, Sui Jingfeng wrote: Hi, On 2023/5/21 20:21, WANG Xuerui wrote: + * LS3A4000/LS3A5000/LS3A6000 CPU, they are equipped with on-board video RAM + * typically. While LS2K0500/LS2K1000/LS2K2000 are low cost SoCs which share + * the system RAM as video RAM, they don't has a

Re: [PATCH v14 1/2] drm: add kms driver for loongson display controller

2023-05-23 Thread WANG Xuerui
On 2023/5/22 18:17, Sui Jingfeng wrote: Hi, On 2023/5/22 18:05, WANG Xuerui wrote: On 2023/5/22 17:49, Sui Jingfeng wrote: Hi, On 2023/5/22 17:28, WANG Xuerui wrote: On 2023/5/22 17:25, Sui Jingfeng wrote: Hi, On 2023/5/21 20:21, WANG Xuerui wrote: + * LS3A4000/LS3A5000/LS3A6000 CPU, they

  1   2   3   >