Re: [PATCH v2 1/6] dt-bindings: display: Add yamls for JH7110 display system

2023-11-29 Thread Krzysztof Kozlowski
On 29/11/2023 04:13, Keith Zhao wrote: > > > On 2023/10/25 20:50, Krzysztof Kozlowski wrote: >> On 25/10/2023 12:39, Keith Zhao wrote: >>> StarFive SoCs JH7110 display system: >> >> A nit, subject: drop second/last, redundant "yamls for". The >> "dt-bindings" prefix is already stating that these

[PATCH v2 RESEND] drm/panel: starry-2081101qfh032011-53g: Fine tune the panel power sequence

2023-11-29 Thread xiazhengqiao
For the "starry, 2081101qfh032011-53g" panel, it is stipulated in the panel spec that MIPI needs to keep the LP11 state before the lcm_reset pin is pulled high. Fixes: 6069b66cd962 ("drm/panel: support for STARRY 2081101QFH032011-53G MIPI-DSI panel") Signed-off-by: xiazhengqiao Reviewed-by:

Re: [PATCH v2 11/12] drm/rockchip: vop2: Add debugfs support

2023-11-29 Thread Sascha Hauer
On Mon, Nov 27, 2023 at 06:56:34PM +0800, Andy Yan wrote: >Hi Sascha: > >thanks for you review. > >On 11/27/23 18:13, Sascha Hauer wrote: > > On Wed, Nov 22, 2023 at 08:56:01PM +0800, Andy Yan wrote: > > From: Andy Yan [1] > > /sys/kernel/debug/dri/vop2/summary: dump vop

Re: [PATCH] drm/imagination: DRM_POWERVR should depend on ARCH_K3

2023-11-29 Thread Geert Uytterhoeven
Hi Maxime, On Wed, Nov 29, 2023 at 9:35 AM Maxime Ripard wrote: > On Tue, Nov 28, 2023 at 08:16:18PM +0100, Geert Uytterhoeven wrote: > > On Tue, Nov 28, 2023 at 8:03 PM Javier Martinez Canillas > > wrote: > > > Geert Uytterhoeven writes: > > > > The Imagination Technologies PowerVR Series 6

Re: [PATCH] drm/imagination: DRM_POWERVR should depend on ARCH_K3

2023-11-29 Thread Maxime Ripard
On Wed, Nov 29, 2023 at 09:58:12AM +0100, Geert Uytterhoeven wrote: > Hi Maxime, > > On Wed, Nov 29, 2023 at 9:35 AM Maxime Ripard wrote: > > On Tue, Nov 28, 2023 at 08:16:18PM +0100, Geert Uytterhoeven wrote: > > > On Tue, Nov 28, 2023 at 8:03 PM Javier Martinez Canillas > > > wrote: > > > >

Re: [PATCH] [drm/meson] meson_plane: Add error handling

2023-11-29 Thread neil . armstrong
Hi, Thanks for your patch! On 29/11/2023 10:21, Haoran Liu wrote: This patch adds robust error handling to the meson_plane_create function in drivers/gpu/drm/meson/meson_plane.c. The function previously lacked proper handling for potential failure scenarios of the drm_universal_plane_init

Re: [PATCH] drm/sched: Fix compilation issues with DRM priority rename

2023-11-29 Thread Sverdlin, Alexander
Hi Luben, thanks for the patch! On Sat, 2023-11-25 at 14:22 -0500, Luben Tuikov wrote: > Fix compilation issues with DRM scheduler priority rename MIN to LOW. > > Signed-off-by: Luben Tuikov > Reported-by: kernel test robot > Closes: >

[PATCH] drm/panel: nt36523: fix return value check in nt36523_probe()

2023-11-29 Thread Yang Yingliang
From: Yang Yingliang mipi_dsi_device_register_full() never returns NULL pointer, it will return ERR_PTR() when it fails, so replace the check with IS_ERR(). Fixes: 0993234a0045 ("drm/panel: Add driver for Novatek NT36523") Signed-off-by: Yang Yingliang ---

[PATCH] [drm/meson] meson_plane: Add error handling

2023-11-29 Thread Haoran Liu
This patch adds robust error handling to the meson_plane_create function in drivers/gpu/drm/meson/meson_plane.c. The function previously lacked proper handling for potential failure scenarios of the drm_universal_plane_init call. Signed-off-by: Haoran Liu --- drivers/gpu/drm/meson/meson_plane.c

Re: [PATCH v4 05/45] drm/connector: Check drm_connector_init pointers arguments

2023-11-29 Thread Jani Nikula
On Wed, 29 Nov 2023, Maxime Ripard wrote: > Hi Ville, > > On Tue, Nov 28, 2023 at 03:49:08PM +0200, Ville Syrjälä wrote: >> On Tue, Nov 28, 2023 at 02:29:40PM +0100, Maxime Ripard wrote: >> > On Tue, Nov 28, 2023 at 02:54:02PM +0200, Jani Nikula wrote: >> > > On Tue, 28 Nov 2023, Maxime Ripard

Re: [PATCH 0/3] drm/bridge: ti-sn65dsi86: Some updates

2023-11-29 Thread Uwe Kleine-König
Hello Laurent, On Wed, Nov 29, 2023 at 02:45:33AM +0200, Laurent Pinchart wrote: > On Fri, Nov 24, 2023 at 09:56:55AM +0100, Neil Armstrong wrote: > > On 23/11/2023 18:54, Uwe Kleine-König wrote: > > > Hello, > > > > > > this is a series I created while starring at the ti-sn65dsi86 driver in > >

[PATCH] [drm/sti] sti_compositor: Add error handlingin sti_compositor_bind

2023-11-29 Thread Haoran Liu
Previously, the function sti_compositor_bind did not properly handle potential failure scenarios of drm_vblank_init, which could lead to unexpected behavior. This update adds a check for the return value of drm_vblank_init. Signed-off-by: Haoran Liu --- drivers/gpu/drm/sti/sti_compositor.c | 7

Re: [PATCH 1/3] drm/bridge: ti-sn65dsi86: Simplify using pm_runtime_resume_and_get()

2023-11-29 Thread Laurent Pinchart
Hi Uwe, On Wed, Nov 29, 2023 at 10:51:37AM +0100, Uwe Kleine-König wrote: > On Wed, Nov 29, 2023 at 02:39:55AM +0200, Laurent Pinchart wrote: > > On Thu, Nov 23, 2023 at 06:54:27PM +0100, Uwe Kleine-König wrote: > > > pm_runtime_resume_and_get() already drops the runtime PM usage counter > > > in

RE: [RFC PATCH 0/6] Supporting GMEM (generalized memory management) for external memory devices

2023-11-29 Thread zhuweixi
Glad to hear that more sharable code is desirable. IMHO, for a common MM subsystem, it is more beneficial for GMEM to extend core MM instead of building a separate one. As stated in the beginning of my RFC letter, MM systems are large and similar. Even a sophisticated one like Linux MM that

Re: [PATCH] drm/imagination: DRM_POWERVR should depend on ARCH_K3

2023-11-29 Thread Maxime Ripard
Hi, On Tue, Nov 28, 2023 at 08:16:18PM +0100, Geert Uytterhoeven wrote: > On Tue, Nov 28, 2023 at 8:03 PM Javier Martinez Canillas > wrote: > > Geert Uytterhoeven writes: > > > The Imagination Technologies PowerVR Series 6 GPU is currently only > > > supported on Texas Instruments K3 AM62x

Re: [PATCH] drm/imagination: DRM_POWERVR should depend on ARCH_K3

2023-11-29 Thread Javier Martinez Canillas
Maxime Ripard writes: Hello Maxime, > Hi, > > On Tue, Nov 28, 2023 at 08:16:18PM +0100, Geert Uytterhoeven wrote: >> On Tue, Nov 28, 2023 at 8:03 PM Javier Martinez Canillas >> wrote: >> > Geert Uytterhoeven writes: >> > > The Imagination Technologies PowerVR Series 6 GPU is currently only >>

Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-11-29 Thread Neil Armstrong
On 08/11/2023 16:58, Laurent Pinchart wrote: On Wed, Nov 08, 2023 at 04:34:39PM +0100, Maxime Ripard wrote: On Tue, Nov 07, 2023 at 04:26:34PM +0100, Greg Kroah-Hartman wrote: On Tue, Nov 07, 2023 at 01:18:14PM +0100, Maxime Ripard wrote: On Tue, Nov 07, 2023 at 12:22:21PM +0100, Greg

Re: [PATCH v5 1/4] pwm: rename pwm_apply_state() to pwm_apply_cansleep()

2023-11-29 Thread Sean Young
On Fri, Nov 24, 2023 at 02:31:18PM +0100, Thierry Reding wrote: > On Sat, Nov 18, 2023 at 04:16:17PM +, Sean Young wrote: > > In order to introduce a pwm api which can be used from atomic context, > > we will need two functions for applying pwm changes: > > > > int

[PATCH v6 1/4] pwm: rename pwm_apply_state() to pwm_apply_might_sleep()

2023-11-29 Thread Sean Young
In order to introduce a pwm api which can be used from atomic context, we will need two functions for applying pwm changes: int pwm_apply_might_sleep(struct pwm *, struct pwm_state *); int pwm_apply_atomic(struct pwm *, struct pwm_state *); This commit just deals with renaming

Re: [PATCH] drm/imagination: DRM_POWERVR should depend on ARCH_K3

2023-11-29 Thread Javier Martinez Canillas
Geert Uytterhoeven writes: Hello Geert, > Hi Maxime, > > On Wed, Nov 29, 2023 at 9:35 AM Maxime Ripard wrote: >> On Tue, Nov 28, 2023 at 08:16:18PM +0100, Geert Uytterhoeven wrote: >> > On Tue, Nov 28, 2023 at 8:03 PM Javier Martinez Canillas >> > wrote: >> > > Geert Uytterhoeven writes: >>

Re: [PATCH v3 07/11] drm/mediatek: Support alpha blending in VDOSYS0

2023-11-29 Thread 宋孝謙

Re: [PATCH] drm/imagination: DRM_POWERVR should depend on ARCH_K3

2023-11-29 Thread Geert Uytterhoeven
Hi Javier, On Wed, Nov 29, 2023 at 10:13 AM Javier Martinez Canillas wrote: > Geert Uytterhoeven writes: > > On Wed, Nov 29, 2023 at 9:35 AM Maxime Ripard wrote: > >> On Tue, Nov 28, 2023 at 08:16:18PM +0100, Geert Uytterhoeven wrote: > >> > On Tue, Nov 28, 2023 at 8:03 PM Javier Martinez

Re: [PATCH] drm/imagination: DRM_POWERVR should depend on ARCH_K3

2023-11-29 Thread Geert Uytterhoeven
Hi Maxime, On Wed, Nov 29, 2023 at 10:23 AM Maxime Ripard wrote: > On Wed, Nov 29, 2023 at 09:58:12AM +0100, Geert Uytterhoeven wrote: > > On Wed, Nov 29, 2023 at 9:35 AM Maxime Ripard wrote: > > > On Tue, Nov 28, 2023 at 08:16:18PM +0100, Geert Uytterhoeven wrote: > > > > On Tue, Nov 28, 2023

Re: [PATCH v2 10/12] drm/rockchip: vop2: Add support for rk3588

2023-11-29 Thread Andy Yan
Hi Sascha, On 11/27/23 19:19, Sascha Hauer wrote: Hi Andy, Looks good overall, two small things inside. On Wed, Nov 22, 2023 at 08:55:44PM +0800, Andy Yan wrote: +#define vop2_output_if_is_hdmi(x) (x == ROCKCHIP_VOP2_EP_HDMI0 || x == ROCKCHIP_VOP2_EP_HDMI1) +#define

Re: [RFC PATCH 2/6] mm/gmem: add arch-independent abstraction to track address mapping status

2023-11-29 Thread linear cannon
On 11/28/23 07:50, Weixi Zhu wrote: This patch adds an abstraction layer, struct vm_object, that maintains per-process virtual-to-physical mapping status stored in struct gm_mapping. For example, a virtual page may be mapped to a CPU physical page or to a device physical page. Struct vm_object

[PATCH v6] Documentation/gpu: VM_BIND locking document

2023-11-29 Thread Thomas Hellström
Add the first version of the VM_BIND locking document which is intended to be part of the xe driver upstreaming agreement. The document describes and discuss the locking used during exec- functions, evicton and for userptr gpu-vmas. Intention is to be using the same nomenclature as the

Re: [PATCH v4 05/45] drm/connector: Check drm_connector_init pointers arguments

2023-11-29 Thread Maxime Ripard
Hi Ville, On Tue, Nov 28, 2023 at 03:49:08PM +0200, Ville Syrjälä wrote: > On Tue, Nov 28, 2023 at 02:29:40PM +0100, Maxime Ripard wrote: > > On Tue, Nov 28, 2023 at 02:54:02PM +0200, Jani Nikula wrote: > > > On Tue, 28 Nov 2023, Maxime Ripard wrote: > > > > All the drm_connector_init variants

Re: [PATCH v4 05/45] drm/connector: Check drm_connector_init pointers arguments

2023-11-29 Thread Ville Syrjälä
On Wed, Nov 29, 2023 at 10:11:26AM +0100, Maxime Ripard wrote: > Hi Ville, > > On Tue, Nov 28, 2023 at 03:49:08PM +0200, Ville Syrjälä wrote: > > On Tue, Nov 28, 2023 at 02:29:40PM +0100, Maxime Ripard wrote: > > > On Tue, Nov 28, 2023 at 02:54:02PM +0200, Jani Nikula wrote: > > > > On Tue, 28

Re: [PATCH 1/3] drm/bridge: ti-sn65dsi86: Simplify using pm_runtime_resume_and_get()

2023-11-29 Thread Uwe Kleine-König
Hello Laurent, On Wed, Nov 29, 2023 at 02:39:55AM +0200, Laurent Pinchart wrote: > On Thu, Nov 23, 2023 at 06:54:27PM +0100, Uwe Kleine-König wrote: > > pm_runtime_resume_and_get() already drops the runtime PM usage counter > > in the error case. So a call to pm_runtime_put_sync() can be dropped.

Re: [PATCH 1/2] Revert "drm/bridge: Add 200ms delay to wait FW HPD status stable"

2023-11-29 Thread Robert Foss
On Mon, 20 Nov 2023 17:10:36 +0800, Xin Ji wrote: > This reverts commit 330140d7319fcc4ec68bd924ea212e476bf12275 > > 200ms delay will cause panel display image later than backlight > turn on, revert this patch. > > Applied, thanks! [1/2] Revert "drm/bridge: Add 200ms delay to wait FW HPD

Re: [PATCH v4 05/45] drm/connector: Check drm_connector_init pointers arguments

2023-11-29 Thread Pekka Paalanen
On Tue, 28 Nov 2023 15:49:08 +0200 Ville Syrjälä wrote: > Should we perhaps start to use the (arguably hideous) > - void f(struct foo *bar) > + void f(struct foo bar[static 1]) > syntax to tell the compiler we don't accept NULL pointers? > > Hmm. Apparently that has the same problem as using

Re: Radeon regression in 6.6 kernel

2023-11-29 Thread Alex Deucher
On Wed, Nov 29, 2023 at 11:41 AM Luben Tuikov wrote: > > On 2023-11-29 10:22, Alex Deucher wrote: > > On Wed, Nov 29, 2023 at 8:50 AM Alex Deucher wrote: > >> > >> On Tue, Nov 28, 2023 at 11:45 PM Luben Tuikov wrote: > >>> > >>> On 2023-11-28 17:13, Alex Deucher wrote: > On Mon, Nov 27,

Re: [PATCH v6] Documentation/gpu: VM_BIND locking document

2023-11-29 Thread Thomas Hellström
On 11/29/23 20:20, John Hubbard wrote: On 11/29/23 01:06, Thomas Hellström wrote: Add the first version of the VM_BIND locking document which is intended to be part of the xe driver upstreaming agreement. The document describes and discuss the locking used during exec- functions, evicton and

[PATCH v3 10/12] arm64: dts: qcom: qrb2210-rb1: Set up HDMI

2023-11-29 Thread Konrad Dybcio
Add the required nodes to support display output via the HDMI port. Reviewed-by: Dmitry Baryshkov Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/qrb2210-rb1.dts | 86 1 file changed, 86 insertions(+) diff --git

[PATCH v3 06/12] arm64: dts: qcom: sc7180: Add the missing MDSS icc path

2023-11-29 Thread Konrad Dybcio
MDSS, aside from the MDP-MEM path, also requires the CPU-DISP_CFG one. Failing to provide it may result in register accesses failing and that's never good. Add the missing path. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 8 ++-- 1 file changed, 6 insertions(+),

[PATCH v3 05/12] iommu/arm-smmu-qcom: Add QCM2290 MDSS compatible

2023-11-29 Thread Konrad Dybcio
Add the QCM2290 MDSS compatible to clients compatible list, as it also needs the workarounds. Reviewed-by: Dmitry Baryshkov Signed-off-by: Konrad Dybcio --- drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c

[PATCH v3 11/12] arm64: dts: qcom: qrb2210-rb1: Enable CAN bus controller

2023-11-29 Thread Konrad Dybcio
Enable the Microchip mcp2518fd hosted on the SPI5 bus. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/qrb2210-rb1.dts | 22 ++ 1 file changed, 22 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts b/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts index

[PATCH v3 09/12] arm64: dts: qcom: qcm2290: Hook up interconnects

2023-11-29 Thread Konrad Dybcio
Add interconnect provider nodes and hook up interconnects to consumer devices, including bwmon. Reviewed-by: Dmitry Baryshkov Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/qcm2290.dtsi | 248 ++ 1 file changed, 248 insertions(+) diff --git

[PATCH v3 12/12] arm64: dts: qcom: qrb2210-rb1: add wifi variant property

2023-11-29 Thread Konrad Dybcio
From: Dmitry Baryshkov The RB1 platform doesn't have board-specific board-id programmed, it uses generic 0xff. Thus add the property with the 'variant' of the calibration data. Note: the driver will check for the calibration data for the following IDs, so existing board-2.bin files will

[PATCH 2/5] drm/imagination: Fixed missing header in pvr_fw_meta

2023-11-29 Thread Donald Robson
Reported-by: Arnd Bergmann Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202311250226.da2yiskp-...@intel.com/ Fixes: bb52a8dc84f2 ("drm/imagination: Implement firmware infrastructure and META FW support") Signed-off-by: Donald Robson ---

[PATCH 3/5] drm/imagination: pvr_device_process_active_queues now static

2023-11-29 Thread Donald Robson
Reported-by: Arnd Bergmann Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202311250632.givex7mu-...@intel.com/ Fixes: c98dab7a5f5f ("drm/imagination: Implement job submission and scheduling") Signed-off-by: Donald Robson ---

[PATCH 5/5] drm/imagination: Removed unused function to_pvr_vm_gpuva()

2023-11-29 Thread Donald Robson
Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202311242159.hh8mwiam-...@intel.com/ Fixes: 3c96dd170efe ("drm/imagination: Add GEM and VM related code") Signed-off-by: Donald Robson --- drivers/gpu/drm/imagination/pvr_vm.c | 6 -- 1 file changed, 6

[PATCH 4/5] drm/imagination: pvr_gpuvm_free() now static

2023-11-29 Thread Donald Robson
Reported-by: Arnd Bergmann Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202311242159.hh8mwiam-...@intel.com/ Fixes: 3c96dd170efe ("drm/imagination: Add GEM and VM related code") Signed-off-by: Donald Robson --- drivers/gpu/drm/imagination/pvr_vm.c | 2 +- 1

Re: Radeon regression in 6.6 kernel

2023-11-29 Thread Luben Tuikov
On 2023-11-29 08:50, Alex Deucher wrote: > On Tue, Nov 28, 2023 at 11:45 PM Luben Tuikov wrote: >> >> On 2023-11-28 17:13, Alex Deucher wrote: >>> On Mon, Nov 27, 2023 at 6:24 PM Phillip Susi wrote: Alex Deucher writes: >> In that case those are the already known problems

Re: [PATCH 2/2] drm/tiny: Add driver for the sharp LS027B7DH01 Memory LCD

2023-11-29 Thread Thomas Zimmermann
7dh01_fops, + DRM_GEM_DMA_DRIVER_OPS_VMAP, + .name = "sharp_ls027b7dh01", + .desc = "Sharp ls027b7dh01 Memory LCD", + .date = "20231129", + .major = 1, +

Re: Radeon regression in 6.6 kernel

2023-11-29 Thread Luben Tuikov
On 2023-11-29 10:22, Alex Deucher wrote: > On Wed, Nov 29, 2023 at 8:50 AM Alex Deucher wrote: >> >> On Tue, Nov 28, 2023 at 11:45 PM Luben Tuikov wrote: >>> >>> On 2023-11-28 17:13, Alex Deucher wrote: On Mon, Nov 27, 2023 at 6:24 PM Phillip Susi wrote: > > Alex Deucher writes:

[PATCH v4 1/1] drm/i915/pxp: Add missing tag for Wa_14019159160

2023-11-29 Thread Alan Previn
Add missing tag for "Wa_14019159160 - Case 2" (for existing PXP code that ensures run alone mode bit is set to allow PxP-decryption. v4: - Include IP_VER 12.71. (Matt Roper) v3: - Check targeted platforms using IP_VAL. (John Harrison) v2: - Fix WA id number (John Harrison). - Improve

Re: [Intel-gfx] [PATCH v5] drm/i915/pxp: Add drm_dbgs for critical PXP events.

2023-11-29 Thread Teres Alexis, Alan Previn
On Fri, 2023-11-24 at 08:30 +, Tvrtko Ursulin wrote: > On 22/11/2023 19:15, Alan Previn wrote: alan:snip alan: thanks for reviewing. > > if (iir & GEN12_DISPLAY_STATE_RESET_COMPLETE_INTERRUPT) > > - pxp->session_events |= PXP_TERMINATION_COMPLETE; > > +

Re: Radeon regression in 6.6 kernel

2023-11-29 Thread Alex Deucher
Actually I think I see the problem. I'll try and send out a patch later today to test. Alex On Wed, Nov 29, 2023 at 1:52 PM Alex Deucher wrote: > > On Wed, Nov 29, 2023 at 11:41 AM Luben Tuikov wrote: > > > > On 2023-11-29 10:22, Alex Deucher wrote: > > > On Wed, Nov 29, 2023 at 8:50 AM Alex

Re: [RFC] drm: enable W=1 warnings by default across the subsystem

2023-11-29 Thread Hamza Mahfooz
Cc: Nathan Chancellor On 11/29/23 13:12, Jani Nikula wrote: At least the i915 and amd drivers enable a bunch more compiler warnings than the kernel defaults. Extend the W=1 warnings to the entire drm subsystem by default. Use the copy-pasted warnings from scripts/Makefile.extrawarn with

Re: Radeon regression in 6.6 kernel

2023-11-29 Thread Alex Deucher
On Wed, Nov 29, 2023 at 3:10 PM Alex Deucher wrote: > > Actually I think I see the problem. I'll try and send out a patch > later today to test. Does the attached patch fix it? Alex > > Alex > > On Wed, Nov 29, 2023 at 1:52 PM Alex Deucher wrote: > > > > On Wed, Nov 29, 2023 at 11:41 AM

[RFC] drm: enable W=1 warnings by default across the subsystem

2023-11-29 Thread Jani Nikula
At least the i915 and amd drivers enable a bunch more compiler warnings than the kernel defaults. Extend the W=1 warnings to the entire drm subsystem by default. Use the copy-pasted warnings from scripts/Makefile.extrawarn with s/KBUILD_CFLAGS/subdir-ccflags-y/ to make it easier to compare and

Re: Radeon regression in 6.6 kernel

2023-11-29 Thread Alex Deucher
On Wed, Nov 29, 2023 at 11:21 AM Luben Tuikov wrote: > > On 2023-11-29 08:50, Alex Deucher wrote: > > On Tue, Nov 28, 2023 at 11:45 PM Luben Tuikov wrote: > >> > >> On 2023-11-28 17:13, Alex Deucher wrote: > >>> On Mon, Nov 27, 2023 at 6:24 PM Phillip Susi wrote: > > Alex Deucher

Re: [PATCH v6 2/2] drm/i915/guc: Close deregister-context race against CT-loss

2023-11-29 Thread Teres Alexis, Alan Previn
On Mon, 2023-11-27 at 16:51 -0500, Vivi, Rodrigo wrote: alan: Firstly, thanks for taking the time to review this, knowing you have a lot on your plate right now. > alan:snip > > @@ -3301,19 +3315,38 @@ static inline void guc_lrc_desc_unpin(struct > > intel_context *ce) > > /* Seal race

Re: [PATCH v2 2/2] drm/i915/guc: Add a selftest for FAST_REQUEST errors

2023-11-29 Thread Daniele Ceraolo Spurio
On 11/13/2023 5:00 PM, john.c.harri...@intel.com wrote: From: John Harrison There is a mechanism for reporting errors from fire and forget H2G messages. This is the only way to find out about almost any error in the GuC backend submission path. So it would be useful to know that it is

Re: [PATCH v6] Documentation/gpu: VM_BIND locking document

2023-11-29 Thread John Hubbard
On 11/29/23 01:06, Thomas Hellström wrote: Add the first version of the VM_BIND locking document which is intended to be part of the xe driver upstreaming agreement. The document describes and discuss the locking used during exec- functions, evicton and for userptr gpu-vmas. Intention is to be

[PULL] drm-misc-fixes

2023-11-29 Thread Maarten Lankhorst
Hi Dave, Daniel, This pull request is a bit confusing, as it first adds the panel fixes and a driver/core change, then immediately revert it. Cheers, ~Maarten drm-misc-fixes-2023-11-29: Fixes for v6.7-rc4: - Revert panel fixes as they require exporting device_is_dependent. - Do not double

Re: Radeon regression in 6.6 kernel

2023-11-29 Thread Phillip Susi
Luben Tuikov writes: > I remember that the problem was really that amdgpu called > drm_sched_entity_init(), > in amdgpu_ttm_set_buffer_funcs_status() without actually having initialized > the scheduler > used therein. For instance, the code before commit b70438004a14f4, looked > like this: >

Re: [PATCH v2 1/1] drm/i915/pxp: Add missing tag for Wa_14019159160

2023-11-29 Thread Teres Alexis, Alan Previn
On Mon, 2023-11-27 at 15:24 -0500, Vivi, Rodrigo wrote: > On Wed, Nov 22, 2023 at 12:30:03PM -0800, Alan Previn wrote: alan:snip alan: thanks for reviewing and apologize for replying to this late. > > /* > > -* On MTL and newer platforms, protected contexts require setting > > -* the

Re: [PATCH 06/10] iommu: Replace iommu_device_lock with iommu_probe_device_lock

2023-11-29 Thread Jason Gunthorpe
On Wed, Nov 29, 2023 at 05:58:08PM +, Robin Murphy wrote: > On 29/11/2023 12:48 am, Jason Gunthorpe wrote: > > The iommu_device_lock protects the iommu_device_list which is only read by > > iommu_ops_from_fwnode(). > > > > This is now always called under the iommu_probe_device_lock, so we

[PATCH v2] drm/msm/dpu: Capture dpu snapshot when frame_done_timer timeouts

2023-11-29 Thread Paloma Arellano
Trigger a devcoredump to dump dpu registers and capture the drm atomic state when the frame_done_timer timeouts. Signed-off-by: Paloma Arellano --- Changes since v1: - Optimized the format in which frame_done_timeout_cnt is incremented --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 12

Re: [PATCH 10/10] ACPI: IORT: Allow COMPILE_TEST of IORT

2023-11-29 Thread Jason Gunthorpe
On Wed, Nov 29, 2023 at 01:55:04PM +0100, Lorenzo Pieralisi wrote: > I don't think it should be done this way. Is the goal compile testing > IORT code ? Yes > If so, why are we forcing it through the SMMU (only because > it can be compile tested while eg SMMUv3 driver can't ?) menu entry ?

Re: [PATCH 08/10] iommu/tegra: Use tegra_dev_iommu_get_stream_id() in the remaining places

2023-11-29 Thread Jason Gunthorpe
On Wed, Nov 29, 2023 at 05:23:13PM +0100, Thierry Reding wrote: > > diff --git a/drivers/memory/tegra/tegra186.c > > b/drivers/memory/tegra/tegra186.c > > index 533f85a4b2bdb7..3e4fbe94dd666e 100644 > > --- a/drivers/memory/tegra/tegra186.c > > +++ b/drivers/memory/tegra/tegra186.c > > @@ -111,21

[PATCH v1] drm/msm/dpu: improve DSC allocation

2023-11-29 Thread Kuogee Hsieh
A DCE (Display Compression Engine) contains two DSC hard slice encoders. Each DCE start with even DSC encoder index followed by an odd DSC encoder index. Each encoder can work independently. But Only two DSC encoders from same DCE can be paired to work together to support merge mode. In addition,

Re: [Linaro-mm-sig] Re: [PATCH] dma-buf: Correct the documentation of name and exp_name symbols

2023-11-29 Thread Alex Deucher
On Wed, Nov 22, 2023 at 1:58 PM Christian König wrote: > > Am 22.11.23 um 17:05 schrieb Ramesh Errabolu: > > Fix the documentation of struct dma_buf members name and exp_name > > as to how these members are to be used and accessed. > > > > Signed-off-by: Ramesh Errabolu > > Reviewed-by:

Re: [PATCH v18 04/26] drm/shmem-helper: Refactor locked/unlocked functions

2023-11-29 Thread Boris Brezillon
On Wed, 29 Nov 2023 14:09:47 +0100 Maxime Ripard wrote: > On Wed, Nov 29, 2023 at 08:53:30AM +0100, Boris Brezillon wrote: > > On Wed, 29 Nov 2023 01:05:14 +0300 > > Dmitry Osipenko wrote: > > > > > On 11/28/23 15:37, Boris Brezillon wrote: > > > > On Tue, 28 Nov 2023 12:14:42 +0100 > > >

Re: [PATCH v18 04/26] drm/shmem-helper: Refactor locked/unlocked functions

2023-11-29 Thread Maxime Ripard
On Wed, Nov 29, 2023 at 02:46:09PM +0100, Boris Brezillon wrote: > On Wed, 29 Nov 2023 14:09:47 +0100 > Maxime Ripard wrote: > > > On Wed, Nov 29, 2023 at 08:53:30AM +0100, Boris Brezillon wrote: > > > On Wed, 29 Nov 2023 01:05:14 +0300 > > > Dmitry Osipenko wrote: > > > > > > > On 11/28/23

Re: [PATCH v2] drm/i915: correct the input parameter on _intel_dsb_commit()

2023-11-29 Thread Jani Nikula
On Tue, 14 Nov 2023, heminhong wrote: > Current, the dewake_scanline variable is defined as unsigned int, > an unsigned int variable that is always greater than or equal to 0. > when _intel_dsb_commit function is called by intel_dsb_commit function, > the dewake_scanline variable may have an int

Re: [Intel-gfx] [PATCH v3 1/1] drm/i915/pxp: Add missing tag for Wa_14019159160

2023-11-29 Thread Teres Alexis, Alan Previn
On Tue, 2023-11-28 at 10:03 -0800, Roper, Matthew D wrote: > On Mon, Nov 27, 2023 at 12:11:50PM -0800, Alan Previn wrote: > > Add missing tag for "Wa_14019159160 - Case 2" (for existing > > PXP code that ensures run alone mode bit is set to allow > > PxP-decryption. alan:snip. alan: thanks for

[PATCH] drm/radeon/r100: Fix integer overflow issues in r100_cs_track_check()

2023-11-29 Thread Nikita Zhandarovich
It may be possible, albeit unlikely, to encounter integer overflow during the multiplication of several unsigned int variables, the result being assigned to a variable 'size' of wider type. Prevent this potential behaviour by converting one of the multiples to unsigned long. Found by Linux

[PATCH] drm/radeon/r600_cs: Fix possible int overflows in r600_cs_check_reg()

2023-11-29 Thread Nikita Zhandarovich
While improbable, there may be a chance of hitting integer overflow when the result of radeon_get_ib_value() gets shifted left. Avoid it by casting one of the operands to larger data type (u64). Found by Linux Verification Center (linuxtesting.org) with static analysis tool SVACE. Fixes:

Re: [PATCH] drm/panel: nt36523: fix return value check in nt36523_probe()

2023-11-29 Thread Neil Armstrong
Hi, On Wed, 29 Nov 2023 17:07:15 +0800, Yang Yingliang wrote: > mipi_dsi_device_register_full() never returns NULL pointer, it > will return ERR_PTR() when it fails, so replace the check with > IS_ERR(). > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git

Re: [PATCH 06/10] iommu: Replace iommu_device_lock with iommu_probe_device_lock

2023-11-29 Thread Robin Murphy
On 29/11/2023 12:48 am, Jason Gunthorpe wrote: The iommu_device_lock protects the iommu_device_list which is only read by iommu_ops_from_fwnode(). This is now always called under the iommu_probe_device_lock, so we don't need to double lock the linked list. Use the iommu_probe_device_lock on the

Re: [PATCH v4 05/45] drm/connector: Check drm_connector_init pointers arguments

2023-11-29 Thread Maxime Ripard
On Wed, Nov 29, 2023 at 01:40:38PM +0200, Jani Nikula wrote: > On Wed, 29 Nov 2023, Maxime Ripard wrote: > > On Wed, Nov 29, 2023 at 11:38:42AM +0200, Jani Nikula wrote: > >> On Wed, 29 Nov 2023, Maxime Ripard wrote: > >> > Hi Ville, > >> > > >> > On Tue, Nov 28, 2023 at 03:49:08PM +0200, Ville

About resuming in the remove callback

2023-11-29 Thread Uwe Kleine-König
Hello Laurent, On Wed, Nov 29, 2023 at 12:11:50PM +0200, Laurent Pinchart wrote: > On Wed, Nov 29, 2023 at 10:51:37AM +0100, Uwe Kleine-König wrote: > > On Wed, Nov 29, 2023 at 02:39:55AM +0200, Laurent Pinchart wrote: > > > On Thu, Nov 23, 2023 at 06:54:27PM +0100, Uwe Kleine-König wrote: > > >

[PATCH v1 1/1] drm/i915/display: Don't use "proxy" headers

2023-11-29 Thread Andy Shevchenko
The driver uses math.h and not util_macros.h. Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/i915/display/intel_snps_phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_snps_phy.c b/drivers/gpu/drm/i915/display/intel_snps_phy.c index

[PATCH 0/2] drm/tiny: Add driver for the sharp LS027B7DH01 Memory LCD

2023-11-29 Thread Mehdi Djait
This patch series adds a DRM driver for the sharp LS027B7DH01 memory display: a 2.7" 400x240 monochrome 1 bit per pixel display SPI device. This controller uses SPI both for control and for pixel data. Pixel data can be sent either as one line per SPI frame or multiple lines (up to the entire

[PATCH 1/2] dt-bindings: display: Add Sharp LS027B7DH01 Memory LCD

2023-11-29 Thread Mehdi Djait
Add device tree bindings for the Sharp LS027B7DH01: a 2.7" 400x240 monochrome display connected over SPI. Signed-off-by: Mehdi Djait --- .../bindings/display/sharp,ls027b7dh01.yaml | 71 +++ 1 file changed, 71 insertions(+) create mode 100644

[PATCH 2/2] drm/tiny: Add driver for the sharp LS027B7DH01 Memory LCD

2023-11-29 Thread Mehdi Djait
27b7dh01_fops); + +static const struct drm_driver sharp_ls027b7dh01_drm_driver = { + .driver_features= DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC, + .fops = _ls027b7dh01_fops, + DRM_GEM_DMA_DRIVER_OPS_VMAP, + .name = "sharp_ls027b7dh01&

Re: [PATCH] drm/radeon/r600_cs: Fix possible int overflows in r600_cs_check_reg()

2023-11-29 Thread Christian König
Am 29.11.23 um 16:22 schrieb Nikita Zhandarovich: While improbable, there may be a chance of hitting integer overflow when the result of radeon_get_ib_value() gets shifted left. Avoid it by casting one of the operands to larger data type (u64). Found by Linux Verification Center

Re: [PATCH v18 04/26] drm/shmem-helper: Refactor locked/unlocked functions

2023-11-29 Thread Boris Brezillon
On Wed, 29 Nov 2023 16:15:27 +0100 Maxime Ripard wrote: > > Now, let's assume we drop the _locked() suffix on > > drm_gem_shmem_v[un]map(), but keep it on other helpers that need both > > variants. This results in an inconsistent naming scheme inside the > > same source file, which I find

Re: [PATCH v2 RESEND] drm/panel: starry-2081101qfh032011-53g: Fine tune the panel power sequence

2023-11-29 Thread Neil Armstrong
Hi, On Wed, 29 Nov 2023 16:41:15 +0800, xiazhengqiao wrote: > For the "starry, 2081101qfh032011-53g" panel, it is stipulated in the > panel spec that MIPI needs to keep the LP11 state before the > lcm_reset pin is pulled high. > > Thanks, Applied to

[PATCH v2] backlight: mp3309c: fix uninitialized local variable

2023-11-29 Thread Flavio Suligoi
In the function "pm3309c_parse_dt_node", when the dimming analog control mode (by I2C messages) is enabled, the local variable "prop_levels" is tested without any initialization, as indicated by the following smatch warning: drivers/video/backlight/mp3309c.c:279 pm3309c_parse_dt_node() error:

Re: [PATCH v2 0/2] DSIPHY RPM

2023-11-29 Thread Konrad Dybcio
On 15.07.2023 17:25, Konrad Dybcio wrote: > On 11.07.2023 18:31, Dmitry Baryshkov wrote: >> On 11/07/2023 17:21, Dmitry Baryshkov wrote: >>> >>> On Tue, 20 Jun 2023 13:43:19 +0200, Konrad Dybcio wrote: Some recent SoCs use power rails that we model as GENPDs to power the DSIPHY. This

Re: [PATCH] drm/panel: nt36523: fix return value check in nt36523_probe()

2023-11-29 Thread neil . armstrong
On 29/11/2023 10:07, Yang Yingliang wrote: From: Yang Yingliang mipi_dsi_device_register_full() never returns NULL pointer, it will return ERR_PTR() when it fails, so replace the check with IS_ERR(). Fixes: 0993234a0045 ("drm/panel: Add driver for Novatek NT36523") Signed-off-by: Yang

[PATCH 0/4] fbdev: Remove global screen_info in efifb/vesafb

2023-11-29 Thread Thomas Zimmermann
Replace the global instance of screen_info with the per-device instance that is set by the sysfb code. The use of the global screen_info should be limited and ideally be pushed into per-architecture code. Thomas Zimmermann (4): fbdev/efifb: Replace references to global screen_info by local

Re: [PATCH v2] backlight: mp3309c: fix uninitialized local variable

2023-11-29 Thread Daniel Thompson
On Wed, Nov 29, 2023 at 05:45:14PM +0100, Flavio Suligoi wrote: > In the function "pm3309c_parse_dt_node", when the dimming analog control > mode (by I2C messages) is enabled, the local variable "prop_levels" is > tested without any initialization, as indicated by the following smatch > warning: >

Re: [PATCH v2 0/3] drm/panfrost: Fix poweroff and sync IRQs for suspend

2023-11-29 Thread Marek Szyprowski
On 28.11.2023 13:45, AngeloGioacchino Del Regno wrote: > This series contains a fast fix for the basic GPU poweroff functionality > and goes further by implementing interrupt masking and synchronization > before suspend. > > For more information, please look at the conversation at [1], which >

Re: 回复: [PATCH v2] drm/i915: correct the input parameter on _intel_dsb_commit()

2023-11-29 Thread Jani Nikula
On Wed, 29 Nov 2023, 何敏红 wrote: > Friendly ping. I think this patch was forgotten. Pushed, thanks for the patch. > > > > 主 题:[PATCH v2] drm/i915: correct the input parameter on _intel_dsb_commit() > 日 期:2023-11-14 10:43 > 发件人:何敏红 > 收件人:何敏红; > > Current, the dewake_scanline variable is

Re: [PATCH v6 06/10] drm: ci: mediatek: Set IGT_FORCE_DRIVER for mt8173

2023-11-29 Thread Daniel Stone
Hi Vignesh, On Wed, 29 Nov 2023 at 12:19, Vignesh Raman wrote: > Expected driver for mt8173 is "mediatek" and for mt8183 > it is "panfrost". Set IGT_FORCE_DRIVER to 'mediatek' as > the expected driver for mt8173. Actually, for mt8183 it's both. And for mt8173 it will probably be mediatek+pvr

Re: Radeon regression in 6.6 kernel

2023-11-29 Thread Alex Deucher
On Tue, Nov 28, 2023 at 11:45 PM Luben Tuikov wrote: > > On 2023-11-28 17:13, Alex Deucher wrote: > > On Mon, Nov 27, 2023 at 6:24 PM Phillip Susi wrote: > >> > >> Alex Deucher writes: > >> > In that case those are the already known problems with the scheduler > changes, aren't they?

Re: [PATCH] PCI: qcom: Fix compile error

2023-11-29 Thread Vignesh Raman
Hi Jani, On 28/11/23 18:33, Jani Nikula wrote: On Tue, 28 Nov 2023, Vignesh Raman wrote: On 28/11/23 12:21, Manivannan Sadhasivam wrote: On Tue, Nov 28, 2023 at 11:44:26AM +0530, Vignesh Raman wrote: Hi Mani, On 28/11/23 10:44, Manivannan Sadhasivam wrote: On Tue, Nov 28, 2023 at

Re: [RFC PATCH 0/6] Supporting GMEM (generalized memory management) for external memory devices

2023-11-29 Thread Christian König
Am 29.11.23 um 09:27 schrieb zhuweixi: Glad to hear that more sharable code is desirable. IMHO, for a common MM subsystem, it is more beneficial for GMEM to extend core MM instead of building a separate one. As stated in the beginning of my RFC letter, MM systems are large and similar. Even a

Re: Radeon regression in 6.6 kernel

2023-11-29 Thread Alex Deucher
On Wed, Nov 29, 2023 at 8:50 AM Alex Deucher wrote: > > On Tue, Nov 28, 2023 at 11:45 PM Luben Tuikov wrote: > > > > On 2023-11-28 17:13, Alex Deucher wrote: > > > On Mon, Nov 27, 2023 at 6:24 PM Phillip Susi wrote: > > >> > > >> Alex Deucher writes: > > >> > > In that case those are the

[PATCH 4/4] fbdev/vesafb: Use screen_info pointer from device

2023-11-29 Thread Thomas Zimmermann
Use the screen_info instance from the device instead of dereferencing the global screen_info state. Decouples the driver from per-architecture code. Duplicated the screen_info data, so that vesafb can modify it at will. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/vesafb.c | 9

Re: [PATCH 2/2] drm/tiny: Add driver for the sharp LS027B7DH01 Memory LCD

2023-11-29 Thread Paul Kocialkowski
.get_modes = sharp_ls027b7dh01_connector_get_modes, > +}; > + > +static const struct drm_connector_funcs sharp_ls027b7dh01_connector_funcs = { > + .reset = drm_atomic_helper_connector_reset, > + .fill_modes = drm_helper_probe_single_connector_modes, > + .destroy =

Re: [PATCH v1 1/1] drm/i915/display: Don't use "proxy" headers

2023-11-29 Thread Jani Nikula
On Wed, 29 Nov 2023, Andy Shevchenko wrote: > The driver uses math.h and not util_macros.h. > > Signed-off-by: Andy Shevchenko Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_snps_phy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[PATCH v8 5/7] drm/msm/dp: incorporate pm_runtime framework into DP driver

2023-11-29 Thread Kuogee Hsieh
Currently DP driver is executed independent of PM runtime framework. This leads msm eDP panel can not being detected by edp_panel driver during generic_edp_panel_probe() due to AUX DPCD read failed at edp panel driver. Incorporate PM runtime framework into DP driver so that host controller's power

[PATCH v8 1/7] drm/msm/dp: tie dp_display_irq_handler() with dp driver

2023-11-29 Thread Kuogee Hsieh
Currently the dp_display_request_irq() is executed at msm_dp_modeset_init() which ties irq registering to the DPU device's life cycle, while depending on resources that are released as the DP device is torn down. Move register DP driver irq handler to dp_display_probe() to have

[PATCH v8 0/7] incorporate pm runtime framework and eDP clean up

2023-11-29 Thread Kuogee Hsieh
The purpose of this patch series is to incorporate pm runtime framework into MSM eDP/DP driver so that eDP panel can be detected by DRM eDP panel driver during system probe time. During incorporating procedure, original customized pm realted fucntions, such as dp_pm_prepare(), dp_pm_suspend(),

  1   2   3   >