19.03.2015 14:56, One Thousand Gnomes wrote:
> On Thu, 19 Mar 2015 14:09:29 +0300
> Michael Tokarev wrote:
>
>> Half a year passed since my first email in this thread, and current kernels
>> (4.0-tobe) still does not work properly. Meanwhile, I found this thread:
>>
. :)
--
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20150319/fb9901bd/attachment-0001.html>
> Yes, with video=LVDS-1:d boot parameter, kernel boots fine and there is
> graphics/video output on the screen, with the following message from kernel
> when loading gma500_gfx:
>
> [6.472859] [drm] forcing LVDS-1 connector OFF
>
> (and a few others).
>
> There's one funky thing still --
https://bugzilla.kernel.org/show_bug.cgi?id=84981
--- Comment #6 from Apostolos B. ---
3.19.2 and this damn thing still happens. I am quite sure it is happening when
i play a video on youtube. (gstreamer)
Mar 19 21:28:47 mainland kernel: general protection fault: [#1] PREEMPT
SMP
Mar 19
On 19/03/15 17:42, Daniel Kurtz wrote:
> On Fri, Mar 6, 2015 at 4:52 PM, Daniel Kurtz wrote:
>> There is a rockchip drm kms driver.
>> Add "rockchip" to the static lists of driver names in the the standard
>> set of tests.
>>
>> Signed-off-by: Daniel Kurtz
>
> Ping?
>
> Can somebody please
On 03/19/2015 04:04 PM, Ville Syrjälä wrote:
> On Thu, Mar 19, 2015 at 03:33:11PM +0100, Daniel Vetter wrote:
>> On Wed, Mar 18, 2015 at 03:52:56PM +0100, Mario Kleiner wrote:
>>> On 03/18/2015 10:30 AM, Chris Wilson wrote:
On Wed, Mar 18, 2015 at 11:53:16AM +0900, Michel Dänzer wrote:
On 19/03/15 16:35, Damien Lespiau wrote:
> It seems that the tests don't need DRM master anymore? at least make
> distcheck passes when X is running.
>
> release.sh is also invoked with just the path to the libdrm git checkout
> and we don't want to pass additional arguments that will be treated
On Thu, Mar 19, 2015 at 05:32:28PM +, Emil Velikov wrote:
> On 19/03/15 16:35, Damien Lespiau wrote:
> > Signed-off-by: Damien Lespiau
> > ---
> > RELEASING | 12 ++--
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/RELEASING b/RELEASING
> > index
On 19/03/15 16:35, Damien Lespiau wrote:
> Signed-off-by: Damien Lespiau
> ---
> RELEASING | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/RELEASING b/RELEASING
> index e17dbea..8ed7490 100644
> --- a/RELEASING
> +++ b/RELEASING
> @@ -13,14 +13,14 @@ Follow
On Thu, Mar 19, 2015 at 05:11:08PM +, Neil Roberts wrote:
> The main incentive to do this is to get I915_PARAM_REVISION.
>
> v2: Rebase on top of some changes that were made to the header without
> copying the whole file from the kernel source.
>
> Signed-off-by: Neil Roberts
The main incentive to do this is to get I915_PARAM_REVISION.
v2: Rebase on top of some changes that were made to the header without
copying the whole file from the kernel source.
Signed-off-by: Neil Roberts
---
Here is a v2 of the patch just to rebase it on the changes that were
added
On Thu, Mar 19, 2015 at 03:33:11PM +0100, Daniel Vetter wrote:
> On Wed, Mar 18, 2015 at 03:52:56PM +0100, Mario Kleiner wrote:
> > On 03/18/2015 10:30 AM, Chris Wilson wrote:
> > >On Wed, Mar 18, 2015 at 11:53:16AM +0900, Michel Dänzer wrote:
> > >>drm_vblank_count_and_time() doesn't return the
That's the only type :set spell found.
Signed-off-by: Damien Lespiau
---
RELEASING | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/RELEASING b/RELEASING
index 8ed7490..78e90c0 100644
--- a/RELEASING
+++ b/RELEASING
@@ -51,7 +51,7 @@ Follow these steps to release a new
Signed-off-by: Damien Lespiau
---
RELEASING | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/RELEASING b/RELEASING
index e17dbea..8ed7490 100644
--- a/RELEASING
+++ b/RELEASING
@@ -13,14 +13,14 @@ Follow these steps to release a new version of libdrm:
It seems that the tests don't need DRM master anymore? at least make
distcheck passes when X is running.
release.sh is also invoked with just the path to the libdrm git checkout
and we don't want to pass additional arguments that will be treated as
additional modules we want to release.
Also,
Made a release with those instructions, they turned out to be slightly
outdated. Fix it for the next first-time person.
--
Damien
Damien Lespiau (3):
RELEASING: Fix releasing instructions to match the latest release.sh
RELEASING: Fix the step numbering
RELEASING: Fix annouce typo
Hello Dave,
This patch makes STI driver use the atomic helpers.
I have fix the comments done by Daniel on the first version and get
his ack with this second version.
Regards,
Benjamin
The following changes since commit 03be70050c85768e9ce7c0d0887110d1b629e127:
Merge tag
On Thu, Mar 19, 2015 at 12:20:57PM +0200, Jani Nikula wrote:
> On Thu, 19 Mar 2015, ville.syrjala at linux.intel.com wrote:
> > From: Ville Syrjälä
> >
> > AUX addresses are 20 bits long. Send out the entire address instead of
> > just the low 16 bits.
> >
> > Signed-off-by: Ville Syrjälä
>
On Thu, Mar 19, 2015 at 01:48:00PM +0200, Jani Nikula wrote:
> On Thu, 19 Mar 2015, ville.syrjala at linux.intel.com wrote:
> > From: Ville Syrjälä
> >
> > When doing a native or i2c aux write the sink will indicate the number
> > of bytes written even if it the nacks the transfer. When we
On Thu, Mar 19, 2015 at 01:46:40PM +0100, Benjamin Gaignard wrote:
> v1: This patch does the minimum to make sti driver use atomic helpers.
> No big bang, only adapt some functions to new call order.
>
> v2: Use dpms and page flip atomic helpers
>
> Signed-off-by: Benjamin Gaignard
Yeah atomic
On Thu, Mar 19, 2015 at 03:13:15PM +, Chris Wilson wrote:
> Pretty much an igt that compared the speed of just querying the hw
> counter vs querying with a regular vblank interrupt would be ideal for
> measuring the impact here.
ickle at crystalwell:/usr/src/intel-gpu-tools$ sudo
On Wed, Mar 18, 2015 at 03:52:56PM +0100, Mario Kleiner wrote:
> On 03/18/2015 10:30 AM, Chris Wilson wrote:
> >On Wed, Mar 18, 2015 at 11:53:16AM +0900, Michel Dänzer wrote:
> >>drm_vblank_count_and_time() doesn't return the correct sequence number
> >>while the vblank interrupt is disabled,
On Fri, Mar 13, 2015 at 05:44:17PM +0800, Jianwei Wang wrote:
> This patch add support for Two Dimensional Animation and Compositing
> Engine (2D-ACE) on Freescale SoCs.
>
> 2D-ACE is a Freescale display controller. It provide an hardware
> cursor.
>
> This is a simplified version, only a
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20150319/71cb080b/attachment.sig>
Hi Dave,
First radeon pull request for 4.1. Highlights:
- DP MST support (disabled by default)
- non-ATOM aux support (DCE5+)
- output csc support for clamped RGB
- Lots of new queries for profiling, Gallium HUD, etc.
- Misc fixes
The following changes since commit
On Thu, Mar 19, 2015 at 05:04:19PM +0200, Ville Syrjälä wrote:
> Is enabling the interrupts the expensive part, or is it the actual
> double timestamp read + scanout pos read? Or is it due to the several
> spinlocks we have in this code?
Chiefly it was the read during disable, then the
s mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20150319/3f696fd3/attachment-0001.html>
scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20150319/373f5448/attachment.html>
freedesktop.org/archives/dri-devel/attachments/20150319/e407ae58/attachment.html>
The Innolux AT043TN24 4.3" WQVGA TFT LCD panel.
This panel with backlight is found in PDA 4.3" LCD screen (TM43xx series for
instance).
Signed-off-by: Nicolas Ferre
---
.../bindings/panel/innolux,at043tn24.txt | 7 ++
drivers/gpu/drm/panel/panel-simple.c | 28
From: Boris BREZILLON
The Shelly SCA07010-BFN-LNN is a 7.0" WVGA TFT LCD panel.
This panel with backlight is found in PDA 7" LCD screen (TM70xx series for
instance).
Signed-off-by: Boris BREZILLON
Signed-off-by: Nicolas Ferre
---
19.03.2015 14:09, Michael Tokarev wrote:
> Half a year passed since my first email in this thread, and current kernels
Actually it was more than a year, since Feb-2014 ;)
> (4.0-tobe) still does not work properly. Meanwhile, I found this thread:
>
this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20150319/10b32fd3/attachment.html>
Half a year passed since my first email in this thread, and current kernels
(4.0-tobe) still does not work properly. Meanwhile, I found this thread:
http://www.linuxquestions.org/questions/slackware-installation-40/black-screen-on-intel-desktopboard-d2500cc-4175503983/
which seems to help. I
On Thu, 19 Mar 2015, ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä
>
> When doing a native or i2c aux write the sink will indicate the number
> of bytes written even if it the nacks the transfer. When we receive a
> nack we just return an error upwards, but it might still be
v1: This patch does the minimum to make sti driver use atomic helpers.
No big bang, only adapt some functions to new call order.
v2: Use dpms and page flip atomic helpers
Signed-off-by: Benjamin Gaignard
---
drivers/gpu/drm/sti/sti_drm_crtc.c | 175
From: Ville Syrjälä
When doing a native or i2c aux write the sink will indicate the number
of bytes written even if it the nacks the transfer. When we receive a
nack we just return an error upwards, but it might still be interesting
to see how many bytes made it
The psb_gtt_free_range() frees "backing" so calling it twice is a double
free bug. I have fixed this by removing the first call.
Fixes: 4d8d096e9ae8 ('gma500: introduce the framebuffer support code')
Signed-off-by: Dan Carpenter
diff --git a/drivers/gpu/drm/gma500/framebuffer.c
Hello Ben Skeggs,
The patch 4196faa86232: "drm/nouveau/i2c: port to subdev interfaces"
from Jul 10, 2012, leads to the following static checker warning:
drivers/gpu/drm/nouveau/nvkm/engine/disp/vga.c:41 nv_rdport()
warn: we tested 'port == 962' before and it was 'false'
On Thu, Mar 19, 2015 at 12:35 PM, Damien Lespiau
wrote:
> That's the only type :set spell found.
---^
But it didn't find this one :)
>
> Signed-off-by: Damien Lespiau
> ---
> RELEASING | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/RELEASING
Hi Dave,
The following changes since commit 6b94aea01d4f96235e947892f6c39f837045e741:
Merge branch 'drm_next' of https://github.com/markyzq/kernel-drm-rockchip
into drm-next (2015-03-19 14:05:53 +1000)
are available in the git repository at:
git://linuxtv.org/pinchartl/fbdev.git
From: Christian König
Date: Thu, 19 Mar 2015 09:50:58 +0100
> In general I would say yes, but for this particular hardware it's a
> bit questionable to do so.
>
> For radeon hardware to work correctly the CPU access to the PCIE BARs
> should work even without using
Hi Dave,
The following changes since commit 6b94aea01d4f96235e947892f6c39f837045e741:
Merge branch 'drm_next' of https://github.com/markyzq/kernel-drm-rockchip
into drm-next (2015-03-19 14:05:53 +1000)
are available in the git repository at:
git://linuxtv.org/pinchartl/fbdev.git
The Innolux ZJ070NA-01P is a 7.0" TFT LCD panel with an integrated LED
backlight unit.
This panel is used on the Technexion Toucan.
Signed-off-by: Michael Grzeschik
---
.../bindings/panel/innolux,zj070na-01p.txt | 7 ++
drivers/gpu/drm/panel/panel-simple.c | 26
On Thu, 19 Mar 2015, ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä
>
> When doing a native or i2c aux write the sink will indicate the number
> of bytes written even if it the nacks the transfer. When we receive a
> nack we just return an error upwards, but it might still be
On Thu, 19 Mar 2015, ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä
>
> AUX addresses are 20 bits long. Send out the entire address instead of
> just the low 16 bits.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/intel_dp.c | 5
On Thu, 2015-03-19 at 13:17 +0300, Dan Carpenter wrote:
> The psb_gtt_free_range() frees "backing" so calling it twice is a double
> free bug. I have fixed this by removing the first call.
>
> Fixes: 4d8d096e9ae8 ('gma500: introduce the framebuffer support code')
> Signed-off-by: Dan Carpenter
On Thu, 19 Mar 2015 14:09:29 +0300
Michael Tokarev wrote:
> Half a year passed since my first email in this thread, and current kernels
> (4.0-tobe) still does not work properly. Meanwhile, I found this thread:
>
From: Ville Syrjälä
AUX addresses are 20 bits long. Send out the entire address instead of
just the low 16 bits.
Cc: Alex Deucher
Cc: "Christian König"
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/radeon/atombios_dp.c | 5 +++--
1 file changed, 3
From: Ville Syrjälä
AUX addresses are 20 bits long. Send out the entire address instead of
just the low 16 bits.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_dp.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git
From: Ville Syrjälä
When doing a native or i2c aux write the sink will indicate the number
of bytes written even if it the nacks the transfer. When we receive a
nack we just return an error upwards, but it might still be interesting
to see how many bytes made it
From: Gustavo Padovan
Change the switch to use the pixel_format instead of bpp to figure out
if we need to enable or disable the layer blending.
Signed-off-by: Gustavo Padovan
---
drivers/gpu/drm/exynos/exynos_mixer.c | 29 +
1 file
From: Gustavo Padovan
'val' wasn't clean after its last usage, so we could get garbage value and
send the wrong command to the hw.
Signed-off-by: Gustavo Padovan
---
drivers/gpu/drm/exynos/exynos_mixer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Gustavo Padovan
exynos doesn't show scaled planes properly on the screen so
disable the feature and show a message to the user.
Signed-off-by: Gustavo Padovan
---
drivers/gpu/drm/exynos/exynos_mixer.c | 6 ++
1 file changed, 6 insertions(+)
diff
On Tue, Mar 17, 2015 at 05:22:08PM +0200, Jani Nikula wrote:
> On Fri, 13 Mar 2015, ville.syrjala at linux.intel.com wrote:
> > From: Ville Syrjälä
> >
> > When an i2c WRITE gets an i2c defer or short i2c ack reply, we are
> > supposed to switch the request from I2C_WRITE to
2015-03-19 10:06 GMT+08:00 Emil Velikov :
> On 18/03/15 16:38, Chih-Wei Huang wrote:
>> 2015-03-18 9:37 GMT+08:00 Emil Velikov :
>>> > On 18 March 2015 at 01:19, Chih-Wei Huang
>>> > wrote:
>>
>> I would suggest to remove all the use of LIBDRM_TOP.
>> Do you want me to submit a
Hi Dave -
Backporting a couple of plane related fixes from drm-next to v4.0.
BR,
Jani.
The following changes since commit 06e5801b8cb3fc057d88cb4dc03c0b64b2744cda:
Linux 4.0-rc4 (2015-03-15 17:38:20 -0700)
are available in the git repository at:
git://anongit.freedesktop.org/drm-intel
On 03/19/2015 02:18 AM, Hyungwon Hwang wrote:
> Dear Daniel,
>
> On Thu, 19 Mar 2015 01:13:21 +
> Daniel Stone wrote:
>
>> Hi Hyungwon,
>>
>> On 19 March 2015 at 01:02, Hyungwon Hwang
>>
>> wrote:
> + /*
> +* The input PLL clock for MIPI DSI in Exynos5433 seems
>
On 03/13/2015 01:24 PM, Arnd Bergmann wrote:
> On Thursday 12 March 2015 10:23:40 John Stultz wrote:
>> Convert the timestamping in the amdkfd driver to use
>> a timespec64 and 64bit time accessors.
>>
>> Cc: Arnd Bergmann
>> Cc: Oded Gabbay
>> Cc: David Airlie
>> Cc: dri-devel at
Hi Dave,
Please pull the following three bug fixes for -rc5:
- Fixing SDMA initialization when in non-HWS mode (debug mode)
- Memory leak fix when destroying kernel queue
- Fix number of available compute pipelines according to new firmware
Thanks,
Oded
The following changes since
On 03/19/2015 02:18 AM, Hyungwon Hwang wrote:
> Dear Daniel,
>
> On Thu, 19 Mar 2015 01:13:21 +
> Daniel Stone wrote:
>
>> Hi Hyungwon,
>>
>> On 19 March 2015 at 01:02, Hyungwon Hwang
>>
>> wrote:
> + /*
> +* The input PLL clock for MIPI DSI in Exynos5433 seems
Dear Daniel,
On Thu, 19 Mar 2015 01:13:21 +
Daniel Stone wrote:
> Hi Hyungwon,
>
> On 19 March 2015 at 01:02, Hyungwon Hwang
> wrote:
> >> > + /*
> >> > +* The input PLL clock for MIPI DSI in Exynos5433 seems
> >> > to be fixed
> >> > +* by OSC CLK.
> >> > +
Dear Daniel,
On Wed, 18 Mar 2015 09:52:33 +
Daniel Stone wrote:
> Hi,
>
> On 18 March 2015 at 08:16, Hyungwon Hwang
> wrote:
> > +#define REG(dsi, reg) ((dsi)->reg_base +
> > dsi->driver_data->regs[(reg)])
>
> This seems like a good change in general, but please split it up: it
> makes
In general I would say yes, but for this particular hardware it's a bit
questionable to do so.
For radeon hardware to work correctly the CPU access to the PCIE BARs
should work even without using the specialized IO macros/functions,
otherwise mapping VRAM CPU accessible isn't really possible.
Need to expand the check to handle short circuiting
if the selected state is the same as current state.
bug:
https://bugs.freedesktop.org/show_bug.cgi?id=87796
Signed-off-by: Alex Deucher
Cc: stable at vger.kernel.org
---
drivers/gpu/drm/radeon/radeon.h| 1 +
hould work well. The breakage
without that sounds like a kwin issue.
--
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20150319/8814bccf/attachment.html>
assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20150319/117d5575/attachment-0001.html>
s, i've checked it.
--
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20150319/bfe9d7ba/attachment.html>
CRTCs might have a NULL mode if they're being disabled.
Signed-off-by: Daniel Stone
---
drivers/gpu/drm/tegra/sor.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c
index d0eaa48..0f8aa2c 100644
---
Add an ioctl which allows users to create objects from arbitrary data.
Currently this only supports modes, creating a drm_display_mode from the
userspace drm_mode_modeinfo.
Signed-off-by: Daniel Stone
---
drivers/gpu/drm/drm_crtc.c | 166
All blob properties currently go on the device-global property list,
which is reaped at device exit. Make the addition to the list optional,
to allow for user properties whose lifetime will be tied to their
drm_file.
Signed-off-by: Daniel Stone
---
drivers/gpu/drm/drm_crtc.c | 13 -
Atomic modesetting: now with modesetting support.
Signed-off-by: Daniel Stone
---
drivers/gpu/drm/drm_atomic.c | 35 ++-
drivers/gpu/drm/drm_crtc.c | 7 +++
include/drm/drm_crtc.h | 1 +
3 files changed, 42 insertions(+), 1 deletion(-)
diff --git
Take a reference to existing modes, rather than duplicating them to
create new ones.
Signed-off-by: Daniel Stone
---
drivers/gpu/drm/i915/intel_atomic.c | 8 ++--
drivers/gpu/drm/tegra/dc.c | 11 ++-
2 files changed, 4 insertions(+), 15 deletions(-)
diff --git
Take a reference to existing modes, rather than duplicating them to
create new ones.
Signed-off-by: Daniel Stone
---
drivers/gpu/drm/drm_atomic_helper.c | 49 ++---
1 file changed, 24 insertions(+), 25 deletions(-)
diff --git
Take a reference to existing modes, rather than duplicating them to
create new ones.
Signed-off-by: Daniel Stone
---
drivers/gpu/drm/drm_crtc_helper.c | 43 ---
1 file changed, 17 insertions(+), 26 deletions(-)
diff --git a/drivers/gpu/drm/drm_crtc_helper.c
Take a reference to existing modes, rather than duplicating them to
create new ones.
Signed-off-by: Daniel Stone
---
drivers/gpu/drm/drm_fb_helper.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/drm_fb_helper.c
Does what it says on the box.
Signed-off-by: Daniel Stone
---
drivers/gpu/drm/drm_crtc.c | 13 +
drivers/gpu/drm/drm_modes.c | 8
include/drm/drm_modes.h | 1 +
3 files changed, 22 insertions(+)
diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
In order to expose modes to users, we need to be able to reason about
their lifetimes. As we currently treat modes as just a bucket of bits to
be shovelled around, we can't do that: reference counting them enables
us to sensibly deal with their lifetimes, to provide useful guarantees
to userspace.
Before, we would set the property, but also return -EINVAL because of a
broken fallthrough.
Signed-off-by: Daniel Stone
---
drivers/gpu/drm/drm_atomic.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
index
Active was here, and we allowed users to set it, but not to get it as
well.
Signed-off-by: Daniel Stone
---
drivers/gpu/drm/drm_atomic.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
index
Overload the getblob ioctl to allow passing in a mode ID, which will
return the userspace representation (drm_mode_modeinfo) of that mode.
Signed-off-by: Daniel Stone
---
drivers/gpu/drm/drm_crtc.c | 26 --
include/drm/drm_crtc.h | 8
2 files changed, 28
Instead of generating a new usermode every time we need to copy a mode
back to userspace, just use the cached one we already have.
Signed-off-by: Daniel Stone
---
drivers/gpu/drm/drm_crtc.c | 15 +--
drivers/gpu/drm/drm_modes.c | 4 ++--
include/drm/drm_modes.h | 2 --
3
For every mode which may be visible to userspace - either current on a
CRTC as a result of setcrtc, or advertised through the connector's mode
list - cache the drm_mode_modeinfo representation to send back to
userspace.
Signed-off-by: Daniel Stone
---
drivers/gpu/drm/drm_modes.c | 2 ++
This will become useful for us in generic mode-handling code later.
Signed-off-by: Daniel Stone
---
drivers/gpu/drm/drm_crtc.c | 44 +++-
drivers/gpu/drm/drm_modes.c | 36
include/drm/drm_modes.h | 2 ++
3 files
Signed-off-by: Daniel Stone
---
drivers/gpu/drm/drm_crtc.c | 51 ---
drivers/gpu/drm/drm_modes.c | 53 +
include/drm/drm_modes.h | 2 ++
3 files changed, 55 insertions(+), 51 deletions(-)
diff --git
Change drm_crtc_convert_umode into a helper which creates a new mode
object and also performs validation.
Signed-off-by: Daniel Stone
---
drivers/gpu/drm/drm_crtc.c | 40 +---
1 file changed, 21 insertions(+), 19 deletions(-)
diff --git
Make it really very clear that you shouldn't be changing this.
XXX: This currently breaks for core helpers who don't have a separate
non-const copy stashed, in order to change refs.
Signed-off-by: Daniel Stone
---
drivers/gpu/drm/nouveau/dispnv04/tvmodesnv17.c | 4 ++--
Holding a pointer to the mode, rather than an embed, allows us to get
towards sharing refcounted modes.
XXX: split into two - drm_mode_copy changes first, then the others
Signed-off-by: Daniel Stone
---
drivers/gpu/drm/armada/armada_overlay.c| 4 +--
drivers/gpu/drm/ast/ast_mode.c
Holding a pointer to the mode, rather than an embed, allows us to get
towards sharing refcounted modes.
XXX: atomic_destroy_state does _not_ seem to be optional - so we should
remove any fallback paths which compensate for its lack!
the crtc_state->mode handling is particularly ugly
Enforce the existing rules on when modes can be modified (never modify
the passed-in mode; only modify adjusted_mode in mode_fixup), by
adding const.
This requires duplicating the existing crtc_info->modeset->mode member
in the fb_helper, to keep a non-const version to free later.
Signed-off-by:
Enforce the existing rules on when modes can be modified (never modify
the passed-in mode; only modify adjusted_mode in mode_fixup), by
adding const.
Signed-off-by: Daniel Stone
---
drivers/gpu/drm/armada/armada_crtc.c | 3 ++-
drivers/gpu/drm/ast/ast_mode.c | 31
Enforce the existing rules on when modes can be modified (never modify
the passed-in mode; only modify adjusted_mode in mode_fixup), by
adding const.
This removes the interim mode_set helper functions introduced in tilcdc
and armada during the encoder-slave mode_set constification, as the
encoder
Enforce the existing rules on when modes can be modified (never modify
the passed-in mode; only modify adjusted_mode in mode_fixup), by
adding const.
Signed-off-by: Daniel Stone
---
drivers/gpu/drm/armada/armada_output.c | 2 +-
drivers/gpu/drm/armada/armada_output.h |
Enforce the existing rules on when modes can be modified (never modify
the passed-in mode; only modify adjusted_mode in mode_fixup), by
adding const.
tilcdc gains an interim helper function, as it registers an encoder
mode_set (as yet non-const), which directly calls the slave helper
(newly
Enforce the existing rules on when modes can be modified (never modify
the passed-in mode; only modify adjusted_mode in mode_fixup), by
adding const.
Signed-off-by: Daniel Stone
---
drivers/gpu/drm/bridge/dw_hdmi.c | 7 ---
drivers/gpu/drm/msm/edp/edp_bridge.c | 4 ++--
crtc->hwmode contains the adjusted_mode from mode_set; no reason to
overwrite crtc->mode (the user-specified mode) with this anymore.
Signed-off-by: Daniel Stone
---
drivers/gpu/drm/armada/armada_crtc.c | 18 --
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git
Further to the previous commit, instead of performing mode adjustment
inside a getter function called from mode_set, actually perform it in
mode_fixup instead. This allows us to drop the extra mode argument and
constify our original mode.
Signed-off-by: Daniel Stone
---
Split the register-setting component of ast_get_vbios_mode_info into a
separate function.
Signed-off-by: Daniel Stone
---
drivers/gpu/drm/ast/ast_drv.h | 1 +
drivers/gpu/drm/ast/ast_mode.c | 70 +-
2 files changed, 43 insertions(+), 28 deletions(-)
crtc->hwmode contains the adjusted_mode from mode_set; no reason to
overwrite crtc->mode (the user-specified mode) with this anymore. This
mode can also be const, since we don't modify it anywhere.
Signed-off-by: Daniel Stone
---
drivers/gpu/drm/sti/sti_cursor.c| 4 ++--
There's no need to copy adjusted_mode into crtc->mode, because that's
already what crtc->hwmode is. Use that consistently instead.
Signed-off-by: Daniel Stone
---
drivers/gpu/drm/exynos/exynos7_drm_decon.c | 4 ++--
drivers/gpu/drm/exynos/exynos_drm_crtc.c | 6 --
1 - 100 of 115 matches
Mail list logo