Re: [PATCH v2] drm/hisilicon: fix build error without fbdev emulation

2017-07-25 Thread Daniel Vetter
On Tue, Jul 25, 2017 at 8:05 PM, Arnd Bergmann wrote: > We cannot reference priv->fbdev outside of the #ifdef: > > drivers/net/virtio_net.c:1881:12: error: 'virtnet_restore_up' defined but not > used [-Werror=unused-function] > static int virtnet_restore_up(struct virtio_device

Re: [PATCH v5 1/7] drm/rockchip: vop: initialize registers directly

2017-07-25 Thread Mark yao
On 2017年07月26日 06:36, Heiko Stuebner wrote: Hi Mark, Am Donnerstag, 20. Juli 2017, 10:43:22 CEST schrieb Mark Yao: At present we are using init_table to initialize some registers, but the Register init table use un-document define, it is unreadable, and sometimes we only want to update tiny

Re: [Intel-gfx] [PATCH 6/8] drm: Nuke drm_atomic_helper_connector_set_property

2017-07-25 Thread Maarten Lankhorst
Op 25-07-17 om 10:01 schreef Daniel Vetter: > It's dead code, the core handles all this directly now. This also > allows us to unexport drm_atomic_helper_connector_set_property. > > The only special case is nouveau which used one function for both > pre-nv50 legacy modeset code and post-nv50

[PATCH] drm/amd/powerplay: rv: Use designated initializers

2017-07-25 Thread Kees Cook
As done for vega10 in commit 3ddd396f6b57 ("drm/amd/powerplay: Use designated initializers") mark other tableFunction entries with designated initializers. The randstruct plugin requires designated initializers for structures that are entirely function pointers. Cc: Rex Zhu Cc:

[RESEND PATCH v2 2/2] drm/exynos/decon: Add include guard to the Exynos7 header

2017-07-25 Thread Krzysztof Kozlowski
Although header is included only once but still having an include guard is a good practice. To avoid confusion, add SoC prefix to existing Exynos5433 header include guard. Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. Just re-order patches in patchset and

Re: iMac 10,1 with Ubuntu 16.04: black screen after suspend

2017-07-25 Thread Florian Echtler
On 25.07.2017 07:14, Mario Kleiner wrote: > On 07/24/2017 03:45 PM, Florian Echtler wrote: > > That's the same here with my patch applied. After a suspend -> resume, the > internal panel stays black, the patch doesn't help for that. Somethig i didn't > notice btw., apparently i never

[RESEND PATCH v2 1/2] drm/exynos/decon: Move headers from global to local place

2017-07-25 Thread Krzysztof Kozlowski
The DECON headers contain only defines for registers. There are no other drivers using them so this should be put locally to the Exynos DRM driver. Keeping headers local helps managing the code. Suggested-by: Marek Szyprowski Signed-off-by: Krzysztof Kozlowski

Re: [PATCH v5 1/7] drm/rockchip: vop: initialize registers directly

2017-07-25 Thread Heiko Stuebner
Hi Mark, Am Donnerstag, 20. Juli 2017, 10:43:22 CEST schrieb Mark Yao: > At present we are using init_table to initialize some > registers, but the Register init table use un-document define, > it is unreadable, and sometimes we only want to update tiny > bits, init table method is not friendly,

Re: [PATCH v5 3/7] drm/rockchip: vop: move line_flag_num to interrupt registers

2017-07-25 Thread Heiko Stuebner
Hi Mark, Am Donnerstag, 20. Juli 2017, 10:43:32 CEST schrieb Mark Yao: > In the hardware design process, the design of line flags > register is associated with the interrupt register, > placing the line flags in the interrupt definition is > more reasonable, and it would make multi-vop define

Re: [PATCH v5 2/7] drm/rockchip: vop: move write_relaxed flags to vop register

2017-07-25 Thread Heiko Stuebner
Hi Mark, Am Donnerstag, 20. Juli 2017, 10:43:27 CEST schrieb Mark Yao: > Since the drm atomic framework, only a small part of the vop > register needs sync write, Currently seems only following registers > need sync write: >cfg_done, standby and interrupt related register. > > All ctrl

Re: [PATCH 1/3] drm: Widen vblank count to 64 bits. Change vblank time precision to ns

2017-07-25 Thread Keith Packard
Daniel Vetter writes: > I'd drop that part (but keep 64 everywhere else ofc). Yeah, we only ever ask drivers for a delta anyways, so keeping an internal 64-bit value while retaining the 32-bit driver API is easy to manage. >> > Other thought on this, since you bother to change

[Bug 99136] Blood Effects corrupt graphics in Total War: Warhammer

2017-07-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99136 Marek Olšák changed: What|Removed |Added Resolution|--- |INVALID

[Bug 101900] No HDMI HBR audio on Polaris (no TrueHD, no Atmos, no Neo:X, no HD Master audio)

2017-07-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101900 Direx changed: What|Removed |Added Summary|No HDMI audio on Polaris|No HDMI HBR audio on

Re: [PATCH] vc4: Add an ioctl for labeling GEM BOs for summary stats

2017-07-25 Thread Eric Anholt
Chris Wilson writes: > Quoting Eric Anholt (2017-06-22 21:50:54) >> This has proven immensely useful for debugging memory leaks and >> overallocation (which is a rather serious concern on the platform, >> given that we typically run at about 256MB of CMA out of up to

[PATCH v2 2/3] drm/vc4: Add an ioctl for labeling GEM BOs for summary stats

2017-07-25 Thread Eric Anholt
This has proven immensely useful for debugging memory leaks and overallocation (which is a rather serious concern on the platform, given that we typically run at about 256MB of CMA out of up to 1GB total memory, with framebuffers that are about 8MB ecah). The state of the art without this is to

[PATCH v2 1/3] drm/vc4: Start using u64_to_user_ptr.

2017-07-25 Thread Eric Anholt
Chris Wilson pointed out this little cleanup in a review of new code, so let's fix up the code I was copying from. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_gem.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git

[PATCH v2 3/3] drm/vc4: Convert more lock requirement comments to lockdep assertions.

2017-07-25 Thread Eric Anholt
Since I do my development with lockdep on, this will help make sure I don't introduce bugs here. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_bo.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_bo.c

[PATCH v2] drm/hisilicon: fix build error without fbdev emulation

2017-07-25 Thread Arnd Bergmann
We cannot reference priv->fbdev outside of the #ifdef: drivers/net/virtio_net.c:1881:12: error: 'virtnet_restore_up' defined but not used [-Werror=unused-function] static int virtnet_restore_up(struct virtio_device *vdev) drivers/net/virtio_net.c:1859:13: error: 'virtnet_freeze_down' defined

Re: [PATCH] drm/hisilicon: fix build error without fbdev emulation

2017-07-25 Thread Arnd Bergmann
On Tue, Jul 25, 2017 at 5:53 PM, Daniel Vetter wrote: > On Tue, Jul 25, 2017 at 05:33:25PM +0200, Arnd Bergmann wrote: >> drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 5 - >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git

Re: [PATCH] vc4: Add an ioctl for labeling GEM BOs for summary stats

2017-07-25 Thread Chris Wilson
Quoting Eric Anholt (2017-06-22 21:50:54) > This has proven immensely useful for debugging memory leaks and > overallocation (which is a rather serious concern on the platform, > given that we typically run at about 256MB of CMA out of up to 1GB > total memory, with framebuffers that are about 8MB

Re: [PATCH] drm/stm: fix warning about multiplication in condition

2017-07-25 Thread Philippe CORNU
On 07/25/2017 05:40 PM, Arnd Bergmann wrote: > gcc-7 complains about multiplying within a condition being > suspicious: > > drivers/gpu/drm/stm/dw_mipi_dsi-stm.c: In function 'dsi_pll_get_clkout_khz': > drivers/gpu/drm/stm/dw_mipi_dsi-stm.c:117:10: error: '*' in boolean context, > suggest '&&'

Re: [PATCH] vc4: Add an ioctl for labeling GEM BOs for summary stats

2017-07-25 Thread Eric Anholt
Eric Anholt writes: > This has proven immensely useful for debugging memory leaks and > overallocation (which is a rather serious concern on the platform, > given that we typically run at about 256MB of CMA out of up to 1GB > total memory, with framebuffers that are about 8MB

[PATCH 1/2] drm/vc4: Demote user-accessible DRM_ERROR paths to DRM_DEBUG.

2017-07-25 Thread Eric Anholt
Userspace shouldn't be able to spam dmesg by passing bad arguments. This has particularly become an issues since we started using a bad argument to set_tiling to detect if set_tiling was supported. Signed-off-by: Eric Anholt Fixes: 83753117f1de ("drm/vc4: Add get/set tiling

[PATCH 2/2] drm/vc4: Add exec flags to allow forcing a specific X/Y tile walk order.

2017-07-25 Thread Eric Anholt
This is useful to allow GL to provide defined results for overlapping glBlitFramebuffer, which X11 in turn uses to accelerate uncomposited window movement without first blitting to a temporary. x11perf -copywinwin100 goes from 1850/sec to 4850/sec. Signed-off-by: Eric Anholt

Re: [PATCH] drm/hisilicon: fix build error without fbdev emulation

2017-07-25 Thread Daniel Vetter
On Tue, Jul 25, 2017 at 05:33:25PM +0200, Arnd Bergmann wrote: > We cannot reference priv->fbdev outside of the #ifdef: > > drivers/net/virtio_net.c:1881:12: error: 'virtnet_restore_up' defined but not > used [-Werror=unused-function] > static int virtnet_restore_up(struct virtio_device *vdev)

Re: [PATCH] drm/stm: fix warning about multiplication in condition

2017-07-25 Thread Joe Perches
On Tue, 2017-07-25 at 17:40 +0200, Arnd Bergmann wrote: > gcc-7 complains about multiplying within a condition being > suspicious: > > drivers/gpu/drm/stm/dw_mipi_dsi-stm.c: In function 'dsi_pll_get_clkout_khz': > drivers/gpu/drm/stm/dw_mipi_dsi-stm.c:117:10: error: '*' in boolean context, >

Re: [PATCH 1/2] drm/edid: Add helper to detect whether EDID changed

2017-07-25 Thread Daniel Vetter
On Tue, Jul 25, 2017 at 03:18:04PM +0300, Paul Kocialkowski wrote: > On Tue, 2017-07-25 at 10:16 +0200, Daniel Vetter wrote: > > On Tue, Jul 25, 2017 at 10:58:55AM +0300, Paul Kocialkowski wrote: > > > On Tue, 2017-07-25 at 09:34 +0200, Daniel Vetter wrote: > > > > On Tue, Jul 25, 2017 at 9:25 AM,

Re: [PATCH] drm/etnaviv: Fix off-by-one error in reloc checking

2017-07-25 Thread Philipp Zabel
On Tue, 2017-07-25 at 14:33 +0200, Wladimir J. van der Laan wrote: > A relocation pointing to the last four bytes of a buffer can > legitimately happen in the case of small vertex buffers. > > Signed-off-by: Wladimir J. van der Laan > --- >

Re: [PATCH] drm/amdgpu: fix spelling mistake: "suuport"-> "support"

2017-07-25 Thread Alex Deucher
On Tue, Jul 25, 2017 at 4:40 AM, Christian König wrote: > Am 25.07.2017 um 00:45 schrieb Colin King: >> >> From: Colin Ian King >> >> Trivial fix to spelling mistake in WARN_ONCE message >> >> Signed-off-by: Colin Ian King

[PATCH] drm/stm: fix warning about multiplication in condition

2017-07-25 Thread Arnd Bergmann
gcc-7 complains about multiplying within a condition being suspicious: drivers/gpu/drm/stm/dw_mipi_dsi-stm.c: In function 'dsi_pll_get_clkout_khz': drivers/gpu/drm/stm/dw_mipi_dsi-stm.c:117:10: error: '*' in boolean context, suggest '&&' instead [-Werror=int-in-bool-context] The code here is

[PATCH] drm/hisilicon: fix build error without fbdev emulation

2017-07-25 Thread Arnd Bergmann
We cannot reference priv->fbdev outside of the #ifdef: drivers/net/virtio_net.c:1881:12: error: 'virtnet_restore_up' defined but not used [-Werror=unused-function] static int virtnet_restore_up(struct virtio_device *vdev) drivers/net/virtio_net.c:1859:13: error: 'virtnet_freeze_down' defined

Re: [PATCH 7/8] drm: Nuke drm_atomic_helper_connector_dpms

2017-07-25 Thread Shawn Guo
On Tue, Jul 25, 2017 at 10:01:21AM +0200, Daniel Vetter wrote: > It's dead code, the core handles all this directly now. > > The only special case is nouveau and tda988x which used one function > for both legacy modeset code and -nv50 atomic world instead of 2 > vtables. But amounts to exactly

[Bug 101656] Invalid signal timestamps with EGL_SYNC_NATIVE_FENCE_ANDROID on android

2017-07-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101656 Yogesh Marathe changed: What|Removed |Added Status|NEW |RESOLVED

Re: [PATCH 20/41] drm/zte: Use .dumb_map_offset and .dumb_destroy defaults

2017-07-25 Thread Shawn Guo
On Sun, Jul 23, 2017 at 09:16:36PM +0200, Noralf Trønnes wrote: > This driver can use the drm_driver.dumb_destroy and > drm_driver.dumb_map_offset defaults, so no need to set them. > > Cc: Shawn Guo Acked-by: Shawn Guo > Signed-off-by: Noralf Trønnes

Re: [PATCH 7/8] drm: Nuke drm_atomic_helper_connector_dpms

2017-07-25 Thread Laurent Pinchart
Hi Daniel, Thank you for the patch. On Tuesday 25 Jul 2017 10:01:21 Daniel Vetter wrote: > It's dead code, the core handles all this directly now. > > The only special case is nouveau and tda988x which used one function > for both legacy modeset code and -nv50 atomic world instead of 2 >

[PATCH] dma-buf: fix reservation_object_wait_timeout_rcu to wait correctly v2

2017-07-25 Thread Christian König
From: Christian König With hardware resets in mind it is possible that all shared fences are signaled, but the exlusive isn't. Fix waiting for everything in this situation. v2: make sure we always wait for the exclusive fence Signed-off-by: Christian König

[Bug 101900] No HDMI audio on Polaris

2017-07-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101900 --- Comment #2 from Harry Wentland --- Does this patch fix your issue? https://patchwork.freedesktop.org/patch/168445/ -- You are receiving this mail because: You are the assignee for the

[Bug 194761] amdgpu driver breaks on Oland (SI)

2017-07-25 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=194761 --- Comment #73 from siyia (eutychio...@gmail.com) --- Any further news about this issue?Why dont you just use the p4 config for the afflicted cards as a fix? -- You are receiving this mail because: You are watching the assignee of the bug.

Re: [RFC v3] drm/hdcp: drm enum property for CP State

2017-07-25 Thread Sean Paul
On Mon, Jul 24, 2017 at 2:12 PM, Ramalingam C wrote: > DRM connector property is created to represent the content protection > state of the connector and to configure the same. > > Content protection states defined: > DRM_MODE_CONTENT_PROTECTION_UNSUPPORTED

[PATCH] drm/etnaviv: Fix off-by-one error in reloc checking

2017-07-25 Thread Wladimir J. van der Laan
A relocation pointing to the last four bytes of a buffer can legitimately happen in the case of small vertex buffers. Signed-off-by: Wladimir J. van der Laan --- drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Bug 98146] DRI_PRIME=1 and fullscreen issues

2017-07-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98146 Darek Deoniziak changed: What|Removed |Added Resolution|--- |FIXED

[drm-intel:for-linux-next 4/4] drivers/gpu/drm/i915/selftests/intel_hangcheck.c:845:3: error: too few arguments to function 'i915_reset'

2017-07-25 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm-intel for-linux-next head: af2788925ae0b83737ee847c5b2e9f19c5bf3630 commit: af2788925ae0b83737ee847c5b2e9f19c5bf3630 [4/4] drm/i915: Squelch reset messages during selftests config: i386-randconfig-x013-201730 (attached as .config) compiler: gcc-6

Re: [PATCH 1/2] drm/edid: Add helper to detect whether EDID changed

2017-07-25 Thread Paul Kocialkowski
On Tue, 2017-07-25 at 10:16 +0200, Daniel Vetter wrote: > On Tue, Jul 25, 2017 at 10:58:55AM +0300, Paul Kocialkowski wrote: > > On Tue, 2017-07-25 at 09:34 +0200, Daniel Vetter wrote: > > > On Tue, Jul 25, 2017 at 9:25 AM, Paul Kocialkowski > > > wrote: > > > >

Re: [PATCH] dma-buf: fix reservation_object_wait_timeout_rcu to wait correctly

2017-07-25 Thread Daniel Vetter
On Tue, Jul 25, 2017 at 11:11:35AM +0200, Christian König wrote: > Am 24.07.2017 um 13:57 schrieb Daniel Vetter: > > On Mon, Jul 24, 2017 at 11:51 AM, Christian König > > wrote: > > > Am 24.07.2017 um 10:33 schrieb Daniel Vetter: > > > > On Fri, Jul 21, 2017 at 06:20:01PM

[PATCH] drm: Don't update property values for atomic drivers

2017-07-25 Thread Daniel Vetter
Atomic drivers only use the property value store for immutable (i.e. can't be set by userspace, but the kernel can still adjust it) properties. The only tricky part is the removal of the update in drm_atomic_helper_update_legacy_modeset_state(). This was added in commit

[PATCH] drm: Handle properties in the core for atomic drivers

2017-07-25 Thread Daniel Vetter
The reason behind the original indirection through the helper functions was to allow existing drivers to overwrite how they handle properties. For example when a vendor-specific userspace had expectations that didn't match atomic. That seemed likely, since atomic is standardizing a _lot_ more of

[Bug 195295] USB device insertion turns on discrete Radeon GPU

2017-07-25 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=195295 Eugene Shalygin (eugene.shaly...@gmail.com) changed: What|Removed |Added Status|NEW |RESOLVED

Re: [PATCH] [RESEND] gpu: ipu-v3: add DRM dependency

2017-07-25 Thread Arnd Bergmann
On Tue, Jul 25, 2017 at 1:52 PM, Philipp Zabel wrote: > On Tue, 2017-07-25 at 13:35 +0200, Arnd Bergmann wrote: >> On Tue, Jul 25, 2017 at 10:03 AM, Philipp Zabel >> wrote: >> > On Tue, 2017-07-25 at 09:33 +0200, Arnd Bergmann wrote: >> >> On Mon,

Re: [PATCH] drm: tegra: add CONFIG_OF dependency

2017-07-25 Thread Arnd Bergmann
On Tue, Jul 25, 2017 at 10:25 AM, Jon Hunter wrote: > > On 21/07/17 17:13, Arnd Bergmann wrote: >> Without CONFIG_OF, we can run into a build error: >> >> drivers/gpu/drm/tegra/dpaux.c:378:20: error: >> 'pinconf_generic_dt_node_to_map_group' undeclared here (not in a

Re: [PATCH] [RESEND] gpu: ipu-v3: add DRM dependency

2017-07-25 Thread Philipp Zabel
On Tue, 2017-07-25 at 13:35 +0200, Arnd Bergmann wrote: > On Tue, Jul 25, 2017 at 10:03 AM, Philipp Zabel > wrote: > > On Tue, 2017-07-25 at 09:33 +0200, Arnd Bergmann wrote: > >> On Mon, Jul 24, 2017 at 10:05 AM, Philipp Zabel > >> wrote: > >> >

Re: [PATCH] drm/udl: Make page_flip asynchronous

2017-07-25 Thread Chris Wilson
Quoting Dawid Kurek (2017-07-07 06:48:49) > In page_flip vblank is sent with no delay. Driver does not know when the > actual update is present on the display and has no means for getting > this information from a device. It is practically impossible to say > exactly *when* as there is also i.e. a

Re: [PATCH] [RESEND] gpu: ipu-v3: add DRM dependency

2017-07-25 Thread Arnd Bergmann
On Tue, Jul 25, 2017 at 10:03 AM, Philipp Zabel wrote: > On Tue, 2017-07-25 at 09:33 +0200, Arnd Bergmann wrote: >> On Mon, Jul 24, 2017 at 10:05 AM, Philipp Zabel >> wrote: >> > On Fri, 2017-07-21 at 22:56 +0200, Arnd Bergmann wrote: >> If you

Re: iMac 10,1 with Ubuntu 16.04: black screen after suspend

2017-07-25 Thread Lukas Wunner
On Tue, Jul 25, 2017 at 07:14:23AM +0200, Mario Kleiner wrote: > On 07/24/2017 03:45 PM, Florian Echtler wrote: > > thanks for the hint. I've applied this patch to the v4.12 tree I'm > > currently running, and it didn't seem to make any difference (i.e. > > display stays black after suspend). > >

Re: [PATCH v2 2/7] drm/atomic: Clean up drm_atomic_helper_async_check

2017-07-25 Thread Maarten Lankhorst
Op 25-07-17 om 11:27 schreef Daniel Vetter: > On Tue, Jul 25, 2017 at 11:11 AM, Maarten Lankhorst > wrote: >> Op 25-07-17 om 10:23 schreef Daniel Vetter: >>> On Wed, Jul 19, 2017 at 04:39:15PM +0200, Maarten Lankhorst wrote: /* - * Don't do an

Re: [PATCH 0/4] [v2] Blobifiers (FKA GET_PLANE2)

2017-07-25 Thread Philippe CORNU
On 07/24/2017 05:46 AM, Ben Widawsky wrote: > Second attempt (although most patches are much further along than that) and > the > blob property for modifiers. > > This small series adds the DRM blob property that allows clients to be made > aware of per plane modifiers and the formats which

Re: [PATCH 7/8] drm: Nuke drm_atomic_helper_connector_dpms

2017-07-25 Thread Philippe CORNU
On 07/25/2017 10:01 AM, Daniel Vetter wrote: > It's dead code, the core handles all this directly now. > > The only special case is nouveau and tda988x which used one function > for both legacy modeset code and -nv50 atomic world instead of 2 > vtables. But amounts to exactly the same. > > v2:

Re: [PATCH 4/8] drm: Nuke drm_atomic_helper_crtc_set_property

2017-07-25 Thread Philippe CORNU
On 07/25/2017 10:01 AM, Daniel Vetter wrote: > It's dead code because this is now handled in the core. > > Signed-off-by: Daniel Vetter > Cc: Boris Brezillon > Cc: Daniel Vetter > Cc: Jani Nikula

Re: [PATCH 5/8] drm: Nuke drm_atomic_helper_plane_set_property

2017-07-25 Thread Philippe CORNU
On 07/25/2017 10:01 AM, Daniel Vetter wrote: > It's dead code, the core handles all this directly now. This also > allows us to unexport drm_atomic_helper_plane_set_property. > > Signed-off-by: Daniel Vetter > Cc: Liviu Dudau > Cc: Brian Starkey

Re: [PATCH 5/8] drm: Nuke drm_atomic_helper_plane_set_property

2017-07-25 Thread Archit Taneja
On 07/25/2017 01:31 PM, Daniel Vetter wrote: It's dead code, the core handles all this directly now. This also allows us to unexport drm_atomic_helper_plane_set_property. Reviewed-by: Archit Taneja Signed-off-by: Daniel Vetter Cc: Liviu

Re: [PATCH 4/8] drm: Nuke drm_atomic_helper_crtc_set_property

2017-07-25 Thread Archit Taneja
On 07/25/2017 01:31 PM, Daniel Vetter wrote: It's dead code because this is now handled in the core. Reviewed-by: Archit Taneja Signed-off-by: Daniel Vetter Cc: Boris Brezillon Cc: Daniel Vetter

[PATCH v13 7/7] drm/i915/gvt: Dmabuf support for GVT-g

2017-07-25 Thread Tina Zhang
This patch introduces a guest's framebuffer sharing mechanism based on dma-buf subsystem. With this sharing mechanism, guest's framebuffer can be shared between guest VM and host. Signed-off-by: Tina Zhang --- drivers/gpu/drm/i915/gvt/Makefile | 2 +-

Re: [PATCH 3/8] drm: Handle properties in the core for atomic drivers

2017-07-25 Thread Archit Taneja
On 07/25/2017 01:31 PM, Daniel Vetter wrote: The reason behind the original indirection through the helper functions was to allow existing drivers to overwrite how they handle properties. For example when a vendor-specific userspace had expectations that didn't match atomic. That seemed

[PATCH v13 5/7] vfio: ABI for mdev display dma-buf operation

2017-07-25 Thread Tina Zhang
Add VFIO_DEVICE_QUERY_GFX_PLANE ioctl command to let user mode query and get the plan and its related information. The dma-buf's life cycle is handled by user mode and tracked by kernel. The returned fd in struct vfio_device_query_gfx_plane can be a new fd or an old fd of a re-exported dma-buf.

[PATCH v13 6/7] drm/i915: Introduce GEM proxy

2017-07-25 Thread Tina Zhang
GEM proxy is a kind of GEM, whose backing physical memory is pinned and produced by guest VM and is used by host as read only. With GEM proxy, host is able to access guest physical memory through GEM object interface. As GEM proxy is such a special kind of GEM, a new flag I915_GEM_OBJECT_IS_PROXY

Re: [Intel-gfx] [PATCH 8/8] drm: Nuke drm_atomic_legacy_backoff

2017-07-25 Thread Maarten Lankhorst
Op 25-07-17 om 10:01 schreef Daniel Vetter: > Finally all users are gone! > > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/drm_atomic.c | 32 > include/drm/drm_atomic.h | 2 -- > 2 files changed, 34 deletions(-) > > diff --git

[PATCH v13 4/7] drm/i915/gvt: Add opregion support

2017-07-25 Thread Tina Zhang
Windows guest UPT driver can use operegion to configure the setting for display. Without the opregion support, the display registers won't be set and this blocks display model to get the correct information of the guest display plane. Signed-off-by: Bing Niu Signed-off-by:

[PATCH v13 3/7] drm/i915/gvt: Add RGB 64-bit 16:16:16:16 float format support

2017-07-25 Thread Tina Zhang
The RGB 64-bit 16:16:16:16 float pixel format is needed by windows 10 guest VM. This patch is to add this pixel format support to gvt device model. Without this patch, some Apps, e.g. "DXGIGammaVM.exe", will crash and make guest screen black. Signed-off-by: Xiaoguang Chen

[PATCH v13 2/7] drm: Introduce RGB 64-bit 16:16:16:16 float format

2017-07-25 Thread Tina Zhang
The RGB 64-bit 16:16:16:16 float pixel format is needed by windows guest VM. This patch is to introduce the format to drm. v1: Suggested by Ville to submit this patch to dri-devel. Signed-off-by: Xiaoguang Chen Signed-off-by: Tina Zhang ---

[PATCH v13 1/7] drm/i915/gvt: Add framebuffer decoder support

2017-07-25 Thread Tina Zhang
Framebuffer decoder returns guest framebuffer information. Guest framebuffer includes primary, cursor and sprite plane. Signed-off-by: Xiaoguang Chen Signed-off-by: Tina Zhang --- drivers/gpu/drm/i915/gvt/Makefile | 3 +-

[PATCH v13 0/7] drm/i915/gvt: Dma-buf support for GVT-g

2017-07-25 Thread Tina Zhang
v12->v13: 1) add comments to GEM proxy. (Chris) 2) don't ban GEM proxy in i915_gem_sw_finish_ioctl. (Chris) 3) check GEM proxy bar after finishing i915_gem_object_wait. (Chris) 4) remove GEM proxy bar in i915_gem_madvise_ioctl. v11->v12: 1) add drm_format_mod back. (Gerd and Zhenyu) 2) add

Re: [PATCH 7/8] drm: Nuke drm_atomic_helper_connector_dpms

2017-07-25 Thread Archit Taneja
On 07/25/2017 01:31 PM, Daniel Vetter wrote: It's dead code, the core handles all this directly now. The only special case is nouveau and tda988x which used one function for both legacy modeset code and -nv50 atomic world instead of 2 vtables. But amounts to exactly the same. v2: Rebase over

Re: [PATCH v2 2/7] drm/atomic: Clean up drm_atomic_helper_async_check

2017-07-25 Thread Daniel Vetter
On Tue, Jul 25, 2017 at 11:11 AM, Maarten Lankhorst wrote: > Op 25-07-17 om 10:23 schreef Daniel Vetter: >> On Wed, Jul 19, 2017 at 04:39:15PM +0200, Maarten Lankhorst wrote: >>> /* >>> - * Don't do an async update if there is an outstanding commit

Re: [Intel-gfx] [PATCH 6/8] drm: Nuke drm_atomic_helper_connector_set_property

2017-07-25 Thread Daniel Vetter
On Tue, Jul 25, 2017 at 11:23 AM, Maarten Lankhorst wrote: > Op 25-07-17 om 10:01 schreef Daniel Vetter: >> It's dead code, the core handles all this directly now. This also >> allows us to unexport drm_atomic_helper_connector_set_property. >> >> The only special case is

Re: [Intel-gfx] [PATCH 1/8] drm/omap: Simplify the rotation-on-crtc hack

2017-07-25 Thread Daniel Vetter
On Tue, Jul 25, 2017 at 10:47 AM, Maarten Lankhorst wrote: > Op 25-07-17 om 10:01 schreef Daniel Vetter: >> I want/need to rework the core property handling, and this hack is >> getting in the way. But since it's a non-standard propety only used by >> legacy

Re: [PATCH v2 2/7] drm/atomic: Clean up drm_atomic_helper_async_check

2017-07-25 Thread Maarten Lankhorst
Op 25-07-17 om 10:23 schreef Daniel Vetter: > On Wed, Jul 19, 2017 at 04:39:15PM +0200, Maarten Lankhorst wrote: >> Instead of assigning plane to __plane, iterate over plane >> which is the same thing. Simplify the check for n_planes != 1, >> at that point we know plane != NULL as well. >> >>

Re: [PATCH] dma-buf: fix reservation_object_wait_timeout_rcu to wait correctly

2017-07-25 Thread Christian König
Am 24.07.2017 um 13:57 schrieb Daniel Vetter: On Mon, Jul 24, 2017 at 11:51 AM, Christian König wrote: Am 24.07.2017 um 10:33 schrieb Daniel Vetter: On Fri, Jul 21, 2017 at 06:20:01PM +0200, Christian König wrote: From: Christian König

Re: [Intel-gfx] [PATCH v2 7/7] drm/atomic: Remove deprecated accessor macros

2017-07-25 Thread Daniel Vetter
On Wed, Jul 19, 2017 at 04:39:20PM +0200, Maarten Lankhorst wrote: > Now that the last users have been converted, we can finally get rid of > for_each_obj_in_state, we have better macros to replace them with. > > Signed-off-by: Maarten Lankhorst > Cc: Daniel

Re: [PATCH v2 6/7] drm/nouveau: Convert nouveau to use new iterator macros, v2.

2017-07-25 Thread Daniel Vetter
On Wed, Jul 19, 2017 at 04:39:19PM +0200, Maarten Lankhorst wrote: > Use the new atomic iterator macros, the old ones are about to be > removed. With the new macros, it's more easy to get old and new state so > get them from the macros instead of from obj->state. > > Changes since v1: > - Don't

Re: [PATCH 7/8] drm: Nuke drm_atomic_helper_connector_dpms

2017-07-25 Thread Philipp Zabel
On Tue, 2017-07-25 at 10:01 +0200, Daniel Vetter wrote: > It's dead code, the core handles all this directly now. > > The only special case is nouveau and tda988x which used one function > for both legacy modeset code and -nv50 atomic world instead of 2 > vtables. But amounts to exactly the same.

Re: [PATCH] drm/amdgpu: fix spelling mistake: "suuport"-> "support"

2017-07-25 Thread Christian König
Am 25.07.2017 um 00:45 schrieb Colin King: From: Colin Ian King Trivial fix to spelling mistake in WARN_ONCE message Signed-off-by: Colin Ian King Reviewed-by: Christian König ---

[PATCH] staging: vboxvideo: select GENERIC_ALLOCATOR

2017-07-25 Thread Hans de Goede
The vboxvideo code uses various gen_pool_* functions, so it needs lib/genalloc.c to be built. In some configs this is not happening, so add select GENERIC_ALLOCATOR to the Kconfig file to enforce this. Note all other Kconfig references to GENERIC_ALLOCATOR also use select. Signed-off-by: Hans de

Re: [PATCH 00/41] drm/dumb-buffers: Add defaults for .dumb_map_offset and .dumb_destroy

2017-07-25 Thread Philippe CORNU
On 07/23/2017 09:16 PM, Noralf Trønnes wrote: > This adds defaults for the drm_driver.dumb_destroy and > drm_driver.dumb_map_offset callbacks as discussed with Daniel. > > vmwgfx is the only driver that doesn't use drm_gem_dumb_destroy(). > > vgem > > vgem changes behaviour after this,

Re: [PATCH 16/41] drm/stm: Use .dumb_map_offset and .dumb_destroy defaults

2017-07-25 Thread Philippe CORNU
On 07/23/2017 09:16 PM, Noralf Trønnes wrote: > This driver can use the drm_driver.dumb_destroy and > drm_driver.dumb_map_offset defaults, so no need to set them. > > Cc: Yannick Fertre > Cc: Philippe Cornu > Cc: Benjamin Gaignard

Re: [Intel-gfx] [PATCH 1/8] drm/omap: Simplify the rotation-on-crtc hack

2017-07-25 Thread Maarten Lankhorst
Op 25-07-17 om 10:01 schreef Daniel Vetter: > I want/need to rework the core property handling, and this hack is > getting in the way. But since it's a non-standard propety only used by > legacy userspace we know that this will only every be called from > ioctl code. And never on some other

Re: [PATCH 2/8] drm: Don't update property values for atomic drivers

2017-07-25 Thread Maarten Lankhorst
Op 25-07-17 om 10:01 schreef Daniel Vetter: > Atomic drivers only use the property value store for immutable (i.e. > can't be set by userspace, but the kernel can still adjust it) > properties. The only tricky part is the removal of the update in > drm_atomic_helper_update_legacy_modeset_state().

Re: [Intel-gfx] [PATCH v2 4/7] drm/omapdrm: Fix omap_atomic_wait_for_completion

2017-07-25 Thread Daniel Vetter
On Wed, Jul 19, 2017 at 04:39:17PM +0200, Maarten Lankhorst wrote: > Use the new iterator macro and look for crtc_state->active instead of > enable, only crtc_state->enable implies that vblanks will happen. s/enable/active/, since enable only means logically enabled (aka resources reserved). With

Re: [Intel-gfx] [PATCH v2 3/7] drm/rcar-du: Use new iterator macros, v2.

2017-07-25 Thread Daniel Vetter
On Wed, Jul 19, 2017 at 04:39:16PM +0200, Maarten Lankhorst wrote: > for_each_obj_in_state is about to be removed, so use the correct new > iterator macros. > > Also look at new_plane_state instead of plane->state when looking up > the hw planes in use. They should be the same except when

Re: [PATCH] drm: tegra: add CONFIG_OF dependency

2017-07-25 Thread Jon Hunter
On 21/07/17 17:13, Arnd Bergmann wrote: > Without CONFIG_OF, we can run into a build error: > > drivers/gpu/drm/tegra/dpaux.c:378:20: error: > 'pinconf_generic_dt_node_to_map_group' undeclared here (not in a function); > did you mean 'pinconf_generic_params'? > .dt_node_to_map =

Re: [PATCH v2 2/7] drm/atomic: Clean up drm_atomic_helper_async_check

2017-07-25 Thread Daniel Vetter
On Wed, Jul 19, 2017 at 04:39:15PM +0200, Maarten Lankhorst wrote: > Instead of assigning plane to __plane, iterate over plane > which is the same thing. Simplify the check for n_planes != 1, > at that point we know plane != NULL as well. > > Rename obj_state to new_obj_state, and get rid of the

Re: [PATCH v2 1/7] drm/atomic: Use new iterator macros in drm_atomic_helper_wait_for_flip_done, again.

2017-07-25 Thread Daniel Vetter
On Wed, Jul 19, 2017 at 04:39:14PM +0200, Maarten Lankhorst wrote: > for_each_obj_in_state is about to be removed, so use the correct new > iterator macro. > > I renamed the variable to 'unused', but forgot to convert > drm_atomic_helper_wait_for_flip_done to the new iterator macro, > so make it

Re: [PATCH 1/2] drm/edid: Add helper to detect whether EDID changed

2017-07-25 Thread Daniel Vetter
On Tue, Jul 25, 2017 at 10:58:55AM +0300, Paul Kocialkowski wrote: > On Tue, 2017-07-25 at 09:34 +0200, Daniel Vetter wrote: > > On Tue, Jul 25, 2017 at 9:25 AM, Paul Kocialkowski > > wrote: > > > On Tue, 2017-07-25 at 08:53 +0200, Daniel Vetter wrote: > > > >

Re: [PATCH v2 1/4] drm/atomic: implement drm_atomic_helper_commit_tail for runtime_pm users

2017-07-25 Thread Daniel Vetter
On Tue, Jul 25, 2017 at 08:57:34AM +0200, Maxime Ripard wrote: > Hi Daniel, > > On Thu, Jul 20, 2017 at 08:46:28PM +0200, Daniel Vetter wrote: > > On Thu, Jul 20, 2017 at 03:01:16PM +0200, Maxime Ripard wrote: > > > The current drm_atomic_helper_commit_tail helper works only if the CRTC is > > >

Re: [PATCH] [RESEND] gpu: ipu-v3: add DRM dependency

2017-07-25 Thread Philipp Zabel
On Tue, 2017-07-25 at 09:33 +0200, Arnd Bergmann wrote: > On Mon, Jul 24, 2017 at 10:05 AM, Philipp Zabel > wrote: > > On Fri, 2017-07-21 at 22:56 +0200, Arnd Bergmann wrote: > >> The new PRE/PRG driver code causes a link failure when DRM is disabled: > >> > >>

Re: [PATCH 7/8] drm: Nuke drm_atomic_helper_connector_dpms

2017-07-25 Thread Neil Armstrong
Le 25/07/2017 10:01, Daniel Vetter a écrit : > It's dead code, the core handles all this directly now. > > The only special case is nouveau and tda988x which used one function > for both legacy modeset code and -nv50 atomic world instead of 2 > vtables. But amounts to exactly the same. > > v2:

[PATCH 7/8] drm: Nuke drm_atomic_helper_connector_dpms

2017-07-25 Thread Daniel Vetter
It's dead code, the core handles all this directly now. The only special case is nouveau and tda988x which used one function for both legacy modeset code and -nv50 atomic world instead of 2 vtables. But amounts to exactly the same. v2: Rebase over the panel/brideg refactorings in stm/ltdc.

[PATCH 8/8] drm: Nuke drm_atomic_legacy_backoff

2017-07-25 Thread Daniel Vetter
Finally all users are gone! Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_atomic.c | 32 include/drm/drm_atomic.h | 2 -- 2 files changed, 34 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic.c

[PATCH 4/8] drm: Nuke drm_atomic_helper_crtc_set_property

2017-07-25 Thread Daniel Vetter
It's dead code because this is now handled in the core. Signed-off-by: Daniel Vetter Cc: Boris Brezillon Cc: Daniel Vetter Cc: Jani Nikula Cc: Sean Paul

[PATCH 1/8] drm/omap: Simplify the rotation-on-crtc hack

2017-07-25 Thread Daniel Vetter
I want/need to rework the core property handling, and this hack is getting in the way. But since it's a non-standard propety only used by legacy userspace we know that this will only every be called from ioctl code. And never on some other free-standing state struct, where this old hack wouldn't

[PATCH 6/8] drm: Nuke drm_atomic_helper_connector_set_property

2017-07-25 Thread Daniel Vetter
It's dead code, the core handles all this directly now. This also allows us to unexport drm_atomic_helper_connector_set_property. The only special case is nouveau which used one function for both pre-nv50 legacy modeset code and post-nv50 atomic world instead of 2 vtables. But amounts to exactly

[PATCH 5/8] drm: Nuke drm_atomic_helper_plane_set_property

2017-07-25 Thread Daniel Vetter
It's dead code, the core handles all this directly now. This also allows us to unexport drm_atomic_helper_plane_set_property. Signed-off-by: Daniel Vetter Cc: Liviu Dudau Cc: Brian Starkey Cc: Mali DP Maintainers

  1   2   >