Re: [PATCH -next] drm/msm/dpu: remove duplicated include from dpu_hw_lm.c

2018-10-05 Thread Abhinav Kumar
On 2018-10-05 18:49, YueHaibing wrote: Remove duplicated include. Signed-off-by: YueHaibing Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c b/drivers/gpu/drm/msm/disp/dpu1/d

[PATCH v10 1/2] drm/panel: Add support for Truly NT35597 panel driver

2018-10-05 Thread Abhinav Kumar
Add support for Truly NT35597 panel driver used in MSM reference platforms. This panel driver supports both single DSI and dual DSI modes. However, this patch series adds support only for dual DSI mode. Changes in v10: - None Reviewed-by: Sean Paul Signed-off-by: Archit Taneja Signed-off-by: A

[PATCH v10 2/2] dt-bindings: Add Truly NT35597 panel driver bindings

2018-10-05 Thread Abhinav Kumar
Add the device tree bindings for Truly NT35597 panel driver. This panel driver supports both single DSI and dual DSI. However, this patch series supports only dual DSI. Changes in v10: - Remove active high in the documentation for mode gpio - Fix commmit text detail about the board and also

[Bug 106671] Frequent lock ups for AMD RX 550 graphics card

2018-10-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106671 --- Comment #28 from Alan W. Irwin --- (In reply to Michel Dänzer from comment #27) > (In reply to Alan W. Irwin from comment #26) > > Debian Jessie = oldstable had debug packages for libgl1-mesa-dri, but I > > can find nothing equivalent for De

Re: [PATCH v5 27/28] drm/i915/dsc: Add Per connector debugfs node for DSC support/enable

2018-10-05 Thread Lyude Paul
On Fri, 2018-10-05 at 16:23 -0700, Manasi Navare wrote: > DSC can be supported per DP connector. This patch adds a per connector > debugfs node to expose DSC support capability by the kernel. > The same node can be used from userspace to force DSC enable. > > Cc: Rodrigo Vivi > Cc: Ville Syrjala

[PATCH v5 25/28] drm/i915/dp: Disable DSC in source by disabling DSS CTL bits

2018-10-05 Thread Manasi Navare
1. Disable Left/right VDSC branch in DSS Ctrl reg depending on the number of VDSC engines being used 2. Disable joiner in DSS Ctrl reg v3 (From Manasi): * Add Disable PG2 for VDSC on eDP v2 (From Manasi): * Use old_crtc_state to find dsc params * Add a condition to disable only if dsc state co

[PATCH v5 23/28] drm/i915/icl: Add Display Stream Splitter control registers

2018-10-05 Thread Manasi Navare
From: "Srivatsa, Anusha" Add defines for DSS_CTL registers. These registers specify the big joiner, splitter, overlap pixels and info regarding display stream compression enabled on left or right branch. v3 (From Manasi): - Change the hex values to lower case (Madhav) - Use BIT macro (Manasi) v2

[PATCH v5 10/28] drm/dsc: Define Rate Control values that do not change over configurations

2018-10-05 Thread Manasi Navare
From: "Srivatsa, Anusha" DSC has some Rate Control values that remain constant across all configurations. These are as per the DSC standard. v3: * Define them in drm_dsc.h as they are DSC constants (Manasi) v2: * Add DP_DSC_ prefix (Jani Nikula) Cc: dri-devel@lists.freedesktop.org Cc: Manasi Na

[PATCH v5 26/28] drm/i915/dsc: Enable and disable appropriate power wells for VDSC

2018-10-05 Thread Manasi Navare
A separate power well 2 (PG2) is required for VDSC on eDP transcoder whereas all other transcoders use the power wells associated with the transcoders for VDSC. This patch adds a helper to obtain correct power domain depending on transcoder being used and enables/disables the power wells during VDS

[PATCH v5 27/28] drm/i915/dsc: Add Per connector debugfs node for DSC support/enable

2018-10-05 Thread Manasi Navare
DSC can be supported per DP connector. This patch adds a per connector debugfs node to expose DSC support capability by the kernel. The same node can be used from userspace to force DSC enable. Cc: Rodrigo Vivi Cc: Ville Syrjala Cc: Anusha Srivatsa Cc: Lyude Paul Signed-off-by: Manasi Navare

[PATCH v5 15/28] drm/dsc: Define the DSC 1.1 and 1.2 Line Buffer depth constants

2018-10-05 Thread Manasi Navare
DSC specification defines linebuf_depth which contains the line buffer bit depth used to generate the bitstream. These values are defined as per Table 4.1 in DSC 1.2 spec v2 (From Manasi): * Rename as MAX_LINEBUF_DEPTH for DSC 1.1 and DSC 1.2 Cc: dri-devel@lists.freedesktop.org Cc: Jani Nikula C

[PATCH v5 14/28] drm/i915/dp: Do not enable PSR2 if DSC is enabled

2018-10-05 Thread Manasi Navare
If a eDP panel supports both PSR2 and VDSC, our HW cannot support both at a time. Give priority to PSR2 if a requested resolution can be supported without compression else enable VDSC and keep PSR2 disabled. v3: * Rebase v2: * Add warning for DSC and PSR2 enabled together (DK) Cc: Rodrigo Vivi C

[PATCH v5 24/28] drm/i915/dp: Configure Display stream splitter registers during DSC enable

2018-10-05 Thread Manasi Navare
Display Stream Splitter registers need to be programmed to enable the joiner if two DSC engines are used and also to enable the left and the right DSC engines. This happens as part of the DSC enabling routine in the source in atomic commit. v2: * Rebase (Manasi) Cc: Jani Nikula Cc: Ville Syrjala

[PATCH v5 12/28] drm/i915/dp: Add DSC params and DSC config to intel_crtc_state

2018-10-05 Thread Manasi Navare
Basic DSC parameters and DSC configuration data needs to be computed for each of the requested mode during atomic check. This is required since for certain modes, valid DSC parameters and config data might not be computed in which case compression cannot be enabled for that mode. For that reason we

[PATCH v5 20/28] drm/i915/dp: Configure i915 Picture parameter Set registers during DSC enabling

2018-10-05 Thread Manasi Navare
After encoder->pre_enable() hook, after link training sequence is completed, PPS registers for DSC encoder are configured using the DSC state parameters in intel_crtc_state as part of DSC enabling routine in the source. DSC enabling routine is called after encoder->pre_enable() before enbaling the

[PATCH v5 28/28] drm/i915/dsc: Force DSC enable if requested by IGT/userspace

2018-10-05 Thread Manasi Navare
Currently the driver will only enable DSC if a certain mode does not fit the available link BW. However IGT/userspace can force DSC enable through dsc support debugfs node to test the DSC functionality if supported by the panel. Cc: Jani Nikula Cc: Ville Syrjala Cc: Anusha Srivatsa Signed-off-b

[PATCH v5 07/28] drm/dp: Define payload size for DP SDP PPS packet

2018-10-05 Thread Manasi Navare
DP 1.4 spec defines DP secondary data packet for DSC picture parameter set. This patch defines its payload size according to the DP 1.4 specification. Signed-off-by: Manasi Navare Cc: dri-devel@lists.freedesktop.org Cc: Gaurav K Singh Cc: Jani Nikula Cc: Ville Syrjala Cc: Anusha Srivatsa Revi

[PATCH v5 21/28] drm/i915/dp: Use the existing write_infoframe() for DSC PPS SDPs

2018-10-05 Thread Manasi Navare
Infoframes are used to send secondary data packets. This patch adds support for DSC Picture parameter set secondary data packets in the existing write_infoframe helpers. v2: * Rebase on drm-tip (Manasi) Cc: Jani Nikula Cc: Ville Syrjala Cc: Anusha Srivatsa Signed-off-by: Manasi Navare Reviewe

[PATCH v5 19/28] drm/i915/dsc: Add a power domain for VDSC on eDP/MIPI DSI

2018-10-05 Thread Manasi Navare
On Icelake, a separate power well PG2 is created for VDSC engine used for eDP/MIPI DSI. This patch adds a new display power domain for Power well 2. v2: * Fix the power well mismatch CI error (Ville) * Rename as VDSC_PIPE_A (Imre) * Fix a whitespace (Anusha) * Fix Comments (Imre) Cc: Ville Syrjal

[PATCH v5 11/28] drm/dsc: Add helpers for DSC picture parameter set infoframes

2018-10-05 Thread Manasi Navare
According to Display Stream compression spec 1.2, the picture parameter set metadata is sent from source to sink device using the DP Secondary data packet. An infoframe is formed for the PPS SDP header and PPS SDP payload bytes. This patch adds helpers to fill the PPS SDP header and PPS SDP payload

[PATCH v5 06/28] drm/i915/dp: Validate modes using max Output BPP and slice count when DSC supported

2018-10-05 Thread Manasi Navare
When DSC is supported we need to validate the modes based on the maximum supported compressed BPP and maximum supported slice count. This allows us to allow the modes with pixel clock greater than the available link BW as long as it meets the compressed BPP and slice count requirements. v3: * Use

[PATCH v5 17/28] drm/i915/dsc: Compute Rate Control parameters for DSC

2018-10-05 Thread Manasi Navare
From: Gaurav K Singh This computation of RC params happens in the atomic commit phase during compute_config() to validate if display stream compression can be enabled for the requested mode. v5 (From Manasi): * Fix dim checkpatch warnings/checks v4(From Gaurav): * No change.Rebase on drm-tip v3

[PATCH v5 16/28] drm/i915/dsc: Define & Compute VESA DSC params

2018-10-05 Thread Manasi Navare
From: Gaurav K Singh This patches does the following: 1. This patch defines all the DSC parameters as per the VESA DSC specification. These are stored in the encoder and used to compute the PPS parameters to be sent to the Sink. 2. Compute all the DSC parameters which are derived from DSC state

[PATCH v5 05/28] drm/i915/dp: Add helpers for Compressed BPP and Slice Count for DSC

2018-10-05 Thread Manasi Navare
This patch adds helpers for calculating the maximum compressed BPP supported with small joiner. This also adds a helper for calculating the slice count in case of small joiner. These are inside intel_dp since they take into account hardware limitations. v6: * Take mode_clock and mode_hdisplay as i

[PATCH v5 03/28] drm/i915/dp: Cache the DP/eDP DSC DPCD register set on Hotplug/eDP Init

2018-10-05 Thread Manasi Navare
DSC is supported on eDP starting GEN 10 display (on GLK) and on DP starting GEN 11. This patch implements the discovery phase of DSC. On hotplug, source reads the DSC DPCD register set (0x00060 - 0x0006F) to read the decompression capabilities of the sink device. This entire block of registers is c

[PATCH v5 09/28] drm/dsc: Define VESA Display Stream Compression Capabilities

2018-10-05 Thread Manasi Navare
From: Gaurav K Singh This defines all the DSC parameters as per the VESA DSC spec that will be required for DSC encoder/decoder v6: (From Manasi) * Add a bit mask for RANGE_BPG_OFFSET for 6 bits(Manasi) v5 (From Manasi) * Add the RC constants as per the spec v4 (From Manasi) * Add the DSC_MUX_WO

[PATCH v5 13/28] drm/i915/dp: Compute DSC pipe config in atomic check

2018-10-05 Thread Manasi Navare
DSC params like the enable, compressed bpp, slice ocunt and dsc_split are added to the intel_crtc_state. These parameters are set based on the requested mode and available link parameters during the pipe configuration in atomic check phase. These values are then later used to populate the remaining

[PATCH v5 00/28] Display Stream Compression enabling on eDP/DP

2018-10-05 Thread Manasi Navare
VESA has developed an industry standard Display Stream Compression(DSC) for interoperable, visually lossless compression over display links to address the needs for higher resolution displays. This patch series enables DSC on Gen 10 eDP and Gen 11 eDP/DP panels. This implementation is based on VES

[PATCH v5 04/28] drm/dp: DRM DP helper/macros to get DP sink DSC parameters

2018-10-05 Thread Manasi Navare
This patch adds inline functions and helpers for obtaining DP sink's supported DSC parameters like DSC sink support, eDP compressed BPP supported, maximum slice count supported by the sink devices, DSC line buffer bit depth supported on DP sink, DSC sink maximum color depth by parsing corresponding

[PATCH v5 22/28] drm/i915/dp: Populate DSC PPS SDP and send PPS infoframes

2018-10-05 Thread Manasi Navare
DSC PPS secondary data packet infoframes are filled with DSC picure parameter set metadata according to the DSC standard. These infoframes are sent to the sink device and used during DSC decoding. v2: * Rebase ond drm-tip Cc: Jani Nikula Cc: Ville Syrjala Cc: Anusha Srivatsa Signed-off-by: Man

[PATCH v5 18/28] drm/i915/dp: Enable/Disable DSC in DP Sink

2018-10-05 Thread Manasi Navare
From: Gaurav K Singh This patch enables decompression support in sink device before link training and disables the same during the DDI disabling. v2:(From Manasi) * Change the enable/disable function to take crtc_state instead of intel_dp as an argument (Manasi) * Use the compression_enable flag

[PATCH v5 02/28] drm/dp: Add DP DSC DPCD receiver capability size define and missing SHIFT

2018-10-05 Thread Manasi Navare
This patch defines the DP DSC receiver capability size that gives total number of DP DSC DPCD registers. This also adds a missing #defines for DP DSC support missed in the commit id (ab6a46ea6842ce "Add DPCD definitions for DP 1.4 DSC feature") v3: * MIN_SLICE_WIDTH = 2560 (Anusha) * Define DP_DSC

[PATCH v5 01/28] drm/i915/dsc: Add slice_row_per_frame in DSC PPS programming

2018-10-05 Thread Manasi Navare
From: Anusha Srivatsa Add the newly added slice_row_per_frame parameter in the Picture Parameter Set registers. This defines the number of vertically stacked slices in a frame. Credits to Manasi for noticing bSpec change. Suggested-by: Manasi Navare Cc: Manasi Navare Signed-off-by: Anusha Sri

[PATCH v5 08/28] drm/dsc: Define Display Stream Compression PPS infoframe

2018-10-05 Thread Manasi Navare
This patch defines a new header file for all the DSC 1.2 structures and creates a structure for PPS infoframe which will be used to send picture parameter set secondary data packet for display stream compression. All the PPS infoframe syntax elements are taken from DSC 1.2 specification from VESA.

[Bug 201275] Power consumption RX560 idle raised from 7 W to 13 W

2018-10-05 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201275 --- Comment #20 from quirin.blae...@freenet.de --- (In reply to Michel Dänzer from comment #19) > People on the Phoronix forum mentioned that this doesn't seem to happen with > 4.19-rc kernels. If people here can confirm that, maybe there are othe

Re: [PATCH v3 1/4] drm: Add vrr_capable property to the drm connector

2018-10-05 Thread Manasi Navare
On Fri, Oct 05, 2018 at 04:39:46PM -0400, Nicholas Kazlauskas wrote: > Modern display hardware is capable of supporting variable refresh rates. > This patch introduces the "vrr_capable" property on the connector to > allow userspace to query support for variable refresh rates. > > Atomic drivers s

Re: [PATCH -next] drm/vmwgfx: Remove set but not used variable 'file_priv'

2018-10-05 Thread Sinclair Yeh
Reviewed-by: Sinclair Yeh On Fri, Oct 05, 2018 at 11:36:58AM +, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/vmwgfx/vmwgfx_fence.c: In function > 'vmw_event_fence_action_seq_passed': > drivers/gpu/drm/vmwgfx/vmwgfx_fence.c:909:19: warning: > varia

[PATCH v3 2/2] drm/sun4i: tcon: prevent tcon->panel dereference if NULL

2018-10-05 Thread Giulio Benetti
If tcon->panel pointer is NULL, trying to dereference from it (i.e. tcon->panel->connector) will cause a null pointer dereference. Add tcon->panel null pointer check before calling sun4i_tcon0_mode_set_dithering(). Signed-off-by: Giulio Benetti Fixes: f11adcecbd5f ("drm/sun4i: tcon: Add ditherin

[PATCH v3 1/2] drm/sun4i: tcon: fix check of tcon->panel null pointer

2018-10-05 Thread Giulio Benetti
Since tcon->panel is a pointer returned by of_drm_find_panel() need to check if it is not NULL, hence a valid pointer. IS_ERR() instead checks return error values, not NULL pointers. Substitute "if (!IS_ERR(tcon->panel))" with "if (tcon->panel)". Signed-off-by: Giulio Benetti --- Changes V1->V2:

[PATCH] drm/edid: VSDB yCBCr420 Deep Color mode bit definitions

2018-10-05 Thread clinton . a . taylor
From: Clint Taylor HDMI Forum VSDB YCBCR420 deep color capability bits are 2:0. Correct definitions in the header for the mask to work correctly. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107893 Signed-off-by: Clint Taylor --- drivers/gpu/drm/drm_edid.c | 2 +- include/drm/drm_edi

Re: [PATCH v2 2/2] drm/sun4i: tcon: prevent tcon->panel dereference if null

2018-10-05 Thread Giulio Benetti
Hi, Il 04/10/2018 21:56, Maxime Ripard ha scritto: On Wed, Oct 03, 2018 at 04:24:58PM +0200, Giulio Benetti wrote: If using tcon with VGA, We don't have support for VGA at the moment. Or are you talking about using a VGA bridge? You're right, in general VGA is not the point. tcon->panel is

[PATCH] intel: Introducing Whiskey Lake platform

2018-10-05 Thread Rodrigo Vivi
Whiskey Lake uses the same gen graphics as Coffe Lake, including some ids that were previously marked as reserved on Coffe Lake, but that now are moved to WHL page. This follows the ids and approach used on kernel's commit b9be78531d27 ("drm/i915/whl: Introducing Whiskey Lake platform") and commit

[Bug 107432] Periodic complete system lockup with Vega M and Kernel 4.18-rc6+

2018-10-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107432 --- Comment #10 from Robert Strube --- Hello Michel, Apologies, I've been pretty busy with work the last month or so. I'm now available again to test out your patch (not sure if this has already made it's way into mainline?). I'm currently ru

Re: [PATCH 16/21] drm/vmwgfx: Fix vmw_du_cursor_plane_atomic_check

2018-10-05 Thread Thomas Hellstrom
On 10/05/2018 10:46 PM, Daniel Vetter wrote: > On Fri, Oct 05, 2018 at 04:21:43PM +, Thomas Hellstrom wrote: >> On 10/05/2018 06:06 PM, Daniel Vetter wrote: >>> On Thu, Oct 04, 2018 at 10:24:41PM +0200, Daniel Vetter wrote: From: Thomas Hellstrom Use the correct helper and also

Re: [PATCH] drm/msm: validate display and event threads

2018-10-05 Thread Abhinav Kumar
On 2018-10-05 12:49, Jeykumar Sankaran wrote: While creating display and event threads per crtc, validate them before setting their priorities. Change-Id: I1dda805286df981c0f0e2b26507d089d3a21ff6c Signed-off-by: Jeykumar Sankaran --- drivers/gpu/drm/msm/msm_drv.c | 49 ++--

Re: [PATCH 16/21] drm/vmwgfx: Fix vmw_du_cursor_plane_atomic_check

2018-10-05 Thread Daniel Vetter
On Fri, Oct 05, 2018 at 04:21:43PM +, Thomas Hellstrom wrote: > On 10/05/2018 06:06 PM, Daniel Vetter wrote: > > On Thu, Oct 04, 2018 at 10:24:41PM +0200, Daniel Vetter wrote: > >> From: Thomas Hellstrom > >> > >> Use the correct helper and also return early on helper > >> success rather than

[PATCH v3 4/4] drm/amd/display: Set FreeSync state using drm VRR properties

2018-10-05 Thread Nicholas Kazlauskas
Support for AMDGPU specific FreeSync properties and ioctls are dropped from amdgpu_dm in favor of supporting drm variable refresh rate properties. The drm vrr_capable property is now attached to any DP/HDMI connector. Its value is updated accordingly to the connector's FreeSync capabiltiy. The fr

[PATCH v3 3/4] drm: Document variable refresh properties

2018-10-05 Thread Nicholas Kazlauskas
These include the drm_connector 'vrr_capable' and the drm_crtc 'vrr_enabled' properties. Signed-off-by: Nicholas Kazlauskas --- Documentation/gpu/drm-kms.rst | 7 +++ drivers/gpu/drm/drm_connector.c | 22 ++ 2 files changed, 29 insertions(+) diff --git a/Documentation

[PATCH v3 2/4] drm: Add vrr_enabled property to drm CRTC

2018-10-05 Thread Nicholas Kazlauskas
This patch introduces the 'vrr_enabled' CRTC property to allow dynamic control over variable refresh rate support for a CRTC. This property should be treated like a content hint to the driver - if the hardware or driver is not capable of driving variable refresh timings then this is not considered

[PATCH v3 1/4] drm: Add vrr_capable property to the drm connector

2018-10-05 Thread Nicholas Kazlauskas
Modern display hardware is capable of supporting variable refresh rates. This patch introduces the "vrr_capable" property on the connector to allow userspace to query support for variable refresh rates. Atomic drivers should attach this property to connectors that are capable of driving variable r

[PATCH v3 0/4] A DRM API for adaptive sync and variable refresh rate support

2018-10-05 Thread Nicholas Kazlauskas
These patches are part of a proposed new interface for supporting variable refresh rate via DRM properties. === Changes from v2 === The interface has changed substantially from the last revision and the cover letter has been updated accordingly. drm changes: * Most "variable_refresh" prefixes

[Bug 108251] Error Example

2018-10-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108251 Bug ID: 108251 Summary: Error Example Product: DRI Version: XOrg git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium

Re: [PATCH 01/21] drm/amdgpu: Remove default best_encoder hook from DC

2018-10-05 Thread Leo Li
On 2018-10-05 11:41 AM, Harry Wentland wrote: On 2018-10-04 04:24 PM, Daniel Vetter wrote: For atomic driver this is the default, no need to reimplement it. We still need to keep the copypasta for not-atomic drivers though, since no one polished the legacy crtc helpers as much as the atomic on

[PATCH] drm/msm/a6xx: Remove CP perfcounter selects from the protected list

2018-10-05 Thread Jordan Crouse
The CP performance counter selects were accidentally marked as protected so they couldn't be written from PM4 streams. Remove the protection because user space does have an interest in setting up their own counters. Signed-off-by: Jordan Crouse --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 4 +---

RE: [bug report] drm/msm: Add SDM845 DPU support

2018-10-05 Thread jsanka
Thanks for reporting the issue Dan. Posted the patch below as the fix. https://patchwork.freedesktop.org/series/50637/ Thanks and Regards, Jeykumar S. -Original Message- From: Dan Carpenter Sent: Monday, October 1, 2018 2:39 AM To: jsa...@codeaurora.org Cc: dri-devel@lists.freedesktop.

[PATCH] drm/msm: validate display and event threads

2018-10-05 Thread Jeykumar Sankaran
While creating display and event threads per crtc, validate them before setting their priorities. Change-Id: I1dda805286df981c0f0e2b26507d089d3a21ff6c Signed-off-by: Jeykumar Sankaran --- drivers/gpu/drm/msm/msm_drv.c | 49 ++- 1 file changed, 16 insertion

Re: [Intel-gfx] [PATCH] dim: Add range-diff convenience wrapper

2018-10-05 Thread Daniel Vetter
On Fri, Oct 05, 2018 at 11:43:58AM -0700, Lucas De Marchi wrote: > On Thu, Oct 4, 2018 at 4:00 AM Daniel Vetter wrote: > > > > range-diff is awesome, but the interface is a bit silly. Add a bunch > > of shortcuts, inspired by what git diff does. > > > > v2: Add it to the developer commmands list.

Re: [PATCH v9 2/2] dt-bindings: Add Truly NT35597 panel driver bindings

2018-10-05 Thread Rob Herring
On Fri, Oct 5, 2018 at 12:38 PM Abhinav Kumar wrote: > > Hi Rob > > Had one question on below comment. Can you please help to clarify? > > Thanks > > Abhinav > On 2018-10-04 12:42, Abhinav Kumar wrote: > > Hi Rob > > > > Thanks for the review. Will copy the DT list in the next patchset. > > > > So

Re: [PATCH 1/2] drm/vmwgfx: Fix up the implicit display unit handling

2018-10-05 Thread Thomas Hellstrom
Thanks for reviewing, Ville. I'll fix those up. /Thomas On 10/05/2018 12:04 PM, Ville Syrjälä wrote: ... ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 05/21] drm/vmwgfx: Remove confused comment from vmw_du_connector_atomic_set_property

2018-10-05 Thread Daniel Vetter
On Fri, Oct 5, 2018 at 8:19 PM Thomas Hellstrom wrote: > > On 10/05/2018 09:48 AM, Daniel Vetter wrote: > > On Fri, Oct 05, 2018 at 08:43:51AM +0200, Daniel Vetter wrote: > >> On Thu, Oct 04, 2018 at 10:40:16PM +, Thomas Hellstrom wrote: > >>> Hi! > >>> > >>> I've sent out patches that replace

Re: [PATCH 05/21] drm/vmwgfx: Remove confused comment from vmw_du_connector_atomic_set_property

2018-10-05 Thread Thomas Hellstrom
On 10/05/2018 09:48 AM, Daniel Vetter wrote: > On Fri, Oct 05, 2018 at 08:43:51AM +0200, Daniel Vetter wrote: >> On Thu, Oct 04, 2018 at 10:40:16PM +, Thomas Hellstrom wrote: >>> Hi! >>> >>> I've sent out patches that replace 05/21 and 07/21. Since I'm on travel, >>> I'm not sure I'll be able t

Re: [PATCH v2 2/3] drm: Add variable refresh property to DRM CRTC

2018-10-05 Thread Kazlauskas, Nicholas
On 10/05/2018 12:56 PM, Michel Dänzer wrote: On 2018-10-05 6:21 p.m., Kazlauskas, Nicholas wrote: On 10/05/2018 04:10 AM, Pekka Paalanen wrote: 2. User preference A toggle on the desktop environment's display settings application to allow or disallow VRR. After all, video mode c

Re: [PATCH v9 2/2] dt-bindings: Add Truly NT35597 panel driver bindings

2018-10-05 Thread Abhinav Kumar
Hi Rob Had one question on below comment. Can you please help to clarify? Thanks Abhinav On 2018-10-04 12:42, Abhinav Kumar wrote: Hi Rob Thanks for the review. Will copy the DT list in the next patchset. Some comments inline. Thanks Abhinav On 2018-10-04 12:01, Rob Herring wrote: If you

Re: [PATCH 7/9] OPP: Add dev_pm_opp_get_interconnect_bw()

2018-10-05 Thread Jordan Crouse
On Fri, Oct 05, 2018 at 12:06:06PM +0530, Sharat Masetty wrote: > > > On 8/27/2018 8:41 PM, Jordan Crouse wrote: > >Add dev_pm_opp_get_interconnect_bw() to read the interconnect > >bandwidth values for a given OPP. > > > >Signed-off-by: Jordan Crouse > >--- > > drivers/opp/of.c | 36 +

Re: [PATCH v2 2/3] drm: Add variable refresh property to DRM CRTC

2018-10-05 Thread Michel Dänzer
On 2018-10-05 6:21 p.m., Kazlauskas, Nicholas wrote: > On 10/05/2018 04:10 AM, Pekka Paalanen wrote: >> >> 2. User preference >> A toggle on the desktop environment's display settings >> application to allow or disallow VRR. After all, video mode >> configuration is here too, and ideall

Re: [PATCH 16/21] drm/vmwgfx: Fix vmw_du_cursor_plane_atomic_check

2018-10-05 Thread Thomas Hellstrom
On 10/05/2018 06:06 PM, Daniel Vetter wrote: > On Thu, Oct 04, 2018 at 10:24:41PM +0200, Daniel Vetter wrote: >> From: Thomas Hellstrom >> >> Use the correct helper and also return early on helper >> success rather than on helper failure. >> >> Also explicitly return 0 in the case of no fb. >> >>

Re: [PATCH 20/21] drm/todo: Add some cleanup tasks

2018-10-05 Thread Eric Engestrom
On Friday, 2018-10-05 12:07:26 -0400, Harry Wentland wrote: > On 2018-10-04 04:24 PM, Daniel Vetter wrote: > > Motivated by review comments from Ville&Sean. > > > > Cc: Ville Syrjälä > > Cc: Sean Paul > > Signed-off-by: Daniel Vetter > > Acked-by: Harry Wentland > > Harry > > > --- > > Doc

Re: [PATCH v2 2/3] drm: Add variable refresh property to DRM CRTC

2018-10-05 Thread Kazlauskas, Nicholas
On 10/05/2018 04:10 AM, Pekka Paalanen wrote: Hi, I have a somewhat of my own view on what would be involved with VRR, and I'd like to hear what you think of it. Comments inline. On Tue, 25 Sep 2018 09:51:37 -0400 "Kazlauskas, Nicholas" wrote: On 09/24/2018 04:26 PM, Ville Syrjälä wrote: O

[Bug 108095] Window becomes partially transparent for short time

2018-10-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108095 Michel Dänzer changed: What|Removed |Added Version|DRI git |git Product|DRI

Re: [PATCH 20/21] drm/todo: Add some cleanup tasks

2018-10-05 Thread Harry Wentland
On 2018-10-04 04:24 PM, Daniel Vetter wrote: > Motivated by review comments from Ville&Sean. > > Cc: Ville Syrjälä > Cc: Sean Paul > Signed-off-by: Daniel Vetter Acked-by: Harry Wentland Harry > --- > Documentation/gpu/todo.rst | 10 ++ > 1 file changed, 10 insertions(+) > > diff

Re: [PATCH 16/21] drm/vmwgfx: Fix vmw_du_cursor_plane_atomic_check

2018-10-05 Thread Daniel Vetter
On Thu, Oct 04, 2018 at 10:24:41PM +0200, Daniel Vetter wrote: > From: Thomas Hellstrom > > Use the correct helper and also return early on helper > success rather than on helper failure. > > Also explicitly return 0 in the case of no fb. > > v2: Check for !fb after updating state->visible (Vil

[PATCH] MAINTAINERS: Add Maxime Ripard as drm-misc maintainer

2018-10-05 Thread Sean Paul
Unfortunately Gustavo has decided to step down as drm-misc maintainer to focus on other projects. Thanks Gustavo for your dedication and hard work! Fortunately for us, we have a wealth of people qualified to assume a -misc maintainer role. Maxime has done an outstanding job with sun4i and in the c

Re: [PATCH resend 00/15] staging: vboxvideo: Convert to atomic modesetting API

2018-10-05 Thread Daniel Vetter
On Mon, Oct 01, 2018 at 11:20:04AM +0200, Hans de Goede wrote: > Hi, > > On 01-10-18 09:25, Dan Carpenter wrote: > > Why are you resending this? It's because you added some more patches > > on the end? Just send those as a new series... > > I accidentally numbered the cover-letter of the origin

[Bug 107978] [amdgpu] Switching to tty fails with DisplayPort monitor going to sleep (REG_WAIT timeout / dce110_stream_encoder_dp_blank)

2018-10-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107978 --- Comment #3 from Shmerl --- Is this issue Debian specific or anyone observed it in other distros? Because if it's something wrong with Debian's kernel build I should probably file a Debian bug about it. -- You are receiving this mail becaus

Re: [PATCH v2] virtio-gpu: add VIRTIO_GPU_F_EDID feature

2018-10-05 Thread Gerd Hoffmann
Hi, > >>> +/* VIRTIO_GPU_RESP_OK_EDID */ > >>> +struct virtio_gpu_resp_edid { > >>> + struct virtio_gpu_ctrl_hdr hdr; > >>> + __le32 scanout; > >>> + __le32 size; > >>> + __u8 edid[1024]; > >> > >> Wouldn’t it be enough to stick to EDID 2.0 (256 bytes)? > >> > >> If not, maybe add comment to e

Re: [PATCH 01/21] drm/amdgpu: Remove default best_encoder hook from DC

2018-10-05 Thread Harry Wentland
On 2018-10-04 04:24 PM, Daniel Vetter wrote: > For atomic driver this is the default, no need to reimplement it. We > still need to keep the copypasta for not-atomic drivers though, since > no one polished the legacy crtc helpers as much as the atomic ones. > > v2: amdgpu uses ->best_encoder inter

Re: [PATCH] drm/vblank: Remove old-style comments

2018-10-05 Thread Daniel Vetter
On Fri, Oct 05, 2018 at 01:14:18PM +0300, Ville Syrjälä wrote: > On Fri, Oct 05, 2018 at 09:36:36AM +0200, Daniel Vetter wrote: > > Somehow I forgot a few when typing all the shiny new kerneldoc. Drop > > them. > > > > Signed-off-by: Daniel Vetter > > Reviewed-by: Ville Syrjälä Applied, thanks

Re: [PATCH v2] virtio-gpu: add VIRTIO_GPU_F_EDID feature

2018-10-05 Thread Christophe de Dinechin
> On 5 Oct 2018, at 16:41, Daniel Vetter wrote: > > On Fri, Oct 05, 2018 at 04:38:11PM +0200, Christophe de Dinechin wrote: >> >> >>> On 5 Oct 2018, at 14:51, Gerd Hoffmann wrote: >>> >>> The feature allows the guest request an EDID blob (describing monitor >>> capabilities) for a given sca

Re: [PATCH 12/12] arm64: dts: allwinner: bananapi-m64: Bananapi S070WV20-CT16 DSI panel

2018-10-05 Thread Maxime Ripard
On Thu, Oct 04, 2018 at 09:33:59PM +0530, Jagan Teki wrote: > On Thu, Sep 27, 2018 at 10:47 PM Maxime Ripard > wrote: > > > > On Thu, Sep 27, 2018 at 05:18:50PM +0530, Jagan Teki wrote: > > > This patch add support for Bananapi S070WV20-CT16 DSI panel to > > > BPI-M64 board. > > > > > > DSI panel

[GIT PULL] malidp-next-fixes

2018-10-05 Thread Liviu Dudau
Hi Dave, I've realised that the commit 3dae1c0919d8 ("drm/arm/malidp: Implemented the size validation for AFBC framebuffers") got bungled up in the upstreaming process and it was missing an important line from the function that calculates the size of the AFBC framebuffer. The patch to fix it has n

Re: [PATCH 4/4] drm/imx: only send commit done event when all state has been applied

2018-10-05 Thread Philipp Zabel
On Fri, 2018-09-14 at 18:59 +0200, Lucas Stach wrote: > Currently there is a small race window where we could manage to arm the > vblank event from atomic flush, but programming the hardware was too close > to the frame end, so the hardware will only apply the current state on the > next vblank. In

Re: [v2 7/7] drm/msm/a6xx: Add support for using system cache(LLC)

2018-10-05 Thread Jordan Crouse
On Fri, Oct 05, 2018 at 06:38:35PM +0530, Sharat Masetty wrote: > The last level system cache can be partitioned to 32 different slices > of which GPU has two slices preallocated. One slice is used for caching GPU > buffers and the other slice is used for caching the GPU SMMU pagetables. > This pat

Re: [v2 4/7] drm/msm/adreno: Add registers in the GPU CX domain

2018-10-05 Thread Jordan Crouse
On Fri, Oct 05, 2018 at 06:38:32PM +0530, Sharat Masetty wrote: > Add the registers needed for configuring the system cache slice info and > other parameters in the GPU. This would conflict with msm-next or at least with the latest update from the rnndb. It is good to have this out here for people

Re: [PATCH v3 0/6] Add method to describe tile/bit_level_packed formats

2018-10-05 Thread Daniel Vetter
On Fri, Oct 05, 2018 at 09:26:43AM +, Alexandru-Cosmin Gheorghe wrote: > There has been some discussion about extending drm core to handle > linear tile formats, in the series sent by me here [1] and how to > handle formats that are intended to be used just with > modifiers(particularly AFBC mo

Re: [PATCH v3 4/6] drm: Extend framebuffer_check to handle formats with cpp/char_per_block 0

2018-10-05 Thread Daniel Vetter
On Fri, Oct 05, 2018 at 09:26:57AM +, Alexandru-Cosmin Gheorghe wrote: > For formats that are supported only with non-linear modifiers it > doesn't make to much sense to define cpp or char_per_block, so that > will be set to 0. > > This patch adds a restriction to force having a modifier attac

Re: [PATCH v3 1/6] drm/fourcc: Add char_per_block, block_w and block_h in drm_format_info

2018-10-05 Thread Daniel Vetter
On Fri, Oct 05, 2018 at 09:26:47AM +, Alexandru-Cosmin Gheorghe wrote: > For some pixel formats .cpp structure in drm_format info it's not > enough to describe the peculiarities of the pixel layout, for example > tiled formats or packed formats at bit level. > > What's implemented here is to a

[Bug 201275] Power consumption RX560 idle raised from 7 W to 13 W

2018-10-05 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201275 --- Comment #19 from Michel Dänzer (mic...@daenzer.net) --- People on the Phoronix forum mentioned that this doesn't seem to happen with 4.19-rc kernels. If people here can confirm that, maybe there are other corresponding changes that need to be

Re: [PATCH v2] virtio-gpu: add VIRTIO_GPU_F_EDID feature

2018-10-05 Thread Daniel Vetter
On Fri, Oct 05, 2018 at 04:38:11PM +0200, Christophe de Dinechin wrote: > > > > On 5 Oct 2018, at 14:51, Gerd Hoffmann wrote: > > > > The feature allows the guest request an EDID blob (describing monitor > > capabilities) for a given scanout (aka virtual monitor connector). > > > > It brings a

Re: [PATCH v2] virtio-gpu: add VIRTIO_GPU_F_EDID feature

2018-10-05 Thread Christophe de Dinechin
> On 5 Oct 2018, at 14:51, Gerd Hoffmann wrote: > > The feature allows the guest request an EDID blob (describing monitor > capabilities) for a given scanout (aka virtual monitor connector). > > It brings a new command message, which has just a scanout field (beside > the standard virtio-gpu h

Re: [PATCH 12/21] drm/sti: Use drm_atomic_helper_shutdown

2018-10-05 Thread Daniel Vetter
On Fri, Oct 5, 2018 at 12:14 PM Benjamin Gaignard wrote: > > From: Daniel Vetter > > drm_plane_helper_disable is a non-atomic drivers only function, and > will blow up (since no one passes the locking context it needs). > > Atomic drivers which want to quiescent their hw on unload should > use dr

Re: [PATCH] drm: malidp: Add the size of the superblocks when calculating total size for AFBC buffers

2018-10-05 Thread Ayan Halder
Hi Liviu, On Fri, Oct 05, 2018 at 01:38:19PM +0100, Liviu Dudau wrote: > The size of the superblocks being added to the total AFBC buffer size > got lost in the upstreaming process. Add it back. > > Cc: Ayan Kumar Halder > Signed-off-by: Liviu Dudau > --- > drivers/gpu/drm/arm/malidp_drv.c | 4

Re: [PATCH 3/4] drm/imx: ipuv3-plane: add function to query atomic update status

2018-10-05 Thread Philipp Zabel
On Fri, 2018-09-14 at 18:59 +0200, Lucas Stach wrote: > This function allows upper layer to check if a requested atomic update > to the plane has been applied or is still pending. > > Signed-off-by: Lucas Stach > --- > drivers/gpu/drm/imx/ipuv3-plane.c | 20 > drivers/gpu/dr

Re: [PATCH 2/4] gpu: ipu-v3: prg: add function to get channel configure status

2018-10-05 Thread Philipp Zabel
On Fri, 2018-09-14 at 18:59 +0200, Lucas Stach wrote: > This allows channels using the PRG to check if a requested configuration > update has been applied or is still pending. > > Signed-off-by: Lucas Stach > --- > drivers/gpu/ipu-v3/ipu-prg.c | 16 > include/video/imx-ipu-v3.h

Re: [PATCH 1/4] gpu: ipu-v3: pre: add double buffer status readback

2018-10-05 Thread Philipp Zabel
Hi Lucas, On Fri, 2018-09-14 at 18:59 +0200, Lucas Stach wrote: > This allows the upper layers to check if a double buffer update has > been applied by the PRE or is still pending. > > Signed-off-by: Lucas Stach > --- > drivers/gpu/ipu-v3/ipu-pre.c | 6 ++ > drivers/gpu/ipu-v3/ipu-prv.h | 1

Re: [PATCH 4/5] omapdrm/dss/hdmi4_cec.c: clear TX FIFO before transmit_done

2018-10-05 Thread Hans Verkuil
Tomi, Can you review this patch and the next? They should go to 4.20. This patch in particular is a nasty one, hard to reproduce. This patch should also be Cc-ed to stable for 4.15 and up. Tracking down randomly disappearing CEC transmits was no fun :-( Regards, Hans On 10/04/18 11:08

[Bug 108014] AMD WX4150 - MST is entirely nonfunctional, spams dmesg with errors

2018-10-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108014 --- Comment #7 from Jerry Zuo --- I am retesting on HP Zbook. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org https

[Bug 201275] Power consumption RX560 idle raised from 7 W to 13 W

2018-10-05 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201275 --- Comment #18 from quirin.blae...@freenet.de --- (In reply to Alex Deucher from comment #9) > I don't think this is a bug. The problem is, prior to that patch, the > display component was requesting minimum clocks that were 10x too low. This >

[PATCHv2 0/6] cec/adv/cec-gpio: fixes and new status flags

2018-10-05 Thread Hans Verkuil
From: Hans Verkuil This patch series replaces patches 1-3 of: https://www.spinics.net/lists/linux-media/msg141216.html Patches 4 & 5 of that series remain as-is and are omap4 bug fixes. This patch series can be applied to the media subsystem since it has no drm changes. Changes since the prev

[PATCHv2 4/6] adv7842: when the EDID is cleared, unconfigure CEC as well

2018-10-05 Thread Hans Verkuil
From: Hans Verkuil When there is no EDID the CEC adapter should be unconfigured as well. So call cec_phys_addr_invalidate() when this happens. Signed-off-by: Hans Verkuil --- drivers/media/i2c/adv7842.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/ad

[PATCHv2 2/6] cec: add new tx/rx status bits to detect aborts/timeouts

2018-10-05 Thread Hans Verkuil
From: Hans Verkuil If the HDMI cable is disconnected or the CEC adapter is manually unconfigured, then all pending transmits and wait-for-replies are aborted. Signal this with new status bits (CEC_RX/TX_STATUS_ABORTED). If due to (usually) a driver bug a transmit never ends (i.e. the transmit_do

  1   2   >