[Bug 110604] AMD WX4150 hangs in aux_read call for REG_RC_CAP

2019-05-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110604 Jason changed: What|Removed |Added Summary|AMX WX4150 hangs in |AMD WX4150 hangs in

[Bug 110604] AMX WX4150 hangs in aux_read call for REG_RC_CAP

2019-05-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110604 Bug ID: 110604 Summary: AMX WX4150 hangs in aux_read call for REG_RC_CAP Product: DRI Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

[Bug 109524] "Invalid glsl version in shading_language_version()" when trying to run directX games using wine

2019-05-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109524 --- Comment #2 from da...@linuxid10t.com --- I have had the same problem in Mesa 19.0.0 with the Nouveau driver. It seems that any card without hardware shaders is failing. This was tested with NV05 and NV11. -- You are receiving this mail

[Bug 108893] Slow redrawing of menu in Gothic 2 under wine

2019-05-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108893 --- Comment #13 from supercoolem...@seznam.cz --- You are lucky. I have this: https://imgur.com/a/YTDyAXv Notice, that this is with vastly limited object rendering distance, which makes fights rather difficult - I can't even see who is shooting

Re: [PATCH v2 16/17] kernel/sysctl-test: Add null pointer test for sysctl.c:proc_dointvec()

2019-05-03 Thread Brendan Higgins
> On Thu, May 02, 2019 at 11:45:43AM -0700, Brendan Higgins wrote: > > On Thu, May 2, 2019 at 11:15 AM wrote: > > > > > > > > > > > > > -Original Message- > > > > From: Greg KH > > > > > > > > On Wed, May 01, 2019 at 04:01:25PM -0700, Brendan Higgins wrote: > > > > > From: Iurii Zaikin >

Re: [PATCH v6 1/3] drm: Add CRTC background color property (v5)

2019-05-03 Thread Matt Roper
On Thu, Apr 25, 2019 at 12:45:33PM +0200, Maarten Lankhorst wrote: > Op 26-02-2019 om 17:17 schreef Matt Roper: > > On Tue, Feb 26, 2019 at 08:26:36AM +0100, Maarten Lankhorst wrote: > >> Hey, > >> > >> Op 21-02-2019 om 01:28 schreef Matt Roper: > >>> Some display controllers can be programmed to

Re: [PATCH v2 12/17] kunit: tool: add Python wrappers for running KUnit tests

2019-05-03 Thread Brendan Higgins
> On 5/2/19 10:36 PM, Brendan Higgins wrote: > > On Thu, May 2, 2019 at 6:45 PM Frank Rowand wrote: > >> > >> On 5/2/19 4:45 PM, Brendan Higgins wrote: > >>> On Thu, May 2, 2019 at 2:16 PM Frank Rowand > >>> wrote: > > On 5/2/19 11:07 AM, Brendan Higgins wrote: > > On Thu, May 2,

[Bug 108893] Slow redrawing of menu in Gothic 2 under wine

2019-05-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108893 --- Comment #12 from andrew.m.mcma...@gmail.com --- (In reply to Michel Dänzer from comment #8) > The video shows very low frame-rate and GPU load in the menu, but high CPU > load. Maybe there's a CPU bottleneck which affects the reporter even

[Bug 110575] [R9 380X] Artifacts in CSGO

2019-05-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110575 Danylo changed: What|Removed |Added CC||danylo.pilia...@gmail.com --- Comment #2 from

Re: [RFC PATCH 0/5] cgroup support for GPU devices

2019-05-03 Thread Welty, Brian
On 5/2/2019 3:48 PM, Kenny Ho wrote: > On 5/2/2019 1:34 AM, Leon Romanovsky wrote: >> Count us (Mellanox) too, our RDMA devices are exposing special and >> limited in size device memory to the users and we would like to provide >> an option to use cgroup to control its exposure. Hi Leon, great

Re: [PATCH 0/4] drm/panfrost: Misc. fixes and cleanups

2019-05-03 Thread Rob Herring
On Fri, May 3, 2019 at 10:31 AM Robin Murphy wrote: > > Hi, > > These are a few trivial fixes and cleanups from playing with the > panfrost kernel driver on an Arm Juno board. Not that anyone has ever > cared much about the built-in GPU on Juno, but it's at least a somewhat > interesting platform

[Bug 109206] Kernel 4.20 amdgpu fails to load firmware on Ryzen 2500U

2019-05-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109206 --- Comment #43 from Talha Khan --- I updated my Fedora KDE spin system from Fedora 29 to Fedora 30 and had the same experience as Jay's. -- You are receiving this mail because: You are the assignee for the

[Bug 110443] vaapi/vpp: wrong output for non 64-bytes align width (ex: 1200)

2019-05-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110443 --- Comment #13 from Julien Isorce --- Thx! -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org

[Bug 110443] vaapi/vpp: wrong output for non 64-bytes align width (ex: 1200)

2019-05-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110443 --- Comment #12 from Viktor Jägersküpper --- I tested the commit in the merge request together with the r600-related change which has already been committed to the master branch, VLC doesn't crash any more. -- You are receiving this mail

[Bug 108750] Glitchy Interface on Origin when using radeonsi and wined3d

2019-05-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108750 --- Comment #2 from Henri Verbeet --- (In reply to Timothy Arceri from comment #1) > wined3d DX11 support is known to be very buggy. Just use dxvk. With DXVK effectively being a Valve project I can understand your personal preference, but I

Re: [PATCHv2 03/22] drm/bridge: tc358767: fix ansi 8b10b use

2019-05-03 Thread Laurent Pinchart
Hi Tomi, On Fri, May 03, 2019 at 04:17:41PM +0300, Tomi Valkeinen wrote: > On 03/05/2019 15:48, Laurent Pinchart wrote: > > On Fri, May 03, 2019 at 02:43:51PM +0300, Tomi Valkeinen wrote: > >> On 23/04/2019 17:56, Laurent Pinchart wrote: > >> > During initial driver development I had one eDP

[Bug 108893] Slow redrawing of menu in Gothic 2 under wine

2019-05-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108893 --- Comment #11 from supercoolem...@seznam.cz --- Ok, so I started the game and attached perf to it by PID, waited a minute and stopped perf with CTRL+C. Here it is: perf report --stdio 45.80% Gothic2.exe wined3d.dll.so [.]

[Bug 201273] Fatal error during GPU init amdgpu RX560

2019-05-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201273 --- Comment #53 from Marco (rodomar...@protonmail.com) --- For the first time it has triggered while I was using the system after some time; and as imagined the system disappear from the network, so no dmesg available. I'll try without DC enabled

Re: [PATCH] drm/virtio: Remove redundant return type

2019-05-03 Thread Chia-I Wu
On Fri, May 3, 2019 at 9:38 AM Robert Foss wrote: > > virtio_gpu_fence_emit() always returns 0, since it > has no error paths. > > Consequently no calls for virtio_gpu_fence_emit() > use the return value, and it can be removed. > > Signed-off-by: Robert Foss > Suggested-by: Emil Velikov

[PATCH] drm/virtio: Remove redundant return type

2019-05-03 Thread Robert Foss
virtio_gpu_fence_emit() always returns 0, since it has no error paths. Consequently no calls for virtio_gpu_fence_emit() use the return value, and it can be removed. Signed-off-by: Robert Foss Suggested-by: Emil Velikov --- This patch was suggested in this email thread: [PATCH] drm/virtio:

[Bug 109345] drm-next-2018-12-14 -Linux PPC

2019-05-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109345 --- Comment #28 from Christian Zigotzky --- Hi All, Allan successfully tested the second test kernel today. He wrote: Christian DRM2 BINGO, boots to Firepro! ace -- This step has been marked as good. git bisect good Output:

[Bug 108893] Slow redrawing of menu in Gothic 2 under wine

2019-05-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108893 --- Comment #10 from Michel Dänzer --- (In reply to supercoolemail from comment #9) > Output of perf (if you want anything more, e.g. full perf.data or something, > I'll deliver): AFAIK perf.data generally won't be useful outside of your

Re: [git pull] drm fixes for final

2019-05-03 Thread pr-tracker-bot
The pull request you sent on Fri, 3 May 2019 11:01:07 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2019-05-03 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/a4ccb5f9dc6c4fb4d4c0a9d73a911986f20ec88a Thank you! -- Deet-doot-dot, I am a bot.

[Bug 108893] Slow redrawing of menu in Gothic 2 under wine

2019-05-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108893 --- Comment #9 from supercoolem...@seznam.cz --- I am on 19.0.3. The game used to run quite well from what I remeber and I could navigate the menu. Now it's horrible and when I want to change something in menu, I need LIBGL_ALWAYS_SOFTWARE=1,

Re: [PATCH v2] drm/bridge/synopsys: dsi: Allow VPG to be enabled via debugfs

2019-05-03 Thread Philippe CORNU
Hi Matt, and many thanks for the patch. Tested successfully by Yannick on STM32MP1 boards :-) Tested-by: Yannick Fertré Reviewed-by: Philippe Cornu Thank you, Philippe :-) On 4/30/19 10:17 AM, Matt Redfearn wrote: > The Synopsys MIPI DSI IP contains a video test pattern generator which > is

[PATCH 4/4] drm/panfrost: Show stored feature registers

2019-05-03 Thread Robin Murphy
Re-reading the feature registers for the sake of displaying the raw values seems pointless, and in fact showing the copies that we've already read and stored is arguably more useful in terms of giving exposure to any potential bugs in that part of the process. Signed-off-by: Robin Murphy ---

[PATCH 3/4] drm/panfrost: Don't scream about deferred probe

2019-05-03 Thread Robin Murphy
Probe deferral is far from "fatal". Signed-off-by: Robin Murphy --- drivers/gpu/drm/panfrost/panfrost_drv.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c index

[RFC 5/4] arm64: dts: juno: add GPU subsystem

2019-05-03 Thread Robin Murphy
Since we now have bindings for Mali Midgard GPUs, let's use them to describe Juno's GPU subsystem, if only because we can. Juno sports a Mali-T624 integrated behind an MMU-400 (as a gesture towards virtualisation), in their own dedicated power domain with DVFS controlled by the SCP.

[PATCH 2/4] drm/panfrost: Disable PM on probe failure

2019-05-03 Thread Robin Murphy
Make sure to disable runtime PM again if probe fails after we've enabled it. Otherwise, any subsequent attempt to re-probe starts triggering "Unbalanced pm_runtime_enable!" assertions from the driver core. Signed-off-by: Robin Murphy --- drivers/gpu/drm/panfrost/panfrost_drv.c | 1 + 1 file

[PATCH 1/4] drm/panfrost: Set DMA masks earlier

2019-05-03 Thread Robin Murphy
The DMA masks need to be set correctly before any DMA API activity kicks off, and the current point in panfrost_probe() is way too late in that regard. since panfrost_mmu_init() has already set up a live address space and DMA-mapped MMU pagetables. We can't set masks until we've queried the

[PATCH 0/4] drm/panfrost: Misc. fixes and cleanups

2019-05-03 Thread Robin Murphy
Hi, These are a few trivial fixes and cleanups from playing with the panfrost kernel driver on an Arm Juno board. Not that anyone has ever cared much about the built-in GPU on Juno, but it's at least a somewhat interesting platform from the kernel driver perspective for having I/O coherency, RAM

[Bug 109835] [865G] [drm] GPU HANG: ecode 2:0:0x75f4003e, in europa.exe [1323], reason: hang on rcs0, action: reset

2019-05-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109835 --- Comment #3 from rtent...@yandex.ru --- I've lied, i have 865GV. With this motherboard: https://www.asrock.com/mb/Intel/P4i65GV/index.asp Also, LIBGL_ALWAYS_SOFTWARE is a workaround for the problem. But it works very slow. -- You are

Re: [PATCH 1/3] drm/virtio: set seqno for dma-fence

2019-05-03 Thread Emil Velikov
Hi Chia-I, On Mon, 29 Apr 2019 at 23:08, Chia-I Wu wrote: > > This is motivated by having meaningful ftrace events, but it also > fixes use cases where dma_fence_is_later is called, such as in > sync_file_merge. > > In other drivers, fence creation and cmdbuf submission normally > happen

Re: [PATCH] drm/virtio: allocate fences with GFP_KERNEL

2019-05-03 Thread Robert Foss
On 03.05.19 16:31, Emil Velikov wrote: On Mon, 29 Apr 2019 at 23:10, Chia-I Wu wrote: It was changed to GFP_ATOMIC in commit ec2f0577c (add & use virtio_gpu_queue_fenced_ctrl_buffer) because the allocation happened with a spinlock held. That was no longer true after commit 9fdd90c0f (add

Re: [PATCH] drm/komeda: Potential error pointer dereference

2019-05-03 Thread Liviu Dudau
On Fri, May 03, 2019 at 03:25:25PM +0300, Dan Carpenter wrote: > We need to check whether drm_atomic_get_crtc_state() returns an error > pointer before dereferencing "crtc_st". > > Fixes: 7d31b9e7a550 ("drm/komeda: Add komeda_plane/plane_helper_funcs") > Signed-off-by: Dan Carpenter Acked-by:

Re: [PATCH v2 15/17] MAINTAINERS: add entry for KUnit the unit testing framework

2019-05-03 Thread shuah
On 5/1/19 5:01 PM, Brendan Higgins wrote: Add myself as maintainer of KUnit, the Linux kernel's unit testing framework. Signed-off-by: Brendan Higgins --- MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5c38f21aee787..c78ae95c56b80

Re: [PATCH] drm/virtio: allocate fences with GFP_KERNEL

2019-05-03 Thread Emil Velikov
On Mon, 29 Apr 2019 at 23:10, Chia-I Wu wrote: > > It was changed to GFP_ATOMIC in commit ec2f0577c (add & use > virtio_gpu_queue_fenced_ctrl_buffer) because the allocation happened > with a spinlock held. That was no longer true after commit > 9fdd90c0f (add virtio_gpu_alloc_fence()). > >

Re: [PATCH v2 11/17] kunit: test: add test managed resource tests

2019-05-03 Thread shuah
On 5/1/19 5:01 PM, Brendan Higgins wrote: From: Avinash Kondareddy Tests how tests interact with test managed resources in their lifetime. Signed-off-by: Avinash Kondareddy Signed-off-by: Brendan Higgins --- I think this change log could use more details. It is vague on what it does.

Re: [PATCH v3 01/10] drm: Add atomic variants of enable/disable to encoder helper funcs

2019-05-03 Thread Daniel Vetter
On Fri, May 3, 2019 at 2:34 PM Sean Paul wrote: > > On Fri, May 03, 2019 at 09:51:30AM +0200, Daniel Vetter wrote: > > On Thu, May 02, 2019 at 03:49:43PM -0400, Sean Paul wrote: > > > From: Sean Paul > > > > > > This patch adds atomic_enable and atomic_disable callbacks to the > > > encoder

Re: [PATCH v3 02/10] drm: Add drm_atomic_crtc_state_for_encoder helper

2019-05-03 Thread Daniel Vetter
On Fri, May 3, 2019 at 2:47 PM Sean Paul wrote: > On Fri, May 03, 2019 at 10:18:51AM +0200, Daniel Vetter wrote: > > On Thu, May 02, 2019 at 03:49:44PM -0400, Sean Paul wrote: > > > From: Sean Paul > > > > > > This patch adds a helper to tease out the currently connected crtc for > > > an

Re: [PATCH] backlight: rave-sp: don't touch initial state and register with correct device

2019-05-03 Thread Daniel Thompson
On Thu, May 02, 2019 at 02:01:45PM +0200, Lucas Stach wrote: > Hi Daniel, > > Am Donnerstag, den 02.05.2019, 11:33 +0100 schrieb Daniel Thompson: > > On 29/04/2019 16:29, Lucas Stach wrote: > > > This way the backlight can be referenced through its device node and > > > enabling/disabling can be

Re: [PATCH v3 01/19] drm: Add |struct drm_gem_vram_object| and helpers

2019-05-03 Thread Thomas Zimmermann
Am 03.05.19 um 14:27 schrieb Thomas Zimmermann: > cc: nor...@tronnes.org Actually cc him > Am 03.05.19 um 14:07 schrieb Koenig, Christian: >> Am 03.05.19 um 14:01 schrieb Daniel Vetter: >>> [CAUTION: External Email] >>> >>> On Fri, May 3, 2019 at 12:15 PM Thomas Zimmermann >>> wrote: Hi

Re: [PATCHv2 03/22] drm/bridge: tc358767: fix ansi 8b10b use

2019-05-03 Thread Tomi Valkeinen
On 03/05/2019 15:48, Laurent Pinchart wrote: > Hi Tomi, > > On Fri, May 03, 2019 at 02:43:51PM +0300, Tomi Valkeinen wrote: >> On 23/04/2019 17:56, Laurent Pinchart wrote: >> During initial driver development I had one eDP display that reports 0 in Bit 0 (ANSI 8B/10B) of DPCD reg

Re: [PATCHv2 08/22] drm/bridge: tc358767: split stream enable/disable

2019-05-03 Thread Tomi Valkeinen
On 03/05/2019 15:55, Laurent Pinchart wrote: - if (state) { - ret = tc_set_video_mode(tc, tc->mode); - if (ret) - goto err; + ret = tc_set_video_mode(tc, tc->mode); + if (ret) + goto err; >>> >>> Let's return

Re: [PATCHv2 16/22] drm/bridge: tc358767: remove check for video mode in link enable

2019-05-03 Thread Laurent Pinchart
Hi Tomi, On Fri, May 03, 2019 at 11:10:54AM +0300, Tomi Valkeinen wrote: > On 21/04/2019 01:14, Laurent Pinchart wrote: > > On Tue, Mar 26, 2019 at 12:31:40PM +0200, Tomi Valkeinen wrote: > >> tc_main_link_enable() checks if videomode has been set, and fails if > >> there's no videomode. As

Re: [PATCHv2 08/22] drm/bridge: tc358767: split stream enable/disable

2019-05-03 Thread Laurent Pinchart
Hi Tomi, On Fri, May 03, 2019 at 12:20:49PM +0300, Tomi Valkeinen wrote: > On 21/04/2019 00:29, Laurent Pinchart wrote: > > On Tue, Mar 26, 2019 at 12:31:32PM +0200, Tomi Valkeinen wrote: > >> It is nicer to have enable/disable functions instead of set(bool enable) > >> style function. > > > >

Re: [PATCHv2 03/22] drm/bridge: tc358767: fix ansi 8b10b use

2019-05-03 Thread Laurent Pinchart
Hi Tomi, On Fri, May 03, 2019 at 02:43:51PM +0300, Tomi Valkeinen wrote: > On 23/04/2019 17:56, Laurent Pinchart wrote: > > >> During initial driver development I had one eDP display that reports 0 in > >> Bit 0 > >> (ANSI 8B/10B) of DPCD reg 0x0006 (MAIN_LINK_CHANNEL_CODING). > >> Also it does

[Bug 110600] [IGT runner] be more consistent with checks on display/outputs

2019-05-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110600 Bug ID: 110600 Summary: [IGT runner] be more consistent with checks on display/outputs Product: DRI Version: DRI git Hardware: Other OS: All

Re: [PATCH v3 02/10] drm: Add drm_atomic_crtc_state_for_encoder helper

2019-05-03 Thread Sean Paul
On Fri, May 03, 2019 at 10:18:51AM +0200, Daniel Vetter wrote: > On Thu, May 02, 2019 at 03:49:44PM -0400, Sean Paul wrote: > > From: Sean Paul > > > > This patch adds a helper to tease out the currently connected crtc for > > an encoder, along with its state. This follows the same pattern as

[Bug 110599] [IGT runner] Per-test external watchdog

2019-05-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110599 Bug ID: 110599 Summary: [IGT runner] Per-test external watchdog Product: DRI Version: DRI git Hardware: Other OS: All Status: NEW Severity: normal

[PATCHv3 23/23] dt-bindings: tc358767: add HPD support

2019-05-03 Thread Tomi Valkeinen
Add DT property for defining the pin used for HPD. Signed-off-by: Tomi Valkeinen Cc: devicet...@vger.kernel.org Cc: Rob Herring Reviewed-by: Rob Herring --- .../devicetree/bindings/display/bridge/toshiba,tc358767.txt | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCHv3 20/23] drm/bridge: tc358767: copy the mode data, instead of storing the pointer

2019-05-03 Thread Tomi Valkeinen
In tc_bridge_mode_set callback, we store the pointer to the given drm_display_mode, and use the mode later. Storing a pointer in such a way looks very suspicious to me, and I have observed odd issues where the timings were apparently (at least mostly) zero. Do a copy of the drm_display_mode

Re: [PATCH v3 01/10] drm: Add atomic variants of enable/disable to encoder helper funcs

2019-05-03 Thread Sean Paul
On Fri, May 03, 2019 at 09:51:30AM +0200, Daniel Vetter wrote: > On Thu, May 02, 2019 at 03:49:43PM -0400, Sean Paul wrote: > > From: Sean Paul > > > > This patch adds atomic_enable and atomic_disable callbacks to the > > encoder helpers. This will allow encoders to make informed decisions in >

[PATCHv3 13/23] drm/bridge: tc358767: remove unnecessary msleep

2019-05-03 Thread Tomi Valkeinen
For some reason the driver has a msleep(100) after writing to DP_PHY_CTRL. Toshiba's documentation doesn't suggest any delay is needed, and I have not seen any issues with the sleep removed. Drop it, as msleep(100) is a rather big one. Signed-off-by: Tomi Valkeinen Reviewed-by: Andrzej Hajda

[PATCHv3 18/23] drm/bridge: tc358767: use bridge mode_valid

2019-05-03 Thread Tomi Valkeinen
We have tc_connector_mode_valid() to filter out videomdoes that the tc358767 cannot support. As it is a bridge limitation, change the code to use drm_bridge_funcs's mode_valid instead. Signed-off-by: Tomi Valkeinen Reviewed-by: Andrzej Hajda Reviewed-by: Laurent Pinchart ---

[PATCHv3 21/23] drm/bridge: tc358767: add GPIO & interrupt registers

2019-05-03 Thread Tomi Valkeinen
Add GPIO and interrupt related registers for HPD work. Mark INTSTS_G and GPIOI as volatile. Signed-off-by: Tomi Valkeinen Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/bridge/tc358767.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/bridge/tc358767.c

[PATCHv3 16/23] drm/bridge: tc358767: clean-up link training

2019-05-03 Thread Tomi Valkeinen
The current link training code does unnecessary retry-loops, and does extra writes to the registers. It is easier to follow the flow and ensure it's similar to Toshiba's documentation if we deal with LT inside tc_main_link_enable() function. This patch adds tc_wait_link_training() which handles

Re: [PATCH 10/12] drm/amdgpu: add independent DMA-buf export v3

2019-05-03 Thread Christian König
Am 30.04.19 um 16:16 schrieb Daniel Vetter: [SNIP] /** - * amdgpu_gem_map_attach - _buf_ops.attach implementation - * @dma_buf: Shared DMA buffer + * amdgpu_gem_pin_dma_buf - _buf_ops.pin_dma_buf implementation + * + * @dma_buf: DMA-buf to pin in memory + * + * Pin the BO which is backing the

[PATCHv3 22/23] drm/bridge: tc358767: add IRQ and HPD support

2019-05-03 Thread Tomi Valkeinen
Add support for interrupt and hotplug handling. Both are optional. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/tc358767.c | 166 ++ 1 file changed, 148 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c

[PATCHv3 14/23] drm/bridge: tc358767: use more reliable seq when finishing LT

2019-05-03 Thread Tomi Valkeinen
At the end of the link training, two steps have to be taken: 1) tc358767's LT mode is disabled by a write to DP0_SRCCTRL, and 2) Remove LT flag in DPCD 0x102. Toshiba's documentation tells to first write the DPCD, then modify DP0_SRCCTRL. In my testing this often causes issues, and the link

[Bug 110214] radeonsi: xterm scrollback buffer disappears while Shift+PgUp and Shift+PgDn

2019-05-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110214 --- Comment #87 from komqin...@zoho.eu --- I have the same bug with xterm and shift+paging. Another similar bug. xfce4-terminal leaves a large black area at the bottom when it renders 'dmesg' or 'cat /etc/passwd'. AMD Ryzen 3 2200G. Arch

[PATCHv3 08/23] drm/bridge: tc358767: split stream enable/disable

2019-05-03 Thread Tomi Valkeinen
It is nicer to have enable/disable functions instead of set(bool enable) style function. Split tc_main_link_stream into tc_stream_enable and tc_stream_disable. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/tc358767.c | 81 +-- 1 file changed, 45

[PATCHv3 11/23] drm/bridge: tc358767: disable only video stream in tc_stream_disable

2019-05-03 Thread Tomi Valkeinen
Currently the code writes 0 to DP0CTL in tc_stream_disable(), which disables the whole DP link instead of just the video stream. We always disable the link and the stream together from tc_bridge_disable(), so this doesn't cause any issues. Nevertheless, fix this by only clearing VID_EN in

[PATCHv3 10/23] drm/bridge: tc358767: add link disable function

2019-05-03 Thread Tomi Valkeinen
Currently we have tc_main_link_setup(), which configures and enabled the link, but we have no counter-part for disabling the link. Add tc_main_link_disable, and rename tc_main_link_setup to tc_main_link_enable. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/tc358767.c | 27

[PATCHv3 17/23] drm/bridge: tc358767: remove check for video mode in link enable

2019-05-03 Thread Tomi Valkeinen
tc_main_link_enable() checks if videomode has been set, and fails if there's no videomode. As tc_main_link_enable() no longer depends on the videomode, we can drop the check. Also, while tc_stream_enable() does depend on the videomode, we can expect that a mode has been set before

[PATCHv3 19/23] drm/bridge: tc358767: remove tc_connector_best_encoder

2019-05-03 Thread Tomi Valkeinen
drm_connector_helper_funcs.best_encoder is only needed when the connector can have more than one encoder, and that is never the case here. So remove tc_connector_best_encoder. Signed-off-by: Tomi Valkeinen Reviewed-by: Andrzej Hajda Reviewed-by: Laurent Pinchart ---

[PATCHv3 12/23] drm/bridge: tc358767: ensure DP is disabled before LT

2019-05-03 Thread Tomi Valkeinen
Link training will sometimes fail if the DP link is enabled when tc_main_link_enable() is called. The driver makes sure the DP link is disabled when the DP output is disabled, and we never enable the DP without first disabling it, so this should never happen. However, as the HW behavior seems to

[PATCHv3 09/23] drm/bridge: tc358767: move PXL PLL enable/disable to stream enable/disable

2019-05-03 Thread Tomi Valkeinen
We set up the PXL PLL inside tc_main_link_setup. This is unnecessary, and makes tc_main_link_setup depend on the video-mode, which should not be the case. As PXL PLL is used only for the video stream (and only when using the HW test pattern), let's move the PXL PLL setup into tc_stream_enable.

[PATCHv3 15/23] drm/bridge: tc358767: cleanup LT result check

2019-05-03 Thread Tomi Valkeinen
The driver has a loop after ending link training, where it reads the DPCD link status and prints an error if that status is not ok. The loop is unnecessary, as far as I can understand from DP specs, so let's remove it. We can also print the more specific errors to help debugging. Signed-off-by:

[PATCHv3 04/23] drm/bridge: tc358767: cleanup spread & scrambler_dis

2019-05-03 Thread Tomi Valkeinen
Minor cleanups: - Use bool for boolean fields - Use DP_MAX_DOWNSPREAD_0_5 instead of BIT(0) - debug print down-spread and scrambler status Signed-off-by: Tomi Valkeinen Reviewed-by: Andrzej Hajda Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/bridge/tc358767.c | 13 - 1 file

[PATCHv3 07/23] drm/bridge: tc358767: move video stream setup to tc_main_link_stream

2019-05-03 Thread Tomi Valkeinen
The driver currently sets the video stream registers in tc_main_link_setup. One should be able to establish the DP link without any video stream, so a more logical place is to configure the stream in the tc_main_link_stream. So move them there. Signed-off-by: Tomi Valkeinen Reviewed-by: Andrzej

[PATCHv3 06/23] drm/bridge: tc358767: cleanup aux_link_setup

2019-05-03 Thread Tomi Valkeinen
The driver sets up AUX link at probe time, but, for some reason, also sets the main link's number of lanes using tc->link.base.num_lanes. This is not needed nor correct, as the number of lanes has not been decided yet. The number of lanes will be set later during main link setup. Modify

[PATCHv3 01/23] drm/bridge: tc358767: fix tc_aux_get_status error handling

2019-05-03 Thread Tomi Valkeinen
tc_aux_get_status() does not report AUX_TIMEOUT correctly, as it only checks the AUX_TIMEOUT if aux is still busy. Fix this by always checking for AUX_TIMEOUT. Signed-off-by: Tomi Valkeinen Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/bridge/tc358767.c | 11 +++ 1 file changed, 7

[PATCHv3 02/23] drm/bridge: tc358767: reset voltage-swing & pre-emphasis

2019-05-03 Thread Tomi Valkeinen
We need to reset DPCD voltage-swing & pre-emphasis before starting the link training, as otherwise tc358767 will use the previous values as minimums. Signed-off-by: Tomi Valkeinen Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/bridge/tc358767.c | 7 +++ 1 file changed, 7 insertions(+)

[PATCHv3 00/23] drm/bridge: tc358767: DP support

2019-05-03 Thread Tomi Valkeinen
Hi, tc358767 bridge was originally implemented for eDP use with an embedded panel. I've been working to add DP and HPD support, and this series is the result. I did have a lot of issues with link training, but with these, it's been working reliably with my devices. Changes in v2 * Drop

[PATCHv3 03/23] drm/bridge: tc358767: fix ansi 8b10b use

2019-05-03 Thread Tomi Valkeinen
DP always uses ANSI 8B10B encoding. Some monitors (old?) may not have the ANSI 8B10B bit set in DPCD, even if it should always be set. The tc358767 driver currently respects that flag, and turns the encoding off if the monitor does not have the bit set, which then results in the monitor not

[PATCHv3 05/23] drm/bridge: tc358767: remove unused swing & preemp

2019-05-03 Thread Tomi Valkeinen
swing and preemp fields are not used. Remove them. Signed-off-by: Tomi Valkeinen Reviewed-by: Andrzej Hajda Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/bridge/tc358767.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c

[Bug 109124] [AMD][TAHITI XT] csgo new battle royal mode bad performance

2019-05-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109124 Sylvain BERTRAND changed: What|Removed |Added Resolution|NOTABUG |NOTOURBUG --- Comment #5 from

Re: [PATCH v3 01/19] drm: Add |struct drm_gem_vram_object| and helpers

2019-05-03 Thread Thomas Zimmermann
cc: nor...@tronnes.org Am 03.05.19 um 14:07 schrieb Koenig, Christian: > Am 03.05.19 um 14:01 schrieb Daniel Vetter: >> [CAUTION: External Email] >> >> On Fri, May 3, 2019 at 12:15 PM Thomas Zimmermann >> wrote: >>> Hi Christian, >>> >>> would you review the whole patch set? Daniel mentioned

[PATCH] drm/komeda: Potential error pointer dereference

2019-05-03 Thread Dan Carpenter
We need to check whether drm_atomic_get_crtc_state() returns an error pointer before dereferencing "crtc_st". Fixes: 7d31b9e7a550 ("drm/komeda: Add komeda_plane/plane_helper_funcs") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/arm/display/komeda/komeda_plane.c | 2 +- 1 file changed, 1

Re: [PULL] 2nd pull for malidp-next

2019-05-03 Thread Daniel Vetter
On Fri, May 03, 2019 at 10:29:48AM +0100, Liviu Dudau wrote: > On Fri, May 03, 2019 at 11:15:23AM +0200, Daniel Vetter wrote: > > On Fri, May 3, 2019 at 11:11 AM Liviu Dudau wrote: > > > > > > On Fri, May 03, 2019 at 09:54:35AM +1000, Dave Airlie wrote: > > > > On Thu, 2 May 2019 at 20:45, Liviu

Re: [Intel-gfx] [PATCH] dma-buf: add struct dma_buf_attach_info v2

2019-05-03 Thread Koenig, Christian
Am 03.05.19 um 14:09 schrieb Daniel Vetter: > [CAUTION: External Email] > > On Fri, May 03, 2019 at 02:05:47PM +0200, Christian König wrote: >> Am 30.04.19 um 19:31 schrieb Russell King - ARM Linux admin: >>> On Tue, Apr 30, 2019 at 01:10:02PM +0200, Christian König wrote: Add a structure for

Re: [Intel-gfx] [PATCH] dma-buf: add struct dma_buf_attach_info v2

2019-05-03 Thread Daniel Vetter
On Fri, May 03, 2019 at 02:05:47PM +0200, Christian König wrote: > Am 30.04.19 um 19:31 schrieb Russell King - ARM Linux admin: > > On Tue, Apr 30, 2019 at 01:10:02PM +0200, Christian König wrote: > > > Add a structure for the parameters of dma_buf_attach, this makes it much > > > easier > > > to

Re: [PATCH v3 01/19] drm: Add |struct drm_gem_vram_object| and helpers

2019-05-03 Thread Koenig, Christian
Am 03.05.19 um 14:01 schrieb Daniel Vetter: > [CAUTION: External Email] > > On Fri, May 3, 2019 at 12:15 PM Thomas Zimmermann wrote: >> Hi Christian, >> >> would you review the whole patch set? Daniel mentioned that he'd prefer >> to leave the review to memory-mgmt developers. > I think Noralf

Re: [PATCH] dma-buf: add struct dma_buf_attach_info v2

2019-05-03 Thread Christian König
Am 30.04.19 um 19:31 schrieb Russell King - ARM Linux admin: On Tue, Apr 30, 2019 at 01:10:02PM +0200, Christian König wrote: Add a structure for the parameters of dma_buf_attach, this makes it much easier to add new parameters later on. I don't understand this reasoning. What are the "new

Re: [PATCH v3 01/19] drm: Add |struct drm_gem_vram_object| and helpers

2019-05-03 Thread Daniel Vetter
On Fri, May 3, 2019 at 12:15 PM Thomas Zimmermann wrote: > > Hi Christian, > > would you review the whole patch set? Daniel mentioned that he'd prefer > to leave the review to memory-mgmt developers. I think Noralf Tronnes or Gerd Hoffmann would also make good reviewers for this, fairly close to

Re: [linux-sunxi] [PATCH v4 5/9] arm64: dts: allwinner: orange-pi-3: Enable ethernet

2019-05-03 Thread Jagan Teki
On Sat, Apr 13, 2019 at 10:24 PM megous via linux-sunxi wrote: > > From: Ondrej Jirman > > Orange Pi 3 has two regulators that power the Realtek RTL8211E. According > to the phy datasheet, both regulators need to be enabled at the same time, > but we can only specify a single phy-supply in the

Re: [PATCH libdrm] xf86drm: Fix possible memory leak with drmModeGetPropertyPtr()

2019-05-03 Thread Eric Engestrom
On Monday, 2019-04-29 18:10:52 +0900, Seung-Woo Kim wrote: > In drmModeGetPropertyPtr(), from upper error path, it calls free > but with just next error path, it does not call. Fix the possible > memory leak. > > Signed-off-by: Seung-Woo Kim Reviewed-by: Eric Engestrom and pushed, thanks! >

Re: [PATCHv2 03/22] drm/bridge: tc358767: fix ansi 8b10b use

2019-05-03 Thread Tomi Valkeinen
On 23/04/2019 17:56, Laurent Pinchart wrote: >> During initial driver development I had one eDP display that reports 0 in >> Bit 0 >> (ANSI 8B/10B) of DPCD reg 0x0006 (MAIN_LINK_CHANNEL_CODING). >> Also it does not react on setting Bit 0 (SET_ANSI 8B10B) in 0x0108 >>

[Bug 110598] [IGT runner] allow tests to attach test-specific results

2019-05-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110598 Bug ID: 110598 Summary: [IGT runner] allow tests to attach test-specific results Product: DRI Version: DRI git Hardware: Other OS: All Status:

[Bug 110597] [IGT runner] allow attachments to results.json

2019-05-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110597 Bug ID: 110597 Summary: [IGT runner] allow attachments to results.json Product: DRI Version: DRI git Hardware: Other OS: All Status: NEW Severity:

[Bug 110598] [IGT runner] allow tests to attach test-specific results

2019-05-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110598 Martin Peres changed: What|Removed |Added Depends on||110597 Referenced Bugs:

[Bug 110597] [IGT runner] allow attachments to results.json

2019-05-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110597 Martin Peres changed: What|Removed |Added Blocks||110598 Referenced Bugs:

Re: [PATCH v2 0/8] per-process address spaces for MMUv2

2019-05-03 Thread Guido Günther
Hi Lucas, On Wed, Apr 17, 2019 at 03:50:15PM +0200, Lucas Stach wrote: > > Hi all, > > v1 cover letter: > > the following patches finally implement one of the longstanding TODO > items in the etnaviv driver: per-process address spaces. They are only > enabled for MMUv2, as switching the MMU

Re: [PATCHv2 13/22] drm/bridge: tc358767: use more reliable seq when finishing LT

2019-05-03 Thread Tomi Valkeinen
On 21/04/2019 00:44, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Tue, Mar 26, 2019 at 12:31:37PM +0200, Tomi Valkeinen wrote: >> At the end of the link training, two steps have to be taken: 1) >> tc358767's LT mode is disabled by a write to DP0_SRCCTRL, and 2) Remove

[Bug 109345] drm-next-2018-12-14 -Linux PPC

2019-05-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109345 --- Comment #27 from Christian Zigotzky --- Hi All, Allan tested the first test kernel today. He wrote: Hi Christian The kernel boots but to SI card. Cheers ace -- That means, this step has been marked as bad. git bisect bad Output:

Re: [PATCHv2 14/22] drm/bridge: tc358767: cleanup LT result check

2019-05-03 Thread Tomi Valkeinen
On 21/04/2019 01:06, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Tue, Mar 26, 2019 at 12:31:38PM +0200, Tomi Valkeinen wrote: >> The driver has a loop after ending link training, where it reads the >> DPCD link status and prints an error if that status is not ok. >> >>

Re: [RFC][PATCH 0/3] mesa: Initial build fixups for AOSP/master

2019-05-03 Thread Emil Velikov
On Thu, 2 May 2019 at 23:19, Rob Clark wrote: > > On Thu, May 2, 2019 at 2:57 PM Dan Willemsen wrote: > > > > On Thu, May 2, 2019 at 1:52 PM John Stultz wrote: > > > > > > We need solutions for the xgettext and the python-mako usage. > > > > Android doesn't support translations at this level,

[Bug 201273] Fatal error during GPU init amdgpu RX560

2019-05-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201273 --- Comment #52 from Marco (rodomar...@protonmail.com) --- (In reply to Marco from comment #51) > (In reply to Alex Deucher from comment #49) > > Can you still log in remotely via ssh and get an updated dmesg? If it's a > > blank screen, can you

[Bug 201273] Fatal error during GPU init amdgpu RX560

2019-05-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201273 --- Comment #51 from Marco (rodomar...@protonmail.com) --- (In reply to Alex Deucher from comment #49) > Can you still log in remotely via ssh and get an updated dmesg? If it's a > blank screen, can you try another display connector on the

  1   2   >