[Bug 110702] segfault in radeonsi HEVC hardware decoding with yuv420p10le

2019-06-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110702 --- Comment #8 from Owen --- I believe this file is also triggering the crash condition. http://www.users.on.net/~ostickley/snip.mkv -- You are receiving this mail because: You are the assignee for the

Re: [PATCH 1/2] drm/vkms: Use index instead of 0 in possible crtc

2019-06-17 Thread Simon Ser
On Tuesday, June 18, 2019 5:19 AM, Rodrigo Siqueira wrote: > I made the patch, but when I started to write the commit message, I just > realized that I did not understand why possible_crtcs should not be > equal zero. Why can we not use zero? Hi, possible_crtcs is a bitfield. If it's zero, it

Re: [v2] drm/komeda: Make Komeda interrupts shareable

2019-06-17 Thread james qian wang (Arm Technology China)
On Thu, Jun 13, 2019 at 03:13:10PM +, Ayan Halder wrote: > Komeda interrupts may be shared with other hardware blocks. > One needs to use devm_request_irq() with IRQF_SHARED to create a shared > interrupt handler. > As a result of not using drm_irq_install() api, one needs to set > "(struct

Re: [RFC/WIP] drm/rockchip: Support CRTC gamma LUT

2019-06-17 Thread Ezequiel Garcia
On Mon, 2019-06-17 at 12:06 +0200, Jacopo Mondi wrote: > Hi Ezequiel, >one small question, as I'm working on supporting gamma LUT for > rcar-du as well, and there's one point not totally clear to me > > > On Thu, Jun 13, 2019 at 04:22:44PM -0300, Ezequiel Garcia wrote: > > Add CRTC gamma LUT

Re: [Xen-devel] [PATCH 38/59] drm/xen: Drop drm_gem_prime_export/import

2019-06-17 Thread Oleksandr Andrushchenko
On 6/14/19 11:35 PM, Daniel Vetter wrote: They're the default. Aside: Would be really nice to switch the others over to drm_gem_object_funcs. Signed-off-by: Daniel Vetter Cc: Oleksandr Andrushchenko Cc: xen-de...@lists.xenproject.org Reviewed-by: Oleksandr Andrushchenko ---

Re: [PATCH 07/59] drm/arm/komeda: Remove DRIVER_HAVE_IRQ

2019-06-17 Thread james qian wang (Arm Technology China)
On Tue, Jun 18, 2019 at 12:41:32PM +0800, James (Qian) Wang wrote: > On Mon, Jun 17, 2019 at 03:43:45PM +0200, Daniel Vetter wrote: > > On Mon, Jun 17, 2019 at 06:26:08AM +, james qian wang (Arm Technology > > China) wrote: > > > On Fri, Jun 14, 2019 at 10:35:23PM +0200, Daniel Vetter wrote:

Re: [PATCH 40/59] drm/vram-helper: Drop drm_gem_prime_export/import

2019-06-17 Thread Gerd Hoffmann
Hi, > > While most callbacks are pretty straight forward (just hook the same > > callbacks into the drm_gem_object_funcs. struct) the mmap bits are a > > bit more obscure. > > > > First, there seem to be two ways to mmap a gem buffer: > > > > (1) drm_driver->fops->mmap, and > > (2)

Re: [PATCH 07/59] drm/arm/komeda: Remove DRIVER_HAVE_IRQ

2019-06-17 Thread james qian wang (Arm Technology China)
On Mon, Jun 17, 2019 at 03:43:45PM +0200, Daniel Vetter wrote: > On Mon, Jun 17, 2019 at 06:26:08AM +, james qian wang (Arm Technology > China) wrote: > > On Fri, Jun 14, 2019 at 10:35:23PM +0200, Daniel Vetter wrote: > > > Read the docs, komeda is not an old enough driver for this :-) > > >

Re: [PATCH 00/10] drm/vkms: rework crc worker

2019-06-17 Thread Rodrigo Siqueira
On 06/12, Daniel Vetter wrote: > On Wed, Jun 12, 2019 at 10:28:41AM -0300, Rodrigo Siqueira wrote: > > Hi Daniel, > > > > First of all, thank you very much for your patchset. > > > > I tried to make a detailed review of your series, and you can see my > > comments in each patch. You’ll notice

[PATCH V2 5/5] drm/vkms: Add support for writeback

2019-06-17 Thread Rodrigo Siqueira
This patch implements the necessary functions to add writeback support for vkms. This feature is useful for testing compositors if you don't have hardware with writeback support. Change in V2: - Rework signal completion (Brian) - Integrates writeback with active_planes (Daniel) - Compose cursor

[PATCH V2 4/5] drm/vkms: Use index instead of 0 in possible crtc

2019-06-17 Thread Rodrigo Siqueira
When vkms calls drm_universal_plane_init(), it sets 0 for the possible_crtcs parameter which works well for a single encoder and connector; however, this approach is not flexible and does not fit well for vkms. This commit adds an index parameter for vkms_plane_init() which makes code flexible and

[PATCH V2 3/5] drm/vkms: Rename vkms_crc_data to vkms_data

2019-06-17 Thread Rodrigo Siqueira
Rename the struct vkms_crc_data to vkms_data and also remove the CRC prefix from variables that use this struct. Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/vkms/vkms_composer.c | 8 +++ drivers/gpu/drm/vkms/vkms_composer.h | 8 +++ drivers/gpu/drm/vkms/vkms_crc.c | 14

[PATCH V2 2/5] drm/vkms: Rename crc_enabled to composer_enabled

2019-06-17 Thread Rodrigo Siqueira
Rename crc_enabled to composer_enabled since it does more than just compute a CRC. Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/vkms/vkms_crc.c | 2 +- drivers/gpu/drm/vkms/vkms_crtc.c | 2 +- drivers/gpu/drm/vkms/vkms_drv.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)

[PATCH V2 1/5] drm/vkms: Move functions from vkms_crc to vkms_composer

2019-06-17 Thread Rodrigo Siqueira
The vkms_crc file has functions related to compose operations which are not directly associated with CRC. This patch, move those function for a new file named vkms_composer. Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/vkms/Makefile| 9 +++- drivers/gpu/drm/vkms/vkms_composer.c

[PATCH V2 0/5] drm/vkms: Introduces writeback support

2019-06-17 Thread Rodrigo Siqueira
This patchset introduces the writeback support to vkms. As a pre-work, the first set of patches separates part of the code inside vkms_crc to a new file named vkms_composer; this change allows that other parts of the vkms take advantage of composing functions. Next, there's a patch that enables

Re: [PATCH 01/10] drm/vkms: Fix crc worker races

2019-06-17 Thread Rodrigo Siqueira
On 06/12, Daniel Vetter wrote: > On Wed, Jun 12, 2019 at 10:33:11AM -0300, Rodrigo Siqueira wrote: > > On Thu, Jun 6, 2019 at 7:28 PM Daniel Vetter wrote: > > > > > > The issue we have is that the crc worker might fall behind. We've > > > tried to handle this by tracking both the earliest frame

Re: [PATCH 06/10] drm/vkms: flush crc workers earlier in commit flow

2019-06-17 Thread Rodrigo Siqueira
On 06/13, Daniel Vetter wrote: > On Wed, Jun 12, 2019 at 10:42:42AM -0300, Rodrigo Siqueira wrote: > > On Thu, Jun 6, 2019 at 7:28 PM Daniel Vetter wrote: > > > > > > Currently we flush pending crc workers very late in the commit flow, > > > when we destry all the old crtc states. Unfortunately

Re: [PATCH 5/6] soc: qcom: add OCMEM driver

2019-06-17 Thread Rob Clark
On Mon, Jun 17, 2019 at 7:02 PM Brian Masney wrote: > > Hi Rob Clark, > > On Sun, Jun 16, 2019 at 10:41:06AM -0700, Bjorn Andersson wrote: > > > diff --git a/drivers/soc/qcom/ocmem.xml.h b/drivers/soc/qcom/ocmem.xml.h > > > > I would prefer that these lived at the top of the c file, rather than >

Re: [PATCH 1/2] drm/vkms: Use index instead of 0 in possible crtc

2019-06-17 Thread Rodrigo Siqueira
On 06/07, Daniel Vetter wrote: > On Fri, Jun 07, 2019 at 11:37:55AM -0300, Rodrigo Siqueira wrote: > > On Fri, Jun 7, 2019 at 4:40 AM Daniel Vetter wrote: > > > > > > On Thu, Jun 06, 2019 at 07:40:38PM -0300, Rodrigo Siqueira wrote: > > > > When vkms calls drm_universal_plane_init(), it sets 0

Re: [PATCH 3/3] drm/vkms: add crc sources list

2019-06-17 Thread Rodrigo Siqueira
On 06/13, Oleg Vasilev wrote: > Other drivers are able to list crc sources when accessing > /sys/kernel/debug/dri/.../crtc-0/crc/control > > Even though VKMS now supports only 'auto' mode, it is more consistent to > have the list available to the userspace. > > Signed-off-by: Oleg Vasilev > ---

Re: [PATCH] drm/komeda: fix 32-bit komeda_crtc_update_clock_ratio

2019-06-17 Thread james qian wang (Arm Technology China)
On Mon, Jun 17, 2019 at 02:51:04PM +0200, Arnd Bergmann wrote: > clang points out a bug in the clock calculation on 32-bit, that leads > to the clock_ratio always being zero: > > drivers/gpu/drm/arm/display/komeda/komeda_crtc.c:31:36: error: shift count >= > width of type

Re: [PATCH] drm/komeda: fix size_t format string

2019-06-17 Thread james qian wang (Arm Technology China)
On Mon, Jun 17, 2019 at 02:49:18PM +0200, Arnd Bergmann wrote: > The debug output uses the wrong format string for printing a size_t: > > In file included from include/drm/drm_mm.h:49, > from include/drm/drm_vma_manager.h:26, > from include/drm/drm_gem.h:40, >

Re: [PATCH 5/6] soc: qcom: add OCMEM driver

2019-06-17 Thread Brian Masney
Hi Rob Clark, On Sun, Jun 16, 2019 at 10:41:06AM -0700, Bjorn Andersson wrote: > > diff --git a/drivers/soc/qcom/ocmem.xml.h b/drivers/soc/qcom/ocmem.xml.h > > I would prefer that these lived at the top of the c file, rather than > being generated. I think it would be nice to make this change

Re: [PATCH 2/3] drm/vkms: stop generating CRCs on buffer overflow

2019-06-17 Thread Rodrigo Siqueira
Hi Oleg, First of all, thank you for your patchset. On 06/13, Daniel Vetter wrote: > On Thu, Jun 13, 2019 at 03:18:01PM +0300, Oleg Vasilev wrote: > > Because interrupts are generated artifitially, kernel bug may lead to > > infinte attempts to submit CRC. > > > > Signed-off-by: Oleg Vasilev >

[PATCH] drm/bridge/synopsys: dw-hdmi: Handle audio for more clock rates

2019-06-17 Thread Douglas Anderson
Let's add some better support for HDMI audio to dw_hdmi. Specifically: 1. For 44.1 kHz audio the old code made the assumption that an N of 6272 was right most of the time. That wasn't true and the new table should give better 44.1 kHz audio for many more rates. 2. The new table has values from

[Bug 104437] RX480 + SME = amdgpu init failed + null dereference

2019-06-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104437 --- Comment #3 from Nick Sarnie --- Sorry, filed https://bugs.freedesktop.org/show_bug.cgi?id=110929 -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing

[Bug 110929] sw_init of IP block failed -12 when using Secure Memory Encryption (SME) with Vega 64

2019-06-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110929 Bug ID: 110929 Summary: sw_init of IP block failed -12 when using Secure Memory Encryption (SME) with Vega 64 Product: DRI Version: DRI git Hardware: x86-64 (AMD64)

Re: [PATCH 01/59] drm/todo: Improve drm_gem_object funcs todo

2019-06-17 Thread Noralf Trønnes
Den 17.06.2019 23.20, skrev Daniel Vetter: > On Mon, Jun 17, 2019 at 06:54:04PM +0200, Noralf Trønnes wrote: >> >> >> Den 17.06.2019 18.29, skrev Daniel Vetter: >>> On Mon, Jun 17, 2019 at 05:47:50PM +0200, Noralf Trønnes wrote: Den 14.06.2019 22.35, skrev Daniel Vetter: >

Re: [PATCH 1/2] dt-bindings: gpu: add Exynos Mali vendor specifics

2019-06-17 Thread Rob Herring
On Sun, Jun 16, 2019 at 2:16 AM Krzysztof Kozlowski wrote: > > On Fri, Jun 14, 2019 at 01:31:43PM -0700, Joseph Kogut wrote: > > Document vendor specific compatible string for Mali gpus on Exynos SoCs. > > > > Signed-off-by: Joseph Kogut > > --- > >

[Bug 110897] HyperZ is broken for r300 (bad z for some micro and macrotiles?)

2019-06-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110897 Richard Thier changed: What|Removed |Added Attachment #144572|0 |1 is obsolete|

[PATCH v9 2/2] drm/i915: update cursors asynchronously through atomic

2019-06-17 Thread Helen Koike
From: Gustavo Padovan Replace the legacy cursor implementation by the async callbacks Signed-off-by: Gustavo Padovan Signed-off-by: Enric Balletbo i Serra Signed-off-by: Helen Koike --- Changes in v9: - v8: https://patchwork.kernel.org/patch/10843397/ - rebased and fixed conflicts on top

[PATCH v9 1/2] drm/i915: Introduce async plane update to i915

2019-06-17 Thread Helen Koike
From: Gustavo Padovan Add implementation for async plane update callbacks Signed-off-by: Gustavo Padovan Signed-off-by: Enric Balletbo i Serra Signed-off-by: Tina Zhang Signed-off-by: Helen Koike Tested-by: Tina Zhang --- Hi, I tested this patch set with igt (ksm_cursor_legacy and

Re: [PATCH 01/59] drm/todo: Improve drm_gem_object funcs todo

2019-06-17 Thread Daniel Vetter
On Mon, Jun 17, 2019 at 06:54:04PM +0200, Noralf Trønnes wrote: > > > Den 17.06.2019 18.29, skrev Daniel Vetter: > > On Mon, Jun 17, 2019 at 05:47:50PM +0200, Noralf Trønnes wrote: > >> > >> > >> Den 14.06.2019 22.35, skrev Daniel Vetter: > >>> We're kinda going in the wrong direction. Spotted

[PATCH v3 10/10] drm: rcar-du: Centralise routing configuration in commit tail handler

2019-06-17 Thread Laurent Pinchart
Routing configuration for the DU is complex. Depending on the SoC generation various routing options are available: - The VSP to DU routing is not available on Gen1, is configurable on Gen2 and is fixed on Gen3. When configurable, the routing affects both CRTC groups but is set in a register

[PATCH v3 09/10] drm: rcar-du: Perform group setup from the atomic tail handler

2019-06-17 Thread Laurent Pinchart
From: Kieran Bingham Create rcar_du_group_atomic_check() and rcar_du_group_atomic_setup() functions to track and apply group state through the DRM atomic state. The use_count field is moved from the rcar_du_group structure to an enabled field in the rcar_du_group_state structure. This allows

[PATCH v3 06/10] drm: rcar-du: Handle CRTC configuration from commit tail handler

2019-06-17 Thread Laurent Pinchart
From: Kieran Bingham The CRTC mode setting and routing configuration are performed at the earliest of atomic enable and atomic begin, to ensure that a valid configuration is applied to the hardware before the CRTC gets enabled and before planes are setup (the latter being required in particular

[PATCH v3 08/10] drm: rcar-du: Create a group state object

2019-06-17 Thread Laurent Pinchart
From: Kieran Bingham Create a new private state object for the DU groups, and move the initialisation of a group object to a new function rcar_du_group_init(). Signed-off-by: Kieran Bingham Signed-off-by: Laurent Pinchart --- Changes since v2: - Call mutex_destroy() when cleaning up the

[PATCH v3 07/10] drm: rcar-du: Provide for_each_group helper

2019-06-17 Thread Laurent Pinchart
From: Kieran Bingham Refactoring of the group control code will soon require more iteration over the available groups. Simplify this process by introducing a group iteration helper. Signed-off-by: Kieran Bingham Signed-off-by: Laurent Pinchart --- Changes since v2: - Don't assign __group in

[PATCH v3 03/10] drm: rcar-du: Convert to the new VSP atomic API

2019-06-17 Thread Laurent Pinchart
From: Kieran Bingham The configuration API between the VSP and the DU has been updated to provide finer grain control over modesetting, and enablement. Split rcar_du_vsp_enable() into rcar_du_vsp_modeset() and rcar_du_vsp_enable() accordingly, and update each function to use the new VSP API.

[PATCH v3 04/10] media: vsp1: drm: Remove vsp1_du_setup_lif()

2019-06-17 Thread Laurent Pinchart
From: Kieran Bingham The vsp1_du_setup_lif() function is deprecated, and the users have been removed. Remove the implementation and the associated configuration structure. Signed-off-by: Kieran Bingham Signed-off-by: Laurent Pinchart --- drivers/media/platform/vsp1/vsp1_drm.c | 46

[PATCH v3 05/10] drm: rcar-du: Handle CRTC standby from commit tail handler

2019-06-17 Thread Laurent Pinchart
From: Kieran Bingham Manage the power state, and initial configuration of the CRTC from the commit tail handler. CRTCs which need to be activated are taken out of standby, and any deactivated CRTCs are put into standby. This aims at removing CRTC state tracking from the rcar_du_crtc structure.

[PATCH v3 02/10] media: vsp1: drm: Don't configure hardware when the pipeline is disabled

2019-06-17 Thread Laurent Pinchart
The vsp1_du_atomic_flush() function calls vsp1_du_pipeline_configure() to configure the hardware pipeline. The function is currently guaranteed to be called with the pipeline enabled, but this will change by future rework of the DU driver. Guard the hardware configuration to skip it when the

[PATCH v3 00/10] drm: rcar-du: Rework CRTC and groups for atomic commits

2019-06-17 Thread Laurent Pinchart
Hello everybody, This patch series refactors atomic commit tail handling in the R-Car DU driver to simplify the code flow, and open the door to further optimisations. It takes over Kieran's "[PATCH v2 0/6] drm: rcar-du: Rework CRTC and groups for atomic commits" and "[RFC PATCH 0/3] VSP1/DU

[PATCH v3 01/10] media: vsp1: drm: Split vsp1_du_setup_lif()

2019-06-17 Thread Laurent Pinchart
From: Kieran Bingham Break vsp1_du_setup_lif() into components more suited to the DRM Atomic API. The existing vsp1_du_setup_lif() API call is maintained as it is still used from the DU. Signed-off-by: Kieran Bingham Signed-off-by: Laurent Pinchart --- Changes since v2: - Minor formatting

Re: [PATCH 08/25] memremap: move dev_pagemap callbacks into a separate structure

2019-06-17 Thread Dan Williams
On Mon, Jun 17, 2019 at 12:59 PM Christoph Hellwig wrote: > > On Mon, Jun 17, 2019 at 10:51:35AM -0700, Dan Williams wrote: > > > - struct dev_pagemap *pgmap = _pgmap; > > > > Whoops, needed to keep this line to avoid: > > > > tools/testing/nvdimm/test/iomap.c:109:11: error: ‘pgmap’

[Bug 110897] HyperZ is broken for r300 (bad z for some micro and macrotiles?)

2019-06-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110897 --- Comment #69 from Marek Olšák --- Can you send it to amd-...@lists.freedesktop.org adding the "drm/radeon: " commit prefix and your Signed-off-by? Thanks. -- You are receiving this mail because: You are the assignee for the

Re: [PATCH 07/25] memremap: validate the pagemap type passed to devm_memremap_pages

2019-06-17 Thread Dan Williams
On Mon, Jun 17, 2019 at 12:59 PM Christoph Hellwig wrote: > > On Mon, Jun 17, 2019 at 12:02:09PM -0700, Dan Williams wrote: > > Need a lead in patch that introduces MEMORY_DEVICE_DEVDAX, otherwise: > > Or maybe a MEMORY_DEVICE_DEFAULT = 0 shared by fsdax and p2pdma? I thought about that, but it

[PATCH v7 5/9] drm/ttm: TTM fault handler helpers

2019-06-17 Thread VMware
From: Thomas Hellstrom With the vmwgfx dirty tracking, the default TTM fault handler is not completely sufficient (vmwgfx need to modify the vma->vm_flags member, and also needs to restrict the number of prefaults). We also want to replicate the new ttm_bo_vm_reserve() functionality So start

[PATCH v7 1/9] mm: Allow the [page|pfn]_mkwrite callbacks to drop the mmap_sem

2019-06-17 Thread VMware
From: Thomas Hellstrom Driver fault callbacks are allowed to drop the mmap_sem when expecting long hardware waits to avoid blocking other mm users. Allow the mkwrite callbacks to do the same by returning early on VM_FAULT_RETRY. In particular we want to be able to drop the mmap_sem when waiting

[PATCH v7 2/9] mm: Add an apply_to_pfn_range interface

2019-06-17 Thread VMware
From: Thomas Hellstrom This is basically apply_to_page_range with added functionality: Allocating missing parts of the page table becomes optional, which means that the function can be guaranteed not to error if allocation is disabled. Also passing of the closure struct and callback function

[PATCH v7 8/9] drm/vmwgfx: Implement an infrastructure for read-coherent resources

2019-06-17 Thread VMware
From: Thomas Hellstrom Similar to write-coherent resources, make sure that from the user-space point of view, GPU rendered contents is automatically available for reading by the CPU. Signed-off-by: Thomas Hellstrom Reviewed-by: Deepak Rawat --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h |

[PATCH v7 4/9] drm/ttm: Allow the driver to provide the ttm struct vm_operations_struct

2019-06-17 Thread VMware
From: Thomas Hellstrom Add a pointer to the struct vm_operations_struct in the bo_device, and assign that pointer to the default value currently used. The driver can then optionally modify that pointer and the new value can be used for each new vma created. Cc: "Christian König"

[PATCH v7 7/9] drm/vmwgfx: Use an RBtree instead of linked list for MOB resources

2019-06-17 Thread VMware
From: Thomas Hellstrom With emulated coherent memory we need to be able to quickly look up a resource from the MOB offset. Instead of traversing a linked list with O(n) worst case, use an RBtree with O(log n) worst case complexity. Signed-off-by: Thomas Hellstrom Reviewed-by: Deepak Rawat ---

[PATCH v7 6/9] drm/vmwgfx: Implement an infrastructure for write-coherent resources

2019-06-17 Thread VMware
From: Thomas Hellstrom This infrastructure will, for coherent resources, make sure that from the user-space point of view, data written by the CPU is immediately automatically available to the GPU at resource validation time. Signed-off-by: Thomas Hellstrom Reviewed-by: Deepak Rawat ---

[PATCH v7 0/9] Emulated coherent graphics memory

2019-06-17 Thread VMware
Planning to merge this through the drm/vmwgfx tree soon, so if there are any objections, please speak up. Graphics APIs like OpenGL 4.4 and Vulkan require the graphics driver to provide coherent graphics memory, meaning that the GPU sees any content written to the coherent memory on the next GPU

[PATCH v7 9/9] drm/vmwgfx: Add surface dirty-tracking callbacks

2019-06-17 Thread VMware
From: Thomas Hellstrom Add the callbacks necessary to implement emulated coherent memory for surfaces. Add a flag to the gb_surface_create ioctl to indicate that surface memory should be coherent. Also bump the drm minor version to signal the availability of coherent surfaces. Signed-off-by:

[PATCH v7 3/9] mm: Add write-protect and clean utilities for address space ranges

2019-06-17 Thread VMware
From: Thomas Hellstrom Add two utilities to a) write-protect and b) clean all ptes pointing into a range of an address space. The utilities are intended to aid in tracking dirty pages (either driver-allocated system memory or pci device memory). The write-protect utility should be used in

[PATCH 13/13] drm/msm/dsi: Move setup_encoder to modeset_init

2019-06-17 Thread Sean Paul
From: Sean Paul Now that the panel probe/setup is in the modeset path, we can call dsi_manager_setup_encoder() in a common place for both internal and external bridge setups. Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/dsi/dsi.c | 2 ++ drivers/gpu/drm/msm/dsi/dsi.h | 2

[PATCH 12/13] drm/msm/dsi: Move dsi panel init into modeset init path

2019-06-17 Thread Sean Paul
From: Sean Paul Since deferred probe from the modeset init path now works, we can move the panel initialization from detect() into connector init. This avoids doing work in detect() and hopefully will result in a more deterministic boot sequence between devices with a dsi panel, and those with

[PATCH 04/13] drm/msm/dsi_pll_10nm: Release clk hw on destroy and failure

2019-06-17 Thread Sean Paul
From: Sean Paul The 10nm pll driver didn't have any failure-path cleanup in register, and the destroy function didn't unregister any of the hardware. This patch adds both. The reason things haven't been blowing up horribly is that msm_drv has a reference count issue that keeps devices alive, so

[PATCH 08/13] drm/msm/dsi: Don't store dsi host mode_flags in msm_dsi

2019-06-17 Thread Sean Paul
From: Sean Paul It's a bit dangerous to store the flags in msm_dsi since there's no way to tell when they're populated. Fortunately the only place that uses them is the same place that fills them. So just use a local variable and delete the struct member. Signed-off-by: Sean Paul ---

[PATCH 11/13] drm/msm/dsi: Use the new setup_encoder function in attach_dsi_device

2019-06-17 Thread Sean Paul
From: Sean Paul Now that we have a function to call set_encoder_mode() for us, use it. Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/dsi/dsi.h | 2 +- drivers/gpu/drm/msm/dsi/dsi_host.c| 2 +- drivers/gpu/drm/msm/dsi/dsi_manager.c | 15 ++- 3 files changed, 4

[PATCH 07/13] drm/msm/dsi: Split mode_flags out of msm_dsi_host_get_panel()

2019-06-17 Thread Sean Paul
From: Sean Paul We use the flags in more places than just get_panel, so split them out into a separate function. Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/dsi/dsi.h | 4 ++-- drivers/gpu/drm/msm/dsi/dsi_host.c| 15 ++- drivers/gpu/drm/msm/dsi/dsi_manager.c | 7

[PATCH 10/13] drm/msm/dsi: Simplify the logic in msm_dsi_manager_panel_init()

2019-06-17 Thread Sean Paul
From: Sean Paul This patch moves things around a bit to be a little more readable and pulls out the set_encoder_mode() call into its own function for later use. Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/dsi/dsi_manager.c | 100 +++--- 1 file changed, 59

[PATCH 06/13] drm/msm: Depopulate platform on probe failure

2019-06-17 Thread Sean Paul
From: Sean Paul add_display_components() calls of_platform_populate, and we depopluate on pdev remove, but not when probe fails. So if we get a probe deferral in one of the components, we won't depopulate the platform. This causes the core to keep references to devices which should be destroyed,

[PATCH 05/13] drm/msm/dsi_pll_10nm: Remove impossible check

2019-06-17 Thread Sean Paul
From: Sean Paul While I'm in here, cut this out, pdev can't be NULL Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c b/drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c index

[PATCH 09/13] drm/msm/dsi: Pull out panel init code into function

2019-06-17 Thread Sean Paul
From: Sean Paul Pull all of the panel init code out of detect() and put it in its own function. This will be useful in future patches where it's moved from detect(). Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/dsi/dsi_manager.c | 16 1 file changed, 12 insertions(+), 4

[PATCH 03/13] drm/msm/phy/dsi_phy: Set pll to NULL in case initialization fails

2019-06-17 Thread Sean Paul
From: Sean Paul We have if (!phy->pll) checks scattered through the driver and if phy->pll is an error pointer, those checks will pass and bad things will happen :( Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

[RESEND PATCH 02/13] drm/msm/dpu: Fix mmu init/destroy functions

2019-06-17 Thread Sean Paul
From: Sean Paul There's a comment in _dpu_kms_hw_destroy() that reads "safe to call these more than once during shutdown", referring to _dpu_kms_mmu_destroy(). Unfortunately that's not the case, mmu_destroy will fail hard if it's called twice. So fix that function to ensure it can be called

[RESEND PATCH 01/13] drm/msm/dpu: Remove call to drm_mode_set_crtcinfo

2019-06-17 Thread Sean Paul
From: Sean Paul Now that mode_fixup has been removed, we can just rely on the call from drm_helper_probe_single_connector_modes(), Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 3 --- 1 file changed, 3 deletions(-) diff --git

[Bug 203879] hard freeze on high single threaded load when Xorg is active (AMD Ryzen 7 2700X CPU, AMD Radeon RX 580 GPU)

2019-06-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=203879 --- Comment #4 from Claude Heiland-Allen (cla...@mathr.co.uk) --- Created attachment 283313 --> https://bugzilla.kernel.org/attachment.cgi?id=283313=edit dmesg after boot with idle=nomwait (before freeze which occured some hours later) I got

Re: [PATCH] drm/nouveau/svm: Convert to use hmm_range_fault()

2019-06-17 Thread Jerome Glisse
On Sat, Jun 08, 2019 at 12:14:50AM +0530, Souptick Joarder wrote: > Hi Jason, > > On Tue, May 21, 2019 at 12:27 AM Souptick Joarder > wrote: > > > > Convert to use hmm_range_fault(). > > > > Signed-off-by: Souptick Joarder > > Would you like to take it through your new hmm tree or do I > need

[Bug 110897] HyperZ is broken for r300 (bad z for some micro and macrotiles?)

2019-06-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110897 Richard Thier changed: What|Removed |Added Attachment #144559|0 |1 is obsolete|

Re: [PATCH 10/25] memremap: lift the devmap_enable manipulation into devm_memremap_pages

2019-06-17 Thread Dan Williams
On Mon, Jun 17, 2019 at 5:28 AM Christoph Hellwig wrote: > > Just check if there is a ->page_free operation set and take care of the > static key enable, as well as the put using device managed resources. > Also check that a ->page_free is provided for the pgmaps types that > require it, and

Re: [PATCH v2 2/2] arm: dts: add ARM Mali GPU node for Odroid XU3

2019-06-17 Thread Rob Herring
On Fri, Jun 14, 2019 at 5:57 PM Joseph Kogut wrote: > > Add device tree node for mali gpu on Odroid XU3 SoCs. > > Signed-off-by: Joseph Kogut > --- > > Changes v1 -> v2: > - Use interrupt name ordering from binding doc > - Specify a single clock for GPU node > - Add gpu opp table > - Fix

Re: [PATCH 07/25] memremap: validate the pagemap type passed to devm_memremap_pages

2019-06-17 Thread Dan Williams
On Mon, Jun 17, 2019 at 5:27 AM Christoph Hellwig wrote: > > Most pgmap types are only supported when certain config options are > enabled. Check for a type that is valid for the current configuration > before setting up the pagemap. > > Signed-off-by: Christoph Hellwig > --- >

[Bug 110897] HyperZ is broken for r300 (bad z for some micro and macrotiles?)

2019-06-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110897 --- Comment #67 from Marek Olšák --- Keep the rs400_mc_wait_for_idle call. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list

Re: [Intel-gfx] [PATCH 00/59] prime doc polish and ... a few cleanups

2019-06-17 Thread Emil Velikov
Hi Daniel, On Fri, 14 Jun 2019 at 21:36, Daniel Vetter wrote: > > Hi all, > > So I figured let's get going and polish the docs for the last part of drm > core/helpers that hasn't yet seen some neat polish last few years. With > the goal to make docs for driver kapi a requirement henceforth - see

[PATCH] drm/rcar-du: Fix error check when retrieving crtc state

2019-06-17 Thread Sean Paul
From: Sean Paul drm_atomic_get_crtc_state() returns an error pointer when it fails, so the null check is doing nothing here. Credit to 0-day/Dan Carpenter for reporting this. Fixes: 6f3b62781bbd ("drm: Convert connector_helper_funcs->atomic_check to accept drm_atomic_state") Cc: Daniel Vetter

Re: [PATCH v5 12/12] drm/vc4: hdmi: Set default state margin at reset

2019-06-17 Thread Eric Anholt
Maxime Ripard writes: > Now that the TV margins are properly parsed and filled into > drm_cmdline_mode, we just need to initialise the first state at reset to > get those values and start using them. > > Reviewed-by: Noralf Trønnes > Signed-off-by: Maxime Ripard Acked-by: Eric Anholt

Re: [Intel-gfx] [PATCH 07/59] drm/arm/komeda: Remove DRIVER_HAVE_IRQ

2019-06-17 Thread Emil Velikov
On 2019/06/17, james qian wang (Arm Technology China) wrote: > On Fri, Jun 14, 2019 at 10:35:23PM +0200, Daniel Vetter wrote: > > Read the docs, komeda is not an old enough driver for this :-) > > > > Signed-off-by: Daniel Vetter > > Cc: "James (Qian) Wang" > > Cc: Liviu Dudau > > --- > >

Re: [PATCH 06/59] drm/prime: Actually remove DRIVER_PRIME everywhere

2019-06-17 Thread Emil Velikov
On 2019/06/14, Daniel Vetter wrote: > Split out to make the functional changes stick out more. > Since this patch flew-by, as standalone one (intentionally or not) I'd add, anything vaguely like: "Core users of DRIVER_PRIME were removed from core with prior patches." HTH Emil

Re: [Intel-gfx] [PATCH 05/59] drm/prime: Make DRIVER_PRIME a no-op

2019-06-17 Thread Emil Velikov
On 2019/06/14, Daniel Vetter wrote: > Drivers must fill out the handle_to_fd and fd_to_handle hooks to > enable export/import prime functionality already. The additional > DRIVER_PRIME flag doesn't serve any real purpose, since the overall > flag doesn't even tell you whether import or export or

Re: [PATCH 08/25] memremap: move dev_pagemap callbacks into a separate structure

2019-06-17 Thread Dan Williams
On Mon, Jun 17, 2019 at 5:27 AM Christoph Hellwig wrote: > > The dev_pagemap is a growing too many callbacks. Move them into a > separate ops structure so that they are not duplicated for multiple > instances, and an attacker can't easily overwrite them. > > Signed-off-by: Christoph Hellwig >

Re: [Intel-gfx] [PATCH 03/59] drm/prime: Update docs

2019-06-17 Thread Emil Velikov
On 2019/06/14, Daniel Vetter wrote: > Yes this is a bit a big patch, but since it's essentially a complete > rewrite of all the prime docs I didn't see how to better split it up. > > Changes: > - Consistently point to drm_gem_object_funcs as the preferred hooks, > where applicable. > > -

Re: [PATCH 06/25] mm: factor out a devm_request_free_mem_region helper

2019-06-17 Thread Dan Williams
On Mon, Jun 17, 2019 at 5:27 AM Christoph Hellwig wrote: > > Keep the physical address allocation that hmm_add_device does with the > rest of the resource code, and allow future reuse of it without the hmm > wrapper. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Jason Gunthorpe >

[Bug 110914] Heavy corruption on R300 with modesetting and GLAMOR

2019-06-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110914 --- Comment #6 from Rui Salvaterra --- Created attachment 144571 --> https://bugs.freedesktop.org/attachment.cgi?id=144571=edit Xorg log (radeon DDX + AccelMethod glamor) With the radeon DDX and the following xorg.conf:

Re: [PATCH libdrm] intel/i915_pciids: Add missing device ID for ICL

2019-06-17 Thread Clinton Taylor
Reviewed-by: Clint Taylor -Clint On 6/17/19 1:34 AM, Mika Kahola wrote: We are missing PCI device ID for SKU ICLLP U GT 1.5F (0x8A54) as per BSPec. BSpec: 19092 Signed-off-by: Mika Kahola --- intel/i915_pciids.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 03/59] drm/prime: Update docs

2019-06-17 Thread Sam Ravnborg
Hi Daniel. > > > +/** > > > + * DOC: overview and lifetime rules > > > + * > > > + * Similar to GEM global names, PRIME file descriptors are also used to > > > share > > > + * buffer objects across processes. They offer additional security: as > > > file > > > + * descriptors must be explicitly

Re: [PATCH 01/59] drm/todo: Improve drm_gem_object funcs todo

2019-06-17 Thread Noralf Trønnes
Den 17.06.2019 18.29, skrev Daniel Vetter: > On Mon, Jun 17, 2019 at 05:47:50PM +0200, Noralf Trønnes wrote: >> >> >> Den 14.06.2019 22.35, skrev Daniel Vetter: >>> We're kinda going in the wrong direction. Spotted while typing better >>> gem/prime docs. >>> >>> Cc: Thomas Zimmermann >>> Cc:

Re: [PATCH 03/59] drm/prime: Update docs

2019-06-17 Thread Daniel Vetter
On Sat, Jun 15, 2019 at 01:41:53PM +0200, Sam Ravnborg wrote: > Hi Daniel > > Better and more consistent docs - good! > With relevant comments addressed: > Reviewed-by: Sam Ravnborg > > > +/** > > + * DOC: overview and lifetime rules > > + * > > + * Similar to GEM global names, PRIME file

Re: [PATCH v2 2/2] arm: dts: add ARM Mali GPU node for Odroid XU3

2019-06-17 Thread Krzysztof Kozlowski
On Mon, Jun 17, 2019 at 09:15:23AM -0700, Joseph Kogut wrote: > Hi Krzysztof, > > Thanks for the review. > > On Sun, Jun 16, 2019 at 1:59 AM Krzysztof Kozlowski wrote: > > > > On Fri, Jun 14, 2019 at 04:57:19PM -0700, Joseph Kogut wrote: > > > Add device tree node for mali gpu on Odroid XU3

Re: [PATCH 01/59] drm/todo: Improve drm_gem_object funcs todo

2019-06-17 Thread Daniel Vetter
On Mon, Jun 17, 2019 at 05:47:50PM +0200, Noralf Trønnes wrote: > > > Den 14.06.2019 22.35, skrev Daniel Vetter: > > We're kinda going in the wrong direction. Spotted while typing better > > gem/prime docs. > > > > Cc: Thomas Zimmermann > > Cc: Gerd Hoffmann > > Cc: Rob Herring > > Cc:

[Bug 110702] segfault in radeonsi HEVC hardware decoding with yuv420p10le

2019-06-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110702 --- Comment #7 from asavah --- The sample provided in the post above is not triggering the crash. However a sample was provided to me that reliably crashes. https://drive.google.com/open?id=1bDhF6U5ccW-K1G63fl1qnO-98kopMJyw ryzen 2400g linux

Re: [PATCH 01/59] drm/todo: Improve drm_gem_object funcs todo

2019-06-17 Thread Noralf Trønnes
Den 14.06.2019 22.35, skrev Daniel Vetter: > We're kinda going in the wrong direction. Spotted while typing better > gem/prime docs. > > Cc: Thomas Zimmermann > Cc: Gerd Hoffmann > Cc: Rob Herring > Cc: Noralf Trønnes > Signed-off-by: Daniel Vetter > --- > Documentation/gpu/todo.rst | 4

[PATCH] drm/prime: Actually remove DRIVER_PRIME everywhere

2019-06-17 Thread Daniel Vetter
Split out to make the functional changes stick out more. v2: amdgpu gained DRIVER_SYNCOBJ_TIMELINE. v3: amdgpu lost DRIVER_SYNCOBJ_TIMELINE. v4: Don't add a space in i915_drv.c (Sam) Cc: Sam Ravnborg Reviewed-by: Eric Anholt Signed-off-by: Daniel Vetter Cc: amd-...@lists.freedesktop.org Cc:

Re: [PATCH] drm/amd/powerplay: Delete a redundant memory setting in vega20_set_default_od8_setttings()

2019-06-17 Thread Alex Deucher
Applied this and the dc patch. Thanks! Alex On Mon, Jun 17, 2019 at 10:07 AM Markus Elfring wrote: > > From: Markus Elfring > Date: Mon, 17 Jun 2019 14:24:14 +0200 > > The memory was set to zero already by a call of the function “kzalloc”. > Thus remove an extra call of the function “memset”

Re: [PATCH] drm/amd/display: Add missing newline at end of file

2019-06-17 Thread Alex Deucher
On Mon, Jun 17, 2019 at 10:45 AM Geert Uytterhoeven wrote: > > "git diff" says: > > \ No newline at end of file > > after modifying the file. > > Signed-off-by: Geert Uytterhoeven Applied. thanks! Alex > --- > drivers/gpu/drm/amd/display/modules/power/Makefile | 2 +- > 1 file changed,

Re: [PATCH] drm/amdgpu: fix error handling in df_v3_6_pmc_start

2019-06-17 Thread Alex Deucher
On Mon, Jun 17, 2019 at 8:57 AM Arnd Bergmann wrote: > > When df_v3_6_pmc_get_ctrl_settings() fails for some reason, we > store uninitialized data in a register, as gcc points out: > > drivers/gpu/drm/amd/amdgpu/df_v3_6.c: In function 'df_v3_6_pmc_start': >

Re: [RFC PATCH] drm/panfrost: Add support for mapping BOs on GPU page faults

2019-06-17 Thread Rob Herring
On Sun, Jun 16, 2019 at 11:15 PM Tomeu Vizoso wrote: > > On Fri, 14 Jun 2019 at 23:22, Rob Herring wrote: > > > > On Wed, Jun 12, 2019 at 6:55 AM Tomeu Vizoso wrote: > > > > > > On Mon, 10 Jun 2019 at 19:06, Rob Herring wrote: > > > > > > > > The midgard/bifrost GPUs need to allocate GPU

  1   2   3   >