Re: [Intel-gfx] [PATCH] drm/i915: Don't disable interrupts independently of the lock

2019-10-10 Thread Sebastian Andrzej Siewior
On 2019-10-10 19:11:27 [+0100], Chris Wilson wrote: > > --- a/drivers/gpu/drm/i915/i915_request.c > > +++ b/drivers/gpu/drm/i915/i915_request.c > > @@ -251,15 +251,13 @@ static bool i915_request_retire(struct i > > active->retire(active, rq); > > } > > > > - local_ir

[amdgpu] ASSERT()'s in write_i2c*retimer_setting() functions

2019-10-10 Thread Gabriel C
Hello, I've built recently a new box with a Ryzen3 2200G APU. Each time I plug in an HDMI cable ( to a TV or Monitor ), or boot with HDMI connected a lot ASSERT()'s from write_i2c*retimer_setting() functions are triggered. I see the same on a Laptop with a Ryzen7 3750H with hybrid GPU configurat

Re: [PATCHv2 7/7] drm/omap: hdmi4: fix use of uninitialized var

2019-10-10 Thread Tony Lindgren
* Tomi Valkeinen [191010 06:48]: > On 08/10/2019 17:21, Tony Lindgren wrote: > > * Tomi Valkeinen [191008 14:17]: > > > On 08/10/2019 17:13, Tony Lindgren wrote: > > > > * Tomi Valkeinen [190930 10:38]: > > > > > If use_mclk is false, mclk_mode is written to a register without > > > > > initiali

Kernel crash on 4.19.77-1-lts (Arch Linux / ThinkPad T470p)

2019-10-10 Thread John Maguire
Hi there, I wasn't sure which mailing list to use so I BCC'd intel-...@lists.freedesktop.org and dri-devel@lists.freedesktop.org I'm using a Lenovo Thinkpad T470p and running the 4.19.77-1-lts kernel on Arch Linux. Recently, I've started getting freezes each day. Audio can still be heard, but vid

[PATCH 4/4] drm/msm/dsi: Remove set but not used variable 'lp'

2019-10-10 Thread zhengbin
Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/msm/dsi/dsi_host.c: In function dsi_cmd_dma_rx: drivers/gpu/drm/msm/dsi/dsi_host.c:1302:7: warning: variable lp set but not used [-Wunused-but-set-variable] It is not used since commit a689554ba6ed ("drm/msm: Initial add DSI connecto

[PATCH 2/4] drm/msm/mdp5: Remove set but not used variable 'hw_cfg' in blend_setup

2019-10-10 Thread zhengbin
Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c: In function blend_setup: drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c:225:28: warning: variable hw_cfg set but not used [-Wunused-but-set-variable] It is not used since commit 14be3200cd5f ("drm/msm: rename md

[PATCH] drm/i915: Don't disable interrupts independently of the lock

2019-10-10 Thread Sebastian Andrzej Siewior
The locks (active.lock and rq->lock) need to be taken with disabled interrupts. This is done in i915_request_retire() by disabling the interrupts independently of the locks itself. While local_irq_disable()+spin_lock() equals spin_lock_irq() on vanilla it does not on PREEMPT_RT. Also, it is not obv

Re: [PATCH] drm/scheduler: make unexported items static

2019-10-10 Thread Ben Dooks
On 09/10/2019 13:14, Ben Dooks wrote: The drm_sched_fence_ops_{scheduled,finished} are not exported from the file so make them static to avoid the following warnings from sparse: drivers/gpu/drm/scheduler/sched_fence.c:131:28: warning: symbol 'drm_sched_fence_ops_scheduled' was not declared. Sh

[PATCH v2 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding

2019-10-10 Thread Xin Ji
The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed for portable device. It converts MIPI to DisplayPort 1.3 4K. You can add support to your board with binding. Example: anx7625_bridge: encoder@58 { compatible = "analogix,anx7625"; reg = <0x

[PATCH 3/4] drm/msm/dsi: Remove set but not used variable 'lpx'

2019-10-10 Thread zhengbin
Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/msm/dsi/phy/dsi_phy.c: In function msm_dsi_dphy_timing_calc_v2: drivers/gpu/drm/msm/dsi/phy/dsi_phy.c:156:17: warning: variable lpx set but not used [-Wunused-but-set-variable] drivers/gpu/drm/msm/dsi/phy/dsi_phy.c: In function msm_ds

[PATCH 0/4] drm/msm: Remove four set but not used variables

2019-10-10 Thread zhengbin
zhengbin (4): drm/msm/mdp5: Remove set but not used variable 'fmt' drm/msm/mdp5: Remove set but not used variable 'hw_cfg' in blend_setup drm/msm/dsi: Remove set but not used variable 'lpx' drm/msm/dsi: Remove set but not used variable 'lp' drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 3 --

[PATCH 1/4] drm/msm/mdp5: Remove set but not used variable 'fmt'

2019-10-10 Thread zhengbin
Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c: In function mdp5_smp_calculate: drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c:134:6: warning: variable fmt set but not used [-Wunused-but-set-variable] It is not used since commit 24c478ead0bf ("drm/fourcc: Pass

Re: [PATCH v2 1/3] drm: Add some new format DRM_FORMAT_NVXX_10

2019-10-10 Thread james qian wang (Arm Technology China)
On Fri, Oct 11, 2019 at 11:35:53AM +0800, sandy.huang wrote: > Hi james.qian.wang, > >     Thank for you remind, fou some unknow reason, i miss the the mail from > you:(, i get this message from https://patchwork.kernel.org/patch/11161937/ > > sorry about that. > >     About the format block des

Re: [PATCH v2 4/4] drm/komeda: Adds gamma and color-transform support for DOU-IPS

2019-10-10 Thread sandy.huang
在 2019/10/11 下午1:43, james qian wang (Arm Technology China) 写道: From: "Lowry Li (Arm Technology China)" Adds gamma and color-transform support for DOU-IPS. Adds two caps members fgamma_coeffs and ctm_coeffs to komeda_improc_state. If color management changed, set gamma and color-transform acco

Re: [PATCH v2 0/2] Add initial support for slimport anx7625

2019-10-10 Thread Andrzej Hajda
On 11.10.2019 04:20, Xin Ji wrote: > Hi all, > > The following series add initial support for the Slimport ANX7625 > transmitter, a > ultra-low power Full-HD 4K MIPI to DP transmitter designed for portable > device. > > This is the initial version, any mistakes, please let me know, I will fix it

[PATCH v2 3/4] drm/komeda: Add drm_ctm_to_coeffs()

2019-10-10 Thread james qian wang (Arm Technology China)
This function is for converting drm_color_ctm matrix to komeda hardware required required Q2.12 2's complement CSC matrix. v2: Move the fixpoint conversion function s31_32_to_q2_12() to drm core as a shared helper. Signed-off-by: james qian wang (Arm Technology China) --- .../gpu/drm/arm/di

[PATCH v2 4/4] drm/komeda: Adds gamma and color-transform support for DOU-IPS

2019-10-10 Thread james qian wang (Arm Technology China)
From: "Lowry Li (Arm Technology China)" Adds gamma and color-transform support for DOU-IPS. Adds two caps members fgamma_coeffs and ctm_coeffs to komeda_improc_state. If color management changed, set gamma and color-transform accordingly. Signed-off-by: Lowry Li (Arm Technology China) --- .../

[PATCH v2 1/4] drm: Add a new helper drm_color_ctm_s31_32_to_qm_n()

2019-10-10 Thread james qian wang (Arm Technology China)
Add a new helper function drm_color_ctm_s31_32_to_qm_n() for driver to convert S31.32 sign-magnitude to Qm.n 2's complement that supported by hardware. Signed-off-by: james qian wang (Arm Technology China) --- drivers/gpu/drm/drm_color_mgmt.c | 23 +++ include/drm/drm_color_m

[PATCH v2 2/4] drm/komeda: Add drm_lut_to_fgamma_coeffs()

2019-10-10 Thread james qian wang (Arm Technology China)
This function is used to convert drm 3dlut to komeda HW required 1d curve coeffs values. Signed-off-by: james qian wang (Arm Technology China) --- .../arm/display/komeda/komeda_color_mgmt.c| 52 +++ .../arm/display/komeda/komeda_color_mgmt.h| 9 +++- 2 files changed, 60

[PATCH v2 0/4] drm/komeda: Enable CRTC color-mgmt

2019-10-10 Thread james qian wang (Arm Technology China)
This series enable CRTC color-mgmt for komeda driver, for current komeda HW which only supports color conversion and forward gamma for CRTC. This series actually are regrouped from: - drm/komeda: Enable layer/plane color-mgmt: https://patchwork.freedesktop.org/series/60893/ - drm/komeda: Enable

[PATCH v2 3/4] drm/komeda: Add drm_ctm_to_coeffs()

2019-10-10 Thread james qian wang (Arm Technology China)
This function is for converting drm_color_ctm matrix to komeda hardware required required Q2.12 2's complement CSC matrix. v2: Move the fixpoint conversion function s31_32_to_q2_12() to drm core as a shared helper. Signed-off-by: james qian wang (Arm Technology China) --- .../gpu/drm/arm/di

[PATCH v2 4/4] drm/komeda: Adds gamma and color-transform support for DOU-IPS

2019-10-10 Thread james qian wang (Arm Technology China)
From: "Lowry Li (Arm Technology China)" Adds gamma and color-transform support for DOU-IPS. Adds two caps members fgamma_coeffs and ctm_coeffs to komeda_improc_state. If color management changed, set gamma and color-transform accordingly. Signed-off-by: Lowry Li (Arm Technology China) --- .../

[PATCH v2 2/4] drm/komeda: Add drm_lut_to_fgamma_coeffs()

2019-10-10 Thread james qian wang (Arm Technology China)
This function is used to convert drm 3dlut to komeda HW required 1d curve coeffs values. Signed-off-by: james qian wang (Arm Technology China) --- .../arm/display/komeda/komeda_color_mgmt.c| 52 +++ .../arm/display/komeda/komeda_color_mgmt.h| 9 +++- 2 files changed, 60

[PATCH v2 1/4] drm/komeda: Add a new helper drm_color_ctm_s31_32_to_qm_n()

2019-10-10 Thread james qian wang (Arm Technology China)
Add a new helper function drm_color_ctm_s31_32_to_qm_n() for driver to convert S31.32 sign-magnitude to Qm.n 2's complement that supported by hardware. Signed-off-by: james qian wang (Arm Technology China) --- drivers/gpu/drm/drm_color_mgmt.c | 23 +++ include/drm/drm_color_m

[PATCH v2 0/4] drm/komeda: Enable CRTC color-mgmt

2019-10-10 Thread james qian wang (Arm Technology China)
This series enable CRTC color-mgmt for komeda driver, for current komeda HW which only supports color conversion and forward gamma for CRTC. This series actually are regrouped from: - drm/komeda: Enable layer/plane color-mgmt: https://patchwork.freedesktop.org/series/60893/ - drm/komeda: Enable

[git pull] drm fixes for 5.4-rc3

2019-10-10 Thread Dave Airlie
Hey Linus, The regular fixes pull for rc3. The i915 team found some fixes they (or I) missed for rc1, which is why this is a bit bigger than usual, otherwise there is a single amdgpu fix, some spi panel aliases, and a bridge fix. drm-fixes-2019-10-11: drm fixes for 5.4-rc3 i915: - execlist acces

Re: [pull] ttm drm-fixes-5.4

2019-10-10 Thread Dave Airlie
On Fri, 11 Oct 2019 at 14:20, Dave Airlie wrote: > > On Thu, 10 Oct 2019 at 21:58, Koenig, Christian > wrote: > > > > Am 09.10.19 um 09:47 schrieb Arkadiusz Hiler: > > > On Tue, Oct 08, 2019 at 09:13:41AM -0400, Alex Deucher wrote: > > >> On Tue, Oct 8, 2019 at 4:04 AM Koenig, Christian > > >> w

Re: [pull] ttm drm-fixes-5.4

2019-10-10 Thread Dave Airlie
On Thu, 10 Oct 2019 at 21:58, Koenig, Christian wrote: > > Am 09.10.19 um 09:47 schrieb Arkadiusz Hiler: > > On Tue, Oct 08, 2019 at 09:13:41AM -0400, Alex Deucher wrote: > >> On Tue, Oct 8, 2019 at 4:04 AM Koenig, Christian > >> wrote: > >>> My git version should be relative new, but I'm usually

Re: [PATCH 1/1] drm/rockchip: vop: add the definition of dclk_pol【请注意,邮件由linux-rockchip-bounces+sandy.huang=rock-chips....@lists.infradead.org代发】

2019-10-10 Thread sandy.huang
Reviewed-by: Sandy Huang 在 2019/10/10 上午11:44, Nickey Yang 写道: Some VOP's (such as px30) dclk_pol bit is at the last. So it is necessary to distinguish dclk_pol and pin_pol. Signed-off-by: Nickey Yang --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 12 +++--- drivers/gpu/drm/rockchip/roc

Re: [PATCH v2 1/3] drm: Add some new format DRM_FORMAT_NVXX_10

2019-10-10 Thread sandy.huang
Hi james.qian.wang,     Thank for you remind, fou some unknow reason, i miss the the mail from you:(, i get this message from https://patchwork.kernel.org/patch/11161937/ sorry about that.     About the format block describe, I also found some unreasonable,  this format need 2 line aligned,

[PATCH v2 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver

2019-10-10 Thread Xin Ji
The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed for portable device. It converts MIPI DSI/DPI to DisplayPort 1.3 4K. The ANX7625 can support both USB Type-C PD feature and MIPI DSI/DPI to DP feature. This driver only enabled MIPI DSI/DPI to DP feature. Signed-off-by: Xin Ji -

[PATCH v2 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding

2019-10-10 Thread Xin Ji
The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed for portable device. It converts MIPI to DisplayPort 1.3 4K. You can add support to your board with binding. Example: anx7625_bridge: encoder@58 { compatible = "analogix,anx7625"; reg = <0x

[PATCH v2 0/2] Add initial support for slimport anx7625

2019-10-10 Thread Xin Ji
Hi all, The following series add initial support for the Slimport ANX7625 transmitter, a ultra-low power Full-HD 4K MIPI to DP transmitter designed for portable device. This is the initial version, any mistakes, please let me know, I will fix it in the next series. Thanks, Xin Xin Ji (2): dt

Re: [PATCH v2 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver

2019-10-10 Thread Xin Ji
Hi Dan Carpenter, This is a bug, I'll fix it right now. The coding is much nicer than before, thanks for your comments, it is very helpful for me. Thanks, Xin On Thu, Oct 10, 2019 at 12:56:17PM +0300, Dan Carpenter wrote: > On Thu, Oct 10, 2019 at 12:53:15PM +0300, Dan Carpenter wrote: > > Thi

Re: [PATCH 1/1] drm/rockchip: vop: add the definition of dclk_pol

2019-10-10 Thread Heiko Stübner
Am Donnerstag, 10. Oktober 2019, 05:44:52 CEST schrieb Nickey Yang: > Some VOP's (such as px30) dclk_pol bit is at the last. > So it is necessary to distinguish dclk_pol and pin_pol. > > Signed-off-by: Nickey Yang on - px30 with dsi ... fixing the display issue I had - rk3328 with hdmi - rk3288

linux-next: build warning after merge of the drm-misc tree

2019-10-10 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (arm multi_v7_defconfig) produced this warning: drivers/gpu/drm/drm_dp_mst_topology.c: In function 'drm_atomic_get_mst_topology_state': drivers/gpu/drm/drm_dp_mst_topology.c:4187:21: warning: unused variable 'dev' [-Wunused-varia

Re: [PATCH v2 4/8] dt-bindings: memory-controllers: Convert Samsung Exynos SROM bindings to json-schema

2019-10-10 Thread Rob Herring
On Wed, 18 Sep 2019 19:31:37 +0200, Krzysztof Kozlowski wrote: > Convert Samsung Exynos SROM controller bindings to DT schema format > using json-schema. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v1: > 1. Indent example with four spaces (more readable), > 2. Split example

[PATCH] dt-bindings: display: Convert sharp,ld-d5116z01b panel to DT schema

2019-10-10 Thread Jeffrey Hugo
Convert the sharp,ld-d5116z01b panel binding to DT schema. Signed-off-by: Jeffrey Hugo --- .../display/panel/sharp,ld-d5116z01b.txt | 26 .../display/panel/sharp,ld-d5116z01b.yaml | 30 +++ 2 files changed, 30 insertions(+), 26 deletions(-) delete mode

[PATCH] drm/dp: Remove the unused drm_device to get rid of build warning

2019-10-10 Thread Manasi Navare
We no longer use the connection mutex and hence no need to define drm_device *dev, it causes a unused variable build warning Fixes: 83fa9842afe7 ("drm/dp-mst: Drop connection_mutex check") Cc: Sean Paul Cc: Lyude Paul Cc: Daniel Vetter Signed-off-by: Manasi Navare --- drivers/gpu/drm/drm_dp_m

[PATCH 28/36] fbdev: s3c2410fb: remove mach header dependency

2019-10-10 Thread Arnd Bergmann
The s3c2410fb driver is too deeply intertwined with the s3c24xx platform code. Change it in a way that avoids the use of platform header files but having all interface data in a platform_data header, and the private register definitions next to the driver itself. One ugly bit here is that the driv

[PATCH] drm: Funnel drm logs to tracepoints

2019-10-10 Thread Sean Paul
From: Sean Paul *Record scratch* You read that subject correctly, I bet you're wondering how we got here. At least hear me out before you flame :-) For a long while now, we (ChromeOS) have been struggling getting any value out of user feedback reports of display failures (notably external displa

Re: [Intel-gfx] [PATCH] drm/i915: Don't disable interrupts independently of the lock

2019-10-10 Thread Chris Wilson
Quoting Sebastian Andrzej Siewior (2019-10-10 19:26:10) > On 2019-10-10 19:11:27 [+0100], Chris Wilson wrote: > > > --- a/drivers/gpu/drm/i915/i915_request.c > > > +++ b/drivers/gpu/drm/i915/i915_request.c > > > @@ -251,15 +251,13 @@ static bool i915_request_retire(struct i > > > ac

[PATCH 00/36] ARM: samsung platform cleanup

2019-10-10 Thread Arnd Bergmann
I've spent some time looking at the remaining ARMv4/ARMv5 platforms that are not part of ARCH_MULTIPLATFORM, and tried to get them closer to that. Here is what came out of that for the samsung platforms: * Exynos and s5pv210 are made independent of plat-samsung * device drivers stop using mach/*.h

[PATCH v5 3/3] ARM: dts: rockchip: Add RK3288 VOP gamma LUT address

2019-10-10 Thread Ezequiel Garcia
RK3288 SoC VOPs have optional support Gamma LUT setting, which requires specifying the Gamma LUT address in the devicetree. Signed-off-by: Ezequiel Garcia Reviewed-by: Douglas Anderson --- Changes from v4: * None. Changes from v3: * None. Changes from v2: * None. Changes from v1: * Drop reg-name

[PATCH v5 2/3] drm/rockchip: Add optional support for CRTC gamma LUT

2019-10-10 Thread Ezequiel Garcia
Add an optional CRTC gamma LUT support, and enable it on RK3288. This is currently enabled via a separate address resource, which needs to be specified in the devicetree. The address resource is required because on some SoCs, such as RK3288, the LUT address is after the MMU address, and the latter

[PATCH v5 1/3] dt-bindings: display: rockchip: document VOP gamma LUT address

2019-10-10 Thread Ezequiel Garcia
Add the register specifier description for an optional gamma LUT address. Signed-off-by: Ezequiel Garcia Reviewed-by: Douglas Anderson Reviewed-by: Rob Herring --- Changes from v4: * None. Changes from v3: * None. Changes from v2: * None. Changes from v1: * Drop reg-names, suggested by Doug. --

[PATCH v5 0/3] RK3288 Gamma LUT

2019-10-10 Thread Ezequiel Garcia
New iteration, seems that we are finally converging. For this v5, we are only doing some changes on the gamma_set implementation. As a result, the code is more readable. See the changelog in patch 2 for more information. Thanks! Ezequiel Garcia (3): dt-bindings: display: rockchip: document VOP

Re: [PATCH] drm/msm/dsi: Implement reset correctly

2019-10-10 Thread Jeffrey Hugo
On Thu, Oct 10, 2019 at 12:49 PM Sean Paul wrote: > > On Thu, Oct 10, 2019 at 2:45 PM Sean Paul wrote: > > > > On Wed, Oct 09, 2019 at 02:34:54PM -0700, Jeffrey Hugo wrote: > > > On msm8998, vblank timeouts are observed because the DSI controller is not > > > reset properly, which ends up stallin

Re: [PATCH v3 2/2] dt-bindings: pwm: Convert Samsung PWM bindings to json-schema

2019-10-10 Thread Rob Herring
On Wed, Oct 2, 2019 at 11:41 AM Krzysztof Kozlowski wrote: > > Convert Samsung PWM (S3C, S5P and Exynos SoCs) bindings to DT schema > format using json-schema. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v2: > 1. Add additionalProperties: false. > > Changes since v1: > 1. Ind

Re: [PATCH v2 3/5] drm/msm/dsi: Add configuration for 28nm PLL on family B

2019-10-10 Thread Sean Paul
On Thu, Sep 26, 2019 at 12:52:54PM +0200, khol...@gmail.com wrote: > From: "Angelo G. Del Regno" > > The 28nm PLL has a different iospace on MSM/APQ family B SoCs: > add a new configuration and use it when the DT reports the > "qcom,dsi-phy-28nm-hpm-fam-b" compatible. > > Signed-off-by: Angelo G

Re: [PATCH v2 1/5] drm/msm/mdp5: Add optional TBU and TBU_RT clocks

2019-10-10 Thread Sean Paul
On Thu, Sep 26, 2019 at 12:52:52PM +0200, khol...@gmail.com wrote: > From: "Angelo G. Del Regno" Hi Angelo, Thank you for your patches! > > Some SoCs, like MSM8956/8976 (and APQ variants), do feature these > clocks and we need to enable them in order to get the hardware to > properly work. Cou

Re: [PATCH v3 1/2] dt-bindings: pwm: Convert PWM bindings to json-schema

2019-10-10 Thread Rob Herring
On Wed, Oct 02, 2019 at 06:40:46PM +0200, Krzysztof Kozlowski wrote: > Convert generic PWM bindings to DT schema format using json-schema. The > consumer bindings are split to separate file. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v2: > 1. Change also pwm-sprd.txt > >

Re: [PATCH] drm/msm/dsi: Implement reset correctly

2019-10-10 Thread Sean Paul
On Thu, Oct 10, 2019 at 2:45 PM Sean Paul wrote: > > On Wed, Oct 09, 2019 at 02:34:54PM -0700, Jeffrey Hugo wrote: > > On msm8998, vblank timeouts are observed because the DSI controller is not > > reset properly, which ends up stalling the MDP. This is because the reset > > logic is not correct

Re: [PATCH] drm/msm/dsi: Implement reset correctly

2019-10-10 Thread Sean Paul
On Wed, Oct 09, 2019 at 02:34:54PM -0700, Jeffrey Hugo wrote: > On msm8998, vblank timeouts are observed because the DSI controller is not > reset properly, which ends up stalling the MDP. This is because the reset > logic is not correct per the hardware documentation. > > The documentation state

[PATCH v11 2/5] dma-buf: heaps: Add heap helpers

2019-10-10 Thread John Stultz
Add generic helper dmabuf ops for dma heaps, so we can reduce the amount of duplicative code for the exported dmabufs. This code is an evolution of the Android ION implementation, so thanks to its original authors and maintainters: Rebecca Schultz Zavin, Colin Cross, Laura Abbott, and others! C

[PATCH v11 4/5] dma-buf: heaps: Add CMA heap to dmabuf heaps

2019-10-10 Thread John Stultz
This adds a CMA heap, which allows userspace to allocate a dma-buf of contiguous memory out of a CMA region. This code is an evolution of the Android ION implementation, so thanks to its original author and maintainters: Benjamin Gaignard, Laura Abbott, and others! Cc: Laura Abbott Cc: Benjami

[PATCH v11 3/5] dma-buf: heaps: Add system heap to dmabuf heaps

2019-10-10 Thread John Stultz
This patch adds system heap to the dma-buf heaps framework. This allows applications to get a page-allocator backed dma-buf for non-contiguous memory. This code is an evolution of the Android ION implementation, so thanks to its original authors and maintainters: Rebecca Schultz Zavin, Colin Cr

[PATCH v11 5/5] kselftests: Add dma-heap test

2019-10-10 Thread John Stultz
Add very trivial allocation and import test for dma-heaps, utilizing the vgem driver as a test importer. A good chunk of this code taken from: tools/testing/selftests/android/ion/ionmap_test.c Originally by Laura Abbott Cc: Benjamin Gaignard Cc: Sumit Semwal Cc: Liam Mark Cc: Pratik Patel

[PATCH v11 1/5] dma-buf: Add dma-buf heaps framework

2019-10-10 Thread John Stultz
From: "Andrew F. Davis" This framework allows a unified userspace interface for dma-buf exporters, allowing userland to allocate specific types of memory for use in dma-buf sharing. Each heap is given its own device node, which a user can allocate a dma-buf fd from using the DMA_HEAP_IOC_ALLOC.

[PATCH v11 0/5] DMA-BUF Heaps (destaging ION)

2019-10-10 Thread John Stultz
Feeling a bit repetitive, but here is yet another pass at the dma-buf heaps patchset Andrew and I have been working on which tries to destage a fair chunk of ION functionality. The patchset implements per-heap devices which can be opened directly and then an ioctl is used to allocate a dmabuf from

[PATCH v2] drm/msm: Sanitize the modeset_is_locked checks in dpu

2019-10-10 Thread Sean Paul
From: Sean Paul As Daniel mentions in his email [1], non-blocking commits don't hold the modeset locks, so we can safely access state as long as these functions are in the commit path. So remove the WARN_ON in dpu_kms_encoder_enable. In dpu_crtc_get_intf_mode, things are a bit more complicated.

Re: [Intel-gfx] [PATCH] drm/i915: Don't disable interrupts independently of the lock

2019-10-10 Thread Chris Wilson
Quoting Sebastian Andrzej Siewior (2019-10-10 17:06:40) > The locks (active.lock and rq->lock) need to be taken with disabled > interrupts. This is done in i915_request_retire() by disabling the > interrupts independently of the locks itself. > While local_irq_disable()+spin_lock() equals spin_lock

[Bug 111948] [Vega10][bisected] Vega56 VM_L2_PROTECTION_FAULT when logging into KDE with kernel 5.3.0-rc1 and newer

2019-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111948 Andreas changed: What|Removed |Added Priority|not set |high -- You are receiving this mail because:

Re: [PATCH v4 3/9] drm: rcar-du: Add support for CMM

2019-10-10 Thread Jacopo Mondi
Hi Laurent, On Thu, Sep 19, 2019 at 01:55:35AM +0300, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > On Fri, Sep 06, 2019 at 03:54:30PM +0200, Jacopo Mondi wrote: > > Add a driver for the R-Car Display Unit Color Correction Module. > > > > In most of Gen3 SoCs, each DU outpu

Re: [PATCH v4 2/3] drm/rockchip: Add optional support for CRTC gamma LUT

2019-10-10 Thread Ville Syrjälä
On Thu, Oct 10, 2019 at 12:23:05PM -0400, Ilia Mirkin wrote: > On Thu, Oct 10, 2019 at 12:01 PM Sean Paul wrote: > > > > > +static int vop_crtc_atomic_check(struct drm_crtc *crtc, > > > > > + struct drm_crtc_state *crtc_state) > > > > > +{ > > > > > + struct vop *v

Re: [PATCH 4/7] drm/meson: plane: add support for AFBC mode for OSD1 plane

2019-10-10 Thread Ayan Halder
On Thu, Oct 10, 2019 at 03:41:15PM +0200, Neil Armstrong wrote: > Hi Ayan, > > On 10/10/2019 15:26, Ayan Halder wrote: > > On Thu, Oct 10, 2019 at 11:25:23AM +0200, Neil Armstrong wrote: > >> This adds all the OSD configuration plumbing to support the AFBC decoders > >> path to display of the OSD1

Re: [PATCH] drm/amdgpu: Bail earlier when amdgpu.cik_/si_support is not set to 1

2019-10-10 Thread Daniel Vetter
On Thu, Oct 10, 2019 at 6:28 PM Hans de Goede wrote: > > Bail from the pci_driver probe function instead of from the drm_driver > load function. > > This avoid /dev/dri/card0 temporarily getting registered and then > unregistered again, sending unwanted add / remove udev events to > userspace. > >

[PATCH] drm/amdgpu: Bail earlier when amdgpu.cik_/si_support is not set to 1

2019-10-10 Thread Hans de Goede
Bail from the pci_driver probe function instead of from the drm_driver load function. This avoid /dev/dri/card0 temporarily getting registered and then unregistered again, sending unwanted add / remove udev events to userspace. Specifically this avoids triggering the (userspace) bug fixed by this

Re: [PATCH v4 2/3] drm/rockchip: Add optional support for CRTC gamma LUT

2019-10-10 Thread Ilia Mirkin
On Thu, Oct 10, 2019 at 12:01 PM Sean Paul wrote: > > > > +static int vop_crtc_atomic_check(struct drm_crtc *crtc, > > > > + struct drm_crtc_state *crtc_state) > > > > +{ > > > > + struct vop *vop = to_vop(crtc); > > > > + > > > > + if (vop->lut_regs && crtc_st

Re: [PATCH v4 2/3] drm/rockchip: Add optional support for CRTC gamma LUT

2019-10-10 Thread Sean Paul
/snip > > > +static void vop_crtc_write_gamma_lut(struct vop *vop, struct drm_crtc > > > *crtc) > > > +{ > > > + struct drm_color_lut *lut = crtc->state->gamma_lut->data; > > > + unsigned int i; > > > + > > > + for (i = 0; i < crtc->gamma_size; i++) { > > > + u32 word; >

[Bug 111968] Navi10 null pointer dereference in kernel 5.4 while running Vulkan CTS

2019-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111968 --- Comment #1 from Alex Deucher --- I think that's a bug in dma-buf fixed with this patch: https://cgit.freedesktop.org/drm/drm-misc/commit/?id=7fbd0782bf94d46993a7e5c08c0feda8dcab1f76 -- You are receiving this mail because: You are the assig

[Bug 111968] Navi10 null pointer dereference in kernel 5.4 while running Vulkan CTS

2019-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111968 Alex Deucher changed: What|Removed |Added Attachment #145698|text/x-log |text/plain mime type|

[Bug 111968] Navi10 null pointer dereference in kernel 5.4 while running Vulkan CTS

2019-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111968 Bug ID: 111968 Summary: Navi10 null pointer dereference in kernel 5.4 while running Vulkan CTS Product: DRI Version: DRI git Hardware: All OS: All

Re: [PATCH] Revert "drm/msm: dpu: Add modeset lock checks where applicable"

2019-10-10 Thread Daniel Vetter
On Thu, Oct 10, 2019 at 5:13 PM Sean Paul wrote: > > From: Sean Paul > > This reverts commit 1dfdb0e107dbe6ebff3f6bbbe4aad0b5aa87bba4. > > As Daniel mentions in his email [1], non-blocking commits don't hold the > modeset locks, so we can safely access state as long as these functions > are in th

[PATCH] Revert "drm/msm: dpu: Add modeset lock checks where applicable"

2019-10-10 Thread Sean Paul
From: Sean Paul This reverts commit 1dfdb0e107dbe6ebff3f6bbbe4aad0b5aa87bba4. As Daniel mentions in his email [1], non-blocking commits don't hold the modeset locks, so we can safely access state as long as these functions are in the commit path. I'm not entirely sure if these have always been i

Re: [pull] amdgpu/kfd, radeon, ttm drm-next-5.5

2019-10-10 Thread Daniel Vetter
On Thu, Oct 10, 2019 at 4:37 PM Koenig, Christian wrote: > Am 10.10.19 um 16:34 schrieb Alex Deucher: > > AOn Thu, Oct 10, 2019 at 5:54 AM Daniel Vetter > > wrote: > >> On Thu, Oct 10, 2019 at 6:17 AM Alex Deucher wrote: > >>> [SNIP] > >>> Christian König (22): > >>>drm/amdgpu: use movi

Re: [pull] amdgpu/kfd, radeon, ttm drm-next-5.5

2019-10-10 Thread Koenig, Christian
Am 10.10.19 um 16:34 schrieb Alex Deucher: > AOn Thu, Oct 10, 2019 at 5:54 AM Daniel Vetter wrote: >> On Thu, Oct 10, 2019 at 6:17 AM Alex Deucher wrote: >>> [SNIP] >>> Christian König (22): >>>drm/amdgpu: use moving fence instead of exclusive for VM updates >>>drm/amdgpu: reserve

Re: [pull] amdgpu/kfd, radeon, ttm drm-next-5.5

2019-10-10 Thread Alex Deucher
AOn Thu, Oct 10, 2019 at 5:54 AM Daniel Vetter wrote: > > On Thu, Oct 10, 2019 at 6:17 AM Alex Deucher wrote: > > > > Hi Dave, Daniel, > > > > New stuff for 5.5. There's an export of a cgroup function that > > Tejun acked for merging through the drm tree. kfd uses it to handle > > permissions in

Re: [PATCH] dma-buf/resv: fix exclusive fence get

2019-10-10 Thread Koenig, Christian
Hi Qiang, oh, good point. Yes it certainly should. Looks like I accidentally pushed it to the wrong branch. Thanks, Christian. Am 10.10.19 um 16:27 schrieb Qiang Yu: > Hi Chris, > > This fix has been pushed to drm-misc-next for a while. But Linux > 5.4-rc kernels still does not have this fix. >

[PULL] drm-intel-fixes

2019-10-10 Thread Rodrigo Vivi
Hi Dave and Daniel, This pull request includes the ones we missed for -rc1 drm-intel-next-fixes-2019-09-26 & drm-intel-next-fixes-2019-09-19 plus few fixes for execlists requests and CML display. Here goes drm-intel-fixes-2019-10-10: - Fix CML display by adding a missing ID. - Drop redundant list

Re: [PATCH] dma-buf/resv: fix exclusive fence get

2019-10-10 Thread Qiang Yu
Hi Chris, This fix has been pushed to drm-misc-next for a while. But Linux 5.4-rc kernels still does not have this fix. Should it be also pushed to drm-misc-fixes? Thanks, Qiang On Sun, Sep 22, 2019 at 8:50 PM Chris Wilson wrote: > > Quoting Chris Wilson (2019-09-22 13:17:19) > > Quoting Qiang

Re: [PATCH 2/3] drm/amdgpu/powerplay: Use swap() where appropriate

2019-10-10 Thread Alex Deucher
On Thu, Oct 10, 2019 at 9:12 AM Ville Syrjala wrote: > > From: Ville Syrjälä > > @swap@ > identifier TEMP; > expression A,B; > @@ > - TEMP = A; > - A = B; > - B = TEMP; > + swap(A, B); > > @@ > type T; > identifier swap.TEMP; > @@ > ( > - T TEMP; > | > - T TEMP = {...}; > ) > ... when != TEMP > >

Re: [PATCH 1/3] drm/amd/display: Use swap() where appropriate

2019-10-10 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Oct 10, 2019 at 9:48 AM Kazlauskas, Nicholas wrote: > > On 2019-10-10 9:11 a.m., Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Mostly a cocci-job, but it flat out refused to remove the > > declaration in drivers/gpu/drm/amd/display/dc/core/dc.c so > > had t

Re: [PATCH] drm/scheduler: make unexported items static

2019-10-10 Thread Alex Deucher
On Thu, Oct 10, 2019 at 2:55 AM Ben Dooks wrote: > > The drm_sched_fence_ops_{scheduled,finished} are not exported > from the file so make them static to avoid the following > warnings from sparse: > > drivers/gpu/drm/scheduler/sched_fence.c:131:28: warning: symbol > 'drm_sched_fence_ops_schedule

Re: [PATCH 2/4] media: bdisp: fix memleak on release

2019-10-10 Thread Fabien DESSENNE
Hi Johan Thank you for the patch BR Fabien On 10/10/2019 3:13 PM, Johan Hovold wrote: > If a process is interrupted while accessing the video device and the > device lock is contended, release() could return early and fail to free > related resources. > > Note that the return value of the v4l2

Re: [PATCH] drm/edid: Add 6 bpc quirk for SDC panel in Lenovo G50

2019-10-10 Thread Alex Deucher
On Wed, Oct 9, 2019 at 3:12 AM Kai-Heng Feng wrote: > > > > > On Jun 6, 2019, at 16:04, Kai-Heng Feng wrote: > > > > Hi, > > > > at 11:30, Kai-Heng Feng wrote: > > > >> Another panel that needs 6BPC quirk. > > > > Please include this patch if possible. > > Another gentle ping. Reviewed and push

[PATCH v4 3/3] drm/lima: add __GFP_NOWARN flag to all dma_alloc_wc

2019-10-10 Thread Qiang Yu
This prevent CMA printing dumy "PFNs busy" info which is caused by alloc fail re-try case. Signed-off-by: Qiang Yu --- drivers/gpu/drm/lima/lima_device.c | 2 +- drivers/gpu/drm/lima/lima_vm.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/lima/lima_

[PATCH v4 1/3] drm/lima: use drm_gem_shmem_helpers

2019-10-10 Thread Qiang Yu
Do not need to maintain our own shmem memory management code as drm_gem_shmem_helpers provides it. And we can also benifit from the work of others with shared code. This is also a preparation for implementing buffer madv. Signed-off-by: Qiang Yu --- drivers/gpu/drm/lima/Kconfig | 1 +

[PATCH v4 2/3] drm/lima: use drm_gem_(un)lock_reservations

2019-10-10 Thread Qiang Yu
Simplify the driver code with DRM GEM helper function. v2: improve commit comment. Signed-off-by: Qiang Yu --- drivers/gpu/drm/lima/lima_gem.c | 64 - 1 file changed, 6 insertions(+), 58 deletions(-) diff --git a/drivers/gpu/drm/lima/lima_gem.c b/drivers/gpu/drm

[PATCH v4 0/3] drm/lima: simplify driver by using more drm helpers

2019-10-10 Thread Qiang Yu
By using shared drm helpers: 1. drm_gem_(un)lock_reservations 2. drm_gem_shmem_helpers we can simplify lima driver a lot and benifit from updates to these functions. Patch series is based on drm-misc-next branch v2: Add drm_gem_objects_lookup_user and use it for driver which pass user GEM handles

Re: [PATCH] drm/tiny: Kconfig: Remove always-y THERMAL dep. from TINYDRM_REPAPER

2019-10-10 Thread Noralf Trønnes
Den 01.10.2019 12.58, skrev Noralf Trønnes: > > > Den 27.09.2019 19.42, skrev Ulf Magnusson: >> Commit 554b3529fe01 ("thermal/drivers/core: Remove the module Kconfig's >> option") changed the type of THERMAL from tristate to bool, so >> THERMAL || !THERMAL is now always y. Remove the redundant

Re: [PATCH 0/4] treewide: fix interrupted release

2019-10-10 Thread Daniel Vetter
On Thu, Oct 10, 2019 at 03:13:29PM +0200, Johan Hovold wrote: > Two old USB drivers had a bug in them which could lead to memory leaks > if an interrupted process raced with a disconnect event. > > Turns out we had a few more driver in other subsystems with the same > kind of bug in them. > > Not

Re: [PATCH] drm/plane: Clarify our expectations for src/dst rectangles

2019-10-10 Thread Maarten Lankhorst
Op 10-10-2019 om 15:07 schreef Ville Syrjälä: > On Thu, Oct 10, 2019 at 02:46:26PM +0200, Maarten Lankhorst wrote: >> Op 10-10-2019 om 14:36 schreef Ville Syrjälä: >>> On Thu, Oct 10, 2019 at 01:29:17PM +0200, Maarten Lankhorst wrote: The rectangles are usually clipped, but it can be useful to

Re: [PATCH 1/3] drm/amd/display: Use swap() where appropriate

2019-10-10 Thread Kazlauskas, Nicholas
On 2019-10-10 9:11 a.m., Ville Syrjala wrote: > From: Ville Syrjälä > > Mostly a cocci-job, but it flat out refused to remove the > declaration in drivers/gpu/drm/amd/display/dc/core/dc.c so > had to do that part manually. > > @swap@ > identifier TEMP; > expression A,B; > @@ > - TEMP = A; > - A

Re: [PATCH -next] drm/vkms: Remove duplicated include from vkms_drv.c

2019-10-10 Thread Daniel Vetter
On Thu, Oct 10, 2019 at 11:52:13AM +, YueHaibing wrote: > Remove duplicated include. > > Signed-off-by: YueHaibing Applied, thanks. -Daniel > --- > drivers/gpu/drm/vkms/vkms_drv.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkm

Re: linux-next: build failure after merge of the tip tree

2019-10-10 Thread Daniel Vetter
On Thu, Oct 10, 2019 at 10:23:21PM +1100, Stephen Rothwell wrote: > Hi Ingo, > > On Thu, 10 Oct 2019 10:02:07 +0200 Ingo Molnar wrote: > > > > I suspect -next will have to carry this semantic merge conflict > > resolution until the DRM tree is merged upstream. > > Yep, its not a real problem, I

Re: [PATCH 1/6] drm/gem: refine drm_gem_objects_lookup

2019-10-10 Thread Daniel Vetter
On Thu, Oct 10, 2019 at 10:02:31AM +0800, Qiang Yu wrote: > On Wed, Oct 9, 2019 at 10:57 PM Daniel Vetter wrote: > > > > On Fri, Sep 27, 2019 at 08:09:52AM +0800, Qiang Yu wrote: > > > On Thu, Sep 26, 2019 at 11:01 PM Rob Herring wrote: > > > > > > > > On Thu, Sep 26, 2019 at 9:12 AM Qiang Yu wr

Re: [PATCH 4/7] drm/meson: plane: add support for AFBC mode for OSD1 plane

2019-10-10 Thread Neil Armstrong
Hi Ayan, On 10/10/2019 15:26, Ayan Halder wrote: > On Thu, Oct 10, 2019 at 11:25:23AM +0200, Neil Armstrong wrote: >> This adds all the OSD configuration plumbing to support the AFBC decoders >> path to display of the OSD1 plane. >> >> The Amlogic GXM and G12A AFBC decoders are integrated very dif

Re: [PATCH] drm/dp-mst: Drop connection_mutex check

2019-10-10 Thread Daniel Vetter
On Wed, Oct 09, 2019 at 06:46:38PM -0400, Lyude Paul wrote: > oh, completely forgot about this one > > Reviewed-by: Lyude Paul Thanks for your review, applied to drm-misc-next. -Daniel > > On Thu, 2019-10-10 at 00:41 +0200, Daniel Vetter wrote: > > Private atomic objects have grown their own lo

Re: [1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM

2019-10-10 Thread Noralf Trønnes
Den 09.10.2019 15.31, skrev Maxime Ripard: > On Wed, Oct 09, 2019 at 02:48:20PM +0200, Noralf Trønnes wrote: >> Den 09.10.2019 12.45, skrev Daniel Vetter: >>> On Tue, Oct 01, 2019 at 04:07:38PM +0200, Noralf Trønnes wrote: Hi drm-misc maintainers, I have just applied a patch to drm

  1   2   >