RE: [PATCH v5 0/5] Asynchronous flip implementation for i915

> -Original Message- > From: Michel Dänzer > Sent: Wednesday, July 29, 2020 1:04 PM > To: Kulkarni, Vandita ; Zanoni, Paulo R > ; Vetter, Daniel ; B S, > Karthik ; intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Shankar, Uma > ; nicholas.kazlaus...@amd.com >

Re: [PATCH v2] fbmem: pull fbcon_update_vcs() out of fb_set_var()

On Thu, Jul 30, 2020 at 07:47:14PM +0900, Tetsuo Handa wrote: > syzbot is reporting OOB read bug in vc_do_resize() [1] caused by memcpy() > based on outdated old_{rows,row_size} values, for resize_screen() can > recurse into vc_do_resize() which changes vc->vc_{cols,rows} that outdates >

[drm:ttm-refactor-mem-manager-rename 51/82] drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:646:2: error: implicit declaration of function 'ttm_bo_man_fini'; did you mean

tree: git://people.freedesktop.org/~airlied/linux.git ttm-refactor-mem-manager-rename head: 1ae584657d6f1ba364af58dc0d35f098d8726967 commit: 2d8e0cde4a7ff32b9b6e369fc33c327e1d32f90a [51/82] drm/vmwgfx: takedown vram manager config: i386-randconfig-r006-20200803 (attached as .config) compiler

Re: [00/59] ttm misc cleanups, mem refactoring, rename objects. (v2)

On Tue, 4 Aug 2020 at 12:56, Dave Airlie wrote: > > I've decided to repost the whole queue this time, it has a few driver > patches up front that are just cleanups. Sample branch is https://cgit.freedesktop.org/~airlied/linux/log/?h=ttm-refactor-mem-manager-rename Dave.

[PATCH 59/59] drm/ttm: rename ttm_mem_reg to ttm_resource.

From: Dave Airlie This name better reflects what the object does. I didn't rename all the pointers it seemed too messy. Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 6 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c| 4 +-

[PATCH 41/59] drm/radeon/ttm: use wrapper to access memory manager

From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/radeon/radeon_gem.c | 2 +- drivers/gpu/drm/radeon/radeon_ttm.c | 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_gem.c b/drivers/gpu/drm/radeon/radeon_gem.c index

[PATCH 57/59] drm/ttm: rename bo manager to range manager.

From: Dave Airlie The generic manager is called the range manager now, rename the file and some internals. Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/Makefile | 2 +- .../{ttm_bo_manager.c => ttm_range_manager.c} | 26 +-- 2 files changed, 14

[PATCH 55/59] drm/ttm: drop type manager has_type

From: Dave Airlie under driver control, this flag isn't needed anymore, remove the API that used to access it, and consoldiate with the used api. Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 2 +-

[PATCH 58/59] drm/ttm: rename ttm_mem_type_manager -> ttm_resource_manager.

From: Dave Airlie This name makes a lot more sense, since these are about managing driver resources rather than just memory ranges. Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c| 2 +-

[PATCH 56/59] drm/ttm: add a wrapper for checking if manager is in use

From: Dave Airlie This converts vmwgfx over to using an interface to set the in use and check the in use flag. Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nouveau_ttm.c | 1 - drivers/gpu/drm/ttm/ttm_bo.c | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 14 +++---

[PATCH 50/59] drm/nouveau/ttm: move to driver allocated manager

From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nouveau_ttm.c | 45 +++ 1 file changed, 32 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_ttm.c b/drivers/gpu/drm/nouveau/nouveau_ttm.c index

[PATCH 53/59] drm/ttm: drop man->bdev link.

From: Dave Airlie This link isn't needed anymore, drop it from the init interface. Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 2 +- drivers/gpu/drm/nouveau/nouveau_ttm.c | 6 ++

[PATCH 48/59] drm/vmwgfx/ttm: move thp to driver managed

From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/vmwgfx/vmwgfx_thp.c | 32 +++-- 1 file changed, 21 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_thp.c b/drivers/gpu/drm/vmwgfx/vmwgfx_thp.c index 720a24214c74..1cefd9c1e8ea

[PATCH 44/59] drm/ttm: allow drivers to provide their own manager subclasses

From: Dave Airlie This will get removed eventually and all drivers will use this. Signed-off-by: Dave Airlie --- include/drm/ttm/ttm_bo_driver.h | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/include/drm/ttm/ttm_bo_driver.h b/include/drm/ttm/ttm_bo_driver.h

[PATCH 54/59] drm/ttm: drop list of memory managers from device. (v2)

From: Dave Airlie The driver now controls these, the core just controls the system memory one. v2: init sysman explicitly and assign it as a driver manager to simplify the lookup sequence. Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo.c| 6 +++---

[PATCH 52/59] drm/amdgpu/ttm: remove man->bdev references.

From: Dave Airlie Just store the device in the private so the link can be removed from the manager Reviewed-by: Christian König Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

[PATCH 46/59] drm/ttm: make ttm_range_man_init/takedown take type + args

From: Dave Airlie This makes it easier to move these to a driver allocated system Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 15 +--- drivers/gpu/drm/drm_gem_vram_helper.c | 10 drivers/gpu/drm/nouveau/nouveau_ttm.c | 22 +++---

[PATCH 49/59] drm/vmwgfx/gmrid: convert to driver controlled allocation.

From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c | 32 +++ 1 file changed, 18 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c b/drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c index

[PATCH 45/59] drm/amdgpu/ttm: use bo manager subclassing for vram/gtt mgrs

From: Dave Airlie Reviewed-by: Christian König Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 35 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 36 +--- 2 files changed, 44 insertions(+), 27 deletions(-) diff --git

[PATCH 51/59] drm/ttm: drop priv pointer in memory manager

From: Dave Airlie This isn't needed anymore by any drivers. Reviewed-by: Christian König Signed-off-by: Dave Airlie --- include/drm/ttm/ttm_bo_driver.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/drm/ttm/ttm_bo_driver.h b/include/drm/ttm/ttm_bo_driver.h index

[PATCH 47/59] drm/ttm: move range manager to subclassed driver allocation

From: Dave Airlie Reviewed-by: Christian König Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo_manager.c | 31 +--- 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo_manager.c b/drivers/gpu/drm/ttm/ttm_bo_manager.c

[PATCH 29/59] drm/vram_helper: call explicit mm takedown

From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/drm_gem_vram_helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c b/drivers/gpu/drm/drm_gem_vram_helper.c index d7c0fdf82eb6..2099851c017e 100644 ---

[PATCH 28/59] drm/vmwgfx: takedown vram manager

From: Dave Airlie Don't bother returning EBUSY, nobody cares enough, if the driver has a problem, it should deal with it. Signed-off-by: Dave Airlie --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 14 +- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 1 + drivers/gpu/drm/vmwgfx/vmwgfx_thp.c |

[PATCH 26/59] drm/ttm: start allowing drivers to use new takedown path (v2)

From: Dave Airlie Allow the takedown path callback to be optional as well. v2: use fini for range manager Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo.c | 12 +++- drivers/gpu/drm/ttm/ttm_bo_manager.c | 21 +++-- include/drm/ttm/ttm_bo_driver.h

[PATCH 25/59] drm/ttm: make some inline helper functions for cleanup paths. (v2)

From: Dave Airlie The disable path is just temporary for now, it will be dropped once has_type is gone in a later patch. v2: add docs. rename to ttm_mem_type_manager namespace Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo.c| 6 ++ include/drm/ttm/ttm_bo_driver.h | 26

[PATCH 33/59] drm/vmwgfx: fix gmrid takedown paths to new interface

From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 9 - drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 1 + drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c | 11 --- 3 files changed, 13 insertions(+), 8 deletions(-) diff --git

[PATCH 32/59] drm/qxl/ttm: use new takedown path

From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/qxl/qxl_ttm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c b/drivers/gpu/drm/qxl/qxl_ttm.c index bfbd2c5c38a2..0f7071829056 100644 --- a/drivers/gpu/drm/qxl/qxl_ttm.c +++

[PATCH 42/59] drm/vmwgfx/ttm: use wrapper to access memory manager

From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 23 +++ drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c | 4 ++-- drivers/gpu/drm/vmwgfx/vmwgfx_thp.c | 4 ++-- 3 files changed, 18 insertions(+), 13 deletions(-) diff

[PATCH 35/59] drm/ttm: make TTM responsible for cleaning system only.

From: Dave Airlie Drivers should all be cleaning up their memory managers themselves now, so let the core just clean the system one up. Remove the legacy cleaning interface. Reviewed-by: Christian König Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo.c| 54

[PATCH 37/59] drm/amdgfx/ttm: use wrapper to get ttm memory managers

From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 3 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 6 +++--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 ++--- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 12 +--

[PATCH 36/59] drm/ttm: add wrapper to get manager from bdev.

From: Dave Airlie This will allow different abstractions later. Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo.c | 34 +++ drivers/gpu/drm/ttm/ttm_bo_util.c | 20 +- drivers/gpu/drm/ttm/ttm_bo_vm.c | 2 +-

[PATCH 43/59] drm/ttm: rename manager variable to make sure wrapper is used.

From: Dave Airlie Other users of this should notice this change and switch to wrapper. Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo.c| 2 +- include/drm/ttm/ttm_bo_driver.h | 7 +-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git

[PATCH 38/59] drm/vram-helper: use wrapper to access memory managers

From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/drm_gem_vram_helper.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c b/drivers/gpu/drm/drm_gem_vram_helper.c index 2099851c017e..a01768adb96d 100644 ---

[PATCH 23/59] drm/ttm: purge old manager init path.

From: Dave Airlie Reviewed-by: Christian König Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo.c | 19 -- drivers/gpu/drm/ttm/ttm_bo_manager.c | 29 ++-- include/drm/ttm/ttm_bo_api.h | 18 -

[PATCH 34/59] drm/ttm: remove range manager legacy takedown path

From: Dave Airlie Now all drivers have been converted, drop the non-driver path. Reviewed-by: Christian König Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo_manager.c | 28 +--- 1 file changed, 9 insertions(+), 19 deletions(-) diff --git

[PATCH 31/59] drm/radeon/ttm: use new takedown paths

From: Dave Airlie Reviewed-by: Christian König Signed-off-by: Dave Airlie --- drivers/gpu/drm/radeon/radeon_ttm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c index 84c02b4529c0..76b409af9476

[PATCH 39/59] drm/nouveau/ttm: use wrapper to access memory managers

From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nouveau_ttm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_ttm.c b/drivers/gpu/drm/nouveau/nouveau_ttm.c index bb310719e3f5..cc6cf04553dd 100644 ---

[PATCH 11/59] drm/qxl/ttm: call ttm manager debug (v2)

From: Dave Airlie v2: use the new exported interface. This code was poking inside a struct and assuming it was a drm_mm at the start. Call the proper API. Signed-off-by: Dave Airlie --- drivers/gpu/drm/qxl/qxl_ttm.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git

[PATCH 30/59] drm/nouveau: use new cleanup paths

From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nouveau_ttm.c | 41 --- 1 file changed, 30 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_ttm.c b/drivers/gpu/drm/nouveau/nouveau_ttm.c index

[PATCH 40/59] drm/qxl/ttm: use wrapper to access memory manager

From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/qxl/qxl_ttm.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c b/drivers/gpu/drm/qxl/qxl_ttm.c index 0f7071829056..57c96f7271db 100644 ---

[PATCH 24/59] drm/ttm: pass man around instead of mem_type in some places

From: Dave Airlie This makes it easier to cleanup things Reviewed-by: Christian König Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c

[PATCH 18/59] drm/vram_helper: use new ttm manager init function

From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/drm_gem_vram_helper.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c b/drivers/gpu/drm/drm_gem_vram_helper.c index c20aee2fddf3..d7c0fdf82eb6 100644 ---

[PATCH 27/59] drm/amdgpu/ttm: use new takedown path

From: Dave Airlie Reviewed-by: Christian König Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 15 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 10 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 2 ++

[PATCH 22/59] drm/ttm: convert system manager init to new code.

From: Dave Airlie Remove the exit path, since this can't fail now. Reviewed-by: Christian König Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo.c | 30 +- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c

[PATCH 15/59] drm/amdgpu/ttm: init managers from the driver side.

From: Dave Airlie Use new init calls to unwrap manager init Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 19 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 37 +++- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 4 +--

[PATCH 21/59] drm/vmwgfx/ttm: switch gmrid allocator to new init paths.

From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 17 --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c | 21 --- 3 files changed, 19 insertions(+), 21 deletions(-)

[PATCH 03/59] nouveau: use ttm populate mapping functions. (v2)

From: Dave Airlie Instead of rolling driver copies of them. v2: cleanup return handling (Ben) Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nouveau_bo.c | 38 ++-- 1 file changed, 2 insertions(+), 36 deletions(-) diff --git

[PATCH 14/59] drm/ttm: provide a driver-led init path for range mm manager. (v2)

From: Dave Airlie This lets the generic range mm manager be initialised by the driver. v2: add docs. rename api to range_man_init for now. v1-Reviewed-by: Christian König Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo_manager.c | 23 ---

[PATCH 02/59] drm/vmwgfx: drop bo map/unmap dma functions.

From: Dave Airlie The map one was used once, just inline it, and drop them both. Signed-off-by: Dave Airlie --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h| 2 - drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c | 46 +++--- 2 files changed, 6 insertions(+), 42 deletions(-) diff

[PATCH 06/59] drm/ttm: use a helper for unlocked moves to the lru tail

From: Dave Airlie The pattern was repeated a few times, just make an inline for it. Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo.c| 8 ++-- drivers/gpu/drm/ttm/ttm_bo_vm.c | 4 +--- include/drm/ttm/ttm_bo_driver.h | 11 --- 3 files changed, 11 insertions(+), 12

[PATCH 01/59] drm/vmwgfx: consolidate ttm object creation and populate

From: Dave Airlie These two functions has the same code in them, create a common helper function instead. Signed-off-by: Dave Airlie --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h| 4 ++ drivers/gpu/drm/vmwgfx/vmwgfx_mob.c| 60 ++

[PATCH 19/59] drm/nouveau: use new memory manager init paths

From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nouveau_ttm.c | 43 --- 1 file changed, 19 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_ttm.c b/drivers/gpu/drm/nouveau/nouveau_ttm.c index

[PATCH 17/59] drm/qxl/ttm: use new init path for manager

From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/qxl/qxl_ttm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c b/drivers/gpu/drm/qxl/qxl_ttm.c index 3e664bb58764..bfbd2c5c38a2 100644 --- a/drivers/gpu/drm/qxl/qxl_ttm.c +++

[PATCH 07/59] drm/vram-helper: remove populate/unpopulate

From: Dave Airlie The default path for populate/unpopulate is already this. Signed-off-by: Dave Airlie --- drivers/gpu/drm/drm_gem_vram_helper.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c b/drivers/gpu/drm/drm_gem_vram_helper.c index

[PATCH 20/59] drm/vmwgfx/ttm: convert vram mm init to new code paths

From: Dave Airlie Split out the vram thp init path vs the range manager init. Signed-off-by: Dave Airlie --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 25 +++-- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 4 +--- drivers/gpu/drm/vmwgfx/vmwgfx_thp.c | 12 3 files

[PATCH 08/59] drm/ttm: export memory type debug entrypoint.

From: Dave Airlie As suggested on review, just export the memory type debug for drivers to use, while also making the debug callback optional (don't need to test for system as it won't init it). rename it to be more consistent with object name for now. (we may rename all the objects later.)

[PATCH 12/59] drm/vram-helper: call the ttm manager debug function

From: Dave Airlie This code was assuming there was a drm_mm here, don't do that call the correct API. v2: use the new exported interface. Signed-off-by: Dave Airlie --- drivers/gpu/drm/drm_gem_vram_helper.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

[PATCH 04/59] qxl/ttm: drop the unusued no wait flag to reserve function

From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/qxl/qxl_cmd.c| 2 +- drivers/gpu/drm/qxl/qxl_ioctl.c | 2 +- drivers/gpu/drm/qxl/qxl_object.c | 4 ++-- drivers/gpu/drm/qxl/qxl_object.h | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH 13/59] drm/ttm: split the mm manager init code (v2)

From: Dave Airlie This will allow the driver to control the ordering here better. Eventually the old path will be removed. v2: add docs for new APIs. rename new path to ttm_mem_type_manager_init/set_used(for now) Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo.c| 34

[PATCH 16/59] drm/radeon: use new ttm man init path

From: Dave Airlie Use the new common manager init path. Signed-off-by: Dave Airlie --- drivers/gpu/drm/radeon/radeon_ttm.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c index

[PATCH 09/59] drm/nouveau/ttm: don't fill in blank ttm debug callback

From: Dave Airlie Acked-by: Christian König Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nouveau_ttm.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_ttm.c b/drivers/gpu/drm/nouveau/nouveau_ttm.c index b0012021ae12..6de762a0c229 100644

[PATCH 10/59] drm/vmwgfx/gmrid: don't provide pointless ttm debug callback

From: Dave Airlie Acked-by: Christian König Signed-off-by: Dave Airlie --- drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c b/drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c index

[00/59] ttm misc cleanups, mem refactoring, rename objects. (v2)

I've decided to repost the whole queue this time, it has a few driver patches up front that are just cleanups. I've reorodered things a little since the first posting, but not much. misc core/driver cleanups mem type manager debug callback cleanup (reordered) new mem type manager init path new

[PATCH 05/59] drm/ttm/amdgpu: consolidate ttm reserve paths

From: Dave Airlie Drop the WARN_ON and consolidate the two paths into one. Use the consolidate slowpath in the execbuf utils code. Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 2 +- drivers/gpu/drm/ttm/ttm_execbuf_util.c | 12 +--

Re: [PATCH 15/49] drm/ttm: make some inline helper functions for cleanup paths.

On Fri, 31 Jul 2020 at 23:07, Christian König wrote: > > Am 31.07.20 um 06:04 schrieb Dave Airlie: > > From: Dave Airlie > > > > Signed-off-by: Dave Airlie > > --- > > drivers/gpu/drm/ttm/ttm_bo.c| 6 ++ > > include/drm/ttm/ttm_bo_driver.h | 12 > > 2 files changed, 14

gma500: monitor-dependent failure to boot FB console (psbdrmfb)

Dear kernel / GPU enthusiasts! This list is listed in the kernel MAINTAINERS file for GMA500 GPU kernel module. My message is either a call for help (not a mission-critical issue) or troubleshooting information useful to fix an outstanding issue in the GMA500 kernel driver? This

Re: [PATCH 39/49] drm/ttm: make ttm_bo_man_init/takedown take type + args

On Fri, 31 Jul 2020 at 23:32, Christian König wrote: > > Am 31.07.20 um 06:05 schrieb Dave Airlie: > > From: Dave Airlie > > > > This makes it easier to move these to a driver allocated system > > No, sorry that looks like going into the wrong direction to me. > > I already wanted to suggest to

Re: linux-next: manual merge of the hmm tree with the drm tree

On Tue, Aug 4, 2020 at 9:19 AM Jason Gunthorpe wrote: > > On Thu, Jul 30, 2020 at 10:31:45AM -0700, Ralph Campbell wrote: > > > > On 7/30/20 5:03 AM, Jason Gunthorpe wrote: > > > On Thu, Jul 30, 2020 at 07:21:10PM +1000, Stephen Rothwell wrote: > > > > Hi all, > > > > > > > > Today's linux-next

[PATCH v2 10/24] virtio_gpu: correct tags for config space fields

Since gpu is a modern-only device, tag config space fields as having little endian-ness. Signed-off-by: Michael S. Tsirkin --- include/uapi/linux/virtio_gpu.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/uapi/linux/virtio_gpu.h

[PATCH v5] Add support for KeemBay DRM driver

This is a new DRM driver for Intel's KeemBay SOC. The SoC couples an ARM Cortex A53 CPU with an Intel Movidius VPU. This driver is tested with the KMB EVM board which is the refernce baord for Keem Bay SOC. The SOC's display pipeline is as follows +--++-+

[Bug 203905] amdgpu:actual_brightness has unreal/wrong value

https://bugzilla.kernel.org/show_bug.cgi?id=203905 --- Comment #10 from Alexander Monakov (amona...@gmail.com) --- Proposed patch: https://lore.kernel.org/lkml/20200803200218.2167-1-amona...@ispras.ru/ -- You are receiving this mail because: You are watching the assignee of the bug.

Re: [PATCH][next] fbdev: Use fallthrough pseudo-keyword

On 8/3/20 14:41, Sam Ravnborg wrote: > On Tue, Jul 07, 2020 at 04:05:39PM -0500, Gustavo A. R. Silva wrote: >> Replace the existing /* fall through */ comments and its variants with >> the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary >> fall-through markings when it is the

Re: [PATCH][next] fbdev: Use fallthrough pseudo-keyword

On Mon, Aug 03, 2020 at 12:52:40PM -0700, Joe Perches wrote: > On Mon, 2020-08-03 at 21:41 +0200, Sam Ravnborg wrote: > > On Tue, Jul 07, 2020 at 04:05:39PM -0500, Gustavo A. R. Silva wrote: > > > Replace the existing /* fall through */ comments and its variants with > > > the new pseudo-keyword

Re: [PATCH][next] fbdev: Use fallthrough pseudo-keyword

On Mon, 2020-08-03 at 21:41 +0200, Sam Ravnborg wrote: > On Tue, Jul 07, 2020 at 04:05:39PM -0500, Gustavo A. R. Silva wrote: > > Replace the existing /* fall through */ comments and its variants with > > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary > > fall-through

Re: [RFC][PATCH] regulator: rpi-panel: Add regulator/backlight driver for RPi panel

On Mon, Aug 03, 2020 at 09:21:25AM +0200, Marek Vasut wrote: > On 8/1/20 3:16 AM, Mark Brown wrote: > > I see, so this is the remaining bits. Perhaps the binding might help me > > see how things fit together - I don't know anything about the system > > really. It's not doing anything that looks

Re: [PATCH] video: fbdev: pvr2fb: initialize variables

Hi Tom, On Mon, Jul 20, 2020 at 12:18:45PM -0700, t...@redhat.com wrote: > From: Tom Rix > > clang static analysis reports this repesentative error > > pvr2fb.c:1049:2: warning: 1st function call argument > is an uninitialized value [core.CallAndMessage] > if (*cable_arg) >

Re: [PATCH][next] fbdev: Use fallthrough pseudo-keyword

On Tue, Jul 07, 2020 at 04:05:39PM -0500, Gustavo A. R. Silva wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary > fall-through markings when it is the case. > > [1] >

[PATCH v11 11/12] drm/msm/a6xx: Add support for per-instance pagetables

Add support for using per-instance pagetables if all the dependencies are available. Signed-off-by: Jordan Crouse --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 53 +++ drivers/gpu/drm/msm/adreno/a6xx_gpu.h | 1 + drivers/gpu/drm/msm/msm_ringbuffer.h | 1 + 3 files

[PATCH v11 09/12] drm/msm: Add support to create a local pagetable

Add support to create a io-pgtable for use by targets that support per-instance pagetables. In order to support per-instance pagetables the GPU SMMU device needs to have the qcom,adreno-smmu compatible string and split pagetables enabled. Signed-off-by: Jordan Crouse ---

[PATCH v11 07/12] drm/msm: Add a context pointer to the submitqueue

Each submitqueue is attached to a context. Add a pointer to the context to the submitqueue at create time and refcount it so that it stays around through the life of the queue. GPU submissions can access the active context via the submitqueue instead of requiring it to be passed around from

[PATCH v11 10/12] drm/msm: Add support for private address space instances

Add support for allocating private address space instances. Targets that support per-context pagetables should implement their own function to allocate private address spaces. The default will return a pointer to the global address space. Signed-off-by: Jordan Crouse ---

[PATCH v11 00/12] iommu/arm-smmu: Add Adreno SMMU specific implementation

This series adds an Adreno SMMU implementation to arm-smmu to allow GPU hardware pagetable switching. The Adreno GPU has built in capabilities to switch the TTBR0 pagetable during runtime to allow each individual instance or application to have its own pagetable. In order to take advantage of

[PATCH v11 08/12] drm/msm: Set the global virtual address range from the IOMMU domain

Use the aperture settings from the IOMMU domain to set up the virtual address range for the GPU. This allows us to transparently deal with IOMMU side features (like split pagetables). Signed-off-by: Jordan Crouse --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 13 +++--

Re: [PATCH] omapfb/dss: Include the right header

On Mon, Jul 06, 2020 at 02:59:31PM +0200, Linus Walleij wrote: > The hdmi4.c and hdmi5.c files include the legacy GPIO > header but does not use any of the symbols > from this file. > > What it does use is the implicit inclusion of > leading to compile errors if we just drop this include. > >

Re: Re: Re: [PATCH v2 1/5] drm/mediatek: config component output by device node port

Hi, Frank: Frank Wunderlich 於 2020年8月3日 週一 下午6:43寫道： > > Hi > > Gesendet: Montag, 03. August 2020 um 01:47 Uhr > > Von: "Chun-Kuang Hu" > > > Now I just care about the bls to dpi. So in mediatek,disp.txt, you > > just need to add a Optional properties - port (input and output), and > > modify

Re: [PATCH 4/9] drm/msm/dsi: Add phy configuration for SDM630/636/660

On Mon, Aug 3, 2020 at 4:00 AM Vinod Koul wrote: > > On 26-07-20, 13:12, Konrad Dybcio wrote: > > These SoCs make use of the 14nm phy, but at different > > addresses than other 14nm units. > > > > Signed-off-by: Konrad Dybcio > > --- > > .../devicetree/bindings/display/msm/dsi.txt| 1 + > >

Re: [PATCH 2/2] dmabuf/tracing: Add dma-buf trace events

On Mon, 3 Aug 2020 14:47:19 + Kalesh Singh wrote: > +DECLARE_EVENT_CLASS(dma_buf_ref_template, > + > + TP_PROTO(struct task_struct *task, struct file *filp), > + > + TP_ARGS(task, filp), > + > + TP_STRUCT__entry( > + __field(u32, tgid) > + __field(u32,

[PATCH] MAINTAINERS: enlist Greg formally for console stuff

I did a few greps for main console data structures, and there's a few places outside of drivers/video/console: - a braille driver - a sisusbvga driver - fbcon, but I think that's fine if we leave that officially under fbdev maintainership - lots of stuff in drivers/tty/vt, which is already under

[Bug 207383] [Regression] 5.7 amdgpu/polaris11 gpf: amdgpu_atomic_commit_tail

https://bugzilla.kernel.org/show_bug.cgi?id=207383 --- Comment #115 from Duncan (1i5t5.dun...@cox.net) --- So 5.8.0 has been out for a few hours with the patch-fix, and I see Greg K-H has it applied to the 5.7 stable tree as well as 5.4 LTS (the bug was in 5.4 but latent, not exposed until

Re: [PATCH] drm: fix drm_dp_mst_port refcount leaks in drm_dp_mst_allocate_vcpi

Hi Xin Xong, I have seen insufficient vcpi ports issues with MST daisy chain. While running the IGT tests on MST, some times the vcpi ports are all used up. Due to this the atomic check fails and the flips start failing with ENOSPC.

Re: [PATCH] drm/nouveau: Drop mutex_lock_nested for atomic

Op 02-08-2020 om 20:18 schreef Daniel Vetter: > Purely conjecture, but I think the original locking inversion with the > legacy page flip code between flipping and ttm's bo move function > shoudn't exist anymore with atomic: With atomic the bo pinning and > actual modeset commit is completely

Re: [PATCH 00/49] ttm mem manager refactoring.

Am 03.08.20 um 09:12 schrieb Dave Airlie: On Fri, 31 Jul 2020 at 19:17, Christian König wrote: Am 31.07.20 um 06:04 schrieb Dave Airlie: I started pulling on a thread, and it led me down a hole. We might want to make that hole even bigger :) How about we rename the ttm_mem_reg into

Re: [PATCH] vgacon: fix out of bounds write to the scrollback buffer

On 8/3/20 11:47 AM, Greg KH wrote: > On Mon, Aug 03, 2020 at 10:45:07AM +0200, Daniel Vetter wrote: >> On Mon, Aug 3, 2020 at 10:26 AM Greg KH wrote: >>> >>> On Mon, Aug 03, 2020 at 10:08:43AM +0200, Jiri Slaby wrote: Hi, On 31. 07. 20, 7:22, 张云海 wrote: > Remove whitespace at

Re: [RFC][PATCH 2/2] dma-heap: Add a system-uncached heap

On 2020-07-29 06:16, John Stultz wrote: This adds a heap that allocates non-contiguous buffers that are marked as writecombined, so they are not cached by the CPU. This is useful, as most graphics buffers are usually not touched by the CPU or only written into once by the CPU. So when mapping

Re: [PATCH 4/9] drm/msm/dsi: Add phy configuration for SDM630/636/660

On 26-07-20, 13:12, Konrad Dybcio wrote: > These SoCs make use of the 14nm phy, but at different > addresses than other 14nm units. > > Signed-off-by: Konrad Dybcio > --- > .../devicetree/bindings/display/msm/dsi.txt| 1 + > drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 2 ++ >

Re: [Nouveau] [PATCH] drm/nouveau/acr: fix a coding style in nvkm_acr_lsfw_load_bl_inst_data_sig()

Reviewed-by: Karol Herbst On Mon, Aug 3, 2020 at 5:46 AM Jing Xiangfeng wrote: > > This patch performs the following changes: > 1. remove a redundant parentheses around the nvkm_acr_lsfw_add() calls > 2. do assignment before this if condition, it is more readable > > Signed-off-by: Jing

Re: [PATCH] vgacon: fix out of bounds write to the scrollback buffer

On Mon, Aug 03, 2020 at 10:45:07AM +0200, Daniel Vetter wrote: > On Mon, Aug 3, 2020 at 10:26 AM Greg KH wrote: > > > > On Mon, Aug 03, 2020 at 10:08:43AM +0200, Jiri Slaby wrote: > > > Hi, > > > > > > On 31. 07. 20, 7:22, 张云海 wrote: > > > > Remove whitespace at EOL > > > > > > I am fine with the

Re: [PATCH] vgacon: fix out of bounds write to the scrollback buffer

On Mon, Aug 3, 2020 at 10:26 AM Greg KH wrote: > > On Mon, Aug 03, 2020 at 10:08:43AM +0200, Jiri Slaby wrote: > > Hi, > > > > On 31. 07. 20, 7:22, 张云海 wrote: > > > Remove whitespace at EOL > > > > I am fine with the patch. However it should be sent properly (inline > > mail, having a PATCH

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

Hello everybody! I'm currently working on a writeback connector screenshooter for Weston. In order to test it, I'm using VKMS with Rodrigo's writeback connector patch .Here is the link with the MR in Weston

drm: list_add corruption followed by BUG (stack guard page was hit)

Hi! I've just got the following WARNING followed by a BUG on rc7. Maybe it's already a known issue, but here it is anyway. Cheers, -- Luis [ 38.001304] [ cut here ] [ 38.001312] list_add corruption. prev->next should be next (8fe713397b88), but was

  1   2   >