Re: [PATCH V2] drm/vkms: Decouple config data for configfs

2021-01-02 Thread Melissa Wen
Hi Sumera, Thanks for your patch. Please see some comments below. On 01/02, Sumera Priyadarsini wrote: > Currently, data for the device instance is held by vkms_device. > Add a separate type, vkms_config to contain configuration details > for the device and various modes to be later used by

Re: [PATCH] drm/amd/display: Fix pageflipping for XOrg in Linux 5.11+

2021-01-02 Thread Mario Kleiner
On Sat, Jan 2, 2021 at 7:51 PM Ilia Mirkin wrote: > On Sat, Jan 2, 2021 at 1:35 PM Mario Kleiner > wrote: > > I'm less sure about nouveau. It uses modifiers, but has atomic support > > only on nv50+ and that atomic support is off by default -- needs a > > nouveau.nouveau_atomic=1 boot parameter

Re: [PATCH] drm/amd/display: Fix pageflipping for XOrg in Linux 5.11+

2021-01-02 Thread Ilia Mirkin
On Sat, Jan 2, 2021 at 1:35 PM Mario Kleiner wrote: > I'm less sure about nouveau. It uses modifiers, but has atomic support > only on nv50+ and that atomic support is off by default -- needs a > nouveau.nouveau_atomic=1 boot parameter to switch it on. It seems to > enable modifier support

Re: [PATCH] drm/amd/display: Fix pageflipping for XOrg in Linux 5.11+

2021-01-02 Thread Mario Kleiner
On Sat, Jan 2, 2021 at 4:49 PM Bas Nieuwenhuizen wrote: > > On Sat, Jan 2, 2021 at 4:05 PM Mario Kleiner > wrote: > > > > On Sat, Jan 2, 2021 at 3:05 PM Bas Nieuwenhuizen > > wrote: > > > > > > I think the problem here is that application A can set the FB and then > > > application B can use

[Bug 211003] New: radeon "BUG: unable to handle page fault for address" when hot-unplugging another PCI-e device

2021-01-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211003 Bug ID: 211003 Summary: radeon "BUG: unable to handle page fault for address" when hot-unplugging another PCI-e device Product: Drivers Version: 2.5 Kernel Version:

Re: [PATCH] drm/amd/display: Fix pageflipping for XOrg in Linux 5.11+

2021-01-02 Thread Bas Nieuwenhuizen
On Sat, Jan 2, 2021 at 4:05 PM Mario Kleiner wrote: > > On Sat, Jan 2, 2021 at 3:05 PM Bas Nieuwenhuizen > wrote: > > > > I think the problem here is that application A can set the FB and then > > application B can use getfb2 (say ffmpeg). > > > Yes. That, and also the check for 'X' won't get us

Re: [PATCH] drm: Check actual format for legacy pageflip.

2021-01-02 Thread Mario Kleiner
On Sat, Jan 2, 2021 at 3:02 PM Bas Nieuwenhuizen wrote: > > With modifiers one can actually have different format_info structs > for the same format, which now matters for AMDGPU since we convert > implicit modifiers to explicit modifiers with multiple planes. > > I checked other drivers and it

Re: [PATCH] drm/amd/display: Fix pageflipping for XOrg in Linux 5.11+

2021-01-02 Thread Mario Kleiner
On Sat, Jan 2, 2021 at 3:05 PM Bas Nieuwenhuizen wrote: > > I think the problem here is that application A can set the FB and then > application B can use getfb2 (say ffmpeg). Yes. That, and also the check for 'X' won't get us far, because if i use my own software Psychtoolbox under Vulkan in

[PATCH] drm: Allow format change during legacy page-flip if driver is atomic.

2021-01-02 Thread Mario Kleiner
This is a slight improvement for legacy flipping, but also an attempted fix for a bug/regression introduced into Linux 4.11-rc. Commit 816853f9dc4057b6c7ee3c45ca9bd5905 ("drm/amd/display: Set new format info for converted metadata.") fixes the getfb2 ioctl, but in exchange it completely breaks

Re: [PATCH] drm/amd/display: Fix pageflipping for XOrg in Linux 5.11+

2021-01-02 Thread Bas Nieuwenhuizen
I think the problem here is that application A can set the FB and then application B can use getfb2 (say ffmpeg). https://lists.freedesktop.org/archives/dri-devel/2021-January/292761.html would be my alternative patch. (I'm not good at detecting the effects of tearing apparently but tested this

[PATCH] drm: Check actual format for legacy pageflip.

2021-01-02 Thread Bas Nieuwenhuizen
With modifiers one can actually have different format_info structs for the same format, which now matters for AMDGPU since we convert implicit modifiers to explicit modifiers with multiple planes. I checked other drivers and it doesn't look like they end up triggering this case so I think this is

[PATCH V2] drm/vkms: Decouple config data for configfs

2021-01-02 Thread Sumera Priyadarsini
Currently, data for the device instance is held by vkms_device. Add a separate type, vkms_config to contain configuration details for the device and various modes to be later used by configfs. This config data stays constant once the device is created. Accordingly, add vkms_create and

Re: [PATCH] i915: fix shift warning

2021-01-02 Thread Chris Wilson
Quoting Arnd Bergmann (2021-01-02 11:23:20) > On Wed, Dec 30, 2020 at 4:56 PM Chris Wilson wrote: > > > > Quoting Arnd Bergmann (2020-12-30 15:39:14) > > > From: Arnd Bergmann > > > > > > Randconfig builds on 32-bit machines show lots of warnings for > > > the i915 driver for incorrect bit masks

Re: [PATCH] i915: fix shift warning

2021-01-02 Thread Arnd Bergmann
On Wed, Dec 30, 2020 at 4:56 PM Chris Wilson wrote: > > Quoting Arnd Bergmann (2020-12-30 15:39:14) > > From: Arnd Bergmann > > > > Randconfig builds on 32-bit machines show lots of warnings for > > the i915 driver for incorrect bit masks like: > > mask is a u8. > > VCS0 is 2, I915_MAX_VCS 4 > >

[Bug 210095] amdgpu : hibernate failed on A12-9700P (R7 bristol ridge) - ASUS X555 Q

2021-01-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=210095 alvin (al...@ximple.ga) changed: What|Removed |Added Component|Video(DRI - non Intel) |Hibernation/Suspend