Re: [Patch v2] drm/amdgpu: Don't inherit GEM object VMAs in child process

2021-12-13 Thread Christian König
Am 11.12.21 um 01:55 schrieb Felix Kuehling: On 2021-12-10 4:48 p.m., Rajneesh Bhardwaj wrote: When an application having open file access to a node forks, its shared mappings also get reflected in the address space of child process even though it cannot access them with the object permissions

Re: [PATCH 6/7] drm/amdgpu: Ensure kunmap is called on error

2021-12-13 Thread Christian König
Am 14.12.21 um 04:37 schrieb Ira Weiny: On Mon, Dec 13, 2021 at 09:37:32PM +0100, Christian König wrote: Am 11.12.21 um 00:24 schrieb ira.we...@intel.com: From: Ira Weiny The default case leaves the buffer object mapped in error. Add amdgpu_bo_kunmap() to that case to ensure the mapping is

Re: [PATCH 6/7] drm/amdgpu: Ensure kunmap is called on error

2021-12-13 Thread Ira Weiny
On Mon, Dec 13, 2021 at 09:37:32PM +0100, Christian König wrote: > Am 11.12.21 um 00:24 schrieb ira.we...@intel.com: > > From: Ira Weiny > > > > The default case leaves the buffer object mapped in error. > > > > Add amdgpu_bo_kunmap() to that case to ensure the mapping is cleaned up. > > Mhm,

Re: [PATCH v3 2/3] drm/vc4: plane: Add support for DRM_FORMAT_P030

2021-12-13 Thread kernel test robot
-randconfig-r031-20211213 (https://download.01.org/0day-ci/archive/20211214/202112141058.ebplkmsk-...@intel.com/config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project b6a2ddb6c8ac29412b1361810972e15221fa021c) reproduce (this is a W=1 build): wget https

[PATCH v2] drm/ast: potential dereference of null pointer

2021-12-13 Thread Jiasheng Jiang
The return value of kzalloc() needs to be checked. To avoid use of null pointer '_state->base' in case of the failure of alloc. Fixes: f0adbc382b8b ("drm/ast: Allocate initial CRTC state of the correct size") Signed-off-by: Jiasheng Jiang --- Changelog: v1 -> v2 *Change 1. Add the else

[PATCH] drm/ast: potential dereference of null pointer

2021-12-13 Thread Jiasheng Jiang
The return value of kzalloc() needs to be checked. To avoid use of null pointer '_state->base' in case of the failure of alloc. Fixes: f0adbc382b8b ("drm/ast: Allocate initial CRTC state of the correct size") Signed-off-by: Jiasheng Jiang --- drivers/gpu/drm/ast/ast_mode.c | 5 - 1 file

Re: RPI 7" display touch controller

2021-12-13 Thread Tim Harvey
On Mon, Dec 13, 2021 at 12:58 PM Tim Harvey wrote: > > On Mon, Dec 13, 2021 at 11:39 AM Tim Harvey wrote: > > > > On Mon, Dec 13, 2021 at 4:04 AM Dave Stevenson > > wrote: > > > > > > On Fri, 10 Dec 2021 at 22:40, Tim Harvey wrote: > > > > > > > > On Fri, Dec 10, 2021 at 11:29 AM Tim Harvey

Re: [PATCH 6/7] drm/i915/guc: Kick G2H tasklet if no credits

2021-12-13 Thread John Harrison
On 12/11/2021 09:35, Matthew Brost wrote: Let's be paranoid and kick the G2H tasklet, which dequeues messages, if G2H credits are exhausted. Signed-off-by: Matthew Brost Reviewed-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 9 - 1 file changed, 8

Re: [PATCH 7/7] drm/i915/guc: Selftest for stealing of guc ids

2021-12-13 Thread John Harrison
On 12/11/2021 09:35, Matthew Brost wrote: Testing the stealing of guc ids is hard from user space as we have 64k guc_ids. Add a selftest, which artificially reduces the number of guc ids, and forces a steal. Description of test below. Last sentence seems redundant. The test creates a spinner

Re: [Mesa-dev] [PATCH v3 13/17] uapi/drm/dg2: Format modifier for DG2 unified compression and clear color

2021-12-13 Thread Ramalingam C
On 2021-12-09 at 14:41:57 -0500, Nanley Chery wrote: > Ping. I see that a v4 has been sent out without these comments being > addressed. Sorry for the miss. I will address it soon. Ram. > > -Nanley > > On Tue, Dec 7, 2021 at 6:51 PM Nanley Chery wrote: > > > > Hi Ramalingam, > > > > On Wed,

Re: [PATCH] drm/dp: Fix off-by-one in register cache size

2021-12-13 Thread Gustavo A. R. Silva
On Fri, Dec 03, 2021 at 12:43:33AM -0800, Kees Cook wrote: > The pcon_dsc_dpcd array holds 13 registers (0x92 through 0x9E). Fix the > math to calculate the max size. Found from a -Warray-bounds build: > > drivers/gpu/drm/drm_dp_helper.c: In function 'drm_dp_pcon_dsc_bpp_incr': >

Re: [PATCH v12, 06/19] media: mtk-vcodec: Add to support multi hardware decode

2021-12-13 Thread Steve Cho
Hi Yunfei, Thank you for reflecting comments. Reviewed-by: Steve Cho On Mon, Dec 13, 2021 at 12:40 AM yunfei.d...@mediatek.com wrote: > > Hi Steve, > > Thanks for your suggestion, > On Thu, 2021-12-09 at 15:29 -0800, Steve Cho wrote: > > Few comments and questions. > > > > On Wed, Dec 1, 2021

Re: [PATCH v12, 13/19] media: mtk-vcodec: Add work queue for core hardware decode

2021-12-13 Thread Steve Cho
Hi Yunfei, Thank you for addressing my questions and comments. Note that my comments for formatting are usually based on standards from chromium & chrome os. So feel free to reflect only if you think it is relevant. Reviewed-by: Steve Cho On Mon, Dec 13, 2021 at 12:52 AM

Re: [PATCH v2] drm/mediatek: Set the default value of rotation to DRM_MODE_ROTATE_0

2021-12-13 Thread Chun-Kuang Hu
Hi, Mark: Mark Yacoub 於 2021年12月14日 週二 上午12:08寫道: > > At the reset hook, call __drm_atomic_helper_plane_reset which is > called at the initialization of the plane and sets the default value of > rotation on all planes to DRM_MODE_ROTATE_0 which is equal to 1. Applied to mediatek-drm-next [1],

Re: [PATCH] dt-bindings: convert power domain node for rockchip DW MIPI DSI

2021-12-13 Thread Rob Herring
On Sat, Dec 11, 2021 at 11:55:58AM +0100, Heiko Stübner wrote: > Hi David, > > Am Montag, 6. Dezember 2021, 22:26:50 CET schrieb David Heidelberg: > > Convert into YAML format into format, which can be validated. > > > > Changes: > > - drop panel from example > > the patch subject is strange,

Re: [PATCH] dt-bindings: convert power domain node for rockchip DW MIPI DSI

2021-12-13 Thread Rob Herring
On Mon, Dec 06, 2021 at 10:26:50PM +0100, David Heidelberg wrote: > Convert into YAML format into format, which can be validated. > > Changes: > - drop panel from example > > Signed-off-by: David Heidelberg > --- > .../display/rockchip/dw_mipi_dsi_rockchip.txt | 93 >

Re: [PATCH v4 00/34] component: Make into an aggregate bus

2021-12-13 Thread Stephen Boyd
Quoting Daniel Vetter (2021-12-07 10:22:15) > On Thu, Dec 02, 2021 at 02:26:58PM -0800, Stephen Boyd wrote: > > This series is from discussion we had on reordering the device lists for > > drm shutdown paths[1]. I've introduced an 'aggregate' bus that we put > > the aggregate device onto and then

Re: RPI 7" display touch controller

2021-12-13 Thread Tim Harvey
On Mon, Dec 13, 2021 at 11:39 AM Tim Harvey wrote: > > On Mon, Dec 13, 2021 at 4:04 AM Dave Stevenson > wrote: > > > > On Fri, 10 Dec 2021 at 22:40, Tim Harvey wrote: > > > > > > On Fri, Dec 10, 2021 at 11:29 AM Tim Harvey wrote: > > > > > > > > On Fri, Dec 10, 2021 at 10:41 AM Dave Stevenson

Re: [PATCH] drm:amdgpu:remove unneeded variable

2021-12-13 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Dec 9, 2021 at 11:56 AM wrote: > > From: chiminghao > > return value form directly instead of > taking this in another redundant variable. > > Reported-by: Zeal Robot > Signed-off-by: chiminghao > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ioc32.c | 5 + >

Re: [PATCH/RFC v2] dt-bindings: display: bridge: sil,sii9022: Convert to json-schema

2021-12-13 Thread Rob Herring
On Fri, Dec 03, 2021 at 03:14:07PM +0100, Geert Uytterhoeven wrote: > Convert the Silicon Image sii902x HDMI bridge Device Tree binding > documentation to json-schema. > > Add missing sil,sii9022-cpi and sil,sii9022-tpi compatible values. > > Signed-off-by: Geert Uytterhoeven > --- > RFC as I

Re: [PATCH 6/7] drm/amdgpu: Ensure kunmap is called on error

2021-12-13 Thread Christian König
Am 11.12.21 um 00:24 schrieb ira.we...@intel.com: From: Ira Weiny The default case leaves the buffer object mapped in error. Add amdgpu_bo_kunmap() to that case to ensure the mapping is cleaned up. Mhm, good catch. But why do you want to do this in the first place? Christian.

Re: [PATCH v2 0/3] drm/i915: Support bigger GuC RSA keys

2021-12-13 Thread Daniele Ceraolo Spurio
On 12/10/2021 4:07 PM, Daniele Ceraolo Spurio wrote: Some of the newer platforms use a bigger RSA key to authenticate the GuC, which is provided to the HW via a ggtt-pinned object instead of mmio. While doing the changes for this I've also spotted an inconsistency in the error status of the

Re: RPI 7" display touch controller

2021-12-13 Thread Tim Harvey
On Mon, Dec 13, 2021 at 4:04 AM Dave Stevenson wrote: > > On Fri, 10 Dec 2021 at 22:40, Tim Harvey wrote: > > > > On Fri, Dec 10, 2021 at 11:29 AM Tim Harvey wrote: > > > > > > On Fri, Dec 10, 2021 at 10:41 AM Dave Stevenson > > > wrote: > > > > > > > > On Fri, 10 Dec 2021 at 18:20, Tim Harvey

Re: [PATCH v4 2/6] drm: improve drm_buddy_alloc function

2021-12-13 Thread Matthew Auld
On 09/12/2021 15:47, Paneer Selvam, Arunpravin wrote: [AMD Official Use Only] Hi Matthew, Ping on this? No new comments from me :) I guess just a question of what we should do with the selftests, and then ofc at some point being able to throw this at CI, or at least test locally, once the

[PATCH] drm/edid: support Microsoft extension for HMDs and specialized monitors

2021-12-13 Thread Philipp Zabel
Add minimal support for parsing VSDBs documented in Microsoft's "EDID extension for head-mounted and specialized monitors" [1]. The version field and the desktop usage flag can be used to set the non_desktop connector property. Remove the non-desktop quirk for devices that are verified to contain

Re: [PATCH] drm/i915: Fix implicit use of struct pci_dev

2021-12-13 Thread Jani Nikula
On Mon, 13 Dec 2021, broo...@kernel.org wrote: > From: Mark Brown > > intel_device_info.h references struct pci_dev but does not ensure that > the struct has been declared, causing build failures if something in > other headers changes so that the implicit dependency it is relying on > is no

Re: [PATCH v4 4/6] drm: implement a method to free unused pages

2021-12-13 Thread Matthew Auld
On 01/12/2021 16:39, Arunpravin wrote: On contiguous allocation, we round up the size to the *next* power of 2, implement a function to free the unused pages after the newly allocate block. v2(Matthew Auld): - replace function name 'drm_buddy_free_unused_pages' with drm_buddy_block_trim

Re: [PATCH RESEND v7 12/12] drm/i915: Move the GGTT from i915 private data to the GT

2021-12-13 Thread Andi Shyti
Hi Matt, On Mon, Dec 13, 2021 at 10:16:47AM -0800, Matt Roper wrote: > On Sun, Dec 12, 2021 at 05:21:17PM +0200, Andi Shyti wrote: > > GGTT was available both through i915->ggtt and gt->ggtt, and we > > eventually want to get rid of the i915->ggtt one. > > Move the GGTT from i915 to gt and use

Re: [PATCH RESEND v7 12/12] drm/i915: Move the GGTT from i915 private data to the GT

2021-12-13 Thread Matt Roper
On Sun, Dec 12, 2021 at 05:21:17PM +0200, Andi Shyti wrote: > GGTT was available both through i915->ggtt and gt->ggtt, and we > eventually want to get rid of the i915->ggtt one. > Move the GGTT from i915 to gt and use to_gt() for accesssing the > ggtt. > > Signed-off-by: Andi Shyti > Cc: Michal

Re: [PATCH RESEND v7 11/12] drm/i915: Use to_gt() helper for GGTT accesses

2021-12-13 Thread Andi Shyti
Hi Matt, > > diff --git a/drivers/gpu/drm/i915/i915_driver.c > > b/drivers/gpu/drm/i915/i915_driver.c > > index 95174938b160..2619bb17b6eb 100644 > > --- a/drivers/gpu/drm/i915/i915_driver.c > > +++ b/drivers/gpu/drm/i915/i915_driver.c > > @@ -571,6 +571,8 @@ static int

[PATCH 3/3] drm/vkms: drop "Multiple overlay planes" TODO

2021-12-13 Thread José Expósito
Signed-off-by: José Expósito --- Documentation/gpu/vkms.rst | 2 -- 1 file changed, 2 deletions(-) diff --git a/Documentation/gpu/vkms.rst b/Documentation/gpu/vkms.rst index 941f0e7e5eef..9c873c3912cc 100644 --- a/Documentation/gpu/vkms.rst +++ b/Documentation/gpu/vkms.rst @@ -124,8 +124,6 @@

[PATCH 1/3] drm/vkms: refactor overlay plane creation

2021-12-13 Thread José Expósito
Move the logic to create an overlay plane to its own function. Refactor, no functional changes. Signed-off-by: José Expósito --- drivers/gpu/drm/vkms/vkms_output.c | 26 +++--- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/vkms/vkms_output.c

[PATCH 2/3] drm/vkms: add support for multiple overlay planes

2021-12-13 Thread José Expósito
Add a new module parameter to allow to set the number of overlay planes to create. Set it to 1 by default in order to keep the "enable_overlay" backwards compatible. Signed-off-by: José Expósito --- drivers/gpu/drm/vkms/vkms_drv.c| 5 + drivers/gpu/drm/vkms/vkms_drv.h| 1 +

[PATCH 0/3] drm/vkms: add support for multiple overlay planes

2021-12-13 Thread José Expósito
Hi all, First of all, let me quickly introduce myself. I'm José Expósito and I'm a hobbyist open source developer. My contributions are usually in the kernel input/HID subsystems and in its userspace library (libinput) as well as other projects. I'm trying to learn more about the GPU and I found

Re: [PATCH RESEND v7 11/12] drm/i915: Use to_gt() helper for GGTT accesses

2021-12-13 Thread Matt Roper
On Sun, Dec 12, 2021 at 05:21:16PM +0200, Andi Shyti wrote: > From: Michał Winiarski > > GGTT is currently available both through i915->ggtt and gt->ggtt, and we > eventually want to get rid of the i915->ggtt one. > Use to_gt() for all i915->ggtt accesses to help with the future > refactoring. >

Re: [PATCH v6 3/6] drm: sun4i: dsi: Add bridge support

2021-12-13 Thread Maxime Ripard
On Fri, Dec 10, 2021 at 04:47:08PM +0530, Jagan Teki wrote: > Some display panels would come up with a non-DSI output, those > can have an option to connect the DSI host by means of interface > bridge converter. > > This DSI to non-DSI interface bridge converter would require > DSI Host to handle

[PATCH] drm/i915: Fix implicit use of struct pci_dev

2021-12-13 Thread broonie
From: Mark Brown intel_device_info.h references struct pci_dev but does not ensure that the struct has been declared, causing build failures if something in other headers changes so that the implicit dependency it is relying on is no longer satisfied: In file included from

Re: [PATCH v6 2/6] drm: sun4i: dsi: Add component only once DSI device attached

2021-12-13 Thread Maxime Ripard
On Fri, Dec 10, 2021 at 04:47:07PM +0530, Jagan Teki wrote: > Having component_add for running all drm bind callbacks returns > error or unbound due to chain of DSI devices connected across > bridge topology on a display pipeline. I'm not sure what that means? > In a typical bridge oriented

Re: [PATCH v6 1/6] drm: sun4i: dsi: Drop DRM bind race with bridge attach

2021-12-13 Thread Maxime Ripard
On Fri, Dec 10, 2021 at 04:47:06PM +0530, Jagan Teki wrote: > Existing host driver will keep looking for DRM pointer in > sun6i_dsi_attach and defers even if the particular DSI device > is found for the first time. Meanwhile it triggers the bind > callback and gets the DRM pointer and then

Re: [PATCH v6 0/6] drm: sun4i: dsi: Bridge support

2021-12-13 Thread Maxime Ripard
Hi, On Fri, Dec 10, 2021 at 04:47:05PM +0530, Jagan Teki wrote: > This series add bridge support for Allwinner DSI controller. > > In addition to previous version, this series add bridge support > only not doing any bridge conversion at the moment. > > Previous version changes [1]. > > Patch

[PATCH v3 3/3] drm/vc4: plane: Add support for YUV color encodings and ranges

2021-12-13 Thread Maxime Ripard
From: Dave Stevenson The BT601/BT709 color encoding and limited vs full range properties were not being exposed, defaulting always to BT601 limited range. Expose the parameters and set the registers appropriately. Signed-off-by: Dave Stevenson Signed-off-by: Maxime Ripard ---

[PATCH v3 2/3] drm/vc4: plane: Add support for DRM_FORMAT_P030

2021-12-13 Thread Maxime Ripard
From: Dave Stevenson The P030 format, used with the DRM_FORMAT_MOD_BROADCOM_SAND128 modifier, is a format output by the video decoder on the BCM2711. Add native support to the KMS planes for that format. Signed-off-by: Dave Stevenson Signed-off-by: Maxime Ripard ---

[PATCH v3 1/3] drm/fourcc: Add packed 10bit YUV 4:2:0 format

2021-12-13 Thread Maxime Ripard
From: Dave Stevenson Adds a format that is 3 10bit YUV 4:2:0 samples packed into a 32bit word (with 2 spare bits). Supported on Broadcom BCM2711 chips. Signed-off-by: Dave Stevenson Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_fourcc.c | 3 +++ include/uapi/drm/drm_fourcc.h | 11

[PATCH v3 0/3] drm/vc4: Support for 30 bits YUV formats

2021-12-13 Thread Maxime Ripard
Hi, Here are a few patches adding support for the P030 and the BT709 and BT2020 colorspaces. Let me know what you think, Maxime Changes from v2: - Fixed Dave email address - Fixed a typo in the first patch commit log Changes from v1: - Reworded the format description - Fixed use before

Re: [PATCH v6 7/7] drm/mediatek: Add mt8195 DisplayPort driver

2021-12-13 Thread Maxime Ripard
On Thu, Dec 02, 2021 at 06:48:12AM -0800, Guillaume Ranquet wrote: > Hi, > > Quoting Maxime Ripard (2021-11-25 15:30:34) > > On Wed, Nov 24, 2021 at 01:45:21PM +, Guillaume Ranquet wrote: > > > Hi, > > > Thanks for all your input, really appreciated. > > > > > > Quoting Maxime Ripard

Re: [PATCH v3 1/3] dt-bindings: gpu: mali-bifrost: Document RZ/G2L support

2021-12-13 Thread Steven Price
On 08/12/2021 10:40, Biju Das wrote: > The Renesas RZ/G2{L, LC} SoC (a.k.a R9A07G044) has a Bifrost Mali-G31 GPU, > add a compatible string for it. > > Signed-off-by: Biju Das > Reviewed-by: Lad Prabhakar > --- > v2->v3: > * Moved optional clock-names and reset-names to SoC-specific

[PATCH RESEND v4 v4 4/4] drm/vc4: Notify the firmware when DRM is in charge

2021-12-13 Thread Maxime Ripard
Once the call to drm_fb_helper_remove_conflicting_framebuffers() has been made, simplefb has been unregistered and the KMS driver is entirely in charge of the display. Thus, we can notify the firmware it can free whatever resource it was using to maintain simplefb functional. Signed-off-by:

[PATCH RESEND v4 v4 3/4] drm/vc4: Remove conflicting framebuffers before callind bind_all

2021-12-13 Thread Maxime Ripard
The bind hooks will modify their controller registers, so simplefb is going to be unusable anyway. Let's avoid any transient state where it could still be in the system but no longer functionnal. Acked-by: Nicolas Saenz Julienne Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_drv.c |

[PATCH RESEND v4 v4 2/4] drm/vc4: Support nomodeset

2021-12-13 Thread Maxime Ripard
If we have nomodeset on the kernel command line we should have the firmware framebuffer driver kept as is and not try to load the full-blown KMS driver. In this case, let's just register the v3d driver. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_drv.c | 20 +++- 1

[PATCH RESEND v4 v4 1/4] firmware: raspberrypi: Add RPI_FIRMWARE_NOTIFY_DISPLAY_DONE

2021-12-13 Thread Maxime Ripard
The RPI_FIRMWARE_NOTIFY_DISPLAY_DONE firmware call allows to tell the firmware the kernel is in charge of the display now and the firmware can free whatever resources it was using. Acked-by: Nicolas Saenz Julienne Signed-off-by: Maxime Ripard --- include/soc/bcm2835/raspberrypi-firmware.h | 1

[PATCH RESEND v4 v4 0/4] drm/vc4: Use the firmware to stop the display pipeline

2021-12-13 Thread Maxime Ripard
Hi, The VC4 driver has had limited support to disable the HDMI controllers and pixelvalves at boot if the firmware has enabled them. However, this proved to be limited, and a bit unreliable so a new firmware command has been introduced some time ago to make it free all its resources and disable

[PATCH v4 0001/1584] dt-bindings: gpio: gpio-vf610: Add imx8ulp compatible string

2021-12-13 Thread Maxime Ripard
From: Jacky Bai Add the compatible string for i.MX8ULP. Reviewed-by: Linus Walleij Reviewed-by: Dong Aisheng Acked-by: Rob Herring Signed-off-by: Jacky Bai Signed-off-by: Peng Fan Signed-off-by: Bartosz Golaszewski --- Documentation/devicetree/bindings/gpio/gpio-vf610.yaml | 3 +++ 1

Re: [PATCH v4 0000/1584] drm/vc4: Use the firmware to stop the display pipeline

2021-12-13 Thread Maxime Ripard
On Mon, Dec 13, 2021 at 04:58:13PM +0100, Maxime Ripard wrote: > Hi, > > The VC4 driver has had limited support to disable the HDMI controllers and > pixelvalves at boot if the firmware has enabled them. > > However, this proved to be limited, and a bit unreliable so a new firmware > command has

[PATCH v4 0000/1584] drm/vc4: Use the firmware to stop the display pipeline

2021-12-13 Thread Maxime Ripard
Hi, The VC4 driver has had limited support to disable the HDMI controllers and pixelvalves at boot if the firmware has enabled them. However, this proved to be limited, and a bit unreliable so a new firmware command has been introduced some time ago to make it free all its resources and disable

Re: [PATCH RESEND v7 12/12] drm/i915: Move the GGTT from i915 private data to the GT

2021-12-13 Thread kernel test robot
-randconfig-a003-20211213 (https://download.01.org/0day-ci/archive/20211213/202112132358.iwecweww-...@intel.com/config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project b6a2ddb6c8ac29412b1361810972e15221fa021c) reproduce (this is a W=1 build): wget https

[PATCH v2] drm/mediatek: Set the default value of rotation to DRM_MODE_ROTATE_0

2021-12-13 Thread Mark Yacoub
At the reset hook, call __drm_atomic_helper_plane_reset which is called at the initialization of the plane and sets the default value of rotation on all planes to DRM_MODE_ROTATE_0 which is equal to 1. Tested on Jacuzzi (MTK). Resolves IGT@kms_properties@plane-properties-{legacy,atomic}

Re: [PATCH 1/7] drm/i915: Replace kmap() with kmap_local_page()

2021-12-13 Thread Ira Weiny
On Mon, Dec 13, 2021 at 01:04:07AM -0800, Christoph Hellwig wrote: > On Fri, Dec 10, 2021 at 03:23:58PM -0800, ira.we...@intel.com wrote: > > - vaddr = kmap(page); > > + vaddr = kmap_local_page(page); > > memcpy(vaddr, data, len); > > - kunmap(page); > > +

Re: [PATCH 1/7] drm/i915: Replace kmap() with kmap_local_page()

2021-12-13 Thread Ira Weiny
On Mon, Dec 13, 2021 at 02:39:59PM +0200, Ville Syrjälä wrote: > On Fri, Dec 10, 2021 at 03:23:58PM -0800, ira.we...@intel.com wrote: > > From: Ira Weiny > > > > kmap() is being deprecated and these usages are all local to the thread > > so there is no reason kmap_local_page() can't be used. > >

Re: [PATCH v3 5/8] drm/i915/gtt: allow overriding the pt alignment

2021-12-13 Thread Ramalingam C
On 2021-12-06 at 13:31:37 +, Matthew Auld wrote: > On some platforms we have alignment restrictions when accessing LMEM > from the GTT. In the next patch few patches we need to be able to modify probably extra "patch" Apart from that looks good to me Reviewed-by : Ramalingam C > the

RE: [PATCH] drm/edid: Refine HDMI VSDB detect

2021-12-13 Thread Lee, Shawn C
On Monday, December 13, 2021 at 02:36 p.m, Ville Syrjälä wrote: >On Mon, Dec 13, 2021 at 02:09:33PM +, Lee, Shawn C wrote: >> >> On Monday, December 13, 2021 at 12:45 p.m, Ville Syrjälä wrote: >> >On Mon, Dec 13, 2021 at 12:42:22PM +, Lee, Shawn C wrote: >> >> >> >> On Monday, December

Re: [PATCH v3 1/3] of: Move simple-framebuffer device handling from simplefb to of

2021-12-13 Thread Rob Herring
On Mon, Dec 13, 2021 at 2:16 AM Thomas Zimmermann wrote: > > Hi > > Am 12.12.21 um 22:29 schrieb Rob Herring: > > On Sun, Dec 12, 2021 at 12:24 AM Hector Martin wrote: > >> > >> This code is required for both simplefb and simpledrm, so let's move it > >> into the OF core instead of having it as

Re: [PATCH v3 1/3] of: Move simple-framebuffer device handling from simplefb to of

2021-12-13 Thread Rob Herring
On Mon, Dec 13, 2021 at 5:30 AM Javier Martinez Canillas wrote: > > On Mon, Dec 13, 2021 at 11:46 AM Hector Martin wrote: > > > > On 13/12/2021 17.44, Javier Martinez Canillas wrote: > > > Hello Hector, > > > > > > On Sun, Dec 12, 2021 at 7:24 AM Hector Martin wrote: > > >> > > >> This code is

Re: [PATCH] drm/edid: Refine HDMI VSDB detect

2021-12-13 Thread Ville Syrjälä
On Mon, Dec 13, 2021 at 02:09:33PM +, Lee, Shawn C wrote: > > On Monday, December 13, 2021 at 12:45 p.m, Ville Syrjälä wrote: > >On Mon, Dec 13, 2021 at 12:42:22PM +, Lee, Shawn C wrote: > >> > >> On Monday, December 13, 2021 8:31 PM, Ville Syrjälä wrote: > >> >On Sun, Dec 12, 2021 at

Re: [PATCH 1/2] drm/amd/display: Reduce stack size for dml31_ModeSupportAndSystemConfigurationFull

2021-12-13 Thread Rodrigo Siqueira Jordao
On 2021-12-13 4:46 a.m., Michel Dänzer wrote: On 2021-12-11 13:20, Rodrigo Siqueira Jordao wrote: On 2021-12-09 11:46 a.m., Michel Dänzer wrote: From: Michel Dänzer Move code using the Pipe struct to a new helper function. Works around[0] this warning (resulting in failure to build a

Re: [PATCH v3 0/7] drm: exynos: dsi: Convert drm bridge

2021-12-13 Thread Marek Szyprowski
Hi Jagan, On 13.12.2021 14:56, Jagan Teki wrote: > On Mon, Dec 13, 2021 at 6:51 PM Marek Szyprowski > wrote: >> On 13.12.2021 13:31, Jagan Teki wrote: >>> On Mon, Dec 13, 2021 at 5:42 PM Marek Szyprowski >>> wrote: On 13.12.2021 13:08, Jagan Teki wrote: > On Mon, Dec 13, 2021 at 5:34

RE: [PATCH] drm/edid: Refine HDMI VSDB detect

2021-12-13 Thread Lee, Shawn C
On Monday, December 13, 2021 at 12:45 p.m, Ville Syrjälä wrote: >On Mon, Dec 13, 2021 at 12:42:22PM +, Lee, Shawn C wrote: >> >> On Monday, December 13, 2021 8:31 PM, Ville Syrjälä wrote: >> >On Sun, Dec 12, 2021 at 11:33:31PM +0800, Lee Shawn C wrote: >> >> According to CEA-861-F chapter

Re: [PATCH v3 0/7] drm: exynos: dsi: Convert drm bridge

2021-12-13 Thread Jagan Teki
Hi Marek, On Mon, Dec 13, 2021 at 6:51 PM Marek Szyprowski wrote: > > Hi Jagan, > > On 13.12.2021 13:31, Jagan Teki wrote: > > On Mon, Dec 13, 2021 at 5:42 PM Marek Szyprowski > > wrote: > >> On 13.12.2021 13:08, Jagan Teki wrote: > >>> On Mon, Dec 13, 2021 at 5:34 PM Marek Szyprowski > >>>

Re: [PATCH 0/3] drm/dp: Move DisplayPort helpers into own module

2021-12-13 Thread Thomas Zimmermann
Hi Am 13.12.21 um 14:34 schrieb Jani Nikula: On Mon, 13 Dec 2021, Thomas Zimmermann wrote: Split-off DisplayPort functions from KMS helper library and move them into their own module. Reduces the size of drm_kms_helper.ko by ~50%. This patchset is part of an on-going effort to reduce the

[PATCH v5 4/4] drm/bridge: ti-sn65dsi83: Add vcc supply regulator support

2021-12-13 Thread Alexander Stein
VCC needs to be enabled before releasing the enable GPIO. Reviewed-by: Laurent Pinchart Signed-off-by: Alexander Stein --- drivers/gpu/drm/bridge/ti-sn65dsi83.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c

[PATCH v5 3/4] dt-bindings: drm/bridge: ti-sn65dsi83: Add vcc supply bindings

2021-12-13 Thread Alexander Stein
Add a VCC regulator which needs to be enabled before the EN pin is released. Reviewed-by: Sam Ravnborg Acked-by: Rob Herring Reviewed-by: Jagan Teki Signed-off-by: Alexander Stein --- .../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml | 4 1 file changed, 4 insertions(+)

[PATCH v5 2/4] drm/bridge: ti-sn65dsi83: Make enable GPIO optional

2021-12-13 Thread Alexander Stein
The enable signal may not be controllable by the kernel. Make it optional. This is a similar to commit bbda1704fc15 ("drm/bridge: ti-sn65dsi86: Make enable GPIO optional") Reviewed-by: Laurent Pinchart Reviewed-by: Sam Ravnborg Signed-off-by: Alexander Stein ---

[PATCH v5 1/4] dt-bindings: display: bridge: sn65dsi83: Make enable GPIO optional

2021-12-13 Thread Alexander Stein
From: Laurent Pinchart The SN65DSI8x EN signal may be tied to VCC, or otherwise controlled by means not available to the kernel. Make the GPIO optional. Signed-off-by: Laurent Pinchart Acked-by: Rob Herring Signed-off-by: Alexander Stein ---

[PATCH v5 0/4] ti-sn65dsi83 patches

2021-12-13 Thread Alexander Stein
Changes in V5 of this set: * Rebased to next-20211208 * Fix format string in error message * Remove superfluous error value for dev_err_probe() * Added Reviewed-by: Jagan Teki for patch 3 & 4 Changes in V4 of this set: * Rebased to next-2028 (due to merge-conflict in linux-next) * Added Rob

Re: [PATCH 0/3] drm/dp: Move DisplayPort helpers into own module

2021-12-13 Thread Jani Nikula
On Mon, 13 Dec 2021, Thomas Zimmermann wrote: > Split-off DisplayPort functions from KMS helper library and move them > into their own module. Reduces the size of drm_kms_helper.ko by ~50%. > > This patchset is part of an on-going effort to reduce the minimum > binary size of the DRM core and

Re: [PATCH v3 0/7] drm: exynos: dsi: Convert drm bridge

2021-12-13 Thread Marek Szyprowski
Hi Jagan, On 13.12.2021 13:31, Jagan Teki wrote: > On Mon, Dec 13, 2021 at 5:42 PM Marek Szyprowski > wrote: >> On 13.12.2021 13:08, Jagan Teki wrote: >>> On Mon, Dec 13, 2021 at 5:34 PM Marek Szyprowski >>> wrote: On 12.12.2021 19:14, Jagan Teki wrote: > Updated series about drm

Re: [PATCH] drm/mediatek: hdmi: Perform NULL pointer check for mtk_hdmi_conf

2021-12-13 Thread Chun-Kuang Hu
Hi, Angelo: AngeloGioacchino Del Regno 於 2021年12月13日 週一 下午6:02寫道: > > Il 28/10/21 09:43, AngeloGioacchino Del Regno ha scritto: > > In commit 41ca9caaae0b ("drm/mediatek: hdmi: Add check for CEA modes only") > > a check for CEA modes was added to function mtk_hdmi_bridge_mode_valid() > > in

Re: [PATCH] drm/i915/ttm: fix large buffer population trucation

2021-12-13 Thread Matthew Auld
On 10/12/2021 19:50, Robert Beckett wrote: ttm->num_pages is uint32_t which was causing very large buffers to only populate a truncated size. This fixes gem_create@create-clear igt test on large memory systems. Fixes: 7ae034590cea ("drm/i915/ttm: add tt shmem backend") Signed-off-by: Robert

Re: [PATCH] drm/i915/debugfs: add noreclaim annotations

2021-12-13 Thread Thomas Hellström
On 12/13/21 13:55, Matthew Auld wrote: We have a debugfs hook to directly call into i915_gem_shrink() with the fs_reclaim acquire annotations to simulate hitting direct reclaim. However we should also annotate this with memalloc_noreclaim, which will set PF_MEMALLOC for us on the current

[PATCH] drm/i915/debugfs: add noreclaim annotations

2021-12-13 Thread Matthew Auld
We have a debugfs hook to directly call into i915_gem_shrink() with the fs_reclaim acquire annotations to simulate hitting direct reclaim. However we should also annotate this with memalloc_noreclaim, which will set PF_MEMALLOC for us on the current context, to ensure we can't re-enter direct

Re: [PATCH] drm/edid: Refine HDMI VSDB detect

2021-12-13 Thread Ville Syrjälä
On Mon, Dec 13, 2021 at 12:42:22PM +, Lee, Shawn C wrote: > > On Monday, December 13, 2021 8:31 PM, Ville Syrjälä wrote: > >On Sun, Dec 12, 2021 at 11:33:31PM +0800, Lee Shawn C wrote: > >> According to CEA-861-F chapter 7.5.4. It says "The VSDB shall contain > >> the > >> 3 bytes of the

RE: [PATCH] drm/edid: Refine HDMI VSDB detect

2021-12-13 Thread Lee, Shawn C
On Monday, December 13, 2021 8:31 PM, Ville Syrjälä wrote: >On Sun, Dec 12, 2021 at 11:33:31PM +0800, Lee Shawn C wrote: >> According to CEA-861-F chapter 7.5.4. It says "The VSDB shall contain >> the >> 3 bytes of the IEEE OUI as well as any additional payload bytes needed." >> Now DRM driver

Re: [PATCH 1/7] drm/i915: Replace kmap() with kmap_local_page()

2021-12-13 Thread Ville Syrjälä
On Fri, Dec 10, 2021 at 03:23:58PM -0800, ira.we...@intel.com wrote: > From: Ira Weiny > > kmap() is being deprecated and these usages are all local to the thread > so there is no reason kmap_local_page() can't be used. > > Replace kmap() calls with kmap_local_page(). > > Signed-off-by: Ira

Re: [PATCH v3 0/7] drm: exynos: dsi: Convert drm bridge

2021-12-13 Thread Jagan Teki
Hi Marek, On Mon, Dec 13, 2021 at 5:42 PM Marek Szyprowski wrote: > > Hi Jagan, > > On 13.12.2021 13:08, Jagan Teki wrote: > > On Mon, Dec 13, 2021 at 5:34 PM Marek Szyprowski > > wrote: > >> On 12.12.2021 19:14, Jagan Teki wrote: > >>> Updated series about drm bridge conversion of exynos dsi.

Re: [PATCH] drm/edid: Refine HDMI VSDB detect

2021-12-13 Thread Ville Syrjälä
On Sun, Dec 12, 2021 at 11:33:31PM +0800, Lee Shawn C wrote: > According to CEA-861-F chapter 7.5.4. It says "The VSDB shall contain the > 3 bytes of the IEEE OUI as well as any additional payload bytes needed." > Now DRM driver check HDMI OUI but VSDB payload size at least five bytes. > That may

Re: [PATCH v3 0/7] drm: exynos: dsi: Convert drm bridge

2021-12-13 Thread Marek Szyprowski
Hi Jagan, On 13.12.2021 13:08, Jagan Teki wrote: > On Mon, Dec 13, 2021 at 5:34 PM Marek Szyprowski > wrote: >> On 12.12.2021 19:14, Jagan Teki wrote: >>> Updated series about drm bridge conversion of exynos dsi. >>> >>> Patch 1: panel checker >>> >>> Patch 2: panel_bridge API >>> >>> Patch 3:

Re: [PATCH v3 0/7] drm: exynos: dsi: Convert drm bridge

2021-12-13 Thread Jagan Teki
Hi Marek, On Mon, Dec 13, 2021 at 5:34 PM Marek Szyprowski wrote: > > Dear Jagan, > > On 12.12.2021 19:14, Jagan Teki wrote: > > Updated series about drm bridge conversion of exynos dsi. > > > > Patch 1: panel checker > > > > Patch 2: panel_bridge API > > > > Patch 3: Bridge conversion > > > >

Re: RPI 7" display touch controller

2021-12-13 Thread Dave Stevenson
On Fri, 10 Dec 2021 at 22:40, Tim Harvey wrote: > > On Fri, Dec 10, 2021 at 11:29 AM Tim Harvey wrote: > > > > On Fri, Dec 10, 2021 at 10:41 AM Dave Stevenson > > wrote: > > > > > > On Fri, 10 Dec 2021 at 18:20, Tim Harvey wrote: > > > > > > > > On Thu, Nov 18, 2021 at 12:52 PM Tim Harvey >

Re: [PATCH v3 0/7] drm: exynos: dsi: Convert drm bridge

2021-12-13 Thread Marek Szyprowski
Dear Jagan, On 12.12.2021 19:14, Jagan Teki wrote: > Updated series about drm bridge conversion of exynos dsi. > > Patch 1: panel checker > > Patch 2: panel_bridge API > > Patch 3: Bridge conversion > > Patch 4: pree_enable, post_disable > > Patch 5: Atomic functions > > Patch 6: atomic_set > >

Re: [PATCH v3 1/3] of: Move simple-framebuffer device handling from simplefb to of

2021-12-13 Thread Hector Martin
On 13/12/2021 20.30, Javier Martinez Canillas wrote: On Mon, Dec 13, 2021 at 11:46 AM Hector Martin wrote: On 13/12/2021 17.44, Javier Martinez Canillas wrote: Hello Hector, On Sun, Dec 12, 2021 at 7:24 AM Hector Martin wrote: This code is required for both simplefb and simpledrm, so

Re: [PATCH v3 1/3] of: Move simple-framebuffer device handling from simplefb to of

2021-12-13 Thread Javier Martinez Canillas
On Mon, Dec 13, 2021 at 11:46 AM Hector Martin wrote: > > On 13/12/2021 17.44, Javier Martinez Canillas wrote: > > Hello Hector, > > > > On Sun, Dec 12, 2021 at 7:24 AM Hector Martin wrote: > >> > >> This code is required for both simplefb and simpledrm, so let's move it > >> into the OF core

[Bug 211807] [drm:drm_dp_mst_dpcd_read] *ERROR* mstb 000000004e6288dd port 3: DPCD read on addr 0x60 for 1 bytes NAKed

2021-12-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211807 --- Comment #19 from Renaud R. (kernel...@iopsthecloud.com) --- (In reply to Renaud R. from comment #18) > My setup: > * Latitude E5570 via dock DisplayPort > * Kernel: https://bugzilla.kernel.org Kernel: 5.15.7-051507-generic #202112080459 SMP

[Bug 211807] [drm:drm_dp_mst_dpcd_read] *ERROR* mstb 000000004e6288dd port 3: DPCD read on addr 0x60 for 1 bytes NAKed

2021-12-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211807 Renaud R. (kernel...@iopsthecloud.com) changed: What|Removed |Added CC|

Re: [RFC PATCH v4 0/2] RDMA/rxe: Add dma-buf support

2021-12-13 Thread Shunsuke Mie
2021年12月10日(金) 22:29 Christian König : > > Am 10.12.21 um 14:26 schrieb Jason Gunthorpe: > > On Fri, Dec 10, 2021 at 01:47:37PM +0100, Christian König wrote: > >> Am 10.12.21 um 13:42 schrieb Jason Gunthorpe: > >>> On Fri, Dec 10, 2021 at 08:29:24PM +0900, Shunsuke Mie wrote: > Hi Jason, >

Re: [PATCH 07/18] dt-bindings: display: rockchip: dw-hdmi: Allow "ref" as clock name

2021-12-13 Thread Sascha Hauer
On Sun, Dec 12, 2021 at 11:09:24PM +0100, Heiko Stuebner wrote: > Am Mittwoch, 8. Dezember 2021, 16:12:19 CET schrieb Sascha Hauer: > > "vpll" is a misnomer. A clock input to a device should be named after > > the usage in the device, not after the clock that drives it. On the > > rk3568 the same

Re: [PATCH v3 1/3] of: Move simple-framebuffer device handling from simplefb to of

2021-12-13 Thread Hector Martin
On 13/12/2021 17.44, Javier Martinez Canillas wrote: Hello Hector, On Sun, Dec 12, 2021 at 7:24 AM Hector Martin wrote: This code is required for both simplefb and simpledrm, so let's move it into the OF core instead of having it as an ad-hoc initcall in the drivers. Acked-by: Thomas

Re: [PATCH 2/2] drm/imx/dcss: select DRM_KMS_HELPER

2021-12-13 Thread Laurentiu Palcu
Hi Lucas, On Sat, Dec 11, 2021 at 11:18:48PM +0100, Lucas Stach wrote: > DCSS can not be built without the DRM_KMS_HELPERs being available. > Select this symbol to disallow this invalid configuration. > > Signed-off-by: Lucas Stach Reviewed-by: Laurentiu Palcu Can you also push these 2

Re: [PATCH 1/2] drm/imx/dcss: add missing drm_bridge.h include

2021-12-13 Thread Laurentiu Palcu
Hi Lucas, On Sat, Dec 11, 2021 at 11:18:47PM +0100, Lucas Stach wrote: > This has been pulled in via some other include before, which is no > longer true. > > Signed-off-by: Lucas Stach > --- Reviewed-by: Laurentiu Palcu > drivers/gpu/drm/imx/dcss/dcss-kms.c | 1 + > 1 file changed, 1

Re: [PATCH] drm: simpledrm: fix wrong unit with pixel clock

2021-12-13 Thread Thomas Zimmermann
Hi Am 12.12.21 um 17:06 schrieb Alejandro Concepcion-Rodriguez: Pixel clock has to be set in kHz. Fixes: 11e8f5fd223b ("drm: Add simpledrm driver") Signed-off-by: Alejandro Concepcion-Rodriguez Applied to drm-misc-fixes. Thanks. Best regards Thomas --- drivers/gpu/drm/tiny/simpledrm.c

Re: [PATCH] drm/mediatek: hdmi: Perform NULL pointer check for mtk_hdmi_conf

2021-12-13 Thread AngeloGioacchino Del Regno
Il 28/10/21 09:43, AngeloGioacchino Del Regno ha scritto: In commit 41ca9caaae0b ("drm/mediatek: hdmi: Add check for CEA modes only") a check for CEA modes was added to function mtk_hdmi_bridge_mode_valid() in order to address possible issues on MT8167; moreover, with commit c91026a938c2

Re: [Intel-gfx] [PATCH 2/3] drm/dp: Move DP declarations into separate header file

2021-12-13 Thread Jani Nikula
On Mon, 13 Dec 2021, Thomas Zimmermann wrote: > Split the DP declarations from other helpers before moving the > DP functions into a separate module. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/drm_crtc_helper_internal.h | 27 - >

  1   2   >