[PATCH 4/4] drm/edid: Avoid multiple log lines for HFVSDB parsing

2022-08-10 Thread Ankit Nautiyal
Replace multiple log lines with a single log line at the end of parsing HF-VSDB. Also use drm_dbg_kms instead of DRM_DBG_KMS, and add log for DSC1.2 support. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/drm_edid.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-)

[PATCH 3/4] drm/edid: Refactor HFVSDB parsing for DSC1.2

2022-08-10 Thread Ankit Nautiyal
DSC capabilities are given in bytes 11-13 of VSDB (i.e. bytes 8-10 of SCDS). Since minimum length of Data block is 7, all bytes greater than 7 must be read only after checking the length of the data block. This patch adds check for data block length before reading relavant DSC bytes.

[PATCH 1/4] drm/edid: Fix minimum bpc supported with DSC1.2 for HDMI sink

2022-08-10 Thread Ankit Nautiyal
HF-VSDB/SCDB has bits to advertise support for 16, 12 and 10 bpc. If none of the bits are set, the minimum bpc supported with DSC is 8. This patch corrects the min bpc supported to be 8, instead of 0. Fixes: 76ee7b905678 ("drm/edid: Parse DSC1.2 cap fields from HFVSDB block") Cc: Ankit Nautiyal

[PATCH 2/4] drm/edid: Split DSC parsing into separate function

2022-08-10 Thread Ankit Nautiyal
Move the DSC parsing logic into separate function. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/drm_edid.c | 128 - 1 file changed, 69 insertions(+), 59 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index

[PATCH 0/4] Fix HFVSDB parsing

2022-08-10 Thread Ankit Nautiyal
Fix issues in HFVSDB parsing for DSC support. Also minor refactoring in Logging. Split from original patch into a new series. https://patchwork.freedesktop.org/patch/495193/ Ankit Nautiyal (4): drm/edid: Fix minimum bpc supported with DSC1.2 for HDMI sink drm/edid: Split DSC parsing into

[Bug 216350] amdgpu 0000:06:00.0: drm_WARN_ON(atomic_read(>refcount) == 0)

2022-08-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216350 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Status|NEW |RESOLVED

Re: [PATCH 3/3] drm/msm/dpu: Introduce SC8280XP

2022-08-10 Thread Steev Klimaszewski
On Wed, Aug 10, 2022 at 11:28 PM Steev Klimaszewski wrote: > > Hi Bjorn, > > > On Wed, Aug 10, 2022 at 10:58 PM Bjorn Andersson > wrote: > > > > The Qualcomm SC8280XP platform contains DPU version 8.0.0, has 9 > > interfaces, 2 DSI controllers and 4 DisplayPort controllers. Extend the > >

Daniel's locking rules articles

2022-08-10 Thread Dave Airlie
In case anyone here hasn't read them yet, and is doing anything with locking or ignoring locking, please read: https://blog.ffwll.ch/2022/07/locking-engineering.html https://blog.ffwll.ch/2022/08/locking-hierarchy.html For anyone doing review or submitting new features from inside companies,

Re: [PATCH 3/3] drm/msm/dpu: Introduce SC8280XP

2022-08-10 Thread Steev Klimaszewski
Hi Bjorn, On Wed, Aug 10, 2022 at 10:58 PM Bjorn Andersson wrote: > > The Qualcomm SC8280XP platform contains DPU version 8.0.0, has 9 > interfaces, 2 DSI controllers and 4 DisplayPort controllers. Extend the > necessary definitions and describe the DPU in the SC8280XP. > > Signed-off-by: Bjorn

[PATCH 3/3] drm/msm/dpu: Introduce SC8280XP

2022-08-10 Thread Bjorn Andersson
The Qualcomm SC8280XP platform contains DPU version 8.0.0, has 9 interfaces, 2 DSI controllers and 4 DisplayPort controllers. Extend the necessary definitions and describe the DPU in the SC8280XP. Signed-off-by: Bjorn Andersson --- Note that MSM_DP_CONTROLLER_3 is also defined in the DP series

[PATCH 2/3] drm/msm/dpu: add support for MDP_TOP blackhole

2022-08-10 Thread Bjorn Andersson
From: Dmitry Baryshkov On sm8450 a register block was removed from MDP TOP. Accessing it during snapshotting results in NoC errors / immediate reboot. Skip accessing these registers during snapshot. Signed-off-by: Dmitry Baryshkov Signed-off-by: Bjorn Andersson ---

[PATCH 0/3] drm/msm/dpu: Add support for SC8280XP

2022-08-10 Thread Bjorn Andersson
This adds support the MDSS and DPU found in the SC8280XP platform. Bjorn Andersson (2): dt-bindings: display/msm: Add binding for SC8280XP MDSS drm/msm/dpu: Introduce SC8280XP Dmitry Baryshkov (1): drm/msm/dpu: add support for MDP_TOP blackhole .../bindings/display/msm/dpu-sc8280xp.yaml

[PATCH 1/3] dt-bindings: display/msm: Add binding for SC8280XP MDSS

2022-08-10 Thread Bjorn Andersson
Add binding for the display subsystem and display processing unit in the Qualcomm SC8280XP platform. Signed-off-by: Bjorn Andersson --- .../bindings/display/msm/dpu-sc8280xp.yaml| 284 ++ 1 file changed, 284 insertions(+) create mode 100644

[Bug 201957] amdgpu: ring gfx timeout

2022-08-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201957 david (291765...@qq.com) changed: What|Removed |Added CC||291765...@qq.com --- Comment

Re: [PATCH v3] drm/msm: Make .remove and .shutdown HW shutdown consistent

2022-08-10 Thread Abhinav Kumar
Hi Javier Thank you for the patch. On 7/25/2022 12:43 AM, Javier Martinez Canillas wrote: Drivers' .remove and .shutdown callbacks are executed on different code paths. The former is called when a device is removed from the bus, while the latter is called at system shutdown time to quiesce the

Re: [PATCH v3] drm/msm/dp: check hpd_state before push idle pattern at dp_bridge_disable()

2022-08-10 Thread Abhinav Kumar
Hi Stephen On 8/10/2022 5:09 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2022-08-10 16:57:51) On 8/10/2022 3:22 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2022-08-10 12:25:51) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index b36f8b6..678289a

Re: [PATCH libdrm v1 2/2] tests/modetest: Add support for writeback connector

2022-08-10 Thread Rohith Iyer
Hi Andy, On 7/25/2022 6:57 PM, Andy Yan wrote: Hi Rohith: At 2022-07-26 03:26:39, "Rohith Iyer" wrote: Add writeback support to modetest with the below options: + case 'o': + pipe_args->dump = true; + dump_path = optarg; +

Re: [PATCH v3] drm/msm/dp: check hpd_state before push idle pattern at dp_bridge_disable()

2022-08-10 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-08-10 16:57:51) > > On 8/10/2022 3:22 PM, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2022-08-10 12:25:51) > >> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > >> b/drivers/gpu/drm/msm/dp/dp_display.c > >> index b36f8b6..678289a 100644 > >> ---

Re: [PATCH v3] drm/msm/dp: check hpd_state before push idle pattern at dp_bridge_disable()

2022-08-10 Thread Kuogee Hsieh
On 8/10/2022 3:22 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2022-08-10 12:25:51) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index b36f8b6..678289a 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@

[PATCH v3 4/4] drm/amdgpu: Document gfx_off members of struct amdgpu_gfx

2022-08-10 Thread André Almeida
Add comments to document gfx_off related members of struct amdgpu_gfx. Signed-off-by: André Almeida --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h

[PATCH v3 3/4] Documentation/gpu: Document GFXOFF's count and residency

2022-08-10 Thread André Almeida
Add documentation explaining those two new files. While here, add a note about the value type. Signed-off-by: André Almeida --- Documentation/gpu/amdgpu/thermal.rst | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/Documentation/gpu/amdgpu/thermal.rst

[PATCH v3 2/4] drm/amd/pm: Implement GFXOFF's entry count and residency for vangogh

2022-08-10 Thread André Almeida
Implement functions to get and set GFXOFF's entry count and residency for vangogh. Signed-off-by: André Almeida --- .../pm/swsmu/inc/pmfw_if/smu_v11_5_ppsmc.h| 5 +- drivers/gpu/drm/amd/pm/swsmu/inc/smu_types.h | 5 +- .../gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 76

[PATCH v3 1/4] drm/amd: Add detailed GFXOFF stats to debugfs

2022-08-10 Thread André Almeida
Add debugfs interface to log GFXOFF statistics: - Read amdgpu_gfxoff_count to get the total GFXOFF entry count at the time of query since system power-up - Write 1 to amdgpu_gfxoff_residency to start logging, and 0 to stop. Read it to get average GFXOFF residency % multiplied by 100 during

[PATCH v3 0/4] drm/amd: Add more GFXOFF stats for vangogh

2022-08-10 Thread André Almeida
This series adds new logging features for GFXOFF available for vangogh and documentation for it. I've created a small userspace program to interact with this new debugfs interface and it can be found at: https://gitlab.freedesktop.org/andrealmeid/gfxoff_tool Changelog: v3: - drop IP version

Re: [PATCH v8 2/2] drm/gem: Don't map imported GEMs

2022-08-10 Thread Rob Clark
On Wed, Aug 10, 2022 at 3:23 PM Dmitry Osipenko wrote: > > On 8/11/22 01:03, Rob Clark wrote: > > On Wed, Aug 10, 2022 at 12:26 PM Dmitry Osipenko > > wrote: > >> > >> On 8/10/22 18:08, Rob Clark wrote: > >>> On Wed, Aug 10, 2022 at 4:47 AM Daniel Vetter wrote: > > On Wed, Jul 06,

Re: [PATCH v8 2/2] drm/gem: Don't map imported GEMs

2022-08-10 Thread Dmitry Osipenko
On 8/11/22 01:03, Rob Clark wrote: > On Wed, Aug 10, 2022 at 12:26 PM Dmitry Osipenko > wrote: >> >> On 8/10/22 18:08, Rob Clark wrote: >>> On Wed, Aug 10, 2022 at 4:47 AM Daniel Vetter wrote: On Wed, Jul 06, 2022 at 10:02:07AM +0300, Dmitry Osipenko wrote: > On 7/6/22 00:48, Rob

Re: [PATCH v3] drm/msm/dp: check hpd_state before push idle pattern at dp_bridge_disable()

2022-08-10 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-08-10 12:25:51) > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > b/drivers/gpu/drm/msm/dp/dp_display.c > index b36f8b6..678289a 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -1729,10 +1729,20 @@ void

Re: [RESEND RFC 15/18] drm/display/dp_mst: Skip releasing payloads if last connected port isn't connected

2022-08-10 Thread Lyude Paul
On Wed, 2022-08-10 at 03:28 +, Lin, Wayne wrote: > Hi Lyude, > Thanks for your time and sorry for late response! > > It's described in 5.6.1.3 of DP spec 2.0: > "MST branch device, in addition to waiting for the ACK from its immediate > Upstream device, should either wait for the

Re: [PATCH v5] drm: Add initial ci/ subdirectory

2022-08-10 Thread Rob Clark
On Wed, Aug 10, 2022 at 11:25 AM Rodrigo Siqueira Jordao wrote: > > Hi Tomeu, > > First of all, nice patch! I just saw it, and I have some basic questions > (I don't understand many of these CI details). I also CC some CI folks > from the display team at AMD. > > On 2022-07-26 14:16, Tomeu Vizoso

Re: [PATCH v8 2/2] drm/gem: Don't map imported GEMs

2022-08-10 Thread Rob Clark
On Wed, Aug 10, 2022 at 12:26 PM Dmitry Osipenko wrote: > > On 8/10/22 18:08, Rob Clark wrote: > > On Wed, Aug 10, 2022 at 4:47 AM Daniel Vetter wrote: > >> > >> On Wed, Jul 06, 2022 at 10:02:07AM +0300, Dmitry Osipenko wrote: > >>> On 7/6/22 00:48, Rob Clark wrote: > On Tue, Jul 5, 2022 at

Re: [PATCH v5 00/13] Canaan devicetree fixes

2022-08-10 Thread Palmer Dabbelt
On Fri, 05 Aug 2022 10:51:00 PDT (-0700), conor.doo...@microchip.com wrote: On 14/07/2022 23:11, Conor Dooley - M52691 wrote: On 14/07/2022 23:04, Palmer Dabbelt wrote: I'm trying to sort out how to merge this one.  I'm not opposed to taking it through the RISC-V tree as Rob's reviewed/acked

Re: [PATCH v2 1/3] drm/dp_mst: add passthrough_aux to struct drm_dp_mst_port

2022-08-10 Thread Lyude Paul
On Wed, 2022-08-10 at 09:23 -0400, Hamza Mahfooz wrote: > On 2022-08-09 18:01, Lyude Paul wrote: > > Ah yes of course! Probably should have asked when I gave the r-b :). Also, > > just so patchwork actually catches it I will say the magic incantation: > > > > Reviewed-by: Lyude Paul > > > > Do

Re: [PATCH] drm/mediatek: dsi: Add atomic {destroy, duplicate}_state, reset callbacks

2022-08-10 Thread Nícolas F . R . A . Prado
On Thu, Jul 21, 2022 at 07:27:27PM +0200, AngeloGioacchino Del Regno wrote: > Add callbacks for atomic_destroy_state, atomic_duplicate_state and > atomic_reset to restore functionality of the DSI driver: this solves > vblank timeouts when another bridge is present in the chain. > > Tested bridge

Re: [PATCH 23/33] drm/vc4: hdmi: Move HDMI reset to pm_resume

2022-08-10 Thread Stefan Wahren
Hi Florian, Am 09.08.22 um 21:02 schrieb Florian Fainelli: On 8/4/22 16:11, Florian Fainelli wrote: On 6/13/22 07:47, Maxime Ripard wrote: From: Dave Stevenson The BCM2835-37 found in the RaspberryPi 0 to 3 have a power domain attached to the HDMI block, handled in Linux through runtime_pm.

Re: [PATCH 0/2] Add DP MST DSC support to i915

2022-08-10 Thread Lyude Paul
Btw, what's the plan for this? Figured I'd ask since I noticed this on the ML, nd I'm now finishing up getting the atomic only MST patches I've been working on merged :) On Wed, 2022-08-10 at 11:17 +0300, Stanislav Lisovskiy wrote: > Currently we have only DSC support for DP SST. > > Stanislav

Re: [PATCH] drm:pl111: Add of_node_put() when breaking out of for_each_available_child_of_node()

2022-08-10 Thread Rob Herring
On Wed, Aug 10, 2022 at 10:37 AM Daniel Vetter wrote: > > On Mon, Jul 11, 2022 at 09:15:50PM +0800, Liang He wrote: > > The reference 'child' in the iteration of for_each_available_child_of_node() > > is only escaped out into a local variable which is only used to check > > its value. So we still

Re: [PATCH 3/4] drm/modes: Add initializer macro DRM_MODE_INIT()

2022-08-10 Thread Sam Ravnborg
On Wed, Aug 10, 2022 at 01:20:52PM +0200, Thomas Zimmermann wrote: > The macro DRM_MODE_INIT() initializes an instance of > struct drm_display_mode with typical parameters. Convert simpledrm > and also update the macro DRM_SIMPLE_MODE(). > > Signed-off-by: Thomas Zimmermann Reviewed-by: Sam

Re: [PATCH v8 2/2] drm/gem: Don't map imported GEMs

2022-08-10 Thread Dmitry Osipenko
On 8/10/22 14:47, Daniel Vetter wrote: > Dmitry, since you have a bunch of patches merged now I think would also be > good to get commit rights so you can drive this more yourself. I've asked > Daniel Stone to help you out with getting that. > -Daniel Thank you! -- Best regards, Dmitry

Re: [PATCH 2/4] drm/probe-helper: Add drm_crtc_helper_mode_valid_static()

2022-08-10 Thread Sam Ravnborg
Hi Thomas, On Wed, Aug 10, 2022 at 01:20:51PM +0200, Thomas Zimmermann wrote: > Add drm_crtc_helper_mode_valid_static(), which validates a given mode > against a display hardware's mode. Convert simpledrm and use it in a > few other drivers with static modes. > > Signed-off-by: Thomas Zimmermann

Re: [PATCH v8 2/2] drm/gem: Don't map imported GEMs

2022-08-10 Thread Dmitry Osipenko
On 8/10/22 18:08, Rob Clark wrote: > On Wed, Aug 10, 2022 at 4:47 AM Daniel Vetter wrote: >> >> On Wed, Jul 06, 2022 at 10:02:07AM +0300, Dmitry Osipenko wrote: >>> On 7/6/22 00:48, Rob Clark wrote: On Tue, Jul 5, 2022 at 4:51 AM Christian König wrote: > > Am 01.07.22 um 11:02

[PATCH v3] drm/msm/dp: check hpd_state before push idle pattern at dp_bridge_disable()

2022-08-10 Thread Kuogee Hsieh
dp_bridge_disable() is the first step toward tearing down main link. Its major function is to start transmitting idle pattern to replace video stream. This patch will check hpd_state to make sure main link is enabled before commit changes of main link's configuration to push idle pattern out to

Re: [PATCH 1/4] drm/probe-helper: Add drm_connector_helper_get_modes_static()

2022-08-10 Thread Sam Ravnborg
Hi Thomas, On Wed, Aug 10, 2022 at 01:20:50PM +0200, Thomas Zimmermann wrote: > Add drm_connector_helper_get_modes_static(), which duplicates a single > display mode for a connector. Convert drivers. I like this helper! There are a lot of panels that can benefit from the same helper. The

Re: [PATCH 1/7] dt-bindings: msm/dp: Add SDM845 and SC8280XP compatibles

2022-08-10 Thread Rob Herring
On Wed, Aug 10, 2022 at 05:47:52PM +0300, Krzysztof Kozlowski wrote: > On 10/08/2022 06:50, Bjorn Andersson wrote: > > Add compatibles for the DisplayPort and Embedded DisplayPort blocks in > > Qualcomm SDM845 and SC8280XP platforms. > > > > Signed-off-by: Bjorn Andersson > > --- > >

Re: [Linaro-mm-sig] [PATCH v2 3/5] dma-buf: Move all dma-bufs to dynamic locking specification

2022-08-10 Thread Dmitry Osipenko
On 8/10/22 21:25, Christian König wrote: > Am 10.08.22 um 19:49 schrieb Dmitry Osipenko: >> On 8/10/22 14:30, Christian König wrote: >>> Am 25.07.22 um 17:18 schrieb Dmitry Osipenko: This patch moves the non-dynamic dma-buf users over to the dynamic locking specification. The strict

[Bug 215618] vblank related lockup during start of SteamVR using Valve Index HMD

2022-08-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215618 --- Comment #4 from farmb...@googlemail.com --- The issue still happens with 5.18.9. The issue has also been reported to mesa and someone bisected it to the following commit: https://gitlab.freedesktop.org/drm/amd/-/issues/1980#note_1400657 --

Re: [Linaro-mm-sig] [PATCH v2 3/5] dma-buf: Move all dma-bufs to dynamic locking specification

2022-08-10 Thread Christian König
Am 10.08.22 um 19:49 schrieb Dmitry Osipenko: On 8/10/22 14:30, Christian König wrote: Am 25.07.22 um 17:18 schrieb Dmitry Osipenko: This patch moves the non-dynamic dma-buf users over to the dynamic locking specification. The strict locking convention prevents deadlock situation for dma-buf

Re: [PATCH v5] drm: Add initial ci/ subdirectory

2022-08-10 Thread Rodrigo Siqueira Jordao
Hi Tomeu, First of all, nice patch! I just saw it, and I have some basic questions (I don't understand many of these CI details). I also CC some CI folks from the display team at AMD. On 2022-07-26 14:16, Tomeu Vizoso wrote: And use it to store expectations about what the DRM drivers are

Re: [PATCH v2] drm/msm/dp: check hpd_state before push idle pattern at dp_bridge_disable()

2022-08-10 Thread Abhinav Kumar
On 8/10/2022 10:22 AM, Kuogee Hsieh wrote: dp_bridge_disable() is the first step toward tearing down main link. Its major function is to start transmitting idle pattern to replace video stream. This patch will check hpd_state to make sure main link is enabled before commit changes of main

Re: [PATCH v2 1/3] media: vsp1: add premultiplied alpha support

2022-08-10 Thread Sergey Shtylyov
Hello! On 8/10/22 11:37 AM, Takanari Hayama wrote: > To support DRM blend mode in R-Car DU driver, we must be able to pass > a plane with the premultiplied alpha. Adding a new property to > vsp1_du_atomic_config allows the R-Car DU driver to pass the > premultiplied alpha plane. > >

Re: [Linaro-mm-sig] [PATCH v2 3/5] dma-buf: Move all dma-bufs to dynamic locking specification

2022-08-10 Thread Dmitry Osipenko
On 8/10/22 14:30, Christian König wrote: >> + * - dma_buf_move_notify() > > This one is called by the exporter, not the importer. Good catch, thank you! -- Best regards, Dmitry

Re: [Linaro-mm-sig] [PATCH v2 3/5] dma-buf: Move all dma-bufs to dynamic locking specification

2022-08-10 Thread Dmitry Osipenko
On 8/10/22 14:30, Christian König wrote: > Am 25.07.22 um 17:18 schrieb Dmitry Osipenko: >> This patch moves the non-dynamic dma-buf users over to the dynamic >> locking specification. The strict locking convention prevents deadlock >> situation for dma-buf importers and exporters. >> >>

Re: [PATCH 1/8] dt-bindings: display: ti,am65x-dss: Add port properties for DSS

2022-08-10 Thread Rob Herring
On Mon, Jul 25, 2022 at 04:56:15PM +0530, Aradhya Bhatia wrote: > > > On 21-Jul-22 04:58, Rob Herring wrote: > > On Tue, Jul 19, 2022 at 01:38:38PM +0530, Aradhya Bhatia wrote: > > > Add "ti,oldi-mode" property to indicate the tidss driver the OLDI output > > > mode. The 2 OLDI TXes on am625-dss

[Bug 216350] New: amdgpu 0000:06:00.0: drm_WARN_ON(atomic_read(>refcount) == 0)

2022-08-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216350 Bug ID: 216350 Summary: amdgpu :06:00.0: drm_WARN_ON(atomic_read(>refcount) == 0) Product: Drivers Version: 2.5 Kernel Version: 5.19 and older Hardware: AMD

[PATCH] dma-buf/dma-resv: check if the new fence is really later

2022-08-10 Thread Christian König
Previously when we added a fence to a dma_resv object we always assumed the the newer than all the existing fences. With Jason's work to add an UAPI to explicit export/import that's not necessary the case any more. So without this check we would allow userspace to force the kernel into an use

[PATCH v2] drm/msm/dp: check hpd_state before push idle pattern at dp_bridge_disable()

2022-08-10 Thread Kuogee Hsieh
dp_bridge_disable() is the first step toward tearing down main link. Its major function is to start transmitting idle pattern to replace video stream. This patch will check hpd_state to make sure main link is enabled before commit changes of main link's configuration to push idle pattern out to

Re: [Intel-gfx] [PATCH] dma-buf: revert "return only unsignaled fences in dma_fence_unwrap_for_each v3"

2022-08-10 Thread Daniel Vetter
On Wed, Aug 10, 2022 at 07:01:55PM +0200, Christian König wrote: > Am 10.08.22 um 18:54 schrieb Daniel Vetter: > > On Tue, 12 Jul 2022 at 12:28, Christian König > > wrote: > > > This reverts commit 8f61973718485f3e89bc4f408f929048b7b47c83. > > > > > > It turned out that this is not correct.

Re: [Intel-gfx] [PATCH] dma-buf: revert "return only unsignaled fences in dma_fence_unwrap_for_each v3"

2022-08-10 Thread Christian König
Am 10.08.22 um 18:54 schrieb Daniel Vetter: On Tue, 12 Jul 2022 at 12:28, Christian König wrote: This reverts commit 8f61973718485f3e89bc4f408f929048b7b47c83. It turned out that this is not correct. Especially the sync_file info IOCTL needs to see even signaled fences to correctly report back

Re: [Intel-gfx] [PATCH] dma-buf: revert "return only unsignaled fences in dma_fence_unwrap_for_each v3"

2022-08-10 Thread Daniel Vetter
On Tue, 12 Jul 2022 at 12:28, Christian König wrote: > > This reverts commit 8f61973718485f3e89bc4f408f929048b7b47c83. > > It turned out that this is not correct. Especially the sync_file info > IOCTL needs to see even signaled fences to correctly report back their > status to userspace. > >

Re: [Linaro-mm-sig] [PATCH] dma-buf/dma_resv_usage: update explicit sync documentation

2022-08-10 Thread Daniel Vetter
On Wed, Jul 13, 2022 at 01:27:13PM +0200, Bas Nieuwenhuizen wrote: > With that changed > > Reviewed-by: Bas Nieuwenhuizen Yeah this is a nice clarification. Reviewed-by: Daniel Vetter In case it hasn't landed yet or so. -Daniel > > Thanks! > > On Tue, Jul 12, 2022 at 3:23 PM Christian

Re: [PATCH 1/3] drm/amd/display: Fix merge conflict resolution in amdgpu_dm_plane.c

2022-08-10 Thread Alex Deucher
Acked-by: Alex Deucher On Mon, Aug 1, 2022 at 10:08 AM Simon Ser wrote: > > Acked-by: Simon Ser > > CC amd-gfx > > On Monday, August 1st, 2022 at 15:52, Imre Deak wrote: > > > The API change introduced in > > > > commit 30c637151cfa ("drm/plane-helper: Export individual helpers") > > > > was

Re: [PATCH] spi/panel: dt-bindings: drop 3-wire from common properties

2022-08-10 Thread Krzysztof Kozlowski
On 10/08/2022 19:18, Mark Brown wrote: > On Wed, Aug 10, 2022 at 04:13:11PM +0300, Krzysztof Kozlowski wrote: >> The spi-3wire property is device specific and should be accepted only if >> device really needs them. Drop it from common spi-peripheral-props.yaml >> schema, mention in few panel

Re: [RFC][PATCH 3/3] kselftest: Add drm_syncobj API test tool

2022-08-10 Thread Daniel Vetter
On Tue, Jul 12, 2022 at 08:52:53AM -0700, John Stultz wrote: > On Tue, Jul 12, 2022 at 12:43 AM Christian König > wrote: > > Am 12.07.22 um 06:22 schrieb John Stultz: > > > An initial pass at a drm_syncobj API test. > > > > > > Currently covers trivial use of: > > >DRM_IOCTL_SYNCOBJ_CREATE >

Re: [PATCHv2 -next] drm/amdgpu: double free error and freeing uninitialized null pointer

2022-08-10 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Aug 1, 2022 at 1:08 PM André Almeida wrote: > > Às 00:46 de 30/07/22, Sebin Sebastian escreveu: > > Fix a double free and an uninitialized pointer read error. Both tmp and > > new are pointing at same address and both are freed which leads to > > double free.

Re: [PATCH v2 1/8] drm: Disable the cursor plane on atomic contexts with virtualized drivers

2022-08-10 Thread Daniel Vetter
On Mon, Jul 11, 2022 at 11:32:39PM -0400, Zack Rusin wrote: > From: Zack Rusin > > Cursor planes on virtualized drivers have special meaning and require > that the clients handle them in specific ways, e.g. the cursor plane > should react to the mouse movement the way a mouse cursor would be >

Re: [PATCH] drm:pl111: Add of_node_put() when breaking out of for_each_available_child_of_node()

2022-08-10 Thread Daniel Vetter
On Mon, Jul 11, 2022 at 09:15:50PM +0800, Liang He wrote: > The reference 'child' in the iteration of for_each_available_child_of_node() > is only escaped out into a local variable which is only used to check > its value. So we still need to the of_node_put() when breaking of the >

Re: [PATCH v2 4/4] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb565()

2022-08-10 Thread Daniel Vetter
On Sun, Jul 17, 2022 at 07:00:54PM +0200, José Expósito wrote: > José Expósito wrote: > > I already fixed the warning and added the reviewed by tags, however, I > > noticed that rebasing the series on the latest drm-misc-next show this > > error: > > [...] > > Sorry for the extra email. I forgot

Re: [PATCH] spi/panel: dt-bindings: drop 3-wire from common properties

2022-08-10 Thread Mark Brown
On Wed, Aug 10, 2022 at 04:13:11PM +0300, Krzysztof Kozlowski wrote: > The spi-3wire property is device specific and should be accepted only if > device really needs them. Drop it from common spi-peripheral-props.yaml > schema, mention in few panel drivers which use it and include instead in >

[PATCH 1/2] dt-bindings: display: arm, versatile-tft-panel: Drop erroneous properties in example

2022-08-10 Thread Rob Herring
The 'arm,versatile-sysreg' node in the example should not have '#address-cells' and '#size-cells' properties as the child node doesn't have 'reg'. Signed-off-by: Rob Herring --- .../bindings/display/panel/arm,versatile-tft-panel.yaml| 3 --- 1 file changed, 3 deletions(-) diff --git

[PATCH 2/2] dt-bindings: arm, versatile-sysreg: Convert to DT schema format

2022-08-10 Thread Rob Herring
Convert the arm,versatile-sysreg binding to DT schema format. The original binding was missing 'simple-mfd' and a 'panel' sub node which the only user (versatile-ab.dts) of this binding has. Signed-off-by: Rob Herring --- .../bindings/arm/arm,versatile-sysreg.yaml| 35 +++

[PATCH 0/2] Convert arm,versatile-sysreg to DT schema

2022-08-10 Thread Rob Herring
This short series converts the arm,versatile-sysreg binding to DT schema. The binding is already in use in examples which unsurprisingly needs a fix with the schema added. This is part of getting rid of the remaining ~40 cases of compatibles without a schema in the examples. Rob Rob Herring

Re: [PATCH v3 00/10] drm: Add support for low-color frame buffer formats

2022-08-10 Thread Daniel Vetter
On Mon, Jul 11, 2022 at 11:12:51AM +0200, Sam Ravnborg wrote: > Hi Thomas, > > On Mon, Jul 11, 2022 at 10:50:00AM +0200, Thomas Zimmermann wrote: > > Hi > > > > Am 09.07.22 um 15:38 schrieb Sam Ravnborg: > > > Hi Geert, > > > > > > On Fri, Jul 08, 2022 at 08:20:45PM +0200, Geert Uytterhoeven

Re: [PATCH v2 0/4] drm/amd: Add more GFXOFF stats for vangogh

2022-08-10 Thread André Almeida
Às 12:57 de 10/08/22, Alex Deucher escreveu: > On Tue, Jul 26, 2022 at 2:23 PM André Almeida wrote: >> >> This series adds new logging features for GFXOFF available for vangogh >> and documentation for it. >> >> I've created a small userspace program to interact with this new debugfs >>

Re: [PATCH v3 01/10] drm/fourcc: Add drm_format_info_bpp() helper

2022-08-10 Thread Daniel Vetter
On Fri, Jul 08, 2022 at 08:20:46PM +0200, Geert Uytterhoeven wrote: > Add a helper to retrieve the actual number of bits per pixel for a > plane, taking into account the number of characters and pixels per > block for tiled formats. > > Signed-off-by: Geert Uytterhoeven > Reviewed-by: Javier

Re: [PATCH v2 0/4] drm/amd: Add more GFXOFF stats for vangogh

2022-08-10 Thread Alex Deucher
On Tue, Jul 26, 2022 at 2:23 PM André Almeida wrote: > > This series adds new logging features for GFXOFF available for vangogh > and documentation for it. > > I've created a small userspace program to interact with this new debugfs > interface and it can be found at: > >

Re: [PATCH v2 2/4] drm/amd/pm: Implement GFXOFF's entry count and residency for vangogh

2022-08-10 Thread Alex Deucher
On Tue, Jul 26, 2022 at 2:23 PM André Almeida wrote: > > Implement functions to get and set GFXOFF's entry count and residency > for vangogh. > > Signed-off-by: André Almeida > --- > .../pm/swsmu/inc/pmfw_if/smu_v11_5_ppsmc.h| 5 +- > drivers/gpu/drm/amd/pm/swsmu/inc/smu_types.h | 5 +- >

Re: [PATCH v4 1/2] dt-bindings: panel-simple-dsi: add Tianma TL057FVXP01

2022-08-10 Thread Rob Herring
On Wed, 10 Aug 2022 00:13:53 -0400, Julian Braha wrote: > Adds the bindings for the Tianma TL057FVXP01 DSI panel, > found on the Motorola Moto G6. > > Signed-off-by: Julian Braha > --- > v4: > Fixed makefile entry. > > v3: > Fixed kconfig dependencies. > > v2: > Fixed accidental whitespace

Re: [PATCH v8 2/2] drm/gem: Don't map imported GEMs

2022-08-10 Thread Rob Clark
On Wed, Aug 10, 2022 at 4:47 AM Daniel Vetter wrote: > > On Wed, Jul 06, 2022 at 10:02:07AM +0300, Dmitry Osipenko wrote: > > On 7/6/22 00:48, Rob Clark wrote: > > > On Tue, Jul 5, 2022 at 4:51 AM Christian König > > > wrote: > > >> > > >> Am 01.07.22 um 11:02 schrieb Dmitry Osipenko: > > >>>

Re: [PATCH] drm/ast: radeon amdgpu for ast add prime

2022-08-10 Thread kernel test robot
Hi oushixiong, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on drm-intel/for-linux-next linus/master v5.19 next-20220810] [cannot apply to drm-misc/drm-misc-next drm-tip/drm-tip] [If your patch is applied to the wrong

Re: [PATCH 1/7] dt-bindings: msm/dp: Add SDM845 and SC8280XP compatibles

2022-08-10 Thread Krzysztof Kozlowski
On 10/08/2022 06:50, Bjorn Andersson wrote: > Add compatibles for the DisplayPort and Embedded DisplayPort blocks in > Qualcomm SDM845 and SC8280XP platforms. > > Signed-off-by: Bjorn Andersson > --- > .../devicetree/bindings/display/msm/dp-controller.yaml | 3 +++ > 1 file changed, 3

Re: [PATCH] drm/drm_edid: Refactor HFVSDB parsing for DSC1.2

2022-08-10 Thread Nautiyal, Ankit K
On 8/2/2022 8:19 PM, Jani Nikula wrote: On Fri, 22 Jul 2022, Ankit Nautiyal wrote: DSC capabilities are given in bytes 11-13 of VSDB (i.e. bytes 8-10 of SCDS). Since minimum length of Data block is 7, all bytes greater than 7 must be read only after checking the length of the data block.

Re: New subsystem for acceleration devices

2022-08-10 Thread Oded Gabbay
On Wed, Aug 10, 2022 at 5:10 PM wrote: > > > -Original Message- > > From: Oded Gabbay > > Sent: Wednesday, August 10, 2022 6:42 AM > > To: Dave Airlie ; Greg Kroah-Hartman > > ; ishikawa yuji(石川 悠司 ○RDC□AITC○ > > EA開) ; Jiho Chu > > Cc: dri-devel ; Arnd Bergmann > > ; Linux-Kernel@Vger.

RE: New subsystem for acceleration devices

2022-08-10 Thread yuji2.ishikawa
> -Original Message- > From: Oded Gabbay > Sent: Wednesday, August 10, 2022 6:42 AM > To: Dave Airlie ; Greg Kroah-Hartman > ; ishikawa yuji(石川 悠司 ○RDC□AITC○ > EA開) ; Jiho Chu > Cc: dri-devel ; Arnd Bergmann > ; Linux-Kernel@Vger. Kernel. Org > ; Jason Gunthorpe > Subject: Re: New

Re: [PATCH 1/2] drm/cmdline-parser: Merge negative tests

2022-08-10 Thread Maíra Canal
On 8/4/22 10:17, Michał Winiarski wrote: > Negative tests can be expressed as a single parameterized test case, > which highlights that we're following the same test logic (passing > negative cmdline and expecting drm_mode_parse_command_line_for_connector > to fail), which improves readability.

Re: [PATCH 2/2] drm/cmdline-parser: Use assert when needed

2022-08-10 Thread Maíra Canal
Hi Michał On 8/4/22 10:17, Michał Winiarski wrote: > Expecting to observe a specific value, when the function responsible for > setting the value has failed will lead to extra noise in test output. > Use assert when the situation calls for it. > Also - very small tidying up around the changed

Re: [EXT] Re: [PATCH 1/3] dma-buf: heaps: add Linaro secure dmabuf heap support

2022-08-10 Thread Olivier Masse
Hi Christian, Thanks for your comments, please find my answer below. On mer., 2022-08-10 at 11:43 +0200, Christian König wrote: > Caution: EXT Email > > Hi guys, > > Am 05.08.22 um 15:53 schrieb Olivier Masse: > > add Linaro secure heap bindings: linaro,secure-heap > > use genalloc to

Re: [PATCH 1/7] dt-bindings: msm/dp: Add SDM845 and SC8280XP compatibles

2022-08-10 Thread Rob Herring
On Tue, 09 Aug 2022 20:50:07 -0700, Bjorn Andersson wrote: > Add compatibles for the DisplayPort and Embedded DisplayPort blocks in > Qualcomm SDM845 and SC8280XP platforms. > > Signed-off-by: Bjorn Andersson > --- > .../devicetree/bindings/display/msm/dp-controller.yaml | 3 +++ > 1

Re: [PATCH v2 1/3] drm/dp_mst: add passthrough_aux to struct drm_dp_mst_port

2022-08-10 Thread Hamza Mahfooz
On 2022-08-09 18:01, Lyude Paul wrote: Ah yes of course! Probably should have asked when I gave the r-b :). Also, just so patchwork actually catches it I will say the magic incantation: Reviewed-by: Lyude Paul Do we want to merge just this patch to drm-misc-next, or do you want to merge the

[PATCH] spi/panel: dt-bindings: drop 3-wire from common properties

2022-08-10 Thread Krzysztof Kozlowski
The spi-3wire property is device specific and should be accepted only if device really needs them. Drop it from common spi-peripheral-props.yaml schema, mention in few panel drivers which use it and include instead in the SPI controller bindings. The controller bindings will provide spi-3wire

Re: [PATCH] virt: acrn: obtain pa from VMA with PFNMAP flag

2022-08-10 Thread Daniel Vetter
On Mon, Feb 28, 2022 at 05:22:12AM +0300, Yonghua Huang wrote: > acrn_vm_ram_map can't pin the user pages with VM_PFNMAP flag > by calling get_user_pages_fast(), the PA(physical pages) > may be mapped by kernel driver and set PFNMAP flag. > > This patch fixes logic to setup EPT mapping for

Re: [Linaro-mm-sig] [PATCH] dma-buf/sync_file: use strscpy to replace strlcpy

2022-08-10 Thread Daniel Vetter
On Fri, Jul 01, 2022 at 07:26:07PM +0800, XueBing Chen wrote: > > The strlcpy should not be used because it doesn't limit the source > length. Preferred is strscpy. > > Signed-off-by: XueBing Chen I don't think there's an impact here since we don't check the error return value, but also

Re: [PATCH v8 2/2] drm/gem: Don't map imported GEMs

2022-08-10 Thread Daniel Vetter
On Wed, Jul 06, 2022 at 10:02:07AM +0300, Dmitry Osipenko wrote: > On 7/6/22 00:48, Rob Clark wrote: > > On Tue, Jul 5, 2022 at 4:51 AM Christian König > > wrote: > >> > >> Am 01.07.22 um 11:02 schrieb Dmitry Osipenko: > >>> Drivers that use drm_gem_mmap() and drm_gem_mmap_obj() helpers don't >

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: Use of BARs names instead of numbers

2022-08-10 Thread Jani Nikula
On Wed, 10 Aug 2022, Andrzej Hajda wrote: > On 05.08.2022 17:59, Piorkowski, Piotr wrote: >> +/* PCI BARs */ >> +#define GTTMMADR_BAR0 >> +#define GEN2_GTTMMADR_BAR 1 >> +#define GFXMEM_BAR 2 >> +#define GTT_APERTURE_BAR

Re: [Linaro-mm-sig] [PATCH v2 3/5] dma-buf: Move all dma-bufs to dynamic locking specification

2022-08-10 Thread Christian König
Am 25.07.22 um 17:18 schrieb Dmitry Osipenko: This patch moves the non-dynamic dma-buf users over to the dynamic locking specification. The strict locking convention prevents deadlock situation for dma-buf importers and exporters. Previously the "unlocked" versions of the dma-buf API functions

[PATCH 1/4] drm/probe-helper: Add drm_connector_helper_get_modes_static()

2022-08-10 Thread Thomas Zimmermann
Add drm_connector_helper_get_modes_static(), which duplicates a single display mode for a connector. Convert drivers. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_mipi_dbi.c | 20 +-- drivers/gpu/drm/drm_probe_helper.c | 40 ++

[PATCH 3/4] drm/modes: Add initializer macro DRM_MODE_INIT()

2022-08-10 Thread Thomas Zimmermann
The macro DRM_MODE_INIT() initializes an instance of struct drm_display_mode with typical parameters. Convert simpledrm and also update the macro DRM_SIMPLE_MODE(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tiny/simpledrm.c | 23 - include/drm/drm_modes.h

[PATCH 4/4] drm/format-helper: Add drm_fb_build_fourcc_list() helper

2022-08-10 Thread Thomas Zimmermann
Add drm_fb_build_fourcc_list() function that builds a list of supported formats from native and emulated ones. Helpful for all drivers that do format conversion as part of their plane updates. Update current caller. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_format_helper.c | 94

[PATCH 0/4] drm/probe-helper, modes: Helpers for single-mode displays

2022-08-10 Thread Thomas Zimmermann
This patchset moves code from simpledrm to probe and display-mode helpers. The new functions will be useful for the upcomming driver for PowerPC displays. [1] Where possible, existing drivers are being converted to use them. [1] https://patchwork.freedesktop.org/series/106538/ Thomas Zimmermann

[PATCH 2/4] drm/probe-helper: Add drm_crtc_helper_mode_valid_static()

2022-08-10 Thread Thomas Zimmermann
Add drm_crtc_helper_mode_valid_static(), which validates a given mode against a display hardware's mode. Convert simpledrm and use it in a few other drivers with static modes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_mipi_dbi.c | 18 ++

Re: [PATCH 23/33] drm/vc4: hdmi: Move HDMI reset to pm_resume

2022-08-10 Thread Dave Stevenson
Hi Florian On Tue, 9 Aug 2022 at 20:02, Florian Fainelli wrote: > > On 8/4/22 16:11, Florian Fainelli wrote: > > On 6/13/22 07:47, Maxime Ripard wrote: > >> From: Dave Stevenson > >> > >> The BCM2835-37 found in the RaspberryPi 0 to 3 have a power domain > >> attached to the HDMI block, handled

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: Use of BARs names instead of numbers

2022-08-10 Thread Andrzej Hajda
On 05.08.2022 17:59, Piorkowski, Piotr wrote: From: Piotr Piórkowski At the moment, when we refer to some PCI BAR we use the number of this BAR in the code. The meaning of BARs between different platforms may be different. Therefore, in order to organize the code, let's start using defined

  1   2   >