Re: [PATCH v3 02/15] mei: add support to GSC extended header

2022-09-08 Thread Greg Kroah-Hartman
On Thu, Sep 08, 2022 at 09:24:07PM +, Winkler, Tomas wrote: > > > > > On Fri, Aug 19, 2022 at 03:53:22PM -0700, Daniele Ceraolo Spurio wrote: > > > --- a/drivers/misc/mei/hw-me.c > > > +++ b/drivers/misc/mei/hw-me.c > > > @@ -590,7 +590,10 @@ static int mei_me_hbuf_write(struct mei_device >

[Bug 205089] amdgpu : drm:amdgpu_cs_ioctl : Failed to initialize parser -125

2022-09-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205089 Oscar Parada (oparada1...@gmail.com) changed: What|Removed |Added CC|

RE: [PATCH v2 15/15] vfio: Add struct device to vfio_device

2022-09-08 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Thursday, September 8, 2022 8:37 PM > > On Thu, Sep 08, 2022 at 11:39:07AM +0200, Eric Auger wrote: > > > >> I am not totally clear about remaining 'struct device *dev;' in > > >> vfio_device struct. I see it used in some places. Is it supposed to > > >> disappear

[PATCH v3 14/15] vfio: Rename vfio_device_put() and vfio_device_try_get()

2022-09-08 Thread Kevin Tian
With the addition of vfio_put_device() now the names become confusing. vfio_put_device() is clear from object life cycle p.o.v given kref. vfio_device_put()/vfio_device_try_get() are helpers for tracking users on a registered device. Now rename them: - vfio_device_put() ->

[PATCH v3 15/15] vfio: Add struct device to vfio_device

2022-09-08 Thread Kevin Tian
From: Yi Liu and replace kref. With it a 'vfio-dev/vfioX' node is created under the sysfs path of the parent, indicating the device is bound to a vfio driver, e.g.: /sys/devices/pci\:6f/\:6f\:01.0/vfio-dev/vfio0 It is also a preparatory step toward adding cdev for supporting future

[PATCH v3 13/15] vfio/ccw: Use the new device life cycle helpers

2022-09-08 Thread Kevin Tian
ccw is the only exception which cannot use vfio_alloc_device() because its private device structure is designed to serve both mdev and parent. Life cycle of the parent is managed by css_driver so vfio_ccw_private must be allocated/freed in css_driver probe/remove path instead of conforming to vfio

[PATCH v3 12/15] vfio/amba: Use the new device life cycle helpers

2022-09-08 Thread Kevin Tian
Implement amba's own vfio_device_ops. Remove vfio_platform_probe/remove_common() given no user now. Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe Reviewed-by: Eric Auger --- drivers/vfio/platform/vfio_amba.c | 72 ++-

[PATCH v3 08/15] drm/i915/gvt: Use the new device life cycle helpers

2022-09-08 Thread Kevin Tian
Move vfio_device to the start of intel_vgpu as required by the new helpers. Change intel_gvt_create_vgpu() to use intel_vgpu as the first param as other vgpu helpers do. Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe Reviewed-by: Zhenyu Wang --- drivers/gpu/drm/i915/gvt/gvt.h | 5

[PATCH v3 11/15] vfio/platform: Use the new device life cycle helpers

2022-09-08 Thread Kevin Tian
Move vfio_device_ops from platform core to platform drivers so device specific init/cleanup can be added. Introduce two new helpers vfio_platform_init/release_common() for the use in driver @init/@release. vfio_platform_probe/remove_common() will be deprecated. Signed-off-by: Kevin Tian

[PATCH v3 10/15] vfio/fsl-mc: Use the new device life cycle helpers

2022-09-08 Thread Kevin Tian
From: Yi Liu Also add a comment to mark that vfio core releases device_set if @init fails. Signed-off-by: Yi Liu Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe --- drivers/vfio/fsl-mc/vfio_fsl_mc.c | 85 ++- 1 file changed, 49 insertions(+), 36

[PATCH v3 05/15] vfio/mdpy: Use the new device life cycle helpers

2022-09-08 Thread Kevin Tian
From: Yi Liu and manage mdpy_count inside @init/@release. Signed-off-by: Yi Liu Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe --- samples/vfio-mdev/mdpy.c | 81 +++- 1 file changed, 47 insertions(+), 34 deletions(-) diff --git

[PATCH v3 07/15] vfio/mbochs: Use the new device life cycle helpers

2022-09-08 Thread Kevin Tian
From: Yi Liu and manage avail_mbytes inside @init/@release. Signed-off-by: Yi Liu Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe --- samples/vfio-mdev/mbochs.c | 73 -- 1 file changed, 46 insertions(+), 27 deletions(-) diff --git

[PATCH v3 09/15] vfio/ap: Use the new device life cycle helpers

2022-09-08 Thread Kevin Tian
From: Yi Liu and manage available_instances inside @init/@release. Signed-off-by: Yi Liu Signed-off-by: Kevin Tian Reviewed-by: Tony Krowiak Reviewed-by: Jason Gunthorpe --- drivers/s390/crypto/vfio_ap_ops.c | 50 ++- 1 file changed, 29 insertions(+), 21

[PATCH v3 03/15] vfio/mlx5: Use the new device life cycle helpers

2022-09-08 Thread Kevin Tian
From: Yi Liu mlx5 has its own @init/@release for handling migration cap. Signed-off-by: Yi Liu Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe --- drivers/vfio/pci/mlx5/main.c | 50 ++-- 1 file changed, 36 insertions(+), 14 deletions(-) diff --git

[PATCH v3 06/15] vfio/mtty: Use the new device life cycle helpers

2022-09-08 Thread Kevin Tian
From: Yi Liu and manage available ports inside @init/@release. Signed-off-by: Yi Liu Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe --- samples/vfio-mdev/mtty.c | 67 +++- 1 file changed, 39 insertions(+), 28 deletions(-) diff --git

[PATCH v3 01/15] vfio: Add helpers for unifying vfio_device life cycle

2022-09-08 Thread Kevin Tian
The idea is to let vfio core manage the vfio_device life cycle instead of duplicating the logic cross drivers. This is also a preparatory step for adding struct device into vfio_device. New pair of helpers together with a kref in vfio_device: - vfio_alloc_device() - vfio_put_device() Drivers

[PATCH v3 00/15] Tidy up vfio_device life cycle

2022-09-08 Thread Kevin Tian
The idea is to let vfio core manage the vfio_device life cycle instead of duplicating the logic cross drivers. Besides cleaner code in driver side this also allows adding struct device to vfio_device as the first step toward adding cdev uAPI in the future. Another benefit is that user can now look

[PATCH v3 04/15] vfio/hisi_acc: Use the new device life cycle helpers

2022-09-08 Thread Kevin Tian
From: Yi Liu Tidy up @probe so all migration specific initialization logic is moved to migration specific @init callback. Remove vfio_pci_core_{un}init_device() given no user now. Signed-off-by: Yi Liu Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe Reviewed-by: Shameer Kolothum ---

[PATCH v3 02/15] vfio/pci: Use the new device life cycle helpers

2022-09-08 Thread Kevin Tian
From: Yi Liu Also introduce two pci core helpers as @init/@release for pci drivers: - vfio_pci_core_init_dev() - vfio_pci_core_release_dev() Signed-off-by: Yi Liu Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe --- drivers/vfio/pci/vfio_pci.c | 20 +-

[PATCH] drm/qxl: drop set_prod_notify parameter from qxl_ring_create

2022-09-08 Thread Zongmin Zhou
Since qxl_io_reset(qdev) will be called immediately after qxl_ring_create() been called, and parameter like notify_on_prod will be set to default value. So the call to qxl_ring_init_hdr() before becomes meaningless. Signed-off-by: Zongmin Zhou Suggested-by: Ming Xie ---

RE: [PATCH v2 13/15] vfio/ccw: Use the new device life cycle helpers

2022-09-08 Thread Tian, Kevin
> From: Eric Farman > Sent: Friday, September 9, 2022 4:51 AM > > On Thu, 2022-09-08 at 07:19 +, Tian, Kevin wrote: > > ping @Eric Farman. > > > > ccw is the only tricky player in this series. Please help take a look > > in case of > > any oversight here. > > Apologies, I had started looking

Re: [PATCH 1/2] dt-bindings: display: panel: Add NewVision NV3051D panel bindings

2022-09-08 Thread Rob Herring
On Wed, Sep 07, 2022 at 08:35:13AM -0500, Chris Morgan wrote: > On Wed, Sep 07, 2022 at 02:53:56PM +0200, Krzysztof Kozlowski wrote: > > On 06/09/2022 20:52, Chris Morgan wrote: > > > From: Chris Morgan > > > > > > Add documentation for the NewVision NV3051D panel bindings. > > > Note that for

Re: [PATCH v2 2/5] dt-bindings: phy-rockchip-inno-dsidphy: add compatible for rk3568

2022-09-08 Thread Rob Herring
On Tue, 06 Sep 2022 12:48:20 -0500, Chris Morgan wrote: > From: Chris Morgan > > Add a compatible string for the rk3568 dsi-dphy. > > Signed-off-by: Chris Morgan > --- > .../devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob

Re: [PATCH v2 1/5] dt-bindings: display: rockchip-dsi: add rk3568 compatible

2022-09-08 Thread Rob Herring
On Tue, 06 Sep 2022 12:48:19 -0500, Chris Morgan wrote: > From: Chris Morgan > > The rk3568 uses the same dw-mipi-dsi controller as previous Rockchip > SOCs, so add a compatible string for it. > > Signed-off-by: Chris Morgan > --- > .../bindings/display/rockchip/dw_mipi_dsi_rockchip.txt

Re: [PATCH v4 15/15] HAX: drm/i915: force INTEL_MEI_GSC and INTEL_MEI_PXP on for CI

2022-09-08 Thread Ceraolo Spurio, Daniele
I've submitted a merge request to have those flags turned on by default in our CI builds: https://gitlab.freedesktop.org/gfx-ci/i915-infra/-/merge_requests/116 Daniele On 9/8/2022 5:16 PM, Daniele Ceraolo Spurio wrote: Both are required for HuC loading. Signed-off-by: Daniele Ceraolo Spurio

[PATCH v4 12/15] drm/i915/huc: stall media submission until HuC is loaded

2022-09-08 Thread Daniele Ceraolo Spurio
Wait on the fence to be signalled to avoid the submissions finding HuC not yet loaded. Signed-off-by: Daniele Ceraolo Spurio Cc: Tony Ye Reviewed-by: Alan Previn --- drivers/gpu/drm/i915/gt/uc/intel_huc.h | 6 ++ drivers/gpu/drm/i915/i915_request.c| 24 2

[PATCH v4 15/15] HAX: drm/i915: force INTEL_MEI_GSC and INTEL_MEI_PXP on for CI

2022-09-08 Thread Daniele Ceraolo Spurio
Both are required for HuC loading. Signed-off-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/Kconfig.debug | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug index e7fd3e76f8a2..a6576ffbc4dc 100644 ---

[PATCH v4 09/15] drm/i915/pxp: add huc authentication and loading command

2022-09-08 Thread Daniele Ceraolo Spurio
From: Tomas Winkler Add support for loading HuC via a pxp stream command. V4: 1. Remove unnecessary include in intel_pxp_huc.h (Jani) 2. Adjust copyright year to 2022 Signed-off-by: Tomas Winkler Signed-off-by: Vitaly Lubart Signed-off-by: Daniele Ceraolo Spurio Cc: Alan Previn

[PATCH v4 06/15] mei: pxp: support matching with a gfx discrete card

2022-09-08 Thread Daniele Ceraolo Spurio
From: Tomas Winkler With on-boards graphics card, both i915 and MEI are in the same device hierarchy with the same parent, while for discrete gfx card the MEI is its child device. Adjust the match function for that scenario by matching MEI parent device with i915. V2: 1. More detailed commit

[PATCH v4 05/15] mei: pxp: add command streamer API to the PXP driver

2022-09-08 Thread Daniele Ceraolo Spurio
From: Vitaly Lubart The discrete graphics card with GSC firmware using command streamer API hence it requires to enhance pxp module with the new gsc_command() handler. The handler is implemented via mei_pxp_gsc_command() which is just a thin wrapper around mei_cldev_send_gsc_command() V2: 1.

[PATCH v4 07/15] drm/i915/pxp: load the pxp module when we have a gsc-loaded huc

2022-09-08 Thread Daniele Ceraolo Spurio
The mei_pxp module is required to send the command to load authenticate the HuC to the GSC even if pxp is not in use for protected content management. Signed-off-by: Daniele Ceraolo Spurio Cc: Alan Previn Reviewed-by: Alan Previn --- drivers/gpu/drm/i915/Makefile| 10 +++---

[PATCH v4 14/15] drm/i915/huc: define gsc-compatible HuC fw for DG2

2022-09-08 Thread Daniele Ceraolo Spurio
The fw name is different and we need to record the fact that the blob is gsc-loaded, so add a new macro to help. Note: A-step DG2 G10 does not support HuC loading via GSC and would require a separate firmware to be loaded the legacy way, but that's not a production stepping so we're not going to

[PATCH v4 13/15] drm/i915/huc: better define HuC status getparam possible return values.

2022-09-08 Thread Daniele Ceraolo Spurio
The current HuC status getparam return values are a bit confusing in regards to what happens in some scenarios. In particular, most of the error cases cause the ioctl to return an error, but a couple of them, INIT_FAIL and LOAD_FAIL, are not explicitly handled and neither is their expected return

[PATCH v4 11/15] drm/i915/huc: track delayed HuC load with a fence

2022-09-08 Thread Daniele Ceraolo Spurio
Given that HuC load is delayed on DG2, this patch adds support for a fence that can be used to wait for load completion. No waiters are added in this patch (they're coming up in the next one), to keep the focus of the patch on the tracking logic. The full HuC loading flow on boot DG2 is as

[PATCH v4 08/15] drm/i915/pxp: implement function for sending tee stream command

2022-09-08 Thread Daniele Ceraolo Spurio
From: Vitaly Lubart Command to be sent via the stream interface are written to a local memory page, whose address is then provided to the GSC. The interface supports providing a full sg with multiple pages for both input and output messages, but since for now we only aim to support short and

[PATCH v4 04/15] mei: bus: extend bus API to support command streamer API

2022-09-08 Thread Daniele Ceraolo Spurio
From: Vitaly Lubart Add mei bus API for sending gsc commands: mei_cldev_send_gsc_command() The GSC commands are originated in the graphics stack and are in form of SGL DMA buffers. The GSC commands are synchronous, the response is received in the same call on the out sg list buffers. The

[PATCH v4 01/15] mei: add support to GSC extended header

2022-09-08 Thread Daniele Ceraolo Spurio
From: Tomas Winkler GSC extend header is of variable size and data is provided in a sgl list inside the header and not in the data buffers, need to enable the path. V2: 1. Add missing kdoc for mei_cl_cb 2. In mei_me_hbuf_write() use dev_err() when validationg parameters instead of WARN_ON()

[PATCH v4 10/15] drm/i915/dg2: setup HuC loading via GSC

2022-09-08 Thread Daniele Ceraolo Spurio
The GSC will perform both the load and the authentication, so we just need to check the auth bit after the GSC has replied. Since we require the PXP module to load the HuC, the earliest we can trigger the load is during the pxp_bind operation. Note that GSC-loaded HuC survives GT reset, so we

[PATCH v4 02/15] mei: bus: enable sending gsc commands

2022-09-08 Thread Daniele Ceraolo Spurio
From: Tomas Winkler GSC command is and extended header containing a scatter gather list and without a data buffer. Using MEI_CL_IO_SGL flag, the caller send the GSC command as a data and the function internally moves it to the extended header. Signed-off-by: Tomas Winkler Signed-off-by:

[PATCH v4 03/15] mei: adjust extended header kdocs

2022-09-08 Thread Daniele Ceraolo Spurio
From: Tomas Winkler Fix kdoc for struct mei_ext_hdr and mei_ext_begin(). V4: New in the series Signed-off-by: Tomas Winkler Signed-off-by: Daniele Ceraolo Spurio Cc: Greg Kroah-Hartman --- drivers/misc/mei/hw.h | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git

[PATCH v4 00/15] drm/i915: HuC loading for DG2

2022-09-08 Thread Daniele Ceraolo Spurio
On DG2, HuC loading is performed by the GSC, via a PXP command. The load operation itself is relatively simple (just send a message to the GSC with the physical address of the HuC in LMEM), but there are timing changes that requires special attention. In particular, to send a PXP command we need

Re: [PATCH v4 00/15]

2022-09-08 Thread Ceraolo Spurio, Daniele
Please ignore this cover letter, I've only realized I was missing a title and aborted the git-send after sending it. Proper series coming in a couple of mins. Daniele On 9/8/2022 5:10 PM, Daniele Ceraolo Spurio wrote: On DG2, HuC loading is performed by the GSC, via a PXP command. The load

[PATCH v4 00/15]

2022-09-08 Thread Daniele Ceraolo Spurio
On DG2, HuC loading is performed by the GSC, via a PXP command. The load operation itself is relatively simple (just send a message to the GSC with the physical address of the HuC in LMEM), but there are timing changes that requires special attention. In particular, to send a PXP command we need

Re: [PATCH v3.1 10/14] drm/i915/uncore: Add GSI offset to uncore

2022-09-08 Thread Ceraolo Spurio, Daniele
On 9/8/2022 3:45 PM, Matt Roper wrote: GT non-engine registers (referred to as "GSI" registers by the spec) have the same relative offsets on standalone media as they do on the primary GT, just with an additional "GSI offset" added to their MMIO address. If we store this GSI offset in the

[PATCH v3.1 10/14] drm/i915/uncore: Add GSI offset to uncore

2022-09-08 Thread Matt Roper
GT non-engine registers (referred to as "GSI" registers by the spec) have the same relative offsets on standalone media as they do on the primary GT, just with an additional "GSI offset" added to their MMIO address. If we store this GSI offset in the standalone media's intel_uncore structure, it

[linux-next:master] BUILD REGRESSION 47c191411b68a771261be3dc0bd6f68394cef358

2022-09-08 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 47c191411b68a771261be3dc0bd6f68394cef358 Add linux-next specific files for 20220908 Error/Warning reports: https://lore.kernel.org/linux-mm/202209042337.fqi69rlv-...@intel.com https

Re: [PATCH v3 10/14] drm/i915/uncore: Add GSI offset to uncore

2022-09-08 Thread Matt Roper
On Thu, Sep 08, 2022 at 02:16:27PM -0700, Ceraolo Spurio, Daniele wrote: > > > On 9/6/2022 4:49 PM, Matt Roper wrote: > > GT non-engine registers (referred to as "GSI" registers by the spec) > > have the same relative offsets on standalone media as they do on the > > primary GT, just with an

Re: [PATCH v4 2/2] drm/msm/dp: retry 3 times if set sink to D0 poweer state failed

2022-09-08 Thread Dmitry Baryshkov
On Fri, 9 Sept 2022 at 00:18, Kuogee Hsieh wrote: > > Bring sink out of D3 (power down) mode into D0 (normal operation) mode > by setting DP_SET_POWER_D0 bit to DP_SET_POWER dpcd register. This > patch will retry 3 times if written to DP_SET_POWER register failed. > > Changes in v4: > -- split

RE: [PATCH v3 02/15] mei: add support to GSC extended header

2022-09-08 Thread Winkler, Tomas
> > On Fri, Aug 19, 2022 at 03:53:22PM -0700, Daniele Ceraolo Spurio wrote: > > --- a/drivers/misc/mei/hw-me.c > > +++ b/drivers/misc/mei/hw-me.c > > @@ -590,7 +590,10 @@ static int mei_me_hbuf_write(struct mei_device > *dev, > > u32 dw_cnt; > > int empty_slots; > > > > - if

Re: [PATCH v3 13/14] drm/i915/mtl: Use primary GT's irq lock for media GT

2022-09-08 Thread Ceraolo Spurio, Daniele
On 9/6/2022 4:49 PM, Matt Roper wrote: When we hook up interrupts (in the next patch), interrupts for the media GT are still processed as part of the primary GT's interrupt flow. As such, we should share the same IRQ lock with the primary GT. Let's convert gt->irq_lock into a pointer and

[PATCH v4 2/2] drm/msm/dp: retry 3 times if set sink to D0 poweer state failed

2022-09-08 Thread Kuogee Hsieh
Bring sink out of D3 (power down) mode into D0 (normal operation) mode by setting DP_SET_POWER_D0 bit to DP_SET_POWER dpcd register. This patch will retry 3 times if written to DP_SET_POWER register failed. Changes in v4: -- split into two patches Signed-off-by: Kuogee Hsieh ---

[PATCH v4 1/2] drm/msm/dp: cleared DP_DOWNSPREAD_CTRL register before start link training

2022-09-08 Thread Kuogee Hsieh
DOWNSPREAD_CTRL (0x107) shall be cleared to 0 upon power-on reset or an upstream device disconnect. This patch will enforce this rule by always cleared DOWNSPREAD_CTRL register to 0 before start link training. At rare case that DP MSA timing parameters may be mis-interpreted by the sink which

[PATCH v4 0/2] cleared DP_DOWNSPREAD_CTRL register

2022-09-08 Thread Kuogee Hsieh
cleared DP_DOWNSPREAD_CTRL register before start link training Kuogee Hsieh (2): drm/msm/dp: cleared DP_DOWNSPREAD_CTRL register before start link training drm/msm/dp: retry 3 times if set sink to D0 poweer state failed drivers/gpu/drm/msm/dp/dp_ctrl.c | 13 +

Re: [PATCH v3 10/14] drm/i915/uncore: Add GSI offset to uncore

2022-09-08 Thread Ceraolo Spurio, Daniele
On 9/6/2022 4:49 PM, Matt Roper wrote: GT non-engine registers (referred to as "GSI" registers by the spec) have the same relative offsets on standalone media as they do on the primary GT, just with an additional "GSI offset" added to their MMIO address. If we store this GSI offset in the

Re: [PATCH v3 09/14] drm/i915: Handle each GT on init/release and suspend/resume

2022-09-08 Thread Ceraolo Spurio, Daniele
On 9/6/2022 4:49 PM, Matt Roper wrote: In preparation for enabling a second GT, there are a number of GT/uncore operations that happen during initialization or suspend flows that need to be performed on each GT, not just the primary, Cc: Daniele Ceraolo Spurio Signed-off-by: Matt Roper

Re: [PATCH v3 08/14] drm/i915: Initialize MMIO access for each GT

2022-09-08 Thread Ceraolo Spurio, Daniele
On 9/6/2022 4:49 PM, Matt Roper wrote: In a multi-GT system we need to initialize MMIO access for each GT, not just the primary GT. Cc: Daniele Ceraolo Spurio Reviewed-by: Daniele Ceraolo Spurio Daniele Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/i915_driver.c | 27

Re: [PATCH v2 13/15] vfio/ccw: Use the new device life cycle helpers

2022-09-08 Thread Eric Farman
On Thu, 2022-09-08 at 07:19 +, Tian, Kevin wrote: > ping @Eric Farman. > > ccw is the only tricky player in this series. Please help take a look > in case of > any oversight here. Apologies, I had started looking at v1 before I left on holiday, and only returned today. > > > From: Tian,

[drm-misc:drm-misc-next 1/1] drivers/gpu/drm/sun4i/sun4i_tv.c:356:17: error: implicit declaration of function 'drm_atomic_get_new_crtc_state'; did you mean 'drm_atomic_helper_swap_state'?

2022-09-08 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next head: 5d832b6694e094b176627ed9918a1b21c56fb742 commit: ec491291dc94914cf962dcd399c3e9b43b00a770 [1/1] drm/sun4i: tv: Merge mode_set into atomic_enable config: parisc-randconfig-r003-20220907

Re: [PATCH v4 10/11] drm/i915/mtl: Update CHICKEN_TRANS* register addresses

2022-09-08 Thread Matt Roper
On Thu, Sep 01, 2022 at 11:03:41PM -0700, Radhakrishna Sripada wrote: > From: Madhumitha Tolakanahalli Pradeep > > > In Display version 14, Transcoder Chicken Registers have updated address. > This patch performs checks to use the right register when required. > > v2: Omit display version

Re: [PATCH v6 01/12] dt-bindings: display/msm: split qcom,mdss bindings

2022-09-08 Thread Dmitry Baryshkov
On 08/09/2022 22:37, Rob Herring wrote: On Thu, Sep 08, 2022 at 03:37:38PM +0200, Krzysztof Kozlowski wrote: On 01/09/2022 12:23, Dmitry Baryshkov wrote: Split Mobile Display SubSystem (MDSS) root node bindings to the separate yaml file. Changes to the existing (txt) schema: - Added optional

[PATCH v1 2/3] drm/i915/gt: Extract per-platform function for frequency read

2022-09-08 Thread Lucas De Marchi
Instead of calling read_clock_frequency() to walk the if/else ladder per platform, move the ladder to intel_gt_init_clock_frequency() and use one function per branch. With the new logic, it's now clear the call to gen9_get_crystal_clock_freq() was just dead code, as gen9 is handled by another

[PATCH v1 3/3] drm/i915: Invert if/else ladder for stolen init

2022-09-08 Thread Lucas De Marchi
Continue converting the driver to the convention of last version first, extending it to the future platforms. Now, any GRAPHICS_VER >= 11 will be handled by the first branch. Signed-off-by: Lucas De Marchi diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c

[PATCH v1 1/3] drm/i915: Invert if/else ladder for frequency read

2022-09-08 Thread Lucas De Marchi
Continue converting the driver to the convention of last version first, extending it to the future platforms. Now, any GRAPHICS_VER >= 11 will be handled by the first branch. With the new ranges it's easier to see what platform a branch started to be taken. Besides the >= 11 change, the branch

[PATCH v1 0/3] drm/i915: A couple of if/else ladder refactors

2022-09-08 Thread Lucas De Marchi
deletions(-) --- base-commit: adc57f2b82896fed07bc8e34956c15bb1448fca2 change-id: 20220908-if-ladder-df33a06d4f4e Best regards, -- Lucas De Marchi

Re: [PATCH v4 0/5] Allwinner H6 GPU devfreq

2022-09-08 Thread Jernej Škrabec
Dne torek, 06. september 2022 ob 17:30:29 CEST je Clément Péron napisal(a): > Hi, > > This is a refresh of previous patches sent to enable GPU Devfreq on H6 > Beelink GS1 but that wasn't stable at that time[0]. > > With the recent fix on GPU PLL from Roman Stratiienko I have retested > and

Re: [PATCH v4 09/11] drm/i915/mtl: Update MBUS_DBOX credits

2022-09-08 Thread Matt Roper
On Thu, Sep 01, 2022 at 11:03:40PM -0700, Radhakrishna Sripada wrote: > Display version 14 platforms have different credits values > compared to ADL-P. Update the credits based on pipe usage. > > v2: Simplify DBOX BW Credit definition(MattR) > > Bspec: 49213 > > Cc: Jose Roberto de Souza > Cc:

Re: [PATCH v6 01/12] dt-bindings: display/msm: split qcom,mdss bindings

2022-09-08 Thread Rob Herring
On Thu, Sep 08, 2022 at 03:37:38PM +0200, Krzysztof Kozlowski wrote: > On 01/09/2022 12:23, Dmitry Baryshkov wrote: > > Split Mobile Display SubSystem (MDSS) root node bindings to the separate > > yaml file. Changes to the existing (txt) schema: > > - Added optional "vbif_nrt_phys" region used by

Re: [RFC PATCH 2/3] drm/msm: filter out modes for DSI bridge having unsupported clock

2022-09-08 Thread Abhinav Kumar
Hi Dmitry On 9/8/2022 7:46 AM, Dmitry Baryshkov wrote: On 30/08/2022 06:33, Abhinav Kumar wrote: DSI interface used with a bridge chip connected to an external display is subject to the same pixel clock limits as one which is natively pluggable like DisplayPort. Hence filter out DSI modes

Re: [RFC PATCH 3/3] drm/msm: filter out modes for DP/eDP bridge having unsupported clock

2022-09-08 Thread Abhinav Kumar
On 9/7/2022 6:12 PM, Stephen Boyd wrote: Quoting Abhinav Kumar (2022-08-29 20:33:09) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index bfd0aeff3f0d..8b91d8adf921 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++

Re: [RFC PATCH 2/3] drm/msm: filter out modes for DSI bridge having unsupported clock

2022-09-08 Thread Abhinav Kumar
Hi Stephen On 9/7/2022 6:06 PM, Stephen Boyd wrote: Quoting Abhinav Kumar (2022-08-29 20:33:08) diff --git a/drivers/gpu/drm/msm/dsi/dsi.c b/drivers/gpu/drm/msm/dsi/dsi.c index 39bbabb5daf6..3a06a157d1b1 100644 --- a/drivers/gpu/drm/msm/dsi/dsi.c +++ b/drivers/gpu/drm/msm/dsi/dsi.c @@ -265,6

Re: Rust in our code base

2022-09-08 Thread Karol Herbst
will merge Rusticl tomorrow or so unless somebody complains. On Wed, Aug 24, 2022 at 5:34 PM Karol Herbst wrote: > > On Wed, Aug 24, 2022 at 5:18 PM Jason Ekstrand > wrote: > > > > +mesa-dev and my jlekstrand.net e-mail > > > > On Sun, 2022-08-21 at 20:44 +0200, Karol Herbst wrote: > > > On

[PATCH] drm: remove unnecessary conditionals

2022-09-08 Thread Jingyu Wang
iput() has already handled null and non-null parameter, so it is no need to use if(). Signed-off-by: Jingyu Wang --- drivers/gpu/drm/drm_drv.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c index

Re: [PATCH 1/3] drm/scheduler: track GPU active time per entity

2022-09-08 Thread Andrey Grodzovsky
On 2022-09-08 14:10, Lucas Stach wrote: Track the accumulated time that jobs from this entity were active on the GPU. This allows drivers using the scheduler to trivially implement the DRM fdinfo when the hardware doesn't provide more specific information than signalling job completion

Re: [PATCH 1/4] drm/sched: returns struct drm_gpu_scheduler ** for drm_sched_pick_best

2022-09-08 Thread Andrey Grodzovsky
Please send everything together because otherwise it's not clear why we need this. Andrey On 2022-09-08 11:09, James Zhu wrote: Yes, it is for NPI design. I will send out patches for review soon. Thanks! James On 2022-09-08 11:05 a.m., Andrey Grodzovsky wrote: So this is the real need of

Re: [PATCH] amd/amdkfd: fix repeated words in comments

2022-09-08 Thread Felix Kuehling
On 2022-09-08 09:17, wangjianli wrote: Delete the redundant word 'to'. Signed-off-by: wangjianli Reviewed-by: Felix Kuehling I'll apply this to amd-staging-drm-next. Thanks,   Felix --- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [pull] amdgpu, amdkfd, radeon, drm drm-next-6.1

2022-09-08 Thread Felix Kuehling
On 2022-09-08 12:35, Alex Deucher wrote: On Thu, Sep 8, 2022 at 12:29 PM Felix Kuehling wrote: On 2022-09-08 11:52, Alex Deucher wrote: Hi Dave, Daniel, New stuff for 6.1. The following changes since commit 085292c3d78015412b752ee1ca4c7725fd2bf2fc: Revert "drm/amd/amdgpu: add pipe1

Re: [PATCH v4 07/11] drm/i915/mtl: Add DP AUX support on TypeC ports

2022-09-08 Thread Matt Roper
On Thu, Sep 01, 2022 at 11:03:38PM -0700, Radhakrishna Sripada wrote: > From: Imre Deak > > On MTL TypeC ports the AUX_CH_CTL and AUX_CH_DATA addresses have > changed wrt. previous platforms, adjust the code accordingly. > > Signed-off-by: Imre Deak > Signed-off-by: Radhakrishna Sripada As

Re: [PATCH v4 06/11] drm/i915/mtl: Add display power wells

2022-09-08 Thread Matt Roper
On Thu, Sep 08, 2022 at 11:07:16AM -0700, Matt Roper wrote: > On Thu, Sep 01, 2022 at 11:03:37PM -0700, Radhakrishna Sripada wrote: > > From: Imre Deak > > > > Add support for display power wells on MTL. The differences from XE_LPD: > > - The AUX HW block is moved to the PICA block, where the

[PATCH 2/3] drm/etnaviv: allocate unique ID per drm_file

2022-09-08 Thread Lucas Stach
Allows to easily track if several fd are pointing to the same execution context due to being dup'ed. Signed-off-by: Lucas Stach --- drivers/gpu/drm/etnaviv/etnaviv_drv.c | 3 +++ drivers/gpu/drm/etnaviv/etnaviv_drv.h | 1 + 2 files changed, 4 insertions(+) diff --git

[PATCH 1/3] drm/scheduler: track GPU active time per entity

2022-09-08 Thread Lucas Stach
Track the accumulated time that jobs from this entity were active on the GPU. This allows drivers using the scheduler to trivially implement the DRM fdinfo when the hardware doesn't provide more specific information than signalling job completion anyways. Signed-off-by: Lucas Stach ---

[PATCH 3/3] drm/etnaviv: export client GPU usage statistics via fdinfo

2022-09-08 Thread Lucas Stach
This exposes a accumulated GPU active time per client via the fdinfo infrastructure. Signed-off-by: Lucas Stach --- drivers/gpu/drm/etnaviv/etnaviv_drv.c | 38 ++- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c

Re: [PATCH v4 06/11] drm/i915/mtl: Add display power wells

2022-09-08 Thread Matt Roper
On Thu, Sep 01, 2022 at 11:03:37PM -0700, Radhakrishna Sripada wrote: > From: Imre Deak > > Add support for display power wells on MTL. The differences from XE_LPD: > - The AUX HW block is moved to the PICA block, where the registers are on > an always-on power well and the functionality needs

Re: [RFC PATCH 0/3] Limit pluggable display modes

2022-09-08 Thread Dmitry Baryshkov
On 30/08/2022 06:33, Abhinav Kumar wrote: As reported on https://gitlab.freedesktop.org/drm/msm/-/issues/17, currently there is no mechanism to limit the display output to the pluggable displays and it lets users connect any monitor on any chipset based device. This can lead to undefined

Re: [Intel-gfx] [PATCH v4 05/11] drm/i915/mtl: Add gmbus and gpio support

2022-09-08 Thread Matt Roper
On Thu, Sep 01, 2022 at 11:03:36PM -0700, Radhakrishna Sripada wrote: > Add tables to map the GMBUS pin pairs to GPIO registers and port to DDC. > From spec we have registers GPIO_CTL[1-5] mapped to native display phys and > GPIO_CTL[9-12] are mapped to TC ports. > > v2: > - Drop unused GPIO

Re: [Intel-gfx] [PATCH v4.1] drm/i915/mtl: Define engine context layouts

2022-09-08 Thread Matt Roper
On Wed, Sep 07, 2022 at 04:33:17PM -0700, Radhakrishna Sripada wrote: > From: Matt Roper > > The part of the media and blitter engine contexts that we care about for > setting up an initial state are the same on MTL as they were on DG2 > (and PVC), so we need to update the driver conditions to

Re: [Intel-gfx] [PATCH v4 03/11] drm/i915: Parse and set stepping for platforms with GMD

2022-09-08 Thread Matt Roper
On Thu, Sep 01, 2022 at 11:03:34PM -0700, Radhakrishna Sripada wrote: > From: José Roberto de Souza > > The GMD step field do not properly match the current stepping convention > that we use(STEP_A0, STEP_A1, STEP_B0...). > > One platform could have { arch = 12, rel = 70, step = 1 } and the >

Re: [PATCH v4.1] drm/i915: Move display and media IP version to runtime info

2022-09-08 Thread Matt Roper
On Fri, Sep 02, 2022 at 03:10:54PM -0700, Radhakrishna Sripada wrote: > Future platforms can read the IP version from a register and the > IP version numbers need not be hard coded in device info. Move the > ip version for media and display to runtime info. > > On platforms where hard coding of

Re: Re: Re: [PATCH v4 3/5] arm64: dts: allwinner: h6: Add GPU OPP table

2022-09-08 Thread Jernej Škrabec
Dne četrtek, 08. september 2022 ob 18:26:31 CEST je Jernej Škrabec napisal(a): > Dne torek, 06. september 2022 ob 21:26:34 CEST je Clément Péron napisal(a): > > Hi Jernej, > > > > On Tue, 6 Sept 2022 at 21:10, Jernej Škrabec > > wrote: > > > Dne torek, 06. september 2022 ob 17:30:32 CEST je

Re: [pull] amdgpu, amdkfd, radeon, drm drm-next-6.1

2022-09-08 Thread Alex Deucher
On Thu, Sep 8, 2022 at 12:29 PM Felix Kuehling wrote: > > > On 2022-09-08 11:52, Alex Deucher wrote: > > Hi Dave, Daniel, > > > > New stuff for 6.1. > > > > The following changes since commit 085292c3d78015412b752ee1ca4c7725fd2bf2fc: > > > >Revert "drm/amd/amdgpu: add pipe1 hardware support"

Re: [Intel-gfx] [PATCH] drm/i915: Invert if/else ladder for frequency read

2022-09-08 Thread Lucas De Marchi
On Thu, Sep 08, 2022 at 02:08:55PM +0300, Ville Syrjälä wrote: On Wed, Sep 07, 2022 at 01:30:41PM -0700, Lucas De Marchi wrote: Continue converting the driver to the convention of last version first, extending it to the future platforms. Now, any GRAPHICS_VER >= 11 will be handled by the first

Re: [pull] amdgpu, amdkfd, radeon, drm drm-next-6.1

2022-09-08 Thread Felix Kuehling
On 2022-09-08 11:52, Alex Deucher wrote: Hi Dave, Daniel, New stuff for 6.1. The following changes since commit 085292c3d78015412b752ee1ca4c7725fd2bf2fc: Revert "drm/amd/amdgpu: add pipe1 hardware support" (2022-08-16 18:14:31 -0400) are available in the Git repository at:

Re: [PATCH v4 5/5] arm64: dts: allwinner: beelink-gs1: Enable GPU OPP

2022-09-08 Thread Jernej Škrabec
Dne torek, 06. september 2022 ob 17:30:34 CEST je Clément Péron napisal(a): > Enable GPU OPP table for Beelink GS1. > > Signed-off-by: Clément Péron Acked-by: Jernej Skrabec Best regards, Jernej > --- > arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts | 1 + > 1 file changed, 1

Re: Re: [PATCH v4 3/5] arm64: dts: allwinner: h6: Add GPU OPP table

2022-09-08 Thread Jernej Škrabec
Dne torek, 06. september 2022 ob 21:26:34 CEST je Clément Péron napisal(a): > Hi Jernej, > > On Tue, 6 Sept 2022 at 21:10, Jernej Škrabec wrote: > > Dne torek, 06. september 2022 ob 17:30:32 CEST je Clément Péron napisal(a): > > > Add an Operating Performance Points table for the GPU to > > >

Re: [PATCH v3 12/14] drm/i915/xelpmp: Expose media as another GT

2022-09-08 Thread Iddamsetty, Aravind
On 07-09-2022 05:19, Matt Roper wrote: > Xe_LPM+ platforms have "standalone media." I.e., the media unit is > designed as an additional GT with its own engine list, GuC, forcewake, > etc. Let's allow platforms to include media GTs in their device info. > > v2: > - Simplify GSI register

Re: [PATCH v4 2/5] arm64: dts: allwinner: h6: Add cooling map for GPU

2022-09-08 Thread Jernej Škrabec
Dne torek, 06. september 2022 ob 17:30:31 CEST je Clément Péron napisal(a): > Add a simple cooling map for the GPU. > > This cooling map come from the vendor kernel 4.9 with a > 2°C hysteresis added. > > Signed-off-by: Clément Péron Acked-by: Jernej Skrabec Best regards, Jernej

Re: [PATCH v3 05/14] drm/i915: Prepare more multi-GT initialization

2022-09-08 Thread Iddamsetty, Aravind
On 07-09-2022 05:19, Matt Roper wrote: > We're going to introduce an additional intel_gt for MTL's media unit > soon. Let's provide a bit more multi-GT initialization framework in > preparation for that. The initialization will pull the list of GTs for > a platform from the device info

Re: [PATCH v3] drm/msm/dp: cleared DP_DOWNSPREAD_CTRL register before start link training

2022-09-08 Thread Dmitry Baryshkov
On Thu, 8 Sept 2022 at 18:38, Kuogee Hsieh wrote: > > DOWNSPREAD_CTRL (0x107) shall be cleared to 0 upon power-on reset or an > upstream device disconnect. This patch will enforce this rule by always > cleared DOWNSPREAD_CTRL register to 0 before start link training. At rare > case that DP MSA

Re: [PATCH] drm/i915/gt: Fix perf limit reasons bit positions

2022-09-08 Thread Dixit, Ashutosh
On Thu, 08 Sep 2022 08:58:21 -0700, Ashutosh Dixit wrote: > > Perf limit reasons bit positions were off by one. > > Fixes: fa68bff7cf27 ("drm/i915/gt: Add sysfs throttle frequency interfaces") > Cc: sta...@vger.kernel.org # v5.18+ > Signed-off-by: Ashutosh Dixit > Acked-by: Andi Shyti >

[PATCH] drm/i915/gt: Fix perf limit reasons bit positions

2022-09-08 Thread Ashutosh Dixit
Perf limit reasons bit positions were off by one. Fixes: fa68bff7cf27 ("drm/i915/gt: Add sysfs throttle frequency interfaces") Cc: sta...@vger.kernel.org # v5.18+ Signed-off-by: Ashutosh Dixit Acked-by: Andi Shyti Reviewed-by: Sujaritha Sundaresan --- drivers/gpu/drm/i915/i915_reg.h | 16

[pull] amdgpu, amdkfd, radeon, drm drm-next-6.1

2022-09-08 Thread Alex Deucher
Hi Dave, Daniel, New stuff for 6.1. The following changes since commit 085292c3d78015412b752ee1ca4c7725fd2bf2fc: Revert "drm/amd/amdgpu: add pipe1 hardware support" (2022-08-16 18:14:31 -0400) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git

  1   2   3   >