Re: [PATCH 1/3] drm/i915/gt: Change RC6 residency functions to accept register ID's

2022-10-18 Thread Dixit, Ashutosh
On Mon, 17 Oct 2022 01:27:35 -0700, Jani Nikula wrote: Hi Jani, Thanks for reviewing, great suggestions overall. I have taken care of most of them in series version v6. Please see below. > On Fri, 14 Oct 2022, Ashutosh Dixit wrote: > > @@ -811,9 +809,23 @@ u64 intel_rc6_residency_ns(struct

[PATCH 2/4] drm/i915/mtl: Modify CAGF functions for MTL

2022-10-18 Thread Ashutosh Dixit
From: Badal Nilawar Update CAGF functions for MTL to get actual resolved frequency of 3D and SAMedia. v2: Update MTL_MIRROR_TARGET_WP1 position/formatting (MattR) Move MTL branches in cagf functions to top (MattR) Fix commit message (Andi) v3: Added comment about registers not needing

[PATCH 4/4] drm/i915/mtl: C6 residency and C state type for MTL SAMedia

2022-10-18 Thread Ashutosh Dixit
From: Badal Nilawar Add support for C6 residency and C state type for MTL SAMedia. Also add mtl_drpc. v2: Fixed review comments (Ashutosh) v3: Sort registers and fix whitespace errors in intel_gt_regs.h (Matt R) Remove MTL_CC_SHIFT (Ashutosh) Adapt to RC6 residency register code

[PATCH 0/4] i915: CAGF and RC6 changes for MTL

2022-10-18 Thread Ashutosh Dixit
This series includes the code changes to get CAGF, RC State and C6 Residency of MTL. v3: Included "Use GEN12 RPSTAT register" patch v4: - Rebased - Dropped "Use GEN12 RPSTAT register" patch from this series going to send separate series for it v5: - Included "drm/i915/gt: Change RC6

[PATCH 1/4] drm/i915: Use GEN12_RPSTAT register for GT freq

2022-10-18 Thread Ashutosh Dixit
From: Don Hiatt On GEN12+ use GEN12_RPSTAT register to get actual resolved GT freq. GEN12_RPSTAT does not require a forcewake and will return 0 freq if GT is in RC6. v2: - Fixed review comments(Ashutosh) - Added function intel_rps_read_rpstat_fw to read RPSTAT without forcewake,

[PATCH 3/4] drm/i915/gt: Use RC6 residency types as arguments to residency functions

2022-10-18 Thread Ashutosh Dixit
Previously RC6 residency functions directly accepted RC6 residency register MMIO offsets (there are four RC6 residency registers). This worked but required an assumption on the residency register layout so was not future proof. Therefore change RC6 residency functions to accept RC6 residency

Re: [Intel-gfx] [PATCH v4 15/17] drm/i915/vm_bind: Handle persistent vmas in execbuf3

2022-10-18 Thread Niranjana Vishwanathapura
On Tue, Oct 18, 2022 at 01:20:06PM -0700, Niranjana Vishwanathapura wrote: On Tue, Oct 18, 2022 at 07:01:57PM +0100, Matthew Auld wrote: On 18/10/2022 08:16, Niranjana Vishwanathapura wrote: Handle persistent (VM_BIND) mappings during the request submission in the execbuf3 path. v2: Ensure

Re: [PATCH v4 12/17] drm/i915/vm_bind: Implement I915_GEM_EXECBUFFER3 ioctl

2022-10-18 Thread Niranjana Vishwanathapura
On Tue, Oct 18, 2022 at 06:30:58PM +0100, Matthew Auld wrote: On 18/10/2022 08:16, Niranjana Vishwanathapura wrote: Implement new execbuf3 ioctl (I915_GEM_EXECBUFFER3) which only works in vm_bind mode. The vm_bind mode only works with this new execbuf3 ioctl. The new execbuf3 ioctl will not

Re: [PATCH v2 5/7] drm/i915/mtl: Handle wopcm per-GT and limit calculations.

2022-10-18 Thread Matt Roper
On Tue, Oct 18, 2022 at 05:44:38PM -0700, John Harrison wrote: > On 10/12/2022 17:03, Daniele Ceraolo Spurio wrote: > > From: Aravind Iddamsetty > > ... > > diff --git a/drivers/gpu/drm/i915/intel_wopcm.c > > b/drivers/gpu/drm/i915/gt/intel_wopcm.c > > similarity index 86% > > rename from

Re: [PATCH] drm/amdgpu/discovery: fix possible memory leak

2022-10-18 Thread Luben Tuikov
On 2022-10-18 23:37, Luben Tuikov wrote: > On 2022-10-18 04:05, Yang Yingliang wrote: >> If kset_register() fails, the refcount of device is not 0, the name allocated >> in dev_set_name() is leaked. Fix this by calling kset_put(), so that it will >> be freed in callback function kobject_cleanup().

Re: [PATCH] drm/amdgpu/discovery: fix possible memory leak

2022-10-18 Thread Luben Tuikov
On 2022-10-18 04:05, Yang Yingliang wrote: > If kset_register() fails, the refcount of device is not 0, the name allocated > in dev_set_name() is leaked. Fix this by calling kset_put(), so that it will > be freed in callback function kobject_cleanup(). > Good catch, but looking at the code it

[PATCH v2] drm: mediatek: Modify dpi power on/off sequence.

2022-10-18 Thread xinlei.lee
From: Xinlei Lee Modify dpi power on/off sequence so that the first gpio operation will take effect. Fixes: 6bd4763fd532 ("drm/mediatek: set dpi pin mode to gpio low to avoid leakage current") Signed-off-by: Xinlei Lee --- change note: v1: Rebase on linus/master v6.1-rc1. Change nothing.

[PATCH v12, 3/3] drm: mediatek: Add mt8186 dpi compatibles and platform data

2022-10-18 Thread xinlei.lee
From: Xinlei Lee Add the compatible because use edge_cfg_in_mmsys in mt8186. Signed-off-by: Xinlei Lee Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_dpi.c | 21 + drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 ++ 2 files

[PATCH v12,0/3] Add dpi output format control for MT8186

2022-10-18 Thread xinlei.lee
From: Xinlei Lee Base on the branch of linus/master v6.1 rc1. Change since v11: 1. Rebase on v6.1-rc1. Change nothing. Change since v10: 1. Modify patch title and add review tag. Change since v9: 1. Modify the location of the mmsys_dev member variable. Change since v8: 1. Modified the title

[PATCH v12,2/3] drm: mediatek: Set dpi format in mmsys

2022-10-18 Thread xinlei.lee
From: Xinlei Lee Dpi output needs to adjust the output format to dual edge for MT8186. Co-developed-by: Jitao Shi Signed-off-by: Jitao Shi Signed-off-by: Xinlei Lee Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_dpi.c | 11 +++ 1 file changed, 11 insertions(+) diff --git

[PATCH v12, 1/3] soc: mediatek: Add all settings to mtk_mmsys_ddp_dpi_fmt_config func

2022-10-18 Thread xinlei.lee
From: Xinlei Lee The difference between MT8186 and other ICs is that when modifying the output format, we need to modify the mmsys_base+0x400 register to take effect. So when setting the dpi output format, we need to call mmsys_func to set it to MT8186 synchronously. Adding mmsys all the

Re: [PATCH v2] drm: Remove drm_mode_config::fb_base

2022-10-18 Thread Zack Rusin
On Tue, 2022-10-18 at 23:59 +0300, Andy Shevchenko wrote: > ⚠ External Email > > On Tue, Oct 18, 2022 at 08:26:17PM +, Zack Rusin wrote: > > > On Oct 18, 2022, at 4:20 PM, Andy Shevchenko > > > wrote: > > > On Tue, Oct 18, 2022 at 12:11:51PM -0400, Zack Rusin wrote: > > > > From: Zack Rusin

[PATCH v4] drm: Remove drm_mode_config::fb_base

2022-10-18 Thread Zack Rusin
From: Zack Rusin v4: Fix issue spotted by the kernel test robot The fb_base in struct drm_mode_config has been unused for a long time. Some drivers set it and some don't leading to a very confusing state where the variable can't be relied upon, because there's no indication as to which driver

Re: [PATCH v4 09/17] drm/i915/vm_bind: Add out fence support

2022-10-18 Thread Niranjana Vishwanathapura
On Tue, Oct 18, 2022 at 04:28:07PM +0100, Matthew Auld wrote: On 18/10/2022 08:16, Niranjana Vishwanathapura wrote: Add support for handling out fence for vm_bind call. v2: Reset vma->vm_bind_fence.syncobj to NULL at the end of vm_bind call. v3: Remove vm_unbind out fence uapi which is not

Re: [PATCH v12 5/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

2022-10-18 Thread Liu Ying
/drm-tip linus/master v6.1-rc1 next- > 20221018] [...] > All errors (new ones prefixed by >>): > >drivers/gpu/drm/imx/dpu/dpu-drv.c: In function 'dpu_drm_bind': > > > drivers/gpu/drm/imx/dpu/dpu-drv.c:67:12: error: 'struct > > > drm_device' has

[PATCH v13 6/6] MAINTAINERS: add maintainer for i.MX8qxp DPU DRM driver

2022-10-18 Thread Liu Ying
Add myself as the maintainer of the i.MX8qxp DPU DRM driver. Acked-by: Laurentiu Palcu Signed-off-by: Liu Ying --- v11->v13: * No change. v10->v11: * Rebase upon v6.0-rc1. v9->v10: * Add Laurentiu's A-b tag. v1->v9: * No change. MAINTAINERS | 9 + 1 file changed, 9 insertions(+)

[PATCH v13 4/6] drm/atomic: Avoid unused-but-set-variable warning on for_each_old_plane_in_state

2022-10-18 Thread Liu Ying
Artificially use 'plane' and 'old_plane_state' to avoid 'not used' warning. The precedent has already been set by other macros in the same file. Acked-by: Daniel Vetter Signed-off-by: Liu Ying --- v6->v13: * No change. v5->v6: * Fix commit message typo - s/Artifically/Artificially/ v4->v5: *

[PATCH v13 3/6] dt-bindings: display: imx: Add i.MX8qxp/qm DPR channel binding

2022-10-18 Thread Liu Ying
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Channel. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v10->v13: * No change. v9->v10: * Add Rob's R-b tag. v8->v9: * Reference 'interrupts-extended' schema instead of 'interrupts' to require an additional

[PATCH v13 1/6] dt-bindings: display: imx: Add i.MX8qxp/qm DPU binding

2022-10-18 Thread Liu Ying
This patch adds bindings for i.MX8qxp/qm Display Processing Unit. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v7->v13: * No change. v6->v7: * Add Rob's R-b tag back. v5->v6: * Use graph schema. So, drop Rob's R-b tag as review is needed. v4->v5: * No change. v3->v4: * Improve

[PATCH v13 2/6] dt-bindings: display: imx: Add i.MX8qxp/qm PRG binding

2022-10-18 Thread Liu Ying
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Gasket. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v4->v13: * No change. v3->v4: * Improve compatible property by using enum instead of oneOf+const. (Rob) * Add Rob's R-b tag. v2->v3: * No change. v1->v2: * Use new

[PATCH v13 0/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

2022-10-18 Thread Liu Ying
Hi, This is the v13 series to introduce i.MX8qm/qxp Display Processing Unit(DPU) DRM support. DPU is comprised of a blit engine for 2D graphics, a display controller and a command sequencer. Outside of DPU, optional prefetch engines can fetch data from memory prior to some DPU fetchunits of

Re: [PATCH v2 5/7] drm/i915/mtl: Handle wopcm per-GT and limit calculations.

2022-10-18 Thread John Harrison
On 10/12/2022 17:03, Daniele Ceraolo Spurio wrote: From: Aravind Iddamsetty With MTL standalone media architecture the wopcm layout has changed with separate partitioning in WOPCM for GCD/GT GuC and SA Media GuC. The size What is GCD? of WOPCM is 4MB with lower 2MB for SA Media and upper

Re: [PATCH 0/2] drm/tiny: add support tft display based on ilitek,ili9488

2022-10-18 Thread Noralf Trønnes
Den 18.10.2022 23.28, skrev Michael Nazzareno Trimarchi: > Hi > > On Tue, Oct 18, 2022 at 9:06 PM Noralf Trønnes wrote: >> >> >> >> Den 18.10.2022 18.45, skrev Tommaso Merciai: >>> Hi All, >>> This series support for ilitek,ili9488 based displays like >>> Waveshare-ResTouch-LCD-3.5 display.

Re: [PATCH 1/2] drm/sched: add DRM_SCHED_FENCE_DONT_PIPELINE flag

2022-10-18 Thread Luben Tuikov
On 2022-10-18 11:37, Alex Deucher wrote: > On Tue, Oct 18, 2022 at 11:11 AM Christian König > wrote: >> >> Gentle ping to others to get this reviewed. >> >> Alex, this is fixing the TLB flush errors and I think we need to get it >> into -fixes ASAP. >> >> Christian. >> >> Am 14.10.22 um 10:15

[PATCH] drm/i915/slpc: Optmize waitboost for SLPC

2022-10-18 Thread Vinay Belgaumkar
Waitboost (when SLPC is enabled) results in a H2G message. This can result in thousands of messages during a stress test and fill up an already full CTB. There is no need to request for RP0 if GuC is already requesting the same. Signed-off-by: Vinay Belgaumkar ---

Re: [PATCH] drm/i915/pvc: Update forcewake domain for CCS register ranges

2022-10-18 Thread Chegondi, Harish
On Fri, 2022-10-14 at 16:30 -0700, Matt Roper wrote: > The bspec was just updated with a correction to the forcewake domain > required when accessing registers in the CCS engine ranges (0x1a000 - > 0x1 and 0x26000 - 0x27fff) on PVC; these ranges require a wake on > the RENDER domain, not the

Re: [PATCH v5 20/22] drm/vc4: vec: Convert to the new TV mode property

2022-10-18 Thread Mateusz Kwiatkowski
Hi Maxime, W dniu 18.10.2022 o 12:00, Maxime Ripard pisze: > On Mon, Oct 17, 2022 at 12:31:31PM +0200, Noralf Trønnes wrote: >> Den 16.10.2022 20.52, skrev Mateusz Kwiatkowski: static int vc4_vec_connector_get_modes(struct drm_connector *connector) { - struct drm_connector_state

Re: [PATCH 0/2] drm/tiny: add support tft display based on ilitek, ili9488

2022-10-18 Thread Michael Nazzareno Trimarchi
Hi On Tue, Oct 18, 2022 at 9:06 PM Noralf Trønnes wrote: > > > > Den 18.10.2022 18.45, skrev Tommaso Merciai: > > Hi All, > > This series support for ilitek,ili9488 based displays like > > Waveshare-ResTouch-LCD-3.5 display. Tested on Waveshare-ResTouch-LCD-3.5 > > connected to px30-evb via

Re: [PATCH v2] drm: Remove drm_mode_config::fb_base

2022-10-18 Thread Andy Shevchenko
On Tue, Oct 18, 2022 at 08:26:17PM +, Zack Rusin wrote: > > On Oct 18, 2022, at 4:20 PM, Andy Shevchenko > > wrote: > > On Tue, Oct 18, 2022 at 12:11:51PM -0400, Zack Rusin wrote: > >> From: Zack Rusin > >> > >> v2: Thomas and Laurent noticed that in radeon_fb.c I forgot to set the > >>

Re: [PATCH] drm/vc4: vec: Add support for PAL-60

2022-10-18 Thread Mateusz Kwiatkowski
Hi Maxime, W dniu 18.10.2022 o 10:31, Maxime Ripard pisze: > Hi, > > On Sun, Oct 16, 2022 at 09:46:49PM +0200, Mateusz Kwiatkowski wrote: >> @@ -308,14 +324,15 @@ static const struct vc4_vec_tv_mode vc4_vec_tv_modes[] >> = { >> }; >> >> static inline const struct vc4_vec_tv_mode * >>

Re: [PATCH v2] drm: Remove drm_mode_config::fb_base

2022-10-18 Thread Zack Rusin
> On Oct 18, 2022, at 4:20 PM, Andy Shevchenko > wrote: > > ⚠ External Email > > On Tue, Oct 18, 2022 at 12:11:51PM -0400, Zack Rusin wrote: >> From: Zack Rusin >> >> v2: Thomas and Laurent noticed that in radeon_fb.c I forgot to set the >> info->apertures->ranges[0].base and Laurent

Re: [PATCH v2 3/7] drm/i915/uc: use different ggtt pin offsets for uc loads

2022-10-18 Thread Ceraolo Spurio, Daniele
On 10/17/2022 4:44 PM, John Harrison wrote: On 10/12/2022 17:03, Daniele Ceraolo Spurio wrote: Our current FW loading process is the same for all FWs: - Pin FW to GGTT at the start of the ggtt->uc_fw node - Load the FW - Unpin This worked because we didn't have a case where 2 FWs would be

Re: [PATCH v2] drm: Remove drm_mode_config::fb_base

2022-10-18 Thread Andy Shevchenko
On Tue, Oct 18, 2022 at 12:11:51PM -0400, Zack Rusin wrote: > From: Zack Rusin > > v2: Thomas and Laurent noticed that in radeon_fb.c I forgot to set the > info->apertures->ranges[0].base and Laurent noticed a neat little cleanup > in the hisilicon driver as a result of the

Re: [PATCH v4 15/17] drm/i915/vm_bind: Handle persistent vmas in execbuf3

2022-10-18 Thread Niranjana Vishwanathapura
On Tue, Oct 18, 2022 at 07:01:57PM +0100, Matthew Auld wrote: On 18/10/2022 08:16, Niranjana Vishwanathapura wrote: Handle persistent (VM_BIND) mappings during the request submission in the execbuf3 path. v2: Ensure requests wait for bindings to complete. v3: Remove short term pinning with

Re: [PATCH 0/2] drm/tiny: add support tft display based on ilitek,ili9488

2022-10-18 Thread Noralf Trønnes
Den 18.10.2022 18.45, skrev Tommaso Merciai: > Hi All, > This series support for ilitek,ili9488 based displays like > Waveshare-ResTouch-LCD-3.5 display. Tested on Waveshare-ResTouch-LCD-3.5 > connected to px30-evb via SPI. There's a generic MIPI DBI SPI driver now that should work with all

Re: [PATCH] drm/edid: Parse VRR cap fields from HFVSDB block

2022-10-18 Thread Navare, Manasi
On Tue, Oct 18, 2022 at 11:01:48AM +0530, Ankit Nautiyal wrote: > This patch parses HFVSDB fields for VRR capabilities of an > HDMI2.1 sink and stores the VRR caps in a new structure in > drm_hdmi_info. > > Signed-off-by: Ankit Nautiyal Makes sense to add this VRR info to drm_hdmi_info struct

[PATCH v3] drm/i915/slpc: Use platform limits for min/max frequency

2022-10-18 Thread Vinay Belgaumkar
GuC will set the min/max frequencies to theoretical max on ATS-M. This will break kernel ABI, so limit min/max frequency to RP0(platform max) instead. Also modify the SLPC selftest to update the min frequency when we have a server part so that we can iterate between platform min and max. v2:

[PATCH v3] drm: Remove drm_mode_config::fb_base

2022-10-18 Thread Zack Rusin
From: Zack Rusin v3: Fix a silly pci_resource_len mistake spotted by Laurent The fb_base in struct drm_mode_config has been unused for a long time. Some drivers set it and some don't leading to a very confusing state where the variable can't be relied upon, because there's no indication as to

Re: [PATCH 2/2] drm/tiny: add support for tft displays based on ilitek, ili9488

2022-10-18 Thread Michael Nazzareno Trimarchi
Hi On Tue, Oct 18, 2022 at 6:46 PM Tommaso Merciai wrote: > > This adds support for ilitek,ili9488 based displays with shift register > in front of controller. Waveshare,pico-restouch-lcd-3.5 are such displays > > Signed-off-by: Tommaso Merciai > --- Because I start to make it working this

Re: [PATCH 1/2] dt-bindings: add binding for tft displays based on ilitek,ili9488

2022-10-18 Thread Krzysztof Kozlowski
On 18/10/2022 12:45, Tommaso Merciai wrote: > This binding is for the tft displays based on ilitek,ili9488. > waveshare,waveshare,pico-rt-lcd-35 (waveshare pico-restouch-lcd-3.5) > > Signed-off-by: Tommaso Merciai > --- > .../bindings/display/ilitek,ili9488.yaml | 72 +++ >

Re: [PATCH v2] drm_bridge: register content protect property

2022-10-18 Thread Sean Paul
On Mon, Oct 17, 2022 at 9:49 AM Hsin-Yi Wang wrote: > > On Wed, Oct 12, 2022 at 12:20 PM Hsin-Yi Wang wrote: > > > > Some bridges are able to update HDCP status from userspace request if > > they support HDCP. > > > > HDCP property is the same as other connector properties that need to be > >

[PATCH] drm: rcar_du: DRM_RCAR_DU optionally depends on RCAR_MIPI_DSI

2022-10-18 Thread Randy Dunlap
When CONFIG_DRM_RCAR_DU=y and CONFIG_DRM_RCAR_MIPI_DSI=m, calls from the builtin driver to the mipi driver fail due to linker errors. Since the RCAR_MIPI_DSI driver is not always required, fix the build error by making DRM_RCAR_DU optionally depend on the RCAR_MIPI_DSI Kconfig symbol. This

Re: [PATCH v4 15/17] drm/i915/vm_bind: Handle persistent vmas in execbuf3

2022-10-18 Thread Matthew Auld
On 18/10/2022 08:16, Niranjana Vishwanathapura wrote: Handle persistent (VM_BIND) mappings during the request submission in the execbuf3 path. v2: Ensure requests wait for bindings to complete. v3: Remove short term pinning with PIN_VALIDATE flag. Individualize fences before adding to

Re: [PATCH v4 12/17] drm/i915/vm_bind: Implement I915_GEM_EXECBUFFER3 ioctl

2022-10-18 Thread Matthew Auld
On 18/10/2022 08:16, Niranjana Vishwanathapura wrote: Implement new execbuf3 ioctl (I915_GEM_EXECBUFFER3) which only works in vm_bind mode. The vm_bind mode only works with this new execbuf3 ioctl. The new execbuf3 ioctl will not have any list of objects to validate bind as all required objects

[PATCH v4] drm/sched: Fix kernel NULL pointer dereference error

2022-10-18 Thread Arvind Yadav
-This is purely a timing issue. Here, sometimes Job free is happening before the job is done. To fix this issue moving 'dma_fence_cb' callback from job(struct drm_sched_job) to scheduler fence (struct drm_sched_fence). -Added drm_sched_fence_set_parent() and drm_sched_fence_clear_parent()

Re: [PATCH V2 3/4] drm/panel: Add prepare_upstream_first flag to drm_panel

2022-10-18 Thread Dave Stevenson
Hi Jagan On Mon, 17 Oct 2022 at 03:44, Jagan Teki wrote: > > Hi Dave, > > On Fri, Oct 7, 2022 at 6:26 PM Dave Stevenson > wrote: > > > > Hi Jagan > > > > On Thu, 6 Oct 2022 at 15:25, Jagan Teki wrote: > > > > > > On Fri, Mar 4, 2022 at 8:48 PM Dave Stevenson > > > wrote: > > > > > > > >

Re: [PATCH v4 17/17] drm/i915/vm_bind: Add uapi for user to enable vm_bind_mode

2022-10-18 Thread Niranjana Vishwanathapura
On Tue, Oct 18, 2022 at 05:03:16PM +0100, Matthew Auld wrote: On 18/10/2022 08:16, Niranjana Vishwanathapura wrote: Add getparam support for VM_BIND capability version. Add VM creation time flag to enable vm_bind_mode for the VM. v2: update kernel-doc v3: create vm->root_obj only upon

[PATCH 2/2] drm/tiny: add support for tft displays based on ilitek, ili9488

2022-10-18 Thread Tommaso Merciai
This adds support for ilitek,ili9488 based displays with shift register in front of controller. Waveshare,pico-restouch-lcd-3.5 are such displays Signed-off-by: Tommaso Merciai --- drivers/gpu/drm/tiny/Kconfig | 13 + drivers/gpu/drm/tiny/Makefile | 1 + drivers/gpu/drm/tiny/ili9488.c |

[PATCH 1/2] dt-bindings: add binding for tft displays based on ilitek, ili9488

2022-10-18 Thread Tommaso Merciai
This binding is for the tft displays based on ilitek,ili9488. waveshare,waveshare,pico-rt-lcd-35 (waveshare pico-restouch-lcd-3.5) Signed-off-by: Tommaso Merciai --- .../bindings/display/ilitek,ili9488.yaml | 72 +++ 1 file changed, 72 insertions(+) create mode 100644

[PATCH 0/2] drm/tiny: add support tft display based on ilitek, ili9488

2022-10-18 Thread Tommaso Merciai
Hi All, This series support for ilitek,ili9488 based displays like Waveshare-ResTouch-LCD-3.5 display. Tested on Waveshare-ResTouch-LCD-3.5 connected to px30-evb via SPI. This series is based on work done by Kamlesh Gurudasani in 2020: - "drm/tiny: add support for tft displays based on ilitek,

Re: [PATCH v2] drm: Remove drm_mode_config::fb_base

2022-10-18 Thread Zack Rusin
On Tue, 2022-10-18 at 19:28 +0300, Laurent Pinchart wrote: > > @@ -271,7 +260,8 @@ static int hibmc_load(struct drm_device *dev) > >    if (ret) > >    goto err; > > > > - ret = drmm_vram_helper_init(dev, pci_resource_start(pdev, 0), priv- > > >fb_size); > > + ret =

Re: [PATCH v2] drm: Remove drm_mode_config::fb_base

2022-10-18 Thread Laurent Pinchart
Hi Zack, Thank you for the patch. On Tue, Oct 18, 2022 at 12:11:51PM -0400, Zack Rusin wrote: > From: Zack Rusin > > v2: Thomas and Laurent noticed that in radeon_fb.c I forgot to set the > info->apertures->ranges[0].base and Laurent noticed a neat little cleanup > in the hisilicon driver as a

[PATCH v2] drm: Remove drm_mode_config::fb_base

2022-10-18 Thread Zack Rusin
From: Zack Rusin v2: Thomas and Laurent noticed that in radeon_fb.c I forgot to set the info->apertures->ranges[0].base and Laurent noticed a neat little cleanup in the hisilicon driver as a result of the drm_mode_config::fb_base removal. The fb_base in struct drm_mode_config has been unused

Re: [PATCH v4 17/17] drm/i915/vm_bind: Add uapi for user to enable vm_bind_mode

2022-10-18 Thread Matthew Auld
On 18/10/2022 08:16, Niranjana Vishwanathapura wrote: Add getparam support for VM_BIND capability version. Add VM creation time flag to enable vm_bind_mode for the VM. v2: update kernel-doc v3: create vm->root_obj only upon I915_VM_CREATE_FLAGS_USE_VM_BIND v4: replace vm->vm_bind_mode check

Re: [PATCH] drm/amdgpu/powerplay/psm: Fix memory leak in power state init

2022-10-18 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Oct 17, 2022 at 9:07 PM Quan, Evan wrote: > > [AMD Official Use Only - General] > > Reviewed-by: Evan Quan > > > -Original Message- > > From: Rafael Mendonca > > Sent: Tuesday, October 18, 2022 8:54 AM > > To: Quan, Evan ; Deucher, Alexander > > ;

Re: [PATCH] drm: Remove drm_mode_config::fb_base

2022-10-18 Thread Zack Rusin
On Tue, 2022-10-18 at 16:05 +0200, Thomas Zimmermann wrote: > Hi > > Am 18.10.22 um 15:17 schrieb Zack Rusin: > > From: Zack Rusin > > > > The fb_base in struct drm_mode_config has been unused for a long time. > > Some drivers set it and some don't leading to a very confusing state > > where

Re: [PATCH 1/2] drm/sched: add DRM_SCHED_FENCE_DONT_PIPELINE flag

2022-10-18 Thread Alex Deucher
On Tue, Oct 18, 2022 at 11:11 AM Christian König wrote: > > Gentle ping to others to get this reviewed. > > Alex, this is fixing the TLB flush errors and I think we need to get it > into -fixes ASAP. > > Christian. > > Am 14.10.22 um 10:15 schrieb Christian König: > > Setting this flag on a

Re: [PATCH v2 4/7] drm/simpledrm: Add support for system memory framebuffers

2022-10-18 Thread Rob Herring
On Tue, Oct 18, 2022 at 5:47 AM Thierry Reding wrote: > > On Mon, Oct 17, 2022 at 01:15:59PM -0500, Rob Herring wrote: > > On Mon, Oct 17, 2022 at 9:54 AM Thierry Reding > > wrote: > > > > > > On Mon, Oct 10, 2022 at 10:12:34AM +0200, Thomas Zimmermann wrote: > > > > Hi > > > > > > > > Am

Re: [PATCH v4 09/17] drm/i915/vm_bind: Add out fence support

2022-10-18 Thread Matthew Auld
On 18/10/2022 08:16, Niranjana Vishwanathapura wrote: Add support for handling out fence for vm_bind call. v2: Reset vma->vm_bind_fence.syncobj to NULL at the end of vm_bind call. v3: Remove vm_unbind out fence uapi which is not supported yet. Signed-off-by: Niranjana Vishwanathapura

Re: [PATCH] drm: Remove drm_mode_config::fb_base

2022-10-18 Thread Laurent Pinchart
Hi Zack, Thank you for the patch. On Tue, Oct 18, 2022 at 09:17:45AM -0400, Zack Rusin wrote: > From: Zack Rusin > > The fb_base in struct drm_mode_config has been unused for a long time. > Some drivers set it and some don't leading to a very confusing state > where the variable can't be

Re: [PATCH v2 4/7] drm/simpledrm: Add support for system memory framebuffers

2022-10-18 Thread Thierry Reding
On Tue, Oct 18, 2022 at 01:58:53PM +0200, Thomas Zimmermann wrote: > Hi Thierry > > Am 17.10.22 um 16:54 schrieb Thierry Reding: > > On Mon, Oct 10, 2022 at 10:12:34AM +0200, Thomas Zimmermann wrote: > [...] > > > > > > That whole 'Memory Manangement' block is will be unmaintainable. Before I >

Re: [PATCH 1/2] drm/sched: add DRM_SCHED_FENCE_DONT_PIPELINE flag

2022-10-18 Thread Christian König
Gentle ping to others to get this reviewed. Alex, this is fixing the TLB flush errors and I think we need to get it into -fixes ASAP. Christian. Am 14.10.22 um 10:15 schrieb Christian König: Setting this flag on a scheduler fence prevents pipelining of jobs depending on this fence. In other

Re: [PATCH v2 0/2] drm/rockchip: dw_hdmi: Add 4k@30 support

2022-10-18 Thread Dan Johansen
Den 05.10.2022 kl. 13.10 skrev Sascha Hauer: On Wed, Oct 05, 2022 at 12:51:57PM +0200, Dan Johansen wrote: Den 05.10.2022 kl. 12.06 skrev Sascha Hauer: On Wed, Sep 28, 2022 at 10:39:27AM +0200, Dan Johansen wrote: Den 28.09.2022 kl. 10.37 skrev Sascha Hauer: On Tue, Sep 27, 2022 at

Re: logging:convert dev_info to drm_info

2022-10-18 Thread Thomas Zimmermann
Hi Am 18.10.22 um 09:20 schrieb jianengchencool: Hi, I want to convert logging dev_info/warn/err to drm_info/warn/err  in drivers/gpu/drm/pl111, so I want to ask if this work will be merged? Thanks! Well, just send the patches for review. Best regards Thomas TODO list below:

Re: [PATCH] drm: Remove drm_mode_config::fb_base

2022-10-18 Thread Christian König
Am 18.10.22 um 15:17 schrieb Zack Rusin: From: Zack Rusin The fb_base in struct drm_mode_config has been unused for a long time. Some drivers set it and some don't leading to a very confusing state where the variable can't be relied upon, because there's no indication as to which driver sets

Re: [PATCH v2] drm/mgag200: Fix PLL setup for G200_SE_A rev >=4

2022-10-18 Thread Jocelyn Falempe
I just pushed it to drm-misc-next. I also fixed the commit message a bit, the commit moving this line of code is in fact: commit 877507bb954e ("drm/mgag200: Provide per-device callbacks for PIXPLLC") Best Regards -- Jocelyn On 13/10/2022 15:55, Thomas Zimmermann wrote: Am 13.10.22 um

Re: [Intel-gfx] [PATCH v3 09/17] drm/i915/vm_bind: Add out fence support

2022-10-18 Thread Matthew Auld
On 14/10/2022 07:48, Niranjana Vishwanathapura wrote: On Sun, Oct 09, 2022 at 11:58:18PM -0700, Niranjana Vishwanathapura wrote: Add support for handling out fence for vm_bind call. v2: Reset vma->vm_bind_fence.syncobj to NULL at the end    of vm_bind call. Signed-off-by: Niranjana

Re: i915 "GPU HANG", bisected to a2daa27c0c61 "swiotlb: simplify swiotlb_max_segment"

2022-10-18 Thread Juergen Gross
On 18.10.22 16:33, Christoph Hellwig wrote: On Tue, Oct 18, 2022 at 04:21:43PM +0200, Jan Beulich wrote: Leaving the "i915 abuses" part aside (because I can't tell what exactly the abuse is), but assuming that "can't cope with bounce buffering" means they don't actually use the allocated

Re: i915 "GPU HANG", bisected to a2daa27c0c61 "swiotlb: simplify swiotlb_max_segment"

2022-10-18 Thread Jan Beulich
On 18.10.2022 13:02, Christoph Hellwig wrote: > On Tue, Oct 18, 2022 at 10:57:37AM +0200, Jan Beulich wrote: >> Shouldn't this then be xen_pv_domain() that you use here, and - if you >> really want IS_ENABLED() in addition - CONFIG_XEN_PV? > > I'll need help from people that understand Xen better

Re: [PATCH] drm: Remove drm_mode_config::fb_base

2022-10-18 Thread Thomas Zimmermann
Hi Am 18.10.22 um 15:17 schrieb Zack Rusin: From: Zack Rusin The fb_base in struct drm_mode_config has been unused for a long time. Some drivers set it and some don't leading to a very confusing state where the variable can't be relied upon, because there's no indication as to which driver

Re: Build regressions/improvements in v6.1-rc1

2022-10-18 Thread Maciej W. Rozycki
Hi Geert, > > > .> [1] > > > http://kisskb.ellerman.id.au/kisskb/branch/linus/head/9abf2313adc1ca1b6180c508c25f22f9395cc780/ > > > (all 149 configs) > > > > > + {standard input}: Error: branch to a symbol in another ISA mode: > > > > 1339 => > > > > 2616, 2621 > > > > > >

[PATCH] drm: Remove drm_mode_config::fb_base

2022-10-18 Thread Zack Rusin
From: Zack Rusin The fb_base in struct drm_mode_config has been unused for a long time. Some drivers set it and some don't leading to a very confusing state where the variable can't be relied upon, because there's no indication as to which driver sets it and which doesn't. The only usage of

Re: [PATCH v7 00/21] Move all drivers to a common dma-buf locking convention

2022-10-18 Thread Dmitry Osipenko
On 10/18/22 14:34, Christian König wrote: > Am 18.10.22 um 01:07 schrieb Dmitry Osipenko: >> On 10/17/22 20:22, Dmitry Osipenko wrote: >>> Hello, >>> >>> This series moves all drivers to a dynamic dma-buf locking >>> specification. >>>  From now on all dma-buf importers are made responsible for

Re: [PATCH v3] drm/sched: Fix kernel NULL pointer dereference error

2022-10-18 Thread Christian König
Am 18.10.22 um 14:20 schrieb Yadav, Arvind: [SNIP] +    drm_sched_fence_finished(s_fence); +    dma_fence_put(_fence->finished); +    wake_up_interruptible(>wake_up_worker); +} + +int drm_sched_fence_add_parent_cb(struct dma_fence *fence, +  struct drm_sched_fence *s_fence)

Re: Build regressions/improvements in v6.1-rc1

2022-10-18 Thread Geert Uytterhoeven
Hi Maciej, On Tue, Oct 18, 2022 at 12:39 PM Maciej W. Rozycki wrote: > On Mon, 17 Oct 2022, Geert Uytterhoeven wrote: > > .> [1] > > http://kisskb.ellerman.id.au/kisskb/branch/linus/head/9abf2313adc1ca1b6180c508c25f22f9395cc780/ > > (all 149 configs) > > > + {standard input}: Error: branch

Re: [PATCH v5 12/22] drm/connector: Add a function to lookup a TV mode by its name

2022-10-18 Thread Noralf Trønnes
Den 18.10.2022 11.33, skrev Maxime Ripard: > On Mon, Oct 17, 2022 at 12:44:45PM +0200, Noralf Trønnes wrote: >> Den 13.10.2022 15.18, skrev Maxime Ripard: >>> As part of the command line parsing rework coming in the next patches, >>> we'll need to lookup drm_connector_tv_mode values by their

Re: [PATCH v3] drm/sched: Fix kernel NULL pointer dereference error

2022-10-18 Thread Yadav, Arvind
On 10/17/2022 8:20 PM, Christian König wrote: Am 17.10.22 um 16:30 schrieb Arvind Yadav: -This is purely a timing issue. Here, sometimes Job free is happening before the job is done. To fix this issue moving 'dma_fence_cb' callback from job(struct drm_sched_job) to scheduler fence (struct

Re: [PATCH v2 4/7] drm/simpledrm: Add support for system memory framebuffers

2022-10-18 Thread Thomas Zimmermann
Hi Thierry Am 17.10.22 um 16:54 schrieb Thierry Reding: On Mon, Oct 10, 2022 at 10:12:34AM +0200, Thomas Zimmermann wrote: [...] That whole 'Memory Manangement' block is will be unmaintainable. Before I go into a detailed review, please see my questions about the reservedmem code at the end

Re: [PATCH v2] drm/panel/panel-sitronix-st7701: Fix RTNI calculation

2022-10-18 Thread Linus Walleij
On Tue, Oct 18, 2022 at 12:01 PM Marek Vasut wrote: > On 10/18/22 11:13, Linus Walleij wrote: > > I've been told to go and poke the DRM git people at IRC to rebase > > the fixes branch. > > That would be #dri-devel on OFTC I think ? Yups, I pinged and mlankhorst says he will fix it. Yours,

Re: [PATCH v7 00/21] Move all drivers to a common dma-buf locking convention

2022-10-18 Thread Christian König
Am 18.10.22 um 01:07 schrieb Dmitry Osipenko: On 10/17/22 20:22, Dmitry Osipenko wrote: Hello, This series moves all drivers to a dynamic dma-buf locking specification. From now on all dma-buf importers are made responsible for holding dma-buf's reservation lock around all operations

Re: [PATCH 1/2] Revert "drm: hide unregistered connectors from GETCONNECTOR IOCTL"

2022-10-18 Thread Ville Syrjälä
On Tue, Oct 18, 2022 at 12:07:43PM +0200, Jonas Ådahl wrote: > On Tue, Oct 18, 2022 at 12:58:53PM +0300, Ville Syrjälä wrote: > > On Tue, Oct 18, 2022 at 11:27:19AM +0200, Jonas Ådahl wrote: > > > On Tue, Oct 18, 2022 at 12:14:09PM +0300, Ville Syrjälä wrote: > > > > On Mon, Oct 17, 2022 at

Re: Build regressions/improvements in v6.1-rc1

2022-10-18 Thread Maciej W. Rozycki
On Mon, 17 Oct 2022, Geert Uytterhoeven wrote: > > + {standard input}: Error: branch to a symbol in another ISA mode: 1339 => > > 2616, 2621 > > mips-gcc11/micro32r2_defconfig > mips-gcc11/micro32r2el_defconfig Where can these configs be obtained from? Maciej

Re: [PATCH v2 4/7] drm/simpledrm: Add support for system memory framebuffers

2022-10-18 Thread Thierry Reding
On Mon, Oct 17, 2022 at 01:15:59PM -0500, Rob Herring wrote: > On Mon, Oct 17, 2022 at 9:54 AM Thierry Reding > wrote: > > > > On Mon, Oct 10, 2022 at 10:12:34AM +0200, Thomas Zimmermann wrote: > > > Hi > > > > > > Am 07.10.22 um 14:49 schrieb Thierry Reding: > > > > From: Thierry Reding > > >

Re: [PATCH] drm/mipi-dsi: fix possible memory leak in mipi_dsi_device_register_full()

2022-10-18 Thread Thierry Reding
On Tue, Oct 18, 2022 at 04:25:45PM +0800, Yang Yingliang wrote: > If mipi_dsi_device_add() fails, the refcount of device is not 0, the name > allocated in dev_set_name() is leaked. Fix this by calling put_device(), > so that it will be freed in callback function kobject_cleanup(). > > Fixes:

Re: [PATCH 1/2] Revert "drm: hide unregistered connectors from GETCONNECTOR IOCTL"

2022-10-18 Thread Jonas Ådahl
On Tue, Oct 18, 2022 at 12:58:53PM +0300, Ville Syrjälä wrote: > On Tue, Oct 18, 2022 at 11:27:19AM +0200, Jonas Ådahl wrote: > > On Tue, Oct 18, 2022 at 12:14:09PM +0300, Ville Syrjälä wrote: > > > On Mon, Oct 17, 2022 at 03:31:57PM +, Simon Ser wrote: > > > > This reverts commit

Re: [PATCH v2] drm/panel/panel-sitronix-st7701: Fix RTNI calculation

2022-10-18 Thread Marek Vasut
On 10/18/22 11:13, Linus Walleij wrote: On Tue, Oct 18, 2022 at 11:03 AM Marek Vasut wrote: On 10/18/22 10:53, Linus Walleij wrote: On Thu, Oct 13, 2022 at 12:12 AM Marek Vasut wrote: The RTNI field is multiplied by 16 and incremented by 512 before being used as the minimum number of pixel

Re: [PATCH v5 20/22] drm/vc4: vec: Convert to the new TV mode property

2022-10-18 Thread Maxime Ripard
On Mon, Oct 17, 2022 at 12:31:31PM +0200, Noralf Trønnes wrote: > Den 16.10.2022 20.52, skrev Mateusz Kwiatkowski: > >> static int vc4_vec_connector_get_modes(struct drm_connector *connector) > >> { > >> - struct drm_connector_state *state = connector->state; > >>struct drm_display_mode

Re: [PATCH 1/2] Revert "drm: hide unregistered connectors from GETCONNECTOR IOCTL"

2022-10-18 Thread Ville Syrjälä
On Tue, Oct 18, 2022 at 11:27:19AM +0200, Jonas Ådahl wrote: > On Tue, Oct 18, 2022 at 12:14:09PM +0300, Ville Syrjälä wrote: > > On Mon, Oct 17, 2022 at 03:31:57PM +, Simon Ser wrote: > > > This reverts commit 981f09295687f856d5345e19c7084aca481c1395. > > > > > > It turns out this breaks

Re: [PATCH v5 12/22] drm/connector: Add a function to lookup a TV mode by its name

2022-10-18 Thread Maxime Ripard
On Mon, Oct 17, 2022 at 12:44:45PM +0200, Noralf Trønnes wrote: > Den 13.10.2022 15.18, skrev Maxime Ripard: > > As part of the command line parsing rework coming in the next patches, > > we'll need to lookup drm_connector_tv_mode values by their name, already > > defined in drm_tv_mode_enum_list.

Re: [PATCH 1/2] Revert "drm: hide unregistered connectors from GETCONNECTOR IOCTL"

2022-10-18 Thread Jonas Ådahl
On Tue, Oct 18, 2022 at 12:14:09PM +0300, Ville Syrjälä wrote: > On Mon, Oct 17, 2022 at 03:31:57PM +, Simon Ser wrote: > > This reverts commit 981f09295687f856d5345e19c7084aca481c1395. > > > > It turns out this breaks Mutter. > > A bit more detail would be a good to help future

Re: [PATCH 2/2] drm/connector: send hotplug uevent on connector cleanup

2022-10-18 Thread Simon Ser
On Tuesday, October 18th, 2022 at 11:24, Ville Syrjälä wrote: > On Mon, Oct 17, 2022 at 03:32:01PM +, Simon Ser wrote: > > > A typical DP-MST unplug removes a KMS connector. However care must > > be taken to properly synchronize with user-space. The expected > > sequence of events is the

Re: [PATCH 2/2] drm/connector: send hotplug uevent on connector cleanup

2022-10-18 Thread Ville Syrjälä
On Mon, Oct 17, 2022 at 03:32:01PM +, Simon Ser wrote: > A typical DP-MST unplug removes a KMS connector. However care must > be taken to properly synchronize with user-space. The expected > sequence of events is the following: > > 1. The kernel notices that the DP-MST port is gone. > 2. The

Re: [PATCH 1/2] Revert "drm: hide unregistered connectors from GETCONNECTOR IOCTL"

2022-10-18 Thread Ville Syrjälä
On Mon, Oct 17, 2022 at 03:31:57PM +, Simon Ser wrote: > This reverts commit 981f09295687f856d5345e19c7084aca481c1395. > > It turns out this breaks Mutter. A bit more detail would be a good to help future archaeologists. > > Signed-off-by: Simon Ser > Cc: Daniel Vetter > Cc: Lyude Paul

Re: [PATCH v2] drm/panel/panel-sitronix-st7701: Fix RTNI calculation

2022-10-18 Thread Linus Walleij
On Tue, Oct 18, 2022 at 11:03 AM Marek Vasut wrote: > On 10/18/22 10:53, Linus Walleij wrote: > > On Thu, Oct 13, 2022 at 12:12 AM Marek Vasut wrote: > > > >> The RTNI field is multiplied by 16 and incremented by 512 before being > >> used as the minimum number of pixel clock per horizontal

[PATCH v3] dma-buf: Proactively round up to kmalloc bucket size

2022-10-18 Thread Kees Cook
Instead of discovering the kmalloc bucket size _after_ allocation, round up proactively so the allocation is explicitly made for the full size, allowing the compiler to correctly reason about the resulting size of the buffer through the existing __alloc_size() hint. Cc: Sumit Semwal Cc:

  1   2   >