Re: [PATCH v2] video: fbdev: smscufx: Fixed several use-after-free bugs

2022-10-20 Thread Helge Deller
On 10/21/22 03:15, Hyunwoo Kim wrote: Several types of UAFs can occur when physically removing a USB device. Adds ufx_ops_destroy() function to .fb_destroy of fb_ops, and in this function, there is kref_put() that finally calls ufx_free(). This fix prevents multiple UAFs. Signed-off-by:

Re: [PATCH 2/2] drm/msm: move domain allocation into msm_iommu_new()

2022-10-20 Thread kernel test robot
Hi Dmitry, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on linus/master v6.1-rc1 next-20221020] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [PATCH v5 10/10] gna: add open and close operations on GNA device

2022-10-20 Thread Greg Kroah-Hartman
On Thu, Oct 20, 2022 at 07:53:34PM +0200, Maciej Kwapulinski wrote: > From: Tomasz Jankowski > > Signed-off-by: Tomasz Jankowski > Tested-by: Mikolaj Grzybowski > Co-developed-by: Jianxun Zhang > Signed-off-by: Jianxun Zhang > Co-developed-by: Maciej Kwapulinski > Signed-off-by: Maciej

Re: [PATCH v5 02/10] gna: add GNA DRM device

2022-10-20 Thread Greg Kroah-Hartman
On Thu, Oct 20, 2022 at 07:53:26PM +0200, Maciej Kwapulinski wrote: > Signed-off-by: Maciej Kwapulinski > Tested-by: Mikolaj Grzybowski Obviously we can not take patches without any changelog text at all. And neither would you want us to. Again, would you want to review this patch? thanks,

Re: [PATCH v5 08/10] gna: add GNA_WAIT ioctl

2022-10-20 Thread Greg Kroah-Hartman
On Thu, Oct 20, 2022 at 07:53:32PM +0200, Maciej Kwapulinski wrote: > From: Tomasz Jankowski > > Although the patch adds GNA_WAIT ioctl, it's main purpose is to provide FIFO > work-queue logic, which offloads each score operation in sequence to GNA > accelerator. When it's done, process(es)

Re: [PATCH v5 05/10] gna: add GNA_GET_PARAMETER ioctl

2022-10-20 Thread Greg Kroah-Hartman
On Thu, Oct 20, 2022 at 07:53:29PM +0200, Maciej Kwapulinski wrote: > From: Tomasz Jankowski > > As this is first ioctl in the series, the patch also adds common bits for > remaining ioctls Again, please read the documentation for what to do here, this is not helpful at all. > +int

Re: [PATCH v5 03/10] gna: read hardware info

2022-10-20 Thread Greg Kroah-Hartman
On Thu, Oct 20, 2022 at 07:53:27PM +0200, Maciej Kwapulinski wrote: > From: Tomasz Jankowski > > Get the hardware information from register MMIO_IBUFFS Please read our documentation for how to write good changelog texts. This tiny line says nothing about why we would want this patch at all.

Re: [PATCH v5 01/10] gna: add PCI driver module

2022-10-20 Thread Greg Kroah-Hartman
On Thu, Oct 20, 2022 at 07:53:25PM +0200, Maciej Kwapulinski wrote: > Add a new PCI driver for Intel(R) Gaussian & Neural Accelerator Please drop all of the (R) stuff in here, and in the Kconfig file and in the .c files. If your lawyers insist on it, please point them at me and I will be glad to

Re: [PATCH v5 00/10] Driver of Intel(R) Gaussian & Neural Accelerator

2022-10-20 Thread Greg Kroah-Hartman
On Thu, Oct 20, 2022 at 07:53:24PM +0200, Maciej Kwapulinski wrote: > Dear kernel maintainers, This really is v6, not v5, right? Why send 2 v5 out? greg k-h

Re: [PATCH v5 01/10] gna: add PCI driver module

2022-10-20 Thread Bagas Sanjaya
On Thu, Oct 20, 2022 at 07:53:25PM +0200, Maciej Kwapulinski wrote: > +IOCTL > +- > +Intel(R) GNA driver controls the device through IOCTL interfaces. > +Following IOCTL commands - handled by DRM framework - are supported: > + > +GNA_GET_PARAMETER gets driver and device capabilities. > + >

[PATCH v3 01/17] drm/vmwgfx: Write the driver id registers

2022-10-20 Thread Zack Rusin
From: Zack Rusin Driver id registers are a new mechanism in the svga device to hint to the device which driver is running. This should not change device behavior in any way, but might be convenient to work-around specific bugs in guest drivers. Signed-off-by: Zack Rusin Reviewed-by: Martin

[PATCH v3 11/17] drm/vmwgfx: Remove vmwgfx_hashtab

2022-10-20 Thread Zack Rusin
From: Maaz Mombasawala The vmwgfx driver has migrated from using the hashtable in vmwgfx_hashtab to the linux/hashtable implementation. Remove the vmwgfx_hashtab from the driver. Signed-off-by: Maaz Mombasawala Reviewed-by: Martin Krastev Reviewed-by: Zack Rusin Signed-off-by: Zack Rusin

[PATCH v3 16/17] drm/vmwgfx: Optimize initial sizes of cotables

2022-10-20 Thread Zack Rusin
From: Zack Rusin It's important to get the initial size of cotables right because otherwise every app needs to start with a synchronous cotable resize. This has an measurable impact on system wide performance but is not relevant for long running single full screen apps for which the cotable

[PATCH v3 12/17] drm/vmwgfx: Do not allow invalid bpp's for dumb buffers

2022-10-20 Thread Zack Rusin
From: Zack Rusin Dumb buffers allow a very limited set of formats. Basically everything apart from 1, 2 and 4 is expected to return an error. Make vmwgfx follow those guidelines. This fixes igt's dumb_buffer invalid_bpp test on vmwgfx. Signed-off-by: Zack Rusin Reviewed-by: Martin Krastev

[PATCH v3 14/17] drm/vmwgfx: Remove explicit and broken vblank handling

2022-10-20 Thread Zack Rusin
From: Zack Rusin The explicit vblank handling was never finished. The driver never had the full implementation of vblank and what was there is emulated by DRM when the driver doesn't pretend to be implementing it itself. Let DRM handle the vblank emulation and stop pretending the driver is

[PATCH v3 04/17] drm/vmwgfx: Remove ttm object hashtable

2022-10-20 Thread Zack Rusin
From: Maaz Mombasawala The object_hash hashtable for ttm objects is not being used. Remove it and perform refactoring in ttm_object init function. Signed-off-by: Maaz Mombasawala Reviewed-by: Zack Rusin Reviewed-by: Martin Krastev Signed-off-by: Zack Rusin ---

[PATCH v3 08/17] drm/vmwgfx: Support cursor surfaces with mob cursor

2022-10-20 Thread Zack Rusin
From: Michael Banack Add support for cursor surfaces when using mob cursors. Signed-off-by: Michael Banack Signed-off-by: Zack Rusin --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 78 ++--- drivers/gpu/drm/vmwgfx/vmwgfx_kms.h | 1 + 2 files changed, 50 insertions(+), 29

[PATCH v3 10/17] drm/vmwgfx: Refactor ttm reference object hashtable to use linux/hashtable.

2022-10-20 Thread Zack Rusin
From: Maaz Mombasawala This is part of an effort to move from the vmwgfx_open_hash hashtable to linux/hashtable implementation. Refactor the ref_hash hashtable, used for fast lookup of reference objects associated with a ttm file. This also exposed a problem related to inconsistently using

[PATCH v3 06/17] drm/vmwgfx: Clean up cursor mobs

2022-10-20 Thread Zack Rusin
From: Michael Banack Clean up the cursor mob path by moving ownership of the mobs into the plane_state, and just leaving a cache of unused mobs in the plane itself. Signed-off-by: Michael Banack Signed-off-by: Zack Rusin --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 441

[PATCH v3 07/17] drm/vmwgfx: Start diffing new mob cursors against old ones

2022-10-20 Thread Zack Rusin
From: Michael Banack Avoid making the SVGA device do extra work if the new cursor image matches the old one. Signed-off-by: Michael Banack Signed-off-by: Zack Rusin --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 95 ++--- drivers/gpu/drm/vmwgfx/vmwgfx_kms.h | 12 ++-- 2

[PATCH v3 05/17] drm/vmwgfx: Refactor resource validation hashtable to use linux/hashtable implementation.

2022-10-20 Thread Zack Rusin
From: Maaz Mombasawala Vmwgfx's hashtab implementation needs to be replaced with linux/hashtable to reduce maintenence burden. As part of this effort, refactor the res_ht hashtable used for resource validation during execbuf execution to use linux/hashtable implementation. This also refactors

[PATCH v3 15/17] drm/vmwgfx: Add a mksstat counter for cotable resizes

2022-10-20 Thread Zack Rusin
From: Zack Rusin There's been a lot of cotable resizes on startup which we can track by adding a mks stat to measure both the invocation count and time spent doing cotable resizes. This is only used if kernel is configured with CONFIG_DRM_VMWGFX_MKSSTATS The stats are collected on the host size

[PATCH v3 09/17] drm/vmwgfx: Diff cursors when using cmds

2022-10-20 Thread Zack Rusin
From: Michael Banack Extend the cursor diffing support to support the command-path. Signed-off-by: Michael Banack Signed-off-by: Zack Rusin --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 120 ++-- drivers/gpu/drm/vmwgfx/vmwgfx_kms.h | 2 + 2 files changed, 62

[PATCH v3 17/17] drm/vmwgfx: Fix a sparse warning in kernel docs

2022-10-20 Thread Zack Rusin
From: Zack Rusin Fixes a warning about extra docs about a function argument that has been removed a while back: drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:3888: warning: Excess function parameter 'sync_file' description in 'vmw_execbuf_copy_fence_user' Fixes: a0f90c881570 ("drm/vmwgfx: Fix stale

[PATCH v3 13/17] drm/vmwgfx: Port the framebuffer code to drm fb helpers

2022-10-20 Thread Zack Rusin
From: Zack Rusin Instead of using vmwgfx specific framebuffer implementation use the drm fb helpers. There's no change in functionality, the only difference is a reduction in the amount of code inside the vmwgfx module. drm fb helpers do not deal correctly with changes in crtc preferred mode at

[PATCH v3 03/17] drm/vmwgfx: Refactor resource manager's hashtable to use linux/hashtable implementation.

2022-10-20 Thread Zack Rusin
From: Maaz Mombasawala Vmwgfx's hashtab implementation needs to be replaced with linux/hashtable to reduce maintenance burden. Refactor cmdbuf resource manager to use linux/hashtable.h implementation as part of this effort. Signed-off-by: Maaz Mombasawala Reviewed-by: Zack Rusin Reviewed-by:

[PATCH v3 02/17] drm/vmwgfx: Fix frame-size warning in vmw_mksstat_add_ioctl

2022-10-20 Thread Zack Rusin
From: Martin Krastev Function vmw_mksstat_add_ioctl allocates three big arrays on stack. That triggers frame-size [-Wframe-larger-than=] warning. Refactor that function to use kmalloc_array instead. Signed-off-by: Martin Krastev Reviewed-by: Zack Rusin Reviewed-by: Maaz Mombasawala

[PATCH v3 00/17] drm/vmwgfx: fb, cursors and hashtable refactor

2022-10-20 Thread Zack Rusin
From: Zack Rusin v3: Add improvements suggested by Thomas for the fb port change and add a commit that fixes a sparse kernel doc warning This is a bit larger series than usual but these are all connected in various ways. The most important changes around everything is centered include: -

[PATCH] drm/panel-edp: Add INX N116BGE-EA2 (HW: C4)

2022-10-20 Thread Sean Hong
Add support for the INX - N116BGE-EA2 (HW: C4) panel. Signed-off-by: Sean Hong --- drivers/gpu/drm/panel/panel-edp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c index 4b39d1dd9140..82c81622a169 100644 ---

[PATCH] drm/panel-edp: Add INX N116BGE-EA2 (HW: C2)

2022-10-20 Thread Sean Hong
Add support for the INX - N116BGE-EA2 (HW: C2) panel. Signed-off-by: Sean Hong --- drivers/gpu/drm/panel/panel-edp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c index 4b39d1dd9140..724b27a53299 100644 ---

Re: [git pull] drm fixes for 6.1-rc2

2022-10-20 Thread pr-tracker-bot
The pull request you sent on Fri, 21 Oct 2022 10:37:33 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2022-10-21 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/e35184f321518acadb681928a016da21a9a20c13 Thank you! -- Deet-doot-dot, I am a bot.

[PATCH v2] video: fbdev: smscufx: Fixed several use-after-free bugs

2022-10-20 Thread Hyunwoo Kim
Several types of UAFs can occur when physically removing a USB device. Adds ufx_ops_destroy() function to .fb_destroy of fb_ops, and in this function, there is kref_put() that finally calls ufx_free(). This fix prevents multiple UAFs. Signed-off-by: Hyunwoo Kim Link:

Re: linux-next: build failure after merge of the drm-misc tree

2022-10-20 Thread Zack Rusin
ntroduced by commit > > 7c99616e3fe7 ("drm: Remove drm_mode_config::fb_base") > > I have used the drm-misc tree from next-20221020 for today. > Hi, Stephen. I've just sent out a trivial fix for this. I'm not sure how the bots and I missed it. Thanks for letting me know! z

[PATCH] drm/nouveau: Remove unused variable

2022-10-20 Thread Zack Rusin
From: Zack Rusin Trivial removal of an unused variable. Not sure how it snuck by me and build bots in the 7c99616e3fe7. Fixes: 7c99616e3fe7 ("drm: Remove drm_mode_config::fb_base") Reported-by: Stephen Rothwell Cc: Laurent Pinchart Cc: Thomas Zimmermann Cc: Christian König Cc: Ben Skeggs

[git pull] drm fixes for 6.1-rc2

2022-10-20 Thread Dave Airlie
Hey Linus, Usual fixes for the week. The amdgpu contains fixes for two regressions, one reported in response to rc1 which broke on SI GPUs, and one gfx9 APU regression. Otherwise it's mostly fixes for new IP, and some GPU reset fixes. vc4 is just HDMI fixes, and panfrost has some mnor types

linux-next: build failure after merge of the drm-misc tree

2022-10-20 Thread Stephen Rothwell
] 662 | struct nvkm_device *device = nvxx_device(>client.device); | ^~ cc1: all warnings being treated as errors Introduced by commit 7c99616e3fe7 ("drm: Remove drm_mode_config::fb_base") I have used the drm-misc tree from next-20221

Re: [Intel-gfx] Random submitter change in Freedesktop Patchwork

2022-10-20 Thread Lucas De Marchi
On Thu, Oct 20, 2022 at 07:20:56PM +0300, Ville Syrjälä wrote: On Thu, Oct 20, 2022 at 07:07:22PM +0300, Jani Nikula wrote: On Thu, 20 Oct 2022, "Dixit, Ashutosh" wrote: > The freedesktop Patchwork seems to have a "feature" where in some cases the > submitter for a series changes randomly to a

Re: [Intel-gfx] [PATCH v3] drm/i915/slpc: Optmize waitboost for SLPC

2022-10-20 Thread Dixit, Ashutosh
On Thu, 20 Oct 2022 13:16:00 -0700, Belgaumkar, Vinay wrote: > > On 10/20/2022 11:33 AM, Dixit, Ashutosh wrote: > > On Wed, 19 Oct 2022 17:29:44 -0700, Vinay Belgaumkar wrote: > > Hi Vinay, > > > >> Waitboost (when SLPC is enabled) results in a H2G message. This can result > >> in thousands of

Re: [PATCH v2 5/7] drm/i915/mtl: Handle wopcm per-GT and limit calculations.

2022-10-20 Thread Ceraolo Spurio, Daniele
On 10/18/2022 5:44 PM, John Harrison wrote: On 10/12/2022 17:03, Daniele Ceraolo Spurio wrote: From: Aravind Iddamsetty With MTL standalone media architecture the wopcm layout has changed with separate partitioning in WOPCM for GCD/GT GuC and SA Media GuC. The size What is GCD? of WOPCM

Re: [PATCH] mm/memremap: Introduce pgmap_request_folio() using pgmap offsets

2022-10-20 Thread Dan Williams
Felix Kuehling wrote: > Am 2022-10-20 um 17:56 schrieb Dan Williams: > > A 'struct dev_pagemap' (pgmap) represents a collection of ZONE_DEVICE > > pages. The pgmap is a reference counted object that serves a similar > > role as a 'struct request_queue'. Live references are obtained for each > > in

Re: [Intel-gfx] [PATCH v3] drm/i915/slpc: Use platform limits for min/max frequency

2022-10-20 Thread Dixit, Ashutosh
On Tue, 18 Oct 2022 11:30:31 -0700, Vinay Belgaumkar wrote: > Hi Vinay, > diff --git a/drivers/gpu/drm/i915/gt/selftest_slpc.c > b/drivers/gpu/drm/i915/gt/selftest_slpc.c > index 4c6e9257e593..e42bc215e54d 100644 > --- a/drivers/gpu/drm/i915/gt/selftest_slpc.c > +++

Re: [PATCH] mm/memremap: Introduce pgmap_request_folio() using pgmap offsets

2022-10-20 Thread Felix Kuehling
Am 2022-10-20 um 17:56 schrieb Dan Williams: A 'struct dev_pagemap' (pgmap) represents a collection of ZONE_DEVICE pages. The pgmap is a reference counted object that serves a similar role as a 'struct request_queue'. Live references are obtained for each in flight request / page, and once a

[PATCH] drm/amd/display: Remove duplicate code for DCN314 DML calculation

2022-10-20 Thread Rafael Mendonca
This is an extension of commit fd3bc691fc7b ("drm/amd/display: Remove duplicate code across dcn30 and dcn31"), which removed duplicate code for the function CalculateBytePerPixelAnd256BBlockSizes() across dcn30 and dcn31. At the time the aforementioned commit was introduced, support for DCN 3.1.4

[Bug 216119] 087451f372bf76d breaks hibernation on amdgpu Radeon R9 390

2022-10-20 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216119 --- Comment #45 from Harald Judt (h.j...@gmx.at) --- Thanks for the new patches. Applying attachment 303055 and https://patchwork.kernel.org/project/dri-devel/patch/20221020103755.24058-2-tzimmerm...@suse.de/ on linux-5.19.16 did seem to have an

[PATCH] mm/memremap: Introduce pgmap_request_folio() using pgmap offsets

2022-10-20 Thread Dan Williams
A 'struct dev_pagemap' (pgmap) represents a collection of ZONE_DEVICE pages. The pgmap is a reference counted object that serves a similar role as a 'struct request_queue'. Live references are obtained for each in flight request / page, and once a page's reference count drops to zero the

[PATCH v1] drm: Switch drm_client_buffer_delete() to unlocked drm_gem_vunmap

2022-10-20 Thread Dmitry Osipenko
The drm_client_buffer_delete() wasn't switched to unlocked GEM vunmapping by accident when rest of drm_client code transitioned to the unlocked variants of the vmapping functions. Make drm_client_buffer_delete() use the unlocked variant. This fixes lockdep warning splat about missing reservation

Re: [Intel-gfx] [PATCH v4 16/17] drm/i915/vm_bind: userptr dma-resv changes

2022-10-20 Thread Niranjana Vishwanathapura
On Thu, Oct 20, 2022 at 12:05:39PM -0700, Niranjana Vishwanathapura wrote: On Thu, Oct 20, 2022 at 04:27:38PM +0200, Andi Shyti wrote: Hi Niranjana, [...] @@ -307,6 +307,8 @@ struct i915_vma { struct list_head non_priv_vm_bind_link; /* @vm_rebind_link: link to vm_rebind_list

IMX6 etnaviv issue

2022-10-20 Thread Tim Harvey
Greetings, I use a standard Ubuntu 20.04 focal rootfs with a mainline kernel on an IMX6Q based board and have had no issues using things like gnome desktop, glxgears, glmark2 however recently I updated the rootfs to Ubuntu 22.04 jammy using the same mainline kernel and now I see some issues. I've

[PATCH] drm/qxl: remove variable num_relocs

2022-10-20 Thread Colin Ian King
The variable num_relocs is being incremented but it is never referenced, it is redundant and can be removed. Signed-off-by: Colin Ian King --- drivers/gpu/drm/qxl/qxl_ioctl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_ioctl.c

Re: [drm/gem] 79e2cf2e7a: WARNING:at_drivers/gpu/drm/drm_gem.c:#drm_gem_vunmap

2022-10-20 Thread Dmitry Osipenko
On 10/20/22 06:38, Dmitry Osipenko wrote: > On 10/20/22 06:23, kernel test robot wrote: >> Greeting, >> >> FYI, we noticed WARNING:at_drivers/gpu/drm/drm_gem.c:#drm_gem_vunmap due to >> commit (built with clang-14): >> >> commit: 79e2cf2e7a193473dfb0da3b9b869682b43dc60f ("drm/gem: Take

Re: [Intel-gfx] [PATCH v3] drm/i915/slpc: Optmize waitboost for SLPC

2022-10-20 Thread Belgaumkar, Vinay
On 10/20/2022 11:33 AM, Dixit, Ashutosh wrote: On Wed, 19 Oct 2022 17:29:44 -0700, Vinay Belgaumkar wrote: Hi Vinay, Waitboost (when SLPC is enabled) results in a H2G message. This can result in thousands of messages during a stress test and fill up an already full CTB. There is no need to

Re: Question about patch "fbdev: smscufx: Fix use-after-free in ufx_ops_open()"

2022-10-20 Thread Hyunwoo Kim
Dear, An additional patch has been submitted for the disconnect->open race condition you reported: https://lore.kernel.org/linux-fbdev/20221020200113.GA320044@ubuntu/T/#u Thanks for reporting. Regards, Hyunwoo Kim.

[PATCH] video: fbdev: smscufx: Fixed several use-after-free bugs

2022-10-20 Thread Hyunwoo Kim
Several types of UAFs can occur when physically removing a USB device. Adds ufx_ops_destroy() function to .fb_destroy of fb_ops, and in this function, there is kref_put() that finally calls ufx_free(). This fix prevents multiple UAFs. Signed-off-by: Hyunwoo Kim Link:

[PATCH 2/2] drm/msm: move domain allocation into msm_iommu_new()

2022-10-20 Thread Dmitry Baryshkov
After the msm_iommu instance is created, the IOMMU domain is completely handled inside the msm_iommu code. Move the iommu_domain_alloc() call into the msm_iommu_new() to simplify callers code. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c| 7 ---

[PATCH 1/2] drm/msm: remove duplicated code from a6xx_create_address_space

2022-10-20 Thread Dmitry Baryshkov
The function a6xx_create_address_space() is mostly a copy of adreno_iommu_create_address_space() with added quirk setting. Reuse the original function to do the work, while introducing the wrapper to set the quirk. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 31

[PATCH 0/2] drm/msm: clean up iommu interface a bit

2022-10-20 Thread Dmitry Baryshkov
This series started as an attempt to rework the drivers usage of IOMMU domains. While the idea ended up to be wrong, these two provide a sensibly looking cleanup. Dmitry Baryshkov (2): drm/msm: remove duplicated code from a6xx_create_address_space drm/msm: move domain allocation into

[Bug 216119] 087451f372bf76d breaks hibernation on amdgpu Radeon R9 390

2022-10-20 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216119 --- Comment #44 from Alex Deucher (alexdeuc...@gmail.com) --- Created attachment 303064 --> https://bugzilla.kernel.org/attachment.cgi?id=303064=edit another fix You'll probably want this patch too. -- You may reply to this email to add a

Re: [PATCH v5 00/10] Driver of Intel(R) Gaussian & Neural Accelerator

2022-10-20 Thread Andy Shevchenko
On Thu, Oct 20, 2022 at 8:57 PM Maciej Kwapulinski wrote: > > Dear kernel maintainers, > > This submission is a kernel driver to support Intel(R) Gaussian & Neural > Accelerator (Intel(R) GNA). Intel(R) GNA is a PCI-based neural co-processor > available on multiple Intel platforms. AI developers

Re: [PATCH v5 06/10] gna: add GNA_GEM_NEW and GNA_GEM_FREE ioctls

2022-10-20 Thread Andy Shevchenko
On Thu, Oct 20, 2022 at 8:57 PM Maciej Kwapulinski wrote: > > drm_gem_shmem_object is base for memory objects provided by the patch Here and in some other commit messages don't forget English punctuation, like trailing period. ... > +struct gna_gem_object { > + struct

Re: [PATCH v4 16/17] drm/i915/vm_bind: userptr dma-resv changes

2022-10-20 Thread Niranjana Vishwanathapura
On Thu, Oct 20, 2022 at 04:27:38PM +0200, Andi Shyti wrote: Hi Niranjana, [...] @@ -307,6 +307,8 @@ struct i915_vma { struct list_head non_priv_vm_bind_link; /* @vm_rebind_link: link to vm_rebind_list and protected by vm_rebind_lock */ struct list_head vm_rebind_link;

Re: [PATCH v5 04/10] gna: initialize MMU

2022-10-20 Thread Andy Shevchenko
On Thu, Oct 20, 2022 at 10:00 PM Andy Shevchenko wrote: > On Thu, Oct 20, 2022 at 8:57 PM Maciej Kwapulinski > wrote: ... > > + desc_size = round_up(gna_priv->info.desc_info.desc_size, PAGE_SIZE); > > PFN_UP() ? Or PFN_ALIGN() ? -- With Best Regards, Andy Shevchenko

Re: [PATCH v5 04/10] gna: initialize MMU

2022-10-20 Thread Andy Shevchenko
On Thu, Oct 20, 2022 at 8:57 PM Maciej Kwapulinski wrote: > > From: Tomasz Jankowski > > Setup MMU in the driver with a new memory component. ... > +#define GNA_FEATURES \ > + .max_hw_mem = 256 * 1024 * 1024,\ SZ_256M ?

Re: [PATCH v5 02/10] gna: add GNA DRM device

2022-10-20 Thread Andy Shevchenko
On Thu, Oct 20, 2022 at 8:57 PM Maciej Kwapulinski wrote: Missed commit message. > Signed-off-by: Maciej Kwapulinski > Tested-by: Mikolaj Grzybowski ... > + if (!(sizeof(dma_addr_t) > 4) || Do you really need this? > + dma_set_mask(parent, DMA_BIT_MASK(64))) { > +

Re: [PATCH v5 01/10] gna: add PCI driver module

2022-10-20 Thread Andy Shevchenko
On Thu, Oct 20, 2022 at 8:57 PM Maciej Kwapulinski wrote: > > Add a new PCI driver for Intel(R) Gaussian & Neural Accelerator > with basic support like module loading and unloading. The full > function of the driver will be added by further changes. ... > +GNA_GEM_NEW acquires new 4KB page

Re: [PATCH v2 13/16] drm/vmwgfx: Port the framebuffer code to drm fb helpers

2022-10-20 Thread Zack Rusin
On Thu, 2022-10-20 at 11:06 +0200, Thomas Zimmermann wrote: > Hi Zack > > Am 20.10.22 um 05:41 schrieb Zack Rusin: > > From: Zack Rusin > [...] > > @@ -1670,6 +1640,10 @@ static int vmw_probe(struct pci_dev *pdev, const > > struct pci_device_id *ent) > > if (ret) > > goto

Re: [Intel-gfx] [PATCH v3] drm/i915/slpc: Optmize waitboost for SLPC

2022-10-20 Thread Dixit, Ashutosh
On Wed, 19 Oct 2022 17:29:44 -0700, Vinay Belgaumkar wrote: > Hi Vinay, > Waitboost (when SLPC is enabled) results in a H2G message. This can result > in thousands of messages during a stress test and fill up an already full > CTB. There is no need to request for RP0 if GuC is already requesting

[PATCH] drm/rockchip: fix fbdev on non-IOMMU devices

2022-10-20 Thread John Keeping
When switching to the generic fbdev infrastructure, it was missed that framebuffers were created with the alloc_kmap parameter to rockchip_gem_create_object() set to true. The generic infrastructure calls this via the .dumb_create() driver operation and thus creates a buffer without an associated

Re: [PATCH v4 01/10] gna: add PCI driver module

2022-10-20 Thread Greg Kroah-Hartman
On Thu, Oct 20, 2022 at 06:11:49PM +0200, Maciej Kwapulinski wrote: > > On 10/20/2022 4:32 PM, Greg Kroah-Hartman wrote: > > On Thu, Oct 20, 2022 at 03:35:16PM +0200, Kwapulinski, Maciej wrote: > >> Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego > >> adresata i moze zawierac

Re: [PATCH] drm/i915/selftests: Stop using kthread_stop()

2022-10-20 Thread Tvrtko Ursulin
On 20/10/2022 15:18, Ville Syrjälä wrote: On Thu, Oct 20, 2022 at 02:08:41PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Since a7c01fa93aeb ("signal: break out of wait loops on kthread_stop()") kthread_stop() started asserting a pending signal which wreaks havoc with a few of our

Re: [PATCH v4 13/17] drm/i915/vm_bind: Update i915_vma_verify_bind_complete()

2022-10-20 Thread Matthew Auld
On 20/10/2022 17:51, Niranjana Vishwanathapura wrote: On Thu, Oct 20, 2022 at 10:16:06AM +0100, Matthew Auld wrote: On 19/10/2022 19:28, Niranjana Vishwanathapura wrote: On Wed, Oct 19, 2022 at 05:07:31PM +0100, Matthew Auld wrote: On 18/10/2022 08:16, Niranjana Vishwanathapura wrote: Ensure

Re: [PATCH v4 15/17] drm/i915/vm_bind: Handle persistent vmas in execbuf3

2022-10-20 Thread Niranjana Vishwanathapura
On Thu, Oct 20, 2022 at 05:39:46PM +0100, Matthew Auld wrote: On 18/10/2022 08:16, Niranjana Vishwanathapura wrote: Handle persistent (VM_BIND) mappings during the request submission in the execbuf3 path. v2: Ensure requests wait for bindings to complete. v3: Remove short term pinning with

Re: [PATCH v4 13/17] drm/i915/vm_bind: Update i915_vma_verify_bind_complete()

2022-10-20 Thread Niranjana Vishwanathapura
On Thu, Oct 20, 2022 at 10:16:06AM +0100, Matthew Auld wrote: On 19/10/2022 19:28, Niranjana Vishwanathapura wrote: On Wed, Oct 19, 2022 at 05:07:31PM +0100, Matthew Auld wrote: On 18/10/2022 08:16, Niranjana Vishwanathapura wrote: Ensure i915_vma_verify_bind_complete() handles case where

Re: [PATCH] drm/amdkfd: use vma_lookup() instead of find_vma()

2022-10-20 Thread Felix Kuehling
Am 2022-10-20 um 04:20 schrieb Deming Wang: Using vma_lookup() verifies the start address is contained in the found vma. This results in easier to read the code. Signed-off-by: Deming Wang Thank you. This patch is Reviewed-by: Felix Kuehling I squashed it with your earlier patch in

Re: [PATCH] drm/amdkfd: use vma_lookup() instead of find_vma()

2022-10-20 Thread Felix Kuehling
Am 2022-10-06 um 22:26 schrieb Deming Wang: Using vma_lookup() verifies the start address is contained in the found vma. This results in easier to read the code. Signed-off-by: Deming Wang --- drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 8 1 file changed, 4 insertions(+), 4

Re: [PATCH v12,3/3] drm: mediatek: Add mt8186 dpi compatibles and platform data

2022-10-20 Thread Nícolas F . R . A . Prado
On Wed, Oct 19, 2022 at 10:52:16AM +0800, xinlei@mediatek.com wrote: > From: Xinlei Lee > > Add the compatible because use edge_cfg_in_mmsys in mt8186. I think the commit message could be improved: Add support for mt8186. It needs its own mtk_dpi_conf data since edge_cfg_in_mmsys is set to

Re: [PATCH v12,2/3] drm: mediatek: Set dpi format in mmsys

2022-10-20 Thread Nícolas F . R . A . Prado
On Wed, Oct 19, 2022 at 10:52:15AM +0800, xinlei@mediatek.com wrote: [..] > @@ -134,6 +137,7 @@ struct mtk_dpi_yc_limit { > * @yuv422_en_bit: Enable bit of yuv422. > * @csc_enable_bit: Enable bit of CSC. > * @pixels_per_iter: Quantity of transferred pixels per iteration. > + *

Re: [PATCH v4 15/17] drm/i915/vm_bind: Handle persistent vmas in execbuf3

2022-10-20 Thread Matthew Auld
On 18/10/2022 08:16, Niranjana Vishwanathapura wrote: Handle persistent (VM_BIND) mappings during the request submission in the execbuf3 path. v2: Ensure requests wait for bindings to complete. v3: Remove short term pinning with PIN_VALIDATE flag. Individualize fences before adding to

Re: [PATCH v4 16/17] drm/i915/vm_bind: userptr dma-resv changes

2022-10-20 Thread Niranjana Vishwanathapura
On Thu, Oct 20, 2022 at 05:29:45PM +0100, Matthew Auld wrote: On 18/10/2022 08:16, Niranjana Vishwanathapura wrote: For persistent (vm_bind) vmas of userptr BOs, handle the user page pinning by using the i915_gem_object_userptr_submit_init() /done() functions v2: Do not double add vma to

Re: [PATCH v4 15/17] drm/i915/vm_bind: Handle persistent vmas in execbuf3

2022-10-20 Thread Matthew Auld
On 18/10/2022 08:16, Niranjana Vishwanathapura wrote: Handle persistent (VM_BIND) mappings during the request submission in the execbuf3 path. v2: Ensure requests wait for bindings to complete. v3: Remove short term pinning with PIN_VALIDATE flag. Individualize fences before adding to

Re: [PATCH v12,1/3] soc: mediatek: Add all settings to mtk_mmsys_ddp_dpi_fmt_config func

2022-10-20 Thread Nícolas F . R . A . Prado
Hi, On Wed, Oct 19, 2022 at 10:52:14AM +0800, xinlei@mediatek.com wrote: > From: Xinlei Lee > > The difference between MT8186 and other ICs is that when modifying the > output format, we need to modify the mmsys_base+0x400 register to take > effect. > So when setting the dpi output format,

Re: [PATCH v4 16/17] drm/i915/vm_bind: userptr dma-resv changes

2022-10-20 Thread Matthew Auld
On 18/10/2022 08:16, Niranjana Vishwanathapura wrote: For persistent (vm_bind) vmas of userptr BOs, handle the user page pinning by using the i915_gem_object_userptr_submit_init() /done() functions v2: Do not double add vma to vm->userptr_invalidated_list Signed-off-by: Niranjana

Re: [Intel-gfx] Random submitter change in Freedesktop Patchwork

2022-10-20 Thread Ville Syrjälä
On Thu, Oct 20, 2022 at 07:07:22PM +0300, Jani Nikula wrote: > On Thu, 20 Oct 2022, "Dixit, Ashutosh" wrote: > > The freedesktop Patchwork seems to have a "feature" where in some cases the > > submitter for a series changes randomly to a person who did not actually > > submit a version of the

Re: [PATCH v7 0/9] dyndbg: drm.debug adaptation

2022-10-20 Thread Ville Syrjälä
On Sat, Sep 24, 2022 at 03:02:34PM +0200, Greg KH wrote: > On Sun, Sep 11, 2022 at 11:28:43PM -0600, Jim Cromie wrote: > > hi Greg, Dan, Jason, DRM-folk, > > > > heres follow-up to V6: > > rebased on driver-core/driver-core-next for -v6 applied bits (thanks) > > rework

Re: Random submitter change in Freedesktop Patchwork

2022-10-20 Thread Jani Nikula
On Thu, 20 Oct 2022, "Dixit, Ashutosh" wrote: > The freedesktop Patchwork seems to have a "feature" where in some cases the > submitter for a series changes randomly to a person who did not actually > submit a version of the series. > > Not sure but this changed submitter seems to be a

Random submitter change in Freedesktop Patchwork

2022-10-20 Thread Dixit, Ashutosh
The freedesktop Patchwork seems to have a "feature" where in some cases the submitter for a series changes randomly to a person who did not actually submit a version of the series. Not sure but this changed submitter seems to be a maintainer:

Re: [PATCH] drm/vc4: vec: Add support for PAL-60

2022-10-20 Thread maxime
On Tue, Oct 18, 2022 at 10:57:04PM +0200, Mateusz Kwiatkowski wrote: > Hi Maxime, > > W dniu 18.10.2022 o 10:31, Maxime Ripard pisze: > > Hi, > > > > On Sun, Oct 16, 2022 at 09:46:49PM +0200, Mateusz Kwiatkowski wrote: > >> @@ -308,14 +324,15 @@ static const struct vc4_vec_tv_mode > >>

Re: [PATCH 2/3] drm/prime: set the dma_coherent flag for export

2022-10-20 Thread Christian König
Am 20.10.22 um 16:43 schrieb Rob Clark: On Thu, Oct 20, 2022 at 5:13 AM Christian König wrote: When a device driver is snooping the CPU cache during access we assume that all importers need to be able to snoop the CPU cache as well. Signed-off-by: Christian König ---

Re: [PATCH 2/3] drm/prime: set the dma_coherent flag for export

2022-10-20 Thread Rob Clark
On Thu, Oct 20, 2022 at 5:13 AM Christian König wrote: > > When a device driver is snooping the CPU cache during access we assume > that all importers need to be able to snoop the CPU cache as well. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/drm_prime.c | 2 ++ > 1 file changed,

[PATCH] drm/amdgpu: don't call drm_fb_helper_lastclose in lastclose()

2022-10-20 Thread Alex Deucher
It's used to restore the fbdev console, but as amdgpu uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the call to drm_client_dev_restore() in drm_lastclose(). Fixes: 087451f372bf76 ("drm/amdgpu: use generic fb helpers instead of setting up AMD

Re: [PATCH v4 01/10] gna: add PCI driver module

2022-10-20 Thread Greg Kroah-Hartman
On Thu, Oct 20, 2022 at 03:35:16PM +0200, Kwapulinski, Maciej wrote: > Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i > moze zawierac informacje poufne. W razie przypadkowego otrzymania tej > wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; >

Re: [PATCH v4 16/17] drm/i915/vm_bind: userptr dma-resv changes

2022-10-20 Thread Andi Shyti
Hi Niranjana, [...] > @@ -307,6 +307,8 @@ struct i915_vma { > struct list_head non_priv_vm_bind_link; > /* @vm_rebind_link: link to vm_rebind_list and protected by > vm_rebind_lock */ > struct list_head vm_rebind_link; /* Link in vm_rebind_list */ > +

[PATCH v2] gpu: host1x: Avoid trying to use GART on Tegra20

2022-10-20 Thread Robin Murphy
Since commit c7e3ca515e78 ("iommu/tegra: gart: Do not register with bus") quite some time ago, the GART driver has effectively disabled itself to avoid issues with the GPU driver expecting it to work in ways that it doesn't. As of commit 57365a04c921 ("iommu: Move bus setup to IOMMU device

Re: [PATCH] dt-bindings: Remove "status" from schema examples, again

2022-10-20 Thread Rob Herring
On Fri, 14 Oct 2022 15:51:04 -0500, Rob Herring wrote: > There's no reason to have "status" properties in examples. "okay" is the > default, and "disabled" turns off some schema checks ('required' > specifically). > > A meta-schema check for this is pending, so hopefully the last time to > fix

Re: [PATCH] drm/i915/selftests: Stop using kthread_stop()

2022-10-20 Thread Ville Syrjälä
On Thu, Oct 20, 2022 at 02:08:41PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Since a7c01fa93aeb ("signal: break out of wait loops on kthread_stop()") > kthread_stop() started asserting a pending signal which wreaks havoc with > a few of our selftests. Mainly because they are not

[Bug 216119] 087451f372bf76d breaks hibernation on amdgpu Radeon R9 390

2022-10-20 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216119 --- Comment #43 from Alex Deucher (alexdeuc...@gmail.com) --- Created attachment 303055 --> https://bugzilla.kernel.org/attachment.cgi?id=303055=edit possible fix Can you try this patch? You might also try adding:

Re: [PATCH v4 01/10] gna: add PCI driver module

2022-10-20 Thread Matthew Wilcox
On Thu, Oct 20, 2022 at 03:35:16PM +0200, Kwapulinski, Maciej wrote: > +++ b/drivers/gpu/drm/gna/Kconfig > @@ -0,0 +1,12 @@ > +# > +# Intel(R) Gaussian & Neural Accelerator (Intel(R) GNA) > +# > + > +config DRM_GNA > + tristate "Intel(R) Gaussian & Neural Accelerator (Intel(R) GNA)" > +

[pull] amdgpu drm-fixes-6.1

2022-10-20 Thread Alex Deucher
Hi Dave, Daniel, An important regression fix for older APUs for 6.1 and stable. The following changes since commit 8273b4048664fff356fd10059033f0e2f5a422a1: drm/amdgpu: Fix for BO move issue (2022-10-18 22:14:07 -0400) are available in the Git repository at:

Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8188

2022-10-20 Thread Krzysztof Kozlowski
On 20/10/2022 07:45, xinlei@mediatek.com wrote: > From: xinlei lee > > For MT8188, the vdosys0 only supports 1T1P mode while the vdosys0 supports > 2T1P mode in MT8195. > > So we need to add dt-binding documentation of dpi for MediaTek MT8188 SoC. Acked-by: Krzysztof Kozlowski Best

Re: [PATCH] gpu: host1x: Avoid trying to use GART on Tegra20

2022-10-20 Thread Thierry Reding
On Thu, Oct 20, 2022 at 01:42:28PM +0100, Robin Murphy wrote: > On 2022-10-20 13:25, Jon Hunter wrote: > > Hi Robin, > > > > On 19/10/2022 18:23, Robin Murphy wrote: > > > Since commit c7e3ca515e78 ("iommu/tegra: gart: Do not register with > > > bus") quite some time ago, the GART driver has

[PATCH v4 03/10] gna: read hardware info

2022-10-20 Thread Kwapulinski, Maciej
From: Tomasz Jankowski Get the hardware information from register MMIO_IBUFFS Signed-off-by: Tomasz Jankowski Tested-by: Mikolaj Grzybowski Co-developed-by: Jianxun Zhang Signed-off-by: Jianxun Zhang Co-developed-by: Maciej Kwapulinski Signed-off-by: Maciej Kwapulinski ---

  1   2   3   >