Re: [PATCH v3 4/7] drm/msm/dp: incorporate pm_runtime framework into DP driver

2023-09-15 Thread kernel test robot
-tip next-20230915] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Kuogee-Hsieh

[Bug 217916] New: amdgpu: ring gfx_low timeout (Google Maps zooming)

2023-09-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217916 Bug ID: 217916 Summary: amdgpu: ring gfx_low timeout (Google Maps zooming) Product: Drivers Version: 2.5 Hardware: All OS: Linux Status: NEW Severity:

Re: [PATCH v6 1/3] drm/i915/pxp/mtl: Update pxp-firmware response timeout

2023-09-15 Thread kernel test robot
Hi Alan, kernel test robot noticed the following build errors: [auto build test ERROR on cf1e91e884bb1113c653e654e9de1754fc1d4488] url: https://github.com/intel-lab-lkp/linux/commits/Alan-Previn/drm-i915-pxp-mtl-Update-pxp-firmware-response-timeout/20230916-023150 base:

Re: [PATCH v3 2/7] drm/msm/dp: replace is_connected with link_ready

2023-09-15 Thread Dmitry Baryshkov
On Sat, 16 Sept 2023 at 00:38, Kuogee Hsieh wrote: > > The is_connected flag is set to true after DP mainlink successfully > finish link training. Replace the is_connected flag with link_ready finishes. Also this is not a replace, this patch renames the flag. > flag to avoid confusing.

Re: [PATCH v3 7/7] drm/msm/dp: move of_dp_aux_populate_bus() to eDP probe()

2023-09-15 Thread Dmitry Baryshkov
On Sat, 16 Sept 2023 at 00:39, Kuogee Hsieh wrote: > > Currently eDP population is done at msm_dp_modeset_init() which happen > at binding time. Move eDP population to be done at display probe time > so that probe deferral cases can be handled effectively. > wait_for_hpd_asserted callback is

[syzbot] [dri?] WARNING in drm_gem_object_handle_put_unlocked

2023-09-15 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:0bb80ecc33a8 Linux 6.6-rc1 git tree: upstream console+strace: https://syzkaller.appspot.com/x/log.txt?x=1002530c68 kernel config: https://syzkaller.appspot.com/x/.config?x=f4894cf58531f dashboard link:

Re: [PATCH v3 6/7] drm/msm/dp: add pm_runtime_force_suspend()/resume()

2023-09-15 Thread Dmitry Baryshkov
On Sat, 16 Sept 2023 at 00:38, Kuogee Hsieh wrote: > > Add pm_runtime_force_suspend()/resume() to complete incorporating pm > runtime framework into DP driver. Both dp_pm_prepare() and dp_pm_complete() > are added to set hpd_state to correct state. After resume, DP driver will > re training its

[PATCH] drm/nouveau: fence: fix type cast warning in nouveau_fence_emit()

2023-09-15 Thread Danilo Krummrich
Fix the following warning. drivers/gpu/drm/nouveau/nouveau_fence.c:210:45: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected struct nouveau_channel *chan @@ got struct nouveau_channel [noderef] __rcu *channel We're just about to emit the fence,

Re: [PATCH v3 5/7] drm/msm/dp: delete EV_HPD_INIT_SETUP

2023-09-15 Thread Dmitry Baryshkov
On Sat, 16 Sept 2023 at 00:38, Kuogee Hsieh wrote: > > EV_HPD_INIT_SETUP flag is used to trigger the initialization of external > DP host controller. Since external DP host controller initialization had > been incorporated into pm_runtime_resume(), this flag become obsolete. became > Lets get

Re: [PATCH v3 4/7] drm/msm/dp: incorporate pm_runtime framework into DP driver

2023-09-15 Thread Dmitry Baryshkov
On Sat, 16 Sept 2023 at 00:38, Kuogee Hsieh wrote: > > Currently DP driver is executed independent of PM runtime framework. > This lead DP driver incompatible with others. Incorporating pm runtime Why is it incompatible? Which others are mentioned here? > framework into DP driver so that both

Re: [PATCH v3 3/7] drm/msm/dp: use drm_bridge_hpd_notify() to report HPD status changes

2023-09-15 Thread Dmitry Baryshkov
On Sat, 16 Sept 2023 at 00:38, Kuogee Hsieh wrote: > > Currently DP driver use drm_helper_hpd_irq_event(), bypassing drm bridge > framework, to report HPD status changes to user space frame work. > Replace it with drm_bridge_hpd_notify() since DP driver is part of drm > bridge. > > Signed-off-by:

Re: [PATCH v2] drm/msm/dsi: skip the wait for video mode done if not applicable

2023-09-15 Thread Dmitry Baryshkov
On Fri, 15 Sept 2023 at 23:45, Abhinav Kumar wrote: > > dsi_wait4video_done() API waits for the DSI video mode engine to > become idle so that we can transmit the DCS commands in the > beginning of BLLP. However, with the current sequence, the MDP > timing engine is turned on after the panel's

Re: [PATCH v3 1/7] drm/msm/dp: tie dp_display_irq_handler() with dp driver

2023-09-15 Thread Dmitry Baryshkov
On Sat, 16 Sept 2023 at 00:38, Kuogee Hsieh wrote: > > Currently the dp_display_irq_handler() is executed at msm_dp_modeset_init() > which ties irq registration to the DPU device's life cycle, while depending on > resources that are released as the DP device is torn down. Move register DP >

Re: [PATCH v4 8/9] drm/msm/dpu: merge DPU_SSPP_SCALER_QSEED3, QSEED3LITE, QSEED4

2023-09-15 Thread Dmitry Baryshkov
On Sat, 16 Sept 2023 at 02:01, Abhinav Kumar wrote: > > > > On 9/11/2023 2:45 PM, Dmitry Baryshkov wrote: > > Three different features, DPU_SSPP_SCALER_QSEED3, QSEED3LITE and QSEED4 > > are all related to different versions of the same HW scaling block. > > Corresponding driver parts use

Re: Fwd: Kernel 6.6-rc1 fails to reboot or shutdown Ryzen 5825U

2023-09-15 Thread Bagas Sanjaya
On Thu, Sep 14, 2023 at 02:03:00PM +0700, Bagas Sanjaya wrote: > #regzbot introduced: v6.5..v6.6 > https://bugzilla.kernel.org/show_bug.cgi?id=217905 > #regzbot title: shutdown/reboot hang on Ryzen 5825U (stuck on amdgpu > initialization) > Fixing up commit range: #regzbot introduced:

Re: [Nouveau] [PATCH] nouveau/u_memcpya: fix NULL vs error pointer bug

2023-09-15 Thread Danilo Krummrich
Hi Dan, On 9/15/23 14:59, Dan Carpenter wrote: The u_memcpya() function is supposed to return error pointers on error. Returning NULL will lead to an Oops. Fixes: 68132cc6d1bc ("nouveau/u_memcpya: use vmemdup_user") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/nouveau/nouveau_drv.h | 2

Re: [PATCH v4 8/9] drm/msm/dpu: merge DPU_SSPP_SCALER_QSEED3, QSEED3LITE, QSEED4

2023-09-15 Thread Abhinav Kumar
On 9/11/2023 2:45 PM, Dmitry Baryshkov wrote: Three different features, DPU_SSPP_SCALER_QSEED3, QSEED3LITE and QSEED4 are all related to different versions of the same HW scaling block. Corresponding driver parts use scaler_blk.version to identify the correct way to program the hardware. In

[PATCH][V2] drm/amd/display: Remove unwanted drm edid references

2023-09-15 Thread Alex Hung
[WHY] edid_override and drm_edid_override_connector_update, according to drm documentation, should not be referred outside drm_edid. [HOW] Remove and replace them accordingly. This can tested by IGT's kms_hdmi_inject test. Signed-off-by: Alex Hung --- V2 - add comments for drm_get_edid and

[PATCH 3/4] drm/i915/guc: Add support for w/a KLVs

2023-09-15 Thread John . C . Harrison
From: John Harrison To prevent running out of bits, new w/a enable flags are being added via a KLV system instead of a 32 bit flags word. Signed-off-by: John Harrison --- .../gpu/drm/i915/gt/uc/abi/guc_errors_abi.h | 1 + drivers/gpu/drm/i915/gt/uc/intel_guc.h| 3 +

[PATCH 4/4] drm/i915/guc: Enable Wa_14019159160

2023-09-15 Thread John . C . Harrison
From: John Harrison Use the new w/a KLV support to enable a MTL w/a. Note, this w/a is a super-set of Wa_16019325821, so requires turning that one as well as setting the new flag for Wa_14019159160 itself. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 3 +++

[PATCH 2/4] drm/i915: Enable Wa_16019325821

2023-09-15 Thread John . C . Harrison
From: John Harrison Some platforms require holding RCS context switches until CCS is idle (the reverse w/a of Wa_14014475959). Some platforms require both versions. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 19 +++

[PATCH 1/4] drm/i915/guc: Update 'recommended' version to 70.11.0 for DG2/ADL-P/MTL

2023-09-15 Thread John . C . Harrison
From: John Harrison The latest GuC has new features and new workarounds that we wish to enable. So let the universe know that it is useful to update their firmware. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH 0/4] Enable Wa_14019159160 and Wa_16019325821 for MTL

2023-09-15 Thread John . C . Harrison
From: John Harrison Enable Wa_14019159160 and Wa_16019325821 for MTL RCS/CCS workarounds for MTL. Signed-off-by: John Harrison John Harrison (4): drm/i915/guc: Update 'recommended' version to 70.11.0 for DG2/ADL-P/MTL drm/i915: Enable Wa_16019325821 drm/i915/guc: Add support for

Re: [PATCH v4 7/9] drm/msm/dpu: drop DPU_HW_SUBBLK_INFO macro

2023-09-15 Thread Abhinav Kumar
On 9/11/2023 2:45 PM, Dmitry Baryshkov wrote: As the subblock info is now mostly gone, inline and drop the macro DPU_HW_SUBBLK_INFO. Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h| 40 ++- 1 file changed, 21 insertions(+), 19

Re: [RFC PATCH 2/8] drm/panel: nv3052c: Add SPI device IDs

2023-09-15 Thread Jessica Zhang
On 9/11/2023 2:02 AM, John Watts wrote: SPI drivers needs their own list of compatible device IDs in order for automatic module loading to work. Add those for this driver. Hi John, Reviewed-by: Jessica Zhang Thanks, Jessica Zhang Signed-off-by: John Watts ---

Re: [PATCH v4 6/9] drm/msm/dpu: deduplicate some (most) of SSPP sub-blocks

2023-09-15 Thread Abhinav Kumar
On 9/11/2023 2:45 PM, Dmitry Baryshkov wrote: As we have dropped the variadic parts of SSPP sub-blocks declarations, deduplicate them now, reducing memory cruft. Signed-off-by: Dmitry Baryshkov --- .../msm/disp/dpu1/catalog/dpu_3_0_msm8998.h | 16 +--

[PATCH v3 5/7] drm/msm/dp: delete EV_HPD_INIT_SETUP

2023-09-15 Thread Kuogee Hsieh
EV_HPD_INIT_SETUP flag is used to trigger the initialization of external DP host controller. Since external DP host controller initialization had been incorporated into pm_runtime_resume(), this flag become obsolete. Lets get rid of it. Changes in v3: -- drop EV_HPD_INIT_SETUP and

[PATCH v3 7/7] drm/msm/dp: move of_dp_aux_populate_bus() to eDP probe()

2023-09-15 Thread Kuogee Hsieh
Currently eDP population is done at msm_dp_modeset_init() which happen at binding time. Move eDP population to be done at display probe time so that probe deferral cases can be handled effectively. wait_for_hpd_asserted callback is added during drm_dp_aux_init() to ensure eDP's HPD is up before

[PATCH v3 0/7] incorporate pm runtime framework and eDP clean up

2023-09-15 Thread Kuogee Hsieh
Incorporate pm runtime framework into DP driver and clean up eDP by moving of_dp_aux_populate_bus() to probe(). -- add v3 changes log Kuogee Hsieh (7): drm/msm/dp: tie dp_display_irq_handler() with dp driver drm/msm/dp: replace is_connected with link_ready drm/msm/dp: use

[PATCH v3 3/7] drm/msm/dp: use drm_bridge_hpd_notify() to report HPD status changes

2023-09-15 Thread Kuogee Hsieh
Currently DP driver use drm_helper_hpd_irq_event(), bypassing drm bridge framework, to report HPD status changes to user space frame work. Replace it with drm_bridge_hpd_notify() since DP driver is part of drm bridge. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_display.c | 20

[PATCH v3 6/7] drm/msm/dp: add pm_runtime_force_suspend()/resume()

2023-09-15 Thread Kuogee Hsieh
Add pm_runtime_force_suspend()/resume() to complete incorporating pm runtime framework into DP driver. Both dp_pm_prepare() and dp_pm_complete() are added to set hpd_state to correct state. After resume, DP driver will re training its main link after .hpd_enable() callback enabled HPD interrupts

[PATCH v3 4/7] drm/msm/dp: incorporate pm_runtime framework into DP driver

2023-09-15 Thread Kuogee Hsieh
Currently DP driver is executed independent of PM runtime framework. This lead DP driver incompatible with others. Incorporating pm runtime framework into DP driver so that both power and clocks to enable/disable host controller fits with PM runtime mechanism. Once pm runtime framework is

[PATCH v3 2/7] drm/msm/dp: replace is_connected with link_ready

2023-09-15 Thread Kuogee Hsieh
The is_connected flag is set to true after DP mainlink successfully finish link training. Replace the is_connected flag with link_ready flag to avoid confusing. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_display.c | 19 +-- drivers/gpu/drm/msm/dp/dp_display.h | 2

[PATCH v3 1/7] drm/msm/dp: tie dp_display_irq_handler() with dp driver

2023-09-15 Thread Kuogee Hsieh
Currently the dp_display_irq_handler() is executed at msm_dp_modeset_init() which ties irq registration to the DPU device's life cycle, while depending on resources that are released as the DP device is torn down. Move register DP driver irq handler at dp_display_probe() to have

Re: [RFC PATCH 5/8] drm/panel: nv3052c: Allow specifying registers per panel

2023-09-15 Thread Jessica Zhang
On 9/11/2023 2:02 AM, John Watts wrote: Panel initialization registers are per-display and not tied to the controller itself. Different panels will specify their own registers. Attach the sequences to the panel info struct so future panels can specify their own sequences. Signed-off-by: John

[PATCH v2 7/7] drm/msm/dp: move of_dp_aux_populate_bus() to eDP probe()

2023-09-15 Thread Kuogee Hsieh
Currently eDP population is done at msm_dp_modeset_init() which happen at binding time. Move eDP population to be done at display probe time so that probe deferral cases can be handled effectively. wait_for_hpd_asserted callback is added during drm_dp_aux_init() to ensure eDP's HPD is up before

[PATCH v2 6/7] drm/msm/dp: add pm_runtime_force_suspend()/resume()

2023-09-15 Thread Kuogee Hsieh
Add pm_runtime_force_suspend()/resume() to complete incorporating pm runtime framework into DP driver. Both dp_pm_prepare() and dp_pm_complete() are added to set hpd_state to correct state. After resume, DP driver will re training its main link after .hpd_enable() callback enabled HPD interrupts

[PATCH v2 3/7] drm/msm/dp: use drm_bridge_hpd_notify() to report HPD status changes

2023-09-15 Thread Kuogee Hsieh
Currently DP driver use drm_helper_hpd_irq_event(), bypassing drm bridge framework, to report HPD status changes to user space frame work. Replace it with drm_bridge_hpd_notify() since DP driver is part of drm bridge. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_display.c | 20

[PATCH v2 5/7] drm/msm/dp: delete EV_HPD_INIT_SETUP

2023-09-15 Thread Kuogee Hsieh
EV_HPD_INIT_SETUP flag is used to trigger the initialization of external DP host controller. Since external DP host controller initialization had been incorporated into pm_runtime_resume(), this flag become obsolete. Lets get rid of it. Signed-off-by: Kuogee Hsieh ---

[PATCH v2 1/7] drm/msm/dp: tie dp_display_irq_handler() with dp driver

2023-09-15 Thread Kuogee Hsieh
Currently the dp_display_irq_handler() is executed at msm_dp_modeset_init() which ties irq registration to the DPU device's life cycle, while depending on resources that are released as the DP device is torn down. Move register DP driver irq handler at dp_display_probe() to have

[PATCH v2 4/7] drm/msm/dp: incorporate pm_runtime framework into DP driver

2023-09-15 Thread Kuogee Hsieh
Currently DP driver is executed independent of PM runtime framework. This lead DP driver incompatible with others. Incorporating pm runtime framework into DP driver so that both power and clocks to enable/disable host controller fits with PM runtime mechanism. Once pm runtime framework is

[PATCH v2 2/7] drm/msm/dp: replace is_connected with link_ready

2023-09-15 Thread Kuogee Hsieh
The is_connected flag is set to true after DP mainlink successfully finish link training. Replace the is_connected flag with link_ready flag to avoid confusing. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_display.c | 19 +-- drivers/gpu/drm/msm/dp/dp_display.h | 2

[PATCH v2 0/7] incorporate pm runtime framework and eDP clean up

2023-09-15 Thread Kuogee Hsieh
Incorporate pm runtime framework into DP driver and clean up eDP by moving of_dp_aux_populate_bus() to probe() Kuogee Hsieh (7): drm/msm/dp: tie dp_display_irq_handler() with dp driver drm/msm/dp: replace is_connected with link_ready drm/msm/dp: use drm_bridge_hpd_notify() to report HPD

[PATCH v2] drm/msm/dsi: skip the wait for video mode done if not applicable

2023-09-15 Thread Abhinav Kumar
dsi_wait4video_done() API waits for the DSI video mode engine to become idle so that we can transmit the DCS commands in the beginning of BLLP. However, with the current sequence, the MDP timing engine is turned on after the panel's pre_enable() callback which can send out the DCS commands needed

Re: [git pull] drm fixes for 6.6-rc2

2023-09-15 Thread pr-tracker-bot
The pull request you sent on Fri, 15 Sep 2023 12:57:50 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-09-15 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/9608c7b729e29c177525006711966ae0fd399b11 Thank you! -- Deet-doot-dot, I am a bot.

Re: [PATCH v3] drm/i915/pxp: Add drm_dbgs for critical PXP events.

2023-09-15 Thread Teres Alexis, Alan Previn
On Fri, 2023-09-15 at 13:15 -0700, Teres Alexis, Alan Previn wrote: > Debugging PXP issues can't even begin without understanding precedding > sequence of important events. Add drm_dbg into the most important PXP events. > > v3 : - move gt_dbg to after mutex block in function >

[PATCH v3] drm/i915/pxp: Add drm_dbgs for critical PXP events.

2023-09-15 Thread Alan Previn
Debugging PXP issues can't even begin without understanding precedding sequence of important events. Add drm_dbg into the most important PXP events. v3 : - move gt_dbg to after mutex block in function i915_gsc_proxy_component_bind. (Vivaik) v2 : - remove __func__ since drm_dbg covers

Re: [PATCH 1/4] drm/dp_mst: Fix NULL dereference during payload addition

2023-09-15 Thread Lyude Paul
Thanks for catching all of this! for the whole series: Reviewed-by: Lyude Paul On Thu, 2023-09-14 at 01:32 +0300, Imre Deak wrote: > Fix the NULL dereference leading to the following stack trace: > > [ 129.687181] i915 :00:02.0: [drm:drm_dp_add_payload_part1 > [drm_display_helper]] VCPI

Re: [PATCH] drm/msm/dsi: skip the wait for video mode done if not applicable

2023-09-15 Thread Dmitry Baryshkov
On Fri, 15 Sept 2023 at 21:30, Abhinav Kumar wrote: > > dsi_wait4video_done() API wait for the DSI video mode engine to > become idle so that we can transmit the DCS commands in the > beginning of BLLP. However, with the current sequence, the MDP > timing engine is turned on after the panel's

Re: [PATCH][next] drm/gud: Use size_add() in call to struct_size()

2023-09-15 Thread Gustavo A. R. Silva
On 9/15/23 12:52, Kees Cook wrote: On Fri, Sep 15, 2023 at 12:43:20PM -0600, Gustavo A. R. Silva wrote: If, for any reason, the open-coded arithmetic causes a wraparound, the protection that `struct_size()` adds against potential integer overflows is defeated. Fix this by hardening call to

Re: [PATCH][next] drm/gud: Use size_add() in call to struct_size()

2023-09-15 Thread Kees Cook
On Fri, Sep 15, 2023 at 12:43:20PM -0600, Gustavo A. R. Silva wrote: > If, for any reason, the open-coded arithmetic causes a wraparound, the > protection that `struct_size()` adds against potential integer overflows > is defeated. Fix this by hardening call to `struct_size()` with `size_add()`. >

[PATCH][next] drm/gud: Use size_add() in call to struct_size()

2023-09-15 Thread Gustavo A. R. Silva
If, for any reason, the open-coded arithmetic causes a wraparound, the protection that `struct_size()` adds against potential integer overflows is defeated. Fix this by hardening call to `struct_size()` with `size_add()`. Fixes: 40e1a70b4aed ("drm: Add GUD USB Display driver") Signed-off-by:

Re: [PATCH v2 0/4] drm/xe: Support optional pinning of userptr pages

2023-09-15 Thread Thomas Hellström
Hi, On 9/8/23 10:44, Joonas Lahtinen wrote: Quoting Thomas Hellström (2023-08-22 19:21:32) This series adds a flag at VM_BIND time to pin the memory backing a VMA. Initially this is needed for long-running workloads on hardware that neither support mid-thread preemption nor pagefaults, since

[PATCH] drm/msm/dsi: skip the wait for video mode done if not applicable

2023-09-15 Thread Abhinav Kumar
dsi_wait4video_done() API wait for the DSI video mode engine to become idle so that we can transmit the DCS commands in the beginning of BLLP. However, with the current sequence, the MDP timing engine is turned on after the panel's pre_enable() callback which can send out the DCS commands needed

[PATCH v6 2/3] drm/i915/pxp/mtl: Update pxp-firmware packet size

2023-09-15 Thread Alan Previn
Update the GSC-fw input/output HECI packet size to match updated internal fw specs. Signed-off-by: Alan Previn Reviewed-by: Vivaik Balasubrawmanian --- drivers/gpu/drm/i915/pxp/intel_pxp_cmd_interface_43.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v6 0/3] drm/i915/pxp/mtl: Update gsc-heci cmd submission to align with fw/hw spec

2023-09-15 Thread Alan Previn
For MTL, update the GSC-HECI packet size and the max firmware response timeout to match internal fw specs. Enforce setting run-alone bit in LRC for protected contexts. Changes from prio revs: v5: - PAGE_ALIGN typo fix (Alan). - Use macro for runalone bit (Vivaik) - Spec alignment

[PATCH v6 3/3] drm/i915/lrc: User PXP contexts requires runalone bit in lrc

2023-09-15 Thread Alan Previn
On Meteorlake onwards, HW specs require that all user contexts that run on render or compute engines and require PXP must enforce run-alone bit in lrc. Add this enforcement for protected contexts. Signed-off-by: Alan Previn Reviewed-by: Vivaik Balasubrawmanian ---

[PATCH v6 1/3] drm/i915/pxp/mtl: Update pxp-firmware response timeout

2023-09-15 Thread Alan Previn
Update the max GSC-fw response time to match updated internal fw specs. Because this response time is an SLA on the firmware, not inclusive of i915->GuC->HW handoff latency, when submitting requests to the GSC fw via intel_gsc_uc_heci_cmd_submit helpers, start the count after the request hits the

[PATCH v6 0/3] drm/i915/pxp/mtl: Update gsc-heci cmd submission to align with fw/hw spec

2023-09-15 Thread Alan Previn
For MTL, update the GSC-HECI packet size and the max firmware response timeout to match internal fw specs. Enforce setting run-alone bit in LRC for protected contexts. Changes from prio revs: v5: - PAGE_ALIGN typo fix (Alan). - Use macro for runalone bit (Vivaik) - Spec alignment

Re: [syzbot] [mm?] kernel BUG in filemap_unaccount_folio

2023-09-15 Thread syzbot
syzbot has bisected this issue to: commit 5c074eeabbd332b11559f7fc1e89d456f94801fb Author: Gerd Hoffmann Date: Wed Nov 14 12:20:29 2018 + udmabuf: set read/write flag when exporting bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=12b21bbfa8 start commit:

Re: [PATCH] drm/panel: boe-tv101wum-nl6: Completely Pull GPW to VGL before TP term

2023-09-15 Thread Jessica Zhang
On 9/12/2023 3:59 AM, Ruihai Zhou wrote: The sta_himax83102 panel sometimes shows abnormally flickering horizontal lines. The front gate output will precharge the X point of the next pole circuit before TP(TouchPanel Enable) term starts, and wait until the end of the TP term to resume the

Re: [PATCH] drm/amd/display: fix the ability to use lower resolution modes on eDP

2023-09-15 Thread Harry Wentland
On 2023-09-14 17:12, Hamza Mahfooz wrote: > > On 9/14/23 17:04, Hamza Mahfooz wrote: >> >> On 9/14/23 16:40, Harry Wentland wrote: >>> On 2023-09-14 13:53, Hamza Mahfooz wrote: On eDP we can receive invalid modes from dm_update_crtc_state() for entirely new streams for which

Re: [PATCH v5 3/3] drm/i915/lrc: User PXP contexts requires runalone bit in lrc

2023-09-15 Thread Teres Alexis, Alan Previn
On Sat, 2023-09-09 at 15:38 -0700, Teres Alexis, Alan Previn wrote: > On Meteorlake onwards, HW specs require that all user contexts that > run on render or compute engines and require PXP must enforce > run-alone bit in lrc. Add this enforcement for protected contexts. alan:snip > >

Re: [PATCH v5 2/3] drm/i915/pxp/mtl: Update pxp-firmware packet size

2023-09-15 Thread Teres Alexis, Alan Previn
On Sat, 2023-09-09 at 15:38 -0700, Teres Alexis, Alan Previn wrote: > Update the GSC-fw input/output HECI packet size to match > updated internal fw specs. > > Signed-off-by: Alan Previn > --- > drivers/gpu/drm/i915/pxp/intel_pxp_cmd_interface_43.h | 4 ++-- > 1 file changed, 2 insertions(+), 2

Re: [PATCH v5 1/3] drm/i915/pxp/mtl: Update pxp-firmware response timeout

2023-09-15 Thread Teres Alexis, Alan Previn
On Sat, 2023-09-09 at 15:38 -0700, Teres Alexis, Alan Previn wrote: > Update the max GSC-fw response time to match updated internal > fw specs. Because this response time is an SLA on the firmware, > not inclusive of i915->GuC->HW handoff latency, when submitting > requests to the GSC fw via

Re: [PATCH] drm/nouveau/nvif: refactor deprecated strncpy

2023-09-15 Thread Lyude Paul
Reviewed-by: Lyude Paul Will push this and your other patches in just a moment On Thu, 2023-09-14 at 21:30 +, Justin Stitt wrote: > `strncpy` is deprecated and as such we should prefer more robust and > less ambiguous string interfaces. > > A suitable replacement is `strscpy_pad` due to

Re: [PATCH] drm/nouveau/pm: refactor deprecated strncpy

2023-09-15 Thread Lyude Paul
...oops, responded to the wrong email :P Reviewed-by: Lyude Paul On Thu, 2023-09-14 at 22:17 +, Justin Stitt wrote: > `strncpy` is deprecated for use on NUL-terminated destination strings [1]. > > We should prefer more robust and less ambiguous string interfaces. > > A suitable

Re: [PATCH] drm/nouveau/core: refactor deprecated strncpy

2023-09-15 Thread Lyude Paul
Eek, I didn't realize how many instances of this we had. Thanks for doing this :) Reviewed-by: Lyude Paul On Thu, 2023-09-14 at 21:40 +, Justin Stitt wrote: > `strncpy` is deprecated for use on NUL-terminated destination strings [1]. > > We should prefer more robust and less ambiguous

Re: [PATCH] drm/nouveau/pm: refactor deprecated strncpy

2023-09-15 Thread Lyude Paul
Nice catch! Reviewed-by: Lyude Paul Will push in just a moment On Thu, 2023-09-14 at 21:59 -0700, Kees Cook wrote: > On Thu, Sep 14, 2023 at 10:17:08PM +, Justin Stitt wrote: > > `strncpy` is deprecated for use on NUL-terminated destination strings [1]. > > > > We should prefer more

Re: [PATCH v5 1/3] drm/i915/pxp/mtl: Update pxp-firmware response timeout

2023-09-15 Thread Teres Alexis, Alan Previn
On Sat, 2023-09-09 at 15:38 -0700, Teres Alexis, Alan Previn wrote: > Update the max GSC-fw response time to match updated internal > fw specs. Because this response time is an SLA on the firmware, > not inclusive of i915->GuC->HW handoff latency, when submitting > requests to the GSC fw via

Re: [PATCH v5 2/3] drm/i915/pxp/mtl: Update pxp-firmware packet size

2023-09-15 Thread Teres Alexis, Alan Previn
On Sat, 2023-09-09 at 15:38 -0700, Teres Alexis, Alan Previn wrote: > Update the GSC-fw input/output HECI packet size to match > updated internal fw specs. > > Signed-off-by: Alan Previn > alan:snip > -/* PXP-Packet sizes for MTL's GSCCS-HECI instruction */ > -#define PXP43_MAX_HECI_INOUT_SIZE

RE: [PATCH v6 1/5] drm/amdgpu: Allocate coredump memory in a nonblocking way

2023-09-15 Thread Sharma, Shashank
[AMD Official Use Only - General] Pushed the rest of the patches in the series to amd-staging-drm-next. Regards Shashank -Original Message- From: Koenig, Christian Sent: Monday, September 11, 2023 1:15 PM To: André Almeida ; dri-devel@lists.freedesktop.org;

Re: [PATCH v2 1/2] dt-bindings: backlight: Add MPS MP3309C

2023-09-15 Thread Rob Herring
On Fri, Sep 15, 2023 at 04:05:15PM +0200, Flavio Suligoi wrote: > The Monolithic Power (MPS) MP3309C is a WLED step-up converter, featuring a > programmable switching frequency to optimize efficiency. > The brightness can be controlled either by I2C commands (called "analog" > mode) or by a PWM

Re: [PATCH v2 1/2] dt-bindings: backlight: Add MPS MP3309C

2023-09-15 Thread Conor Dooley
Yo, On Fri, Sep 15, 2023 at 04:05:15PM +0200, Flavio Suligoi wrote: > The Monolithic Power (MPS) MP3309C is a WLED step-up converter, featuring a > programmable switching frequency to optimize efficiency. > The brightness can be controlled either by I2C commands (called "analog" > mode) or by a

Re: [PATCH] MAINTAINERS: add drm_bridge_connector.[ch] files under bridge chips

2023-09-15 Thread Jani Nikula
On Fri, 15 Sep 2023, Robert Foss wrote: > On Fri, Sep 15, 2023 at 12:31 PM Neil Armstrong > wrote: >> >> On 14/09/2023 15:19, Jani Nikula wrote: >> > Clearly this should be under bridge chips. >> > >> > Cc: Andrzej Hajda >> > Cc: Neil Armstrong >> > Cc: Robert Foss >> > Signed-off-by: Jani

Re: [PATCH] accel/qaic: Use devm_drm_dev_alloc() instead of drm_dev_alloc()

2023-09-15 Thread Jeffrey Hugo
On 9/1/2023 10:12 AM, Jeffrey Hugo wrote: From: Pranjal Ramajor Asha Kanojiya Since drm_dev_alloc() is deprecated it is recommended to use devm_drm_dev_alloc() instead. Update the driver to start using devm_drm_dev_alloc(). Signed-off-by: Pranjal Ramajor Asha Kanojiya Reviewed-by: Carl

Re: [PATCH] accel/qaic: Use devm_drm_dev_alloc() instead of drm_dev_alloc()

2023-09-15 Thread Jeffrey Hugo
On 9/4/2023 3:28 AM, Stanislaw Gruszka wrote: On Fri, Sep 01, 2023 at 10:12:36AM -0600, Jeffrey Hugo wrote: From: Pranjal Ramajor Asha Kanojiya Since drm_dev_alloc() is deprecated it is recommended to use devm_drm_dev_alloc() instead. Update the driver to start using devm_drm_dev_alloc().

Re: [PATCH v2 1/2] dt-bindings: backlight: Add MPS MP3309C

2023-09-15 Thread Rob Herring
On Fri, 15 Sep 2023 16:05:15 +0200, Flavio Suligoi wrote: > The Monolithic Power (MPS) MP3309C is a WLED step-up converter, featuring a > programmable switching frequency to optimize efficiency. > The brightness can be controlled either by I2C commands (called "analog" > mode) or by a PWM input

Re: [PATCH] accel/qaic: Register for PCI driver at the beginning of module init

2023-09-15 Thread Jeffrey Hugo
On 9/1/2023 10:10 AM, Jeffrey Hugo wrote: From: Pranjal Ramajor Asha Kanojiya As qaic drivers base device is connected to host via PCI framework, it makes sense to register in PCI framework at the beginning of module init. Signed-off-by: Pranjal Ramajor Asha Kanojiya Reviewed-by: Carl

Re: [PATCH] drm/amd/display: Remove unwanted drm edid references

2023-09-15 Thread Jani Nikula
On Fri, 15 Sep 2023, Harry Wentland wrote: > On 2023-09-05 13:13, Alex Hung wrote: >> [WHY] >> edid_override and drm_edid_override_connector_update, according to drm >> documentation, should not be referred outside drm_edid. >> >> [HOW] >> Remove and replace them accordingly. >> >>

Re: [PATCH v11] drm: Add initial ci/ subdirectory

2023-09-15 Thread Daniel Stone
Hey, On Thu, 14 Sept 2023 at 10:54, Maxime Ripard wrote: > On Tue, Sep 12, 2023 at 02:16:41PM +0100, Daniel Stone wrote: > > Hopefully less mangled formatting this time: turns out Thunderbird + > > plain text is utterly unreadable, so that's one less MUA that is > > actually usable to send email

Re: [PATCH] drm/tests: Fix incorrect argument in drm_test_mm_insert_range

2023-09-15 Thread Maira Canal
On 9/15/23 11:17, Janusz Krzysztofik wrote: Hi Maíra, Thanks for review. On Friday, 15 September 2023 16:01:31 CEST Maira Canal wrote: Hi, On 9/11/23 10:03, Janusz Krzysztofik wrote: While drm_mm test was converted form igt selftest to kunit, unexpected value of "end" argument equal "start"

Re: [PATCH] drm/tests: Fix incorrect argument in drm_test_mm_insert_range

2023-09-15 Thread Janusz Krzysztofik
Hi Maíra, Thanks for review. On Friday, 15 September 2023 16:01:31 CEST Maira Canal wrote: > Hi, > > On 9/11/23 10:03, Janusz Krzysztofik wrote: > > While drm_mm test was converted form igt selftest to kunit, unexpected > > value of "end" argument equal "start" was introduced to one of calls to

Re: [RFT PATCH 2/6] drm: Call drm_atomic_helper_shutdown() at shutdown time for misc drivers

2023-09-15 Thread suijingfeng
Hi, On 2023/9/15 21:44, Doug Anderson wrote: Hi, On Fri, Sep 15, 2023 at 2:11 AM suijingfeng wrote: Hi, On 2023/9/2 07:39, Douglas Anderson wrote: Based on grepping through the source code these drivers appear to be missing a call to drm_atomic_helper_shutdown() at system shutdown time.

Re: [PATCH] drm/tests: Fix incorrect argument in drm_test_mm_insert_range

2023-09-15 Thread Maira Canal
Hi, On 9/11/23 10:03, Janusz Krzysztofik wrote: While drm_mm test was converted form igt selftest to kunit, unexpected value of "end" argument equal "start" was introduced to one of calls to a function that executes the drm_test_mm_insert_range for specific start/end pair of arguments. As a

Re: [PATCH] drm/amd/display: Remove unwanted drm edid references

2023-09-15 Thread Harry Wentland
On 2023-09-05 13:13, Alex Hung wrote: > [WHY] > edid_override and drm_edid_override_connector_update, according to drm > documentation, should not be referred outside drm_edid. > > [HOW] > Remove and replace them accordingly. > > Signed-off-by: Alex Hung > --- >

Re: [RFT PATCH 2/6] drm: Call drm_atomic_helper_shutdown() at shutdown time for misc drivers

2023-09-15 Thread Doug Anderson
Hi, On Fri, Sep 15, 2023 at 2:11 AM suijingfeng wrote: > > Hi, > > > On 2023/9/2 07:39, Douglas Anderson wrote: > > Based on grepping through the source code these drivers appear to be > > missing a call to drm_atomic_helper_shutdown() at system shutdown > > time. Among other things, this means

Re: [PATCH] drm/msm/dsi: fix irq_of_parse_and_map() error checking

2023-09-15 Thread Konrad Dybcio
On 15.09.2023 14:59, Dan Carpenter wrote: > The irq_of_parse_and_map() function returns zero on error. It > never returns negative error codes. Fix the check. > > Fixes: a689554ba6ed ("drm/msm: Initial add DSI connector support") > Signed-off-by: Dan Carpenter > --- Reviewed-by: Konrad Dybcio

[PATCH] drm/msm/dsi: fix irq_of_parse_and_map() error checking

2023-09-15 Thread Dan Carpenter
The irq_of_parse_and_map() function returns zero on error. It never returns negative error codes. Fix the check. Fixes: a689554ba6ed ("drm/msm: Initial add DSI connector support") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/msm/dsi/dsi_host.c | 7 +++ 1 file changed, 3 insertions(+),

[PATCH] nouveau/u_memcpya: fix NULL vs error pointer bug

2023-09-15 Thread Dan Carpenter
The u_memcpya() function is supposed to return error pointers on error. Returning NULL will lead to an Oops. Fixes: 68132cc6d1bc ("nouveau/u_memcpya: use vmemdup_user") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/nouveau/nouveau_drv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [RFC PATCH v1 12/12] usb: typec: qcom: define the bridge's path

2023-09-15 Thread Heikki Krogerus
Hi Dmitry, On Mon, Sep 04, 2023 at 12:41:50AM +0300, Dmitry Baryshkov wrote: > In order to notify the userspace about the DRM connector's USB-C port, > export the corresponding port's name as the bridge's path field. > > Signed-off-by: Dmitry Baryshkov > --- >

[PATCH v2 03/10] drm/amdgpu: Use RMW accessors for changing LNKCTL2

2023-09-15 Thread Ilpo Järvinen
Don't assume that only the driver would be accessing LNKCTL2. In the case of upstream (parent), the driver does not even own the device it's changing the registers for. Use RMW capability accessors which do proper locking to avoid losing concurrent updates to the register value. This change is

[PATCH v2 02/10] drm/radeon: Use RMW accessors for changing LNKCTL2

2023-09-15 Thread Ilpo Järvinen
Don't assume that only the driver would be accessing LNKCTL2. In the case of upstream (parent), the driver does not even own the device it's changing the registers for. Use RMW capability accessors which do proper locking to avoid losing concurrent updates to the register value. This change is

Re: [PATCH] MAINTAINERS: add drm_bridge_connector.[ch] files under bridge chips

2023-09-15 Thread Robert Foss
On Fri, Sep 15, 2023 at 12:31 PM Neil Armstrong wrote: > > On 14/09/2023 15:19, Jani Nikula wrote: > > Clearly this should be under bridge chips. > > > > Cc: Andrzej Hajda > > Cc: Neil Armstrong > > Cc: Robert Foss > > Signed-off-by: Jani Nikula > > --- > > MAINTAINERS | 2 ++ > > 1 file

Re: [PATCH] drm: bridge: it66121: ->get_edid callback must not return err pointers

2023-09-15 Thread Paul Cercueil
Hi Jani, Le jeudi 14 septembre 2023 à 16:11 +0300, Jani Nikula a écrit : > The drm stack does not expect error valued pointers for EDID > anywhere. > > Fixes: e66856508746 ("drm: bridge: it66121: Set DDC preamble only > once before reading EDID") > Cc: Paul Cercueil > Cc: Robert Foss > Cc:

[PATCH] drm/virtio: add definition for venus capset

2023-09-15 Thread Huang Rui
This definition is used fro qemu, and qemu imports this marco in the headers to enable venus for virtio gpu. So it should add it even kernel doesn't use this. Signed-off-by: Huang Rui --- Hi all, We would like to add a new definition for venus capset, it will be used for qemu. Please see

[PATCH v5 7/8] drm: atmel-hlcdc: add vertical and horizontal scaling support for XLCDC

2023-09-15 Thread Manikandan Muralidharan
Update the LCDC_HEOCFG30 and LCDC_HEOCFG31 registers of XLCDC IP which supports vertical and horizontal scaling with Bilinear and Bicubic co-efficients taps for Chroma and Luma componenets of the Pixel. Signed-off-by: Manikandan Muralidharan --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c |

[PATCH v5 8/8] drm: atmel-hlcdc: add support for DSI output formats

2023-09-15 Thread Manikandan Muralidharan
Add support for the following DPI mode if the encoder type is DSI as per the XLCDC IP datasheet: - 16BPPCFG1 - 16BPPCFG2 - 16BPPCFG3 - 18BPPCFG1 - 18BPPCFG2 - 24BPP Signed-off-by: Manikandan Muralidharan [durai.manicka...@microchip.com: update output format using is_xlcdc flag] Signed-off-by:

[PATCH v5 6/8] drm: atmel-hlcdc: add DPI mode support for XLCDC

2023-09-15 Thread Manikandan Muralidharan
Add support for Display Pixel Interface (DPI) Compatible Mode support in atmel-hlcdc driver for XLCDC IP along with legacy pixel mapping.DPI mode BIT is configured in LCDC_CFG5 register. Signed-off-by: Manikandan Muralidharan [durai.manicka...@microchip.com: update DPI mode bit using is_xlcdc

[PATCH v5 4/8] drm: atmel-hlcdc: Define SAM9X7 SoC XLCDC specific registers

2023-09-15 Thread Manikandan Muralidharan
From: Durai Manickam KR The register address of the XLCDC IP used in SAM9X7 SoC family are different from the previous HLCDC.Defining those address space with valid macros. Signed-off-by: Durai Manickam KR [manikanda...@microchip.com: Remove unused macro definitions] Signed-off-by: Manikandan

  1   2   >