[PULL] drm-xe-next-fixes

2024-03-14 Thread Lucas De Marchi
Hi Dave and Sima, Here are the drm-xe fixes for the 6.9 cycle. Just 3 fixes: one trivial fix for error path handling, one to avoid pinning all VMAs in drm_gpuvm_exec_lock() when num_batch_buffer passed to xe_exec is 0 and the other to allow userspace to free userptr while still having bindings.

[PATCH] drm/sched: fix null-ptr-deref in init entity

2024-03-14 Thread vitaly.prosyak
From: Vitaly Prosyak The bug can be triggered by sending an amdgpu_cs_wait_ioctl to the AMDGPU DRM driver on any ASICs with valid context. The bug was reported by Joonkyo Jung . For example the following code: static void Syzkaller2(int fd) { union drm_amdgpu_ctx arg1;

Re: Proposal to add CRIU support to DRM render nodes

2024-03-14 Thread Felix Kuehling
On 2024-03-12 5:45, Tvrtko Ursulin wrote: On 11/03/2024 14:48, Tvrtko Ursulin wrote: Hi Felix, On 06/12/2023 21:23, Felix Kuehling wrote: Executive Summary: We need to add CRIU support to DRM render nodes in order to maintain CRIU support for ROCm application once they start relying on

[PATCH RFC v2 4/7] drm/msm: move msm_gpummu.c to adreno/a2xx_gpummu.c

2024-03-14 Thread Dmitry Baryshkov
The msm_gpummu.c implementation is used only on A2xx and it is tied to the A2xx registers. Rename the source file accordingly. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/Makefile | 2 +- drivers/gpu/drm/msm/adreno/a2xx_gpu.c | 4 +-

[PATCH RFC v2 6/7] drm/msm: import gen_header.py script from Mesa

2024-03-14 Thread Dmitry Baryshkov
Import the gen_headers.py script from Mesa, commit FIXME. This script will be used to generate MSM register files on the fly during compilation. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/registers/gen_header.py | 958 1 file changed, 958 insertions(+)

[PATCH RFC v2 3/7] drm/msm/dsi: drop mmss_cc.xml.h

2024-03-14 Thread Dmitry Baryshkov
The mmss_cc.xml.h file describes bits of the MMSS clock controller on APQ8064 / MSM8960 platforms. They are not used by the driver and do not belong to the DRM MSM driver. Drop the file. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/mmss_cc.xml.h | 131

[PATCH RFC v2 1/7] drm/msm/mdp5: add writeback block bases

2024-03-14 Thread Dmitry Baryshkov
In order to stop patching the mdp5 headers, import definitions for the writeback blocks. This part is extracted from the old Rob's patch. Co-developed-by: Rob Clark Signed-off-by: Rob Clark Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.h | 11 +++ 1 file

[PATCH RFC v2 2/7] drm/msm/hdmi: drop qfprom.xml.h

2024-03-14 Thread Dmitry Baryshkov
The qfprom.xml.h contains definitions for the nvmem code. They are not used in the existing code. Also if we were to use them later, we should have used nvmem cell API instead of using these defs. Drop the file. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/qfprom.xml.h | 61

[PATCH RFC v2 0/7] drm/msm: generate register header files

2024-03-14 Thread Dmitry Baryshkov
Currently display-related register headers are generated from XML files shipped withing Mesa source tree. This is not fully optimal: it requires multi-stage process of the changes first being landed to Mesa and only then synced to the kernel tree. Move original XML files to the kernel tree and

Re: [PATCH 1/3] drm/msm/dp: Avoid a long timeout for AUX transfer if nothing connected

2024-03-14 Thread Doug Anderson
Hi, On Wed, Mar 13, 2024 at 1:41 PM Abhinav Kumar wrote: > > > > On 3/12/2024 5:13 PM, Douglas Anderson wrote: > > As documented in the description of the transfer() function of > > "struct drm_dp_aux", the transfer() function can be called at any time > > regardless of the state of the DP port.

Re: [PATCH] drm/panel: atna33xc20: Fix unbalanced regulator in the case HPD doesn't assert

2024-03-14 Thread Jessica Zhang
On 3/13/2024 2:12 PM, Douglas Anderson via B4 Relay wrote: From: Douglas Anderson When the atna33xc20 driver was first written the resume code never returned an error. If there was a problem waiting for HPD it just printed a warning and moved on. This changed in response to review feedback

Re: [PATCH] drm/i915/guc: Update w/a 14019159160

2024-03-14 Thread Matt Roper
On Tue, Mar 12, 2024 at 04:43:06PM -0700, John Harrison wrote: > On 3/12/2024 09:24, Matt Roper wrote: > > On Thu, Mar 07, 2024 at 06:01:29PM -0800, john.c.harri...@intel.com wrote: > > > From: John Harrison > > > > > > An existing workaround has been extended in both platforms affected > > >

Time for drm-ci-next?

2024-03-14 Thread Rob Clark
When we first merged drm/ci I was unsure if it would need it's own -next branch. But after using it for a couple releases, a few times I've found myself wanting to backmerge drm/ci changes without necessarily backmerging all of drm-misc-next. So, maybe it makes some sense to have a drm-ci-next

RE: [PATCH v2 8/8] drm: xlnx: Intoduce TPG CRTC driver

2024-03-14 Thread Klymenko, Anatoliy
Hi Maxime, Thank you for the review. > -Original Message- > From: Maxime Ripard > Sent: Thursday, March 14, 2024 5:05 AM > To: Klymenko, Anatoliy > Cc: Laurent Pinchart ; Maarten Lankhorst > ; Thomas Zimmermann > ; David Airlie ; Daniel Vetter > ; Simek, Michal ; Andrzej Hajda > ; Neil

Re: [PATCH 1/6] auxdisplay/ht16k33: Replace use of fb_blank with backlight helper

2024-03-14 Thread Miguel Ojeda
On Thu, Mar 14, 2024 at 9:09 AM Thomas Zimmermann wrote: > > As Sam already said, it doesn't seem to make different in practice. I'd > mention it in the commit message and that's it. Ok? Yeah, that is what I meant -- thanks a lot! Reviewed-by: Miguel Ojeda Cheers, Miguel

Re: [PATCH 1/6] auxdisplay/ht16k33: Replace use of fb_blank with backlight helper

2024-03-14 Thread Miguel Ojeda
On Wed, Mar 13, 2024 at 6:54 PM Sam Ravnborg wrote: > > The driver does not set BL_CORE_SUSPENDRESUME so that part is a nop. The driver may not set it now, but it is still not the same logic (and unless I am missing something it would not generate the same code either, so not sure I would say it

Re: [PATCH] drm/amdgpu: fix deadlock while reading mqd from debugfs

2024-03-14 Thread Johannes Weiner
Hello, On Fri, Mar 08, 2024 at 12:32:33PM +0100, Christian König wrote: > Am 07.03.24 um 23:07 schrieb Johannes Weiner: > > Lastly I went with an open loop instead of a memcpy() as I wasn't > > sure if that memory is safe to address a byte at at time. Shashank pointed out to me in private that

Re: [FYI][PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-03-14 Thread Steven Rostedt
On Thu, 14 Mar 2024 09:57:57 -0700 Alison Schofield wrote: > On Fri, Feb 23, 2024 at 12:56:34PM -0500, Steven Rostedt wrote: > > From: "Steven Rostedt (Google)" > > > > [ > >This is a treewide change. I will likely re-create this patch again in > >the second week of the merge window of

Re: [PATCH 1/2] drm/amdgpu: add the IP information of the soc

2024-03-14 Thread Alex Deucher
On Thu, Mar 14, 2024 at 12:16 PM Khatri, Sunil wrote: > > > On 3/14/2024 8:12 PM, Alex Deucher wrote: > > On Thu, Mar 14, 2024 at 1:44 AM Khatri, Sunil wrote: > >> > >> On 3/14/2024 1:58 AM, Alex Deucher wrote: > >>> On Tue, Mar 12, 2024 at 8:41 AM Sunil Khatri wrote: > Add all the IP's

Re: [PATCH] drm/sun4i: tcon: Support keeping dclk rate upon ancestor clock changes

2024-03-14 Thread Jernej Škrabec
Dne četrtek, 14. marec 2024 ob 15:42:24 CET je Maxime Ripard napisal(a): > Hi, > > On Sun, Mar 10, 2024 at 02:32:29PM +0100, Frank Oltmanns wrote: > > Allow the dclk to reset its rate when a rate change is initiated from an > > ancestor clock. This makes it possible to no longer to get an

Re: [FYI][PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-03-14 Thread Alison Schofield
On Fri, Feb 23, 2024 at 12:56:34PM -0500, Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > [ >This is a treewide change. I will likely re-create this patch again in >the second week of the merge window of v6.9 and submit it then. Hoping >to keep the conflicts that it will

[PATCH][next] drm/gma500: Fix spelling mistake "patter" -> "pattern"

2024-03-14 Thread Colin Ian King
There is a spelling mistake in a DRM_DEBUG_KMS message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/gma500/cdv_intel_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/gma500/cdv_intel_dp.c b/drivers/gpu/drm/gma500/cdv_intel_dp.c index

Re: [PATCH] drm/msm/dp: move link_ready out of HPD event thread

2024-03-14 Thread Abhinav Kumar
On 3/14/2024 8:38 AM, Johan Hovold wrote: On Wed, Mar 13, 2024 at 10:24:08AM -0700, Abhinav Kumar wrote: On 3/13/2024 1:18 AM, Johan Hovold wrote: Right, but your proposed fix would not actually fix anything and judging from the sparse commit message and diff itself it is clearly only

Re: [PATCH 1/2] drm/amdgpu: add the IP information of the soc

2024-03-14 Thread Khatri, Sunil
On 3/14/2024 8:12 PM, Alex Deucher wrote: On Thu, Mar 14, 2024 at 1:44 AM Khatri, Sunil wrote: On 3/14/2024 1:58 AM, Alex Deucher wrote: On Tue, Mar 12, 2024 at 8:41 AM Sunil Khatri wrote: Add all the IP's information on a SOC to the devcoredump. Signed-off-by: Sunil Khatri ---

Re: [PATCH] drm/i915/gt: Report full vm address range

2024-03-14 Thread Nirmoy Das
On 3/14/2024 3:04 PM, Lionel Landwerlin wrote: Hi Andi, In Mesa we've been relying on I915_CONTEXT_PARAM_GTT_SIZE so as long as that is adjusted by the kernel What do you mean by adjusted by, should it be a aligned size? I915_CONTEXT_PARAM_GTT_SIZE ioctl is returning vm->total which is

Re: [RFC PATCH v4 25/42] drm/vkms: Add tests for CTM handling

2024-03-14 Thread Pekka Paalanen
On Mon, 26 Feb 2024 16:10:39 -0500 Harry Wentland wrote: > A whole slew of tests for CTM handling that greatly helped in > debugging the CTM code. The extent of tests might seem a bit > silly but they're fast and might someday help save someone > else's day when debugging this. > > v4: > -

[PATCH] gpu: host1x: Do not setup DMA for virtual devices

2024-03-14 Thread Thierry Reding
From: Thierry Reding The host1x devices are virtual compound devices and do not perform DMA accesses themselves, so they do not need to be set up for DMA. Ideally we would also not need to set up DMA masks for the virtual devices, but we currently still need those for legacy support on old

Re: [PATCH] drm/msm/dp: move link_ready out of HPD event thread

2024-03-14 Thread Johan Hovold
On Wed, Mar 13, 2024 at 10:24:08AM -0700, Abhinav Kumar wrote: > On 3/13/2024 1:18 AM, Johan Hovold wrote: > > Right, but your proposed fix would not actually fix anything and judging > > from the sparse commit message and diff itself it is clearly only meant > > to mitigate the case where user

Re: [RFC PATCH v4 24/42] drm/tests: Add a few tests around drm_fixed.h

2024-03-14 Thread Pekka Paalanen
On Mon, 26 Feb 2024 16:10:38 -0500 Harry Wentland wrote: > While working on the CTM implementation of VKMS I had to ascertain > myself of a few assumptions. One of those is whether drm_fixed.h > treats its numbers using signed-magnitude or twos-complement. It is > twos-complement. > > In order

Re: [PATCH v6 0/5] Match panel with identity

2024-03-14 Thread Doug Anderson
Hi, On Thu, Mar 7, 2024 at 3:07 PM Hsin-Yi Wang wrote: > > This series is a follow up for 1a5e81de180e ("Revert "drm/panel-edp: Add > auo_b116xa3_mode""). It's found that 2 different AUO panels use the same > product id. One of them requires an overridden mode, while the other should > use the

Re: [PATCH] drm/amdgpu: fix deadlock while reading mqd from debugfs

2024-03-14 Thread Sharma, Shashank
+ Johannes Regards Shashank On 13/03/2024 18:22, Sharma, Shashank wrote: Hello Johannes, On 07/03/2024 23:07, Johannes Weiner wrote: An errant disk backup on my desktop got into debugfs and triggered the following deadlock scenario in the amdgpu debugfs files. The machine also hard-resets

Re: [PATCH][next] drm/msm: remove unused variable 'out'

2024-03-14 Thread Doug Anderson
Hi, On Thu, Mar 7, 2024 at 1:37 AM Colin Ian King wrote: > > The variable out is being initialized and incremented but it is never > actually referenced in any other way. The variable is redundant and can > be removed. > > Cleans up clang scan build warning: >

Re: [PATCH 00/14] Add support for suppressing warning backtraces

2024-03-14 Thread Guenter Roeck
On 3/14/24 08:02, Maxime Ripard wrote: On Thu, Mar 14, 2024 at 07:37:13AM -0700, Guenter Roeck wrote: On 3/14/24 06:36, Geert Uytterhoeven wrote: Hi Günter, On Tue, Mar 12, 2024 at 6:03 PM Guenter Roeck wrote: Some unit tests intentionally trigger warning backtraces by passing bad

Re: [RFC PATCH v4 23/42] drm/vkms: add 3x4 matrix in color pipeline

2024-03-14 Thread Pekka Paalanen
On Mon, 26 Feb 2024 16:10:37 -0500 Harry Wentland wrote: > We add two 3x4 matrices into the VKMS color pipeline. The reason > we're adding matrices is so that we can test that application > of a matrix and its inverse yields an output equal to the input > image. You will test also cases where

Re: arm: ERROR: modpost: "__aeabi_uldivmod" [drivers/gpu/drm/sun4i/sun4i-drm-hdmi.ko] undefined!

2024-03-14 Thread Maxime Ripard
On Thu, Mar 14, 2024 at 10:27:23AM +0100, Geert Uytterhoeven wrote: > On Sat, Mar 9, 2024 at 3:34 PM David Laight wrote: > > From: Maxime Ripard > > > Sent: 04 March 2024 11:46 > > > > > > On Mon, Mar 04, 2024 at 12:11:36PM +0100, Arnd Bergmann wrote: > > > > On Mon, Mar 4, 2024, at 09:07, Naresh

Re: [PATCH 00/14] Add support for suppressing warning backtraces

2024-03-14 Thread Maxime Ripard
On Thu, Mar 14, 2024 at 07:37:13AM -0700, Guenter Roeck wrote: > On 3/14/24 06:36, Geert Uytterhoeven wrote: > > Hi Günter, > > > > On Tue, Mar 12, 2024 at 6:03 PM Guenter Roeck wrote: > > > Some unit tests intentionally trigger warning backtraces by passing bad > > > parameters to kernel API

Re: [PATCH] drm/sun4i: tcon: Support keeping dclk rate upon ancestor clock changes

2024-03-14 Thread Maxime Ripard
Hi, On Sun, Mar 10, 2024 at 02:32:29PM +0100, Frank Oltmanns wrote: > Allow the dclk to reset its rate when a rate change is initiated from an > ancestor clock. This makes it possible to no longer to get an exclusive > lock. As a consequence, it is now possible to set new rates if > necessary,

Re: [PATCH 1/2] drm/amdgpu: add the IP information of the soc

2024-03-14 Thread Alex Deucher
On Thu, Mar 14, 2024 at 1:44 AM Khatri, Sunil wrote: > > > On 3/14/2024 1:58 AM, Alex Deucher wrote: > > On Tue, Mar 12, 2024 at 8:41 AM Sunil Khatri wrote: > >> Add all the IP's information on a SOC to the > >> devcoredump. > >> > >> Signed-off-by: Sunil Khatri > >> --- > >>

Re: [PATCH v5 11/16] drm/vkms: Add YUV support

2024-03-14 Thread Louis Chauvet
Le 13/03/24 - 12:20, Randy Dunlap a écrit : > Hi, > > On 3/13/24 10:45, Louis Chauvet wrote: > > From: Arthur Grillo > > > > > > > Signed-off-by: Arthur Grillo > > [Louis Chauvet: > > - Adapted Arthur's work > > - Implemented the read_line_t callbacks for yuv > > - add struct

RE: [PATCH v2] drm/amdgpu: Clear the hotplug interrupt ack bit before hpd initialization

2024-03-14 Thread Deucher, Alexander
[Public] > -Original Message- > From: Qiang Ma > Sent: Wednesday, March 13, 2024 2:18 AM > To: Deucher, Alexander ; Koenig, Christian > ; Pan, Xinhui ; > airl...@gmail.com; dan...@ffwll.ch; SHANMUGAM, SRINIVASAN > ; sunran...@208suo.com > Cc: amd-...@lists.freedesktop.org;

Re: [PATCH 00/14] Add support for suppressing warning backtraces

2024-03-14 Thread Guenter Roeck
On 3/14/24 06:36, Geert Uytterhoeven wrote: Hi Günter, On Tue, Mar 12, 2024 at 6:03 PM Guenter Roeck wrote: Some unit tests intentionally trigger warning backtraces by passing bad parameters to kernel API functions. Such unit tests typically check the return value from such calls, not the

Re: [RFC PATCH 2/3] drm/tidss: Add support for display sharing

2024-03-14 Thread Maxime Ripard
Hi, On Wed, Feb 14, 2024 at 09:17:12PM +0530, Devarsh Thakkar wrote: > On 13/02/24 19:34, Maxime Ripard wrote: > > On Thu, Feb 08, 2024 at 06:26:17PM +0530, Devarsh Thakkar wrote: > >> On 26/01/24 17:45, Maxime Ripard wrote: > >>> Hi, > >>> > >>> Thanks a lot for working on that. > >>> > >>> On

Re: [PATCH v9 1/9] drm/panic: Add drm panic locking

2024-03-14 Thread Daniel Vetter
On Fri, Mar 08, 2024 at 02:45:52PM +0100, Thomas Zimmermann wrote: > Hi > > Am 07.03.24 um 10:14 schrieb Jocelyn Falempe: > > From: Daniel Vetter > > > > Rough sketch for the locking of drm panic printing code. The upshot of > > this approach is that we can pretty much entirely rely on the

Re: [RFC] drm/panic: Add drm panic locking

2024-03-14 Thread Daniel Vetter
On Fri, Mar 01, 2024 at 02:03:12PM +0100, Jocelyn Falempe wrote: > Thanks for the patch. > > I think it misses to initialize the lock, so we need to add a > raw_spin_lock_init() in the drm device initialization. > > Also I'm wondering if it make sense to put that under the CONFIG_DRM_PANIC >

Re: [RFC] drm/panic: Add drm panic locking

2024-03-14 Thread Daniel Vetter
On Tue, Mar 05, 2024 at 09:20:04AM +0106, John Ogness wrote: > Hi Daniel, > > Great to see this moving forward! > > On 2024-03-01, Daniel Vetter wrote: > > But for the initial cut of a drm panic printing support I don't think > > we need that, because the critical sections are extremely small

Re: [PATCH] drm/i915/gt: Report full vm address range

2024-03-14 Thread Lionel Landwerlin
Hi Andi, In Mesa we've been relying on I915_CONTEXT_PARAM_GTT_SIZE so as long as that is adjusted by the kernel, we should be able to continue working without issues. Acked-by: Lionel Landwerlin Thanks, -Lionel On 13/03/2024 21:39, Andi Shyti wrote: Commit 9bb66c179f50 ("drm/i915:

Re: [PATCH 11/14] s390: Add support for suppressing warning backtraces

2024-03-14 Thread Guenter Roeck
On 3/14/24 00:57, Geert Uytterhoeven wrote: Hi Günter, On Tue, Mar 12, 2024 at 6:06 PM Guenter Roeck wrote: Add name of functions triggering warning backtraces to the __bug_table object section to enable support for suppressing WARNING backtraces. To limit image size impact, the pointer to

Re: [RFC PATCH v4 01/42] drm: Don't treat 0 as -1 in drm_fixp2int_ceil

2024-03-14 Thread Melissa Wen
On 02/26, Harry Wentland wrote: > Unit testing this in VKMS shows that passing 0 into > this function returns -1, which is highly counter- > intuitive. Fix it by checking whether the input is > >= 0 instead of > 0. > > Fixes: 64566b5e767f9 ("drm: Add drm_fixp_from_fraction and drm_fixp2int_ceil")

[PATCH v2] fbdev: uvesafb: Convert sprintf/snprintf to sysfs_emit

2024-03-14 Thread Li Zhijian
Per filesystems/sysfs.rst, show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. coccinelle complains that there are still a couple of functions that use snprintf(). Convert them to sysfs_emit(). sprintf() will be converted as weel if they

Re: [PATCH 1/7] drm: Fix drm_fixp2int_round() making it add 0.5

2024-03-14 Thread Harry Wentland
On 2024-03-14 09:31, Melissa Wen wrote: > On 03/14, Melissa Wen wrote: >> On 03/13, Arthur Grillo wrote: >>> >>> >>> On 12/03/24 15:27, Melissa Wen wrote: On 03/06, Arthur Grillo wrote: > As well noted by Pekka[1], the rounding of drm_fixp2int_round is wrong. > To round a number,

Re: [PATCH 00/14] Add support for suppressing warning backtraces

2024-03-14 Thread Geert Uytterhoeven
Hi Günter, On Tue, Mar 12, 2024 at 6:03 PM Guenter Roeck wrote: > Some unit tests intentionally trigger warning backtraces by passing bad > parameters to kernel API functions. Such unit tests typically check the > return value from such calls, not the existence of the warning backtrace. > > Such

Re: [PATCH 1/7] drm: Fix drm_fixp2int_round() making it add 0.5

2024-03-14 Thread Melissa Wen
On 03/14, Melissa Wen wrote: > On 03/13, Arthur Grillo wrote: > > > > > > On 12/03/24 15:27, Melissa Wen wrote: > > > On 03/06, Arthur Grillo wrote: > > >> As well noted by Pekka[1], the rounding of drm_fixp2int_round is wrong. > > >> To round a number, you need to add 0.5 to the number and

Re: [PATCH 1/7] drm: Fix drm_fixp2int_round() making it add 0.5

2024-03-14 Thread Pekka Paalanen
On Thu, 14 Mar 2024 09:59:39 -0300 Melissa Wen wrote: > On 03/13, Arthur Grillo wrote: > > > > > > On 12/03/24 15:27, Melissa Wen wrote: > > > On 03/06, Arthur Grillo wrote: > > >> As well noted by Pekka[1], the rounding of drm_fixp2int_round is wrong. > > >> To round a number, you need to

Re: [PATCH 2/2] drm:amdgpu: add firmware information of all IP's

2024-03-14 Thread Alex Deucher
On Thu, Mar 14, 2024 at 2:10 AM Sharma, Shashank wrote: > > > On 14/03/2024 06:58, Khatri, Sunil wrote: > > > > On 3/14/2024 2:06 AM, Alex Deucher wrote: > >> On Tue, Mar 12, 2024 at 8:42 AM Sunil Khatri > >> wrote: > >>> Add firmware version information of each > >>> IP and each instance where

Re: [RFC PATCH v4 02/42] drm: Add helper for conversion from signed-magnitude

2024-03-14 Thread Melissa Wen
On 02/26, Harry Wentland wrote: > CTM values are defined as signed-magnitude values. Add > a helper that converts from CTM signed-magnitude fixed > point value to the twos-complement value used by > drm_fixed. > > Signed-off-by: Harry Wentland > --- > include/drm/drm_fixed.h | 18

Re: [PATCH 1/7] drm: Fix drm_fixp2int_round() making it add 0.5

2024-03-14 Thread Melissa Wen
On 03/13, Arthur Grillo wrote: > > > On 12/03/24 15:27, Melissa Wen wrote: > > On 03/06, Arthur Grillo wrote: > >> As well noted by Pekka[1], the rounding of drm_fixp2int_round is wrong. > >> To round a number, you need to add 0.5 to the number and floor that, > >> drm_fixp2int_round() is adding

RE: [PATCH 6/6] backlight: Remove fb_blank from struct backlight_properties

2024-03-14 Thread FLAVIO SULIGOI
Hi Thomas, ... > drivers/video/backlight/mp3309c.c | 1 - ... > diff --git a/drivers/video/backlight/mp3309c.c > b/drivers/video/backlight/mp3309c.c > index 34d71259fac1d..059f4ddbbc842 100644 > --- a/drivers/video/backlight/mp3309c.c > +++ b/drivers/video/backlight/mp3309c.c > @@

Re: [PATCH] drm/sun4i: hdmi: Fix u64 div on 32bit arch

2024-03-14 Thread Maxime Ripard
On Mon, 04 Mar 2024 10:12:25 +0100, Maxime Ripard wrote: > Commit 358e76fd613a ("drm/sun4i: hdmi: Consolidate atomic_check and > mode_valid") changed the clock rate from an unsigned long to an unsigned > long long resulting in a a 64-bit division that might not be supported > on all platforms. >

Re: [PATCH 0/6] drm: debug logging improvements

2024-03-14 Thread Jani Nikula
On Thu, 07 Mar 2024, Jani Nikula wrote: > Switch a handful of places over to drm device based logging and WARNs, > unify connector and crtc logging, etc. Ping for review, please. :) > > Jani Nikula (6): > drm/modes: add drm_mode_print() to dump mode in drm_printer > drm/probe-helper:

Re: [PATCH v2 8/8] drm: xlnx: Intoduce TPG CRTC driver

2024-03-14 Thread Maxime Ripard
Hi, On Tue, Mar 12, 2024 at 05:55:05PM -0700, Anatoliy Klymenko wrote: > DO NOT MERGE. REFERENCE ONLY. > > Add CRTC driver based on AMD/Xilinx Video Test Pattern Generator IP. TPG > based FPGA design represents minimalistic harness useful for testing links > between FPGA based CRTC and external

Re: [PATCH 3/3] accel/qaic: Add fifo queued debugfs

2024-03-14 Thread Jacek Lawrynowicz
Reviewed-by: Jacek Lawrynowicz On 11.03.2024 17:58, Jeffrey Hugo wrote: > When debugging functional issues with workload input processing, it is > useful to know if requests are backing up in the fifo, or perhaps > getting stuck elsewhere. To answer the question of how many requests are > in the

Re: [PATCH 2/3] accel/qaic: Add fifo size debugfs

2024-03-14 Thread Jacek Lawrynowicz
Reviewed-by: Jacek Lawrynowicz On 11.03.2024 17:58, Jeffrey Hugo wrote: > Each DMA Bridge Channel (dbc) has a unique configured fifo size which is > specified by the userspace client of that dbc. Since the fifo is > circular, it is useful to know the configured size when debugging > issues. > >

Re: [PATCH 1/3] accel/qaic: Add bootlog debugfs

2024-03-14 Thread Jacek Lawrynowicz
Hi, On 11.03.2024 17:58, Jeffrey Hugo wrote: > During the boot process of AIC100, the bootloaders (PBL and SBL) log > messages to device RAM. During SBL, if the host opens the QAIC_LOGGING > channel, SBL will offload the contents of the log buffer to the host, > and stream any new messages that

[PATCH v2] backlight: lp8788: Drop support for platform data

2024-03-14 Thread Uwe Kleine-König
The backlight driver supports getting passed platform data. However this isn't used. This allows to remove quite some dead code from the driver because bl->pdata is always NULL, and so bl->mode is always LP8788_BL_REGISTER_ONLY. Signed-off-by: Uwe Kleine-König --- Changes since (implicit) v1

[PATCH] drm/edid: make drm_edid_are_equal() static

2024-03-14 Thread Jani Nikula
drm_edid_are_equal() is only used within drm_edid.c. Make it static. Do not encourage more uses of struct edid. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 3 +-- include/drm/drm_edid.h | 2 -- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git

Re: arm: ERROR: modpost: "__aeabi_uldivmod" [drivers/gpu/drm/sun4i/sun4i-drm-hdmi.ko] undefined!

2024-03-14 Thread Geert Uytterhoeven
On Thu, Mar 14, 2024 at 10:27 AM Geert Uytterhoeven wrote: > On Sat, Mar 9, 2024 at 3:34 PM David Laight wrote: > > From: Maxime Ripard > > > Sent: 04 March 2024 11:46 > > > > > > On Mon, Mar 04, 2024 at 12:11:36PM +0100, Arnd Bergmann wrote: > > > > On Mon, Mar 4, 2024, at 09:07, Naresh Kamboju

Re: [PATCH v3] Fix divide-by-zero regression on DP MST unplug with nouveau

2024-03-14 Thread Imre Deak
On Wed, Mar 13, 2024 at 10:06:30PM +, Chris Bainbridge wrote: > Fix a regression when using nouveau and unplugging a StarTech MSTDP122DP > DisplayPort 1.2 MST hub (the same regression does not appear when using > a Cable Matters DisplayPort 1.4 MST hub). Trace: > > divide error: [#1]

Re: [PATCH] backlight: lp8788: Drop support for platform data

2024-03-14 Thread Uwe Kleine-König
Hey Lee, On Thu, Mar 14, 2024 at 10:20:35AM +, Lee Jones wrote: > On Wed, 13 Mar 2024, Uwe Kleine-König wrote: > > On Wed, Mar 13, 2024 at 01:48:27PM +0100, Uwe Kleine-König wrote: > > > struct lp8788_bl { > > > struct lp8788 *lp; > > > struct backlight_device *bl_dev; > > > - struct

Re: [PATCH] m68k: pgtable: Add missing #include

2024-03-14 Thread Jani Nikula
On Thu, 07 Mar 2024, Jani Nikula wrote: > On Thu, 07 Mar 2024, Geert Uytterhoeven wrote: >> When just including : >> >> include/asm-generic/pgtable-nop4d.h:9:18: error: unknown type name >> ‘pgd_t’ >> 9 | typedef struct { pgd_t pgd; } p4d_t; >>| ^ >> >>

Re: [PATCH] backlight: lp8788: Drop support for platform data

2024-03-14 Thread Lee Jones
On Wed, 13 Mar 2024, Uwe Kleine-König wrote: > Hello, > > On Wed, Mar 13, 2024 at 01:48:27PM +0100, Uwe Kleine-König wrote: > > diff --git a/drivers/video/backlight/lp8788_bl.c > > b/drivers/video/backlight/lp8788_bl.c > > index 31f97230ee50..f3a89677c31c 100644 > > ---

Re: [PATCH v2] drm: Document requirements for driver-specific KMS props in new drivers

2024-03-14 Thread Maxime Ripard
On Mon, Mar 11, 2024 at 04:58:58PM +0100, Sebastian Wick wrote: > When extending support for a driver-specific KMS property to additional > drivers, we should apply all the requirements for new properties and > make sure the semantics are the same and documented. > > v2: devs of the driver which

Re: [PATCH 0/2] drm/fourcc.h: Add libcamera to Open Source Waiver

2024-03-14 Thread Jacopo Mondi
Hello gentle nudge for *) libcamera: are we ok being listed here ? *) DRM/KMS: is it ok splitting the list of projects in the way I've done ? Thanks j On Wed, Feb 28, 2024 at 11:22:42AM +0100, Jacopo Mondi wrote: > As suggested by Sima, add libcamera to the list of projects to which the

Re: [PATCH] mediatek: dsi: Add dsi per-frame lp code for mt8188

2024-03-14 Thread AngeloGioacchino Del Regno
Il 14/03/24 10:41, Shuijing Li ha scritto: Adding the per-frame lp function of mt8188, which can keep HFP in HS and reduce the time required for each line to enter and exit low power. Per Frame LP: |<--One Active Frame>|

Re: drm-misc migration to Gitlab server

2024-03-14 Thread Stephen Rothwell
Hi Maxime, On Thu, 14 Mar 2024 09:39:24 +0100 Maxime Ripard wrote: > > We've migrated the drm-misc repo to: > https://gitlab.freedesktop.org/drm/misc/kernel.git > > The branch names are the same I have switched over for tomorrow and test fetches work fine. -- Cheers, Stephen Rothwell

Re: [PATCH 3/6] backlight/omap1-bl: Replace FB_BLANK_ states with simple on/off

2024-03-14 Thread Dan Carpenter
On Thu, Mar 14, 2024 at 09:16:15AM +0100, Thomas Zimmermann wrote: > Hi > > Am 13.03.24 um 19:00 schrieb Sam Ravnborg: > > Hi Thomas, > > > > On Wed, Mar 13, 2024 at 04:45:02PM +0100, Thomas Zimmermann wrote: > > > The backlight is on for fb_blank eq FB_BLANK_UNBLANK, or off for > > > any other

Re: [PATCH 2/2] drm:amdgpu: add firmware information of all IP's

2024-03-14 Thread Khatri, Sunil
On 3/14/2024 11:40 AM, Sharma, Shashank wrote: On 14/03/2024 06:58, Khatri, Sunil wrote: On 3/14/2024 2:06 AM, Alex Deucher wrote: On Tue, Mar 12, 2024 at 8:42 AM Sunil Khatri wrote: Add firmware version information of each IP and each instance where applicable. Is there a way we can

[PATCH] mediatek: dsi: Add dsi per-frame lp code for mt8188

2024-03-14 Thread Shuijing Li
Adding the per-frame lp function of mt8188, which can keep HFP in HS and reduce the time required for each line to enter and exit low power. Per Frame LP: |<--One Active Frame>| --_____

Re: [PATCH] drm/scheduler: fix null-ptr-deref in init entity

2024-03-14 Thread Christian König
Am 13.03.24 um 22:20 schrieb vitaly.pros...@amd.com: From: Vitaly Prosyak The bug can be triggered by sending an amdgpu_cs_wait_ioctl to the AMDGPU DRM driver on any ASICs with valid context. The bug was reported by Joonkyo Jung . For example the following code: static void

Re: arm: ERROR: modpost: "__aeabi_uldivmod" [drivers/gpu/drm/sun4i/sun4i-drm-hdmi.ko] undefined!

2024-03-14 Thread Geert Uytterhoeven
On Sat, Mar 9, 2024 at 3:34 PM David Laight wrote: > From: Maxime Ripard > > Sent: 04 March 2024 11:46 > > > > On Mon, Mar 04, 2024 at 12:11:36PM +0100, Arnd Bergmann wrote: > > > On Mon, Mar 4, 2024, at 09:07, Naresh Kamboju wrote: > > > > The arm defconfig builds failed on today's Linux next

Re: [PATCH v4 0/3] Add minimal XDP support to TI AM65 CPSW Ethernet driver

2024-03-14 Thread Ratheesh Kannoth
On 2024-03-12 at 18:52:39, Julien Panis (jpa...@baylibre.com) wrote: > This patch adds XDP support to TI AM65 CPSW Ethernet driver. is this a net-next item ? > > The following features are implemented: NETDEV_XDP_ACT_BASIC, > NETDEV_XDP_ACT_REDIRECT, and NETDEV_XDP_ACT_NDO_XMIT. > > Zero-copy

RE: [EXTERNAL] Re: [PATCH v4 0/3] Add minimal XDP support to TI AM65 CPSW Ethernet driver

2024-03-14 Thread Ratheesh Kannoth
> From: Julien Panis > Sent: Wednesday, March 13, 2024 7:34 PM > On 3/13/24 14:44, Ratheesh Kannoth wrote: > > On 2024-03-12 at 18:52:39, Julien Panis (jpa...@baylibre.com) wrote: > >> This patch adds XDP support to TI AM65 CPSW Ethernet driver. > > is this a net-next item ? > > Initially I

Re: [PATCH v18 8/9] drm/i915/display: Compute vrr_vsync params

2024-03-14 Thread Nautiyal, Ankit K
On 3/13/2024 9:26 AM, Mitul Golani wrote: Compute vrr_vsync_start/end, which sets the position for hardware to send the Vsync at a fixed position relative to the end of the Vblank. --v2: - Updated VSYNC_START/END macros to VRR_VSYNC_START/END. (Ankit) - Updated bit fields of

Re: [PATCH 3/6] backlight/omap1-bl: Replace FB_BLANK_ states with simple on/off

2024-03-14 Thread Sam Ravnborg
On Thu, Mar 14, 2024 at 09:16:15AM +0100, Thomas Zimmermann wrote: > Hi > > Am 13.03.24 um 19:00 schrieb Sam Ravnborg: > > Hi Thomas, > > > > On Wed, Mar 13, 2024 at 04:45:02PM +0100, Thomas Zimmermann wrote: > > > The backlight is on for fb_blank eq FB_BLANK_UNBLANK, or off for > > > any other

Re: drm-misc migration to Gitlab server

2024-03-14 Thread Maxime Ripard
Hi Stephen, On Wed, Feb 21, 2024 at 09:46:43AM +1100, Stephen Rothwell wrote: > Hi Daniel, > > On Tue, 20 Feb 2024 11:25:05 + Daniel Stone wrote: > > > > On Tue, 20 Feb 2024 at 09:05, Maxime Ripard wrote: > > > On Tue, Feb 20, 2024 at 09:49:25AM +0100, Maxime Ripard wrote: > > > > This

Re: [PATCH 1/6] auxdisplay/ht16k33: Replace use of fb_blank with backlight helper

2024-03-14 Thread Geert Uytterhoeven
On Wed, Mar 13, 2024 at 4:49 PM Thomas Zimmermann wrote: > Replace the use of struct backlight_properties.fb_blank with a > call to backlight_get_brightness(). The helper implement the same > logic as the driver's function. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Geert Uytterhoeven

Re: [git pull] drm for 6.9-rc1

2024-03-14 Thread Jani Nikula
On Thu, 14 Mar 2024, Dave Airlie wrote: > On Thu, 14 Mar 2024 at 11:49, Linus Torvalds > wrote: >> >> On Tue, 12 Mar 2024 at 21:07, Dave Airlie wrote: >> > >> > I've done a trial merge into your tree from a few hours ago, there >> > are definitely some slighty messy conflicts, I've pushed a

[PULL] drm-misc-next-fixes

2024-03-14 Thread Thomas Zimmermann
Hi Dave, Sima, here's the PR for drm-misc-next-fixes for this week. There's a fix for nouveau BOs and quite a few fixes for get_modes() functions. Best regards Thomas drm-misc-next-fixes-2024-03-14: Short summary of fixes pull: probe-helper: - never return negative values from .get_modes()

Re: [PATCH 3/6] backlight/omap1-bl: Replace FB_BLANK_ states with simple on/off

2024-03-14 Thread Thomas Zimmermann
Hi Am 13.03.24 um 19:00 schrieb Sam Ravnborg: Hi Thomas, On Wed, Mar 13, 2024 at 04:45:02PM +0100, Thomas Zimmermann wrote: The backlight is on for fb_blank eq FB_BLANK_UNBLANK, or off for any other value in fb_blank. But the field fb_blank in struct backlight_properties is deprecated and

Re: [PATCH] vmwgfx: Create debugfs ttm_resource_manager entry only if needed

2024-03-14 Thread Jocelyn Falempe
On 13/03/2024 18:57, Zack Rusin wrote: On Tue, Mar 12, 2024 at 5:36 AM Jocelyn Falempe wrote: [...] Thanks! That looks great. I can push it through drm-misc-fixes. Thanks, I think I only forget the "drm/" in the commit title, but yes you can push it with this small correction.

Re: [PATCH 1/6] auxdisplay/ht16k33: Replace use of fb_blank with backlight helper

2024-03-14 Thread Thomas Zimmermann
Hi Am 13.03.24 um 17:08 schrieb Miguel Ojeda: Hi Thomas, Thanks for this! Cc'ing Andy and Geert -- the new maintainer and reviewer. Ah, sorry. They are not yet in my MAINTAINERS file. Also, a couple quick notes below since I am here... On Wed, Mar 13, 2024 at 4:49 PM Thomas Zimmermann

Re: [v4,08/13] drm/msm/dpu: add support for virtual planes

2024-03-14 Thread Sui Jingfeng
Hi, On 2024/3/14 08:02, Dmitry Baryshkov wrote: [...] +/** + * dpu_rm_reserve_sspp - Reserve the required SSPP for the provided CRTC + * @rm: DPU Resource Manager handle + * @global_state: private global state + * @crtc: DRM CRTC handle + * @reqs: SSPP required features + */ +struct

Re: [PATCH 11/14] s390: Add support for suppressing warning backtraces

2024-03-14 Thread Geert Uytterhoeven
Hi Günter, On Tue, Mar 12, 2024 at 6:06 PM Guenter Roeck wrote: > Add name of functions triggering warning backtraces to the __bug_table > object section to enable support for suppressing WARNING backtraces. > > To limit image size impact, the pointer to the function name is only added > to the

Re: [PATCH 11/11] drm/mediatek: Rename "pending_needs_vblank" to "needs_vblank"

2024-03-14 Thread 胡俊光

Re: [PATCH 00/14] Add support for suppressing warning backtraces

2024-03-14 Thread Naresh Kamboju
On Tue, 12 Mar 2024 at 22:33, Guenter Roeck wrote: > This series is based on the RFC patch and subsequent discussion at > https://patchwork.kernel.org/project/linux-kselftest/patch/02546e59-1afe-4b08-ba81-d94f3b691c9a@moroto.mountain/ > and offers a more comprehensive solution of the problem

Re: [PATCH 10/11] drm/mediatek: Rename mtk_ddp_comp functions

2024-03-14 Thread 胡俊光

Re: [PATCH 09/11] drm/mediatek: Rename files "mtk_drm_gem.*" to "mtk_gem.*"

2024-03-14 Thread 胡俊光

Re: [PATCH 08/11] drm/mediatek: Rename files "mtk_drm_plane.*" to "mtk_plane.*"

2024-03-14 Thread 胡俊光

Re: [PATCH 07/11] drm/mediatek: Rename files "mtk_drm_ddp_comp.*" to "mtk_ddp_comp.*"

2024-03-14 Thread 胡俊光

Re: [PATCH 06/11] drm/mediatek: Rename files "mtk_drm_crtc.*" to "mtk_crtc.*"

2024-03-14 Thread 胡俊光

Re: [PATCH 06/11] drm/mediatek: Rename files "mtk_drm_crtc.*" to "mtk_crtc.*"

2024-03-14 Thread 胡俊光

  1   2   >