Re: [Intel-gfx] [PATCH 4/6] drm: scrambling support in drm layer

On Wed, 2017-02-01 at 18:14 +0530, Shashank Sharma wrote: > HDMI 2.0 spec mandates scrambling for modes with pixel clock higher > than 340Mhz. This patch adds few new functions in drm layer for > core drivers to enable/disable scrambling. > > This patch adds: > - A function to detect scrambling

Re: [Intel-gfx] [PATCH v2 7/9] drm: Connector helper function to release atomic state

On Wed, 2017-01-25 at 07:18 +0100, Daniel Vetter wrote: > On Tue, Jan 24, 2017 at 03:49:35PM -0800, Dhinakaran Pandiyan wrote: > > Having a ->atomic_release callback is useful to release shared resources > > that get allocated in compute_config(). > > > > Suggested-by: Daniel Vetter

Re: [Intel-gfx] [PATCH v2 9/9] drm/dp: Track MST link bandwidth

On Wed, 2017-01-25 at 07:15 +0100, Daniel Vetter wrote: > On Tue, Jan 24, 2017 at 03:49:37PM -0800, Dhinakaran Pandiyan wrote: > > Use the added helpers to track MST link bandwidth for atomic modesets. > > Link bw is acquired in the ->atomic_check() phase when CRTCs are being > > enabled with

Re: [Intel-gfx] [PATCH v2 4/9] drm: Add driver private objects to atomic state

On Wed, 2017-01-25 at 06:59 +0100, Daniel Vetter wrote: > On Tue, Jan 24, 2017 at 03:49:32PM -0800, Dhinakaran Pandiyan wrote: > > It is necessary to track states for objects other than connector, crtc > > and plane for atomic modesets. But adding objects like DP MST link > > bandwidth to

Re: [Intel-gfx] [PATCH v2 7/9] drm: Connector helper function to release atomic state

On Wed, 2017-01-25 at 07:18 +0100, Daniel Vetter wrote: > On Tue, Jan 24, 2017 at 03:49:35PM -0800, Dhinakaran Pandiyan wrote: > > Having a ->atomic_release callback is useful to release shared resources > > that get allocated in compute_config(). > > > > Suggested-by: Daniel Vetter

Re: [Intel-gfx] [PATCH v2 2/9] drm/dp: Kill unused MST vcpi slot availability tracking

On Wed, 2017-01-25 at 06:43 +0100, Daniel Vetter wrote: > On Tue, Jan 24, 2017 at 03:49:30PM -0800, Dhinakaran Pandiyan wrote: > > The avail_slots member in the MST topology manager is never updated to > > reflect the available vcpi slots. The check is effectively against > > total_slots. So,

Re: [Intel-gfx] [PATCH v2 3/9] drm/dp: Split drm_dp_mst_allocate_vcpi

On Wed, 2017-01-25 at 10:31 +1000, Dave Airlie wrote: > On 25 January 2017 at 09:49, Dhinakaran Pandiyan > wrote: > > drm_dp_mst_allocate_vcpi() apart from setting up the vcpi structure, > > also finds if there are enough slots available. This check is a duplicate >

Re: [Intel-gfx] [PATCH v2 8/9] drm/dp: Release DP MST shared link bandwidth

On Wed, 2017-01-25 at 07:16 +0100, Daniel Vetter wrote: > On Tue, Jan 24, 2017 at 03:49:36PM -0800, Dhinakaran Pandiyan wrote: > > Implement the ->atomic_release() callback to release the shared link > > bandwidth that was originally acquired during compute_config() > > > > Signed-off-by:

Re: [Intel-gfx] [PATCH v3 4/8] drm: Add driver-private objects to atomic state

On Fri, 2017-02-17 at 15:37 +0530, Archit Taneja wrote: > > On 02/16/2017 05:43 AM, Pandiyan, Dhinakaran wrote: > > On Wed, 2017-02-15 at 16:53 +0530, Archit Taneja wrote: > >> Hi, > >> > >> On 02/09/2017 12:08 PM, Dhinakaran Pandiyan wrote: > >>>

Re: [Intel-gfx] [PATCH v3 7/8] drm: Connector helper function to release resources

On Thu, 2017-02-16 at 09:09 +, Lankhorst, Maarten wrote: > Daniel Vetter schreef op di 14-02-2017 om 20:51 [+0100]: > > On Mon, Feb 13, 2017 at 10:26 PM, Pandiyan, Dhinakaran > > <dhinakaran.pandi...@intel.com> wrote: > > > On Mon, 2017-02-13 at 09:05 +

Re: [Intel-gfx] [PATCH v3 4/8] drm: Add driver-private objects to atomic state

On Wed, 2017-02-22 at 09:59 +0530, Archit Taneja wrote: > > On 02/22/2017 05:31 AM, Pandiyan, Dhinakaran wrote: > > On Fri, 2017-02-17 at 15:37 +0530, Archit Taneja wrote: > >> > >> On 02/16/2017 05:43 AM, Pandiyan, Dhinakaran wrote: > >>> On Wed, 2017

Re: [Intel-gfx] [PATCH v3 7/8] drm: Connector helper function to release resources

On Mon, 2017-02-13 at 09:05 +, Lankhorst, Maarten wrote: > Pandiyan, Dhinakaran schreef op do 09-02-2017 om 18:55 [+]: > > On Thu, 2017-02-09 at 09:01 +, Lankhorst, Maarten wrote: > > > > > > Dhinakaran Pandiyan schreef op wo 08-02-2017 om 22:38 [-080

Re: [Intel-gfx] [PATCH v3 7/8] drm: Connector helper function to release resources

On Mon, 2017-02-13 at 21:26 +, Pandiyan, Dhinakaran wrote: > On Mon, 2017-02-13 at 09:05 +, Lankhorst, Maarten wrote: > > Pandiyan, Dhinakaran schreef op do 09-02-2017 om 18:55 [+]: > > > On Thu, 2017-02-09 at 09:01 +, Lankhorst, Maarten wrote: > > > >

Re: [Intel-gfx] [PATCH v3 4/8] drm: Add driver-private objects to atomic state

On Thu, 2017-02-09 at 08:08 +, Chris Wilson wrote: > On Wed, Feb 08, 2017 at 10:38:07PM -0800, Dhinakaran Pandiyan wrote: > > +#define for_each_private_obj(__state, obj_funcs, obj, obj_state, __i, > > __funcs) \ > > + for ((__i) = 0; \ > >

Re: [Intel-gfx] [PATCH v3 7/8] drm: Connector helper function to release resources

On Thu, 2017-02-09 at 09:01 +, Lankhorst, Maarten wrote: > Dhinakaran Pandiyan schreef op wo 08-02-2017 om 22:38 [-0800]: > > Having a ->atomic_release callback is useful to release shared > > resources > > that get allocated in compute_config(). This function is expected to > > be > > called

Re: [Intel-gfx] [PATCH v3 7/8] drm: Connector helper function to release resources

On Tue, 2017-02-14 at 20:51 +0100, Daniel Vetter wrote: > On Mon, Feb 13, 2017 at 10:26 PM, Pandiyan, Dhinakaran > <dhinakaran.pandi...@intel.com> wrote: > > On Mon, 2017-02-13 at 09:05 +, Lankhorst, Maarten wrote: > >> Pandiyan, Dhinakaran schreef op do

Re: [Intel-gfx] [PATCH v3 4/8] drm: Add driver-private objects to atomic state

On Wed, 2017-02-15 at 16:53 +0530, Archit Taneja wrote: > Hi, > > On 02/09/2017 12:08 PM, Dhinakaran Pandiyan wrote: > > It is necessary to track states for objects other than connector, crtc > > and plane for atomic modesets. But adding objects like DP MST link > > bandwidth to drm_atomic_state

[Intel-gfx] [PATCH 2/5] drm: Define a work struct for scheduling a uevent for modeset retry

On Mon, 2016-10-24 at 23:28 -0700, Manasi Navare wrote: > On Sat, Oct 22, 2016 at 10:48:13AM +0200, Daniel Vetter wrote: > > On Fri, Oct 21, 2016 at 04:45:40PM -0700, Manasi Navare wrote: > > > This work struct will be used to schedule a uevent on a separate > > > thread. This will be scheduled

[2/9] drm/doc: Polish kerneldoc for encoders

I guess it's too late for review now. But, I want to send this anyway. On Mon, 2016-08-29 at 10:27 +0200, Daniel Vetter wrote: > - Move missing bits into struct drm_encoder docs. > - Explain that encoders are 95% internal and only 5% uapi, and that in > general the uapi part is broken. > -

[Intel-gfx] [PATCH RFC 2/8] drm: Define a work struct for scheduling a uevent for modeset retry

On Wed, 2016-10-19 at 14:46 -0700, Manasi Navare wrote: > This work struct will be used to schedule a uevent on a separate > thread. This will be scheduled after a link train failure during modeset > to indicate a modeset retry request. It will get executed after the > current modeset is complete

[Intel-gfx] [PATCH 4/6] drm/dp: Introduce DP MST topology manager state to track DP link bw

On Wed, 2017-01-04 at 10:33 +0100, Daniel Vetter wrote: > On Tue, Jan 03, 2017 at 01:01:49PM -0800, Dhinakaran Pandiyan wrote: > > Link bandwidth is shared between multiple display streams in DP MST > > configurations. The DP MST topology manager structure maintains the shared > > link bandwidth

[Intel-gfx] [PATCH 4/6] drm/dp: Introduce DP MST topology manager state to track DP link bw

On Wed, 2017-01-04 at 19:20 +, Pandiyan, Dhinakaran wrote: > On Wed, 2017-01-04 at 10:33 +0100, Daniel Vetter wrote: > > On Tue, Jan 03, 2017 at 01:01:49PM -0800, Dhinakaran Pandiyan wrote: > > > Link bandwidth is shared between multiple display streams in DP MST > >

[Intel-gfx] [PATCH 3/4] drm/dp: Clarify clock recovery and channel equalization failures

On Thu, 2016-08-04 at 04:12 +0100, Chris Wilson wrote: > On Wed, Aug 03, 2016 at 08:07:40PM -0700, Dhinakaran Pandiyan wrote: > > The causes of clock recovery and channel equalization failures are not > > explicitly printed in debug messages. Help debugging link training > > failures by printing

[Intel-gfx] [PATCH 4/4] drm/i915/dp: Dump DP link status when link training stages fails

On Thu, 2016-08-04 at 10:46 +0300, Jani Nikula wrote: > On Thu, 04 Aug 2016, Dhinakaran Pandiyan > wrote: > > A full dump of link status can be handy in debugging link training > > failures. Let's add that to the debug messages when link training fails. > > > > Signed-off-by: Dhinakaran Pandiyan

[Intel-gfx] [PATCH 1/4] drm/i915/dp: Add debug messages to print DP link training pattern

On Thu, 2016-08-04 at 04:07 +0100, Chris Wilson wrote: > On Wed, Aug 03, 2016 at 08:07:38PM -0700, Dhinakaran Pandiyan wrote: > > @@ -2588,7 +2592,7 @@ _intel_dp_set_link_train(struct intel_dp *intel_dp, > > *DP |= DP_LINK_TRAIN_PAT_2_CPT; > > break; > >

[Intel-gfx] [PATCH 1/2] A Helper function that returns available link bandwidth

On Thu, 2016-08-11 at 16:41 -0700, Anusha Srivatsa wrote: > drm/dp/mst > > Signed-off-by: Anusha Srivatsa > > Add a function that returns the available link bandwidth for > MST port so that we can accurately determine whether a new > mode is valid for the link or not. > The Signed-off line

[Intel-gfx] [PATCH] drm/dp: Make space for null terminator in the DP device ID char array

Mika, Can you take a look at this? -DK On Fri, 2016-11-04 at 14:06 -0700, Dhinakaran Pandiyan wrote: > The DP device identification string read from the DPCD registers is 6 > characters long at max. and we store it in a char array of the same length > without space for the NULL terminator. Fix

[Intel-gfx] [PATCH v2] drm/dp: Make space for null terminator in the DP device ID char array

Adding Cc's. On Mon, 2016-11-07 at 15:22 -0800, Dhinakaran Pandiyan wrote: > The DP device identification string read from the DPCD registers is 6 > characters long at max. and we store it in a char array of the same length > without space for the NULL terminator. Fix this by increasing the

[Intel-gfx] [PATCH 1/3] drm/i915/dp: Fail DP MST config when there are not enough vcpi slots

On Fri, 2016-11-18 at 09:43 +0100, Daniel Vetter wrote: > On Thu, Nov 17, 2016 at 06:03:46PM -0800, Dhinakaran Pandiyan wrote: > > drm_dp_find_vcpi_slots() returns an error when there is not enough > > available bandwidth on a link to support a mode. This error should make > > compute_config() to

[Intel-gfx] [PATCH 3/3] drm/dp/mst: Track available time slots in DP Multi-Stream Transport Packet

On Fri, 2016-11-18 at 06:57 +, Chris Wilson wrote: > On Thu, Nov 17, 2016 at 06:03:48PM -0800, Dhinakaran Pandiyan wrote: > > static int drm_dp_init_vcpi(struct drm_dp_mst_topology_mgr *mgr, > > struct drm_dp_vcpi *vcpi, int pbn) > > { > > - int num_slots; > > +

[Intel-gfx] [PATCH 2/3] drm/dp/mst: Calculate total link bandwidth instead of hardcoding it

This patch along with https://patchwork.freedesktop.org/series/15305/ will fix https://bugs.freedesktop.org/show_bug.cgi?id=98141. I'd like this to be reviewed independently since the other two patches in this series require rework for atomic support. -DK On Thu, 2016-11-17 at 18:03 -0800,

[Intel-gfx] [PATCH 2/3] drm/dp/mst: Calculate total link bandwidth instead of hardcoding it

On Tue, 2016-11-29 at 22:58 +0200, Ville Syrjälä wrote: > On Thu, Nov 17, 2016 at 06:03:47PM -0800, Dhinakaran Pandiyan wrote: > > The total or the nominal link bandwidth, which we save in terms of PBN, is > > a factor of link rate and lane count. But, currently we hardcode it to > > 2560 PBN.

[Intel-gfx] [PATCH 0/2] drm: link status property and DP link training failure handling

On Fri, 2016-12-16 at 16:47 +0200, Jani Nikula wrote: > On Fri, 16 Dec 2016, Daniel Vetter wrote: > > On Fri, Dec 16, 2016 at 12:29:05PM +0200, Jani Nikula wrote: > >> The two remaining patches from [1], rebased. > >> > >> BR, > >> Jani. > >> > >> > >> [1] > >>

[Intel-gfx] [PATCH 0/2] drm: link status property and DP link training failure handling

On Sun, 2016-12-18 at 14:43 +0100, Daniel Vetter wrote: > On Sat, Dec 17, 2016 at 05:47:56AM +0000, Pandiyan, Dhinakaran wrote: > > On Fri, 2016-12-16 at 16:47 +0200, Jani Nikula wrote: > > > On Fri, 16 Dec 2016, Daniel Vetter wrote: > > > > On Fri, Dec 16, 2016 at

[Intel-gfx] [PATCH v2 1/2] drm: Wrap the check for atomic_commit implementation

Done, hope I got it right this time. -DK -Original Message- From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter Sent: Thursday, December 22, 2016 12:52 AM To: Ander Conselvan De Oliveira Cc: Pandiyan, Dhinakaran ; intel-gfx at lists.freedesktop.org; Daniel

Re: [Intel-gfx] [PATCH v4 8/8] drm/dp: Track MST link bandwidth

On Wed, 2017-03-22 at 13:30 +0100, Maarten Lankhorst wrote: > Op 16-03-17 om 08:10 schreef Dhinakaran Pandiyan: > > From: "Pandiyan, Dhinakaran" <dhinakaran.pandi...@intel.com> > > > > Use the added helpers to track MST link bandwidth for ato

Re: [Intel-gfx] [PATCH v4 4/8] drm: Add driver-private objects to atomic state

On Wed, 2017-03-22 at 11:00 +0100, Maarten Lankhorst wrote: > Op 16-03-17 om 08:10 schreef Dhinakaran Pandiyan: > > From: "Pandiyan, Dhinakaran" <dhinakaran.pandi...@intel.com> > > > > It is necessary to track states for objects other than connector, c

Re: [Intel-gfx] [PATCH v5 4/8] drm: Add driver-private objects to atomic state

9PM -0700, Dhinakaran Pandiyan wrote: > >>>> From: "Pandiyan, Dhinakaran" <dhinakaran.pandi...@intel.com> > >>>> > >>>> It is necessary to track states for objects other than connector, crtc > >>>> and plane for atomic modesets.

Re: [Intel-gfx] [PATCH] Revert unrelated part of "drm: simplify the locking in the GETCRTC ioctl"

On Thu, 2017-03-30 at 09:36 +0200, Maarten Lankhorst wrote: > Op 28-03-17 om 09:01 schreef Daniel Vetter: > > > > diff --git a/drivers/gpu/drm/i915/intel_display.c > > b/drivers/gpu/drm/i915/intel_display.c > > index 68cded453882..43dbad62786e 100644 > > ---

Re: [Intel-gfx] [PATCH v5 4/5] drm: Connector helper function to release resources

On Thu, 2017-03-30 at 12:36 +0200, Maarten Lankhorst wrote: > Op 30-03-17 om 10:42 schreef Dhinakaran Pandiyan: > > From: "Pandiyan, Dhinakaran" <dhinakaran.pandi...@intel.com> > > > > Having an ->atomic_release callback is useful to release

Re: [Intel-gfx] [PATCH v5 3/5] drm/dp: Add DP MST helpers to atomically find and release vcpi slots

On Thu, 2017-03-30 at 01:42 -0700, Dhinakaran Pandiyan wrote: > From: "Pandiyan, Dhinakaran" <dhinakaran.pandi...@intel.com> > > drm_dp_atomic_find_vcpi_slots() should be called from ->atomic_check() to > check there are sufficient vcpi slots for a mode and to add t

Re: [Intel-gfx] [PATCH v3 4/8] drm: Add driver-private objects to atomic state

On Sun, 2017-02-26 at 20:57 +0100, Daniel Vetter wrote: > On Wed, Feb 22, 2017 at 12:01:12AM +0000, Pandiyan, Dhinakaran wrote: > > On Fri, 2017-02-17 at 15:37 +0530, Archit Taneja wrote: > > > > > > On 02/16/2017 05:43 AM, Pandiyan, Dhinakaran wrote: > > >

Re: [Intel-gfx] [PATCH v3 4/8] drm: Add driver-private objects to atomic state

IRC acked by Harry Wentland " dhnkrn, the patch for driver-private atomic state object makes sense to me. Didn't realize that's the same one from early February. Feel free to add my Acked-by" -DK On Wed, 2017-02-08 at 22:38 -0800, Dhinakaran Pandiyan wrote: > It is necessary to track states

Re: [Intel-gfx] [PATCH] drm/atomic: Add connector atomic_check function.

On Wed, 2017-04-05 at 12:06 +0200, Daniel Vetter wrote: > On Wed, Apr 05, 2017 at 10:41:24AM +0200, Maarten Lankhorst wrote: > > The connector atomic check function may be called multiple times, > > or not at all. It's mostly useful for implementing properties but if you > > call check_modeset

Re: [Intel-gfx] [PATCH] drm/i915: Return correct EDP voltage swing table for 0.85V

Looks like a typo in cf54ca8 ("drm/i915/cnl: Implement voltage swing sequence.") but Cc'ing Rodrigo, Clint to make sure this wasn't a workaround. -DK On Mon, 2017-07-17 at 11:21 -0700, Matthias Kaehlcke wrote: > For 0.85V cnl_get_buf_trans_edp() returns the DP table, instead of EDP. > Use

Re: [Intel-gfx] [PATCH] drm/i915: Return correct EDP voltage swing table for 0.85V

On Mon, 2017-07-17 at 18:55 +, Pandiyan, Dhinakaran wrote: > Looks like a typo in > > cf54ca8 ("drm/i915/cnl: Implement voltage swing sequence.") > > but Cc'ing Rodrigo, Clint to make sure this wasn't a workaround. > > -DK Checked with Clint, this was

Re: [PATCH 1/3] drm/dp/mst: Handle errors from drm_atomic_get_private_obj_state() correctly

On Wed, 2017-07-12 at 18:51 +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > On failure drm_atomic_get_private_obj_state() returns and error > pointer instead of NULL. Adjust the checks in the callers to match. > > Cc: sta...@vger.kernel.org >

Re: [Intel-gfx] [PATCH v2] drm/i915: Explicit the connector name for DP link training result

On Tue, 2017-07-18 at 17:25 +0300, Paul Kocialkowski wrote: > This adds the connector name when printing a debug message about the DP > link training result. It is useful to figure out what connector is > failing when multiple DP connectors are used. > > Signed-off-by: Paul Kocialkowski

Re: [Intel-gfx] [PATCH] drm/i915: Synchronize connectors states when switching from poll to irq

On Mon, 2017-06-26 at 15:32 +0300, Paul Kocialkowski wrote: > After detecting an IRQ storm, hotplug detection will switch from > irq-based detection to poll-based detection. After a short delay or > when resetting storm detection from debugfs, detection will switch > back to being irq-based. > >

Re: [Intel-gfx] [PATCH v12 3/3] drm/i915: Add option to support dynamic backlight via DPCD

On Tue, 2017-06-27 at 16:23 +0300, David Weinehall wrote: > On Mon, Jun 26, 2017 at 05:18:19PM +0300, David Weinehall wrote: > > On Thu, Jun 22, 2017 at 12:03:39PM -0700, Puthikorn Voravootivat wrote: > > > This patch adds option to enable dynamic backlight for eDP > > > panel that supports

Re: [PATCH v7 4/4] drm/dp: Track MST link bandwidth

On Tue, 2017-04-25 at 09:51 +0200, Maarten Lankhorst wrote: > On 21-04-17 07:51, Dhinakaran Pandiyan wrote: > > From: "Pandiyan, Dhinakaran" <dhinakaran.pandi...@intel.com> > > > > Use the added helpers to track MST link bandwidth for atomic modesets. > >

Re: [Intel-gfx] [PATCH v7 0/4] Adding driver-private objects to atomic state

On Mon, 2017-04-24 at 11:53 -0400, Harry Wentland wrote: > Patches 1-3: Reviewed-by: Harry Wentland > Patch 4: Acked-by: Harry Wentland > > Harry > Thanks for the review. -DK ___ dri-devel mailing

Re: [Intel-gfx] [PATCH v7 4/4] drm/dp: Track MST link bandwidth

On Tue, 2017-04-25 at 09:51 +0200, Maarten Lankhorst wrote: > On 21-04-17 07:51, Dhinakaran Pandiyan wrote: > > From: "Pandiyan, Dhinakaran" <dhinakaran.pandi...@intel.com> > > > > Use the added helpers to track MST link bandwidth for atomic modesets. > >

Re: [Intel-gfx] [PATCH v6 6/9] drm/i915: Support dynamic backlight via DPCD register

On Tue, 2017-05-09 at 16:40 -0700, Puthikorn Voravootivat wrote: > This patch enables dynamic backlight by default for eDP > panel that supports this feature via DPCD register and > set minimum / maximum brightness to 0% and 100% of the > normal brightness. I realized I replied to the previous

Re: [Intel-gfx] [PATCH v6 3/9] drm/i915: Drop AUX backlight enable check for backlight control

On Tue, 2017-05-09 at 16:40 -0700, Puthikorn Voravootivat wrote: > There are some panel that > (1) does not support display backlight enable via AUX > (2) support display backlight adjustment via AUX > (3) support display backlight enable via eDP BL_ENABLE pin > > The current driver required that

Re: [Intel-gfx] [PATCH v6 1/9] drm/i915: Fix cap check for intel_dp_aux_backlight driver

On Tue, 2017-05-09 at 16:40 -0700, Puthikorn Voravootivat wrote: > intel_dp_aux_backlight driver should check for the > DP_EDP_BACKLIGHT_BRIGHTNESS_AUX_SET_CAP before enable the driver. > > Signed-off-by: Puthikorn Voravootivat Reviewed-by: Dhinakaran Pandiyan

Re: [Intel-gfx] [PATCH v5 3/9] drm/i915: Drop AUX backlight enable check for backlight control

On Wed, 2017-05-10 at 13:05 +0300, Jani Nikula wrote: > On Wed, 10 May 2017, "Pandiyan, Dhinakaran" <dhinakaran.pandi...@intel.com> > wrote: > > On Tue, 2017-05-09 at 16:39 -0700, Puthikorn Voravootivat wrote: > >> > How is backlight enabled in

Re: [Intel-gfx] [PATCH v6 4/9] drm/i915: Allow choosing how to adjust brightness if both supported

On Tue, 2017-05-09 at 16:40 -0700, Puthikorn Voravootivat wrote: > Add option to allow choosing how to adjust brightness if > panel supports both PWM pin and AUX channel. > > Signed-off-by: Puthikorn Voravootivat > --- > drivers/gpu/drm/i915/i915_params.c| 8

Re: [Intel-gfx] [PATCH v5 6/9] drm/i915: Support dynamic backlight via DPCD register

On Wed, 2017-05-03 at 17:28 -0700, Puthikorn Voravootivat wrote: > This patch enables dynamic backlight by default for eDP > panel that supports this feature via DPCD register and > set minimum / maximum brightness to 0% and 100% of the > normal brightness. I read the link that you shared last

Re: [Intel-gfx] [PATCH v6 8/9] drm: Add definition for eDP backlight frequency

On Tue, 2017-05-09 at 16:40 -0700, Puthikorn Voravootivat wrote: > This patch adds the following definition > - Bit mask for EDP_PWMGEN_BIT_COUNT and min/max cap > register which only use bit 0:4 > - Base frequency (27 MHz) for backlight PWM frequency > generator. > > Signed-off-by: Puthikorn

Re: [PATCH v7 3/9] drm/i915: Drop AUX backlight enable check for backlight control

On Fri, 2017-05-12 at 11:10 -0700, Puthikorn Voravootivat wrote: > > > On Fri, May 12, 2017 at 6:14 AM, Jani Nikula > <jani.nik...@linux.intel.com> wrote: > On Fri, 12 May 2017, "Pandiyan, Dhinakaran" > <dhinakaran.pandi...@intel.com> wro

Re: [Intel-gfx] [PATCH v7 9/9] drm/i915: Set PWM divider to match desired frequency in vbt

On Thu, 2017-05-11 at 16:02 -0700, Puthikorn Voravootivat wrote: > Read desired PWM frequency from panel vbt and calculate the > value for divider in DPCD address 0x724 and 0x728 to have > as many bits as possible for PWM duty cyle for granularity of > brightness adjustment while the frequency is

Re: [Intel-gfx] [PATCH v5 3/9] drm/i915: Drop AUX backlight enable check for backlight control

hing very obvious. If intel_dp_aux_init_backlight_funcs() returned -ENODEV, then one of the platform specific PWM enable callbacks would be called. But in this case, dp_aux_enable_backlight() just returns without doing anything. -DK > > > On Sat, May 6, 2017 at 1:59 AM, Pa

RE: [PATCH v8 1/5] drm/i915: Drop AUX backlight enable check for backlight control

From: Puthikorn Voravootivat [put...@google.com] on behalf of Puthikorn Voravootivat [put...@chromium.org] Sent: Tuesday, May 16, 2017 5:33 PM To: intel-...@lists.freedesktop.org; Pandiyan, Dhinakaran Cc: dri-devel@lists.freedesktop.org; Jani Nikula

Re: [Intel-gfx] [PATCH v8 3/5] drm/i915: Add option to support dynamic backlight via DPCD

On Tue, 2017-05-16 at 17:34 -0700, Puthikorn Voravootivat wrote: > This patch adds option to enable dynamic backlight for eDP > panel that supports this feature via DPCD register and > set minimum / maximum brightness to 0% and 100% of the > normal brightness. > > Signed-off-by: Puthikorn

Re: [Intel-gfx] [PATCH v8 5/5] drm/i915: Set PWM divider to match desired frequency in vbt

On Tue, 2017-05-16 at 17:34 -0700, Puthikorn Voravootivat wrote: > Read desired PWM frequency from panel vbt and calculate the > value for divider in DPCD address 0x724 and 0x728 to have > as many bits as possible for PWM duty cyle for granularity of > brightness adjustment while the frequency

Re: [Intel-gfx] [PATCH v7 9/9] drm/i915: Set PWM divider to match desired frequency in vbt

On Tue, 2017-05-16 at 11:07 -0700, Puthikorn Voravootivat wrote: > > > On Mon, May 15, 2017 at 11:21 PM, Pandiyan, Dhinakaran > <dhinakaran.pandi...@intel.com> wrote: > On Mon, 2017-05-15 at 17:43 -0700, Puthikorn Voravootivat > wrote: > >

Re: [Intel-gfx] [PATCH v7 9/9] drm/i915: Set PWM divider to match desired frequency in vbt

On Tue, 2017-05-16 at 17:39 -0700, Puthikorn Voravootivat wrote: > > > On Tue, May 16, 2017 at 2:21 PM, Pandiyan, Dhinakaran > <dhinakaran.pandi...@intel.com> wrote: > On Tue, 2017-05-16 at 13:56 -0700, Puthikorn Voravootivat > wrote: > >

Re: [Intel-gfx] [PATCH 1/2] drm/dp: start a DPCD based DP sink/branch device quirk database

On Thu, 2017-05-11 at 12:57 +0300, Jani Nikula wrote: > Face the fact, there are Display Port sink and branch devices out there > in the wild that don't follow the Display Port specifications, or they > have bugs, or just otherwise require special treatment. Start a common > quirk database the

Re: [Intel-gfx] [PATCH v7 9/9] drm/i915: Set PWM divider to match desired frequency in vbt

On Fri, 2017-05-12 at 17:31 -0700, Puthikorn Voravootivat wrote: > > > > On Fri, May 12, 2017 at 5:12 PM, Pandiyan, Dhinakaran > <dhinakaran.pandi...@intel.com> wrote: > On Thu, 2017-05-11 at 16:02 -0700, Puthikorn Voravootivat > wrote: >

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Detect USB-C specific dongles before reducing M and N

On Thu, 2017-05-11 at 09:12 -0700, Clint Taylor wrote: > > On 05/11/2017 02:57 AM, Jani Nikula wrote: > > From: Clint Taylor > > > > The Analogix 7737 DP to HDMI converter requires reduced M and N values > > when to operate correctly at HBR2. Detect this IC by its OUI

Re: [Intel-gfx] [PATCH v7 9/9] drm/i915: Set PWM divider to match desired frequency in vbt

On Mon, 2017-05-15 at 17:43 -0700, Puthikorn Voravootivat wrote: > > > On Mon, May 15, 2017 at 4:07 PM, Pandiyan, Dhinakaran > <dhinakaran.pandi...@intel.com> wrote: > On Fri, 2017-05-12 at 17:31 -0700, Puthikorn Voravoo

Re: [PATCH v7 3/9] drm/i915: Drop AUX backlight enable check for backlight control

On Thu, 2017-05-11 at 16:02 -0700, Puthikorn Voravootivat wrote: > There are some panel that > (1) does not support display backlight enable via AUX > (2) support display backlight adjustment via AUX > (3) support display backlight enable via eDP BL_ENABLE pin > > The current driver required that

Re: [PATCH v7 6/9] drm/i915: Add option to support dynamic backlight via DPCD

On Thu, 2017-05-11 at 16:02 -0700, Puthikorn Voravootivat wrote: > This patch adds option to enable dynamic backlight for eDP > panel that supports this feature via DPCD register and > set minimum / maximum brightness to 0% and 100% of the > normal brightness. > > Signed-off-by: Puthikorn

Re: [Intel-gfx] [PATCH] drm: Fix GETCONNECTOR regression

edesktop.org > Reported-by: "H.J. Lu" <hjl.to...@gmail.com> > Tested-by: "H.J. Lu" <hjl.to...@gmail.com> > Cc: <sta...@vger.kernel.org> # v4.11+ > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100576 > Cc: "H.J. Lu" <hjl.to...@gm

Re: [Intel-gfx] [PATCH] drm: Fix GETCONNECTOR regression

On Tue, 2017-06-20 at 11:16 +0200, Daniel Vetter wrote: > In > > commit 91eefc05f0ac71902906b2058360e61bd25137fe > Author: Daniel Vetter > Date: Wed Dec 14 00:08:10 2016 +0100 > > drm: Tighten locking in drm_mode_getconnector > > I reordered the logic a bit in

Re: [Intel-gfx] [PATCH RESEND v11 0/3] Enhancement to intel_dp_aux_backlight driver

On Tue, 2017-06-20 at 11:03 +0200, Daniel Vetter wrote: > On Mon, Jun 05, 2017 at 02:56:04PM -0700, Puthikorn Voravootivat wrote: > > This patch set contain 3 patches which are already reviewed by DK. > > Another 6 patches in previous version was already merged in v7 and v9. > > - First patch

RE: [Intel-gfx] [PATCH v8 3/5] drm/i915: Add option to support dynamic backlight via DPCD

Yeah, looks fine to me. -DK From: put...@google.com [mailto:put...@google.com] On Behalf Of Puthikorn Voravootivat Sent: Friday, May 19, 2017 2:00 PM To: Pandiyan, Dhinakaran <dhinakaran.pandi...@intel.com> Cc: put...@chromium.org; dri-devel@lists.freedesktop.org;

Re: [Intel-gfx] [PATCH 3/4] drm/dp: start a DPCD based DP sink/branch device quirk database

On Thu, 2017-05-18 at 14:10 +0300, Jani Nikula wrote: > Face the fact, there are Display Port sink and branch devices out there > in the wild that don't follow the Display Port specifications, or they > have bugs, or just otherwise require special treatment. Start a common > quirk database the

Re: [Intel-gfx] [PATCH v8 1/5] drm/i915: Drop AUX backlight enable check for backlight control

On Wed, 2017-05-17 at 14:04 -0700, Puthikorn Voravootivat wrote: > > On Wed, May 17, 2017 at 1:09 PM, Pandiyan, Dhinakaran > <dhinakaran.pandi...@intel.com> wrote: > > > From: Puthikorn Voravootivat [put.

Re: [Intel-gfx] [PATCH v10 2/3] drm/i915: Add option to support dynamic backlight via DPCD

On Wed, 2017-05-31 at 14:37 -0700, Puthikorn Voravootivat wrote: > > > On Tue, May 30, 2017 at 9:18 PM, Pandiyan, Dhinakaran > <dhinakaran.pandi...@intel.com> wrote: > On Fri, 2017-05-26 at 18:42 -0700, Puthikorn Voravootivat > wrote: > > Th

Re: [Intel-gfx] [PATCH v10 3/3] drm/i915: Set PWM divider to match desired frequency in vbt

The patch looks good overall, it would have been easier to merge if you'd sent this as the first patch in this version. Some comments inline. On Fri, 2017-05-26 at 18:42 -0700, Puthikorn Voravootivat wrote: > Read desired PWM frequency from panel vbt and calculate the > value for divider in

Re: [Intel-gfx] [PATCH v10 2/3] drm/i915: Add option to support dynamic backlight via DPCD

On Fri, 2017-05-26 at 18:42 -0700, Puthikorn Voravootivat wrote: > This patch adds option to enable dynamic backlight for eDP > panel that supports this feature via DPCD register and > set minimum / maximum brightness to 0% and 100% of the > normal brightness. > > Signed-off-by: Puthikorn

Re: [Intel-gfx] [PATCH v10 2/3] drm/i915: Add option to support dynamic backlight via DPCD

On Fri, 2017-05-26 at 18:42 -0700, Puthikorn Voravootivat wrote: > This patch adds option to enable dynamic backlight for eDP > panel that supports this feature via DPCD register and > set minimum / maximum brightness to 0% and 100% of the > normal brightness. > > Signed-off-by: Puthikorn

Re: [Intel-gfx] [PATCH v10 1/3] drm/i915: Add heuristic to determine better way to adjust brightness

On Fri, 2017-06-02 at 17:42 +, Pandiyan, Dhinakaran wrote: Somehow the CC's got removed in my previous reply, adding them back. See one additional comment below. > On Fri, 2017-05-26 at 18:42 -0700, Puthikorn Voravootivat wrote: > > Add heuristic to decide that AUX or PWM pin s

Re: [Intel-gfx] [PATCH v10 1/3] drm/i915: Add heuristic to determine better way to adjust brightness

On Fri, 2017-05-26 at 18:42 -0700, Puthikorn Voravootivat wrote: > Add heuristic to decide that AUX or PWM pin should use for > backlight brightness adjustment and modify i915 param description > to have auto, force disable, and force enable. > > The heuristic to determine that using AUX pin is

Re: [Intel-gfx] [PATCH v5 3/9] drm/i915: Drop AUX backlight enable check for backlight control

On Wed, 2017-05-03 at 17:28 -0700, Puthikorn Voravootivat wrote: > There are some panel that > (1) does not support display backlight enable via AUX > (2) support display backlight adjustment via AUX > (3) support display backlight enable via eDP BL_ENABLE pin > > The current driver required that

Re: [Intel-gfx] [PATCH v5 9/9] drm/i915: Set PWM divider to match desired frequency in vbt

On Wed, 2017-05-03 at 17:28 -0700, Puthikorn Voravootivat wrote: > Read desired PWM frequency from panel vbt and calculate the > value for divider in DPCD address 0x724 and 0x728 to match > that frequency as close as possible. > > Signed-off-by: Puthikorn Voravootivat > ---

Re: [Intel-gfx] [PATCH v8 4/4] drm/dp: Track MST link bandwidth

On Mon, 2017-05-01 at 10:24 +0200, Maarten Lankhorst wrote: > Op 29-04-17 om 01:14 schreef Dhinakaran Pandiyan: > > From: "Pandiyan, Dhinakaran" <dhinakaran.pandi...@intel.com> > > > > Use the added helpers to track MST link bandwidth for ato

Re: [Intel-gfx] [PATCH v5 1/9] drm/i915: Fix cap check for intel_dp_aux_backlight driver

->edp_dpcd[2] & DP_EDP_BACKLIGHT_BRIGHTNESS_AUX_SET_CAP)) { You can then make the PWM PIN/AUX preference changes in patch 4. Jani, please correct me if I'm wrong here. -DK > > > On Mon, May 8, 2017 at 10:55 AM, Pandiyan, Dhinakaran > <dhinakaran.pandi...@intel.com> wrote:

Re: [Intel-gfx] [PATCH v5 7/9] drm/i915: Restore brightness level in aux backlight driver

On Wed, 2017-05-03 at 17:28 -0700, Puthikorn Voravootivat wrote: > Some panel will default to zero brightness when turning the > panel off and on again. This patch restores last brightness > level back when panel is turning back on. > > Signed-off-by: Puthikorn Voravootivat

Re: [Intel-gfx] [PATCH v5 5/9] drm/i915: Set backlight mode before enable backlight

On Wed, 2017-05-03 at 17:28 -0700, Puthikorn Voravootivat wrote: > We should set backlight mode register before set register to > enable the backlight. > Sounds reasonable, although I did not find anything in the spec. that says we should do this. If you've tested and it works, Reviewed-by:

Re: [Intel-gfx] [PATCH v5 2/9] drm/i915: Correctly enable backlight brightness adjustment via DPCD

On Wed, 2017-05-03 at 17:28 -0700, Puthikorn Voravootivat wrote: > intel_dp_aux_enable_backlight() assumed that the register > BACKLIGHT_BRIGHTNESS_CONTROL_MODE can only has value 01 > (DP_EDP_BACKLIGHT_CONTROL_MODE_PRESET) when initialize. > > This patch fixed that by handling all cases of that

Re: [Intel-gfx] [PATCH v5 9/9] drm/i915: Set PWM divider to match desired frequency in vbt

and then again "Allowing Pn to be adjustable provides the flexibility of backlight dimming granularity vs. maximum backlight frequency." > > On Sat, May 6, 2017 at 1:35 AM, Pandiyan, Dhinakaran > <dhinakaran.pandi...@intel.com> wrote: > On Wed, 2017-05-03 at 17:28 -0700,

Re: [Intel-gfx] [PATCH v5 1/9] drm/i915: Fix cap check for intel_dp_aux_backlight driver

On Wed, 2017-05-03 at 17:28 -0700, Puthikorn Voravootivat wrote: > intel_dp_aux_backlight driver should check for the > DP_EDP_BACKLIGHT_BRIGHTNESS_AUX_SET_CAP before enable the driver. > > Signed-off-by: Puthikorn Voravootivat > --- >

Re: [Intel-gfx] [PATCH v11 3/3] drm/i915: Add option to support dynamic backlight via DPCD

> > On Mon, Jun 5, 2017 at 11:49 AM, Pandiyan, Dhinakaran > <dhinakaran.pandi...@intel.com> wrote: > On Fri, 2017-06-02 at 19:04 -0700, Puthikorn Voravootivat > wrote: > > This patch adds option to enable dynamic backlight for eDP > >

Re: [Intel-gfx] [PATCH v11 3/3] drm/i915: Add option to support dynamic backlight via DPCD

On Fri, 2017-06-02 at 19:04 -0700, Puthikorn Voravootivat wrote: > This patch adds option to enable dynamic backlight for eDP > panel that supports this feature via DPCD register and > set minimum / maximum brightness to 0% and 100% of the > normal brightness. > > Change-Id:

Re: [Intel-gfx] [PATCH] drm/dp: DPCD register defines for link

On Thu, 2017-09-14 at 09:00 +0300, Jani Nikula wrote: > On Wed, 13 Sep 2017, Dhinakaran Pandiyan > wrote: > > Link status is available in the ESI field on devices with DPCD r1.2 or > > higher. DP spec also says "An MST upstream device shall use this field > >

Re: [Intel-gfx] [PATCH v2] drm/dp/mst: Sideband message transaction to power up/down nodes

On Mon, 2017-09-11 at 16:33 +0300, Ville Syrjälä wrote: > On Wed, Sep 06, 2017 at 05:14:58PM -0700, Dhinakaran Pandiyan wrote: > > The POWER_DOWN_PHY and POWER_UP_PHY sideband message transactions allow > > the source to reqest any node in a mst path or a whole path to be > > powered down or up.

Re: [Intel-gfx] [PATCH v2] drm/dp/mst: Sideband message transaction to power up/down nodes

On Thu, 2017-09-07 at 14:04 -0400, Lyude Paul wrote: > Looks good to me. > > Reviewed-by: Lyude Paul > Thanks for the review. -DK > On Wed, 2017-09-06 at 17:14 -0700, Dhinakaran Pandiyan wrote: > > The POWER_DOWN_PHY and POWER_UP_PHY sideband message transactions > >

  1   2   >