is not the
default.
I'm gonna open a new bz entry with all the details (and all the people on cc
minus regression handlers). But first I'll check with CONFIG_LOCKDEP
whether it's really a locking goof-up.
-Daniel
--
Daniel Vetter
E-Mail: daniel.vet...@ffwll.ch
Tel.: +41 (0)79 365 57 48
:
(cc's added)
On Sat, 31 Jan 2009 16:25:08 +0100 Daniel Vetter dan...@ffwll.ch wrote:
On Thu, Jan 29, 2009 at 01:48:25PM -0800, Andrew Morton wrote:
On Thu, 29 Jan 2009 13:24:17 -0800
Jesse Barnes jbar...@virtuousgeek.org wrote:
On Thursday, January 29, 2009 12:50 pm
for the framebuffer console always works, so
YMMV.
-Daniel
--
Daniel Vetter
E-Mail: daniel.vet...@ffwll.ch
Tel.: +41 (0)79 365 57 48
--
Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM)
software
1024.
- patches 1, 4, 5 change drm-generic code.
- the ioctl interface is intel-only. Anyone (radeon devs?) working on another
overlay implementation/interested in sharing code?
Yours, Daniel
PS: I'll post the ddx part shortly to intel-gfx.
Daniel Vetter (6):
[drm]: make drm_mode_object_find
These will be used to ensure that the clock of pipe a is running
when the overlay is switched on. Programming logic more or less
directly ported over from userspace.
Also export the already existing helper function drm_encoder_crtc_ok.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
And clean up a small whitespace goof-up in the same function, while
I was looking at it.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/i915/intel_display.c | 20
1 files changed, 8 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/i915
.
Also replace a magic 0 with the symbolic constant (and kill the then
superflous comment) while I was looking at the code.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/i915/i915_drv.h |1 +
drivers/gpu/drm/i915/i915_gem.c | 51
... by moving the assignment up.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/i915/intel_display.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index bb59356
I've wasted half a day hunting a bug that could easily be spotted by
gcc. Prevent this from reoccurring.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/drm_crtc.c |3 ++-
include/drm/drm_crtc.h |3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff
as infrastructure.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/i915/Makefile|1 +
drivers/gpu/drm/i915/i915_dma.c |7 +
drivers/gpu/drm/i915/i915_drv.h |4 +
drivers/gpu/drm/i915/i915_reg.h |5 +
drivers/gpu/drm/i915/intel_display.c
let's leave it at this
for the moment. I left some dummy functions as infrastructure.
Changes since v1:
- fix off-by-one misconception on my side. This fixes fullscreen
playback.
Tested-By: diego.abele...@gmail.com (on a 865G)
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu
for all it's
chips.
/Thomas
Yours, Daniel
--
Daniel Vetter
Mail: dan...@ffwll.ch
Mobile: +41 (0)79 365 57 48
--
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report
On Mon, Aug 31, 2009 at 02:15:15PM +0200, Stephane Marchesin wrote:
2009/8/31 Thomas Hellström tho...@shipmail.org:
Daniel Vetter wrote:
...
In conclusion I don't think a common ioctl is worth it. But sharing some
code and infrastructure on the kernel side is certainly possible
with the crtc output state.
So at least on intel, some overlay support on the kernel side is needed to
at least prevent race conditions that may hang the chip.
Alex
Yours, Daniel
--
Daniel Vetter
Mail: dan...@ffwll.ch
Mobile: 079 365 57 48
--
Daniel Vetter
Mail: dan...@ffwll.ch
Mobile: 079 365 57 48
--
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what
batchbuffers,
so no monsterous checker/relocater/munger already present.
--
Daniel Vetter
Mail: dan...@ffwll.ch
Mobile: 079 365 57 48
--
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify
I've wasted half a day hunting a bug that could easily be spotted by
gcc. Prevent this from reoccurring.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/drm_crtc.c |3 ++-
include/drm/drm_crtc.h |3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff
These will be used to ensure that the clock of pipe a is running
when the overlay is switched on. Programming logic more or less
directly ported over from userspace.
Also export the already existing helper function drm_encoder_crtc_ok.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
.
Also replace a magic 0 with the symbolic constant (and kill the then
superflous comment) while I was looking at the code.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/i915/i915_drv.h |1 +
drivers/gpu/drm/i915/i915_gem.c | 51
It is identical to I85X. Use that one instead.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/i915/i915_drv.h |1 -
drivers/gpu/drm/i915/intel_display.c |4 ++--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b
fullscreen
playback.
Changes since v2:
- add underrun detection as spec'ed for i965.
- flush caches properly, fixing visual corruptions.
Tested-By: diego.abele...@gmail.com (on a 865G)
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/i915/Makefile|1 +
drivers/gpu/drm
to summarize the outcomes of various discussion in the changelog.
Please review and consider for .32.
Thanks, Daniel
Daniel Vetter (5):
[drm]: make drm_mode_object_find typesafe
[drm/i915]: require_pipe_a helper functions
[drm/i915]: add i915_lp_ring_sync helper
[drm/i915]: kill superflous
. Looks like I've missed yet another cache flush. I've hacked
up a fix which seems to work, here, but I'd like to give it some more
testing.
Yours, Daniel
--
Daniel Vetter
Mail: dan...@ffwll.ch
Mobile: +41 (0)79 365 57 48
Hi all,
Latest version of my overlay kms work. I've added the new stuff as separated
patches for easier testing in case something blows up.
Please review.
Thanks, Daniel
Daniel Vetter (8):
[drm]: make drm_mode_object_find typesafe
[drm/i915]: add i915_lp_ring_sync helper
[drm/i915]: kill
)
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/i915/Makefile|1 +
drivers/gpu/drm/i915/i915_dma.c |7 +
drivers/gpu/drm/i915/i915_drv.h |4 +
drivers/gpu/drm/i915/i915_reg.h |5 +
drivers/gpu/drm/i915/intel_display.c | 26 +-
drivers/gpu
an unkillable X in addition to a black screen.
BUG() about it and explain in the code.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/i915/intel_display.c | 17 +++-
drivers/gpu/drm/i915/intel_drv.h |9 ++-
drivers/gpu/drm/i915/intel_overlay.c | 167
I've wasted half a day hunting a bug that could easily be spotted by
gcc. Prevent this from reoccurring.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/drm_crtc.c |3 ++-
include/drm/drm_crtc.h |3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff
It is identical to I85X. Use that one instead.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/i915/i915_drv.h |1 -
drivers/gpu/drm/i915/intel_display.c |4 ++--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b
As long as the gpu can keep up, neither the cpu (waiting for gpu)
nore the gpu (waiting for vblank to do an overlay flip) stalls.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/i915/i915_drv.h |3 ++
drivers/gpu/drm/i915/i915_gem.c |4 +-
drivers/gpu
It's not needed anymore.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/i915/i915_drv.h |1 -
drivers/gpu/drm/i915/i915_gem.c | 18 --
2 files changed, 0 insertions(+), 19 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm
.
Also replace a magic 0 with the symbolic constant (and kill the then
superflous comment) while I was looking at the code.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/i915/i915_drv.h |1 +
drivers/gpu/drm/i915/i915_gem.c | 51
Now that the cache flushing of the memory based overlay regs works,
we can safely switch off the overlay. Beforehand it was only disabled
(like in userspace).
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/i915/intel_overlay.c |3 +--
1 files changed, 1 insertions
On Fri, Oct 02, 2009 at 02:38:46PM -0700, Eric Anholt wrote:
On Tue, 2009-09-15 at 22:57 +0200, Daniel Vetter wrote:
OK, I've finally pulled this for -next, with a bit of hand resolving of
conflicts. I debated, because of the somewhat unusual series of adding
the ring sync, implementing
I've simply overlooked one case in the conversion to interruptible
sleeps. Rectify this.
Also delete a leftover debug printk.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/i915/intel_overlay.c | 17 +++--
1 files changed, 7 insertions(+), 10 deletions
On Thu, Oct 08, 2009 at 10:11:40AM -0700, Eric Anholt wrote:
On Sun, 2009-10-04 at 15:00 +0200, Daniel Vetter wrote:
I've simply overlooked one case in the conversion to interruptible
sleeps. Rectify this.
Also delete a leftover debug printk.
OK, I'm confused about what this patch
Hunting, Daniel
--
Daniel Vetter
Mail: dan...@ffwll.ch
Mobile: +41 (0)79 365 57 48
--
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev
-gem_free_object_unlocked entry point if available, and
otherwise just takes struct_mutex and just calls -gem_free_object
Why not add a BUG_ON(!mutex_is_locked(dev-struct_mutex)) to
drm_gem_object_unreference to catch wrong api by occasional drm hackers
like me?
-Daniel
--
Daniel Vetter
Mail: dan...@ffwll.ch
calls,
make more sense that way, IMHO.
-Daniel
--
Daniel Vetter
Mail: dan...@ffwll.ch
Mobile: +41 (0)79 365 57 48
--
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data
Oh, dang. Thanks for catching this. Eric, please merge.
Cc: sta...@kernel.org (for .33)
Reviewed-by: Daniel Vetter dan...@ffwll.ch
On Sat, Mar 06, 2010 at 02:05:39PM +0300, Dan Carpenter wrote:
We should free params before returning.
Signed-off-by: Dan Carpenter erro...@gmail.com
diff
welcome.
Yours, Daniel
Daniel Vetter (14):
drm/radoen: move r100 asic struct to r100.c
drm/radoen: move r200 asic struct to r200.c
drm/radeon: move r300 asic structs to r300.c
drm/radeon: move r420 asic struct to r420.c
drm/radoen: move rs400 asic struct to rs400.c
drm/radoen: move rs600
Like for r200.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/radeon/r600.c| 43 ++
drivers/gpu/drm/radeon/radeon_asic.h | 37 +
2 files changed, 44 insertions(+), 36 deletions(-)
diff --git
to r100.c
To accomplish this, the declarations for a few shared functions had to
be moved from radeon_asic.h to radeon.h. They'll move back when this
cleanup is complete.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/radeon/r100.c| 38
Like for r200.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/radeon/radeon_asic.h | 38 +-
drivers/gpu/drm/radeon/rs690.c | 72 ++
2 files changed, 73 insertions(+), 37 deletions(-)
diff --git a/drivers/gpu/drm
No one cares about it, so set it to void.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/radeon/radeon.h |2 +-
drivers/gpu/drm/radeon/radeon_asic.h |4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon.h b
And kill the temporary function declarations. Also drop a few
unnecessary forward declarations.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/radeon/evergreen.c | 12 +-
drivers/gpu/drm/radeon/r100.c|1 +
drivers/gpu/drm/radeon/r200.c
Like for r200.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/radeon/r520.c| 77 ++
drivers/gpu/drm/radeon/radeon_asic.h | 40 +-
2 files changed, 79 insertions(+), 38 deletions(-)
diff --git a/drivers/gpu/drm
Like for the r100.
Because radeon_asic.h is not yet usable as a header file, I had to
copy a few shared function declarations into r200.c. Yes, this is
ugly but not actually worse than current state. And it'll all be
gone when this header untangling is done.
Signed-off-by: Daniel Vetter
Like for r200.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/radeon/evergreen.c | 43 ++
drivers/gpu/drm/radeon/radeon_asic.h | 35 +--
2 files changed, 44 insertions(+), 34 deletions(-)
diff --git a/drivers
Like for r200.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/radeon/r420.c| 75 ++
drivers/gpu/drm/radeon/radeon_asic.h | 39 +-
2 files changed, 77 insertions(+), 37 deletions(-)
diff --git a/drivers/gpu/drm
Like for r200.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/radeon/radeon_asic.h | 38 +-
drivers/gpu/drm/radeon/rv515.c | 72 ++
2 files changed, 73 insertions(+), 37 deletions(-)
diff --git a/drivers/gpu/drm
Like for r200.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/radeon/radeon_asic.h | 38 +-
drivers/gpu/drm/radeon/rs400.c | 72 ++
2 files changed, 73 insertions(+), 37 deletions(-)
diff --git a/drivers/gpu/drm
Like for r200.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/radeon/r300.c| 105 ++
drivers/gpu/drm/radeon/radeon_asic.h | 76 +
2 files changed, 107 insertions(+), 74 deletions(-)
diff --git a/drivers
Like for r200.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/radeon/radeon_asic.h | 39 +
drivers/gpu/drm/radeon/rs600.c | 63 ++
2 files changed, 64 insertions(+), 38 deletions(-)
diff --git a/drivers/gpu
. Of
course, as someone who has just started to look at the radeon drm, I'm
biased ;)
- there was no .c file around where they'd fit.
Creating a new radeon_asic.c file would be another option of course. If
you think that's much better, I could respin the series.
Daniel
--
Daniel Vetter
Mail: dan
On Thu, Mar 11, 2010 at 04:46:01PM +0100, Jerome Glisse wrote:
On Thu, Mar 11, 2010 at 02:06:02PM +0100, Daniel Vetter wrote:
Hi all,
This patch pile moves the static struct radeon_asic asic definitions
form radeon_asic.h into the asic-specific files, where I think they belong
--
Daniel Vetter
Mail: dan...@ffwll.ch
Mobile: +41 (0)79 365 57 48
--
Download Intel#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications
radeon_asic.h
contains static struct definitions (i.e. should be a C file) and is
therefore included only exactly _once_. And contains tons of declarations
for the functions it uses. Which are actually in one case not coherent
with the actual definitions!
-Daniel
--
Daniel Vetter
Mail: dan...@ffwll.ch
In essence this creates a home for all asic specific declarations in
radeon_asic.h
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/radeon/evergreen.c |1 +
drivers/gpu/drm/radeon/r100.c |1 +
drivers/gpu/drm/radeon/r200.c |1 +
drivers/gpu/drm/radeon
No one cares about it, so set it to void.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/radeon/radeon.h |2 +-
drivers/gpu/drm/radeon/radeon_asic.h |4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon.h b
). This is just an example
to convince Jerome that radeon_asic.h might not be totally useless ;)
Again, comments higly welcome.
Yours, Daniel
Daniel Vetter (5):
drm/radeon: create radeon_asic.c
drm/radeon: move asic structs to radeon_asic.c
drm/radeon: unconfuse return value of radeon_asic
And move asic init plus a few related functions from radeon_device.c
to it. This file will hold all the asic structures in the future,
but atm they're still stuck in radeon_asic.h.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/radeon/Makefile|2 +-
drivers
This just an example to show what radeon_asic.h might be good for.
Before Jerome kills it ;)
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/radeon/radeon.h | 47 --
drivers/gpu/drm/radeon/radeon_asic.h | 52
With these static structs gone, radeon_asic.h is a real header file
and can be used as such.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/radeon/radeon_asic.c | 487 +
drivers/gpu/drm/radeon/radeon_asic.h | 489
ahead. After all, generic code should not muck around
in the asic private stuff.
Unconditionally including radeon_asic.h therefore runs counter to the
bigger idea behind my patches.
Cheers, Daniel
--
Daniel Vetter
Mail: dan...@ffwll.ch
Mobile: +41 (0)79 365 57 48
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
--
Daniel Vetter
Mail: dan...@ffwll.ch
Mobile: +41 (0)79 365 57 48
--
Download Intel#174
Just preparation, no functional change.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/i915/i915_drv.h |2 ++
drivers/gpu/drm/i915/i915_gem.c | 12 +---
drivers/gpu/drm/i915/intel_display.c |2 +-
drivers/gpu/drm/i915/intel_fb.c |2
This function can be used by drivers who allocate the drm gem object
on their own. No functional change in here, just preparation.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/drm_gem.c | 39 +--
include/drm/drmP.h|2
When drivers embed the core gem object into their own structures,
they'll have to do this. Temporarily this results in an ugly
kfree(gem_obj);
in every gem driver.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/drm_gem.c | 10 +++---
drivers/gpu/drm
Luckily the change is quite a little bit less invasive than I've
feared.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/i915/i915_debugfs.c | 15 +++
drivers/gpu/drm/i915/i915_drv.h |1 -
drivers/gpu/drm/i915/i915_gem.c | 21
Thanks to the to_intel_bo helper, this change is rather trivial.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/i915/i915_drv.h |2 +-
drivers/gpu/drm/i915/i915_gem.c |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915
on the patches and my future plans highly welcome.
Yours, Daniel
Daniel Vetter (6):
drm: extract drm_gem_object_init
drm: free core gem object from driver callbacks
drm/i915: introduce i915_gem_alloc_object
drm/i915: embed the gem object into drm_i915_gem_object
drm/i915: don't use -driver_private
Just embed it and adjust the pointers, No other changes (that's
for later patches).
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/i915/i915_drv.h |1 +
drivers/gpu/drm/i915/i915_gem.c | 58 +++---
2 files changed, 30 insertions
26.714 msecs
[ 1879.677144] ACPI: Preparing to enter system sleep state S3
[ 1879.677144] Back to C!
Does anybody care?
mfg
thomas
--
Daniel Vetter
Mail: dan...@ffwll.ch
Mobile: +41 (0)79 365 57 48
On Mon, Apr 12, 2010 at 10:51:20AM -0700, Eric Anholt wrote:
On Fri, 9 Apr 2010 21:05:03 +0200, Daniel Vetter daniel.vet...@ffwll.ch
wrote:
Daniel Vetter (6):
drm: extract drm_gem_object_init
drm: free core gem object from driver callbacks
drm/i915: introduce
on it (due to my make-gem-embeddable work).
Tested on my agp rv570 and my i945 with no ill effects.
Please review and merge.
Thanks, Daniel
Daniel Vetter (3):
drm: kill drm_agp_chipset_flush
drm: drop return value of drm_free_agp
drm: kill agp indirection mess
drivers/gpu/drm/drm_agpsupport.c
There's no point in jumping through two indirections. So kill one
and call the kernels agp functions directly.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/drm_agpsupport.c | 40 +++--
drivers/gpu/drm/drm_memory.c | 12
for this is a rather gross amount of fragile code duplication
between these two parts of the kernel intel graphics driver.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/drm_agpsupport.c |7 ---
drivers/gpu/drm/i915/i915_gem.c |8
include/drm/drmP.h
No caller (rightly) cares about it, so drop it.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/drm_memory.c |4 ++--
include/drm/drmP.h |2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/drm_memory.c b/drivers/gpu/drm
/listinfo/dri-devel
--
Daniel Vetter
Mail: dan...@ffwll.ch
Mobile: +41 (0)79 365 57 48
--
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
* @newidx.
+ *
+ * This should be called with the console lock held.
*/
static int set_con2fb_map(int unit, int newidx, int user)
{
What about throwing a WARN_CONSOLE_UNLOCKED(); in here to make sure
this new rule is obeyed?
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
--
Android is increasing in popularity, but the open development
81 matches
Mail list logo