Re: [PATCH v6 08/23] modetest: Add a command line parameter to set properties

2013-06-27 Thread Laurent Pinchart
Hi Ville, Thank you for the review. On Monday 24 June 2013 18:08:37 Ville Syrjälä wrote: > On Fri, Jun 14, 2013 at 11:34:42PM +0200, Laurent Pinchart wrote: > > The -w parameter can be used to set a property value from the command > > line, using the target object ID and the property name. > > >

Re: [PATCH v6 00/23] modetest enhancements

2013-06-27 Thread Laurent Pinchart
Hi Jerome, Marek, On Friday 14 June 2013 23:34:34 Laurent Pinchart wrote: > Hello, > > Here's the sixth (and hopefully final) version of my modeset enhancements > patch set. > > Beside various cleanups, these patches allow dropping master after mode set, > configuring more than two pipes and pla

[Bug 66243] New: X display is shifted upwards on GMA500

2013-06-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66243 Priority: medium Bug ID: 66243 Assignee: dri-devel@lists.freedesktop.org Summary: X display is shifted upwards on GMA500 Severity: normal Classification: Unclassified OS: Lin

[Bug 66243] X display is shifted upwards on GMA500

2013-06-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66243 Stéphane Aulery changed: What|Removed |Added See Also||http://bugs.debian.org/7142

Re: [PATCH v2] drm/gem: fix not to assign error value to gem name

2013-06-27 Thread Chris Wilson
On Thu, Jun 27, 2013 at 08:58:33AM +0900, Seung-Woo Kim wrote: > From: YoungJun Cho > > If idr_alloc() is failed, obj->name can be error value. Also > it cleans up duplicated flink processing code. > > This regression has been introduced in > > commit 2e928815c1886fe628ed54623aa98d0889cf5509 >

Re: [PATCH v6 08/23] modetest: Add a command line parameter to set properties

2013-06-27 Thread Ville Syrjälä
On Thu, Jun 27, 2013 at 10:10:43AM +0200, Laurent Pinchart wrote: > Hi Ville, > > Thank you for the review. > > On Monday 24 June 2013 18:08:37 Ville Syrjälä wrote: > > On Fri, Jun 14, 2013 at 11:34:42PM +0200, Laurent Pinchart wrote: > > > The -w parameter can be used to set a property value fro

Re: [PATCH] gpu/host1x: Remove DRIVER_BUS_PLATFORM from driver_features

2013-06-27 Thread Laurent Pinchart
Hi Thierry, On Wednesday 29 May 2013 12:50:40 Thierry Reding wrote: > On Wed, May 29, 2013 at 07:44:34AM +0200, Laurent Pinchart wrote: > > From: Laurent Pinchart > > > > DRIVER_BUS_PLATFORM is not a DRM driver feature flag, it must not be set > > in the driver's driver_features field. > > > >

Re: [PATCH v6 08/23] modetest: Add a command line parameter to set properties

2013-06-27 Thread Laurent Pinchart
On Thursday 27 June 2013 11:31:48 Ville Syrjälä wrote: > On Thu, Jun 27, 2013 at 10:10:43AM +0200, Laurent Pinchart wrote: > > On Monday 24 June 2013 18:08:37 Ville Syrjälä wrote: > > > On Fri, Jun 14, 2013 at 11:34:42PM +0200, Laurent Pinchart wrote: > > > > The -w parameter can be used to set a p

[PATCH 01/24] drm/rcar-du: Add missing alpha plane register definitions

2013-06-27 Thread Laurent Pinchart
Several alpha plane register definitions are missing, add them. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rcar_du_regs.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/rcar-du/rcar_du_regs.h b/drivers/gpu/drm/rcar-du/rcar_du_regs.h index 6

[PATCH 00/24] R-Car DU DRM support for R8A7790

2013-06-27 Thread Laurent Pinchart
Hello, Here's a set of patches that adds support for the DU found in the R8A7790 SoC. Compared to the R8A7779 DU, the R8A7790 has a third CRTC, internal LVDS encoders and different output routing options. These patches are targetted at v3.12 so there's no rush (but please don't take that as an e

[PATCH 02/24] drm/rcar-du: Use devm_ioremap_resource()

2013-06-27 Thread Laurent Pinchart
Replace the devm_request_mem_region() and devm_ioremap_nocache() calls with devm_ioremap_resource(). Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 20 ++-- 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/rcar-du/rcar_du

[PATCH 03/24] drm/rcar-du: Add platform module device table

2013-06-27 Thread Laurent Pinchart
The platform device id driver data field points to a device information structure that only contains a (currently empty) features field for now. Support for additional model-dependent features will be added later. Only the R8A7779 variant is currently supported. Signed-off-by: Laurent Pinchart -

[PATCH 04/24] drm/rcar-du: Don't ignore rcar_du_crtc_create() return value

2013-06-27 Thread Laurent Pinchart
Handle error cases correctly. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rcar_du_kms.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c index 9c63f39..06cacf6 100644 --- a/dr

[PATCH 05/24] drm/rcar-du: Support per-CRTC clock and IRQ

2013-06-27 Thread Laurent Pinchart
Some of the DU revisions use one clock and IRQ per CRTC instead of one clock and IRQ per device. Retrieve the correct clock and register the correct IRQ for each CRTC. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 120 + drivers/gpu/

[PATCH 06/24] drm/rcar-du: Fix buffer pitch alignment

2013-06-27 Thread Laurent Pinchart
The DU requires a 16 pixels pitch alignement. Make sure dumb buffers are allocated with the correct pitch, and validate the pitch when creating frame buffers. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +- drivers/gpu/drm/rcar-du/rcar_du_kms.c | 19 +++

[PATCH 07/24] drm/rcar-du: Clarify comment regarding plane Y source coordinate

2013-06-27 Thread Laurent Pinchart
The R8A7790 DU documentation contains further information regarding the plane Y source coordinate. Update the comment accordingly. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rcar_du_plane.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/

[PATCH 08/24] drm/rcar-du: Split LVDS encoder and connector

2013-06-27 Thread Laurent Pinchart
This prepares for the encoders rework. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/Makefile | 1 + drivers/gpu/drm/rcar-du/rcar_du_lvds.c| 120 +-- drivers/gpu/drm/rcar-du/rcar_du_lvdscon.c | 129 ++ drivers/gpu/d

[PATCH 09/24] drm/rcar-du: Split VGA encoder and connector

2013-06-27 Thread Laurent Pinchart
This prepares for the encoders rework. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/Makefile | 3 +- drivers/gpu/drm/rcar-du/rcar_du_vga.c| 86 + drivers/gpu/drm/rcar-du/rcar_du_vga.h| 2 +- drivers/gpu/drm/rcar-du/rcar_du_vgacon.c | 9

[PATCH 10/24] drm/rcar-du: Merge LVDS and VGA encoder code

2013-06-27 Thread Laurent Pinchart
Create a single rcar_du_encoder structure that implements a KMS encoder. The current implementation is straightforward and only configures CRTC output routing. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/Makefile | 3 +- drivers/gpu/drm/rcar-du/rcar_du_crtc.c| 2

[PATCH 12/24] drm/rcar-du: Create rcar_du_planes structure

2013-06-27 Thread Laurent Pinchart
Move the plane-related fields of struct rcar_du_device to their own structure. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rcar_du_drv.h | 11 +-- drivers/gpu/drm/rcar-du/rcar_du_plane.h | 17 +++-- 2 files changed, 16 insertions(+), 12 deletions(-) diff --

[PATCH 11/24] drm/rcar-du: Rename platform data fields to match what they describe

2013-06-27 Thread Laurent Pinchart
The struct rcar_du_encoder_data encoder::field describes the encoder type, and the rcar_du_encoder_lvds_data and rcar_du_encoder_vga_data structures describe connector properties. Rename them accordingly. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rcar_du_encoder.c | 2 +- driv

[PATCH 13/24] drm/rcar-du: Rename rcar_du_plane_(init|register) to rcar_du_planes_*

2013-06-27 Thread Laurent Pinchart
The functions initialize or register all planes, rename them accordingly. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rcar_du_kms.c | 4 ++-- drivers/gpu/drm/rcar-du/rcar_du_plane.c | 4 ++-- drivers/gpu/drm/rcar-du/rcar_du_plane.h | 5 +++-- 3 files changed, 7 insertions(+), 6

[PATCH 14/24] drm/rcar-du: Introduce CRTCs groups

2013-06-27 Thread Laurent Pinchart
The R8A7779 DU is split in per-CRTC resources (scan-out engine, blending unit, timings generator, ...) and device-global resources (start/stop control, planes, ...) shared between the two CRTCs. The R8A7790 introduced a third CRTC with its own set of global resources This would be modeled as two s

[PATCH 15/24] drm/rcar-du: Use dynamic number of CRTCs instead of CRTCs array size

2013-06-27 Thread Laurent Pinchart
The rcar_du_device structure contains a field that stores the number of CRTCs, use it instead of the CRTCs array size. This prepares the driver to support a variable number of CRTCs. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +- drivers/gpu/drm/rcar-du/rcar_du

[PATCH 16/24] drm/rcar-du: Remove register definitions for the second channel

2013-06-27 Thread Laurent Pinchart
Channels are accessed through a global channel memory offset, there's no need to define register addresses for the second channel. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rcar_du_regs.h | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/gpu/drm/rcar-du/rcar_d

[PATCH 17/24] drm/rcar-du: Move output routing configuration to group

2013-06-27 Thread Laurent Pinchart
Output routing is configured in group registers, move the corresponding code from rcar_du_crtc.c to rcar_du_group.c. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 21 + drivers/gpu/drm/rcar-du/rcar_du_group.c | 19 +++ drivers/g

[PATCH 18/24] drm/rcar-du: Add support for the R8A7790 DU

2013-06-27 Thread Laurent Pinchart
The DU revision in the R8A7790 SoC uses one IRQ and clock per CRTC. Add a corresponding entry in the module platform ID table. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 5 +++ drivers/gpu/drm/rcar-du/rcar_du_regs.h | 66 -- 2 fi

[PATCH 19/24] drm/rcar-du: Fix buffer pitch alignment for R8A7790 DU

2013-06-27 Thread Laurent Pinchart
The R8A7790 DU seems to require a 128 bytes pitch alignment, even though the documentation only mentions a 16 pixels alignement as for the R8A7779 DU. Make this configurable through a device flag. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +- drivers/gpu/drm/

[PATCH 20/24] drm/rcar-du: Add support for multiple groups

2013-06-27 Thread Laurent Pinchart
The R8A7790 DU has 3 CRTCs, split in two groups. Support them. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 25 ++- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 ++ drivers/gpu/drm/rcar-du/rcar_du_drv.h | 6 +++-- drivers/gpu/drm/rcar-du/rcar_d

[PATCH 21/24] drm/rcar-du: Add support for DEFR8 register

2013-06-27 Thread Laurent Pinchart
The R8A7790 DU has a new extended function control register. Support it. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 3 ++- drivers/gpu/drm/rcar-du/rcar_du_drv.h | 1 + drivers/gpu/drm/rcar-du/rcar_du_group.c | 2 ++ 3 files changed, 5 insertions(+), 1 deletio

[PATCH 22/24] drm/rcar-du: Rework output routing support

2013-06-27 Thread Laurent Pinchart
Split the output routing specification between SoC-internal data, specified in the rcar_du_device_info structure, and board data, passed through platform data. The DU has 5 possible outputs (DPAD0/1, LVDS0/1, TCON). SoC-internal output routing data specify which output are valid, which CRTCs can b

[PATCH 23/24] drm/rcar-du: Configure RGB output routing to DPAD0

2013-06-27 Thread Laurent Pinchart
The R8A7790 DU variant has a single RGB output called DPAD0 that can be fed with the output of DU0, DU1 or DU2. Making the routing configurable. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 5 drivers/gpu/drm/rcar-du/rcar_du_drv.h | 2 ++ drivers/gpu/drm

[PATCH 24/24] drm/rcar-du: Add internal LVDS encoder support

2013-06-27 Thread Laurent Pinchart
The R8A7790 includes two internal LVDS encoders. Support them in the DU driver. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/Kconfig | 7 ++ drivers/gpu/drm/rcar-du/Makefile | 4 +- drivers/gpu/drm/rcar-du/rcar_du_crtc.c| 2 - drivers/gpu/drm/rcar-du/r

Re: [PATCH] gpu/host1x: Remove DRIVER_BUS_PLATFORM from driver_features

2013-06-27 Thread Thierry Reding
On Thu, Jun 27, 2013 at 11:09:39AM +0200, Laurent Pinchart wrote: > Hi Thierry, > > On Wednesday 29 May 2013 12:50:40 Thierry Reding wrote: > > On Wed, May 29, 2013 at 07:44:34AM +0200, Laurent Pinchart wrote: > > > From: Laurent Pinchart > > > > > > DRIVER_BUS_PLATFORM is not a DRM driver featu

Re: [PATCH V2 0/7] drm/tilcdc: bug fixes, mode selection improvements

2013-06-27 Thread Pantelis Antoniou
Hi Rob, On Jun 26, 2013, at 6:42 PM, Rob Clark wrote: > On Fri, Jun 21, 2013 at 2:52 PM, Darren Etheridge wrote: >> The series of patches that follow are intended to address issues that >> have been found in the tilcdc drm driver. The patchset enables support >> for screen resolutions with horiz

[PATCH] drm: drm_stub: Fixing return value if driver master_set call failed

2013-06-27 Thread Benjamin GAIGNARD
From: Benjamin Gaignard When dev->driver->master_set() failed ioctl call return 0 but the caller is not the DRM-Master because file_priv->is_master = 0. Fix that by returning to ioctl caller the driver master_set error code. Signed-off-by: Benjamin Gaignard --- drivers/gpu/drm/drm_stub.c |

Re: Armada DRM driver on OLPC XO

2013-06-27 Thread Jean-Francois Moine
On Tue, 25 Jun 2013 16:47:26 -0400 (EDT) Daniel Drake wrote: > Hi Russell, > > Thanks a lot for writing the Armada DRM driver. > > I have tested it on OLPC XO-1.75 (MMP2 aka Armada610) and OLPC XO-4 (MMP3 > aka PXA2128). After a bit of fighting, I have it running. Could you share your > X drive

Re: Armada DRM driver on OLPC XO

2013-06-27 Thread Russell King - ARM Linux
On Wed, Jun 26, 2013 at 06:42:50PM +0200, Jean-Francois Moine wrote: > Do you know that there are 2 drm drivers for the Cubox? I posted mine > (http://lists.infradead.org/pipermail/linux-arm-kernel/2013-May/168732.html) > before Russell, but I got no return about it yet. > > As it uses the CMA hel

Re: 'Timed out waiting for forcewake old ack to clear' and hangup on IvyBridge system

2013-06-27 Thread Guenter Roeck
On Wed, Jun 26, 2013 at 09:24:07AM -0700, Jesse Barnes wrote: > On Sat, 22 Jun 2013 13:04:09 -0700 > Guenter Roeck wrote: > > > On Sat, Jun 22, 2013 at 12:16:46PM -0700, Jesse Barnes wrote: > > > On Fri, 21 Jun 2013 23:58:08 -0700 > > > Guenter Roeck wrote: > > > > > > > Hi all, > > > > > > >

Re: [RFC PATCH v2] dmabuf-sync: Introduce buffer synchronization framework

2013-06-27 Thread Russell King - ARM Linux
On Tue, Jun 25, 2013 at 11:23:21AM +0200, Daniel Vetter wrote: > Just a quick question on your assertion that we need all four > functions: Since we already have begin/end_cpu_access functions > (intention here was to allow the dma_buf exporter to ensure the memory > is pinned, e.g. for swapable ge

Re: Packard Bell EasyNote LV need i915.invert_brightness=1

2013-06-27 Thread Petter Reinholdtsen
[Daniel Vetter] >> Is there some other quirk table for acpi that also need to be updated? > > If the acpi brightness controller is broken, it needs to be quirked > away. For that please file a bug report against the ACPI subsystem. Right. Where do I do that? I can do it if I know what to do. :

RADEON / DPM: GPU cannot properly up-clock

2013-06-27 Thread Joshua C.
First of all thank you guys for pushing this out! Great work! I tried the latest code in drm-next-3.11-wip (up to commit b3c1e0c3ba885db44 “drm/radeon: fix endian issues in atombios dpm code”) in connection with the latest radeon_ucode (latest update on 2013-06-26). I also reintroduced the debugfs

Re: RADEON / DPM: GPU cannot properly up-clock

2013-06-27 Thread Joshua C.
2013/6/26 Deucher, Alexander : > > >> -Original Message- >> From: Joshua C. [mailto:joshua...@gmail.com] >> Sent: Wednesday, June 26, 2013 1:52 PM >> To: dri-devel@lists.freedesktop.org >> Cc: Deucher, Alexander >> Subject: RADEON / DPM: GPU cannot properly up-clock >> >> First of all thank

[PATCH 000/165] radeon drm-next patches

2013-06-27 Thread Julian Wollrath
Hi, I just tried the DPM support out on a E-450 APU (HD6320) and it did not work like expected. In the terminal everything seemed ok but when I started a display manager, the screen showed garbage and the system basically locked up. The radeon and drm related parts of the syslog are below. If you

Re: [PATCH 000/165] radeon drm-next patches

2013-06-27 Thread Julian Wollrath
Hi, > I just tried the DPM support out on a E-450 APU (HD6320) and it did > not work like expected. In the terminal everything seemed ok but when > I started a display manager, the screen showed garbage and the system > basically locked up. The radeon and drm related parts of the syslog > are belo

Re: Armada DRM driver on OLPC XO

2013-06-27 Thread Russell King - ARM Linux
On Tue, Jun 25, 2013 at 04:47:26PM -0400, Daniel Drake wrote: > Hi Russell, > > Thanks a lot for writing the Armada DRM driver. > > I have tested it on OLPC XO-1.75 (MMP2 aka Armada610) and OLPC XO-4 (MMP3 > aka PXA2128). After a bit of fighting, I have it running. Could you share your > X driver

Re: [PATCH v2 1/1] drm/mgag200: Added resolution and bandwidth limits for various G200e products.

2013-06-27 Thread Dave Airlie
> At the larger resolutions, the g200e series sometimes struggles with > maintaining a proper output. Problems like flickering or black bands > appearing > on screen can occur. In order to avoid this, limitations regarding > resolutions > and bandwidth have been added for the different variatio

[PATCH 1/9] drm/radeon: implement unpin function, v2

2013-06-27 Thread Maarten Lankhorst
Changes since v1: - Fixup compiler warning in unpin function. Signed-off-by: Maarten Lankhorst Reviewed-by: Jerome Glisse Acked-by: Alex Deucher --- drivers/gpu/drm/radeon/radeon_drv.c | 2 ++ drivers/gpu/drm/radeon/radeon_prime.c | 18 +- 2 files changed, 15 insertions(+),

[PATCH 2/9] drm/nouveau: implement prime helper unpin function

2013-06-27 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/nouveau/nouveau_drm.c | 1 + drivers/gpu/drm/nouveau/nouveau_gem.h | 1 + drivers/gpu/drm/nouveau/nouveau_prime.c | 9 - 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers

[PATCH 3/9] drm/nouveau: unpin notify object in chan_fini

2013-06-27 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/nouveau/nouveau_abi16.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/nouveau/nouveau_abi16.c b/drivers/gpu/drm/nouveau/nouveau_abi16.c index 1c4c6c9..8f467e7 100644 --- a/drivers/gpu/drm/nouveau/nouveau_abi16.c +++ b/dri

[PATCH 4/9] drm/nouveau: fixup fbcon failure paths

2013-06-27 Thread Maarten Lankhorst
Add missing calls, and fix a leak from forgetting to call the unpin function. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/nouveau/nouveau_fbcon.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.c b/drive

[PATCH 5/9] drm/nouveau: complain loudly if buffer is pinned during destruction

2013-06-27 Thread Maarten Lankhorst
Shouldn't happen, and we invert the struct_mutex with reservation here, potentially leading to deadlocks. Once reservations become lockdep annotated, lockdep will go splat on this. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/nouveau/nouveau_gem.c | 3 ++- 1 file changed, 2 insertions(+)

[PATCH 6/9] drm/nouveau: always select ACPI_VIDEO if ACPI is enabled.

2013-06-27 Thread Maarten Lankhorst
Having nouveau builtin would still allow ACPI_VIDEO to be used as external module if some of the deps for acpi_video have not been met, which would result in a linking failure. Solve this by selecting all dependencies as well. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/Kconfig

[PULL] final drm-intel-next pull for 3.11

2013-06-27 Thread Daniel Vetter
Hi Dave, Last 3.11 feature pull. I have a few odds bits and pieces and fixes in my queue, I'll sort them out later on to see what's for 3.11-fixes and what's for 3.12. But nothing to hold this here up imo. Highlights: - more hangcheck work from Mika and Chris to prepare for arb robustness - trick

[PATCH 7/9] drm/cirrus: do not attempt to acquire a reservation while in an interrupt handler

2013-06-27 Thread Maarten Lankhorst
Mutexes should not be acquired in interrupt context. While the trylock fastpath is arguably safe on all implementations, the slowpath unlock path definitely isn't. This fixes the following lockdep splat: [ 13.044313] [ cut here ] [ 13.044367] WARNING: at /c/kernel-tests

[PATCH 8/9] drm/mgag200: do not attempt to acquire a reservation while in an interrupt handler

2013-06-27 Thread Maarten Lankhorst
Mutexes should not be acquired in interrupt context. While the trylock fastpath is arguably safe on all implementations, the slowpath unlock path definitely isn't. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/mgag200/mgag200_fb.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

[PATCH 9/9] drm/ast: do not attempt to acquire a reservation while in an interrupt handler

2013-06-27 Thread Maarten Lankhorst
Mutexes should not be acquired in interrupt context. While the trylock fastpath is arguably safe on all implementations, the slowpath unlock path definitely isn't. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/ast/ast_fb.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff -

[PATCH WW 00/13] Convert TTM to Wound/wait mutexes.

2013-06-27 Thread Maarten Lankhorst
With all the previous fixes in place, and my previous patch series applied to prevent fallout, it's time to throw the switch! Thanks to Deveryone who made this possible, in particular danvet, robclark, airlied and peterz. The first 4 patches are the real meat, the rest is just some cleanups. Maa

[PATCH WW 01/13] reservation: cross-device reservation support, v4

2013-06-27 Thread Maarten Lankhorst
This adds support for a generic reservations framework that can be hooked up to ttm and dma-buf and allows easy sharing of reservations across devices. The idea is that a dma-buf and ttm object both will get a pointer to a struct reservation_object, which has to be reserved before anything is done

[PATCH WW 02/13] drm/ttm: make ttm reservation calls behave like reservation calls

2013-06-27 Thread Maarten Lankhorst
This commit converts the source of the val_seq counter to the ww_mutex api. The reservation objects are converted later, because there is still a lockdep splat in nouveau that has to resolved first. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/nouveau/nouveau_gem.c| 38 ++

[PATCH WW 03/13] drm/nouveau: make flipping lockdep safe

2013-06-27 Thread Maarten Lankhorst
cli->mutex was inverted with reservations, and multiple reservations were used without a ticket, fix both. This commit had to be done after the previous commit, because otherwise ttm_eu_* calls would use a different seqno counter.. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/nouveau/nou

[PATCH WW 04/13] drm/ttm: convert to the reservation api

2013-06-27 Thread Maarten Lankhorst
Now that the code is compatible in semantics, flip the switch. Use ww_mutex instead of the homegrown implementation. ww_mutex uses -EDEADLK to signal that the caller has to back off, and -EALREADY to indicate this buffer is already held by the caller. ttm used -EAGAIN and -EDEADLK for those, resp

[PATCH WW 05/13] drm/ast: inline reservations

2013-06-27 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/ast/ast_drv.h | 20 ++-- drivers/gpu/drm/ast/ast_ttm.c | 18 -- 2 files changed, 18 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_drv.h b/drivers/gpu/drm/ast/ast_drv.h index 02e52d5..622d4a

[PATCH WW 06/13] drm/cirrus: inline reservations

2013-06-27 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/cirrus/cirrus_drv.h | 21 +++-- drivers/gpu/drm/cirrus/cirrus_ttm.c | 18 -- 2 files changed, 19 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/cirrus/cirrus_drv.h b/drivers/gpu/drm/cirrus/cirrus_d

[PATCH WW 07/13] drm/mgag200: inline reservations

2013-06-27 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/mgag200/mgag200_drv.h | 20 ++-- drivers/gpu/drm/mgag200/mgag200_ttm.c | 18 -- 2 files changed, 18 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.h b/drivers/gpu/drm/mgag200/mg

[PATCH WW 08/13] drm/radeon: inline reservations

2013-06-27 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/radeon/radeon_object.c | 23 --- drivers/gpu/drm/radeon/radeon_object.h | 22 +- 2 files changed, 21 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/

[PATCH WW 09/13] drm/ttm: inline ttm_bo_reserve and related calls

2013-06-27 Thread Maarten Lankhorst
Makes lockdep a lot more useful. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/ttm/ttm_bo.c | 105 ++-- drivers/gpu/drm/ttm/ttm_execbuf_util.c | 9 +- include/drm/ttm/ttm_bo_driver.h| 175 - 3 files changed, 117 insertion

[PATCH WW 10/13] drm/ttm: get rid of ttm_bo_is_reserved usage

2013-06-27 Thread Maarten Lankhorst
Use lockdep_assert_held instead. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/ttm/ttm_bo.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index a8a27f5..6e6975c 100644 --- a/drivers/gpu/drm/ttm/ttm_b

[PATCH WW 11/13] drm/radeon: get rid of ttm_bo_is_reserved usage

2013-06-27 Thread Maarten Lankhorst
Try to use lockdep_assert_held or other alternatives where possible. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/radeon/radeon_object.c | 8 ++-- drivers/gpu/drm/radeon/radeon_object.h | 5 --- drivers/gpu/drm/radeon/radeon_test.c | 75 +- 3 files cha

[PATCH WW 12/13] drm/vmwgfx: get rid of ttm_bo_is_reserved usage

2013-06-27 Thread Maarten Lankhorst
Use lockdep_assert_held instead. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/vmwgfx/vmwgfx_dmabuf.c | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_resource.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_dmabuf.c b/drivers/gpu/drm/vmwgf

[PATCH WW 13/13] drm/ttm: get rid of ttm_bo_is_reserved

2013-06-27 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- include/drm/ttm/ttm_bo_api.h | 14 -- 1 file changed, 14 deletions(-) diff --git a/include/drm/ttm/ttm_bo_api.h b/include/drm/ttm/ttm_bo_api.h index 31ad860..8a6aa56 100644 --- a/include/drm/ttm/ttm_bo_api.h +++ b/include/drm/ttm/ttm_bo_api.h @@ -

Re: [PATCH WW 09/13] drm/ttm: inline ttm_bo_reserve and related calls

2013-06-27 Thread Daniel Vetter
On Thu, Jun 27, 2013 at 01:48:24PM +0200, Maarten Lankhorst wrote: > Makes lockdep a lot more useful. > > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/ttm/ttm_bo.c | 105 ++-- > drivers/gpu/drm/ttm/ttm_execbuf_util.c | 9 +- > include/drm/ttm/ttm_bo_driver

Re: [PATCH WW 10/13] drm/ttm: get rid of ttm_bo_is_reserved usage

2013-06-27 Thread Daniel Vetter
On Thu, Jun 27, 2013 at 01:48:25PM +0200, Maarten Lankhorst wrote: > Use lockdep_assert_held instead. > > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/ttm/ttm_bo.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers

Re: Packard Bell EasyNote LV need i915.invert_brightness=1

2013-06-27 Thread Daniel Vetter
On Wed, Jun 26, 2013 at 7:35 PM, Petter Reinholdtsen wrote: > [Daniel Vetter] >>> Is there some other quirk table for acpi that also need to be updated? >> >> If the acpi brightness controller is broken, it needs to be quirked >> away. For that please file a bug report against the ACPI subsystem.

Re: [PATCH v2] drm/gem: add mutex lock when using drm_gem_mmap_obj

2013-06-27 Thread Laurent Pinchart
Hi, On Thursday 27 June 2013 08:39:58 Seung-Woo Kim wrote: > From: YoungJun Cho > > The drm_gem_mmap_obj() has to be protected with dev->struct_mutex, > but some caller functions do not. So it adds mutex lock to missing > callers and adds assertion to check whether drm_gem_mmap_obj() is > calle

Re: [PATCH 000/165] radeon drm-next patches

2013-06-27 Thread Andy Furniss
Alex Deucher wrote: On Wed, Jun 26, 2013 at 9:21 AM, wrote: From: Alex Deucher These are the radeon patches for 3.11. Some of these patches are huge so, it might be easier to review things here: http://cgit.freedesktop.org/~agd5f/linux/log/?h=drm-next-3.11-wip Updated branch: http://cgit.

Re: Packard Bell EasyNote LV need i915.invert_brightness=1

2013-06-27 Thread Petter Reinholdtsen
[Daniel Vetter] > acpi_backlight=vendor should disable the acpi backlights (you can > check that in /sys/class/backlight), which would mean that userspace > should fall back to intel backlight driver. Can you please check > whether that one works even without the invert_brightness knob? I.e. > not

Re: [PATCH 02/24] drm/rcar-du: Use devm_ioremap_resource()

2013-06-27 Thread Sergei Shtylyov
Hello. On 27-06-2013 13:49, Laurent Pinchart wrote: Replace the devm_request_mem_region() and devm_ioremap_nocache() calls with devm_ioremap_resource(). Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 20 ++-- 1 file changed, 2 insertions(+), 1

Re: Packard Bell EasyNote LV need i915.invert_brightness=1

2013-06-27 Thread Daniel Vetter
On Thu, Jun 27, 2013 at 3:03 PM, Petter Reinholdtsen wrote: > [Daniel Vetter] >> acpi_backlight=vendor should disable the acpi backlights (you can >> check that in /sys/class/backlight), which would mean that userspace >> should fall back to intel backlight driver. Can you please check >> whether

Re: [PATCH v2] drm/gem: add mutex lock when using drm_gem_mmap_obj

2013-06-27 Thread Rob Clark
On Wed, Jun 26, 2013 at 7:39 PM, Seung-Woo Kim wrote: > From: YoungJun Cho > > The drm_gem_mmap_obj() has to be protected with dev->struct_mutex, > but some caller functions do not. So it adds mutex lock to missing > callers and adds assertion to check whether drm_gem_mmap_obj() is > called with

Re: [PATCH v2] drm/gem: add mutex lock when using drm_gem_mmap_obj

2013-06-27 Thread Maarten Lankhorst
Op 27-06-13 01:39, Seung-Woo Kim schreef: > From: YoungJun Cho > > The drm_gem_mmap_obj() has to be protected with dev->struct_mutex, > but some caller functions do not. So it adds mutex lock to missing > callers and adds assertion to check whether drm_gem_mmap_obj() is > called with mutex lock or

Re: [PATCH 000/165] radeon drm-next patches

2013-06-27 Thread Jerome Glisse
On Wed, Jun 26, 2013 at 6:51 PM, Julian Wollrath wrote: > Hi, > >> I just tried the DPM support out on a E-450 APU (HD6320) and it did >> not work like expected. In the terminal everything seemed ok but when >> I started a display manager, the screen showed garbage and the system >> basically lock

Re: [PATCH 000/165] radeon drm-next patches

2013-06-27 Thread Alex Deucher
On Thu, Jun 27, 2013 at 9:12 AM, Andy Furniss wrote: > Alex Deucher wrote: >> >> On Wed, Jun 26, 2013 at 9:21 AM, wrote: >>> >>> From: Alex Deucher >>> >>> These are the radeon patches for 3.11. Some of these patches >>> are huge so, it might be easier to review things here: >>> http://cgit.fr

[Bug 64695] Enabling both MLAA and MLAA color 2D crashes Gnome Shell on Cayman (6950)

2013-06-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64695 --- Comment #4 from Brian Paul --- I'm going to push this patch since it fixes some issues we've seen here. -- You are receiving this mail because: You are the assignee for the bug. ___ dri-devel mail

Re: RADEON / DPM: GPU cannot properly up-clock

2013-06-27 Thread Alex Deucher
On Wed, Jun 26, 2013 at 4:57 PM, Joshua C. wrote: > 2013/6/26 Deucher, Alexander : >> >> >>> -Original Message- >>> From: Joshua C. [mailto:joshua...@gmail.com] >>> Sent: Wednesday, June 26, 2013 1:52 PM >>> To: dri-devel@lists.freedesktop.org >>> Cc: Deucher, Alexander >>> Subject: RADEON

[Bug 65873] R600/SI: Cannot select store with truncate to 32-bit

2013-06-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65873 --- Comment #7 from Tom Stellard --- The SI backend needs to be fixed so it can handle zext i64 loads, but there is also a bug in libclc. The vload implementation assumes pointer types are 32-bit: define <2 x i32> @__clc_vload2_impl_i32__global

[PATCH v3 0/1] drm/mgag200: Added resolution and bandwidth limits for various G200e products.

2013-06-27 Thread Julia Lemire
I fixed all of the formatting errors found by scripts/checkpatch.pl. Julia Lemire (1): drm/mgag200: Added resolution and bandwidth limits for various G200e products. drivers/gpu/drm/mgag200/mgag200_drv.h |3 +- drivers/gpu/drm/mgag200/mgag200_main.c |2 +- drivers/gpu/drm/mgag200/

[PATCH v3 1/1] drm/mgag200: Added resolution and bandwidth limits for various G200e products.

2013-06-27 Thread Julia Lemire
At the larger resolutions, the g200e series sometimes struggles with maintaining a proper output. Problems like flickering or black bands appearing on screen can occur. In order to avoid this, limitations regarding resolutions and bandwidth have been added for the different variations of the g200

[Bug 65873] R600/SI: Cannot select store with truncate to 32-bit

2013-06-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65873 --- Comment #8 from Aaron Watry --- "Pointers on SI are 64-bit." Talk about a "duh" moment. I'll see what I can do to fix and test the vload/vstore implementation pointer generation since this is broken on SI, maybe 64-bit PTX, and would also be

[Bug 66243] X display is shifted upwards on GMA500

2013-06-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66243 Patrik Jakobsson changed: What|Removed |Added Assignee|dri-devel@lists.freedesktop |patrik.r.jakobs...@gmail.co

[PULL] drm/tegra: Changes for v3.11-rc1

2013-06-27 Thread Thierry Reding
Hi Dave, The following changes since commit c7788792a5e7b0d5d7f96d0766b4cb6112d47d75: Linux 3.10-rc2 (2013-05-20 14:37:38 -0700) are available in the git repository at: git://anongit.freedesktop.org/tegra/linux.git drm/for-next for you to fetch changes up to ebae30b1fbcc2cc991ce705cc82e16d

[Bug 63599] [r600][r600] GPU lockup CP stall (kernel 3.2.47, 3.4, 3.8, 3.9)

2013-06-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=63599 wojtek changed: What|Removed |Added Summary|[r600][r600] GPU lockup CP |[r600][r600] GPU lockup CP |s

[Bug 65873] R600/SI: Cannot select store with truncate to 32-bit

2013-06-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65873 --- Comment #9 from Tom Stellard --- The piglit test should work with this patch: http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20130624/179364.html But we should still try to fix the bug in libclc. -- You are receiving this mail

Re: [PATCH WW 01/13] reservation: cross-device reservation support, v4

2013-06-27 Thread Jerome Glisse
On Thu, Jun 27, 2013 at 01:48:16PM +0200, Maarten Lankhorst wrote: > This adds support for a generic reservations framework that can be > hooked up to ttm and dma-buf and allows easy sharing of reservations > across devices. > > The idea is that a dma-buf and ttm object both will get a pointer > t

Re: [PATCH WW 02/13] drm/ttm: make ttm reservation calls behave like reservation calls

2013-06-27 Thread Jerome Glisse
On Thu, Jun 27, 2013 at 01:48:17PM +0200, Maarten Lankhorst wrote: > This commit converts the source of the val_seq counter to > the ww_mutex api. The reservation objects are converted later, > because there is still a lockdep splat in nouveau that has to > resolved first. > > Signed-off-by: Maart

Re: [PATCH WW 04/13] drm/ttm: convert to the reservation api

2013-06-27 Thread Jerome Glisse
On Thu, Jun 27, 2013 at 01:48:19PM +0200, Maarten Lankhorst wrote: > Now that the code is compatible in semantics, flip the switch. > Use ww_mutex instead of the homegrown implementation. > > ww_mutex uses -EDEADLK to signal that the caller has to back off, > and -EALREADY to indicate this buffer

Re: [PATCH WW 08/13] drm/radeon: inline reservations

2013-06-27 Thread Jerome Glisse
On Thu, Jun 27, 2013 at 01:48:23PM +0200, Maarten Lankhorst wrote: > Signed-off-by: Maarten Lankhorst Reviewed-by: Jerome Glisse > --- > drivers/gpu/drm/radeon/radeon_object.c | 23 --- > drivers/gpu/drm/radeon/radeon_object.h | 22 +- > 2 files changed,

Re: [PATCH WW 11/13] drm/radeon: get rid of ttm_bo_is_reserved usage

2013-06-27 Thread Jerome Glisse
On Thu, Jun 27, 2013 at 01:48:26PM +0200, Maarten Lankhorst wrote: > Try to use lockdep_assert_held or other alternatives where possible. > > Signed-off-by: Maarten Lankhorst Reviewed-by: Jerome Glisse > --- > drivers/gpu/drm/radeon/radeon_object.c | 8 ++-- > drivers/gpu/drm/radeon/radeon_o

[Bug 65873] R600/SI: Cannot select store with truncate to 32-bit

2013-06-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65873 --- Comment #10 from Aaron Watry --- I've got a draft fix in my libclc repo on fdo.o. I've tested for regressions on Cedar (successfully), and I will test on SI with your 64-bit load patch asap (hopefully tonight, but we'll see). -- You are re

Re: [PATCH 000/165] radeon drm-next patches

2013-06-27 Thread James Cloos
> "AD" == Alex Deucher writes: AD> Nope. 6xx and APUs do not require ucode. only 7xx+ dGPUs. Does that mean that APUs do not require *any* ucode blobs? Or just that they do not require updated or additional blobs for the new functionality like DPM? -JimC -- James Cloos OpenPGP:

  1   2   3   >