[PATCH v2 12/16] drm/sun4i: Add support for H3 HDMI PHY variant

2018-02-28 Thread Jernej Skrabec
While A83T HDMI PHY seems to be just customized Synopsys HDMI PHY, H3 HDMI PHY is completely custom PHY. However, they still have many things in common like clock and reset setup, setting sync polarity and more. Add support for H3 HDMI PHY variant. While documentation exists for this PHY variant

[PATCH v2 00/16] Implement H3/H5 HDMI driver

2018-02-28 Thread Jernej Skrabec
This series implements H3/H5 HDMI driver. It was tested on OrangePi 2 (H3), OrangePi Plus2e (H3) and OrangePi PC2 (H5) with many resolutions and it works well. Bug, which prevented correct operation for some resolutions, is also fixed. Code is based on linux-next, next-20180226 tag. Best regards,

Re: [PATCH v3 05/10] pwm: add PWM mode to pwm_config()

2018-02-28 Thread Claudiu Beznea
On 27.02.2018 12:54, Daniel Thompson wrote: > On Mon, Feb 26, 2018 at 04:24:15PM +0200, Claudiu Beznea wrote: >> On 26.02.2018 11:57, Jani Nikula wrote: >>> On Thu, 22 Feb 2018, Daniel Thompson wrote: On Thu, Feb 22, 2018 at 02:01:16PM +0200, Claudiu Beznea wrote: > Add PWM mode to pwm_

Re: [PATCH v5 6/6] drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL

2018-02-28 Thread Chanwoo Choi
Hi, On 2018년 02월 27일 21:05, Andrzej Hajda wrote: > On 27.02.2018 12:08, Chanwoo Choi wrote: >> Hi, >> >> On 2018년 02월 27일 16:11, Andrzej Hajda wrote: >>> From: Maciej Purski >>> >>> Currently MHL chip must be turned on permanently to detect MHL cable. It >>> duplicates micro-USB controller's (MUI

Re: [PATCH 2/2] selftests: ion: Add simple test with the vgem driver

2018-02-28 Thread Shuah Khan
On 02/26/2018 06:48 PM, Laura Abbott wrote: > On 02/26/2018 09:07 AM, Shuah Khan wrote: >> On 02/19/2018 11:33 AM, Daniel Vetter wrote: >>> On Mon, Feb 19, 2018 at 10:18:21AM -0800, Laura Abbott wrote: On 02/19/2018 07:31 AM, Daniel Vetter wrote: > On Thu, Feb 15, 2018 at 05:24:45PM -0800,

[PATCH v2 03/16] clk: sunxi-ng: h3: h5: Allow some clocks to set parent rate

2018-02-28 Thread Jernej Skrabec
Some units have to be able to set it's own clock precisely to work correctly. Allow them to do so by adding CLK_SET_RATE_PARENT flag. Add this flag to DE, TCON and HDMI clocks. Signed-off-by: Jernej Skrabec --- drivers/clk/sunxi-ng/ccu-sun8i-h3.c | 9 ++--- 1 file changed, 6 insertions(+),

[PATCH v2 14/16] ARM: dts: sunxi: h3/h5: Add HDMI pipeline

2018-02-28 Thread Jernej Skrabec
This commit adds all entries needed for HDMI to function properly. Signed-off-by: Jernej Skrabec --- arch/arm/boot/dts/sunxi-h3-h5.dtsi | 108 + 1 file changed, 108 insertions(+) diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5

[PATCH v2 07/16] drm/sun4i: Add support for H3 display engine

2018-02-28 Thread Jernej Skrabec
H3 display engine has two mixers which are connected to HDMI and TV output. Signed-off-by: Jernej Skrabec --- drivers/gpu/drm/sun4i/sun4i_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c index 3957c2ff6870..a0f43b81c

[PATCH v2 09/16] drm/sun4i: Fix polarity configuration for DW HDMI PHY

2018-02-28 Thread Jernej Skrabec
Current polarity configuration code is cleary wrong since it compares same flag two times. However, even if flag name is fixed, it won't work well for resolutions which have one polarity positive and another negative. Fix that by properly set each bit according to each polarity. Since those two bi

[PATCH v2 16/16] ARM64: dts: sun50i: h5: Enable HDMI output on H5 boards

2018-02-28 Thread Jernej Skrabec
Enable HDMI output on all boards with HDMI connector. Signed-off-by: Jernej Skrabec --- .../boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts | 25 ++ .../dts/allwinner/sun50i-h5-orangepi-prime.dts | 25 ++ .../allwinner/sun50i-h5-orangepi-zero-plus2.dts

[PATCH v2 15/16] ARM: dts: sun8i: h3: Enable HDMI output on H3 boards

2018-02-28 Thread Jernej Skrabec
Enable HDMI output on all boards which have HDMI connector. Signed-off-by: Jernej Skrabec --- arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts| 25 ++ arch/arm/boot/dts/sun8i-h3-beelink-x2.dts | 25 ++ arch/arm/boot/dts/sun8i-h3-libretech-all-h

Re: [linux-sunxi] [PATCH 14/15] ARM: dts: sun8i: h3: Enable HDMI output on H3 boards

2018-02-28 Thread Julian Calaby
Hi Maxime, On Tue, Feb 27, 2018 at 6:07 PM, Maxime Ripard wrote: > On Tue, Feb 27, 2018 at 01:29:27PM +1100, Julian Calaby wrote: >> Hi Jernej, >> >> On Tue, Feb 27, 2018 at 3:27 AM, Jernej Škrabec >> wrote: >> > Hi, >> > >> > Dne ponedeljek, 26. februar 2018 ob 17:21:05 CET je Icenowy Zheng >

[PATCH v2 08/16] drm/sun4i: Add support for H3 mixer 0

2018-02-28 Thread Jernej Skrabec
This mixer supports 1 VI plane, 3 UI plane and HW scaling on all planes. Signed-off-by: Jernej Skrabec --- drivers/gpu/drm/sun4i/sun8i_mixer.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.c b/drivers/gpu/drm/sun4i/sun8i_mixer.c index 9b0256

Re: [PATCH v5 6/6] drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL

2018-02-28 Thread Chanwoo Choi
Hi, On 2018년 02월 27일 16:11, Andrzej Hajda wrote: > From: Maciej Purski > > Currently MHL chip must be turned on permanently to detect MHL cable. It > duplicates micro-USB controller's (MUIC) functionality and consumes > unnecessary power. Lets use extcon attached to MUIC to enable MHL chip > onl

[PATCH v2 04/16] clk: sunxi-ng: h3: h5: export CLK_PLL_VIDEO

2018-02-28 Thread Jernej Skrabec
CLK_PLL_VIDEO needs to be referenced in HDMI DT entry as a possible PHY clock parent. Export it so it can be used later in DT. Signed-off-by: Jernej Skrabec --- drivers/clk/sunxi-ng/ccu-sun8i-h3.h | 4 +++- include/dt-bindings/clock/sun8i-h3-ccu.h | 2 ++ 2 files changed, 5 insertions(+),

Re: [PATCH v5 5/6] extcon: add possibility to get extcon device by OF node

2018-02-28 Thread Chanwoo Choi
Hi, On 2018년 02월 27일 16:11, Andrzej Hajda wrote: > Since extcon property is not allowed in DT, extcon subsystem requires > another way to get extcon device. Lets try the simplest approach - get > edev by of_node. > > Signed-off-by: Andrzej Hajda > Acked-by: Chanwoo Choi > --- > v5: function ren

[PATCH v2 02/16] clk: sunxi-ng: h3: h5: Add minimal rate for video PLL

2018-02-28 Thread Jernej Skrabec
Although user manuals for H3 and H5 SoCs state that minimal rate supported by video PLL is around 30 MHz, it seems that in reality minimal rate is around 192 MHz. Experiments showed that any rate below 96 MHz doesn't produce any video output at all. Even at this frequency, stable output depends on

Re: [PATCH v3 05/10] pwm: add PWM mode to pwm_config()

2018-02-28 Thread Claudiu Beznea
On 27.02.2018 17:38, Daniel Thompson wrote: > On Tue, Feb 27, 2018 at 01:40:58PM +0200, Claudiu Beznea wrote: >> On 27.02.2018 12:54, Daniel Thompson wrote: >>> On Mon, Feb 26, 2018 at 04:24:15PM +0200, Claudiu Beznea wrote: On 26.02.2018 11:57, Jani Nikula wrote: > On Thu, 22 Feb 2018,

[PATCH v2 10/16] drm/sun4i: Add support for variants to DW HDMI PHY

2018-02-28 Thread Jernej Skrabec
There are multiple variants of DW HDMI PHYs in Allwinner SoCs. While some things like clock and reset setup are the same, PHY configuration differs a lot. Split out code which is PHY specific to separate functions and create a structure which holds pointers to those functions. Signed-off-by: Jern

[PATCH v2 13/16] drm/sun4i: Allow building on arm64

2018-02-28 Thread Jernej Skrabec
64-bit ARM SoCs from Allwinner have DE2/TCON/HDMI periphery which is compatible to 32-bit SoCs, so allow building DRM driver for arm64 architecture. Signed-off-by: Jernej Skrabec --- drivers/gpu/drm/sun4i/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm

[PATCH v2 11/16] drm/sun4i: Move and expand DW HDMI PHY register macros

2018-02-28 Thread Jernej Skrabec
DW HDMI PHY macros are moved to header file and expanded with the registers present on newer SoCs like H3 and H5. Signed-off-by: Jernej Skrabec --- drivers/gpu/drm/sun4i/sun8i_dw_hdmi.h | 131 + drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c | 17 - 2 files changed,

[PATCH v2 06/16] drm/sun4i: Don't process LVDS if TCON doesn't support it

2018-02-28 Thread Jernej Skrabec
TCON checks for LVDS properties even if it doesn't support it. Add a check to skip that part of the code if TCON doesn't support channel 0. Signed-off-by: Jernej Skrabec --- drivers/gpu/drm/sun4i/sun4i_tcon.c | 120 +++-- 1 file changed, 63 insertions(+), 57 delet

[PATCH v2 05/16] dt-bindings: display: sun4i-drm: Add compatibles for H3 HDMI pipeline

2018-02-28 Thread Jernej Skrabec
Add missing compatibles for H3 HDMI pipeline. These compatibles can also be used with H5 SoC. Signed-off-by: Jernej Skrabec --- Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/display/sunxi/

[PATCH v2 01/16] clk: sunxi-ng: Add check for minimal rate to NM PLLs

2018-02-28 Thread Jernej Skrabec
Some NM PLLs doesn't work well when their output clock rate is set below certain rate. Add support for that constrain. Signed-off-by: Jernej Skrabec --- drivers/clk/sunxi-ng/ccu_nm.c | 11 +++ drivers/clk/sunxi-ng/ccu_nm.h | 27 +++ 2 files changed, 34 insertions

Re: [PATCH] dma-buf/reservation: shouldn't kfree staged when slot available

2018-02-28 Thread Christian König
Am 28.02.2018 um 07:44 schrieb Monk Liu: under below scenario the obj->fence would refer to a wild pointer: 1,call reservation_object_reserved_shared 2,call reservation_object_add_shared_fence 3,call reservation_object_reserved_shared 4,call reservation_object_add_shared_fence in step 1, staged

Re: [PATCH v2 00/30] omapdrm: Allocate objects dynamically

2018-02-28 Thread Tomi Valkeinen
On 13/02/18 14:00, Laurent Pinchart wrote: > Hello, > > Most of this series has previously been posted as part of "[PATCH 00/48] > omapdrm: Merge omapdrm and omapdss". With "[PATCH v2 00/15] omapdrm: > Miscellaneous fixes and cleanups" posted and merged a few days ago, it > completes the rework of

Re: [RFC][PATCH 04/11] drm: Split the display info into static and dynamic parts

2018-02-28 Thread Sharma, Shashank
for I915: Acked-by: Shashank Sharma Regards Shashank On 2/27/2018 6:26 PM, Ville Syrjala wrote: From: Ville Syrjälä Currently we have a mix of static and dynamic information stored in the display info structure. That makes it rather difficult to repopulate the dynamic parts when a new EDID ap

Re: [PATCH 02/24] drm/omap: cleanup fbdev init/free

2018-02-28 Thread Tomi Valkeinen
On 27/02/18 13:38, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Monday, 12 February 2018 11:44:32 EET Tomi Valkeinen wrote: >> omap_fbdev_init() and omap_fbdev_free() use priv->fbdev directly. >> However, omap_fbdev_init() returns the fbdev, and omap_drv.c also >> assign

Re: [RFC][PATCH 05/11] drm/edid: Clear display info fully

2018-02-28 Thread Sharma, Shashank
Regards Shashank On 2/27/2018 6:26 PM, Ville Syrjala wrote: From: Ville Syrjälä Now that we have split the display info into static and dynamic parts, we can just zero out the entire dynamic part with memset(). Previously we were just clearing parts of it, leaving stale data in other parts (

Re: [PATCH 03/24] drm/omap: add HPD support to connector-dvi

2018-02-28 Thread Tomi Valkeinen
On 27/02/18 14:58, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Monday, 12 February 2018 11:44:33 EET Tomi Valkeinen wrote: >> Add HPD support to the DVI connector driver. The code is almost >> identical to the HPD code in the HDMI connector driver. > > Would it make se

Re: [PATCH 22/24] drm/omap: fix maximum sizes

2018-02-28 Thread Tomi Valkeinen
On 27/02/18 15:42, Laurent Pinchart wrote: >> +/* >> + * Note: these values are used for multiple independent things: >> + * connector mode filtering, buffer sizes, crtc sizes... >> + * Use big enough values here to cover all use cases, and do more >> + * specific checking in t

[Bug 198745] Blank screen on RX 580 with AMDGPU Display Core enabled

2018-02-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=198745 --- Comment #15 from Kyle De'Vir (kyle.de...@mykolab.com) --- Am trying it out soon. Will try and capture dmesg log if it matters. -- You are receiving this mail because: You are watching the assignee of the bug.

Re: [RFC][PATCH 04/11] drm: Split the display info into static and dynamic parts

2018-02-28 Thread Stefan Agner
On 27.02.2018 13:56, Ville Syrjala wrote: > From: Ville Syrjälä > > Currently we have a mix of static and dynamic information stored in > the display info structure. That makes it rather difficult to repopulate > the dynamic parts when a new EDID appears. Let's make life easier by > splitting the

Re: [PATCH 11/24] drm/omap: Add kernel parameter to specify the desired display order

2018-02-28 Thread Tomi Valkeinen
On 27/02/18 15:35, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Monday, 12 February 2018 11:44:41 EET Tomi Valkeinen wrote: >> From: Peter Ujfalusi >> >> omapdrm.displays (int array) can be used to reorder the displays by id if >> needed. It can be also used to disable

Re: [PATCH 1/5] drm/prime: fix potential race in drm_gem_map_detach

2018-02-28 Thread Lucas Stach
Hi Christian, Am Dienstag, den 27.02.2018, 12:49 +0100 schrieb Christian König: > Unpin the GEM object only after freeing the sg table. What is the race that is being fixed here? The SG table is private to the importer and the importer should hopefully only call map_detach if it is done with all

[PULL] drm-intel-next

2018-02-28 Thread Joonas Lahtinen
Hi Dave, Cannonlake driver support is fine for the hardware we've had at our disposal to test on, so we've removed the alpha_support protection for it. That'll be the biggest visible change. Other than there's fixes for Dell Venue 8 Pro display issues, audio only HDMI and out-fences from execbuf.

Re: [PATCH 24/24] drm/omap: cleanup color space conversion

2018-02-28 Thread Tomi Valkeinen
On 27/02/18 16:08, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Monday, 12 February 2018 11:44:54 EET Tomi Valkeinen wrote: >> The setup code for color space conversion is a bit messy. This patch >> cleans it up. >> >> For some reason the TRM uses values in YCrCb order,

Re: [PATCH 24/24] drm/omap: cleanup color space conversion

2018-02-28 Thread Laurent Pinchart
Hi Tomi, On Wednesday, 28 February 2018 12:09:35 EET Tomi Valkeinen wrote: > On 27/02/18 16:08, Laurent Pinchart wrote: > > On Monday, 12 February 2018 11:44:54 EET Tomi Valkeinen wrote: > >> The setup code for color space conversion is a bit messy. This patch > >> cleans it up. > >> > >> For som

Re: [PATCH 24/24] drm/omap: cleanup color space conversion

2018-02-28 Thread Tomi Valkeinen
On 28/02/18 12:13, Laurent Pinchart wrote: > Hi Tomi, > > On Wednesday, 28 February 2018 12:09:35 EET Tomi Valkeinen wrote: >> On 27/02/18 16:08, Laurent Pinchart wrote: >>> On Monday, 12 February 2018 11:44:54 EET Tomi Valkeinen wrote: The setup code for color space conversion is a bit messy

Re: [PATCH 1/5] drm/prime: fix potential race in drm_gem_map_detach

2018-02-28 Thread Christian König
Am 28.02.2018 um 10:48 schrieb Lucas Stach: Hi Christian, Am Dienstag, den 27.02.2018, 12:49 +0100 schrieb Christian König: Unpin the GEM object only after freeing the sg table. What is the race that is being fixed here? The SG table is private to the importer and the importer should hopefully

[GIT PULL] tilcdc changes for 4.17

2018-02-28 Thread Jyri Sarha
Hi Dave, Please pull the tilcdc changes for Linux v4.17. Best regards and thanks, Jyri The following changes since commit 8bb5b22255dac09cd74eae9f86333b474d69fbbe: Merge branch 'drm-next-4.17' of git://people.freedesktop.org/~agd5f/linux into drm-next (2018-02-28 11:44:29 +1000) are available

[PATCH v2] drm/panel: simple: Add TVC S9700RTWV43TR-01B 800x480 panel support

2018-02-28 Thread Jyri Sarha
Add support for TVC S9700RTWV43TR-01B 800x480 panel found on TI's AM335X-EVM. Signed-off-by: Jyri Sarha Reviewed-by: Tomi Valkeinen --- The only change is added "Reviewed-by: Tomi Valkeinen ". Who is going to pick this up? The first version of the patch can be found here: https://lists.freedesk

Re: [RFC PATCH hwc] drm_hwcomposer: set CRTC background color when available

2018-02-28 Thread Robert Foss
Hey, On 02/23/2018 03:34 PM, Stefan Schake wrote: Hey Eric, On Thu, Feb 22, 2018 at 9:47 PM, Eric Anholt wrote: Stefan Schake writes: Android assumes an implicit black background layer is always present behind all layers it specifies for composition. drm_hwcomposer currently punts responsi

[Bug 104920] Broken hardware video encoding with vaapi/ffmpeg

2018-02-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104920 --- Comment #6 from Andy Furniss --- (In reply to Luke McKee from comment #3) > ffmpeg -hwaccel vaapi -hwaccel_device /dev/dri/renderD128 > -hwaccel_output_format vaapi -ss 120 -t 120 -i a-movie.mkv -map 0:0 -map 0:1 > -c:v h264_vaapi -b:v 4000

Re: [PATCH hwc v1] drm_hwcomposer: Fix comment on worker_test

2018-02-28 Thread Robert Foss
Thanks Rhys! Pushed. I removed the Change-Id field though. Rob. On 02/26/2018 07:17 AM, Rhys Kidd wrote: Reflect the boolean logic of the accompanying code, which is run after Worker.InitWorker() has completed in test setup. Change-Id: If5187bdaa944c5d74a70c55b5b5e58e1baa20511 Signed-off-by:

[Bug 198745] Blank screen on RX 580 with AMDGPU Display Core enabled

2018-02-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=198745 --- Comment #16 from Kyle De'Vir (kyle.de...@mykolab.com) --- No change... dmesg looks no different. :/ -- You are receiving this mail because: You are watching the assignee of the bug. ___ dri-devel m

[PATCH v2 1/2] drm/panel: Remove drm_panel_detach() calls from all panel drives

2018-02-28 Thread Jyri Sarha
Setting the connector and drm to NULL when the drm panel device is going away hardly serves any purpose. Usually the the whole memory stucture is freed right after the remove call. Signed-off-by: Jyri Sarha --- drivers/gpu/drm/panel/panel-innolux-p079zca.c| 1 - drivers/gpu/drm/panel/pan

[PATCH v2 0/2] drm/panel: Add device link in drm_panel_attach()

2018-02-28 Thread Jyri Sarha
The first version of the series can be found here: https://lists.freedesktop.org/archives/dri-devel/2018-February/166909.html The only change is the dev_err print in drm_panel_attach() if device_link_add() fails. The device_link_del() is still there in drm_panel_detach(), despite Lukas Wunner's c

[PATCH v2 2/2] drm/panel: Add device_link from panel device to drm device

2018-02-28 Thread Jyri Sarha
Add device_link from panel device (supplier) to drm device (consumer) with DL_FLAG_AUTOREMOVE when drm_panel_attach() is called. Currently the master drm driver is not protected against the attached. The device_link with DL_FLAG_AUTOREMOVE should make sure the drm device is unbound before the panel

[Bug 105046] Screen resolution reset to 1368x768 when turning monitor off

2018-02-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105046 --- Comment #7 from Michael Zapf --- Is there at least some way to restore the real monitor resolution without killing the Xserver (and hence all running desktop applications)? Right now I either have to reboot, or I must turn off the monitor,

Re: [PATCH hwc RFC] drm_hwcomposer: Enable and refactor Separate Rects test

2018-02-28 Thread Robert Foss
Hey Rhys, Pushed! Change-ID tag was dropped. Rob. On 02/26/2018 07:18 AM, Rhys Kidd wrote: Plumb through the existing test based on known sample data for the Separate Rect algorithm via Android's NATIVE_TEST harness. Change-Id: I82b5ab8ed97e338fd20b7e38b4b35ac8c53f4d2d Signed-off-by: Rhys Ki

[Bug 105262] ttf fonts are invisible

2018-02-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105262 LoneVVolf changed: What|Removed |Added Hardware|Other |x86-64 (AMD64) --- Comment #5 from LoneVVol

[Bug 105262] ttf fonts are invisible

2018-02-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105262 --- Comment #6 from LoneVVolf --- It appears most recent commits wrt r600 were written by Dave Airlie. Added him to CC list -- You are receiving this mail because: You are the assignee for the bug.__

[PATCHv2 07/17] drm/omap: dispc: disp_wb_setup to check return code

2018-02-28 Thread Tomi Valkeinen
From: Benoit Parrot When dispc_wb_setup() calls dispc_ovl_setup_common() it does not check for failure but instead keeps on partially setting up WB. This causes the WB H/W to be partially initialized and yield unexpected behavior. Make sure return code is successful before proceeding. Signed-of

[PATCHv2 05/17] dt-bindings: display: add HPD gpio to DVI connector

2018-02-28 Thread Tomi Valkeinen
Add hpd-gpios property to dvi-connector.txt. Signed-off-by: Tomi Valkeinen Cc: devicet...@vger.kernel.org Reviewed-by: Rob Herring Reviewed-by: Laurent Pinchart --- Documentation/devicetree/bindings/display/connector/dvi-connector.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Docume

[PATCHv2 06/17] drm/omap: remove leftover enums

2018-02-28 Thread Tomi Valkeinen
A few enums are not used anywhere, so remove them. Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/omapdss.h | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h b/drivers/gpu/drm/omapdrm/dss/omapd

[PATCHv2 03/17] drm/omap: Init fbdev emulation only when we have displays

2018-02-28 Thread Tomi Valkeinen
From: Peter Ujfalusi Do not try to init the fbdev if either num_crtcs or num_connectors is 0. In this case we do not have display so the fbdev init would fail anyways. Signed-off-by: Peter Ujfalusi Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/omap_f

[PATCHv2 09/17] drm/omap: set WB channel-in in wb_setup()

2018-02-28 Thread Tomi Valkeinen
We need to know the WB channel-in in wb_setup() to be able to configure WB properly for capture mode. At the moment channel-in is set separately. This patch moves channel-in to wb_setup(). Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/dispc.c | 12 +++- drivers/gpu/drm/o

[PATCHv2 02/17] drm/omap: cleanup fbdev init/free

2018-02-28 Thread Tomi Valkeinen
omap_fbdev_init() and omap_fbdev_free() use priv->fbdev directly. However, omap_fbdev_init() returns the fbdev, and omap_drv.c also assigns the return value to priv->fbdev. This is slightly confusing. Clean this up by removing the omap_fbdev_init() return value, as we don't care whether fbdev init

[PATCHv2 01/17] drm/omap: fix omap_fbdev_free() when omap_fbdev_create() wasn't called

2018-02-28 Thread Tomi Valkeinen
If we have no crtcs/connectors, fbdev init goes fine, but omap_fbdev_create() is never called. This means that omap_fbdev->bo is NULL and omap_fbdev_free() crashes. Add a check to omap_fbdev_free() to handle the NULL case. Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart --- drivers

[PATCHv2 04/17] drm/omap: add HPD support to connector-dvi

2018-02-28 Thread Tomi Valkeinen
Add HPD support to the DVI connector driver. The code is almost identical to the HPD code in the HDMI connector driver. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/displays/connector-dvi.c | 118 +++ 1 file changed, 118 insertions(+) diff --git a/drivers/gpu/dr

[PATCHv2 08/17] drm/omap: Add pclk setting case when channel is DSS_WB

2018-02-28 Thread Tomi Valkeinen
From: Benoit Parrot In dispc_set_ovl_common() we need to initialize pclk to a valid value when we use WB in capture mode (i.e. mem_2_mem is false). Otherwise dispc_ovl_calc_scaling() fails. Signed-off-by: Benoit Parrot Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/dispc.c | 4

[PATCHv2 10/17] drm/omap: fix WBDELAYCOUNT for HDMI

2018-02-28 Thread Tomi Valkeinen
For HDMI, WBDELAYCOUNT starts counting at the start of vsync, not at the start of vfp. This patch adjusts the wbdelay for HDMI accordingly. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/dispc.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/g

[PATCHv2 00/17] drm/omap: misc patches

2018-02-28 Thread Tomi Valkeinen
Hi, This is v2 of the series. I've rebased these on top of Laurent's latest patches. I also dropped most of Peter's patches, as they need rebasing and some work. I think I addressed all of Laurent's comments to the patches in this v2. Tomi Benoit Parrot (2): drm/omap: dispc: disp_wb_setup to

[PATCHv2 12/17] drm/omap: fix WB height with interlace

2018-02-28 Thread Tomi Valkeinen
When using WB capture from interlaced source, we need to halve the picture heights correctly. Unfortunately the current dispc_ovl_setup_common() doesn't deal with interlace very neatly, so the end result is a bit messy. Signed-off-by: Tomi Valkeinen Acked-by: Benoit Parrot --- drivers/gpu/drm/

[PATCHv2 11/17] drm/omap: fix WBDELAYCOUNT with interlace

2018-02-28 Thread Tomi Valkeinen
Vertical blanking needs to be halved on interlace modes. WBDELAYCOUNT was calculated without such halving, resulting in WBUNCOMPLETE errors. Signed-off-by: Tomi Valkeinen Acked-by: Benoit Parrot --- drivers/gpu/drm/omapdrm/dss/dispc.c | 14 +- 1 file changed, 9 insertions(+), 5 dele

[PATCHv2 14/17] drm/omap: add writeback funcs to dispc_ops

2018-02-28 Thread Tomi Valkeinen
Add writeback specific dispc functions to dispc_ops so that omapdrm can use them. Also move 'enum dss_writeback_channel' to the public omapdss.h for omapdrm. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/dispc.c | 19 +++ drivers/gpu/drm/omapdrm/dss/dss.h |

[PATCHv2 16/17] drm/omap: Allow HDMI audio setup even if we do not have video configured

2018-02-28 Thread Tomi Valkeinen
From: Jyri Sarha Allow HDMI audio setup even if we do not have video configured. Audio will get configured at the same time with video if the video is configured soon enough. If it is not the audio DMA will timeout in couple of seconds and audio playback will be aborted. Signed-off-by: Jyri Sarh

[PATCHv2 15/17] drm/omap: fix maximum sizes

2018-02-28 Thread Tomi Valkeinen
We define max width and height in mode_config to 2048. These maximums affect many things, which are independent and depend on platform. We need to do more fine grained checks in the code paths for each component, and so the maximum values in mode_config should just be "big enough" to cover all use

[PATCHv2 17/17] drm/omap: cleanup color space conversion

2018-02-28 Thread Tomi Valkeinen
The setup code for color space conversion is a bit messy. This patch cleans it up. For some reason the TRM uses values in YCrCb order, which is also used in the current driver, whereas everywhere else it's YCbCr (which also matches YUV order). This patch changes the tables to use the common order

[PATCHv2 13/17] drm/omap: fix scaling limits for WB

2018-02-28 Thread Tomi Valkeinen
WB has additional scaling limits when the output color format is one of the YUV formats. These limits are not handled at the moment, causing bad scaling and/or NULL dereference crash. This patchs adds the check so that dispc returns an error for bad scaling request. Signed-off-by: Tomi Valkeinen

Re: [PATCH RFC 3/9] drm/omap: Add ovl_name() and mgr_name() to dispc_ops

2018-02-28 Thread Tomi Valkeinen
On 27/02/18 16:35, Laurent Pinchart wrote: > the whole omap_irq_fifo_underflow() and omap_irq_ocp_error_handler() IRQ > handling to the DSS side, as they're not DRM/KMS-related ? I think we should react to both errors somehow (I'm not sure how, disable output probably), and that has to be done o

[PATCH] drm/sun4i: init dclk_min_div & dclk_max_div inside encoder init functions

2018-02-28 Thread Giulio Benetti
sun4i_dclk_round_rate is called before sun4i_tcon_mode_set, so it finds dclk_min_div and dclk_max_div set to 0 and fails adding crtc. Move dclk_min_div and dclk_max_div to encoders init functions. Signed-off-by: Giulio Benetti --- drivers/gpu/drm/sun4i/sun4i_lvds.c | 4 drivers/gpu/drm/sun

Re: [Intel-gfx] [PATCH 1/4] drm/uapi: The ctm matrix uses sign-magnitude representation

2018-02-28 Thread Ville Syrjälä
On Fri, Feb 23, 2018 at 04:04:10PM +0200, Ville Syrjälä wrote: > On Fri, Feb 23, 2018 at 01:52:22PM +, Brian Starkey wrote: > > Hi Ville, > > > > On Thu, Feb 22, 2018 at 11:42:29PM +0200, Ville Syrjala wrote: > > >From: Ville Syrjälä > > > > > >The documentation for the ctm matrix suggests a

[PATCH v2] bridge: Elaborate a bit on dumb VGA bridges in Kconfig

2018-02-28 Thread Linus Walleij
It's better if we explain a bit that this pertains to passive VGA DAC bridges. Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Write that these bridges are non-programmable rather than discrete, as that reflects the name of the bridge being "dumb". Discrete is wrong as it has a specific

Re: [PATCH v2] bridge: Elaborate a bit on dumb VGA bridges in Kconfig

2018-02-28 Thread Laurent Pinchart
Hi Linus, Thank you for the patch. On Wednesday, 28 February 2018 15:02:49 EET Linus Walleij wrote: > It's better if we explain a bit that this pertains to > passive VGA DAC bridges. s/passive/non-programmable/ ? > Signed-off-by: Linus Walleij > --- > ChangeLog v1->v2: > - Write that these bri

Re: [PATCH RFC 3/9] drm/omap: Add ovl_name() and mgr_name() to dispc_ops

2018-02-28 Thread Laurent Pinchart
Hi Tomi, On Wednesday, 28 February 2018 13:37:48 EET Tomi Valkeinen wrote: > On 27/02/18 16:35, Laurent Pinchart wrote: > > the whole omap_irq_fifo_underflow() and omap_irq_ocp_error_handler() IRQ > > handling to the DSS side, as they're not DRM/KMS-related ? > > I think we should react to both e

[PATCH] tinydrm: add backlight dependency

2018-02-28 Thread Arnd Bergmann
Calling devm_of_find_backlight directly means we get a link failure without CONFIG_BACKLIGHT_CLASS_DEVICE: drivers/gpu/drm/tinydrm/mi0283qt.o: In function `mi0283qt_probe': mi0283qt.c:(.text+0x684): undefined reference to `devm_of_find_backlight' This adds an explicit Kconfig dependency for it. W

Re: [PATCH v5 6/6] drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL

2018-02-28 Thread Andrzej Hajda
On 27.02.2018 23:26, Chanwoo Choi wrote: > Hi, > > On 2018년 02월 27일 21:05, Andrzej Hajda wrote: >> On 27.02.2018 12:08, Chanwoo Choi wrote: >>> Hi, >>> >>> On 2018년 02월 27일 16:11, Andrzej Hajda wrote: From: Maciej Purski Currently MHL chip must be turned on permanently to detect MHL

Re: [PATCH RFC 3/9] drm/omap: Add ovl_name() and mgr_name() to dispc_ops

2018-02-28 Thread Tomi Valkeinen
On 28/02/18 15:23, Laurent Pinchart wrote: > Hi Tomi, > > On Wednesday, 28 February 2018 13:37:48 EET Tomi Valkeinen wrote: >> On 27/02/18 16:35, Laurent Pinchart wrote: >>> the whole omap_irq_fifo_underflow() and omap_irq_ocp_error_handler() IRQ >>> handling to the DSS side, as they're not DRM/KM

Re: [PATCH RFC 3/9] drm/omap: Add ovl_name() and mgr_name() to dispc_ops

2018-02-28 Thread Laurent Pinchart
Hi Tomi, On Wednesday, 28 February 2018 16:05:34 EET Tomi Valkeinen wrote: > On 28/02/18 15:23, Laurent Pinchart wrote: > > On Wednesday, 28 February 2018 13:37:48 EET Tomi Valkeinen wrote: > >> On 27/02/18 16:35, Laurent Pinchart wrote: > >>> the whole omap_irq_fifo_underflow() and omap_irq_ocp_e

Re: [PATCH] drm/atomic: Add new reverse iterator over all plane state

2018-02-28 Thread Alex Deucher
+ dri-devel On Wed, Feb 28, 2018 at 4:33 AM, S, Shirish wrote: > From: Shirish S > > Add reverse iterator "for_each_oldnew_plane_in_state_reverse" to > complement "for_each_oldnew_plane_in_state" way of reading plane > states. > > The plane states are required to be read in reverse order for >

Re: [PATCH RFC 3/9] drm/omap: Add ovl_name() and mgr_name() to dispc_ops

2018-02-28 Thread Tomi Valkeinen
On 28/02/18 16:24, Laurent Pinchart wrote: > Hi Tomi, > > On Wednesday, 28 February 2018 16:05:34 EET Tomi Valkeinen wrote: >> On 28/02/18 15:23, Laurent Pinchart wrote: >>> On Wednesday, 28 February 2018 13:37:48 EET Tomi Valkeinen wrote: On 27/02/18 16:35, Laurent Pinchart wrote: > th

Re: [PATCH v3 05/43] drm/bridge: analogix_dp: Don't power bridge in analogix_dp_bind

2018-02-28 Thread Heiko Stübner
Am Dienstag, 30. Januar 2018, 21:28:35 CET schrieb Thierry Escande: > From: zain wang > > The bridge does not need to be powered in analogix_dp_bind(), so > remove the calls to pm_runtime_get()/phy_power_on()/analogix_dp_init_dp() > as well as their power-off counterparts. > > Cc: Stéphane March

RE: [PATCH 02/10] drm: Add Plane Degamma properties

2018-02-28 Thread Shankar, Uma
>-Original Message- >From: Sean Paul [mailto:seanp...@chromium.org] >Sent: Tuesday, February 27, 2018 8:44 PM >To: Daniele Castagna >Cc: dri-devel@lists.freedesktop.org; brian.star...@arm.com; Shankar, Uma > >Subject: Re: [PATCH 02/10] drm: Add Plane Degamma properties > >On Thu, Feb 15,

RE: [PATCH 03/10] drm: Add Plane CTM property

2018-02-28 Thread Shankar, Uma
>-Original Message- >From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of >Sean Paul >Sent: Tuesday, February 27, 2018 8:53 PM >To: Daniele Castagna >Cc: dri-devel@lists.freedesktop.org >Subject: Re: [PATCH 03/10] drm: Add Plane CTM property > >On Thu, Feb 15, 20

Re: [PATCH v3 05/43] drm/bridge: analogix_dp: Don't power bridge in analogix_dp_bind

2018-02-28 Thread Heiko Stübner
Am Mittwoch, 28. Februar 2018, 15:54:30 CET schrieb Marc Zyngier: > On 28/02/18 14:37, Heiko Stübner wrote: > > Am Dienstag, 30. Januar 2018, 21:28:35 CET schrieb Thierry Escande: > >> From: zain wang > >> > >> The bridge does not need to be powered in analogix_dp_bind(), so > >> remove the calls

RE: [PATCH 05/10] drm: Define helper function for plane color enabling

2018-02-28 Thread Shankar, Uma
>-Original Message- >From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of >Sean Paul >Sent: Tuesday, February 27, 2018 8:59 PM >To: Daniele Castagna >Cc: dri-devel@lists.freedesktop.org >Subject: Re: [PATCH 05/10] drm: Define helper function for plane color enabl

Re: [PATCH libdrm] meson: add configuration summary

2018-02-28 Thread Eric Engestrom
On Tuesday, 2018-02-27 12:30:48 -0800, Eric Anholt wrote: > Dylan Baker writes: > > > [ Unknown signature status ] > > Quoting Eric Engestrom (2018-02-27 03:11:07) > >> The message block printed is the same as the one in configure.ac > >> > >> Signed-off-by: Eric Engestrom > >> --- > >> meson.

[PATCH] drm/arm: mali-dp: Reorder atomic_commit_hw_done to avoid waiting on wrong vblank event

2018-02-28 Thread Liviu Dudau
mali-dp driver sets the 'go' bit (config_valid) and then waits for confirmation from the hardware that the config has been updated before arming the vblank event. The issue is that config_valid is actually asserted by the hardware after vblank event, during the prefetch phase, so when arming the vb

Re: [PATCH 0/3] console: Expand dummy functions for CFI

2018-02-28 Thread Bartlomiej Zolnierkiewicz
On Wednesday, February 28, 2018 04:09:47 PM Bartlomiej Zolnierkiewicz wrote: > On Monday, February 26, 2018 04:04:17 PM Kees Cook wrote: > > This is a small series that cleans up struct consw a bit and > > prepares it for Control Flow Integrity checking (i.e. Clang's > > -fsanitize=cfi). > > for d

[PATCH] drm: mali-dp: Turn off CRTC vblank when removing module.

2018-02-28 Thread Liviu Dudau
When unbinding the mali-dp driver the drm_vblank_cleanup() function warns us that the vblanks are still enabled. Fix that by calling drm_crtc_vblank_off() in the malidp_unbind() function. Signed-off-by: Liviu Dudau --- drivers/gpu/drm/arm/malidp_drv.c | 2 ++ 1 file changed, 2 insertions(+) dif

Re: [PATCH 0/3] console: Expand dummy functions for CFI

2018-02-28 Thread Bartlomiej Zolnierkiewicz
On Monday, February 26, 2018 04:04:17 PM Kees Cook wrote: > This is a small series that cleans up struct consw a bit and > prepares it for Control Flow Integrity checking (i.e. Clang's > -fsanitize=cfi). for drivers/video/ parts: Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Z

Re: [PATCH v3 05/43] drm/bridge: analogix_dp: Don't power bridge in analogix_dp_bind

2018-02-28 Thread Heiko Stübner
Am Dienstag, 30. Januar 2018, 21:28:35 CET schrieb Thierry Escande: > From: zain wang > > The bridge does not need to be powered in analogix_dp_bind(), so > remove the calls to pm_runtime_get()/phy_power_on()/analogix_dp_init_dp() > as well as their power-off counterparts. > > Cc: Stéphane March

[Bug 198745] Blank screen on RX 580 with AMDGPU Display Core enabled

2018-02-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=198745 --- Comment #17 from Harry Wentland (harry.wentl...@amd.com) --- Thanks for checking. Non-DC display driver and DC do detection somewhat differently. It's somewhat difficult to say what's going wrong there. Do you see different behavior when boot

[PATCH] drm/drm_ioctl.c: Test client capability value early when setting.

2018-02-28 Thread Liviu Dudau
The drm_setclientcap() function implementing the DRM_IOCTL_SET_CLIENT_CAP ioctl expects that any capability set by the client will have a value of 1. Make the check early so that we don't have to test the value for each capability. Signed-off-by: Liviu Dudau --- drivers/gpu/drm/drm_ioctl.c | 9 +

Re: [PATCH 0/3] console: Expand dummy functions for CFI

2018-02-28 Thread Greg Kroah-Hartman
On Wed, Feb 28, 2018 at 04:14:38PM +0100, Bartlomiej Zolnierkiewicz wrote: > On Wednesday, February 28, 2018 04:09:47 PM Bartlomiej Zolnierkiewicz wrote: > > On Monday, February 26, 2018 04:04:17 PM Kees Cook wrote: > > > This is a small series that cleans up struct consw a bit and > > > prepares i

[Bug 105046] Screen resolution reset to 1368x768 when turning monitor off

2018-02-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105046 --- Comment #8 from Harry Wentland --- Unplugging and replugging the display should get you back to normal. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mail

[PULL] drm-misc-fixes

2018-02-28 Thread Gustavo Padovan
Hi Dave, A few more fixes for 4.16, including 2 regression fixes. Please pull. Thanks, Gustavo drm-misc-fixes-2018-02-28: Two regression fixes here: a fb format regression on nouveau and a 4.16-rc1 regression with on LVDS with one sun4i device. Plus a sun4i and a virtio-gpu fixes. The followin

Re: [PATCH] drm/drm_ioctl.c: Test client capability value early when setting.

2018-02-28 Thread Ville Syrjälä
On Wed, Feb 28, 2018 at 03:27:41PM +, Liviu Dudau wrote: > The drm_setclientcap() function implementing the DRM_IOCTL_SET_CLIENT_CAP > ioctl expects that any capability set by the client will have a value of 1. > Make the check early so that we don't have to test the value for each > capability

  1   2   >