[PATCH v4 3/5] drm/dp: make dp_get_lane_status usable from outside of the core

2018-09-21 Thread Damian Kos
From: Quentin Schulz dp_get_lane_status is pretty generic and can be used for other means, so let's make it "public". This adds drm_dp_get_lane_status to the header file and add the appropriate EXPORT_SYMBOL for it so that it can be used by other drivers, be they compiled built-in or as

[PATCH v4 4/5] dt-bindings: drm/bridge: Document Cadence MHDP bridge bindings

2018-09-21 Thread Damian Kos
From: Quentin Schulz Document the bindings used for the Cadence MHDP DPI/DP bridge. Signed-off-by: Quentin Schulz Signed-off-by: Damian Kos --- .../bindings/display/bridge/cdns,mhdp.txt | 43 +++ 1 file changed, 43 insertions(+) create mode 100644

Re: [RFC PATCH v4 1/2] drm: Add generic colorkey properties for display planes

2018-09-21 Thread Dmitry Osipenko
On 8/14/18 1:38 PM, Daniel Vetter wrote: On Tue, Aug 14, 2018 at 12:48:08PM +0300, Laurent Pinchart wrote: Hi Dmitry, Thank you for the patch. On Tuesday, 7 August 2018 20:22:01 EEST Dmitry Osipenko wrote: From: Laurent Pinchart Color keying is the action of replacing pixels matching a

Re: [RFC PATCH v1 0/6] Resolve unwanted DMA backing with IOMMU

2018-09-21 Thread Dmitry Osipenko
On 8/16/18 8:23 PM, Robin Murphy wrote: On 15/08/18 20:56, Dmitry Osipenko wrote: On Friday, 3 August 2018 18:43:41 MSK Robin Murphy wrote: On 02/08/18 19:24, Dmitry Osipenko wrote: On Friday, 27 July 2018 20:16:53 MSK Dmitry Osipenko wrote: On Friday, 27 July 2018 20:03:26 MSK Jordan Crouse

[PATCH v4 0/5] drm: add support for Cadence MHDP DPI/DP bridge.

2018-09-21 Thread Damian Kos
Hello! This is the series of patches that will add support for the Cadence's DPI/DP bridge. Please note that this is a preliminary version of the driver and there will be more patches in the future with updates, fixes and improvements. Please keep that in mind when looking at FIXME/TODO/XXX

RE: [PATCH 3/6] drm: add support of syncobj timeline point wait v2

2018-09-21 Thread Zhou, David(ChunMing)
> -Original Message- > From: amd-gfx On Behalf Of > Christian K?nig > Sent: Thursday, September 20, 2018 7:11 PM > To: Zhou, David(ChunMing) ; dri- > de...@lists.freedesktop.org > Cc: amd-...@lists.freedesktop.org > Subject: Re: [PATCH 3/6] drm: add support of syncobj timeline point

Re: [PATCH libdrm] intel: annotate the intel genx helpers as private

2018-09-21 Thread Chih-Wei Huang
2018-09-20 7:18 GMT+08:00 Lucas De Marchi : > On Wed, Sep 19, 2018 at 03:47:48PM +0800, Chih-Wei Huang wrote: >> 2018-09-14 2:23 GMT+08:00 Lucas De Marchi : >> > +Chris >> >> >> >> That's because drm_gralloc use the IS_GEN9 macro >> >> (and other IS_GEN{n} macros) directly. >> >> >> >> Since

Re: [PATCH v5 7/7] drm/rockchip: dsi: add dual mipi support

2018-09-21 Thread Andrzej Hajda
On 20.09.2018 13:20, Heiko Stuebner wrote: > Hi Andrzej, > > Am Montag, 27. August 2018, 13:34:07 CEST schrieb Andrzej Hajda: >> On 21.08.2018 16:05, Heiko Stuebner wrote: >>> Add the Rockchip-sepcific dual-dsi setup and hook it into the VOP as well. >>> As described in the general dual-dsi

Re: [PATCH v3 01/12] drm/mediatek: add refcount for DPI power on/off

2018-09-21 Thread CK Hu
Hi, Bibby: On Fri, 2018-09-21 at 11:28 +0800, Bibby Hsieh wrote: > From: chunhui dai > > After the kernel 4.4, the DRM disable flow was changed, if DPI was > disableed before CRTC, it will cause warning message as following: > > [ cut here ] > WARNING: CPU: 0 PID: 1339

Re: [RFC PATCH v4 1/2] drm: Add generic colorkey properties for display planes

2018-09-21 Thread Dmitry Osipenko
On 8/16/18 2:42 PM, Maarten Lankhorst wrote: Op 08-08-18 om 16:30 schreef Dmitry Osipenko: On Wednesday, 8 August 2018 11:16:09 MSK Russell King - ARM Linux wrote: On Tue, Aug 07, 2018 at 08:22:01PM +0300, Dmitry Osipenko wrote: + * Glossary: + * + * Destination plane: + * Plane to which

[PATCH v4 5/5] drm: bridge: add support for Cadence MHDP DPI/DP bridge

2018-09-21 Thread Damian Kos
From: Quentin Schulz This adds basic support for Cadence MHDP DPI to DP bridge. Basically, it takes a DPI stream as input and output it encoded in DP format. It's missing proper HPD, HDCP and currently supports only SST mode. Changes made in the low level driver (cdn-dp-reg.*): - moved it to

[PATCH v4 1/5] drm/rockchip: prepare common code for cdns and rk dpi/dp driver

2018-09-21 Thread Damian Kos
- Extracted common fields from cdn_dp_device to a new cdns_mhdp_device structure which will be used by two separate drivers later on. - Moved some datatypes (audio_format, audio_info, vic_pxl_encoding_format, video_info) from cdn-dp-core.c to cdn-dp-reg.h. - Changed prefixes from cdn_dp to

Re: [PATCH v7 1/2] drm/panel: Add support for Truly NT35597 panel driver

2018-09-21 Thread Bjorn Andersson
On Wed 19 Sep 19:55 PDT 2018, Abhinav Kumar wrote: > +static int truly_nt35597_probe(struct mipi_dsi_device *dsi) > +{ [..] > + dsi1 = of_graph_get_remote_node(dsi->dev.of_node, 1, -1); > + if (!dsi1) { > + DRM_DEV_ERROR(dev, > + "failed to get remote node

[PATCH] video: fbdev: sis: Remove unnecessary parentheses and commented code

2018-09-21 Thread Nathan Chancellor
Clang warns when multiple pairs of parentheses are used for a single conditional statement. drivers/video/fbdev/sis/init301.c:851:42: warning: equality comparison with extraneous parentheses [-Wparentheses-equality] } else if((SiS_Pr->SiS_IF_DEF_LVDS == 1) /* ||

Re: Bug report: HiBMC crash

2018-09-21 Thread xinliang
Hi John, Thank you for reporting bug. I am now using 4.18.7. I haven't found this issue yet. I will try linux-next and figure out what's wrong with it. Thanks, Xinliang On 2018/9/20 19:23, John Garry wrote: On 20/09/2018 11:04, John Garry wrote: Hi, I am seeing this crash below on

Bug report: HiBMC crash

2018-09-21 Thread John Garry
Hi, I am seeing this crash below on linux-next (20 Sept). This is on an arm64 D05 board, which includes the HiBMC device. D06 was also crashing for what looked like same reason. I am using standard defconfig, except DRM and DRM_HISI_HIBMC are built-in. Is this a known issue? I tested

[PATCH v4 2/5] drm/dp: fix link probing for devices supporting DP 1.4+

2018-09-21 Thread Damian Kos
From: Quentin Schulz DP 1.4 introduced a DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT bit in DP_TRAINING_AUX_RD_INTERVAL register. If set, DPCD registers from DP_DPCD_REV to DP_ADAPTER_CAP should be retrieved starting from DP_DPCD_REV_EXTENDED. All registers are copied except DP_DPCD_REV,

Re: [RESEND 0/5] drm/mxsfb: Fix runtime PM for unpowering lcdif block

2018-09-21 Thread Leonard Crestez
On Mon, 2018-09-17 at 16:37 -0700, Stefan Agner wrote: > On 17.09.2018 12:16, Sean Paul wrote: > > On Mon, Sep 17, 2018 at 04:42:10PM +0300, Leonard Crestez wrote: > > > Adding lcdif nodes to a power domain currently doesn't work, it results > > > in black/corrupted screens or hangs. While the

Re: [RFC PATCH v4 1/2] drm: Add generic colorkey properties for display planes

2018-09-21 Thread Dmitry Osipenko
Hello Laurent, Sorry for the late response. On 8/14/18 12:48 PM, Laurent Pinchart wrote: Hi Dmitry, Thank you for the patch. > On Tuesday, 7 August 2018 20:22:01 EEST Dmitry Osipenko wrote: From: Laurent Pinchart Color keying is the action of replacing pixels matching a given color (or

Re: Bug report: HiBMC crash

2018-09-21 Thread John Garry
On 20/09/2018 11:04, John Garry wrote: Hi, I am seeing this crash below on linux-next (20 Sept). This is on an arm64 D05 board, which includes the HiBMC device. D06 was also crashing for what looked like same reason. I am using standard defconfig, except DRM and DRM_HISI_HIBMC are built-in.

Re: [BUG] i915 HDMI connector status is connected after disconnection

2018-09-21 Thread Chris Chiu
On Wed, Sep 19, 2018 at 8:08 PM, Jani Nikula wrote: > On Wed, 19 Sep 2018, Chris Chiu wrote: >> I tried to add a slight delay in the hotplug work as follows >> >> --- a/drivers/gpu/drm/i915/intel_hotplug.c >> +++ b/drivers/gpu/drm/i915/intel_hotplug.c >> @@ -378,6 +378,8 @@ static void

Re: [PATCH v3 0/3] ARM: OMAP1: ams-delta: Complete driver gpiod migration

2018-09-21 Thread Tony Lindgren
* Janusz Krzysztofik [180919 18:13]: > On Monday, September 10, 2018 12:56:02 AM CEST Janusz Krzysztofik wrote: > > > > This is a follow up of initial submission of a series consisted of > > 6 changes, 3 of which have been already applied or reworkeed. > > > > > > Janusz Krzysztofik (3): > >

Re: [PATCH v3 02/12] drm/mediatek: move hardware register to node data

2018-09-21 Thread CK Hu
Hi, Bibby: On Fri, 2018-09-21 at 11:28 +0800, Bibby Hsieh wrote: > From: chunhui dai > > The address of register DPI_H_FRE_CON is different in different IC. > Using of_node data to find this address. > Reviewed-by: CK Hu > Signed-off-by: chunhui dai > --- >

Re: [git pull] drm fixes for 4.19-rc5

2018-09-21 Thread Greg Kroah-Hartman
On Fri, Sep 21, 2018 at 10:06:58AM +1000, Dave Airlie wrote: > Hey Greg, > > Looks like a pretty run of the mill set of fixes for this stage, > > core: fix debugfs for atomic, fix the check for atomic for > non-modesetting drivers > amdgpu: adds a new PCI id, some kfd fixes and a sdma fix >

Re: [PATCH v4 2/5] drm/dp: fix link probing for devices supporting DP 1.4+

2018-09-21 Thread Manasi Navare
Thanks for the patch. Verified with the DP 1.4 spec and looks good to me. Also look at the related patch that makes use of the correct extended capabilities: https://patchwork.freedesktop.org/patch/249400/ Reviewed-by: Manasi Navare Manasi On Thu, Sep 20, 2018 at 03:54:37PM +0100, Damian

Re: [PATCH 3/6] drm: add support of syncobj timeline point wait v2

2018-09-21 Thread Christian König
Am 21.09.2018 um 09:15 schrieb Zhou, David(ChunMing): -Original Message- From: amd-gfx On Behalf Of Christian K?nig Sent: Thursday, September 20, 2018 7:11 PM To: Zhou, David(ChunMing) ; dri- de...@lists.freedesktop.org Cc: amd-...@lists.freedesktop.org Subject: Re: [PATCH 3/6] drm:

Re: [PATCH libdrm 3/3] radeon: add missing drm_public exports

2018-09-21 Thread Michel Dänzer
On 2018-09-20 8:31 p.m., Eric Engestrom wrote: > On Thursday, 2018-09-20 18:21:41 +0100, Eric Engestrom wrote: >> On Thursday, 2018-09-20 18:09:41 +0200, Michel Dänzer wrote: >>> On 2018-09-20 5:58 p.m., Eric Engestrom wrote: Fixes: 9f45264815eff6ebeba3 "radeon: annotate public functions"

Re: [PATCH 03/18] video/hdmi: Constify infoframe passed to the log functions

2018-09-21 Thread Hans Verkuil
On 09/20/18 20:51, Ville Syrjala wrote: > From: Ville Syrjälä > > The log functions don't modify the passed in infoframe so make it const. > > Cc: Thierry Reding > Cc: Hans Verkuil Acked-by: Hans Verkuil Thanks, Hans > Cc: linux-me...@vger.kernel.org > Signed-off-by: Ville

Re: [PATCH 02/18] video/hdmi: Pass buffer size to infoframe unpack functions

2018-09-21 Thread Hans Verkuil
On 09/20/18 20:51, Ville Syrjala wrote: > From: Ville Syrjälä > > To make sure the infoframe unpack functions don't end up examining > stack garbage or oopsing, let's pass in the size of the buffer. > > v2: Convert tda1997x.c as well (kbuild test robot) > > Cc: Thierry Reding > Cc: Hans

Re: [PATCH] drm: fix use of freed memory in drm_mode_setcrtc

2018-09-21 Thread Daniel Vetter
On Mon, Sep 17, 2018 at 02:00:54PM +0300, Tomi Valkeinen wrote: > drm_mode_setcrtc() retries modesetting in case one of the functions it > calls returns -EDEADLK. connector_set, mode and fb are freed before > retrying, but they are not set to NULL. This can cause > drm_mode_setcrtc() to use those

Re: [PATCH] drm/probe_helper: Don't bother probing when connectors are forced off

2018-09-21 Thread Daniel Vetter
On Mon, Sep 17, 2018 at 05:12:04PM -0400, Lyude Paul wrote: > On Mon, 2018-09-17 at 21:16 +0300, Ville Syrjälä wrote: > > On Mon, Sep 17, 2018 at 02:10:02PM -0400, Lyude Paul wrote: > > > On Mon, 2018-09-17 at 20:55 +0300, Ville Syrjälä wrote: > > > > On Mon, Sep 17, 2018 at 01:43:44PM -0400,

Re: [Intel-gfx] [PATCH 2/2] drm: Fix syncobj handing of schedule() returning 0

2018-09-21 Thread Chris Wilson
Quoting Daniel Vetter (2018-09-21 10:15:41) > On Tue, Sep 18, 2018 at 11:07:20AM +0100, Chris Wilson wrote: > > After schedule() returns 0, we must do one last check of COND to > > determine the reason for the wakeup with 0 jiffies remaining before > > reporting the timeout -- otherwise we may

Re: [PATCH v3 09/12] drm/mediatek: add hdmi driver for MT2701 and MT7623

2018-09-21 Thread CK Hu
Hi, Bibby: On Fri, 2018-09-21 at 11:28 +0800, Bibby Hsieh wrote: > From: chunhui dai > > This patch adds hdmi dirver suppot for both MT2701 and MT7623. > And also support other (existing or future) chips that use > the same binding and driver. > > Signed-off-by: chunhui dai > --- >

Re: [PATCH 04/18] video/hdmi: Constify infoframe passed to the pack functions

2018-09-21 Thread Hans Verkuil
On 09/20/18 20:51, Ville Syrjala wrote: > From: Ville Syrjälä > > Let's make the infoframe pack functions usable with a const infoframe > structure. This allows us to precompute the infoframe earlier, and still > pack it later when we're no longer allowed to modify the structure. > So now we end

Re: [PATCH v4 5/5] drm: bridge: add support for Cadence MHDP DPI/DP bridge

2018-09-21 Thread Heiko Stuebner
Hi Damian, Am Donnerstag, 20. September 2018, 16:54:40 CEST schrieb Damian Kos: > From: Quentin Schulz > > This adds basic support for Cadence MHDP DPI to DP bridge. > > Basically, it takes a DPI stream as input and output it encoded in DP > format. It's missing proper HPD, HDCP and currently

Re: [PATCH 05/18] video/hdmi: Add an enum for HDMI packet types

2018-09-21 Thread Hans Verkuil
On 09/20/18 20:51, Ville Syrjala wrote: > From: Ville Syrjälä > > We'll be wanting to send more than just infoframes over HDMI. So add an > enum for other packet types. > > TODO: Maybe just include the infoframe types in the packet type enum > and get rid of the infoframe type enum? I

Re: [Intel-gfx] [PATCH v3] drm: Return -EOPNOTSUPP in drm_setclientcap() when driver do not support KMS

2018-09-21 Thread Daniel Vetter
On Tue, Sep 18, 2018 at 09:02:04PM +0300, Ville Syrjälä wrote: > On Tue, Sep 18, 2018 at 10:48:09AM -0700, José Roberto de Souza wrote: > > All DRM_CLIENT capabilities are tied to KMS support, so returning > > -EOPNOTSUPP when KMS is not supported. > > > > v2: returning -EOPNOTSUPP(same value as

Re: [PATCH v3 05/12] drm/mediatek: convert dpi driver to use drm_of_find_panel_or_bridge

2018-09-21 Thread CK Hu
Hi, Bibby: On Fri, 2018-09-21 at 11:28 +0800, Bibby Hsieh wrote: > From: chunhui dai > > Convert dpi driver to use drm_of_find_panel_or_bridge. > This changes some error messages to debug messages (in the graph core). > Graph connections are often "no connects" depending on the particular >

Re: [PATCH v3 04/12] drm/mediatek: add clock factor for different IC

2018-09-21 Thread CK Hu
Hi, Bibby: On Fri, 2018-09-21 at 11:28 +0800, Bibby Hsieh wrote: > From: chunhui dai > > different IC has different clock designed in HDMI, the factor for > calculate clock should be different. Usinng the data in of_node > to find this factor. > Reviewed-by: CK Hu > Signed-off-by: chunhui

Re: [PATCH] drm/i915: set i915 driver probe to asynchronous

2018-09-21 Thread Daniel Vetter
On Wed, Sep 19, 2018 at 03:37:12PM +0800, ning.a.zh...@intel.com wrote: > From: Zhang Ning > > when i915 is built in module, and system has built-in display, eg. eDP, > i915 will detect and active it during driver probe. it will take long > time. > > set i915 driver probe to asynchrous can save

Re: [PATCH v3 1/5] drm: move native byte order quirk to new drm_mode_legacy_fb_format2 function

2018-09-21 Thread Daniel Vetter
On Wed, Sep 19, 2018 at 01:12:48PM +0200, Gerd Hoffmann wrote: > Turns out we need the pixel format fixup not only for the addfb ioctl, > but also for fbdev emulation code. > > Ideally we would place it in drm_mode_legacy_fb_format(). That would > create alot of churn though, and most drivers

Re: [PATCH v3 06/12] drm/mediatek: add dpi driver for mt2701 and mt7623

2018-09-21 Thread CK Hu
Hi, Bibby: On Fri, 2018-09-21 at 11:28 +0800, Bibby Hsieh wrote: > From: chunhui dai > > This patch adds dpi dirver suppot for both mt2701 and mt7623. > And also support other (existing or future) chips that use > the same binding and driver. > Reviewed-by: CK Hu > Signed-off-by: chunhui

[Bug 104602] [apitrace] Graphical artifacts in Civilization VI on RX Vega

2018-09-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104602 --- Comment #10 from Jason Playne --- (In reply to Timothy Arceri from comment #9) > I'm not sure why yet but both the black triangles and the incorrect > rendering behind the chinese emperor on the loading screen go away when I > run the trace

Re: [PATCH 06/18] video/hdmi: Handle the MPEG Source infoframe

2018-09-21 Thread Hans Verkuil
On 09/20/18 20:51, Ville Syrjala wrote: > From: Ville Syrjälä > > Add the code to deal with the MPEG source infoframe. > > Blindly typed from the spec, and totally untested. I'm not sure this patch should be added at all. The CTA-861-G spec (section 6.7) says that the implementation of this

Re: [PATCH -next] drm/vkms: Fix possible memory leak in _vkms_get_crc()

2018-09-21 Thread Daniel Vetter
On Sat, Sep 15, 2018 at 01:53:19AM +, Wei Yongjun wrote: > 'vaddr_out' is malloced in _vkms_get_crc() and should be freed before > leaving from the error handling cases, otherwise it will cause memory > leak. > > Fixes: db7f419c06d7 ("drm/vkms: Compute CRC with Cursor Plane") > Signed-off-by:

Re: [PATCH 1/2] drm: Use default dma_fence hooks where possible for null syncobj

2018-09-21 Thread Daniel Vetter
On Tue, Sep 18, 2018 at 11:07:19AM +0100, Chris Wilson wrote: > Both the .enable_signaling and .release of the null syncobj fence > can be replaced by the default callbacks for a small reduction in code > size. > > Signed-off-by: Chris Wilson Reviewed-by: Daniel Vetter > --- >

Re: [PATCH 1/2] drm/fourcc: rename Intel modifiers to follow the naming convention

2018-09-21 Thread Daniel Vetter
On Tue, Sep 18, 2018 at 06:21:59PM +0100, Eric Engestrom wrote: > All the other vendors use the format > DRM_FORMAT_MOD_{SAMSUNG,QCOM,VIVANTE,NVIDIA,BROADCOM,ARM}_* for their > modifiers, except Intel. > > Suggested-by: Gerd Hoffmann > Signed-off-by: Eric Engestrom I think it'd be good to add

[PATCH 1/5] drm/tegra: dc: Do not register DC without primary plane

2018-09-21 Thread Thierry Reding
From: Thierry Reding Tegra194 contains a fourth display controller that does not own any windows. Therefore, we cannot currently assign a primary plane to it which causes KMS to eventually crash. Do not register the display controller if it owns no windows to work around this. Note that we

[PATCH 4/5] drm/tegra: dpaux: Add Tegra194 support

2018-09-21 Thread Thierry Reding
From: Thierry Reding The DPAUX controller found on Tegra194 is almost identical to its predecessor from Tegra186. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/dpaux.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/tegra/dpaux.c b/drivers/gpu/drm/tegra/dpaux.c

[PATCH 3/5] drm/tegra: dc: Add Tegra194 support

2018-09-21 Thread Thierry Reding
From: Thierry Reding The display controllers found on Tegra194 are almost identical to those found on Tegra186. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/dc.c | 51 + drivers/gpu/drm/tegra/dc.h | 2 +- drivers/gpu/drm/tegra/drm.c | 1 + 3

[PATCH 5/5] drm/tegra: sor: Add Tegra194 support

2018-09-21 Thread Thierry Reding
From: Thierry Reding The SOR implemented in Tegra194 is subtly different from its predecessor found in Tegra186. Most notably some registers have been moved around so it is no longer compatible. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/drm.c | 1 + drivers/gpu/drm/tegra/sor.c

[PATCH 2/5] drm/tegra: hub: Add Tegra194 support

2018-09-21 Thread Thierry Reding
From: Thierry Reding The display hub integrated into Tegra194 is almost identical to the one found on Tegra186. However, it doesn't support DSC (display stream compression) so it isn't fully compatible. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/drm.c | 1 +

Re: [PATCH 01/18] video/hdmi: Constify 'buffer' to the unpack functions

2018-09-21 Thread Hans Verkuil
On 09/20/18 20:51, Ville Syrjala wrote: > From: Ville Syrjälä > > The unpack functions just read from the passed in buffer, > so make it const. > > Cc: Thierry Reding > Cc: Hans Verkuil Acked-by: Hans Verkuil Thanks! Hans > Cc: linux-me...@vger.kernel.org > Signed-off-by: Ville

Re: [PATCH 07/18] video/hdmi: Handle the NTSC VBI infoframe

2018-09-21 Thread Hans Verkuil
On 09/20/18 20:51, Ville Syrjala wrote: > From: Ville Syrjälä > > Add the code to deal with the NTSC VBI infoframe. > > I decided against parsing the PES_data_field and just leave > it as an opaque blob, just dumping it out as hex in the log. > > Blindly typed from the spec, and totally

Re: [PATCH v2 13/16] arm64: dts: renesas: r8a77990: Add display output support

2018-09-21 Thread Laurent Pinchart
Hi Simon, On Friday, 21 September 2018 10:16:44 EEST Simon Horman wrote: > On Wed, Sep 19, 2018 at 04:11:36PM +0300, Laurent Pinchart wrote: > > On Wednesday, 19 September 2018 11:35:07 EEST Simon Horman wrote: > >> On Mon, Sep 17, 2018 at 11:59:32AM +0300, Laurent Pinchart wrote: > >>> On

Re: [PATCH] drm: rcar-du: Revert "drm: rcar-du: Use __drm_atomic_helper_plane_reset instead of copying the logic"

2018-09-21 Thread Daniel Vetter
On Mon, Sep 17, 2018 at 01:25:49PM +0100, Alexandru-Cosmin Gheorghe wrote: > Hi Kieran, > > On Mon, Sep 17, 2018 at 11:56:23AM +0100, Kieran Bingham wrote: > > Hi Alexandru, > > > > On 17/09/18 10:10, Alexandru-Cosmin Gheorghe wrote: > > > Hi Kieran, > > > > > > Sorry for that and thanks for

Re: [Intel-gfx] [PATCH 2/2] drm: Fix syncobj handing of schedule() returning 0

2018-09-21 Thread Daniel Vetter
On Tue, Sep 18, 2018 at 11:07:20AM +0100, Chris Wilson wrote: > After schedule() returns 0, we must do one last check of COND to > determine the reason for the wakeup with 0 jiffies remaining before > reporting the timeout -- otherwise we may lose the signal due to > scheduler delays. Ah classic!

Re: [PATCH v3 0/5] drm: more byteorder fixes

2018-09-21 Thread Daniel Vetter
On Wed, Sep 19, 2018 at 01:12:47PM +0200, Gerd Hoffmann wrote: > Fix fbdev emulation. > Fix bochs-drm and virtio-gpu drivers. > > Gerd Hoffmann (5): > drm: move native byte order quirk to new drm_mode_legacy_fb_format2 > function > drm: use drm_mode_legacy_fb_format2 in

Re: [PATCH] drm/exynos: simplify DMA mapping

2018-09-21 Thread Marek Szyprowski
Hi Andrzej, On 2018-09-21 10:58, Andrzej Hajda wrote: > Moving DMA mapping creation to drm_iommu_attach_device allows to avoid > looping through all components and maintaining DMA device flags. > > Signed-off-by: Andrzej Hajda > --- > drivers/gpu/drm/exynos/exynos_drm_drv.c | 50

Re: [PATCH v8 1/2] drm/panel: Add support for Truly NT35597 panel driver

2018-09-21 Thread Sean Paul
On Thu, Sep 20, 2018 at 03:52:36PM -0700, Abhinav Kumar wrote: > From: "abhin...@codeaurora.org" > > Add support for Truly NT35597 panel driver used > in MSM reference platforms. > > This panel driver supports both single DSI and dual DSI > modes. > > However, this patch series adds support

[PATCH v2] drm/exynos: simplify DMA mapping

2018-09-21 Thread Andrzej Hajda
Moving DMA mapping creation to drm_iommu_attach_device allows to avoid looping through all components and maintaining DMA device flags. v2: take care of configurations without IOMMU Signed-off-by: Andrzej Hajda --- Hi Inki, In the 2nd version I took care of non-iommu case, thanks to Marek.

[GIT PULL] mali-dp fixes

2018-09-21 Thread Liviu Dudau
Hi Dave, I have managed to push the fixes to the public tree without sending the pull request until today when I did a clean checkout of drm-fixes and realised my mistake. I've now rebased the tree on your latest drm-fixes branch. At your convenience, please pull these two patches. Many thanks,

Re: [PATCH v8 2/2] dt-bindings: Add Truly NT35597 panel driver bindings

2018-09-21 Thread Sean Paul
On Thu, Sep 20, 2018 at 03:52:37PM -0700, Abhinav Kumar wrote: > From: "abhin...@codeaurora.org" > > Add the device tree bindings for Truly NT35597 panel driver. > This panel driver supports both single DSI and dual DSI. > > However, this patch series supports only dual DSI. > > Changes in v8:

[Bug 107956] [CI][SHARDS] igt@kms_busy@extended_*_render-[abc] - dmesg-warn - Asynchronous wait on fence i915:kms_busy\[\d+\]/0:1 timed out \(hint:intel_atomic_commit_ready

2018-09-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107956 --- Comment #4 from Martin Peres --- https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_114/fi-ilk-650/igt@kms_b...@extended-pageflip-hang-newfb-render-b.html

Re: [PATCH v8 2/2] dt-bindings: Add Truly NT35597 panel driver bindings

2018-09-21 Thread Sean Paul
On Thu, Sep 20, 2018 at 03:52:37PM -0700, Abhinav Kumar wrote: > From: "abhin...@codeaurora.org" JFYI, this is going to munge your Author name. This can be fixed up when the patch is applied, so probably not worth a v9. Reviewed-by: Sean Paul > > Add the device tree bindings for Truly

[Bug 104602] [apitrace] Graphical artifacts in Civilization VI on RX Vega

2018-09-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104602 --- Comment #11 from Jason Playne --- (In reply to Jason Playne from comment #10) > (In reply to Timothy Arceri from comment #9) > > I'm not sure why yet but both the black triangles and the incorrect > > rendering behind the chinese emperor on

Re: [PATCH v8 1/2] drm/panel: Add support for Truly NT35597 panel driver

2018-09-21 Thread Sean Paul
On Thu, Sep 20, 2018 at 03:52:36PM -0700, Abhinav Kumar wrote: > From: "abhin...@codeaurora.org" > > Add support for Truly NT35597 panel driver used > in MSM reference platforms. > > This panel driver supports both single DSI and dual DSI > modes. > > However, this patch series adds support

Re: [PATCH 2/3] drm/exynos: scaler: Add support for tiled formats

2018-09-21 Thread Marek Szyprowski
Hi Inki, On 2018-09-21 05:20, Inki Dae wrote: > There are several warnings, > WARNING: line over 80 characters > #276: FILE: drivers/gpu/drm/exynos/exynos_drm_scaler.c:182: > + struct drm_exynos_ipp_task_rect *src_pos, const struct scaler_format > *fmt) > > WARNING: line over 80 characters >

Re: [PATCH v4 19/25] drm/i915/dsc: Add a power domain for VDSC on eDP/MIPI DSI

2018-09-21 Thread Manasi Navare
On Wed, Sep 19, 2018 at 01:57:00PM +0300, Ville Syrjälä wrote: > On Tue, Sep 18, 2018 at 02:10:17PM -0700, Manasi Navare wrote: > > On Tue, Sep 18, 2018 at 10:46:46PM +0300, Ville Syrjälä wrote: > > > On Tue, Sep 18, 2018 at 12:31:54PM -0700, Manasi Navare wrote: > > > > On Tue, Sep 18, 2018 at

[PATCH] drm/exynos: simplify DMA mapping

2018-09-21 Thread Andrzej Hajda
Moving DMA mapping creation to drm_iommu_attach_device allows to avoid looping through all components and maintaining DMA device flags. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 50 +++ drivers/gpu/drm/exynos/exynos_drm_iommu.c | 13 +-

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Leave intel_conn->mst_port set, use mst_port_gone instead

2018-09-21 Thread Daniel Vetter
On Tue, Sep 18, 2018 at 07:06:19PM -0400, Lyude Paul wrote: > Currently we set intel_connector->mst_port to NULL to signify that the > MST port has been removed from the system so that we can prevent further > action on the port such as connector probes, mode probing, etc. > However, we're going

Re: [PATCH 09/18] drm/i915: Pass intel_encoder to infoframe functions

2018-09-21 Thread Ville Syrjälä
On Fri, Sep 21, 2018 at 03:59:06PM +0200, Daniel Vetter wrote: > On Thu, Sep 20, 2018 at 09:51:36PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Make life simpler by passing around intel_encoder instead of > > drm_encoder. > > > > @r1@ > > identifier F =~ "infoframe"; > >

[Bug 107607] Problems with MST display (REG_WAIT takes a while or times out)

2018-09-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107607 --- Comment #4 from Paul Menzel --- (In reply to Jerry Zuo from comment #3) > Hi Paul, can you please explain what you did by "when switching the inputs > of the monitor (two systems are connected)"? The monitor has several inputs. Over the

[PATCH v2 06/18] video/hdmi: Handle the MPEG Source infoframe

2018-09-21 Thread Ville Syrjala
From: Ville Syrjälä Add the code to deal with the MPEG source infoframe. Blindly typed from the spec, and totally untested. v2: Rebase Cc: Thierry Reding Cc: Hans Verkuil Cc: linux-me...@vger.kernel.org Signed-off-by: Ville Syrjälä --- drivers/video/hdmi.c | 229

Re: [PATCH v7 2/2] dt-bindings: Add Truly NT35597 panel driver bindings

2018-09-21 Thread Linus Walleij
On Wed, Sep 19, 2018 at 7:55 PM Abhinav Kumar wrote: > From: "abhin...@codeaurora.org" > > Add the device tree bindings for Truly NT35597 panel driver. > This panel driver supports both single DSI and dual DSI. > > However, this patch series supports only dual DSI. > > Changes in v7: > -

[PATCH libdrm] meson: honor -Detnaviv=auto

2018-09-21 Thread Guido Günther
We support that value so it should work as expected. This does not make 'auto' the default since the API is still marked as experimental. --- meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 75c7bdff..8001a9cc 100644 ---

[PATCH v2] drm/arm/malidp: Validate rotations for compressed/uncompressed framebuffers for each layer

2018-09-21 Thread Liviu Dudau
From: Ayan Kumar Halder Add support for compressed framebuffers that are described using the framebuffer's modifier field. Mali DP uses the rotation memory for the decompressor of the format, so we need to check for space when the modifiers are present. Signed-off-by: Ayan Kumar Halder

Re: [PATCH 05/18] video/hdmi: Add an enum for HDMI packet types

2018-09-21 Thread Ville Syrjälä
On Fri, Sep 21, 2018 at 04:12:36PM +0200, Hans Verkuil wrote: > On 09/21/18 16:01, Ville Syrjälä wrote: > > On Fri, Sep 21, 2018 at 10:41:46AM +0200, Hans Verkuil wrote: > >> On 09/20/18 20:51, Ville Syrjala wrote: > >>> From: Ville Syrjälä > >>> > >>> We'll be wanting to send more than just

[PATCH v2 07/18] video/hdmi: Handle the NTSC VBI infoframe

2018-09-21 Thread Ville Syrjala
From: Ville Syrjälä Add the code to deal with the NTSC VBI infoframe. I decided against parsing the PES_data_field and just leave it as an opaque blob, just dumping it out as hex in the log. Blindly typed from the spec, and totally untested. v2: Rebase Cc: Thierry Reding Cc: Hans Verkuil

Re: [PATCH 06/18] video/hdmi: Handle the MPEG Source infoframe

2018-09-21 Thread Ville Syrjälä
On Fri, Sep 21, 2018 at 10:28:09AM +0200, Hans Verkuil wrote: > On 09/20/18 20:51, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Add the code to deal with the MPEG source infoframe. > > > > Blindly typed from the spec, and totally untested. > > I'm not sure this patch should be added at

Re: [Intel-gfx] [PATCH 08/18] drm/i915: Use memmove() for punching the hole into infoframes

2018-09-21 Thread Daniel Vetter
On Thu, Sep 20, 2018 at 09:51:35PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Replace the hand rolled memmove() with the real thing. > > Signed-off-by: Ville Syrjälä Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/i915/intel_hdmi.c | 4 +--- > 1 file changed, 1 insertion(+),

Re: [PATCH 05/18] video/hdmi: Add an enum for HDMI packet types

2018-09-21 Thread Ville Syrjälä
On Fri, Sep 21, 2018 at 10:41:46AM +0200, Hans Verkuil wrote: > On 09/20/18 20:51, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > We'll be wanting to send more than just infoframes over HDMI. So add an > > enum for other packet types. > > > > TODO: Maybe just include the infoframe types

Re: [PATCH v4 5/5] drm: bridge: add support for Cadence MHDP DPI/DP bridge

2018-09-21 Thread Sean Paul
On Thu, Sep 20, 2018 at 03:54:40PM +0100, Damian Kos wrote: > From: Quentin Schulz > > This adds basic support for Cadence MHDP DPI to DP bridge. > > Basically, it takes a DPI stream as input and output it encoded in DP > format. It's missing proper HPD, HDCP and currently supports only > SST

Re: [PATCH] drm/fb_helper: Allow leaking fbdev smem_start

2018-09-21 Thread Maxime Ripard
Hi, On Thu, Sep 20, 2018 at 03:04:12PM +0200, Neil Armstrong wrote: > Since "drm/fb: Stop leaking physical address", the default behaviour of > the DRM fbdev emulation is to set the smem_base to 0 and pass the new > FBINFO_HIDE_SMEM_START flag. > > The main reason is to avoid leaking physical

Re: [PATCH 02/10] phy: Add configuration interface

2018-09-21 Thread Maxime Ripard
On Wed, Sep 19, 2018 at 02:14:36PM +0200, Maxime Ripard wrote: > > I'm sorry but I'm not convinced a consumer driver should have all the > > details > > that are added in phy_configure_opts_mipi_dphy. > > If it can convince you, here is the parameters that are needed by all > the MIPI-DSI

[PATCH v4 5/6] drm/virtio: fix DRM_FORMAT_* handling

2018-09-21 Thread Gerd Hoffmann
Use DRM_FORMAT_HOST_XRGB, so we are using the correct format code on bigendian machines. Also set the quirk_addfb_prefer_host_byte_order mode_config bit so drm_mode_addfb() asks for the correct format code. Both DRM_FORMAT_* and VIRTIO_GPU_FORMAT_* are defined to be little endian, so using a

[PATCH v4 3/6] drm/bochs: fix DRM_FORMAT_* handling for big endian machines.

2018-09-21 Thread Gerd Hoffmann
Use DRM_FORMAT_HOST_XRGB, so we are using the correct format code on bigendian machines. Also set the quirk_addfb_prefer_host_byte_order mode_config bit so drm_mode_addfb() asks for the correct format code. Create our own plane and use drm_crtc_init_with_planes() instead of depending on the

[PATCH v4 2/6] drm: use drm_driver_legacy_fb_format in drm_gem_fbdev_fb_create

2018-09-21 Thread Gerd Hoffmann
Creating framebuffers for fbdev emulation should use the correct format code too, so switch drm_gem_fbdev_fb_create() over to use the new drm_driver_legacy_fb_format() function. Signed-off-by: Gerd Hoffmann Acked-by: Daniel Vetter --- drivers/gpu/drm/drm_gem_framebuffer_helper.c | 4 ++-- 1

[PATCH v4 1/6] drm: move native byte order quirk to new drm_driver_legacy_fb_format function

2018-09-21 Thread Gerd Hoffmann
Turns out we need the pixel format fixup not only for the addfb ioctl, but also for fbdev emulation code. Ideally we would place it in drm_mode_legacy_fb_format(). That would create alot of churn though, and most drivers don't care because they never ever run on a big endian platform. So add a

[PATCH v4 4/6] drm/bochs: support changing byteorder at mode set time

2018-09-21 Thread Gerd Hoffmann
Add bochs_hw_set_*_endian() helper functions, to set the framebuffer byteorder at mode set time. Support both DRM_FORMAT_XRGB and DRM_FORMAT_BGRX framebuffer formats, no matter what the native machine byte order is. Signed-off-by: Gerd Hoffmann Acked-by: Daniel Vetter ---

[PATCH v4 6/6] drm: move quirk_addfb_prefer_xbgr_30bpp handling to drm_driver_legacy_fb_format too

2018-09-21 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/drm_fourcc.c | 5 + drivers/gpu/drm/drm_framebuffer.c | 4 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c index 7c6d3922ed..90a1c846fc 100644 ---

Re: [PATCH v4 19/25] drm/i915/dsc: Add a power domain for VDSC on eDP/MIPI DSI

2018-09-21 Thread Ville Syrjälä
On Fri, Sep 21, 2018 at 01:34:00AM -0700, Manasi Navare wrote: > On Wed, Sep 19, 2018 at 01:57:00PM +0300, Ville Syrjälä wrote: > > On Tue, Sep 18, 2018 at 02:10:17PM -0700, Manasi Navare wrote: > > > On Tue, Sep 18, 2018 at 10:46:46PM +0300, Ville Syrjälä wrote: > > > > On Tue, Sep 18, 2018 at

[PATCH v4 0/6] drm: more byteorder fixes

2018-09-21 Thread Gerd Hoffmann
Fix fbdev emulation. Fix bochs-drm and virtio-gpu drivers. Gerd Hoffmann (6): drm: move native byte order quirk to new drm_driver_legacy_fb_format function drm: use drm_driver_legacy_fb_format in drm_gem_fbdev_fb_create drm/bochs: fix DRM_FORMAT_* handling for big endian machines.

Re: [PATCH 09/18] drm/i915: Pass intel_encoder to infoframe functions

2018-09-21 Thread Daniel Vetter
On Thu, Sep 20, 2018 at 09:51:36PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Make life simpler by passing around intel_encoder instead of > drm_encoder. > > @r1@ > identifier F =~ "infoframe"; > identifier I, M; > @@ > F( > - struct drm_encoder *I > + struct intel_encoder *I > ,

Re: [Intel-gfx] [PATCH 10/18] drm/i915: Add the missing HDMI gamut metadata packet stuff

2018-09-21 Thread Daniel Vetter
On Thu, Sep 20, 2018 at 09:51:37PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > We have definitions and low level code for everything except the gamut > metadata HDMI packet. Add the missing bits. > > Signed-off-by: Ville Syrjälä Online Bspec seems to have dropped pre-cpt/snb stuff,

Re: Bug report: HiBMC crash

2018-09-21 Thread Chris Wilson
Quoting John Garry (2018-09-21 09:11:19) > On 21/09/2018 06:49, Liuxinliang (Matthew Liu) wrote: > > Hi John, > > Thank you for reporting bug. > > I am now using 4.18.7. I haven't found this issue yet. > > I will try linux-next and figure out what's wrong with it. > > > > Thanks, > > Xinliang > >

[PATCH v3 04/18] video/hdmi: Constify infoframe passed to the pack functions

2018-09-21 Thread Ville Syrjala
From: Ville Syrjälä Let's make the infoframe pack functions usable with a const infoframe structure. This allows us to precompute the infoframe earlier, and still pack it later when we're no longer allowed to modify the structure. So now we end up with a _check()+_pack_only() or _pack()

Re: [PATCH 04/18] video/hdmi: Constify infoframe passed to the pack functions

2018-09-21 Thread Ville Syrjälä
On Fri, Sep 21, 2018 at 10:24:25AM +0200, Hans Verkuil wrote: > On 09/20/18 20:51, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Let's make the infoframe pack functions usable with a const infoframe > > structure. This allows us to precompute the infoframe earlier, and still > > pack it

Re: [PATCH 07/18] video/hdmi: Handle the NTSC VBI infoframe

2018-09-21 Thread Ville Syrjälä
On Fri, Sep 21, 2018 at 10:30:16AM +0200, Hans Verkuil wrote: > On 09/20/18 20:51, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Add the code to deal with the NTSC VBI infoframe. > > > > I decided against parsing the PES_data_field and just leave > > it as an opaque blob, just dumping it

Re: [PATCH 05/18] video/hdmi: Add an enum for HDMI packet types

2018-09-21 Thread Hans Verkuil
On 09/21/18 16:01, Ville Syrjälä wrote: > On Fri, Sep 21, 2018 at 10:41:46AM +0200, Hans Verkuil wrote: >> On 09/20/18 20:51, Ville Syrjala wrote: >>> From: Ville Syrjälä >>> >>> We'll be wanting to send more than just infoframes over HDMI. So add an >>> enum for other packet types. >>> >>> TODO:

  1   2   >