Re: [PATCH] drm/exynos: dsi: Remove bridge node reference in error handling path in probe function

2020-05-12 Thread Inki Dae
Hi, 20. 5. 11. 오전 12:48에 Christophe JAILLET 이(가) 쓴 글: > 'exynos_dsi_parse_dt()' takes a reference to 'dsi->in_bridge_node'. > This must be released in the error handling path. > > This patch is similar to commit 70505c2ef94b ("drm/exynos: dsi: Remove bridge > node reference in removal") > which

Re: [Nouveau] [PATCH 1/3] drm/radeon: remove AGP support

2020-05-12 Thread Alex Deucher
On Tue, May 12, 2020 at 4:52 PM Roy Spliet wrote: > > Op 12-05-2020 om 14:36 schreef Alex Deucher: > > On Tue, May 12, 2020 at 4:16 AM Michel Dänzer wrote: > >> > >> On 2020-05-11 10:12 p.m., Alex Deucher wrote: > >>> On Mon, May 11, 2020 at 1:17 PM Christian König > >>> wrote: > >

Re: [PATCH] docs: dt: fix broken links due to txt->yaml renames

2020-05-12 Thread Rob Herring
On Mon, May 04, 2020 at 11:30:20AM +0200, Mauro Carvalho Chehab wrote: > There are some new broken doc links due to yaml renames > at DT. Developers should really run: > > ./scripts/documentation-file-ref-check > > in order to solve those issues while submitting patches. > This tool can

Re: [PATCH v10 0/2] Panel rotation patches

2020-05-12 Thread Sean Paul
On Thu, Apr 16, 2020 at 7:03 PM Dmitry Osipenko wrote: > > 15.04.2020 00:32, dbasehore . пишет: > > On Tue, Apr 14, 2020 at 2:18 PM Dmitry Osipenko wrote: > >> > >> 14.04.2020 22:32, dbasehore . пишет: > >>> Hi Dmitry, sorry for the late reply. > >>> > >>> On Sun, Mar 8, 2020 at 12:25 PM Dmitry

[pull] amdgpu, amdkfd drm-next-5.8

2020-05-12 Thread Alex Deucher
Hi Dave, Daniel, More stuff for 5.8. The following changes since commit b8020b0304c8f44e5e29f0b1a04d31e0bf68d26a: drm/amdkfd: Enable over-subscription with >1 GWS queue (2020-04-28 16:20:30 -0400) are available in the Git repository at: git://people.freedesktop.org/~agd5f/linux

Re: [RFC v2] drm/connector: Add support for privacy-screen properties (v2)

2020-05-12 Thread Hans de Goede
Hi, On 5/12/20 10:44 PM, mario.limoncie...@dell.com wrote: -Original Message- From: Hans de Goede Sent: Monday, May 11, 2020 12:47 PM To: Maarten Lankhorst; Maxime Ripard; Thomas Zimmermann; Daniel Vetter; David Airlie; Rajat Jain; Jani Nikula Cc: Hans de Goede; Pekka Paalanen;

Re: [RFC v2] drm/connector: Add support for privacy-screen properties (v2)

2020-05-12 Thread Hans de Goede
Hi, On 5/11/20 10:04 PM, Rajat Jain wrote: On Mon, May 11, 2020 at 10:47 AM Hans de Goede wrote: From: Rajat Jain Add support for generic electronic privacy screen properties, that can be added by systems that have an integrated EPS. Changes in v2 (Hans de Goede) - Create 2 properties,

[PATCH v2 07/15] drm/mgag200: Set pitch in a separate helper function

2020-05-12 Thread Thomas Zimmermann
The framebuffer's pitch is now set in mgag200_set_offset(). v2: * move offset and bpp-shift calculation into helper functions * use u8 instead of uint8_t * add MGAREG_CRTCEXT0_OFFSET_MASK Signed-off-by: Thomas Zimmermann Tested-by: John Donnelly ---

[PATCH v2 13/15] drm/mgag200: Use simple-display data structures

2020-05-12 Thread Thomas Zimmermann
The MGA CRTC data structure struct mga_crtc contains unused additional fields; so it can removed. The standard DRM CRTC and encoder structures are embedded now in struct drm_simple_display_pipe. Done in preparation of converting mgag200 to simple KMS helpers. Signed-off-by: Thomas Zimmermann

[PATCH v2 01/15] drm/mgag200: Remove HW cursor

2020-05-12 Thread Thomas Zimmermann
The HW cursor of Matrox G200 cards only supports a 16-color palette format. Univeral planes require at least ARGB or a similar component- based format, so remove the HW cursor. Alternatively, the driver could dither a cursor image from ARGB to 16 colors. But this does not produce pleasent-looking

[PATCH v2 06/15] drm/mgag200: Update mode registers after plane registers

2020-05-12 Thread Thomas Zimmermann
Setting the plane registers first and the mode registers afterwards reproduces the sequence used by atomic helpers. Done in preparation of switching to simple KMS helpers. Signed-off-by: Thomas Zimmermann Tested-by: John Donnelly Acked-by: Sam Ravnborg ---

[PATCH v2 02/15] drm/mgag200: Clean up mga_set_start_address()

2020-05-12 Thread Thomas Zimmermann
All register names and fields are now named according to the MGA programming manuals. The function doesn't need the CRTC, so callers pass in the device structure directly. The logging now uses device-specific macros. v2: * use to_mga_device() * use MiB instead of MB *

[PATCH v2 14/15] drm/mgag200: Convert to simple KMS helper

2020-05-12 Thread Thomas Zimmermann
The mgag200 supports a single pipeline with only a primary plane. It can be converted to simple KMS helpers. This also adds support for atomic modesetting. Wayland compositors, which use pageflip ioctls, can now be used with mgag200. v2: * prepare encoder and CRTC in a separate patch

[PATCH v2 15/15] drm/mgag200: Replace VRAM helpers with SHMEM helpers

2020-05-12 Thread Thomas Zimmermann
The VRAM helpers managed the framebuffer memory for mgag200. This came with several problems, as some MGA device require the scanout address to be located at VRAM offset 0. It's incompatible with the page-flip semantics of DRM's atomic modesettting. With atomic modesetting, old and new

[PATCH v2 12/15] drm/mgag200: Remove out-commented suspend/resume helpers

2020-05-12 Thread Thomas Zimmermann
The suspend/resume helpers are unused. Also remove associated state from struct mga_device. Signed-off-by: Thomas Zimmermann Tested-by: John Donnelly Acked-by: Sam Ravnborg --- drivers/gpu/drm/mgag200/mgag200_drv.h | 1 - drivers/gpu/drm/mgag200/mgag200_mode.c | 71

[PATCH v2 10/15] drm/mgag200: Move hiprilvl setting into separate functions

2020-05-12 Thread Thomas Zimmermann
The hiprivlvl settings are now updated in mgag200_g200se_set_hiprilvl() and mgag200_g200ev_set_hiprilvl(). v2: * replace uint8_t with u8 Signed-off-by: Thomas Zimmermann Tested-by: John Donnelly Acked-by: Sam Ravnborg --- drivers/gpu/drm/mgag200/mgag200_mode.c | 98

[PATCH v2 09/15] drm/mgag200: Move TAGFIFO reset into separate function

2020-05-12 Thread Thomas Zimmermann
The TAGFIFO state is now reset in mgag200_g200er_reset_tagfifo(). v2: * define MGAREG_SEQ1_SCROFF Signed-off-by: Thomas Zimmermann Tested-by: John Donnelly Acked-by: Sam Ravnborg --- drivers/gpu/drm/mgag200/mgag200_drv.h | 6 drivers/gpu/drm/mgag200/mgag200_mode.c | 45

[PATCH v2 08/15] drm/mgag200: Set primary plane's format in separate helper function

2020-05-12 Thread Thomas Zimmermann
The primary plane's format registers are now updated in a mgag200_set_format_regs(). v2: * get bpp shift from helper function * replace uint8_t with u8 Signed-off-by: Thomas Zimmermann Tested-by: John Donnelly --- drivers/gpu/drm/mgag200/mgag200_mode.c | 109

[PATCH v2 04/15] drm/mgag200: Move mode-setting code into separate helper function

2020-05-12 Thread Thomas Zimmermann
The mode-setting code is now located in mgag200_set_mode_regs(), sans a few flags that will be moved in a later patch for clarity. v2: * replace uint8_t with u8 Signed-off-by: Thomas Zimmermann Tested-by: John Donnelly Acked-by: Sam Ravnborg --- drivers/gpu/drm/mgag200/mgag200_mode.c

[PATCH v2 11/15] drm/mgag200: Move register initialization into separate function

2020-05-12 Thread Thomas Zimmermann
Registers are initialized with constants. This is now done in mgag200_init_regs(), mgag200_set_dac_regs() and mgag200_set_pci_regs(). Later patches should move these calls from mode setting to device initialization. v2: * replace uint8_t with u8 Signed-off-by: Thomas Zimmermann

[PATCH v2 00/15] drm/mgag200: Convert to atomic modesetting

2020-05-12 Thread Thomas Zimmermann
This patchset converts mgag200 to atomic modesetting. It uses simple KMS helpers and SHMEM. Patch 1 removes cursor support. The HW cursor is not usable with the way universal planes work. Patches 2 to 11 untangle the existing modesetting code into smaller functions. Specifically, mode setting

[PATCH v2 03/15] drm/mgag200: Clean up mga_crtc_do_set_base()

2020-05-12 Thread Thomas Zimmermann
The function now only takes the device structure, and the old and new framebuffers. Signed-off-by: Thomas Zimmermann Tested-by: John Donnelly Acked-by: Sam Ravnborg --- drivers/gpu/drm/mgag200/mgag200_mode.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git

[PATCH v2 05/15] drm/mgag200: Split MISC register update into PLL selection, SYNC and I/O

2020-05-12 Thread Thomas Zimmermann
Set different fields in MISC in their rsp location in the code. This patch also fixes a bug in the original code where the mode's SYNC flags were never written into the MISC register. v2: * use u8 instead of uint8_t * define MGAREG_MISC_CLK_SEL_MASK Signed-off-by: Thomas

[PATCH v3 2/2] mtd: rawnand: brcmnand: improve hamming oob layout

2020-05-12 Thread Álvaro Fernández Rojas
The current code generates 8 oob sections: S1 1-5 ECC 6-8 S2 9-15 S3 16-21 ECC 22-24 S4 25-31 S5 32-37 ECC 38-40 S6 41-47 S7 48-53 ECC 54-56 S8 57-63 Change it by merging continuous sections: S1 1-5 ECC 6-8 S2 9-21 ECC

Re: [PATCH] dma-buf: fix use-after-free in dmabuffs_dname

2020-05-12 Thread Charan Teja Kalla
Thank you Greg for the comments. On 5/6/2020 2:30 PM, Greg KH wrote: On Wed, May 06, 2020 at 02:00:10PM +0530, Charan Teja Kalla wrote: Thank you Greg for the reply. On 5/5/2020 3:38 PM, Greg KH wrote: On Tue, Apr 28, 2020 at 01:24:02PM +0530, Charan Teja Reddy wrote: The following race

[PATCH v3 4/5] clk: stm32: Fix stm32f429 ltdc driver loading hang in clk set rate. keep ltdc clk running after kernel startup

2020-05-12 Thread dillon . minfei
From: dillon min as store stm32f4_rcc_register_pll return to the wrong offset of clks, so ltdc gate clk is null. need change clks[PLL_VCO_SAI] to clks[PLL_SAI] add CLK_IGNORE_UNUSED for ltdc to make sure clk not be freed by clk_disable_unused Signed-off-by: dillon min ---

BUG: unable to handle kernel paging request in bitfill_aligned

2020-05-12 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:1d3962ae Merge tag 'io_uring-5.7-2020-05-08' of git://git... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1487425810 kernel config: https://syzkaller.appspot.com/x/.config?x=b0212dbee046bc1f

Re: [PATCH v5 6/6] arm64: dts: sdm845: Add "no-hpd" to sn65dsi86 on cheza

2020-05-12 Thread Bjorn Andersson
On Thu 07 May 14:35 PDT 2020, Douglas Anderson wrote: > We don't have the HPD line hooked up to the bridge chip. Add it as > suggested in the patch ("dt-bindings: drm/bridge: ti-sn65dsi86: > Document no-hpd"). > > NOTE: this patch isn't expected to have any effect but just keeps us > cleaner

[PATCH v7 01/15] PM / EM: change naming convention from 'capacity' to 'performance'

2020-05-12 Thread Lukasz Luba
The Energy Model uses concept of performance domain and capacity states in order to calculate power used by CPUs. Change naming convention from capacity to performance state would enable wider usage in future, e.g. upcoming support for other devices other than CPUs. Acked-by: Daniel Lezcano

[PATCH v7 13/15] thermal: devfreq_cooling: remove old power model and use EM

2020-05-12 Thread Lukasz Luba
Remove old power model and use new Energy Model to calculate the power budget. It drops static + dynamic power calculations and power table in order to use Energy Model performance domain data. This model should be easy to use and could find more users. It is also less complicated to setup the

[PATCH v7 08/15] OPP: refactor dev_pm_opp_of_register_em() and update related drivers

2020-05-12 Thread Lukasz Luba
The Energy Model framework supports not only CPU devices. Drop the CPU specific interface with cpumask and add struct device. Add also a return value, user might use it. This new interface provides easy way to create a simple Energy Model, which then might be used by e.g. thermal subsystem.

[PATCH v3 1/5] ARM: dts: stm32: Add pin map for ltdc, spi5 on stm32f429-disco board

2020-05-12 Thread dillon . minfei
From: dillon min This patch adds the pin configuration for ltdc, spi5 controller on stm32f429-disco board. Signed-off-by: dillon min --- arch/arm/boot/dts/stm32f4-pinctrl.dtsi | 67 ++ 1 file changed, 67 insertions(+) diff --git

[PATCH v3 3/5] ARM: dts: stm32: enable ltdc binding with ili9341 on stm32429-disco board

2020-05-12 Thread dillon . minfei
From: dillon min Enable the ltdc & ili9341 on stm32429-disco board. Signed-off-by: dillon min --- Changes: V3: change dts binding compatible to "st,sf-tc240t-9370-t" V2: none v1: none arch/arm/boot/dts/stm32f429-disco.dts | 39 +++ 1 file

[PATCH v7 09/15] thermal: devfreq_cooling: change tracing function and arguments

2020-05-12 Thread Lukasz Luba
Prepare for deleting the static and dynamic power calculation and clean the trace function. These two fields are going to be removed in the next changes. Reviewed-by: Steven Rostedt (VMware) # for tracing code Signed-off-by: Lukasz Luba --- drivers/thermal/devfreq_cooling.c | 3 +--

Re: [Intel-gfx] [PATCH 3/3] misc/habalabs: don't set default fence_ops->wait

2020-05-12 Thread Daniel Vetter
On Tue, May 12, 2020 at 4:14 AM Dave Airlie wrote: > > On Mon, 11 May 2020 at 19:37, Oded Gabbay wrote: > > > > On Mon, May 11, 2020 at 12:11 PM Daniel Vetter > > wrote: > > > > > > It's the default. > > Thanks for catching that. > > > > > > > > Also so much for "we're not going to tell the

Re: [RFC] Remove AGP support from Radeon/Nouveau/TTM

2020-05-12 Thread Christian König
Am 11.05.20 um 22:46 schrieb Alex Deucher: On Mon, May 11, 2020 at 4:41 PM John Paul Adrian Glaubitz wrote: On 5/11/20 10:05 PM, Alex Deucher wrote: For Nouveau I'm not 100% sure, but from the code it of hand looks like we can do it similar to Radeon. Please comment what you think about

Re: [PATCH 1/3] drm/radeon: remove AGP support

2020-05-12 Thread Michel Dänzer
On 2020-05-11 10:12 p.m., Alex Deucher wrote: > On Mon, May 11, 2020 at 1:17 PM Christian König > wrote: >> >> AGP is deprecated for 10+ years now and not used any more on modern hardware. >> >> Old hardware should continue to work in PCI mode. > > Might want to clarify that there is no loss of

Re: [PATCH] dma-buf: fix use-after-free in dmabuffs_dname

2020-05-12 Thread Greg KH
On Tue, May 12, 2020 at 10:43:18AM +0530, Charan Teja Kalla wrote: > > Ok, but watch out, now you have 2 different reference counts for the > > same structure. Keeping them coordinated is almost always an impossible > > task so you need to only rely on one. If you can't use the file api, > >

Re: [RFC v2] drm/connector: Add support for privacy-screen properties (v2)

2020-05-12 Thread Hans de Goede
Hi, On 5/12/20 9:49 AM, Pekka Paalanen wrote: On Mon, 11 May 2020 19:47:24 +0200 Hans de Goede wrote: From: Rajat Jain Add support for generic electronic privacy screen properties, that can be added by systems that have an integrated EPS. Changes in v2 (Hans de Goede) - Create 2

[PATCH v7 03/15] PM / EM: update callback structure and add device pointer

2020-05-12 Thread Lukasz Luba
The Energy Model framework is going to support devices other that CPUs. In order to make this happen change the callback function and add pointer to a device as an argument. Update the related users to use new function and new callback from the Energy Model. Signed-off-by: Lukasz Luba ---

[PATCH v7 00/15] Add support for devices in the Energy Model

2020-05-12 Thread Lukasz Luba
Hi all, This patch set introduces support for devices in the Energy Model (EM) framework. It will unify the power model for thermal subsystem. It will make simpler to add support for new devices willing to use more advanced features (like Intelligent Power Allocation). Now it should require less

[PATCH v7 04/15] PM / EM: add support for other devices than CPUs in Energy Model

2020-05-12 Thread Lukasz Luba
Add support for other devices that CPUs. The registration function does not require a valid cpumask pointer and is ready to handle new devices. Some of the internal structures has been reorganized in order to keep consistent view (like removing per_cpu pd pointers). To track usage of the Energy

[PATCH v7 05/15] PM / EM: remove em_register_perf_domain

2020-05-12 Thread Lukasz Luba
Remove old function em_register_perf_domain which is no longer needed. There is em_dev_register_perf_domain that covers old use cases and new as well. Acked-by: Daniel Lezcano Signed-off-by: Lukasz Luba --- include/linux/energy_model.h | 7 --- kernel/power/energy_model.c | 25

[PATCH v7 10/15] thermal: devfreq_cooling: get device load and frequency directly

2020-05-12 Thread Lukasz Luba
Devfreq cooling needs to now the correct status of the device in order to operate. Do not rely on Devfreq last_status which might be a stale data and get more up-to-date values of load and frequency. In addition this patch adds normalization function, which also makes sure that whatever data

[PATCH v3 1/2] mtd: rawnand: brcmnand: fix hamming oob layout

2020-05-12 Thread Álvaro Fernández Rojas
First 2 bytes are used in large-page nand. Fixes: ef5eeea6e911 ("mtd: nand: brcm: switch to mtd_ooblayout_ops") Cc: sta...@vger.kernel.org Signed-off-by: Álvaro Fernández Rojas --- v3: invert patch order v2: extend original comment drivers/mtd/nand/raw/brcmnand/brcmnand.c | 11 +++ 1

[PATCH v7 11/15] thermal: devfreq_cooling: work on a copy of device status

2020-05-12 Thread Lukasz Luba
Devfreq framework can change the device status in the background. To mitigate this situation make a copy of the status structure and use it for internal calculations. Signed-off-by: Lukasz Luba --- drivers/thermal/devfreq_cooling.c | 14 ++ 1 file changed, 10 insertions(+), 4

[PATCH v3 0/5] Enable ilitek ili9341 on stm32f429-disco board

2020-05-12 Thread dillon . minfei
From: dillon min This patchset has following changes: V3: merge original tiny/ili9341.c driver to panel/panel-ilitek-ili9341.c to support serial spi & parallel rgb interface in one driver. update ilitek,ili9341.yaml dts binding documentation. update stm32f429-disco dts binding

[PATCH v7 12/15] thermal: devfreq_cooling: add new registration functions with Energy Model

2020-05-12 Thread Lukasz Luba
The Energy Model (EM) framework supports devices such as Devfreq. Create new registration functions which automatically register EM for the thermal devfreq_cooling devices. This patch prepares the code for coming changes which are going to replace old power model with the new EM. Signed-off-by:

Re: [PATCH v5 1/6] drm/bridge: ti-sn65dsi86: Export bridge GPIOs to Linux

2020-05-12 Thread Bjorn Andersson
On Thu 07 May 14:34 PDT 2020, Douglas Anderson wrote: > The ti-sn65dsi86 MIPI DSI to eDP bridge chip has 4 pins on it that can > be used as GPIOs in a system. Each pin can be configured as input, > output, or a special function for the bridge chip. These are: > - GPIO1: SUSPEND Input > - GPIO2:

[PATCH v3] mtd: rawnand: brcmnand: correctly verify erased pages

2020-05-12 Thread Álvaro Fernández Rojas
The current code checks that the whole OOB area is erased. This is a problem when JFFS2 cleanmarkers are added to the OOB, since it will fail due to the usable OOB bytes not being 0xff. Correct this by only checking that data and ECC bytes aren't 0xff. Fixes: 02b88eea9f9c ("mtd: brcmnand: Add

[PATCH v3 2/5] dt-bindings: display: panel: Add ilitek ili9341 panel bindings

2020-05-12 Thread dillon . minfei
From: dillon min Add documentation for "ilitek,ili9341" panel. Signed-off-by: dillon min --- Changes: V3: change compatible to st,sf-tc240t-9370-t, match #vendor,#lcd_module style V2: verifyied with make dt_binding_check V1: none .../bindings/display/panel/ilitek,ili9341.yaml

[PATCH v7 07/15] Documentation: power: update Energy Model description

2020-05-12 Thread Lukasz Luba
The Energy Model framework supports also other devices than CPUs. Update related information and add description for the new usage. Acked-by: Daniel Lezcano Signed-off-by: Lukasz Luba --- Documentation/power/energy-model.rst | 135 +++ 1 file changed, 75 insertions(+),

[PATCH v7 06/15] PM / EM: change name of em_pd_energy to em_cpu_energy

2020-05-12 Thread Lukasz Luba
Energy Model framework supports now other devices than CPUs. Refactor some of the functions in order to prevent wrong usage. The old function em_pd_energy has to generic name. It must not be used without proper cpumask pointer, which is possible only for CPU devices. Thus, rename it and add proper

[PATCH v3 5/5] drm/panel: Add ilitek ili9341 driver

2020-05-12 Thread dillon . minfei
From: dillon min Currently, we can use tinydrm ili9341 driver to drive ili9341 panel by spi interface (both register configuration and video) ili9341 have parallel and mcu interface as well, we extend the support to parallel rgb interface with DRM_MODE_CONNECTOR_DPI this driver can work as

[PATCH v7 14/15] thermal: devfreq_cooling: update license to use SPDX

2020-05-12 Thread Lukasz Luba
Change the license headers and use SPDX standard. Signed-off-by: Lukasz Luba --- drivers/thermal/devfreq_cooling.c | 12 ++-- include/linux/devfreq_cooling.h | 12 ++-- 2 files changed, 4 insertions(+), 20 deletions(-) diff --git a/drivers/thermal/devfreq_cooling.c

[PATCH v7 02/15] PM / EM: introduce em_dev_register_perf_domain function

2020-05-12 Thread Lukasz Luba
Add now function in the Energy Model framework which is going to support new devices. This function will help in transition and make it smoother. For now it still checks if the cpumask is a valid pointer, which will be removed later when the new structures and infrastructure will be ready.

[PATCH v3 0/2] mtd: rawnand: brcmnand: improve hamming oob layout

2020-05-12 Thread Álvaro Fernández Rojas
These patches improve the OOB hamming layout by reducing the number of oob sections and correctly v3: invert patch order. v2: extend original comment and correctly skip byte 6 for small-page. Álvaro Fernández Rojas (2): mtd: rawnand: brcmnand: fix hamming oob layout mtd: rawnand: brcmnand:

[PATCH v7 15/15] drm/panfrost: Register devfreq cooling and attempt to add Energy Model

2020-05-12 Thread Lukasz Luba
Register devfreq cooling device and attempt to register Energy Model. This will add the devfreq device to the Energy Model framework. It will create a dedicated and unified data structures used i.e. in thermal framework. The last NULL parameter indicates that the power model is simplified and

Re: [RFC v2 0/1] drm/connector: Add support for privacy-screen properties

2020-05-12 Thread Hans de Goede
Hi, On 5/11/20 9:55 PM, Rajat Jain wrote: Hi Hans, On Mon, May 11, 2020 at 10:47 AM Hans de Goede mailto:hdego...@redhat.com>> wrote: Hi All, This RFC takes Rajat's earlier patch for adding privacy-screen properties infra to drm_connector.c and then adds the results of the

[PATCH v5 2/3] drm/i915/dp: Attach and set drm connector VRR property

2020-05-12 Thread Manasi Navare
From: Aditya Swarup This function sets the VRR property for connector based on the platform support, EDID monitor range and DP sink DPCD capability of outputing video without msa timing information. v5: * Fix the vrr prop not being set in kernel (Manasi) * Unset the prop on connector disconnect

[PATCH v5 3/3] drm/i915/dp: Expose connector VRR info via debugfs

2020-05-12 Thread Manasi Navare
From: Bhanuprakash Modem [Why] It's useful to know the min and max vrr range for IGT testing. [How] Expose the min and max vfreq for the connector via a debugfs file on the connector, "i915_vrr_info". Example usage: cat /sys/kernel/debug/dri/0/DP-1/i915_vrr_info v5: * Rename to vrr_range to

[PATCH v5 1/3] drm/dp: DRM DP helper for reading Ignore MSA from DPCD

2020-05-12 Thread Manasi Navare
DP sink device sets the Ignore MSA bit in its DP_DOWNSTREAM_PORT_COUNT register to indicate its ability to ignore the MSA video timing parameters and its ability to support seamless video timing change over a range of timing exposed by DisplayID and EDID. This is required for the sink to indicate

Re: [PATCH v4 1/6] drm/bridge: ti-sn65dsi86: Export bridge GPIOs to Linux

2020-05-12 Thread Linus Walleij
On Thu, May 7, 2020 at 4:39 PM Doug Anderson wrote: > One suggestion that came off-list is to change the code to make the > numbering match up better with the datasheet. Right now if you want > GPIO 2 you have to refer to it like: > > hpd-gpios = <_bridge 1 GPIO_ACTIVE_HIGH>; > > That's because

Re: [PATCH v5 1/6] drm/bridge: ti-sn65dsi86: Export bridge GPIOs to Linux

2020-05-12 Thread Linus Walleij
On Thu, May 7, 2020 at 11:35 PM Douglas Anderson wrote: > The ti-sn65dsi86 MIPI DSI to eDP bridge chip has 4 pins on it that can > be used as GPIOs in a system. Each pin can be configured as input, > output, or a special function for the bridge chip. These are: > - GPIO1: SUSPEND Input > -

Re: [PATCH v4 01/38] dma-mapping: add generic helpers for mapping sgtable objects

2020-05-12 Thread Marek Szyprowski
Hi Christoph, On 12.05.2020 14:18, Christoph Hellwig wrote: > On Tue, May 12, 2020 at 11:00:21AM +0200, Marek Szyprowski wrote: >> struct sg_table is a common structure used for describing a memory >> buffer. It consists of a scatterlist with memory pages and DMA addresses >> (sgl entry), as well

Re: [RFC] Remove AGP support from Radeon/Nouveau/TTM

2020-05-12 Thread Alex Deucher
On Tue, May 12, 2020 at 5:40 AM Karoly Balogh (Charlie/SGR) wrote: > > Hi, > > On Tue, 12 May 2020, Rui Salvaterra wrote: > > > > FWIW, on my last-generation PowerBook with RV350 (IIRC), there was a > > > big performance difference between AGP and PCI GART. The latter was > > > sort of usable for

Re: [RFC 16/17] drm/amdgpu: gpu recovery does full modesets

2020-05-12 Thread Alex Deucher
On Tue, May 12, 2020 at 9:17 AM Daniel Vetter wrote: > > On Tue, May 12, 2020 at 3:12 PM Alex Deucher wrote: > > > > On Tue, May 12, 2020 at 8:58 AM Daniel Vetter wrote: > > > > > > On Tue, May 12, 2020 at 08:54:45AM -0400, Alex Deucher wrote: > > > > On Tue, May 12, 2020 at 5:00 AM Daniel

Re: [RFC 16/17] drm/amdgpu: gpu recovery does full modesets

2020-05-12 Thread Daniel Vetter
On Tue, May 12, 2020 at 3:29 PM Alex Deucher wrote: > > On Tue, May 12, 2020 at 9:17 AM Daniel Vetter wrote: > > > > On Tue, May 12, 2020 at 3:12 PM Alex Deucher wrote: > > > > > > On Tue, May 12, 2020 at 8:58 AM Daniel Vetter wrote: > > > > > > > > On Tue, May 12, 2020 at 08:54:45AM -0400,

Re: [RFC 16/17] drm/amdgpu: gpu recovery does full modesets

2020-05-12 Thread Daniel Vetter
On Tue, May 12, 2020 at 08:54:45AM -0400, Alex Deucher wrote: > On Tue, May 12, 2020 at 5:00 AM Daniel Vetter wrote: > > > > ... > > > > I think it's time to stop this little exercise. > > > > The lockdep splat, for the record: > > > > [ 132.583381]

Re: [RFC 02/17] dma-fence: basic lockdep annotations

2020-05-12 Thread Daniel Vetter
On Tue, May 12, 2020 at 09:09:52AM -0300, Jason Gunthorpe wrote: > On Tue, May 12, 2020 at 10:59:29AM +0200, Daniel Vetter wrote: > > diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c > > index 6802125349fb..d5c0fd2efc70 100644 > > +++ b/drivers/dma-buf/dma-fence.c > > @@

Re: [PATCH -next] drm/mcde: dsi: Fix return value check in dev_err()

2020-05-12 Thread Emil Velikov
Hi all, On Tue, 12 May 2020 at 12:49, Linus Walleij wrote: > > On Tue, Apr 28, 2020 at 4:13 PM Wei Yongjun wrote: > > > In case of error, the function of_drm_find_bridge() returns NULL pointer > > not ERR_PTR(). The IS_ERR() test in the return value check should be > > replaced with NULL test.

[Bug 207693] amdgpu: RX 5500 XT boost frequency out of spec

2020-05-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207693 --- Comment #2 from Jan Ziak (http://atom-symbol.net) (0xe2.0x9a.0...@gmail.com) --- (In reply to Alex Deucher from comment #1) > The vbios defines the clock frequencies and nominal voltages, not the > driver. The voltage is changed dynamically

Re: [PATCH 1/3] drm/radeon: remove AGP support

2020-05-12 Thread Alex Deucher
On Tue, May 12, 2020 at 4:16 AM Michel Dänzer wrote: > > On 2020-05-11 10:12 p.m., Alex Deucher wrote: > > On Mon, May 11, 2020 at 1:17 PM Christian König > > wrote: > >> > >> AGP is deprecated for 10+ years now and not used any more on modern > >> hardware. > >> > >> Old hardware should

[PATCH][next] drm/amdgpu: remove redundant assignment to variable ret

2020-05-12 Thread Colin King
From: Colin Ian King The variable ret is being initializeed with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King ---

Re: [RFC 16/17] drm/amdgpu: gpu recovery does full modesets

2020-05-12 Thread Alex Deucher
On Tue, May 12, 2020 at 5:00 AM Daniel Vetter wrote: > > ... > > I think it's time to stop this little exercise. > > The lockdep splat, for the record: > > [ 132.583381] == > [ 132.584091] WARNING: possible circular locking dependency detected

Re: [RFC 16/17] drm/amdgpu: gpu recovery does full modesets

2020-05-12 Thread Alex Deucher
On Tue, May 12, 2020 at 8:58 AM Daniel Vetter wrote: > > On Tue, May 12, 2020 at 08:54:45AM -0400, Alex Deucher wrote: > > On Tue, May 12, 2020 at 5:00 AM Daniel Vetter > > wrote: > > > > > > ... > > > > > > I think it's time to stop this little exercise. > > > > > > The lockdep splat, for the

Re: [RFC 16/17] drm/amdgpu: gpu recovery does full modesets

2020-05-12 Thread Daniel Vetter
On Tue, May 12, 2020 at 3:12 PM Alex Deucher wrote: > > On Tue, May 12, 2020 at 8:58 AM Daniel Vetter wrote: > > > > On Tue, May 12, 2020 at 08:54:45AM -0400, Alex Deucher wrote: > > > On Tue, May 12, 2020 at 5:00 AM Daniel Vetter > > > wrote: > > > > > > > > ... > > > > > > > > I think it's

Re: [RFC v2] drm/connector: Add support for privacy-screen properties (v2)

2020-05-12 Thread Pekka Paalanen
On Tue, 12 May 2020 10:02:12 +0200 Hans de Goede wrote: > Hi, > > On 5/12/20 9:49 AM, Pekka Paalanen wrote: > > On Mon, 11 May 2020 19:47:24 +0200 > > Hans de Goede wrote: > > > >> From: Rajat Jain > >> > >> Add support for generic electronic privacy screen properties, that > >> can be

[PATCH v4 00/38] DRM: fix struct sg_table nents vs. orig_nents misuse

2020-05-12 Thread Marek Szyprowski
Dear All, During the Exynos DRM GEM rework and fixing the issues in the. drm_prime_sg_to_page_addr_arrays() function [1] I've noticed that most drivers in DRM framework incorrectly use nents and orig_nents entries of the struct sg_table. In case of the most DMA-mapping implementations exchanging

Re: [PATCH v2] dma-buf: fix use-after-free in dmabuffs_dname

2020-05-12 Thread Greg KH
On Fri, May 08, 2020 at 12:11:03PM +0530, Charan Teja Reddy wrote: > The following race occurs while accessing the dmabuf object exported as > file: > P1P2 > dma_buf_release() dmabuffs_dname() > [say lsof reading /proc//fd/] > >

Re: [RFC 02/17] dma-fence: basic lockdep annotations

2020-05-12 Thread Daniel Vetter
On Tue, May 12, 2020 at 10:04:22AM +0100, Chris Wilson wrote: > Quoting Daniel Vetter (2020-05-12 09:59:29) > > Design is similar to the lockdep annotations for workers, but with > > some twists: > > > > - We use a read-lock for the execution/worker/completion side, so that > > this explicit

Re: [RFC 01/17] dma-fence: add might_sleep annotation to _wait()

2020-05-12 Thread Christian König
Am 12.05.20 um 10:59 schrieb Daniel Vetter: But only for non-zero timeout, to avoid false positives. One question here is whether the might_sleep should be unconditional, or only for real timeouts. I'm not sure, so went with the more defensive option. But in the interest of locking down the

Re: [RFC 02/17] dma-fence: basic lockdep annotations

2020-05-12 Thread Chris Wilson
Quoting Daniel Vetter (2020-05-12 10:08:47) > On Tue, May 12, 2020 at 10:04:22AM +0100, Chris Wilson wrote: > > Quoting Daniel Vetter (2020-05-12 09:59:29) > > > Design is similar to the lockdep annotations for workers, but with > > > some twists: > > > > > > - We use a read-lock for the

Re: [RFC] Remove AGP support from Radeon/Nouveau/TTM

2020-05-12 Thread John Paul Adrian Glaubitz
Hi David! On 5/12/20 7:04 AM, David VANTYGHEM wrote: > Im happy now that after your work, Debian and GRUB install fine on my > iMac G3. But Xserver doesn't start, I've got an AMD Rage 128 Pro AGP 4x > (see joined screenshot). This is an unrelated problem as the reason why you don't have a

Re: [PATCH V4 2/3] drm/vkms: Compute CRC without change input data

2020-05-12 Thread Emil Velikov
Hi Rodrigo, On Mon, 11 May 2020 at 12:55, Rodrigo Siqueira wrote: > > From: Rodrigo Siqueira > > The compute_crc() function is responsible for calculating the > framebuffer CRC value; due to the XRGB format, this function has to > ignore the alpha channel during the CRC computation. Therefore,

Re: [PATCH -next v2] drm/mcde: dsi: Fix return value check in mcde_dsi_bind()

2020-05-12 Thread Linus Walleij
On Thu, Apr 30, 2020 at 9:30 AM Wei Yongjun wrote: > The of_drm_find_bridge() function returns NULL on error, it doesn't return > error pointers so this check doesn't work. > > Fixes: 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE") > Signed-off-by: Wei Yongjun > --- > v1 - > v2:

Re: [PATCH v4 01/38] dma-mapping: add generic helpers for mapping sgtable objects

2020-05-12 Thread Marek Szyprowski
Hi Christoph, On 12.05.2020 15:09, Christoph Hellwig wrote: > On Tue, May 12, 2020 at 03:00:31PM +0200, Marek Szyprowski wrote: >>> if (n <= 0) >>> return -EINVAL; >>> sgt->nents = n; >>> return 0; >>> >> Indeed this version looks much better. I will resend it in a few

[PATCH v4 33/38] staging: tegra-vde: fix common struct sg_table related issues

2020-05-12 Thread Marek Szyprowski
The Documentation/DMA-API-HOWTO.txt states that the dma_map_sg() function returns the number of the created entries in the DMA address space. However the subsequent calls to the dma_sync_sg_for_{device,cpu}() and dma_unmap_sg must be called with the original number of the entries passed to the

[PATCH v4 37/38] media: pci: fix common ALSA DMA-mapping related codes

2020-05-12 Thread Marek Szyprowski
The Documentation/DMA-API-HOWTO.txt states that dma_map_sg returns the numer of the created entries in the DMA address space. However the subsequent calls to dma_sync_sg_for_{device,cpu} and dma_unmap_sg must be called with the original number of entries passed to dma_map_sg. The sg_table->nents

[PATCH v4 19/38] drm: panfrost: fix common struct sg_table related issues

2020-05-12 Thread Marek Szyprowski
The Documentation/DMA-API-HOWTO.txt states that the dma_map_sg() function returns the number of the created entries in the DMA address space. However the subsequent calls to the dma_sync_sg_for_{device,cpu}() and dma_unmap_sg must be called with the original number of the entries passed to the

[PATCH v4 18/38] drm: omapdrm: fix common struct sg_table related issues

2020-05-12 Thread Marek Szyprowski
The Documentation/DMA-API-HOWTO.txt states that the dma_map_sg() function returns the number of the created entries in the DMA address space. However the subsequent calls to the dma_sync_sg_for_{device,cpu}() and dma_unmap_sg must be called with the original number of the entries passed to the

Re: [PATCH v2 12/15] drm/mgag200: Remove out-commented suspend/resume helpers

2020-05-12 Thread Emil Velikov
Hi Thomas, On Tue, 12 May 2020 at 09:43, Thomas Zimmermann wrote: > > The suspend/resume helpers are unused. Also remove associated state > from struct mga_device. > Although DPMS in it's traditional sense is no longer a thing, would it make sense to keep this around for documentation purposes?

[PATCH v4 30/38] dmabuf: fix common struct sg_table related issues

2020-05-12 Thread Marek Szyprowski
The Documentation/DMA-API-HOWTO.txt states that the dma_map_sg() function returns the number of the created entries in the DMA address space. However the subsequent calls to the dma_sync_sg_for_{device,cpu}() and dma_unmap_sg must be called with the original number of the entries passed to the

[PATCH v4 28/38] drm: host1x: fix common struct sg_table related issues

2020-05-12 Thread Marek Szyprowski
The Documentation/DMA-API-HOWTO.txt states that the dma_map_sg() function returns the number of the created entries in the DMA address space. However the subsequent calls to the dma_sync_sg_for_{device,cpu}() and dma_unmap_sg must be called with the original number of the entries passed to the

[PATCH v4 36/38] samples: vfio-mdev/mbochs: fix common struct sg_table related issues

2020-05-12 Thread Marek Szyprowski
The Documentation/DMA-API-HOWTO.txt states that the dma_map_sg() function returns the number of the created entries in the DMA address space. However the subsequent calls to the dma_sync_sg_for_{device,cpu}() and dma_unmap_sg must be called with the original number of the entries passed to the

[PATCH v4 23/38] drm: tegra: fix common struct sg_table related issues

2020-05-12 Thread Marek Szyprowski
The Documentation/DMA-API-HOWTO.txt states that the dma_map_sg() function returns the number of the created entries in the DMA address space. However the subsequent calls to the dma_sync_sg_for_{device,cpu}() and dma_unmap_sg must be called with the original number of the entries passed to the

Re: [RFC 01/17] dma-fence: add might_sleep annotation to _wait()

2020-05-12 Thread Chris Wilson
Quoting Daniel Vetter (2020-05-12 09:59:28) > But only for non-zero timeout, to avoid false positives. > > One question here is whether the might_sleep should be unconditional, > or only for real timeouts. I'm not sure, so went with the more > defensive option. But in the interest of locking down

[PATCH v4 08/38] drm: armada: fix common struct sg_table related issues

2020-05-12 Thread Marek Szyprowski
The Documentation/DMA-API-HOWTO.txt states that the dma_map_sg() function returns the number of the created entries in the DMA address space. However the subsequent calls to the dma_sync_sg_for_{device,cpu}() and dma_unmap_sg must be called with the original number of the entries passed to the

[PATCH v4 14/38] drm: mediatek: use common helper for a scatterlist contiguity check

2020-05-12 Thread Marek Szyprowski
Use common helper for checking the contiguity of the imported dma-buf and do this check before allocating resources, so the error path is simpler. Signed-off-by: Marek Szyprowski --- For more information, see '[PATCH v4 00/38] DRM: fix struct sg_table nents vs. orig_nents misuse' thread:

Re: [PATCH -next] drm/mcde: dsi: Fix return value check in dev_err()

2020-05-12 Thread Linus Walleij
On Tue, Apr 28, 2020 at 4:13 PM Wei Yongjun wrote: > In case of error, the function of_drm_find_bridge() returns NULL pointer > not ERR_PTR(). The IS_ERR() test in the return value check should be > replaced with NULL test. > > Signed-off-by: Wei Yongjun Patch applied! Thanks Wei, sorry for

  1   2   >