Re: [PATCH 12/21] drm/tilcdc: Allow build without __iowmb()

2024-04-10 Thread sarha
April 8, 2024 at 8:04 PM, "Ville Syrjala" mailto:ville.syrj...@linux.intel.com?to=%22Ville%20Syrjala%22%20%3Cville.syrjala%40linux.intel.com%3E > wrote: > > From: Ville Syrjälä > > __iowmb() isn't available on most architectures. Make > its use optional so that the driver can be built on >

Re: [PATCH 13/21] drm/tilcdc: Allow build with COMPILE_TEST=y

2024-04-10 Thread sarha
April 8, 2024 at 8:04 PM, "Ville Syrjala" mailto:ville.syrj...@linux.intel.com?to=%22Ville%20Syrjala%22%20%3Cville.syrjala%40linux.intel.com%3E > wrote: > > From: Ville Syrjälä > > Allow tilcdc to be built with COMPILE_TEST=y for greater > coverage. Builds fine on x86/x86_64 at least. > >

Re: [PATCH] dma-buf: add DMA_BUF_IOCTL_SYNC_PARTIAL support

2024-04-10 Thread Rong Qianfeng
在 2024/4/9 23:34, Christian König 写道: Am 09.04.24 um 09:32 schrieb Rong Qianfeng: 在 2024/4/8 15:58, Christian König 写道: Am 07.04.24 um 09:50 schrieb Rong Qianfeng: [SNIP] Am 13.11.21 um 07:22 schrieb Jianqun Xu: Add DMA_BUF_IOCTL_SYNC_PARTIAL support for user to sync dma-buf with offset

[PATCH v1 1/4] dt-bindings: display: panel: Add compatible for BOE nv110wum-l60

2024-04-10 Thread Cong Yang
The BOE nv110wum-l60 is a 11.0" WUXGA TFT LCD panel, which fits in nicely with the existing panel-boe-tv101wum-nl6 driver. Hence, we add a new compatible with panel specific config. Signed-off-by: Cong Yang --- .../devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml | 2 ++ 1 file

[PATCH v1 2/4] drm/panel: boe-tv101wum-nl6: Support for BOE nv110wum-l60 MIPI-DSI panel

2024-04-10 Thread Cong Yang
The BOE nv110wum-l60 is a 11.0" WUXGA TFT LCD panel, which fits in nicely with the existing panel-boe-tv101wum-nl6 driver. Hence, we add a new compatible with panel specific config. Signed-off-by: Cong Yang --- .../gpu/drm/panel/panel-boe-tv101wum-nl6.c| 115 ++ 1 file

[PATCH v1 4/4] drm/panel: boe-tv101wum-nl6: Support for IVO t109nw41 MIPI-DSI panel

2024-04-10 Thread Cong Yang
The IVO t109nw41 is a 11.0" WUXGA TFT LCD panel, which fits in nicely with the existing panel-boe-tv101wum-nl6 driver. Hence, we add a new compatible with panel specific config. Signed-off-by: Cong Yang --- .../gpu/drm/panel/panel-boe-tv101wum-nl6.c| 98 +++ 1 file changed,

[PATCH v1 3/4] dt-bindings: display: panel: Add compatible for IVO t109nw41

2024-04-10 Thread Cong Yang
The IVO t109nw41 is a 11.0" WUXGA TFT LCD panel, which fits in nicely with the existing panel-boe-tv101wum-nl6 driver. Hence, we add a new compatible with panel specific config. Signed-off-by: Cong Yang --- .../devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml | 2 ++ 1 file changed,

[PATCH v1 0/2] Support BOE nv110wum-l60 and IVO t109nw41 MIPI-DSI panel

2024-04-10 Thread Cong Yang
BOE nv110wum-l60 and IVO t109nw41 both 11.0" WUXGA TFT LCD panel, which fits in nicely with the existing panel-boe-tv101wum-nl6 driver. Add compatible for BOE nv110wum-l60 and IVO t109nw41 in dt-bindings. Cong Yang (4): dt-bindings: display: panel: Add compatible for BOE nv110wum-l60

[PATCH] drm/amd/display: Fix division by zero in setup_dsc_config

2024-04-10 Thread Jose Fernandez
When slice_height is 0, the division by slice_height in the calculation of the number of slices will cause a division by zero driver crash. This leaves the kernel in a state that requires a reboot. This patch adds a check to avoid the division by zero. The stack trace below is for the 6.8.4

Re: [PATCH v2 00/25] virtio: store owner from modules with register_virtio_driver()

2024-04-10 Thread Michael S. Tsirkin
On Wed, Apr 10, 2024 at 09:41:57AM +0200, Krzysztof Kozlowski wrote: > On 31/03/2024 10:43, Krzysztof Kozlowski wrote: > > Changes in v2: > > - Three new patches: virtio mem+input+balloon > > - Minor commit msg adjustments > > - Add tags > > - Link to v1: > >

Re: (subset) [PATCH 00/34] address all -Wunused-const warnings

2024-04-10 Thread Sebastian Reichel
On Wed, 03 Apr 2024 10:06:18 +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > Compilers traditionally warn for unused 'static' variables, but not > if they are constant. The reason here is a custom for C++ programmers > to define named constants as 'static const' variables in header files

[PATCH v2] drm: Document requirements for driver-specific KMS props in new drivers

2024-04-10 Thread Sebastian Wick
When extending support for a driver-specific KMS property to additional drivers, we should apply all the requirements for new properties and make sure the semantics are the same and documented. v2: devs of the driver which introduced property shall help and ack Signed-off-by: Sebastian Wick

Re: [PATCH 3/3] drm/ast: Define struct ast_ddc in ast_ddc.c

2024-04-10 Thread Jocelyn Falempe
Hi, Thanks for the patch, it looks good to me. Reviewed-by: Jocelyn Falempe -- Jocelyn On 03/04/2024 12:31, Thomas Zimmermann wrote: Move the definition of struct ast_ddc to ast_ddc.c and return the i2c adapter from ast_ddc_create(). Update callers accordingly. Avoids including Linux i2c

Re: [PATCH v2 00/25] virtio: store owner from modules with register_virtio_driver()

2024-04-10 Thread Krzysztof Kozlowski
On 31/03/2024 10:43, Krzysztof Kozlowski wrote: > Changes in v2: > - Three new patches: virtio mem+input+balloon > - Minor commit msg adjustments > - Add tags > - Link to v1: > https://lore.kernel.org/r/20240327-module-owner-virtio-v1-0-0feffab77...@linaro.org > > Merging > === > All further

Re: [PATCH v12 0/9] drm/panic: Add a drm panic handler

2024-04-10 Thread Daniel Vetter
On Tue, Apr 09, 2024 at 06:30:39PM +0200, Jocelyn Falempe wrote: > drm/panic: Add a drm panic handler > > This introduces a new drm panic handler, which displays a message when a > panic occurs. > So when fbcon is disabled, you can still see a kernel panic. > > This is one of the missing

Re: [PATCH 1/1] fbdev: add HAS_IOPORT dependencies

2024-04-10 Thread Niklas Schnelle
On Wed, 2024-04-10 at 10:27 +0200, Niklas Schnelle wrote: > In a future patch HAS_IOPORT=n will disable inb()/outb() and friends at > compile time. We thus need to add HAS_IOPORT as dependency for those > drivers using them. > > Co-developed-by: Arnd Bergmann > Signed-off-by: Arnd Bergmann >

Re: [PATCH RESEND] drm: use capital "OR" for multiple licenses in SPDX

2024-04-10 Thread Neil Armstrong
On 10/04/2024 10:22, Krzysztof Kozlowski wrote: Documentation/process/license-rules.rst expects the SPDX identifier syntax for multiple licenses to use capital "OR". Correct it to keep consistent format and avoid copy-paste issues. Signed-off-by: Krzysztof Kozlowski --- Resend... Cc:

Re: [PATCH 13/21] drm/tilcdc: Allow build with COMPILE_TEST=y

2024-04-10 Thread Tomi Valkeinen
On 08/04/2024 20:04, Ville Syrjala wrote: From: Ville Syrjälä Allow tilcdc to be built with COMPILE_TEST=y for greater coverage. Builds fine on x86/x86_64 at least. Cc: Jyri Sarha Cc: Tomi Valkeinen Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/tilcdc/Kconfig | 2 +- 1 file changed,

Re: [PATCH v1 3/4] dt-bindings: display: panel: Add compatible for IVO t109nw41

2024-04-10 Thread Krzysztof Kozlowski
On 10/04/2024 09:14, Cong Yang wrote: > The IVO t109nw41 is a 11.0" WUXGA TFT LCD panel, which fits in nicely with > the existing panel-boe-tv101wum-nl6 driver. Hence, we add a new compatible > with panel specific config. > > Signed-off-by: Cong Yang > --- >

Re: [PATCH net-next v8 2/3] net: ethernet: ti: Add desc_infos member to struct k3_cppi_desc_pool

2024-04-10 Thread Julien Panis
On 4/10/24 02:39, Jakub Kicinski wrote: On Mon, 08 Apr 2024 11:38:03 +0200 Julien Panis wrote: goto gen_pool_create_fail; } + pool->desc_infos = kcalloc(pool->num_desc, + sizeof(*pool->desc_infos), GFP_KERNEL); + if

Re: [PATCH 14/21] drm/omap: Open code phys_to_page()

2024-04-10 Thread Tomi Valkeinen
On 08/04/2024 20:04, Ville Syrjala wrote: From: Ville Syrjälä phys_to_page() is not available on most architectures. Just open code it like msm does. Allows COMPILE_TEST=y builds of omapdrm on other architectures. Cc: Tomi Valkeinen Signed-off-by: Ville Syrjälä ---

Re: [PATCH 15/21] drm/omap: Allow build with COMPILE_TEST=y

2024-04-10 Thread Tomi Valkeinen
On 08/04/2024 20:04, Ville Syrjala wrote: From: Ville Syrjälä Allow omapdrm to be built with COMPILE_TEST=y for greater coverage. FIXME: Still borked due to ? Cc: Tomi Valkeinen Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/omapdrm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v2 1/1] fbdev: add HAS_IOPORT dependencies

2024-04-10 Thread Niklas Schnelle
In a future patch HAS_IOPORT=n will disable inb()/outb() and friends at compile time. We thus need to add HAS_IOPORT as dependency for those drivers using them. Co-developed-by: Arnd Bergmann Signed-off-by: Arnd Bergmann Signed-off-by: Niklas Schnelle --- Note: This patch does not depend any

[PATCH v2 0/1] fbdev: Handle HAS_IOPORT dependencies

2024-04-10 Thread Niklas Schnelle
Hi Helge, This is a follow up in my ongoing effort of making inb()/outb() and similar I/O port accessors compile-time optional. Previously I sent this as a treewide series titled "treewide: Remove I/O port accessors for HAS_IOPORT=n" with the latest being its 5th version[0]. With a significant

Re: [PATCH] drm/msm/dpu: Add callback function pointer check before its call

2024-04-10 Thread Aleksandr Mishin
On 08.04.2024 12:03, Dmitry Baryshkov wrote: On Mon, 8 Apr 2024 at 11:57, Aleksandr Mishin wrote: In dpu_core_irq_callback_handler() callback function pointer is compared to NULL, but then callback function is unconditionally called by this pointer. Fix this bug by adding conditional

Re: [PATCH 21/21] drm/stm: Allow build with COMPILE_TEST=y

2024-04-10 Thread Raphael Gallais-Pou
Hi Ville On 4/8/24 19:04, Ville Syrjala wrote: > From: Ville Syrjälä > > Allow stm to be built with COMPILE_TEST=y for greater > coverage. Builds fine on x86/x86_64 at least. > > Cc: Yannick Fertre > Cc: Raphael Gallais-Pou > Cc: Philippe Cornu > Signed-off-by: Ville Syrjälä Thank you for

Re: [PATCH 1/3] drm/ast: Set DDC timeout in milliseconds

2024-04-10 Thread Jocelyn Falempe
Hi, Thanks for the patch, it looks good to me. Reviewed-by: Jocelyn Falempe -- Jocelyn On 03/04/2024 12:31, Thomas Zimmermann wrote: Compute the i2c timeout in jiffies from a value in milliseconds. The original values of 2 jiffies equals 2 milliseconds if HZ has been configured to a value

Re: [PATCH v1 1/4] dt-bindings: display: panel: Add compatible for BOE nv110wum-l60

2024-04-10 Thread Krzysztof Kozlowski
On 10/04/2024 09:14, Cong Yang wrote: > The BOE nv110wum-l60 is a 11.0" WUXGA TFT LCD panel, which fits in nicely > with the existing panel-boe-tv101wum-nl6 driver. Hence, we add a new > compatible with panel specific config. > > Signed-off-by: Cong Yang > --- >

[PATCH v2] drm: move i915_drm.h under include/drm/intel

2024-04-10 Thread Jani Nikula
Clean up the top level include/drm directory by grouping all the Intel specific files under a common subdirectory. v2: Also fix comment in intel_pci_config.h (Ilpo) Cc: Daniel Vetter Cc: Dave Airlie Cc: Lucas De Marchi Cc: Bjorn Helgaas Cc: Hans de Goede Cc: Ilpo Järvinen Signed-off-by:

Re: [PATCH v2] drm: ensure drm headers are self-contained and pass kernel-doc

2024-04-10 Thread Jani Nikula
On Tue, 02 Apr 2024, Jani Nikula wrote: > Ensure drm headers build, are self-contained, have header guards, and > have no kernel-doc warnings, when CONFIG_DRM_HEADER_TEST=y. > > The mechanism follows similar patters used in i915, xe, and usr/include. > > To cover include/drm, we need to recurse

Re: [RESEND v7 09/37] dt-binding: Add compatible SH7750 SoC

2024-04-10 Thread Rob Herring
On Thu, 04 Apr 2024 14:14:20 +0900, Yoshinori Sato wrote: > Signed-off-by: Yoshinori Sato > --- > Documentation/devicetree/bindings/timer/renesas,tmu.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Acked-by: Rob Herring

Re: [PATCH 2/3] drm/ast: Group DDC init code by data structure

2024-04-10 Thread Jocelyn Falempe
Hi, Thanks for the patch, it looks good to me. Reviewed-by: Jocelyn Falempe -- Jocelyn On 03/04/2024 12:31, Thomas Zimmermann wrote: Reorder the code to set up the DDC channel by data structure, so that each data structure's init is in a separate block: first the bit algo then the i2c

Re: [PATCH] drm: remove unused header gma_drm.h

2024-04-10 Thread Javier Martinez Canillas
Jani Nikula writes: > gma_drm.h has become an empty, unused header. Remove. > > Cc: Patrik Jakobsson > Signed-off-by: Jani Nikula > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: (subset) [PATCH v12 0/7] drm/meson: add support for MIPI DSI Display

2024-04-10 Thread Jerome Brunet
Applied to clk-meson (v6.10/drivers), thanks! [2/7] clk: meson: add vclk driver https://github.com/BayLibre/clk-meson/commit/bb5aa08572b5 [3/7] clk: meson: g12a: make VCLK2 and ENCL clock path configurable by CCF https://github.com/BayLibre/clk-meson/commit/b70cb1a21a54 Best regards,

Re: [PATCH v1 1/4] dt-bindings: display: panel: Add compatible for BOE nv110wum-l60

2024-04-10 Thread cong yang
Hi, Krzysztof Kozlowski 于2024年4月10日周三 16:24写道: > > On 10/04/2024 09:14, Cong Yang wrote: > > The BOE nv110wum-l60 is a 11.0" WUXGA TFT LCD panel, which fits in nicely > > with the existing panel-boe-tv101wum-nl6 driver. Hence, we add a new > > compatible with panel specific config. > > > >

[PATCH 02/10] drm: move intel-gtt.h under include/drm/intel

2024-04-10 Thread Jani Nikula
Clean up the top level include/drm directory by grouping all the Intel specific files under a common subdirectory. Cc: Daniel Vetter Cc: Dave Airlie Cc: Lucas De Marchi Signed-off-by: Jani Nikula --- drivers/char/agp/intel-agp.c | 2 +- drivers/char/agp/intel-gtt.c

[PATCH 01/10] drm/i915: use system include for drm headers

2024-04-10 Thread Jani Nikula
Use <> instead of "" for including headers from include/, even if the file is in the same directory. Signed-off-by: Jani Nikula --- include/drm/i915_component.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/i915_component.h b/include/drm/i915_component.h index

[PATCH 00/10] drm: move Intel drm headers to a subdirectory

2024-04-10 Thread Jani Nikula
We've accumulated enough Intel specific header files under include/drm that they warrant a subdirectory of their own. Clean up the top drm header directory by moving the Intel files under include/drm/intel. Since i915 is most impacted, I suggest merging the lot via drm-intel-next. Please ack if

Re: [PATCH 06/10] drm: move i915_drm.h under include/drm/intel

2024-04-10 Thread Ilpo Järvinen
On Wed, 10 Apr 2024, Jani Nikula wrote: > Clean up the top level include/drm directory by grouping all the Intel > specific files under a common subdirectory. > > Cc: Daniel Vetter > Cc: Dave Airlie > Cc: Lucas De Marchi > Cc: Bjorn Helgaas > Cc: Hans de Goede > Cc: Ilpo Järvinen >

Re: [PATCH] drm/msm/dpu: Add callback function pointer check before its call

2024-04-10 Thread Aleksandr Mishin
On 08.04.2024 19:51, Abhinav Kumar wrote: On 4/8/2024 1:55 AM, Aleksandr Mishin wrote: In dpu_core_irq_callback_handler() callback function pointer is compared to NULL, but then callback function is unconditionally called by this pointer. Fix this bug by adding conditional return. Found

[PATCH v2 2/5] drm/udl: Move drm_dev_{enter, exit}() into udl_get_edid_block()

2024-04-10 Thread Thomas Zimmermann
Protect the code in udl_get_edid_block() with drm_dev_enter() and drm_dev_exit(), so that all callers automatically invoke it. The function uses hardware resources, which can be hot-unplugged at any time. The other code in udl_connector_detect() does not use the resources of the hardware device

[PATCH v2 0/5] drm/udl: Convert to struct drm_edid

2024-04-10 Thread Thomas Zimmermann
Convert udl to use struct drm_edid and its helpers. Also clean up a few things in the process. Patch 1 fixes a bug. Patches 2 to 4 convert the current EDID handling to struct drm_edid and its helpers. Patch 4 also separates the helpers for .get_modes() and .detect_ctx() from each other. Patch 5

[PATCH v2 3/5] drm/udl: Clean up Makefile

2024-04-10 Thread Thomas Zimmermann
Clean up Makefile before listing new object files. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/udl/Makefile | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/udl/Makefile b/drivers/gpu/drm/udl/Makefile index

[PATCH v2 4/5] drm/udl: Untangle .get_modes() and .detect_ctx()

2024-04-10 Thread Thomas Zimmermann
Provide separate implementations of .get_modes() and .detect_ctx() from struct drm_connector. Switch to struct drm_edid. Udl's .detect() helper used to fetch the EDID from the adapter and the .get_modes() helper provided display modes from the data. But this relied on the DRM helpers to call the

[PATCH v2 5/5] drm/udl: Remove struct udl_connector

2024-04-10 Thread Thomas Zimmermann
Udl's struct udl_connector is an empty wrapper around struct drm_connector. Remove it. Allocate the connector as part of struct udl_device and inline the init function into its only caller. v2: - fix return value in udl_modeset_init() (Dan) Signed-off-by: Thomas Zimmermann ---

[PATCH v2 1/5] drm/udl: Remove DRM_CONNECTOR_POLL_HPD

2024-04-10 Thread Thomas Zimmermann
DisplayLink devices do not generate hotplug events. Remove the poll flag DRM_CONNECTOR_POLL_HPD, as it may not be specified together with DRM_CONNECTOR_POLL_CONNECT or DRM_CONNECTOR_POLL_DISCONNECT. Signed-off-by: Thomas Zimmermann Fixes: afdfc4c6f55f ("drm/udl: Fixed problem with UDL adpater

Re: [PATCH 01/11] drm/mediatek: aal: drop driver owner initialization

2024-04-10 Thread Krzysztof Kozlowski
On 01/04/2024 05:44, CK Hu (胡俊光) wrote: > Hi, Krzysztof: > > On Sat, 2024-03-30 at 21:43 +0100, Krzysztof Kozlowski wrote: >> >> External email : Please do not click links or open attachments until >> you have verified the sender or the content. >> Core in platform_driver_register()

Re: [PATCH v12 1/9] drm/panic: Add drm panic locking

2024-04-10 Thread Daniel Vetter
On Tue, Apr 09, 2024 at 06:30:40PM +0200, Jocelyn Falempe wrote: > From: Daniel Vetter > > Rough sketch for the locking of drm panic printing code. The upshot of > this approach is that we can pretty much entirely rely on the atomic > commit flow, with the pair of raw_spin_lock/unlock providing

Re: [PATCH v3 01/18] ASoC: dt-bindings: mediatek,mt8365-afe: Add audio afe document

2024-04-10 Thread Alexandre Mergnat
On 09/04/2024 17:46, Krzysztof Kozlowski wrote: +soc { +#address-cells = <2>; +#size-cells = <2>; + +afe@1122 { Did you implement the comment or decided to keep afe? Though it was clear according to [1]: " Audio Front End, this is the same name used for

[PATCH 04/10] drm: move i915_component.h under include/drm/intel

2024-04-10 Thread Jani Nikula
Clean up the top level include/drm directory by grouping all the Intel specific files under a common subdirectory. Cc: Daniel Vetter Cc: Dave Airlie Cc: Lucas De Marchi Cc: Tomas Winkler Cc: Jaroslav Kysela Cc: Takashi Iwai Signed-off-by: Jani Nikula ---

[PATCH 06/10] drm: move i915_drm.h under include/drm/intel

2024-04-10 Thread Jani Nikula
Clean up the top level include/drm directory by grouping all the Intel specific files under a common subdirectory. Cc: Daniel Vetter Cc: Dave Airlie Cc: Lucas De Marchi Cc: Bjorn Helgaas Cc: Hans de Goede Cc: Ilpo Järvinen Signed-off-by: Jani Nikula --- arch/x86/kernel/early-quirks.c

[PATCH 05/10] drm: move intel_lpe_audio.h under include/drm/intel

2024-04-10 Thread Jani Nikula
Clean up the top level include/drm directory by grouping all the Intel specific files under a common subdirectory. Cc: Daniel Vetter Cc: Dave Airlie Cc: Lucas De Marchi Cc: Jaroslav Kysela Cc: Takashi Iwai Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_hdmi.c | 2 +-

[PATCH 08/10] drm: move i915_pciids.h under include/drm/intel

2024-04-10 Thread Jani Nikula
Clean up the top level include/drm directory by grouping all the Intel specific files under a common subdirectory. Cc: Daniel Vetter Cc: Dave Airlie Cc: Lucas De Marchi Cc: Bjorn Helgaas Signed-off-by: Jani Nikula --- arch/x86/kernel/early-quirks.c | 2 +-

[PATCH 07/10] drm: move i915_pxp_tee_interface.h under include/drm/intel

2024-04-10 Thread Jani Nikula
Clean up the top level include/drm directory by grouping all the Intel specific files under a common subdirectory. Cc: Daniel Vetter Cc: Dave Airlie Cc: Lucas De Marchi Cc: Tomas Winkler Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 2 +-

[PATCH 03/10] drm: move i915_gsc_proxy_mei_interface.h under include/drm/intel

2024-04-10 Thread Jani Nikula
Clean up the top level include/drm directory by grouping all the Intel specific files under a common subdirectory. Cc: Daniel Vetter Cc: Dave Airlie Cc: Lucas De Marchi Cc: Tomas Winkler Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gt/uc/intel_gsc_proxy.c | 2 +-

Re: [PATCH] drm/omap: dmm_tiler: drop driver owner assignment

2024-04-10 Thread Tomi Valkeinen
On 30/03/2024 22:28, Krzysztof Kozlowski wrote: Core in platform_driver_register() already sets the .owner, so driver does not need to. Whatever is set here will be anyway overwritten by main driver calling platform_driver_register(). Signed-off-by: Krzysztof Kozlowski ---

Re: [PATCH] drm/bridge: ti-sn65dsi86: Fix ti_sn_bridge_set_dsi_rate function

2024-04-10 Thread Jayesh Choudhary
Hello Doug, Thanks for the review. On 08/04/24 14:33, Doug Anderson wrote: Hi, On Mon, Apr 8, 2024 at 12:36 AM Jayesh Choudhary wrote: Due to integer calculations, the rounding off can cause errors in the final value propagated in the registers. Considering the example of 1080p (very

Re: [PATCH 4/6] drm/msm/adreno: Implement SMEM-based speed bin

2024-04-10 Thread Konrad Dybcio
On 4/6/24 05:23, Dmitry Baryshkov wrote: On Fri, Apr 05, 2024 at 10:41:32AM +0200, Konrad Dybcio wrote: On recent (SM8550+) Snapdragon platforms, the GPU speed bin data is abstracted through SMEM, instead of being directly available in a fuse. Add support for SMEM-based speed binning, which

Re: [PATCH v11 2/9] drm/panic: Add a drm panic handler

2024-04-10 Thread Thomas Zimmermann
Hi Am 09.04.24 um 16:11 schrieb Jocelyn Falempe: Hi, On 09/04/2024 10:30, Thomas Zimmermann wrote: Hi Am 28.03.24 um 13:03 schrieb Jocelyn Falempe: +/** + * struct drm_scanout_buffer - DRM scanout buffer + * + * This structure holds the information necessary for drm_panic to draw the + *

Re: [PATCH 01/11] drm/mediatek: aal: drop driver owner initialization

2024-04-10 Thread 胡俊光

Re: [PATCH 4/4] gpu: ipu-v3: Convert to platform remove callback returning void

2024-04-10 Thread Philipp Zabel
On Di, 2024-04-09 at 19:02 +0200, Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a

Re: (subset) [PATCH v12 0/7] drm/meson: add support for MIPI DSI Display

2024-04-10 Thread Neil Armstrong
Hi, On Wed, 03 Apr 2024 09:46:31 +0200, Neil Armstrong wrote: > The Amlogic G12A, G12B & SM1 SoCs embeds a Synopsys DW-MIPI-DSI transceiver > (ver 1.21a), > with a custom glue managing the IP resets, clock and data input similar to > the DW-HDMI > glue on the same Amlogic SoCs. > > This is a

Re: [PATCH v11 0/7] drm/meson: add support for MIPI DSI Display

2024-04-10 Thread Neil Armstrong
Hi, On Mon, 25 Mar 2024 12:09:46 +0100, Neil Armstrong wrote: > The Amlogic G12A, G12B & SM1 SoCs embeds a Synopsys DW-MIPI-DSI transceiver > (ver 1.21a), > with a custom glue managing the IP resets, clock and data input similar to > the DW-HDMI > glue on the same Amlogic SoCs. > > This is a

Re: [PATCH 12/21] drm/tilcdc: Allow build without __iowmb()

2024-04-10 Thread Tomi Valkeinen
On 08/04/2024 20:04, Ville Syrjala wrote: From: Ville Syrjälä __iowmb() isn't available on most architectures. Make its use optional so that the driver can be built on other architectures with COMPILE_TEST=y. Cc: Jyri Sarha Cc: Tomi Valkeinen Signed-off-by: Ville Syrjälä ---

Re: [PATCH 06/10] drm: move i915_drm.h under include/drm/intel

2024-04-10 Thread Jani Nikula
On Wed, 10 Apr 2024, Ilpo Järvinen wrote: > Could you please also address the comment in > drivers/gpu/drm/i915/intel_pci_config.h. Ack. -- Jani Nikula, Intel

Re: [PATCH] drm: tilcdc: don't use devm_pinctrl_get_select_default() in probe

2024-04-10 Thread Tomi Valkeinen
On 22/09/2023 10:37, Wolfram Sang wrote: Since commit ab78029ecc34 ("drivers/pinctrl: grab default handles from device core"), we can rely on device core for setting the default pins. Signed-off-by: Wolfram Sang --- drivers/gpu/drm/tilcdc/tilcdc_panel.c | 6 -- 1 file changed, 6

Re: [PATCH 3/6] drm/msm/adreno: Allow specifying default speedbin value

2024-04-10 Thread Konrad Dybcio
On 4/9/24 20:31, Dmitry Baryshkov wrote: On Tue, 9 Apr 2024 at 21:27, Konrad Dybcio wrote: On 4/9/24 20:15, Dmitry Baryshkov wrote: On Tue, Apr 09, 2024 at 08:07:56PM +0200, Konrad Dybcio wrote: On 4/9/24 20:04, Dmitry Baryshkov wrote: On Tue, Apr 09, 2024 at 10:12:00AM -0700, Rob

Re: [RESEND v7 12/37] dt-bindings: pci: pci-sh7751: Add SH7751 PCI

2024-04-10 Thread Rob Herring
On Thu, Apr 04, 2024 at 02:14:23PM +0900, Yoshinori Sato wrote: > Renesas SH7751 PCI Controller json-schema. > > Signed-off-by: Yoshinori Sato > --- > .../bindings/pci/renesas,sh7751-pci.yaml | 89 +++ > 1 file changed, 89 insertions(+) > create mode 100644 >

Re: [PATCH v12 4/9] drm/panic: Add debugfs entry to test without triggering panic.

2024-04-10 Thread Daniel Vetter
On Tue, Apr 09, 2024 at 06:30:43PM +0200, Jocelyn Falempe wrote: > Add a debugfs file, so you can test drm_panic without freezing > your machine. This is unsafe, and should be enabled only for > developer or tester. > > To display the drm_panic screen on the device 0: > echo 1 >

Re: [PATCH v12 2/9] drm/panic: Add a drm panic handler

2024-04-10 Thread Daniel Vetter
On Tue, Apr 09, 2024 at 06:30:41PM +0200, Jocelyn Falempe wrote: > This module displays a user friendly message when a kernel panic > occurs. It currently doesn't contain any debug information, > but that can be added later. > > v2 > * Use get_scanout_buffer() instead of the drm client API. >

[PATCH RESEND] drm: use capital "OR" for multiple licenses in SPDX

2024-04-10 Thread Krzysztof Kozlowski
Documentation/process/license-rules.rst expects the SPDX identifier syntax for multiple licenses to use capital "OR". Correct it to keep consistent format and avoid copy-paste issues. Signed-off-by: Krzysztof Kozlowski --- Resend... Cc: Dmitry Baryshkov Cc: Neil Armstrong ---

[PATCH RESEND] drm/armada: drop unneeded MODULE_ALIAS

2024-04-10 Thread Krzysztof Kozlowski
The MODULE_DEVICE_TABLE already creates proper alias for platform driver. Having another MODULE_ALIAS causes the alias to be duplicated. Signed-off-by: Krzysztof Kozlowski --- Resent third time https://lore.kernel.org/all/20220407202443.23000-1-krzysztof.kozlow...@linaro.org/ Cc: Dmitry

[PATCH 0/1] fbdev: Handle HAS_IOPORT dependencies

2024-04-10 Thread Niklas Schnelle
Hi Helge, This is a follow up in my ongoing effort of making inb()/outb() and similar I/O port accessors compile-time optional. Previously I sent this as a treewide series titled "treewide: Remove I/O port accessors for HAS_IOPORT=n" with the latest being its 5th version[0]. With a significant

[PATCH 1/1] fbdev: add HAS_IOPORT dependencies

2024-04-10 Thread Niklas Schnelle
In a future patch HAS_IOPORT=n will disable inb()/outb() and friends at compile time. We thus need to add HAS_IOPORT as dependency for those drivers using them. Co-developed-by: Arnd Bergmann Signed-off-by: Arnd Bergmann Signed-off-by: Niklas Schnelle --- Note: This patch does not depend any

Re: [PATCH] drm: remove unused header gma_drm.h

2024-04-10 Thread Jani Nikula
On Wed, 10 Apr 2024, Javier Martinez Canillas wrote: > Jani Nikula writes: > >> gma_drm.h has become an empty, unused header. Remove. >> >> Cc: Patrik Jakobsson >> Signed-off-by: Jani Nikula >> --- > > Reviewed-by: Javier Martinez Canillas Thanks, pushed to drm-misc-next. BR, Jani. --

[PATCH 10/10] drm: move i915_hdcp_interface.h under include/drm/intel

2024-04-10 Thread Jani Nikula
Clean up the top level include/drm directory by grouping all the Intel specific files under a common subdirectory. Cc: Daniel Vetter Cc: Dave Airlie Cc: Lucas De Marchi Cc: Tomas Winkler Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display_types.h| 2 +-

[PATCH 09/10] drm: move xe_pciids.h under include/drm/intel

2024-04-10 Thread Jani Nikula
Clean up the top level include/drm directory by grouping all the Intel specific files under a common subdirectory. Cc: Daniel Vetter Cc: Dave Airlie Cc: Lucas De Marchi Signed-off-by: Jani Nikula --- drivers/gpu/drm/xe/xe_pci.c | 2 +- include/drm/{ => intel}/xe_pciids.h | 0 2 files

Re: [PATCH] drm: xlnx: db: fix a memory leak in probe

2024-04-10 Thread Tomi Valkeinen
On 04/04/2024 10:32, Dan Carpenter wrote: Free "dp" before returning. Fixes: be318d01a903 ("drm: xlnx: dp: Reset DisplayPort IP") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v2 15/43] drm/tiny/gm12u320: Use fbdev-shmem

2024-04-10 Thread Hans de Goede
Hi, On 4/10/24 3:02 PM, Thomas Zimmermann wrote: > Implement fbdev emulation with fbdev-shmem. Avoids the overhead of > fbdev-generic's additional shadow buffering. No functional changes. > > Signed-off-by: Thomas Zimmermann > Cc: Hans de Goede Thanks, patch looks good to me: Reviewed-by:

Re: [PATCH] dma-buf: add DMA_BUF_IOCTL_SYNC_PARTIAL support

2024-04-10 Thread T.J. Mercier
On Wed, Apr 10, 2024 at 7:22 AM Christian König wrote: > > Am 09.04.24 um 18:37 schrieb T.J. Mercier: > > On Tue, Apr 9, 2024 at 12:34 AM Rong Qianfeng <11065...@vivo.com> wrote: > >> > >> 在 2024/4/8 15:58, Christian König 写道: > >>> Am 07.04.24 um 09:50 schrieb Rong Qianfeng: > [SNIP] >

Re: [PATCH v12 4/7] drm/meson: gate px_clk when setting rate

2024-04-10 Thread Nicolas Belin
Le mer. 3 avr. 2024 à 09:46, Neil Armstrong a écrit : > > Disable the px_clk when setting the rate to recover a fully > configured and correctly reset VCLK clock tree after the rate > is set. > > Fixes: 77d9e1e6b846 ("drm/meson: add support for MIPI-DSI transceiver") > Signed-off-by: Neil

[PATCH v2 08/43] drm/fbdev: Add fbdev-shmem

2024-04-10 Thread Thomas Zimmermann
Add an fbdev emulation for SHMEM-based memory managers. The code is similar to fbdev-generic, but does not require an addition shadow buffer for mmap(). Fbdev-shmem operates directly on the buffer object's SHMEM pages. Fbdev's deferred-I/O mechanism updates the hardware state on write operations.

[PATCH v2 04/43] fbdev/deferred-io: Test screen_buffer for vmalloc'ed memory

2024-04-10 Thread Thomas Zimmermann
Framebuffers in virtual memory are available via screen_buffer. Use it instead of screen_base and avoid the type casting. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/video/fbdev/core/fb_defio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[PATCH v2 03/43] fbdev/deferred-io: Clean up pageref on lastclose

2024-04-10 Thread Thomas Zimmermann
Clean up the pageref state as part of the lastclose helper. This only requires to clear the page's mapping field. The pageref and page can stay in place for the next opened instance of the frame- buffer file. With the change in the clean-up logic, there's no further need to look up pages during

[PATCH v2 01/43] drm/fbdev-generic: Do not set physical framebuffer address

2024-04-10 Thread Thomas Zimmermann
Framebuffer memory is allocated via vzalloc() from non-contiguous physical pages. The physical framebuffer start address is therefore meaningless. Do not set it. The value is not used within the kernel and only exported to userspace on dedicated ARM configs. No functional change is expected. v2:

[PATCH v2 07/43] fbdev/deferred-io: Provide get_page hook in struct fb_deferred_io

2024-04-10 Thread Thomas Zimmermann
Add a callback for drivers to provide framebuffer pages to fbdev's deferred-I/O helpers. Implementations need to acquire a reference on the page before returning it. Returning NULL generates a SIGBUS signal. This will be useful for DRM's fbdev emulation with GEM-shmem buffer objects. v2: - fix

[PATCH v2 35/43] drm/tiny/ili9341: Use fbdev-dma

2024-04-10 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by ili9341. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Kamlesh Gurudasani --- drivers/gpu/drm/tiny/ili9341.c

[PATCH v2 43/43] drm/fbdev: Clean up fbdev documentation

2024-04-10 Thread Thomas Zimmermann
Rewrite some docs that are not up-to-date any longer. Remove the TODO item for fbdev-generic conversion, as the helper has been replaced. Make documentation for DMA, SHMEM and TTM emulation available. Signed-off-by: Thomas Zimmermann Cc: Jonathan Corbet ---

[PATCH v2 10/43] drm/gud: Use fbdev-shmem

2024-04-10 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-shmem. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: "Noralf Trønnes" Acked-by: Noralf Trønnes --- drivers/gpu/drm/gud/gud_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v2 34/43] drm/tiny/ili9225: Use fbdev-dma

2024-04-10 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by ili9225. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: David Lechner Acked-by: David Lechner ---

[PATCH v2 21/43] drm/fbdev-dma: Implement damage handling and deferred I/O

2024-04-10 Thread Thomas Zimmermann
Add support for damage handling and deferred I/O to fbdev-dma. This enables fbdev-dma to support all DMA-memory-based DRM drivers, even such with a dirty callback in their framebuffers. The patch adds the code for deferred I/O and also sets a dedicated helper for struct fb_ops.fb_mmap that

[PATCH v2 12/43] drm/mgag200: Use fbdev-shmem

2024-04-10 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-shmem. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Dave Airlie Cc: Thomas Zimmermann Cc: Jocelyn Falempe Reviewed-by: Jocelyn Falempe ---

[PATCH v2 13/43] drm/solomon: Use fbdev-shmem

2024-04-10 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-shmem. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Javier Martinez Canillas --- drivers/gpu/drm/solomon/ssd130x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH v2 33/43] drm/tiny/ili9163: Use fbdev-dma

2024-04-10 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by ili9163. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tiny/ili9163.c | 4 ++-- 1 file

[PATCH v2 17/43] drm/tiny/simpledrm: Use fbdev-shmem

2024-04-10 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-shmem. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Thomas Zimmermann Cc: Javier Martinez Canillas --- drivers/gpu/drm/tiny/simpledrm.c | 4 ++-- 1 file changed, 2

[PATCH v2 27/43] drm/panel/panel-ilitek-9341: Use fbdev-dma

2024-04-10 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by panel-ilitek-9341. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Neil Armstrong Cc: Jessica Zhang Cc: Sam

[PATCH v2 20/43] drm/vkms: Use fbdev-shmem

2024-04-10 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-shmem. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Rodrigo Siqueira Cc: Melissa Wen Cc: "Maíra Canal" Cc: Haneen Mohammed Cc: Daniel Vetter ---

[PATCH v2 06/43] fbdev/deferred-io: Always call get_page() for framebuffer pages

2024-04-10 Thread Thomas Zimmermann
Unconditionally call get_page() after looking up a page from the framebuffer memory. Guarantees that we always hold a reference. This change also refactors the code such that it can support a driver-supplied get_page helper. This will be useful for DRM's fbdev emulation. Signed-off-by: Thomas

[PATCH v2 09/43] drm/ast: Use fbdev-shmem

2024-04-10 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-shmem. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Dave Airlie Cc: Thomas Zimmermann Cc: Jocelyn Falempe Reviewed-by: Jocelyn Falempe --- drivers/gpu/drm/ast/ast_drv.c |

[PATCH v2 02/43] fbdev/deferred-io: Move pageref setup into separate helper

2024-04-10 Thread Thomas Zimmermann
Set up struct fb_deferred_io_pageref in the new helper function fb_deferred_io_pageref_lookup(), which runs when the pageref is first taken. Remove the setup code from the rest of the code. At first, the code allocates the memory of all pageref structs. The setup of the various fields happens

  1   2   >