It doesn't need to assign name array address to np pointer.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
v2: replace sprintf() with snprintf() and remove memset() call
because snprintf() adds a terminating '\0'
drivers/staging/cxt1e1/linux.c |8 +++-
1 files changed, 3
On Wednesday, March 5, 2014 6:10 AM, Ian Abbott abbo...@mev.co.uk wrote:
On 2014-03-04 08:43, Chase Southwood wrote:
This patch changes a handful of while loops to timeouts to prevent
infinite looping on hardware failure. A couple such loops are in a
function (s626_debi_transfer()) which is
On 06/03/14 06:57, Fred Akers wrote:
Refactor this function to remove an extra indent level
Signed-off-by: Fred Akers kni...@botops.net
Reviewed-by: Ian Abbott abbo...@mev.co.uk
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk)=-
-=( Tel: +44 (0)161 477 1898 FAX: +44
On 06/03/14 06:57, Fred Akers wrote:
This check is unnecessary because range_table will always be
initialized to range_unknown by comedi_device_postconfig() for
drivers that do not initialize range_table or range_table_list
Signed-off-by: Fred Akers kni...@botops.net
---
This patch set enables both checksum as well as segmentation offload.
As part of this effort I have enabled scatter gather I/O a well.
K. Y. Srinivasan (6):
Drivers: net: hyperv: Enable scatter gather I/O
Drivers: net: hyperv: Cleanup the send path
Drivers: net: hyperv: Enable offloads on
In preparation for enabling offloads, cleanup the send path.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Reviewed-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/net/hyperv/hyperv_net.h |7 +---
drivers/net/hyperv/netvsc_drv.c | 87 +---
Enable segmentation offload.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Reviewed-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/net/hyperv/hyperv_net.h | 40 +++
drivers/net/hyperv/netvsc_drv.c | 38 +---
2
Enable send side checksum offload.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Reviewed-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/net/hyperv/netvsc_drv.c | 70 +-
1 files changed, 68 insertions(+), 2 deletions(-)
diff --git
Enable receive side checksum offload.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Reviewed-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/net/hyperv/hyperv_net.h | 33 -
drivers/net/hyperv/netvsc_drv.c | 20
Prior to enabling guest side offloads, enable the offloads on the host.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Reviewed-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/net/hyperv/hyperv_net.h | 55
drivers/net/hyperv/rndis_filter.c | 83
On Wed, 2014-03-05 at 20:45 -0800, Greg Kroah-Hartman wrote:
On Thu, Mar 06, 2014 at 01:48:29AM +0100, Laurent Pinchart wrote:
Would you recommend to drop driver-specific Kconfig options related to
debugging and use CONFIG_DYNAMIC_DEBUG instead ?
Yes, please do that, no one wants to
Hi Joe,
On Wednesday 05 March 2014 19:25:47 Joe Perches wrote:
On Thu, 2014-03-06 at 02:52 +0100, Laurent Pinchart wrote:
I've thought about that, but it would require iss.h to be included before
all other headers. I've also thought about creating an iss-debug.h header
to be included first
Hi Greg,
On Wednesday 05 March 2014 20:45:29 Greg Kroah-Hartman wrote:
On Thu, Mar 06, 2014 at 01:48:29AM +0100, Laurent Pinchart wrote:
On Wednesday 05 March 2014 16:28:03 Joe Perches wrote:
On Thu, 2014-03-06 at 00:50 +0100, Laurent Pinchart wrote:
Please note that -DDEBUG is
Em Thu, 06 Mar 2014 12:00:30 +0100
Laurent Pinchart laurent.pinch...@ideasonboard.com escreveu:
Hi Greg,
On Wednesday 05 March 2014 20:45:29 Greg Kroah-Hartman wrote:
On Thu, Mar 06, 2014 at 01:48:29AM +0100, Laurent Pinchart wrote:
On Wednesday 05 March 2014 16:28:03 Joe Perches wrote:
On 03/06/2014 01:17 AM, Daeseok Youn wrote:
coccinelle warning:
drivers/staging/dgap/dgap.c:782:3-7: WARNING:
casting value returned by k[cmz]alloc to (char *) is useless.
drivers/staging/dgap/dgap.c:776:2-16: WARNING:
casting value returned by k[cmz]alloc to (struct board_t *) is useless.
On Wed, Mar 05, 2014 at 10:20:57AM +0100, Philipp Zabel wrote:
This patch fixes the TV Encoder DDC I2C bus property to use the common
'ddc-i2c-bus' property name instead of 'ddc'.
Looking at both hdmi and tve, the ddc part is very similar. The difference
is how the probe is handled:
imx-hdmi:
Hi Russell,
Am Donnerstag, den 06.03.2014, 13:03 + schrieb Russell King - ARM
Linux:
On Wed, Mar 05, 2014 at 10:20:57AM +0100, Philipp Zabel wrote:
This patch fixes the TV Encoder DDC I2C bus property to use the common
'ddc-i2c-bus' property name instead of 'ddc'.
Looking at both hdmi
This patch allows to optionally attach the lvds-channel to a panel
supported by a drm_panel driver instead of supplying the modes via
device tree.
Before:
ldb {
...
lvds-channel@0 {
...
display-timings {
This patch depends on the OF graph parsing helper and imx-drm-dt series.
It allows to connect the panel to the output port (port@1 on i.MX53, port@4
on i.MX6) via the OF graph bindings.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
drivers/staging/imx-drm/imx-ldb.c | 19
Am Donnerstag, den 06.03.2014, 14:54 +0100 schrieb Philipp Zabel:
This patch depends on the OF graph parsing helper and imx-drm-dt series.
It allows to connect the panel to the output port (port@1 on i.MX53, port@4
on i.MX6) via the OF graph bindings.
If we postpone this until the imx-drm-dt
On 03/05/2014 04:39 PM, Dan Carpenter wrote:
Btw, if you don't get any messages from me that means I have given your
patch the stamp of approval. So good job on your previous patchset. :)
On Wed, Mar 05, 2014 at 03:54:49PM -0500, Mark Hounschell wrote:
@@ -1613,7 +1616,8 @@ static void
On 03/05/2014 10:40 PM, Greg KH wrote:
On Wed, Mar 05, 2014 at 02:52:26PM -0600, Ken Cox wrote:
Add the Unisys s-Par maintainer entry to the MAINTAINERS file.
Add Greg Kroah-Hartman to the list of patch recipients in the TODO file
Signed-off-by: Ken Cox j...@redhat.com
---
MAINTAINERS
On Thu, Mar 06, 2014 at 09:19:08AM -0500, Mark Hounschell wrote:
Function arguments line up:
memcpy(ch-ch_sniff_buf + ch-ch_sniff_in, p,
r);
As you say below, Breaking the lines up like this isn't ideal.
This one I feel
On Wed, Mar 05, 2014 at 10:36:53PM -0800, Kalyan Kodamagula wrote:
Hi,
Iam new to this ML,I need info regarding Usb device drivers.I had learned
Lnx device drivers and having
knowledge on USB Host driver(highlevel).
I had seen probe/read/write functions of a driver.As there is no
On 03/05/2014 04:47 PM, Dan Carpenter wrote:
On Wed, Mar 05, 2014 at 03:54:50PM -0500, Mark Hounschell wrote:
@@ -2953,7 +2955,8 @@ static int dgap_tty_write(struct tty_struct *tty, const
unsigned char *buf, int
if (down_interruptible(dgap_TmpWriteSem))
On Thu, Mar 06, 2014 at 09:56:29AM -0500, Mark Hounschell wrote:
On 03/05/2014 04:47 PM, Dan Carpenter wrote:
On Wed, Mar 05, 2014 at 03:54:50PM -0500, Mark Hounschell wrote:
@@ -2953,7 +2955,8 @@ static int dgap_tty_write(struct tty_struct *tty,
const unsigned char *buf, int
if
Removed the unneeded pmcc4_OSSI_release version string, as well as the now
unused 'release' element of the sbe_card_info struct. This also resolves a
sparse should it be static warning.
Signed-off-by: Shaun Laing sh...@xresource.ca
---
V2: changed to remove the version string entirely.
Compiles,
On Thu, 6 Mar 2014, Valentina Manea wrote:
A device should not be able to be used concurrently both by
the server and the client. Claiming the port used by the
shared device ensures no interface drivers bind to it and
that it is not usable from the server.
Signed-off-by: Valentina Manea
On 03/06/2014 10:11 AM, Dan Carpenter wrote:
On Thu, Mar 06, 2014 at 09:56:29AM -0500, Mark Hounschell wrote:
On 03/05/2014 04:47 PM, Dan Carpenter wrote:
On Wed, Mar 05, 2014 at 03:54:50PM -0500, Mark Hounschell wrote:
@@ -2953,7 +2955,8 @@ static int dgap_tty_write(struct tty_struct *tty,
This patch updates the MAINTAINERS file to add the maintainer for the
Unisys s-Par driver set.
Signed-off-by: Ken Cox j...@redhat.com
signed-off-by: Ben Romer sparmaintai...@unisys.com
diff --git a/MAINTAINERS b/MAINTAINERS
index c3ff623..06dc169 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@
On Thu, 2014-03-06 at 08:47 -0600, Ken Cox wrote:
On 03/05/2014 10:40 PM, Greg KH wrote:
On Wed, Mar 05, 2014 at 02:52:26PM -0600, Ken Cox wrote:
Add the Unisys s-Par maintainer entry to the MAINTAINERS file.
Add Greg Kroah-Hartman to the list of patch recipients in the TODO file
Signed-off-by: Denis Carikli de...@eukrea.com
---
ChangeLog v8-v9:
- Removed the Cc. They are now set in git-send-email directly.
- Rebased.
ChangeLog v7-v8:
- Shrinked even more the Cc list.
ChangeLog v6-v7:
- Shrinked even more the Cc list.
ChangeLog v5-v6:
- Remove people not concerned by
The current BGR666 is not consistent with the other color mapings like BGR24.
BGR666 should be in the same byte order than BGR24.
Signed-off-by: Denis Carikli de...@eukrea.com
---
ChangeLog v8-v9:
- Removed the Cc. They are now set in git-send-email directly.
ChangeLog v7-v8:
- Shrinked even
The CMO-QVGA, DVI-SVGA and DVI-VGA are added.
Signed-off-by: Denis Carikli de...@eukrea.com
---
ChangeLog v8-v9:
- Removed the Cc. They are now set in git-send-email directly.
- updated pixelclk-active after the following patch:
imx-drm: Match ipu_di_signal_cfg's clk_pol with its description.
If de-active and/or pixelclk-active properties were set in the
display-timings DT node, they were not used.
Instead the data-enable and the pixel data clock polarity
were hardcoded.
The dts were updated to keep the former behaviour.
Signed-off-by: Denis Carikli de...@eukrea.com
---
ChangeLog
Signed-off-by: Denis Carikli de...@eukrea.com
---
ChangeLog v8-v9:
- Removed the Cc. They are now set in git-send-email directly.
- The backlight is now on at boot.
ChangeLog v6-v7:
- Shrinked even more the Cc list.
ChangeLog v5-v6:
- Reordered the Cc list.
ChangeLog v3-v5:
- Updated to the new
According to the datasheet, setting the di0_polarity_disp_clk
field in the GENERAL di register sets the output clock polarity
to active high.
Signed-off-by: Denis Carikli de...@eukrea.com
---
ChangeLog v8-v9:
- New patch that is now needed by the
staging: imx-drm: Use de-active and
Signed-off-by: Denis Carikli de...@eukrea.com
---
ChangeLog v8-v9:
- Removed the Cc. They are now set in git-send-email directly.
- Rebased.
ChangeLog v7-v8:
- Shrinked even more the Cc list.
- Rebased.
ChangeLog v6-v7:
- Shrinked even more the Cc list.
- Rebased the patch and included
On 03/04/2014 12:10 PM, Valentina Manea wrote:
This patch adds autoconf check for libudev and migrates
usbip_bind to the new library.
libsysfs will still be used until all userspace is modified.
Signed-off-by: Valentina Manea valentina.mane...@gmail.com
---
On Wed, Mar 05, 2014 at 11:30:06PM -0800, Andrew Grover wrote:
On Wed, Mar 5, 2014 at 10:14 PM, Valentina Manea
valentina.mane...@gmail.com wrote:
On Tue, Mar 4, 2014 at 9:20 PM, Greg KH gre...@linuxfoundation.org wrote:
On Tue, Mar 04, 2014 at 09:16:39PM +0200, Valentina Manea wrote:
Hi Denis,
Am Donnerstag, den 06.03.2014, 17:04 +0100 schrieb Denis Carikli:
[...]
+display {
+ status = okay;
+ display-timings {
+ model = DVI-SVGA;
Does this board really have a DVI connector and no I2C bus routed to the
DDC pins?
+ bits-per-pixel = 16;
+
Hi Denis,
Am Donnerstag, den 06.03.2014, 17:04 +0100 schrieb Denis Carikli:
diff --git
a/Documentation/devicetree/bindings/staging/imx-drm/fsl-imx-drm.txt
b/Documentation/devicetree/bindings/staging/imx-drm/fsl-imx-drm.txt
index 2d24425..4dd7ce5 100644
---
Hi Denis,
Am Donnerstag, den 06.03.2014, 17:01 +0100 schrieb Denis Carikli:
The current BGR666 is not consistent with the other color mapings like BGR24.
BGR666 should be in the same byte order than BGR24.
Signed-off-by: Denis Carikli de...@eukrea.com
patches 1 to 3
Acked-by: Philipp Zabel
On 03/04/2014 12:10 PM, Valentina Manea wrote:
This patch modifies usbip_unbind to use libudev.
Signed-off-by: Valentina Manea valentina.mane...@gmail.com
---
drivers/staging/usbip/userspace/src/usbip_unbind.c | 92 +++---
1 file changed, 29 insertions(+), 63 deletions(-)
Четверг, 6 марта 2014, 17:29 +01:00 от Philipp Zabel p.za...@pengutronix.de:
Hi Denis,
Am Donnerstag, den 06.03.2014, 17:04 +0100 schrieb Denis Carikli:
diff --git
a/Documentation/devicetree/bindings/staging/imx-drm/fsl-imx-drm.txt
On Wednesday, March 05, 2014 11:57 PM, Fred Akers wrote:
Refactor this function to remove an extra indent level
Signed-off-by: Fred Akers kni...@botops.net
Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com
Thanks
___
devel mailing list
On Wednesday, March 05, 2014 11:57 PM, Fred Akers wrote:
This check is unnecessary because range_table will always be
initialized to range_unknown by comedi_device_postconfig() for
drivers that do not initialize range_table or range_table_list
Signed-off-by: Fred Akers kni...@botops.net
On Thu, 2014-03-06 at 11:55 +0100, Laurent Pinchart wrote:
We thus need the #define DEBUG it appear before the first time device.h is
included, either directly or indirectly. Adding #define DEBUG to iss.h won't
work now as iss.h is included after all system includes (which is the usual
On Thursday, March 06, 2014 12:25 AM, Chase Southwood wrote:
This patch for hwdrv_apci1564.c fixes the register map defines for the
digital input registers such that they are all the real offsets to each
register, rather than a mix of real offsets and adders to those offsets.
Additionally, the
On Thursday, March 06, 2014 12:26 AM, Chase Southwood wrote:
This patch for hwdrv_apci1564.c fixes the register map defines for the
digital output registers such that they are all the real offsets to each
register, rather than a mix of real offsets and adders to those offsets.
Additionally,
On Thursday, March 06, 2014 12:26 AM, Chase Southwood wrote:
This patch for hwdrv_apci1564.c fixes the register map defines for the
timer registers such that they are all the real offsets to each register,
rather than a mix of real offsets and adders to those offsets.
Additionally, the defines
On Thursday, March 06, 2014 12:26 AM, Chase Southwood wrote:
This patch for hwdrv_apci1564.c fixes the register map defines for the
watchdog registers such that they are all the real offsets to each
register, rather than a mix of real offsets and adders to those offsets.
Additionally, the
On Thursday, March 06, 2014 12:26 AM, Chase Southwood wrote:
This patch for hwdrv_apci1564.c fixes the register map defines for the
digital input registers such that they are all the real offsets to each
register, rather than a mix of real offsets and adders to those offsets.
Signed-off-by:
This patch fixes a few 80+ char lines as reported by checkpatch
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap.c | 52 +
1 file changed, 34 insertions(+), 18 deletions(-)
This patch removes more dead code and code associated
with that dead code. The from_user variable in the
dgap_tty_write function was never true. The code under
its test was never being executed. So variables and
functions supporting only that code are also dead.
Signed-off-by: Mark Hounschell
On Thu, Mar 06, 2014 at 09:15:01AM -0700, Shuah Khan wrote:
--- a/drivers/staging/usbip/userspace/libsrc/usbip_common.h
+++ b/drivers/staging/usbip/userspace/libsrc/usbip_common.h
@@ -29,6 +29,15 @@
#define USBIP_HOST_DRV_NAMEusbip-host
#define USBIP_VHCI_DRV_NAMEvhci_hcd
If CONFIG_SCSI is not enabled, compiling virthba.c goes horribly wrong with
undefined symbols.
Signed-off-by: Ken Cox j...@redhat.com
---
drivers/staging/unisys/virthba/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/virthba/Kconfig
This patch removes printks associated with sysfile creation
and changes the dgap_create_driver_sysfiles function to return
an int so we can check for errors in the sysfile creation
process.
The printk's were flagged by checkpatch but then
driver_create_file was flagged by checkpatch for
not
Introduce some helper functions to handle the user space to kernel space
copying of the comedi_cmd and chanlist data for the COMEDI_CMD and
COMEDI_CMDTEST ioctls.
This gets all the dev_dbg() into one place and clarifies the functions a
bit.
H Hartley Sweeten (2):
staging: comedi: comedi_fops:
The COMEDI_CMD and COMEDI_CMDTEST ioctl functions both copy the
comedi_cmd passed by the user from __user memory space to kernel
memory space. They then do some basic sanity checking of the cmd
before the subdevice (*do_cmdtest) and (*do_cmd) operations are
called.
Introduce a helper function to
On Thu, Mar 06, 2014 at 12:57:00PM -0600, Ken Cox wrote:
If CONFIG_SCSI is not enabled, compiling virthba.c goes horribly wrong with
undefined symbols.
Signed-off-by: Ken Cox j...@redhat.com
---
You forgot a Reported-by: line saying how you found out about this
issue...
From: K. Y. Srinivasan k...@microsoft.com
Date: Thu, 6 Mar 2014 03:13:05 -0800
@@ -140,21 +140,125 @@ static void netvsc_xmit_completion(void *context)
dev_kfree_skb_any(skb);
}
+static u32 fill_pg_buf(struct page *page, u32 offset, u32 len,
+ struct
On Thu, Mar 06, 2014 at 01:57:55PM -0500, Mark Hounschell wrote:
This patch removes printks associated with sysfile creation
and changes the dgap_create_driver_sysfiles function to return
an int so we can check for errors in the sysfile creation
process.
The printk's were flagged by
From: K. Y. Srinivasan k...@microsoft.com
Date: Thu, 6 Mar 2014 03:13:06 -0800
In preparation for enabling offloads, cleanup the send path.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Reviewed-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/net/hyperv/hyperv_net.h |7
From: K. Y. Srinivasan k...@microsoft.com
Date: Thu, 6 Mar 2014 03:13:08 -0800
+ /*
+ * We only look at the IP checksum here.
+ * Should we be dropping the packet if checksum
+ * failed? How do we deal with other checksums - TCP/UDP?
+
From: K. Y. Srinivasan k...@microsoft.com
Date: Thu, 6 Mar 2014 03:13:07 -0800
+ /*
+ * can't put_rndis_request, since we may still receive a
+ * send-completion.
+ */
Please fix the formatting of this comment.
+ /*
+ * Turn on
On Thu, Mar 06, 2014 at 02:26:17PM -0500, Mark Hounschell wrote:
On 03/05/2014 04:47 PM, Dan Carpenter wrote:
On Wed, Mar 05, 2014 at 03:54:50PM -0500, Mark Hounschell wrote:
@@ -2953,7 +2955,8 @@ static int dgap_tty_write(struct tty_struct *tty,
const unsigned char *buf, int
if
From: K. Y. Srinivasan k...@microsoft.com
Date: Thu, 6 Mar 2014 03:13:09 -0800
+bool get_net_transport_info(struct sk_buff *skb, bool *is_v4,
+ bool *is_tcp, bool *is_udp, u32 *trans_off)
+{
Returning so many values like this is awkward, at best.
Why not return a
From: K. Y. Srinivasan k...@microsoft.com
Date: Thu, 6 Mar 2014 03:13:10 -0800
+ ppi = init_ppi_data(rndis_msg, NDIS_LSO_PPI_SIZE,
+ TCP_LARGESEND_PKTINFO);
This is not indented properly, TCP_LARGESEND_PKTINFO); should start at the
first column after the
On Thu, Mar 06, 2014 at 03:13:07AM -0800, K. Y. Srinivasan wrote:
+ offload_params = (struct ndis_offload_params *)((ulong)set +
+ set-info_buf_offset);
It's a bit simpler to do pointer math like this:
offload_params = (void *)set + set-info_buf_offset;
If CONFIG_SCSI is not enabled, compiling virthba.c goes horribly wrong with
undefined symbols.
Reported-by: kbuild test robot fengguang...@intel.com
Signed-off-by: Ken Cox j...@redhat.com
---
drivers/staging/unisys/virthba/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On Wed, Mar 05, 2014 at 09:53:06PM +0300, Dan Carpenter wrote:
On Wed, Mar 05, 2014 at 02:04:35PM +0100, Maxin B. John wrote:
From: Maxin B. John maxin.j...@enea.com
cppcheck reported possible null pointer dereference in mdc_lib.c
[lustre/lustre/mdc/mdc_lib.c:233]: (error) Possible
On Wed, Mar 05, 2014 at 02:04:36PM +0100, Maxin B. John wrote:
From: Maxin B. John maxin.j...@enea.com
osc_obd can be NULL. cppcheck reported this:
[lustre/lustre/lov/lov_obd.c:283]: (error) Possible null pointer dereference:
osc_obd - otherwise it is redundant to check if osc_obd is null at
On Thu, Mar 06, 2014 at 02:48:13PM -0500, Mark Hounschell wrote:
want me to do this is in a separate patch or redo this one?
Separate patch is fine.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
On Thu, Mar 06, 2014 at 07:45:27AM +0200, Valentina Manea wrote:
On Wed, Mar 5, 2014 at 12:16 PM, Dan Carpenter dan.carpen...@oracle.com
wrote:
On Tue, Mar 04, 2014 at 10:35:39PM -0800, Greg KH wrote:
On Tue, Mar 04, 2014 at 09:10:46PM +0200, Valentina Manea wrote:
Add
On Wed, Mar 05, 2014 at 10:21:01AM +0900, Daeseok Youn wrote:
checkpatch.pl error in linux.c:
ERROR: do not use assignment in if condition
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c | 31 +++
1 files changed, 19
On Thu, Mar 06, 2014 at 05:12:48PM +0900, Daeseok Youn wrote:
It doesn't need to assign name array address to np pointer.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
v2: replace sprintf() with snprintf() and remove memset() call
because snprintf() adds a terminating '\0'
Your
On Thu, Mar 06, 2014 at 10:01:04AM -0600, Romer, Benjamin M wrote:
This patch updates the MAINTAINERS file to add the maintainer for the
Unisys s-Par driver set.
Signed-off-by: Ken Cox j...@redhat.com
signed-off-by: Ben Romer sparmaintai...@unisys.com
Please capitalize things properly.
And
This patch simplifies and cleans up the dgap_init_module function. It also fixes
a possible double free condition as a result pci_unregister_driver possibly
being called twice.
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
-Original Message-
From: David Miller [mailto:da...@davemloft.net]
Sent: Friday, March 7, 2014 1:04 AM
To: KY Srinivasan
Cc: net...@vger.kernel.org; linux-ker...@vger.kernel.org;
de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
jasow...@redhat.com
Subject: Re:
From: KY Srinivasan k...@microsoft.com
Date: Thu, 6 Mar 2014 20:29:13 +
-Original Message-
From: David Miller [mailto:da...@davemloft.net]
Sent: Friday, March 7, 2014 1:04 AM
To: KY Srinivasan
Cc: net...@vger.kernel.org; linux-ker...@vger.kernel.org;
-Original Message-
From: David Miller [mailto:da...@davemloft.net]
Sent: Friday, March 7, 2014 2:19 AM
To: KY Srinivasan
Cc: net...@vger.kernel.org; linux-ker...@vger.kernel.org;
de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
jasow...@redhat.com
Subject: Re:
On Fri, Mar 07, 2014 at 12:11:10AM +0300, Dan Carpenter wrote:
Hello Ken Cox,
The patch dc95086172db: staging: virthba driver to access shared
SCSI hba from Mar 4, 2014, leads to the following Sparse warning:
drivers/staging/unisys/virthba/virthba.c:1442:24: warning:
Variable
Hello Ken Cox,
The patch bac8a4d5d29b: staging: visoruislib driver used to handle
requests from virtpci from Mar 4, 2014, leads to the following
Smatch warning (but you need to run with --spammy to see it):
drivers/staging/unisys/uislib/uislib.c:1688 info_proc_read_helper()
warn:
Hi,
On Thu, Mar 6, 2014 at 8:51 PM, Greg KH gre...@linuxfoundation.org wrote:
On Wed, Mar 05, 2014 at 09:53:06PM +0300, Dan Carpenter wrote:
On Wed, Mar 05, 2014 at 02:04:35PM +0100, Maxin B. John wrote:
From: Maxin B. John maxin.j...@enea.com
cppcheck reported possible null pointer
On 03/04/2014 12:10 PM, Valentina Manea wrote:
This patch modifies usbip_host_driver to use libudev.
Signed-off-by: Valentina Manea valentina.mane...@gmail.com
---
.../staging/usbip/userspace/libsrc/usbip_common.c | 74 ++
.../staging/usbip/userspace/libsrc/usbip_common.h | 5 +-
On 03/04/2014 12:10 PM, Valentina Manea wrote:
The class device lists were used only when being initialized,
being populated and being destroyed. They had no real meaning
and thus the code was useless.
Signed-off-by: Valentina Manea valentina.mane...@gmail.com
---
On 03/04/2014 12:10 PM, Valentina Manea wrote:
This patch migrates vhci_driver to libudev.
Signed-off-by: Valentina Manea valentina.mane...@gmail.com
---
.../staging/usbip/userspace/libsrc/usbip_common.h | 1 -
.../staging/usbip/userspace/libsrc/vhci_driver.c | 154 ++---
Sorry for confusing you.
Actually 1-3 patches already merged to staging-next branch.
And then I had a request resending the rest of the series.
So I just sent 4-7 again. Sorry, I should rebase these patches and
make a series newly.
I will send patches again properly.
I think this patches need to
Ok.
I will fix it and send again.
Thanks.
Daeseok Youn
2014-03-07 4:58 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Thu, Mar 06, 2014 at 05:12:48PM +0900, Daeseok Youn wrote:
It doesn't need to assign name array address to np pointer.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
Hi Russell,
Time for me to jump in. The more, the merrier I suppose.
On Wednesday 26 February 2014 22:19:39 Russell King - ARM Linux wrote:
On Wed, Feb 26, 2014 at 10:00:25PM +0100, Guennadi Liakhovetski wrote:
Hi Russell
(I suspect this my email will be rejected by ALKML too like other
On Thursday 27 February 2014 16:10:41 Tomi Valkeinen wrote:
On 27/02/14 15:43, Russell King - ARM Linux wrote:
That may be - but the problem with CDF solving this problem is that it's
wrong. It's fixing what is in actual fact a *generic* problem in a much
too specific way. To put it
Networking prefers this style, so warn when it's not used.
Networking uses:
void foo(int bar)
{
int baz;
code...
}
not
void foo(int bar)
{
int baz;
code...
}
There are a limited number of false positives when using
macros to declare variables like:
WARNING:
On Thu, 06 Mar 2014 15:42:30 -0800 Joe Perches j...@perches.com wrote:
On Thu, 2014-03-06 at 15:35 -0800, Andrew Morton wrote:
On Thu, 06 Mar 2014 15:28:40 -0800 Joe Perches j...@perches.com wrote:
Networking prefers this style, so warn when it's not used.
void foo(int bar)
{
int
checkpatch.pl error in linux.c:
ERROR: do not use assignment in if condition
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c | 31 +++
1 files changed, 19 insertions(+), 12 deletions(-)
diff --git
clean up checkpatch.pl error in linux.c:
ERROR: that open brace { should be on the previous line
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c | 67 ---
1 files changed, 21 insertions(+), 46 deletions(-)
diff --git
The mkret() change a value of error from positive to
negative. This patch is modified to return negative value
when it failed. It doesn't need to call with function
for changing from positive to negative.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c
The name array doens't need to set to 0. Because
sprintf/snprintf adds a terminating '\0'.
And also it doesn't need to assign name array
address to np pointer.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c |8 +++-
1 files changed, 3
Make the test system wide, modify the message too.
Signed-off-by: Joe Perches j...@perches.com
---
OK, let's do this for now. Could you please cook up a followon patch
which makes this kernel-wide? I'll play with that for a while then I'll
decide how much I feel like irritating people.
On Thu, 2014-03-06 at 15:51 -0800, John de la Garza wrote:
Added code to check return value of sscanf.
[]
diff --git a/drivers/staging/usbip/usbip_common.c
b/drivers/staging/usbip/usbip_common.c
[]
@@ -55,7 +55,8 @@ static ssize_t usbip_debug_store(struct device *dev,
1 - 100 of 112 matches
Mail list logo
