[E1000-devel] [PATCH 1/2] ixgbe: fix typo

2008-06-09 Thread Jeff Kirsher
Define names were accidently transposed. Signed-off-by: Jeff Kirsher [EMAIL PROTECTED] --- drivers/net/ixgbe/ixgbe_82598.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_82598.c b/drivers/net/ixgbe/ixgbe_82598.c index 6321b05..2f38e84 100644

[E1000-devel] [NET-NEXT PATCH 01/18] igb: limit EEPROM access

2008-06-27 Thread Jeff Kirsher
EEPROM access beyond the base eeprom page is unsupported. Signed-off-by: Jeff Kirsher [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/igb/e1000_82575.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/net/igb/e1000_82575.c b/drivers

[E1000-devel] [NET-NEXT PATCH 07/18] igb: add NAPI Rx queue support

2008-06-27 Thread Jeff Kirsher
From: PJ Waskiewicz [EMAIL PROTECTED] Update the NAPI implementation to use the new napi_struct infrstructure. This removes the need of multiple net_device structs to implement a multiqueue NAPI. Signed-off-by: PJ Waskiewicz [EMAIL PROTECTED] Signed-off-by: Jeff Kirsher [EMAIL PROTECTED

[E1000-devel] [NET-NEXT PATCH 10/18] igb: add DCA support

2008-06-27 Thread Jeff Kirsher
From: Jeb Cramer [EMAIL PROTECTED] Add DCA support in the similar method that it was added to the ixgbe driver recently. DCA allows the network device to put data in the CPU cache and notify the chipset of that event. This reduces cache misses during receives. Signed-off-by: Jeb Cramer [EMAIL

[E1000-devel] [NET-NEXT PATCH 12/18] igb: Increment driver version

2008-06-27 Thread Jeff Kirsher
From: Auke Kok [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] Signed-off-by: Jeff Kirsher [EMAIL PROTECTED] --- drivers/net/igb/igb_main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/igb/igb_main.c b/drivers/net/igb/igb_main.c index 27fca76

[E1000-devel] [NET-NEXT PATCH 18/18] igb: update suspend resume

2008-06-27 Thread Jeff Kirsher
From: Alexander Duyck [EMAIL PROTECTED] Updates the suspend and resume to better handle the possibility of MSIX vector changes. Signed-off-by: Alexander Duyck [EMAIL PROTECTED] Signed-off-by: Jeff Kirsher [EMAIL PROTECTED] --- drivers/net/igb/igb_main.c | 46

Re: [E1000-devel] Huge packet loss on Intel 80003ES2LAN

2008-07-23 Thread Jeff Kirsher
On Tue, Jul 22, 2008 at 3:34 AM, Vlad Seliverstov [EMAIL PROTECTED] wrote: Hi. Recently, I moved my heavily network-loaded server under Ubuntu Hardy to a box with two 80003ES2LAN onboard NICs and began to experience problems with it. The problem is huge packet loss time to time. Here are

Re: [E1000-devel] Problem in change driver

2008-08-05 Thread Jeff Kirsher
2008/8/5 刘磊 [EMAIL PROTECTED]: Thank you, I will check again. And the follow is the changes I had made. static int e1000_ipv4(struct e1000_adapter *adapter, struct sk_buff *skb) { struct e1000_ring *tx_ring = adapter-tx_ring; struct e1000_context_desc *context_desc; struct

[E1000-devel] [PATCH] igb: add IGB_DCA instead of selecting INTEL_IOATDMA

2008-10-17 Thread Jeff Kirsher
Add a bool IGB_DCA defined to y if IGB and DCA are enabled, but IGB isn't y while DCA=m. And thus remove the need to select INTEL_IOATDMA when IGB is enabled, so that non-x86 architectures can build the igb driver. Based on work/patch from Brice Goglin [EMAIL PROTECTED] Signed-off-by: Jeff

Re: [E1000-devel] [PATCH] Temporary solution for problem, e1000e breaking IPMI

2008-10-28 Thread Jeff Kirsher
On Tue, Oct 28, 2008 at 3:53 PM, Irwin Estes [EMAIL PROTECTED] wrote: Now that e1000e release 0.4.1.12 is out is there any word about the when the patch for IPMI will be released, and what method will be used? I apologize, we have a patch which I have not pushed to the kernel. I will work on

Re: [E1000-devel] e1000 and PBA

2008-11-25 Thread Jeff Kirsher
Added e1000-devel mailing list (again), please reply-to-all next time. On Tue, Nov 25, 2008 at 12:40 AM, [EMAIL PROTECTED] wrote: what other devices do you have on the PCI bus? Since there are different versions of this part having a device ID here in the discussion would help. Also, you

Re: [E1000-devel] Searching Kernel patches for multiqueue RX at E1000 7.6.15 (Intel 1000/PRO PT)

2008-11-28 Thread Jeff Kirsher
On Thu, Nov 27, 2008 at 2:45 AM, Vladimir [EMAIL PROTECTED] wrote: Hi, I am using E1000 driver 7.6.15 that enables multiqueueing by CONFIG_E1000_MQ. However, there are some patches required for kernel also since compilation erros with CONFIG_E1000_MQ set. Could you help me how and

Re: [E1000-devel] e1000: LED indicates trouble, and [PATCH] enable/disable of force-link-up

2008-12-03 Thread Jeff Kirsher
On Tue, Dec 2, 2008 at 11:36 PM, [EMAIL PROTECTED] wrote: From: Hiroki Ohashi [EMAIL PROTECTED] Hi all, I faced the following situations. The LED of NIC was indicated, even when the system was not linked the network (auto-negotiation failed or link partner cannot auto-negotiate). LED

Re: [E1000-devel] [PATCH] e1000e: fix double release of mutex

2008-12-11 Thread Jeff Kirsher
On Thu, Dec 11, 2008 at 8:31 PM, David Miller da...@davemloft.net wrote: From: Jeff Kirsher jeffrey.t.kirs...@intel.com Date: Thu, 11 Dec 2008 13:58:07 -0800 During a reset, releasing the swflag after it failed to be acquired would cause a double unlock of the mutex. Instead, test whether

Re: [E1000-devel] (no subject)

2008-12-23 Thread Jeff Kirsher
On Mon, Dec 22, 2008 at 8:49 PM, Wu Fengguang fengguang...@intel.com wrote: Hi, I'd like to report one e1000e warning. I've been running 2.6.28-rcX for a long time and it's the first appearance of this (debug) message: [14100.898939] :00:19.0: eth0: Link is Down [14102.896362]

Re: [E1000-devel] E1000 change log

2008-12-24 Thread Jeff Kirsher
On Tue, Dec 23, 2008 at 9:49 PM, Luke Zhang (luzhan) luz...@cisco.com wrote: Hi, I ran into a kernel panic and would like to see if it is some known issue . I checked the sourceforge pages but can't find the changelog. Where can I find the change log and issues fixed for the e1000 driver?

Re: [E1000-devel] E1000 change log

2008-12-25 Thread Jeff Kirsher
63072 4 mptspi,mptctl,mptsas,mptscsih e1000e115492 0 igb 105880 0 mv_sata81804 18 -Original Message- From: tar...@gmail.com [mailto:tar...@gmail.com mailto:tar...@gmail.com ] On Behalf Of Jeff Kirsher Sent: Wednesday, December 24

Re: [E1000-devel] E1000 change log

2008-12-25 Thread Jeff Kirsher
On Thu, Dec 25, 2008 at 1:14 AM, Luke Zhang (luzhan) luz...@cisco.com wrote: Here you go... old bootloader convention, maybe loadlin? Bootdata ok (command line is root=/dev/ram ramdisk_size=15 ramdisk_start=0x600 console=ttyS0,9600n8) start kernel Linux version 2.6.10

Re: [E1000-devel] Does e1000e driver NOT need multiqueue?

2008-12-25 Thread Jeff Kirsher
On Wed, Dec 24, 2008 at 11:07 PM, 刘磊 orphen.lei...@gmail.com wrote: Hi, all: I have an intel 82571EB NIC, and it support 2Tx, 2Rx queues. I want to use the multi queue feature, but there is no CONFIG_NETDEVICES_MULTIQUEUE in the e1000e driver. Is the e1000e driver NOT need to set

Re: [E1000-devel] E1000 change log

2008-12-25 Thread Jeff Kirsher
people to do the upgrade :-) -- Luke -Original Message- From: tar...@gmail.com [mailto:tar...@gmail.com] On Behalf Of Jeff Kirsher Sent: Thursday, December 25, 2008 5:50 PM To: Luke Zhang (luzhan) Cc: e1000-devel@lists.sourceforge.net Subject: Re: [E1000-devel] E1000 change log

Re: [E1000-devel] [GIT]: Networking

2008-12-29 Thread Jeff Kirsher
On Mon, Dec 29, 2008 at 9:17 AM, Andrew Morton a...@linux-foundation.org wrote: On Mon, 29 Dec 2008 11:25:15 +0100 Andreas Mohr a...@lisas.de wrote: Hi, Adrian Bunk (1): The overdue eepro100 removal. That would be a rather pronounced NAK then? (sorry ;) (reason: rendering my web

Re: [E1000-devel] [PATCH -net-next 1/4] firmware: convert e100 driver to request_firmware()

2009-01-07 Thread Jeff Kirsher
On Sun, Jan 4, 2009 at 9:34 PM, David Miller da...@davemloft.net wrote: From: Jeff Kirsher jeffrey.t.kirs...@intel.com Date: Sun, 4 Jan 2009 18:20:24 -0800 On Sun, Jan 4, 2009 at 4:06 PM, David Miller da...@davemloft.net wrote: From: Jeff Kirsher jeffrey.t.kirs...@intel.com Date: Tue, 30

Re: [E1000-devel] e1000 tx Unit hang on 2.6.28 and patch that works...

2009-01-12 Thread Jeff Kirsher
On Fri, Jan 9, 2009 at 1:47 PM, Doug Bazarnic ker...@bazarnic.net wrote: Asus P5k, Intel Q9450, 8gb ram, x86_64, running 2.6.28. The on board eth0 atl1 never has a problem, only eth1 intel e1000, plugged into a pci slot. On a couple of machines, the way I got it to stop, was to use 8.0.6

Re: [E1000-devel] E1000 change log

2009-01-13 Thread Jeff Kirsher
On Tue, Jan 13, 2009 at 6:07 PM, Luke Zhang (luzhan) luz...@cisco.com wrote: Hi Jeff, Does these latest 8.x e1000 driver suppose to work with kernel 2.6.10? Or is there some minimum kernel version required? I am thinking of upgrade my e1000 driver from 7.2.7 to the latest. Thanks. -- Luke

Re: [E1000-devel] [PATCH] Fix link test for e1000 and e1000e when iface is down

2009-02-12 Thread Jeff Kirsher
On Tue, Feb 10, 2009 at 8:35 AM, Andre Detsch adet...@br.ibm.com wrote: When running ethtool -t on an interface that was just brought down, the link test was failing. That's because we need to perform a reset on the interface to be able to check the link status correctly. There is no problem

Re: [E1000-devel] [PATCH] Fix link test for e1000 and e1000e when iface is down

2009-02-13 Thread Jeff Kirsher
On Fri, Feb 13, 2009 at 4:08 AM, André Detsch adet...@br.ibm.com wrote: Jeff Kirsher wrote: I guess this comes down to what the definition of a Link test should be doing. My $0.02 is that it should be testing if the interface has a link, in which case if you ifdown the interface before

Re: [E1000-devel] Timeout Problem

2009-02-20 Thread Jeff Kirsher
On Wed, Feb 18, 2009 at 11:41 PM, Zils, Stephan stephan.z...@eads.com wrote: Hello, my name ist Stephan Zils and I'm a System-Ingenieer at EADS in Germany. We have a problem with the e100 Linux driver. From time to time, the driver will be restartet. See following kernel msg: NETDEV

Re: [E1000-devel] [PATCH 2/2] ixgbe: fix select_queue management

2009-03-20 Thread Jeff Kirsher
is necessary when there are multiple boards, or 1000's of vlans. Ah, gotcha.  Clears up my questions. Acked-by: Peter P Waskiewicz Jr peter.p.waskiewicz...@intel.com -- Acked-by: Jeff Kirsher jeffrey.t.kirs...@intel.com Dave - feel free to apply this patch when you take the first patch

Re: [E1000-devel] 64bit e1000 problems with Intel 82541PI

2009-03-24 Thread Jeff Kirsher
2009/3/24 Stack Stack i.am.st...@gmail.com: Hello! I have a few problems with my Intel Gigabit card. I was hoping someone could help. I am not subscribed to the list but I am following the list online [5]. I had been running 32 bit Debian Etch with my Intel Gigabit network card for

Re: [E1000-devel] [PATCH] igb: Report PCIe x2 link width configurations

2009-03-24 Thread Jeff Kirsher
On Tue, Mar 24, 2009 at 3:17 PM, Myron Stowe myron.st...@hp.com wrote: During boot, the igb driver shows the following message(s) for each NIC:  igb :05:00.0: Intel(R) Gigabit Ethernet Network Connection  igb :05:00.0: eth0: (PCIe:2.5Gb/s:unknown) 00:23:7d:45:80:6f  igb :05:00.0:

Re: [E1000-devel] 64bit e1000 problems with Intel 82541PI

2009-03-24 Thread Jeff Kirsher
2009/3/24 Stack Stack i.am.st...@gmail.com: On Tue, Mar 24, 2009 at 8:02 PM, Jeff Kirsher jeffrey.t.kirs...@intel.comwrote: The kernel version of e1000 is what you should be using if you have a kernel version 2.6.28 or newer (since 2.6.29 just got released). We keep the stand-alone driver

Re: [E1000-devel] [PATCH] Be explict with what we are !'ing in ixgbe_sfp_config_module_task()

2009-04-08 Thread Jeff Kirsher
On Tue, Apr 7, 2009 at 9:44 PM, Tony Breeds t...@bakeyournoodle.com wrote: GCC warns: drivers/net/ixgbe/ixgbe_main.c: In function 'ixgbe_sfp_config_module_task': drivers/net/ixgbe/ixgbe_main.c:3920: warning: suggest parentheses around operand of '!' or change '' to '' or '!' to '~' Which I

Re: [E1000-devel] [PATCH v2 fixed] e100: do not go D3 in shutdown unless system is powering off

2009-04-21 Thread Jeff Kirsher
On Tue, Apr 21, 2009 at 9:38 PM, Thadeu Lima de Souza Cascardo casca...@holoscopio.com wrote: After experimenting with kexec with the last merges after 2.6.29, I've had some problems when probing e100. It would not read the eeprom. After some bisects, I realized this has been like that since

Re: [E1000-devel] [PATCH v2 fixed] e100: do not go D3 in shutdown unless system is powering off

2009-04-22 Thread Jeff Kirsher
On Wed, Apr 22, 2009 at 12:37 PM, Thadeu Lima de Souza Cascardo casca...@holoscopio.com wrote: On Tue, Apr 21, 2009 at 10:46:19PM -0700, Jeff Kirsher wrote: On Tue, Apr 21, 2009 at 9:38 PM, Thadeu Lima de Souza Cascardo casca...@holoscopio.com wrote: After experimenting with kexec

Re: [E1000-devel] [PATCH net-next] Return PCI_ERS_RESULT_DISCONNECT when bus is disabled

2009-04-23 Thread Jeff Kirsher
On Thu, Apr 23, 2009 at 10:57 AM, Breno Leitao lei...@linux.vnet.ibm.com wrote: According to the PCI Error Recovery document, if after a recovery, the bus is disabled, the error_detected function should return PCI_ERS_RESULT_DISCONNECT. Actually ixgbe error_detected function is always

Re: [E1000-devel] [PATCH net-next] ixgbe: removing unnecesary assignments

2009-04-29 Thread Jeff Kirsher
On Wed, Apr 29, 2009 at 10:15 AM, Breno Leitao lei...@linux.vnet.ibm.com wrote: This patch removes some assignment that are not necessary. Since the ret variable is declared as false during its initialization, it makes no sense to reassign false to it again. Signed-off-by: Breno Leitao

Re: [E1000-devel] [PATCH] igb: Record hardware RX overruns in net_stats

2009-05-05 Thread Jeff Kirsher
On Mon, May 4, 2009 at 4:06 AM, Jesper Dangaard Brouer h...@comx.dk wrote: Hardware RX fifo overruns for the 82576 is stored in the RNBC (Receive No Buffers Count) register. I choose the store the RNBC value in net_stats.rx_fifo_errors. Saving the stats in dev-net_stats makes it visible via

Re: [E1000-devel] [PATCH 0/2] igb: drop stats due to OS cannot keep up

2009-05-14 Thread Jeff Kirsher
On Thu, May 7, 2009 at 6:35 AM, Jesper Dangaard Brouer h...@comx.dk wrote: The following patchset address drop stats counters in the igb driver (chips 82576 and 82575). The drop stats addressed here are due to the OS cannot keep up. I have only tested it for the 82576 chip, as my (12 port)

Re: [E1000-devel] [PATCH 0/2] igb: drop stats due to OS cannot keep up

2009-05-18 Thread Jeff Kirsher
On Fri, May 15, 2009 at 12:41 AM, Jesper Dangaard Brouer h...@comx.dk wrote: On Thu, 2009-05-14 at 15:43 -0700, Jeff Kirsher wrote: Jesper - I have pulled in your patches, and made the necessary modifications based on Mitch's comments.  Right now, they are in testing and I should be pushing

Re: [E1000-devel] [RFC] e1000e: handle msi-x tx complete in tasklet

2009-05-21 Thread Jeff Kirsher
On Tue, May 19, 2009 at 2:50 PM, Stephen Hemminger shemmin...@vyatta.com wrote: The e1000e driver has three forms of interrupt handling for transmit completions: msi-x, msi and legacy mode. In msi and legacy mode, tx completion is managed via the receive NAPI routine, but msi-x mode transmit

Re: [E1000-devel] [RFC] e1000e: handle msi-x tx complete in tasklet

2009-06-02 Thread Jeff Kirsher
On Thu, May 21, 2009 at 5:22 PM, Jeff Kirsher jeffrey.t.kirs...@intel.com wrote: On Thu, May 21, 2009 at 5:07 PM, Stephen Hemminger shemmin...@vyatta.com wrote: The e1000e driver has three forms of interrupt handling for transmit completions: msi-x, msi and legacy mode. In msi and legacy mode

Re: [E1000-devel] [patch] e1000e: Call e1000e_config_collision_dist() after TCTL has been set

2009-06-02 Thread Jeff Kirsher
On Tue, May 19, 2009 at 12:27 AM, Simon Horman ho...@verge.net.au wrote: e1000e_config_collision_dist() sets tctl, but subsequently tctl is overwritten. It seems to me that as things stand the call to e1000e_config_collision_dist() has no effect and should either be removed or moved down a

Re: [E1000-devel] [PATCH] ixgbe: fix mismatched dma map/unmap size

2009-06-11 Thread Jeff Kirsher
On Thu, Jun 11, 2009 at 3:20 AM, David Millerda...@davemloft.net wrote: From: Chris Wright chr...@sous-sol.org Date: Tue, 9 Jun 2009 10:11:51 -0700 DMA buffer is mapped w/ NET_IP_ALIGN accounted, unmapped w/out. Dma debugging generates this warning.  Simple fix below. [   76.356509] ixgbe

Re: [E1000-devel] [PATCH] e1000e: fix use of pci_enable_pcie_error_reporting

2009-08-13 Thread Jeff Kirsher
On Fri, Aug 7, 2009 at 02:36, Xiaotian Fengdf...@redhat.com wrote: commit 111b9dc5 introduces pcie aer support for e1000e, but it is not reasonable to disable it in e1000_remove but enable it in e1000_resume. This patch enables aer support in e1000_probe. Signed-off-by: Xiaotian Feng

Re: [E1000-devel] [PATCH] e1000e: Fix PCIE error message

2009-10-01 Thread Jeff Kirsher
On Wed, Sep 30, 2009 at 14:28, Frans Pop elen...@planet.nl wrote: Tim Gardner wrote: Subject: [PATCH] e1000e: Fix PCIE error message BugLink: http://bugs.launchpad.net/bugs/436370 The error returned by pci_enable_pcie_error_reporting() is ignored, so print a notice instead of an error.

Re: [E1000-devel] [Bug #14261] e1000e jumbo frames no longer work: 'Unsupported MTU setting'

2009-10-02 Thread Jeff Kirsher
On Fri, Oct 2, 2009 at 14:31, Rafael J. Wysocki r...@sisk.pl wrote: On Friday 02 October 2009, Nix wrote: On 1 Oct 2009, Rafael J. Wysocki stated: The following bug entry is on the current list of known regressions introduced between 2.6.30 and 2.6.31.  Please verify if it still should be

Re: [E1000-devel] [Bug #14261] e1000e jumbo frames no longer work: 'Unsupported MTU setting'

2009-10-07 Thread Jeff Kirsher
On Wed, Oct 7, 2009 at 11:34, Theodore Tso ty...@mit.edu wrote: On Fri, Oct 02, 2009 at 03:13:07PM -0700, Jeff Kirsher wrote: Patch               : http://patchwork.kernel.org/patch/50277/ Most likely because it's not in the Linus' tree yet. [e1000e maintainers, we have a regression

Re: [E1000-devel] [PATCH] e1000: the power down when running ifdown command

2009-11-03 Thread Jeff Kirsher
2009/11/3 Naohiro Ooiwa noo...@miraclelinux.com: Jeff Kirsher wrote: 2009/10/31 Naohiro Ooiwa noo...@miraclelinux.com: I have added this patch to my tree for testing.  This patch requires a fair amount of regression testing, so once its passed testing I will push the patch to David/netdev

Re: [E1000-devel] [PATCH] e1000e: Use sizeof struct rather than pointer in e1000_get_eeprom()

2009-11-23 Thread Jeff Kirsher
On Sun, Nov 22, 2009 at 06:31, Roel Kluin roel.kl...@gmail.com wrote: Don't use the sizeof the pointer to clear the result Signed-off-by: Roel Kluin roel.kl...@gmail.com ---  drivers/net/e1000e/ethtool.c |    3 ++-  1 files changed, 2 insertions(+), 1 deletions(-) -            

Re: [E1000-devel] [rfc 1/3 v2] [rfc 1/4] igb: Add igb_cleanup_vf()

2009-11-24 Thread Jeff Kirsher
On Tue, Nov 24, 2009 at 22:32, Simon Horman ho...@verge.net.au wrote: Move virtual finction cleanup code into igb_cleanup_vf() and for the sake of symmetry rename igb_probe_vfs() as igb_init_vf(). Although these functions aren't entirely symmetrical it should aid maintenance by making the

Re: [E1000-devel] [PATCH 1/3] e1000: increase skb size to prevent dma over skb boundary (v2)

2009-12-07 Thread Jeff Kirsher
On Mon, Dec 7, 2009 at 07:59, Neil Horman nhor...@tuxdriver.com wrote: On Mon, Dec 07, 2009 at 04:24:02PM +0100, Franco Fichtner wrote: Hi Neil, Neil Horman wrote: Update e1000 driver to not allow dma beyond the end of the allocated skb     Signed-off-by: Neil Horman nhor...@tuxdriver.com

Re: [E1000-devel] [PATCH 2/3] e1000e: increase skb size to prevent dma over skb boundary (v2)

2009-12-07 Thread Jeff Kirsher
On Mon, Dec 7, 2009 at 08:02, Neil Horman nhor...@tuxdriver.com wrote: Sorry to reply to myself, but given the comments regarding the e1000 driver, I should take the same changes into account here.  New version of the patch, much cleaner than previously. Update e1000e driver to not allow

Re: [E1000-devel] [PATCH] e1000: Fix tests of unsigned in e1000_tx_map()

2009-12-22 Thread Jeff Kirsher
On Tue, Dec 15, 2009 at 11:02, Roel Kluin roel.kl...@gmail.com wrote: The variables count and i are unsigned so the (|=) 0 tests do not work. Signed-off-by: Roel Kluin roel.kl...@gmail.com --- Found using coccinelle: http://coccinelle.lip6.fr/ This should be all with this pattern. As

Re: [E1000-devel] [PATCH] e1000: enhance frame fragment detection

2009-12-28 Thread Jeff Kirsher
On Mon, Dec 28, 2009 at 12:10, Neil Horman nhor...@tuxdriver.com wrote: Hey all-        A security discussion was recently given: http://events.ccc.de/congress/2009/Fahrplan//events/3596.en.html And a patch that I submitted awhile back was brought up.  Apparently some of their testing

Re: [E1000-devel] [PATCH 2/2] e1000: Fix DMA mapping error handling on RX

2010-01-22 Thread Jeff Kirsher
On Thu, Jan 21, 2010 at 03:44, Anton Blanchard an...@samba.org wrote: Check for error return from pci_map_single/pci_map_page and clean up. With this and the previous patch the driver was able to handle a significant percentage of errors (I set the fault injection rate to 10% and could still

Re: [E1000-devel] [PATCH 1/1] e1000e: stop cleaning when we reach tx_ring-next_to_use

2010-04-01 Thread Jeff Kirsher
On Thu, 2010-04-01 at 19:33 -0700, David Miller wrote: From: Terry Loftin terry.lof...@hp.com Date: Wed, 31 Mar 2010 14:01:52 -0600 Tx ring buffers after tx_ring-next_to_use are volatile and could change, possibly causing a crash. Stop cleaning when we hit tx_ring-next_to_use.

Re: [E1000-devel] [PATCH 1/2 resend] igb: dobule increment nr_frags

2010-04-15 Thread Jeff Kirsher
On Thu, Apr 15, 2010 at 02:06, Koki Sanagi sanagi.k...@jp.fujitsu.com wrote: Previous patch has some mail format problem. Maybe I've fixed and re-sent. There is no need to increment nr_frags becasue skb_fill_page_desc increments it. Signed-off-by: Koki Sanagi sanagi.k...@jp.fujitsu.com ---

Re: [E1000-devel] [PATCH 2/2] igbvf: dobule increment nr_frags

2010-04-15 Thread Jeff Kirsher
2010/4/15 Koki Sanagi sanagi.k...@jp.fujitsu.com: There is no need to increment nr_frags becasue skb_fill_page_desc increments it. Signed-off-by: Koki Sanagi sanagi.k...@jp.fujitsu.com ---  drivers/net/igbvf/netdev.c |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) Thanks I

Re: [E1000-devel] [PATCH] ixgb and e1000: Use new function for copybreak tests

2010-05-03 Thread Jeff Kirsher
On Sun, May 2, 2010 at 17:46, Joe Perches j...@perches.com wrote: There appears to be an off-by-1 defect in the maximum packet size copied when copybreak is speified in these modules. The copybreak module params are specified as: Maximum size of packet that is copied to a new buffer on

Re: [E1000-devel] [PATCH net-next] ixgbe: return error in set_rar when index out of range

2010-05-18 Thread Jeff Kirsher
IXGBE_ERR_blah instead and there is another spot where this could be used. Instead I propose this patch instead... ixgbe: return IXGBE_ERR_RAR_INDEX when out of range From: Jeff Kirsher jeffrey.t.kirs...@intel.com Based on patch from Shirley Ma x...@us.ibm.com Return IXGBE_ERR_RAR_INDEX when RAR index

Re: [E1000-devel] [PATCH net-next] ixgbe: make macvlan on PF working when SRIOV is enabled

2010-05-25 Thread Jeff Kirsher
On Tue, May 25, 2010 at 09:55, Shirley Ma mashi...@us.ibm.com wrote: When SRIOV is enabled, if we create macvlan on PF and load the VF driver in host domain, when macvlan/PF and VF interfaces are all up, the macvlan incoming network traffics are directed to VF interface not PF interface.

Re: [E1000-devel] [PATCH] drivers/net/e1000/e1000_main.c: Fix message logging defect

2010-06-11 Thread Jeff Kirsher
On Thu, Jun 10, 2010 at 23:29, Joe Perches j...@perches.com wrote: commit 675ad47375c76a7c3be4ace9554d92cd55518ced removed the capability to use ethtool.set_msglevel to control the types of messages emitted by the driver. That commit should probably be reverted. If not, then this patch

Re: [E1000-devel] [PATCH] Re: mmotm 2010-07-19 - e1000e vs. pm_qos_update_request issues

2010-07-22 Thread Jeff Kirsher
On Wed, Jul 21, 2010 at 00:12, Florian Mickler flor...@mickler.org wrote: On Tue, 20 Jul 2010 14:07:51 -0700 Andrew Morton a...@linux-foundation.org wrote: On Tue, 20 Jul 2010 16:35:25 -0400 valdis.kletni...@vt.edu wrote: On Mon, 19 Jul 2010 16:38:09 PDT, a...@linux-foundation.org said:

Re: [E1000-devel] [PATCH 1/2] ixgbe: fix parameters in distributing budget to each RX queue fairly

2010-07-27 Thread Jeff Kirsher
are trying to fix is still an issue with the latest upstream kernel? Cheers, Jeff Kirsher -- The Palm PDK Hot Apps Program offers developers who use the Plug-In Development Kit to bring their C/C++ apps to Palm for a share

Re: [E1000-devel] [PATCH] Add missing memory barriers to clean_rx_irq functions in Intel Drivers

2010-07-27 Thread Jeff Kirsher
On Tue, Jul 27, 2010 at 15:34, Sonny Rao sonny...@us.ibm.com wrote: This patch is similar to what was fixed in ixgbe in this patch: http://marc.info/?l=e1000-develm=126593062701537w=3 We should add read memory barriers to all the similar cases across the Intel ethernet driver family.  In the

Re: [E1000-devel] [PATCHv2] Add missing memory barriers to clean_rx_irq functions in Intel Drivers

2010-07-27 Thread Jeff Kirsher
On Tue, Jul 27, 2010 at 15:44, Sonny Rao sonny...@us.ibm.com wrote: Add missing memory barriers to clean_rx_irq functions in Intel Drivers This patch is similar to what was fixed in ixgbe in this patch: http://marc.info/?l=e1000-develm=126593062701537w=3 We should add read memory barriers

Re: [E1000-devel] [PATCH] Add missing memory barriers to clean_rx_irq functions in Intel Drivers

2010-07-27 Thread Jeff Kirsher
On Tue, Jul 27, 2010 at 15:46, Sonny Rao sonny...@us.ibm.com wrote: On Tue, Jul 27, 2010 at 03:41:46PM -0700, Jeff Kirsher wrote: On Tue, Jul 27, 2010 at 15:34, Sonny Rao sonny...@us.ibm.com wrote: This patch is similar to what was fixed in ixgbe in this patch: http://marc.info/?l=e1000

Re: [E1000-devel] [PATCHv3] Add missing memory barriers to clean_rx_irq functions in Intel Drivers

2010-07-27 Thread Jeff Kirsher
On Tue, Jul 27, 2010 at 16:05, Sonny Rao sonny...@us.ibm.com wrote: On Tue, Jul 27, 2010 at 03:45:42PM -0700, Jeff Kirsher wrote: You also seem to be missing igb. This patch is similar to what was fixed in ixgbe in this patch: http://marc.info/?l=e1000-develm=126593062701537w=3 We should

Re: [E1000-devel] [patch -next] ixgbe: potential null dereference

2010-07-27 Thread Jeff Kirsher
On Tue, Jul 27, 2010 at 03:05, Dan Carpenter erro...@gmail.com wrote: The e_dev_err() macro dereferences adapter which is NULL here. Signed-off-by: Dan Carpenter erro...@gmail.com Acked-by: Jeff Kirsher jeffrey.t.kirs...@intel.com

Re: [E1000-devel] [PATCH net-next 1/3] drivers/net/ixgbe/ixgbe_main.c: Checkpatch cleanups

2010-08-23 Thread Jeff Kirsher
On Sun, Aug 22, 2010 at 20:34, David Miller da...@davemloft.net wrote: I'll let the Intel folks integrate these 3 patches. Thanks Joe. -- Thanks Joe, I have added the patches to my queue. -- Cheers, Jeff -- Sell

Re: [E1000-devel] [PATCH] e1000e: Intel 82571EB: Don't wait for MNG cycle on unmanaged chips

2010-08-29 Thread Jeff Kirsher
On Fri, Aug 27, 2010 at 12:10, Kyle Moffett kyle.d.moff...@boeing.com wrote: The Intel 82571EB chipset can be used in an unmanaged configuration as a fast dual-port Gig-E controller.  Unfortunately a board constructed that way would fail to correctly come up because the driver polls for the

Re: [E1000-devel] [PATCH] e1000e: convert to stats64

2010-12-15 Thread Jeff Kirsher
On Tue, Dec 14, 2010 at 12:32, Flavio Leitner fleit...@redhat.com wrote: Provides accurate stats at the time user reads them. Signed-off-by: Flavio Leitner fleit...@redhat.com ---  drivers/net/e1000e/e1000.h   |    5 ++-  drivers/net/e1000e/ethtool.c |   27 +---  

Re: [E1000-devel] [PATCH v2] e1000e: convert to stats64

2010-12-16 Thread Jeff Kirsher
On Thu, Dec 16, 2010 at 04:31, Flavio Leitner fleit...@redhat.com wrote: On Tue, Dec 14, 2010 at 10:29:33PM +0100, Eric Dumazet wrote: Le mardi 14 décembre 2010 à 18:32 -0200, Flavio Leitner a écrit : Provides accurate stats at the time user reads them. Signed-off-by: Flavio Leitner

Re: [E1000-devel] [PATCH 0/3] igb: cleanup and code deduplication

2011-03-29 Thread Jeff Kirsher
On Tue, Mar 29, 2011 at 06:09, Stefan Assmann sassm...@kpanic.de wrote: Some cleanups for igb. First patch is just a simple typo fix. Second patch turns igb_update_nvm_checksum and igb_validate_nvm_checksum into wrapper functions to deduplicate code. Third patch puts the thermal sensor code

Re: [E1000-devel] [PATCH] e1000e: fix stats locking in e1000_watchdog_task

2011-04-04 Thread Jeff Kirsher
On Fri, Apr 1, 2011 at 11:16, Flavio Leitner fleit...@redhat.com wrote: Just move the unlock down a bit because it unlocks too early leaving a chance for get_stats64() run in parallel while it is still accessing the stats. Signed-off-by: Flavio Leitner fleit...@redhat.com ---  

Re: [E1000-devel] Support e1000 M88 PHY registers in -d

2011-04-04 Thread Jeff Kirsher
On Sat, Apr 2, 2011 at 09:24, Ben Hutchings bhutchi...@solarflare.com wrote: Anthony, I'm now upstream maintainer for ethtool so I've picked up your patch again. On Fri, 2010-03-19 at 00:32 -0400, Anthony DeRobertis wrote: Package: ethtool Version: 1:2.6.33-1 Severity: wishlist The M88

Re: [E1000-devel] [RFT PATCH] net: remove legacy ethtool ops

2011-05-07 Thread Jeff Kirsher
2011/5/7 Michał Mirosław mirq-li...@rere.qmqm.pl: As all drivers are converted, we may now remove discrete offload setting callback handling. Signed-off-by: Michał Mirosław mirq-li...@rere.qmqm.pl --- Note: This needs to wait for Intel guys to finish conversion of their LAN drivers.  

Re: [E1000-devel] [PATCH] ixgbe: Report PAUSE flags to ethtool

2011-06-09 Thread Jeff Kirsher
On Mon, Jun 6, 2011 at 04:52, Esa-Pekka Pyokkimies esa-pekka.pyokkim...@stonesoft.com wrote: Hello! I noticed that ixgbe driver doesn't report SUPPORTED_Pause and ADVERTISED_Pause flags to ethtool. This means that ethtool always reports:        Supported pause frame use: No        

Re: [E1000-devel] [PATCH] fix WOL on 2nd port on i350

2011-07-06 Thread Jeff Kirsher
On Mon, Jul 4, 2011 at 07:17, Martin Wilck martin.wi...@ts.fujitsu.com wrote: WOL fails on second port of a i350 network adapter with the latest upstream kernel driver. It works with the sf.net driver 3.0.19. The following patch seems to be missing upstream. Regards, Martin -- Dr. Martin

Re: [E1000-devel] ixgbe: not accepting any packets - increasing rx_missed_errors

2011-07-28 Thread Jeff Kirsher
On Thu, Jul 28, 2011 at 01:41, martin_zielin...@mcafee.com wrote: Hello, With a 82559EB card a customer often comes into the situation that no packet can be received anymore until network restart. The symptom is that the rx_missed_errors register counts each packet but no more packets can

Re: [E1000-devel] Unicast hash for IXGBEVF driver

2011-08-27 Thread Jeff Kirsher
On Sat, Aug 27, 2011 at 00:23, J.Hwan Kim frog1...@gmail.com wrote: Hi, everyone How can I distribute the packets according to destination MAC address into multi-virtual fucntion queue? Now, my setting is that all bit of PFUTA are '1' and ROPE bit is 1, so all mac packet is duplicated to all

Re: [E1000-devel] Regarding - Detected Tx Unit Hang

2011-09-29 Thread Jeff Kirsher
On Thu, Sep 29, 2011 at 05:05, Indira ramasamy vel.ind...@gmail.com wrote: Hi,  I am using e1000e driver(version: 0.4.1.12-NAPI, firmware-version: 5.10-2) . In dmesg I am seeing :00:19.0: eth0: Detected Tx Unit Hang:  TDH                  b7  TDT                  a3  next_to_use        

Re: [E1000-devel] [PATCH 1/2] e1000e: Disable ASPM L1 on 82574

2012-04-23 Thread Jeff Kirsher
On Mon, 2012-04-23 at 22:29 +0100, Chris Boot wrote: ASPM on the 82574 causes trouble. Currently the driver disables L0s for this NIC but only disables L1 if the MTU is 1500. This patch simply causes L1 to be disabled regardless of the MTU setting. Signed-off-by: Chris Boot

Re: [E1000-devel] [PATCH 2/2] e1000e: Remove special case for 82573/82574 ASPM L1 disablement

2012-04-23 Thread Jeff Kirsher
On Mon, 2012-04-23 at 22:29 +0100, Chris Boot wrote: For the 82573, ASPM L1 gets disabled wholesale so this special-case code is not required. For the 82574 the previous patch does the same as for the 82573, disabling L1 on the adapter. Thus, this code is no longer required and can be

Re: [E1000-devel] [PATCH] e1000e: MSI interrupt test failed, using legacy interrupt

2012-04-26 Thread Jeff Kirsher
On Thu, 2012-04-26 at 17:42 -0700, Prasanna Panchamukhi wrote: On 04/26/2012 05:20 PM, Jeff Kirsher wrote: On 04/26/2012 05:05 PM, prasanna.panchamu...@riverbed.com wrote: From: Prasanna S. Panchamukhippanchamu...@riverbed.com Following logs where seen on Systems with multiple NICs ports

Re: [E1000-devel] [PATCH] e1000e: MSI interrupt test failed, using legacy interrupt

2012-04-26 Thread Jeff Kirsher
On 04/26/2012 05:05 PM, prasanna.panchamu...@riverbed.com wrote: From: Prasanna S. Panchamukhi ppanchamu...@riverbed.com Following logs where seen on Systems with multiple NICs ports, while using MSI interrupts as shown below: Feb 16 15:09:32 (none) user.notice kernel: :00:0d.0: lan0_0:

Re: [E1000-devel] [PATCH BUG-FIX] igbvf: fix the bug when initializing the igbvf

2012-04-27 Thread Jeff Kirsher
On Fri, 2012-04-27 at 16:58 +0800, Shan Wei wrote: From: Samuel Liao samuell...@tencent.com Maybe it's a typo, but it cause that igbvf can't be initialized successfully. Set perm_addr value using valid dev_addr, although which is equal to hw.mac.addr. Signed-off-by: Samuel Liao

Re: [E1000-devel] e1000e tx queue timeout in 3.3.0 (bisected to BQL support for e1000e)

2012-05-01 Thread Jeff Kirsher
On Tue, 2012-05-01 at 15:08 -0700, Ben Greear wrote: On 05/01/2012 02:49 PM, David Miller wrote: From: Ben Greeargree...@candelatech.com Date: Tue, 01 May 2012 14:10:43 -0700 On 04/20/2012 02:56 PM, Ben Greear wrote: On 04/20/2012 02:21 PM, Tom Herbert wrote: Thanks John for pointers

Re: [E1000-devel] e1000e tx queue timeout in 3.3.0 (bisected to BQL support for e1000e)

2012-05-01 Thread Jeff Kirsher
On Tue, 2012-05-01 at 18:46 -0400, David Miller wrote: From: Jeff Kirsher jeffrey.t.kirs...@intel.com Date: Tue, 01 May 2012 15:42:28 -0700 I will take care of the stable submission's Ben. Actually, Jeff, hold off on that. I misread Ben's email and didn't see that these were

Re: [E1000-devel] e1000e-1.9.5 didn't recognize 82579LM in SLES11.1 Network Settings

2012-05-09 Thread Jeff Kirsher
On Tue, 2012-05-08 at 13:46 +0800, Miller Liu wrote: Hi Jefferey: Need your help again. Could you please help to look into this? It appears 82579LM is not recognized in SLES 11.1 64bit Network Settings. But if I use lspci command, 82579LM can be displayed. I will try the 1.10.6 to

Re: [E1000-devel] [PATCH 2/2 v2] net/e1000: look in the page and not in skb-data for the last byte

2012-05-11 Thread Jeff Kirsher
On Fri, 2012-05-11 at 08:45 +0200, Sebastian Andrzej Siewior wrote: The code seems to want to look at the last byte where the HW puts some information. Since the skb-data area is never seen by the HW I guess it does not work as expected. We pass the page address to the HW so I *think* in

Re: [E1000-devel] [PATCH] net/e1000: look into the page instead of skb-data for e1000_tbi_adjust_stats()

2012-05-14 Thread Jeff Kirsher
On Mon, 2012-05-14 at 20:42 +0200, Sebastian Andrzej Siewior wrote: This is another fixup where the data is not transfered into buffer addressed by skb-data but into a page. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- Jeff, I just noticed it. Again, now HW here. Feel

Re: [E1000-devel] [next-net PATCH] drivers/net/ethernet/intel/e1000e: fix unregistered net_device ethX name output by e1000e

2012-06-06 Thread Jeff Kirsher
On Wed, 2012-06-06 at 22:57 +0800, Ethan Zhao wrote: commit ca3ccc6835943287b6f69e973c126a02bc4de409 Author: ethan.zhao ethan.ker...@gmail.com Date: Wed Jun 6 07:32:11 2012 -0700 modified: drivers/net/ethernet/intel/e1000e/param.c While e1000e_check_options() is called,

Re: [E1000-devel] [PATCH] e1000: save skb counts in TX to avoid cache misses

2012-06-07 Thread Jeff Kirsher
On 06/07/2012 02:43 PM, David Miller wrote: From: Jeff Kirsher tar...@gmail.com Date: Thu, 07 Jun 2012 14:38:17 -0700 Thanks! I have applied the patch to my queue Why? My impression is that this is a patch already in the tree, and it's being submitted for -stable but such minor performance

Re: [E1000-devel] [PATCH] e1000: save skb counts in TX to avoid cache misses

2012-06-07 Thread Jeff Kirsher
cleaning tx in e1000_clean_tx_irq use the values in the associated buffer_info for statistics counting, this eliminates cache misses on skb fields. Signed-off-by: Dean Nelson dnel...@redhat.com Acked-by: Jeff Kirsher jeffrey.t.kirs...@intel.com Signed-off-by: David

Re: [E1000-devel] e1000e Driver for Linux Kernel 2.4.4

2012-06-08 Thread Jeff Kirsher
On Fri, 2012-06-08 at 10:04 +0200, Daniel Forrer wrote: Hi Everyone Is there a senior network programmer around, which maybe can help us? We are running an old Linux Kernel 2.4.4 with some RTLinux extension and we have to migrate this system to a new hardware, equipped with Intels

Re: [E1000-devel] [PATCH 1/2 net-next] ixgbe: use skb_padto

2012-06-18 Thread Jeff Kirsher
On Mon, 2012-06-18 at 10:58 -0700, Stephen Hemminger wrote: The code to pad packets here is the same effective code as the existing inline function skb_padto(). There is a minor performance gain since skb_padto() also uses unlikely(). Signed-off-by: Stephen Hemminger shemmin...@vyatta.com

Re: [E1000-devel] [PATCH 2/2 net-next] ixgbe: remove xmit length check

2012-06-18 Thread Jeff Kirsher
On Mon, 2012-06-18 at 11:55 -0700, Stephen Hemminger wrote: The check here is bogus. Since len is unsigned, it can never be negative. And it would be a bug in network stack to ever send a zero length packet to device. Signed-off-by: Stephen Hemminger shemmin...@vyatta.com Thanks, I have

Re: [E1000-devel] [PATCH net-next] ixgbe: simplify padding and length checks (v2)

2012-06-19 Thread Jeff Kirsher
On Mon, 2012-06-18 at 16:31 -0700, Stephen Hemminger wrote: The check for length = 0 is bogus because length is unsigned, and network stack never sends zero length packets (unless it is totally broken). The check for really small packets can be optimized (using unlikely) and calling skb_pad

Re: [E1000-devel] Intel e1000 ethernet device, change in kernel v3.4, and jumbo frames setting DENIED.

2012-07-06 Thread Jeff Kirsher
On 07/05/2012 04:53 PM, D. Stussy wrote: Henrique de Moraes Holschuh wrote in message news:jjgoo-7l0...@gated-at.bofh.it... On Wed, 04 Jul 2012, D. Stussy wrote: There has been some changes to the driver such that things like checksum verification is offloaded from the CPU. However, this

  1   2   3   4   >