Re: [edk2] [PATCH] NetworkPkg: HttpDxe: Address double FreePool issue

Can someone help me with commit of this patch? -Original Message- From: Ye, Ting [mailto:ting...@intel.com] Sent: Thursday, October 29, 2015 6:57 AM To: Hegde, Nagaraj P; edk2-devel@lists.01.org Subject: RE: [edk2] [PATCH] NetworkPkg: HttpDxe: Address double FreePool issue Looks good to

Re: [edk2] [PATCH] NetworkPkg: HttpDxe: Address double FreePool issue

I will help to commit the patch. Thanks for the reminder. Thanks, Ting -Original Message- From: Hegde, Nagaraj P [mailto:nagaraj-p.he...@hpe.com] Sent: Friday, October 30, 2015 2:09 PM To: Ye, Ting; edk2-devel@lists.01.org Subject: RE: [edk2] [PATCH] NetworkPkg: HttpDxe: Address double

Re: [edk2] RE enquote PATH: edk2-devel Digest, Vol 4, Issue 214

Hi Carl, Could you let me know your environment info, os info, etc. actually I can't reproduce the issue. So please help me to reproduce it, thanks. Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Miller, Carl H

Re: [edk2] [PATCH] MdeModulePkg: Fix memory leak issues

Sunny, You could move the two FreePool (FullInstance) to one place which is under the LocateDevicePath() call to make the change smaller a bit. What do you think? Thanks, Ray -Original Message- From: Wang, Sunny (HPS SW) [mailto:sunnyw...@hpe.com] Sent: Friday, October 30, 2015 6:21 PM

Re: [edk2] [PATCH] MdeModulePkg: Add a BDS platform hook function PlatformBootManagerDefaultBootFail to PlatformBootManagerLib

Sunny, I don't like to add a library interface as a short term fix. I will provide a patch next week to enable platform recovery (We are still working on OS recovery) so that you don't need PlatformBootManagerDefaultBootFail() interface. Thanks, Ray -Original Message- From: edk2-devel

[edk2] [PATCH] Add common HTTP definitions for use in HTTP clients/applications. List includes: HTTP methods, request/response headers, and encodings.

Signed-off-by: Samer El-Haj-Mahmoud --- MdeModulePkg/Include/Library/HttpLib.h | 43 ++ 1 file changed, 43 insertions(+) diff --git a/MdeModulePkg/Include/Library/HttpLib.h b/MdeModulePkg/Include/Library/HttpLib.h index

[edk2] [PATCH v2] MdeModulePkg: Add DEBUG statement when reaching max perf log entries

Add a DEBUG statement when the number of PEI perf log entries exceeds PcdMaxPeiPerformanceLogEntries Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud --- MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.c | 2 ++ 1

[edk2] [PATCH] MdeModulePkg: Add DEBUG statement on reaching PEI perf log max entries

Signed-off-by: Samer El-Haj-Mahmoud --- MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.c

Re: [edk2] [PATCH v2] MdeModulePkg: Add some common HTTP definitions

Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Samer El-Haj-Mahmoud > Sent: Friday, October 30, 2015 4:08 PM > To: edk2-devel@lists.01.org > Cc: Tian, Feng ; Samer

[edk2] [PATCH v2] MdeModulePkg: Add some common HTTP definitions

Add common HTTP definitions for use in HTTP clients/applications. List includes: HTTP methods, request/response headers, and encodings. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud ---

Re: [edk2] [PATCH] MdeModulePkg: Add a BDS platform hook function PlatformBootManagerDefaultBootFail to PlatformBootManagerLib

Hi Ray, Yes, I think OS/Platform recovery feature can meet our requirement. However, OS/Platform recovery feature has not yet been completely implemented, so we would like to have a short-term solution for this. Just like Samer said, if you are OK with introducing a new StatusCode in either

[edk2] SecurityPkg: PeiRsa2048Sha256GuidedSectionExtractLib error handling

Dear SecurityPkg maintainer, I'm trying to track down the best way for platform policy to handle an authentication failure in the PEI Rsa2048Sha256 guided section extraction library and ran across this curious state near the end of Rsa2048Sha256GuidedSectionHandler. // // Temp solution

[edk2] [PATCH] MdeModulePkg: PiSmmCore: Remove confusing CopyMem() of SMM_ENTRY_CONTEXT

A subset of fields in the EFI_SMM_SYSTEM_TABLE2 structure are identical to the fields in the SMM_ENTRY_CONTEXT structure. CopyMem() is used to transfer the contents of the SMM_ENTRY_CONTEXT structure into the EFI_SMM_SYSTEM_TABLE2. This is confusing because SMM_ENTRY_CONTEXT is not used in the

Re: [edk2] [PATCH 6/6] OvmfPkg/PlatformPei: Set PcdCpuMaxLogicalProcessorNumber using QEMU fw_cfg

On 10/30/15 14:04, Janusz Mocek wrote: > W dniu 30.10.2015 o 13:26, Laszlo Ersek pisze: >> CC'ing Xiao and Alex again. >> >> On 10/29/15 19:39, Jordan Justen wrote: >>> On 2015-10-29 04:45:37, Laszlo Ersek wrote: On 10/29/15 02:32, Jordan Justen wrote: > +ASSERT (MaxProcessors > 0);

Re: [edk2] [PATCH 6/6] OvmfPkg/PlatformPei: Set PcdCpuMaxLogicalProcessorNumber using QEMU fw_cfg

On 10/30/15 13:26, Laszlo Ersek wrote: >> diff --git a/UefiCpuPkg/CpuDxe/CpuMp.c b/UefiCpuPkg/CpuDxe/CpuMp.c >> index 3f56faa..e7f5b41 100644 >> --- a/UefiCpuPkg/CpuDxe/CpuMp.c >> +++ b/UefiCpuPkg/CpuDxe/CpuMp.c >> @@ -1451,6 +1451,8 @@ ApEntryPointInC ( >>VOID* TopOfApStack; >>

Re: [edk2] [PATCH 6/6] OvmfPkg/PlatformPei: Set PcdCpuMaxLogicalProcessorNumber using QEMU fw_cfg

CC'ing Xiao and Alex again. On 10/29/15 19:39, Jordan Justen wrote: > On 2015-10-29 04:45:37, Laszlo Ersek wrote: >> On 10/29/15 02:32, Jordan Justen wrote: >>> +ASSERT (MaxProcessors > 0); >>> +PcdSet32 (PcdCpuMaxLogicalProcessorNumber, MaxProcessors); >> >> I think that when this branch

Re: [edk2] about the SMM_S3_RESUME_SMM_64 branch in S3Resume2Pei

Yes, first, thanks the great analysis from Laszlo. Is that possible to eliminate the assumption by parsing current GDT entry? Instead of hardcode 0x38 or 0x28, if PiSmmCpu inherits GDT from other module, should it parse GDT to get correct long mode segment? I do not object the idea to change

Re: [edk2] about the SMM_S3_RESUME_SMM_64 branch in S3Resume2Pei

Jiewen, Yes. That is a longer term goal for the PiSmmCpuDxeSmm. Making the GDTs consistent helps debug and is a fix that works until we can add logic to PiSmmCpuiDxeSmm to inherit current GDT information and use it throughout this module. Thanks, Mike >-Original Message- >From:

Re: [edk2] [Patch] MdeModulePkg: Fix a PciBusDxe hot plug bug

Hi Ray, Many thanks for this. On Fri, Oct 30, 2015 at 04:53:54AM +, Ni, Ruiyu wrote: > Ok I will revert the two patches I committed (big patch + small > patch). But I want to clarify one thing that not every big patch can > be easily understood by just splitting to small patches. Certainly,

[edk2] [PATCH] UefiCpuPkg: PiSmmCpuDxeSmm: Remove Framework compatibility

The PiSmmCpuDxeSmm module is using PcdFrameworkCompatibilitySupport to provide compatibility with the SMM support in the IntelFrameworkPkg. This change removes the Framework compatibility and requires all SMM modules that provide SMI handlers to follow the PI Specification. Contributed-under: