[edk2] [PATCH] Nt32Pkg: Fix asserts from running Nt32 64-bit on Win8

On Windows 8, 64-bit NT32 images are loaded above 4GB. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Cinnamon Shia --- Nt32Pkg/Nt32Pkg.dsc | 4 Nt32Pkg/Sec/SecMain.c | 3 ++-

Re: [edk2] [PATCH] Nt32Pkg: Fix asserts from running Nt32 64-bit on Win8

Good enhancement. Have BuildCpuHob (52, 16) impact on normal 32bit NT32 image? Thanks Liming -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Cinnamon Shia Sent: Tuesday, January 19, 2016 5:02 PM To: edk2-devel@lists.01.org Subject: [edk2]

Re: [edk2] [PATCH 0/2] DP: Use Image->FilePath to get name for SMM drivers

On 2016/1/19 18:04, Laszlo Ersek wrote: On 01/18/16 07:02, Star Zeng wrote: This enhancement is to use the FilePath field in the loaded image protocol to find the name of an image as a fallback for when the loaded image device path protocol is not installed on the image handle. This is

Re: [edk2] [PATCH 0/2] MdeModulePkg/.../IdeMode: restore handling of "short reads"

On 01/19/16 01:34, Laszlo Ersek wrote: > The series > > [edk2] [patch 0/2] Fix a DVD device compatbility issue > http://thread.gmane.org/gmane.comp.bios.edk2.devel/3681 > > fixed an IDE timeout masking (misreporting) bug in the AtaAtapiPassThru > driver. (And, separately, it increased SCSI

Re: [edk2] [Patch] Vlv2DeviceRefcodePkg:Add setup option to control _STA of LPE Audio

It's good. Reviewed-by: zwei4 Thanks, David | SSG BIOS -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of lushifex Sent: Tuesday, January 19, 2016 11:00 AM To: edk2-devel@lists.01.org Subject: [edk2] [Patch]

Re: [edk2] [PATCH 0/2] MdeModulePkg/.../IdeMode: restore handling of "short reads"

On 01/19/16 06:40, Tian, Feng wrote: > Laszlo & John > > Thanks for your detail analysis. It's very helpful for me. > > Reviewed-by: Feng Tian Thank you! I'll soon commit the patches with your R-b. > I am thinking shall we update > EFI_SCSI_INQUIRY_DATA/ATAPI_INQUIRY_DATA

Re: [edk2] [PATCH 0/2] DP: Use Image->FilePath to get name for SMM drivers

On 01/18/16 07:02, Star Zeng wrote: > This enhancement is to use the FilePath field in the loaded image > protocol to find the name of an image as a fallback for when the > loaded image device path protocol is not installed on the image handle. > This is necessary because the SMM core does not

Re: [edk2] [Patch] edk2: Update the maintainer list.

On 01/19/16 02:40, Jiaxin Wu wrote: > This patch is used to update the CryptoPkg and NetworkPkg > maintainer list. > > Cc: Long Qin > Cc: Fu Siyuan > Cc: Tian Hot > Cc: Li Ruth > Contributed-under: TianoCore

Re: [edk2] [patch 1/2] MdeModulePkg/Ide: return correct status when DRQ is not ready for ATAPI

On 19/01/2016 00:29, Laszlo Ersek wrote: >> INQUIRY works slightly different from other commands. It has a maximum >> length instead of a deterministic length; once HCYL/LCYL are read back, >> should RequiredBytes not be adjusted in this case? (This way we don't >> short the loop, we just finish

Re: [edk2] [PATCH] CryptoPkg: Fix function qsort for non 32-bit machines

Shouldn't we also update the MdeModulePkg header and implementation where that is copied from if we are changing the way it works? Sidenote: why does CryptoPkg carry a separate quick sort implementation? Is it worth just using the MdeModulePkg BaseSortLib? That library used to be in

Re: [edk2] [PATCH 2/2] ShellPkg UefiDpLib: Use Image->FilePath to get name for SMM drivers

for the series. Reviewed-by: Jaben Carsey > -Original Message- > From: Zeng, Star > Sent: Sunday, January 17, 2016 10:02 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Carsey, Jaben > ; Qiu, Shumin

Re: [edk2] [PATCH 0/3] MdeModulePkg: fix cursor movement keys on ARM FVP / Juno

On 19 January 2016 at 14:10, Ard Biesheuvel wrote: > On 19 January 2016 at 14:53, Laszlo Ersek wrote: >> In this series I've rounded up the ideas & fixes from the recent >> discussion, started by Ryan's problem report. The commit messages are >>

Re: [edk2] [PATCH] CryptoPkg: Fix function qsort for non 32-bit machines

Hi, Jaben! The function PerformQuickSort (in MdeModulePkg\Include\Library\SortLib.h) is correct, since both PerformQuickSort and QuickSortWorker use the same function type for their comparison function pointer. Kind regards, Arthur. -Original Message- From: Carsey, Jaben

Re: [edk2] [PATCH] CryptoPkg: Fix function qsort for non 32-bit machines

Hello! Unless it is guaranteed an "int" will always have exactly 32-bits, using "INT32" instead of "int" does not guarantee the algorithm will work for machines where an "int" is not a 32-bit integer. Thanks for your attention! Kind regards, Arthur. -Original Message- From: Long, Qin

Re: [edk2] [PATCH] Nt32Pkg: Fix asserts from running Nt32 64-bit on Win8

Hi Liming, According to my tests, no, 32-bit NT32 image works fine. It can boot to Shell successfully. Extending the memory space of CPU HOB from 32 to 52 is for letting the resource above 4GB to be added to GCD. Thanks, Cinnamon Shia -Original Message- From: Gao, Liming

Re: [edk2] [PATCH] Maintainers.txt: Update maintainers for SourceLevelDebugPkg

Reviewed-by: Jeff Fan -Original Message- From: Wu, Hao A Sent: Tuesday, January 19, 2016 11:44 AM To: edk2-devel@lists.01.org; Fan, Jeff; Gao, Liming; Tian, Hot Cc: Wu, Hao A Subject: [PATCH] Maintainers.txt: Update maintainers for SourceLevelDebugPkg

Re: [edk2] [PATCH 0/2] Add NOOPT target in package DSC files

Reviewed-by: Liming Gao -Original Message- From: Wu, Hao A Sent: Wednesday, January 20, 2016 9:33 AM To: edk2-devel@lists.01.org; Gao, Liming Cc: Wu, Hao A Subject: [PATCH 0/2] Add NOOPT target in package DSC files Add NOOPT option in BUILD_TARGETS within package

Re: [edk2] [PATCH] CryptoPkg: Fix function qsort for non 32-bit machines

Yes, this issue was there because CRT qsort() is using "int" as function return type, but we define the "INTN" for it. In original BaseSortLib, the return types are consistent. For int or INT32, I have no strong opinion. Int will be 4-byte except under IPL64 data model. Authur, the patch is

Re: [edk2] [PATCH] FatPkg: Add NOOPT target in FatPkg.dsc

Reviewed-by: Liming Gao -Original Message- From: Wu, Hao A Sent: Wednesday, January 20, 2016 9:34 AM To: edk2-devel@lists.01.org; Gao, Liming Cc: Wu, Hao A Subject: [PATCH] FatPkg: Add NOOPT target in FatPkg.dsc Contributed-under: TianoCore Contribution Agreement

Re: [edk2] [PATCH] BaseTools: make build report tolerant of FVs specified by name

Hi Eugene, Thanks for your patch. Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Cohen, Eugene [mailto:eug...@hp.com] Sent: Thursday, January 14, 2016 12:01 AM To: edk2-devel@lists.01.org; Zhu, Yonghong; Gao, Liming Subject:

Re: [edk2] [Patch] Update local variable type to avoid potential data overflow.

Hi Eric, The patch is good to me. Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Eric Dong > Sent: Wednesday, January 20, 2016 1:04 PM > To: edk2-devel@lists.01.org > Cc: Tian,

Re: [edk2] [PATCH 06/12] NetworkPkg: Add NOOPT target in NetworkPkg.dsc

Reviewed-by: Ye Ting -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hao Wu Sent: Monday, January 18, 2016 1:18 PM To: edk2-devel@lists.01.org; Gao, Liming Cc: Wu, Hao A Subject: [edk2] [PATCH 06/12] NetworkPkg: Add NOOPT

[edk2] [Patch] Refine the code to avoid potential buffer overflow or use NULL pointer.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong Cc: Liming Gao --- MdeModulePkg/Universal/HiiDatabaseDxe/Image.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git

[edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

The Serial IO protocol instances provided by SerialDxe and consumed by TerminalDxe come with a Mode.ReceiveFifoDepth=1 default setting, as required by UEFI 2.5. Although TerminalDxe calls EFI_SERIAL_IO_PROTOCOL.SetAttributes() in the TerminalDriverBindingStart() and TerminalConInTimerHandler()

[edk2] [PATCH 2/3] MdeModulePkg: SerialDxe: sync EFI_SERIAL_IO_MODE.Timeout with the spec

In "11.8 Serial I/O Protocol", UEFI 2.5 requires: The default attributes for all UART-style serial device interfaces are: (a) 115,200 baud, (b) a 1 byte receive FIFO, (c) a 1,000,000 microsecond timeout per character, (d) no parity, (e) 8 data bits, (f) and 1 stop bit. It also

[edk2] [PATCH 1/3] MdeModulePkg: SerialDxe: lay out mSerialIoMode initializer more nicely

This patch doesn't change behavior; it only modifies whitespace and comments. Cc: Ard Biesheuvel Cc: Ryan Harkin Cc: Leif Lindholm Cc: Star Zeng Contributed-under: TianoCore Contribution

[edk2] [PATCH 0/3] MdeModulePkg: fix cursor movement keys on ARM FVP / Juno

In this series I've rounded up the ideas & fixes from the recent discussion, started by Ryan's problem report. The commit messages are verbose and contain references to the mailing list, so this blurb is long enough already. :) I'd highly appreciate if ARM FVP / Juno users responded with their

Re: [edk2] [PATCH 0/3] MdeModulePkg: fix cursor movement keys on ARM FVP / Juno

On 19 January 2016 at 14:53, Laszlo Ersek wrote: > In this series I've rounded up the ideas & fixes from the recent > discussion, started by Ryan's problem report. The commit messages are > verbose and contain references to the mailing list, so this blurb is > long enough

[edk2] [PATCH] CryptoPkg: Fix function qsort for non 32-bit machines

Although the function qsort receives as an argument a "compare" function which returns an "int", QuickSortWorker (the function used internally by qsort to do its job) receives as an argument a "CompareFunction" which returns an "INTN". In a 32-bit machine, "INTN" is defined as "INT32", which is

[edk2] [RFC] BaseTools Win32 Binaries

Hi Folks, We have received requests to update the version of Microsoft* Visual Studio* to 2015 (Update 1) for building the EDK II BaseTools Win32 Binaries. We would like to make this change by the end of next week (Friday, Jan. 29th, 2016). Please let us know if you believe there is an issue

[edk2] [PATCH 2/2] IntelFspWrapperPkg: Add NOOPT target in IntelFspWrapperPkg.dsc

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- IntelFspWrapperPkg/IntelFspWrapperPkg.dsc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/IntelFspWrapperPkg/IntelFspWrapperPkg.dsc

[edk2] [PATCH 1/2] IntelFspPkg: Add NOOPT target in IntelFspPkg.dsc

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- IntelFspPkg/IntelFspPkg.dsc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/IntelFspPkg/IntelFspPkg.dsc b/IntelFspPkg/IntelFspPkg.dsc index c8c604e..f3b5689 100644 ---

[edk2] [PATCH] FatPkg: Add NOOPT target in FatPkg.dsc

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- FatPkg.dsc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/FatPkg.dsc b/FatPkg.dsc index 483bb8d..403f8fa 100644 --- a/FatPkg.dsc +++ b/FatPkg.dsc @@ -4,7 +4,7 @@ # #

Re: [edk2] [PATCH] CryptoPkg: Fix function qsort for non 32-bit machines

On 01/19/16 16:13, Burigo, Arthur Crippa wrote: > Although the function qsort receives as an argument a "compare" function > which returns an "int", QuickSortWorker (the function used internally by > qsort to do its job) receives as an argument a "CompareFunction" which > returns an "INTN". In a

Re: [edk2] [PATCH] CryptoPkg: Fix function qsort for non 32-bit machines

Thanks for the detailed analysis. The fix makes sense to me. And yes, I also prefer to use INT32 as Laszlo's comment (since we don't consider ILP64 data model), to keep the consistent style in this function declaration. Best Regards & Thanks, LONG, Qin > -Original Message- > From: