Re: [edk2] [Patch 2/3] UefiCpuPkg/CpuMpPei: Dump message if microcode signature not matched

2016-07-01 Thread Fan, Jeff
Mike, Parameter - PeiCpuMpData is added for MicrocodeDetect() in this patch. PeiCpuMpData->MpLock is used to avoid debug message corruption when Aps output debug message in parallel mode. I don't understand why the patch showed in your mail has not the following part of patch. It's maybe the r

Re: [edk2] [Patch 2/3] UefiCpuPkg/CpuMpPei: Dump message if microcode signature not matched

2016-07-01 Thread Mike Maslenkin
Just curious why locking is required here? Looks like some operator missed. On Fri, 2016-07-01 at 15:02 +0800, Jeff Fan wrote: > diff --git a/UefiCpuPkg/CpuMpPei/Microcode.c b/UefiCpuPkg/CpuMpPei/Microcode.c > index 8e7f3b0..51a0737 100644 > --- a/UefiCpuPkg/CpuMpPei/Microcode.c > +++ b/UefiCpuPkg

Re: [edk2] [PATCH 7/7] ShellPkg-UefiShellTftpCommandLib: Replace compiler builtin

2016-07-01 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Shi, Steven > Sent: Tuesday, June 28, 2016 8:19 AM > To: edk2-devel@lists.01.org; Gao, Liming > Cc: Kinney, Michael D ; af...@apple.com > Subject: [edk2] [PATCH 7/7]

Re: [edk2] [Patch 3/3] UefiCpuPkg/CpuMpPei: Remove unnecessary variable

2016-07-01 Thread Mudusuru, Giri P
Reviewed-by: Giri P Mudusuru > -Original Message- > From: Fan, Jeff > Sent: Friday, July 1, 2016 12:02 AM > To: edk2-de...@ml01.01.org > Cc: Kinney, Michael D ; Tian, Feng > ; Mudusuru, Giri P > Subject: [Patch 3/3] UefiCpuPkg/CpuMpPei: Remove unnecessary variable > > Cc: Michael Kinne

Re: [edk2] [Patch 2/3] UefiCpuPkg/CpuMpPei: Dump message if microcode signature not matched

2016-07-01 Thread Mudusuru, Giri P
Thanks Jeff, Please use @param[in] instead of @param. Reviewed-by: Giri P Mudusuru > -Original Message- > From: Fan, Jeff > Sent: Friday, July 1, 2016 12:02 AM > To: edk2-de...@ml01.01.org > Cc: Kinney, Michael D ; Tian, Feng > ; Mudusuru, Giri P > Subject: [Patch 2/3] UefiCpuPkg/CpuM

Re: [edk2] [Patch 1/3] UefiCpuPkg/CpuMpPei: Skip microcode check/load if it has been loaded

2016-07-01 Thread Mudusuru, Giri P
Reviewed-by: Giri P Mudusuru > -Original Message- > From: Fan, Jeff > Sent: Friday, July 1, 2016 12:02 AM > To: edk2-de...@ml01.01.org > Cc: Kinney, Michael D ; Tian, Feng > ; Mudusuru, Giri P > Subject: [Patch 1/3] UefiCpuPkg/CpuMpPei: Skip microcode check/load if it > has been loaded

[edk2] [PATCH v2 1/4] ArmPkg: introduce ArmMmuLib library class

2016-07-01 Thread Ard Biesheuvel
Introduce the library class ArmMmuLib, which encapsulates the functionality to set up and modify page table entries. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPkg/ArmPkg.dec | 1 + ArmPkg/Include/Library/ArmMmuLib.h | 65 ++

[edk2] [PATCH v2 3/4] ArmPkg ArmVirtPkg MdeModulePkg: switch to separate ArmMmuLib

2016-07-01 Thread Ard Biesheuvel
Switch all users of ArmLib that depend on the MMU routines to the new, separate ArmMmuLib. This needs to occur in one go, since the MMU routines are removed from ArmLib build at the same time, to prevent conflicting symbols. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ar

[edk2] [PATCH v2 4/4] ArmPkg/ArmMmuLib: add PEI specific version of ArmMmuLib

2016-07-01 Thread Ard Biesheuvel
This introduces a special version of ArmMmuLib for PEIMs that takes care only to perform cache maintenance on the live entry replacement routine if the module is not executing in place. Not only is such cache maintenance unnecessary in that case, it may be actively harmful on some systems that fail

[edk2] [PATCH v2 2/4] ArmPkg: introduce base ArmMmuLib implementation

2016-07-01 Thread Ard Biesheuvel
This base library encapsulates the MMU manipulation routines that have been factored out of ArmLib. The functionality covers initial creation of the 1:1 mapping in the page tables, and remapping regions to change permissions or cacheability attributes. Contributed-under: TianoCore Contribution Agr

[edk2] [PATCH v2 0/4] ArmPkg: refactor MMU handling routines into separate ArmMmuLib

2016-07-01 Thread Ard Biesheuvel
The MMU routines are only used by a small subset of the users of ArmLib. In order to prevent all those users to have to run the library constructor to clean some MMU handling routines to the PoC, split off all MMU handling into a separate ArmMmuLib. NOTE: this change will affect out-of-tree platfo

Re: [edk2] [PATCH 2/2] ArmPkg/CpuDxe: unmask SErrors in DEBUG builds

2016-07-01 Thread Ard Biesheuvel
On 1 July 2016 at 15:48, Leif Lindholm wrote: > On Fri, Jul 01, 2016 at 01:21:36PM +0200, Ard Biesheuvel wrote: >> On 1 July 2016 at 13:03, Leif Lindholm wrote: >> > On Fri, Jul 01, 2016 at 12:53:13PM +0200, Ard Biesheuvel wrote: >> >> SErrors (formerly called asynchronous aborts) are a distinct

Re: [edk2] [PATCH 2/2] ArmPkg/CpuDxe: unmask SErrors in DEBUG builds

2016-07-01 Thread Leif Lindholm
On Fri, Jul 01, 2016 at 01:21:36PM +0200, Ard Biesheuvel wrote: > On 1 July 2016 at 13:03, Leif Lindholm wrote: > > On Fri, Jul 01, 2016 at 12:53:13PM +0200, Ard Biesheuvel wrote: > >> SErrors (formerly called asynchronous aborts) are a distinct class of > >> exceptions that are not closely tied t

Re: [edk2] [PATCH 4/4] OvmfPkg: add PciHotPlugInitDxe

2016-07-01 Thread Laszlo Ersek
On 07/01/16 03:10, Laszlo Ersek wrote: > +STATIC CONST RESOURCE_PADDING mPadding = { > + // > + // MmioPadding > + // > + { > +ACPI_ADDRESS_SPACE_DESCRIPTOR, // Desc > +(UINT16)( // Len > + sizeof (EFI_ACPI_ADDRESS_SPACE_DESCRIP

Re: [edk2] [PATCH 6/6] Vlv2TbltDevicePkg: fix ASSERT_EFI_ERROR() typos

2016-07-01 Thread Laszlo Ersek
On 07/01/16 13:36, Ard Biesheuvel wrote: > On 29 June 2016 at 09:49, Wei, David wrote: >> Reviewed-by: David Wei >> >> Thanks, >> David Wei >> > > Hi David, > > It seems like Laszlo and you both pushed this patch, and you merged it > rather than rebasing first. > > This means we now have two

[edk2] [PATCH] ArmPlatformPkg: Set Juno debug serial port defaults

2016-07-01 Thread evan . lloyd
From: Evan Lloyd Juno has several serial ports, one of which may be used for a remote debug interface (e.g. gdb, WinDbg). The debug serial port needs to be distinct from that used for UEFI trace to prevent corruption of debugger protocol messaging. The UEFI spec requires that serial devices be i

Re: [edk2] [PATCH 6/6] Vlv2TbltDevicePkg: fix ASSERT_EFI_ERROR() typos

2016-07-01 Thread Ard Biesheuvel
On 29 June 2016 at 09:49, Wei, David wrote: > Reviewed-by: David Wei > > Thanks, > David Wei > Hi David, It seems like Laszlo and you both pushed this patch, and you merged it rather than rebasing first. This means we now have two copies of the same patch, which needlessly obfuscates the GIT

Re: [edk2] [PATCH 2/2] ArmPkg/CpuDxe: unmask SErrors in DEBUG builds

2016-07-01 Thread Ard Biesheuvel
On 1 July 2016 at 13:03, Leif Lindholm wrote: > On Fri, Jul 01, 2016 at 12:53:13PM +0200, Ard Biesheuvel wrote: >> SErrors (formerly called asynchronous aborts) are a distinct class of >> exceptions that are not closely tied to the currently executing >> instruction. Since execution may be able to

Re: [edk2] [PATCH 2/2] ArmPkg/CpuDxe: unmask SErrors in DEBUG builds

2016-07-01 Thread Leif Lindholm
On Fri, Jul 01, 2016 at 12:53:13PM +0200, Ard Biesheuvel wrote: > SErrors (formerly called asynchronous aborts) are a distinct class of > exceptions that are not closely tied to the currently executing > instruction. Since execution may be able to proceed in such a condition, > this class of except

Re: [edk2] [PATCH 2/2] ArmPkg/CpuDxe: unmask SErrors in DEBUG builds

2016-07-01 Thread Mark Rutland
On Fri, Jul 01, 2016 at 12:53:13PM +0200, Ard Biesheuvel wrote: > SErrors (formerly called asynchronous aborts) are a distinct class of > exceptions that are not closely tied to the currently executing > instruction. Since execution may be able to proceed in such a condition, > this class of except

Re: [edk2] [PATCH 1/2] ArmPkg/DefaultExceptionHandlerLib: put ASSERT (FALSE) last

2016-07-01 Thread Leif Lindholm
On Fri, Jul 01, 2016 at 12:53:12PM +0200, Ard Biesheuvel wrote: > Putting DEBUG () code after an ASSERT (FALSE) statement is not very > useful, since the code will be unreachable on DEBUG builds and compiled > out on RELEASE builds. So move the ASSERT () statement after it. > > Contributed-under:

[edk2] [PATCH 1/2] ArmPkg/DefaultExceptionHandlerLib: put ASSERT (FALSE) last

2016-07-01 Thread Ard Biesheuvel
Putting DEBUG () code after an ASSERT (FALSE) statement is not very useful, since the code will be unreachable on DEBUG builds and compiled out on RELEASE builds. So move the ASSERT () statement after it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- A

[edk2] [PATCH 2/2] ArmPkg/CpuDxe: unmask SErrors in DEBUG builds

2016-07-01 Thread Ard Biesheuvel
SErrors (formerly called asynchronous aborts) are a distinct class of exceptions that are not closely tied to the currently executing instruction. Since execution may be able to proceed in such a condition, this class of exception is masked by default, and software needs to unmask it explicitly if

[edk2] Error. The protocol 'gEfiIp4ConfigProtocolGuid' was required and not found

2016-07-01 Thread Aravindhlal G . S . S
Hi Experts, I am not able to config the Ethernet interface in UEFI shell. I am running Shell> teractive Shell v2.1 EDK II UEFI v2.40 (EDK II, 0x0001) The drivers commands list the required driver, but #D is 0 and Type is "?". Am I missing any drivers to be installed ? If so could you please

Re: [edk2] [patch] ShellPkg: Update the error prompt for ping6 command.

2016-07-01 Thread Hegde, Nagaraj P
Reviewed-by: Hegde, Nagaraj P -Original Message- From: Zhang Lubo [mailto:lubo.zh...@intel.com] Sent: Friday, July 01, 2016 11:43 AM To: edk2-devel@lists.01.org Cc: Hegde, Nagaraj P ; Fu Siyuan ; Wu Jiaxin Subject: [patch] ShellPkg: Update the error prompt for ping6 command. when we u

[edk2] [Patch 1/3] UefiCpuPkg/CpuMpPei: Skip microcode check/load if it has been loaded

2016-07-01 Thread Jeff Fan
Actually, there is only one microcode region in platform. If microcode has been loaded, its signature will not be zero and should be loaded successfully. We needn't to check microcode region and load microcode again. This update is to skip checking/loading microcode if current microcode signature i

[edk2] [Patch 0/3] UefiCpuPkg/CpuMpPei: Microcode update

2016-07-01 Thread Jeff Fan
Jeff Fan (3): UefiCpuPkg/CpuMpPei: Skip microcode check/load if it has been loaded UefiCpuPkg/CpuMpPei: Dump message if microcode signature not matched UefiCpuPkg/CpuMpPei: Remove unnecessary variable UefiCpuPkg/CpuMpPei/CpuMpPei.c | 4 ++-- UefiCpuPkg/CpuMpPei/CpuMpPei.h | 10 ++

[edk2] [Patch 3/3] UefiCpuPkg/CpuMpPei: Remove unnecessary variable

2016-07-01 Thread Jeff Fan
Cc: Michael Kinney Cc: Feng Tian Cc: Giri P Mudusuru Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan --- UefiCpuPkg/CpuMpPei/Microcode.c | 3 --- UefiCpuPkg/CpuMpPei/Microcode.h | 1 - 2 files changed, 4 deletions(-) diff --git a/UefiCpuPkg/CpuMpPei/Microcode.c

[edk2] [Patch 2/3] UefiCpuPkg/CpuMpPei: Dump message if microcode signature not matched

2016-07-01 Thread Jeff Fan
Verification microcode signature is one enhancement and not one requirement from IA32 SDM. This update is just to dump debug message instead of ASSERT() if the updated microcode signature does not match the loaded microcode signature. Cc: Michael Kinney Cc: Feng Tian Cc: Giri P Mudusuru Contrib