[edk2] [PATCH] Vlv2TbltDevPkg: Fixed code logic error.

2016-07-14 Thread Wei, David
>From d6e2bb4a60ab7cca4c1b8757f4ef76fc090ade7a Mon Sep 17 00:00:00 2001 From: david wei Date: Fri, 15 Jul 2016 14:34:26 +0800 Subject: [PATCH] Fixed code logic error. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: David Wei --- Vlv2TbltDevicePkg/PlatformRtcRuntimeDxe/Pla

Re: [edk2] [Patch] CryptoPkg/OpensslLib: Upgrade OpenSSL version to 1.0.2h

2016-07-14 Thread Ye, Ting
Looks good to me. Reviewed-by: Ye Ting -Original Message- From: Long, Qin Sent: Wednesday, July 13, 2016 2:16 PM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Woodhouse, David ; Long, Qin Subject: [Patch] CryptoPkg/OpensslLib: Upgrade OpenSSL version to 1.0.2h OpenSSL 1.0.2h was release

Re: [edk2] [PATCH 0/5] MdePkg BaseTools: GCC optimization for X64

2016-07-14 Thread Laszlo Ersek
On 07/15/16 08:07, Ard Biesheuvel wrote: > On 15 July 2016 at 01:27, Laszlo Ersek wrote: >> First, the build tests. I built OVMF 84 times, with the following settings: >> >> * Dimension 1: whether your and Steven's patches were applied or not. > > I take it this means this series only? Ah, yes,

Re: [edk2] [PATCH 0/5] MdePkg BaseTools: GCC optimization for X64

2016-07-14 Thread Ard Biesheuvel
On 15 July 2016 at 01:27, Laszlo Ersek wrote: > On 07/14/16 15:16, Ard Biesheuvel wrote: >> This series is not an attempt to steal Steven's thunder. I was merely >> inspired by some of the changes he is proposing for GCC 5 and Clang >> support, which I noticed would be applicable to older versions

Re: [edk2] [PATCH v3 0/5] OvmfPkg: program MSR_IA32_FEATURE_CONTROL from fw_cfg on all processors

2016-07-14 Thread Laszlo Ersek
On 07/13/16 16:36, Laszlo Ersek wrote: > v1: http://thread.gmane.org/gmane.comp.bios.edk2.devel/14214 > v2: http://thread.gmane.org/gmane.comp.bios.edk2.devel/14471 > > Changes relative to v2: > - Patches 2 and 3: pick up Jeff's R-b. > - Patch 4: resolve CpuExceptionHandlerLib to PeiCpuExceptionHa

Re: [edk2] [PATCH v3 2/5] OvmfPkg/PlatformPei: rebase and resize the permanent PEI memory for S3

2016-07-14 Thread Laszlo Ersek
On 07/15/16 02:26, Jordan Justen wrote: > On 2016-07-13 07:36:56, Laszlo Ersek wrote: >> Move the permanent PEI memory for the S3 resume boot path to the top of >> the low RAM (just below TSEG if the SMM driver stack is included in the >> build). The new size is derived from CpuMpPei's approximate

Re: [edk2] [PATCH 0/5] MdePkg BaseTools: GCC optimization for X64

2016-07-14 Thread Ard Biesheuvel
On 15 July 2016 at 03:28, Gao, Liming wrote: > I see Steven patch uses -Os after enables new MS VA intrinsics. So, -Os > should work. But, I am not sure whether -Os is better than -O2 for edk2. > -Os did not work for me with GCC49 or earlier. It complains about a missing -maccumulate-outgoing-ar

Re: [edk2] [Patch 2/3] IntelFsp2WrapperPkg: Add missing modules in Package DSC

2016-07-14 Thread Mudusuru, Giri P
Reviewed-by: Giri P Mudusuru > -Original Message- > From: Gao, Liming > Sent: Thursday, July 14, 2016 10:05 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Mudusuru, Giri P > > Subject: [Patch 2/3] IntelFsp2WrapperPkg: Add missing modules in Package > DSC > > Package DSC is used

Re: [edk2] [Patch 3/3] IntelFsp2Pkg: Add missing modules in Package DSC

2016-07-14 Thread Mudusuru, Giri P
Reviewed-by: Giri P Mudusuru > -Original Message- > From: Gao, Liming > Sent: Thursday, July 14, 2016 10:05 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Mudusuru, Giri P > > Subject: [Patch 3/3] IntelFsp2Pkg: Add missing modules in Package DSC > > Package DSC is used to verify

Re: [edk2] [Patch 1/3] IntelFsp2WrapperPkg SecFspWrapperPlatformSecLibSample:Update code to pass build

2016-07-14 Thread Mudusuru, Giri P
Reviewed-by: Giri P Mudusuru > -Original Message- > From: Gao, Liming > Sent: Thursday, July 14, 2016 10:05 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Mudusuru, Giri P > > Subject: [Patch 1/3] IntelFsp2WrapperPkg > SecFspWrapperPlatformSecLibSample:Update code to pass build >

Re: [edk2] [PATCH v3 4/5] OvmfPkg: include UefiCpuPkg/CpuMpPei

2016-07-14 Thread Laszlo Ersek
On 07/15/16 02:12, Jordan Justen wrote: > On 2016-07-13 07:36:58, Laszlo Ersek wrote: >> In the next patch we're going to put EFI_PEI_MP_SERVICES_PPI to use. >> >> CpuMpPei uses the following PCDs from gUefiCpuPkgTokenSpaceGuid, beyond >> those already used by CpuDxe: >> >> - PcdCpuMicrocodePatchAd

[edk2] [Patch 3/3] IntelFsp2Pkg: Add missing modules in Package DSC

2016-07-14 Thread Liming Gao
Package DSC is used to verify the module source build. Cc: Jiewen Yao Cc: Giri Mudusuru Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- IntelFsp2Pkg/IntelFsp2Pkg.dsc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/IntelFsp2Pkg/IntelFsp2Pkg.dsc b/Inte

[edk2] [Patch 2/3] IntelFsp2WrapperPkg: Add missing modules in Package DSC

2016-07-14 Thread Liming Gao
Package DSC is used to verify the module source build. Cc: Jiewen Yao Cc: Giri Mudusuru Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc | 7 +++ 1 file changed, 7 insertions(+) diff --git a/IntelFsp2WrapperP

[edk2] [Patch 1/3] IntelFsp2WrapperPkg SecFspWrapperPlatformSecLibSample:Update code to pass build

2016-07-14 Thread Liming Gao
1. Update its library class to PlatformSecLib 2. Update source code to refer to the matched header file Cc: Jiewen Yao Cc: Giri Mudusuru Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- .../FspWrapperPlatformSecLibSample.c| 2 ++ ..

[edk2] [Patch 0/3] IntelFsp2Pkg IntelFsp2WrapperPkg: Add the missing modules in DSC

2016-07-14 Thread Liming Gao
Package DSC is used to verify the module source build. Liming Gao (3): IntelFsp2WrapperPkg SecFspWrapperPlatformSecLibSample:Update code to pass build IntelFsp2WrapperPkg: Add missing modules in Package DSC IntelFsp2Pkg: Add missing modules in Package DSC IntelFsp2Pkg/IntelFsp2Pkg.dsc

[edk2] (no subject)

2016-07-14 Thread Liming Gao
Package DSC is used to verify the module source build. Liming Gao (3): IntelFsp2WrapperPkg SecFspWrapperPlatformSecLibSample:Update code to pass build IntelFsp2WrapperPkg: Add missing modules in Package DSC IntelFsp2Pkg: Add missing modules in Package DSC IntelFsp2Pkg/IntelFsp2Pkg.dsc

Re: [edk2] PCI performance issue

2016-07-14 Thread Shaveta Leekha
You are right Eugene! Performance is getting impacted by all these factors, but that's true that I shall get better performance figure than this. That's why I am trying to figure out the possible optimizations in code that may help in improving it. Have you tried some optimizations to get bette

Re: [edk2] SATA AHCI issue

2016-07-14 Thread Tian, Feng
Hi, Mike Thanks for providing such info. I double checked WDK7600.16385.1 msahci driver. In P_Running_WaitOnFRE(), there is a statement: " Wait for confirmation is a 'nice to have' but isn't necessary. " And in the code, it waits for 50ms for FR bit if it's not set to 1. So the most safe way

Re: [edk2] [Patch] BaseTools: Fix a bug for FixedPcd value generation in AutoGen file

2016-07-14 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Zhu, Yonghong > Sent: Friday, July 15, 2016 10:22 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [Patch] BaseTools: Fix a bug for FixedPcd value generation in > AutoGen file > > If the library is listed in [Components]

[edk2] [PATCH v2 07/27] ShellPkg/UefiShellBcfgCommandLib: Handle memory allocation failure

2016-07-14 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey --- .../UefiShellBcfgCommandLib.c | 49 +++--- 1 file changed, 25 insertions(+), 24 deletions(-) diff --git a/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellB

[edk2] [PATCH v2 08/27] ShellPkg/ConsistMapping.c: Handle memory allocation failure

2016-07-14 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey --- .../Library/UefiShellCommandLib/ConsistMapping.c | 499 + 1 file changed, 320 insertions(+), 179 deletions(-) diff --git a/ShellPkg/Library/UefiShellCommandLib/ConsistMappi

[edk2] [PATCH v2 09/27] ShellPkg/UefiShellCommandLib.c: Handle memory allocation failure

2016-07-14 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey --- .../UefiShellCommandLib/UefiShellCommandLib.c | 36 +- 1 file changed, 28 insertions(+), 8 deletions(-) diff --git a/ShellPkg/Library/UefiShellCommandLib/UefiShellComman

[edk2] [PATCH v2 11/27] ShellPkg/EfiCompress: Handle memory allocation failure

2016-07-14 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey --- .../UefiShellDebug1CommandsLib/EfiCompress.c | 30 +- 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/EfiComp

[edk2] [PATCH v2 13/27] ShellPkg/LoadPciRom: Handle memory allocation failure

2016-07-14 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey --- ShellPkg/Library/UefiShellDebug1CommandsLib/LoadPciRom.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/LoadPciRom.c b/Sh

[edk2] [PATCH v2 00/27] ShellPkg: Handle memory allocation failure

2016-07-14 Thread Ruiyu Ni
The patch serials remove almost all assertions on memory allocation result, replaces with the error handling code. https://github.com/niruiyu/edk2/commits/shell_assert_v2 V2 adds "Status =" in patch #8, adds missing copy right year updates in patch #7, #8, #9, #11, #13. Ruiyu Ni (27): ShellPkg

[edk2] [Patch] BaseTools: Fix a bug for FixedPcd value generation in AutoGen file

2016-07-14 Thread Yonghong Zhu
If the library is listed in [Components] section for build only, its used FixedPcd Value is not generated into AutoGen code. This patch cover this case to generate the FixedPcd Value in AutoGen file. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zh

Re: [edk2] [PATCH 00/27] ShellPkg: Handle memory allocation failure

2016-07-14 Thread Ni, Ruiyu
Jaben, If we want to promote FreeArgList to library API. The structure ARG_LIST will also be in the library header file. Let's wait and see if there is more such usage and abstract it then. I will post a v2 for those that need update. Regards, Ray >-Original Message- >From: edk2-devel [

[edk2] [Patch] BaseTools: Add build info for binary modules that only list in FDF file

2016-07-14 Thread Yonghong Zhu
If the binary module is list in the FDF file but not list in the DSC file, current build report would not include these binary module's info in the report "Module section". The patch fix this issue. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu

Re: [edk2] [PATCH 0/5] MdePkg BaseTools: GCC optimization for X64

2016-07-14 Thread Gao, Liming
I see Steven patch uses -Os after enables new MS VA intrinsics. So, -Os should work. But, I am not sure whether -Os is better than -O2 for edk2. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Friday, July 15, 2016 6:20

Re: [edk2] [PATCH v3 2/5] OvmfPkg/PlatformPei: rebase and resize the permanent PEI memory for S3

2016-07-14 Thread Jordan Justen
On 2016-07-13 07:36:56, Laszlo Ersek wrote: > Move the permanent PEI memory for the S3 resume boot path to the top of > the low RAM (just below TSEG if the SMM driver stack is included in the > build). The new size is derived from CpuMpPei's approximate memory demand. > > Save the base address and

Re: [edk2] [PATCH v3 4/5] OvmfPkg: include UefiCpuPkg/CpuMpPei

2016-07-14 Thread Jordan Justen
On 2016-07-13 07:36:58, Laszlo Ersek wrote: > In the next patch we're going to put EFI_PEI_MP_SERVICES_PPI to use. > > CpuMpPei uses the following PCDs from gUefiCpuPkgTokenSpaceGuid, beyond > those already used by CpuDxe: > > - PcdCpuMicrocodePatchAddress and PcdCpuMicrocodePatchRegionSize: thes

Re: [edk2] [patch] ShellPkg: Fix issue about Ifconfig6 -r command.

2016-07-14 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: Wu, Jiaxin > Sent: Wednesday, July 13, 2016 9:32 PM > To: Zhang, Lubo ; Carsey, Jaben > ; edk2-devel@lists.01.org > Cc: Ye, Ting ; Fu, Siyuan > Subject: RE: [edk2] [patch] ShellPkg: Fix issue about Ifconfig6 -r command. > Importance:

Re: [edk2] [PATCH 0/5] MdePkg BaseTools: GCC optimization for X64

2016-07-14 Thread Laszlo Ersek
On 07/14/16 15:16, Ard Biesheuvel wrote: > This series is not an attempt to steal Steven's thunder. I was merely > inspired by some of the changes he is proposing for GCC 5 and Clang > support, which I noticed would be applicable to older versions of GCC > as well. > > The first patch fixes the is

Re: [edk2] [PATCH 0/5] MdePkg BaseTools: GCC optimization for X64

2016-07-14 Thread Kinney, Michael D
Hi Bruce, I think size is most important for the default settings. This is why it it important to measure the size changes for each set of flag options. Size measurements are a bit complex due to the interaction with compressors. I have found that measuring the used space in an FV with compressio

Re: [edk2] [PATCH 0/5] MdePkg BaseTools: GCC optimization for X64

2016-07-14 Thread Bruce Cran
On 7/14/2016 4:20 PM, Laszlo Ersek wrote: On 07/14/16 23:57, Bruce Cran wrote: I wonder if -Os might be a better default optimization? Or perhaps there's plenty of flash on devices nowadays and performance is more important than size? Beware of -Os with GCC48: http://thread.gmane.org/gmane.c

Re: [edk2] [PATCH 0/5] MdePkg BaseTools: GCC optimization for X64

2016-07-14 Thread Laszlo Ersek
On 07/14/16 23:57, Bruce Cran wrote: > On 7/14/2016 7:16 AM, Ard Biesheuvel wrote: > >> Patch #3 enabled -O2 optimization for X64/RELEASE all the way back to >> GCC44. > > I wonder if -Os might be a better default optimization? Or perhaps > there's plenty of flash on devices nowadays and performa

Re: [edk2] SATA AHCI issue

2016-07-14 Thread Mike Maslenkin
BTW Windows waits for FR bit set for 50ms as opposed to Linux. See P_Running_WaitOnFRE function of storahci from WDK. So you can break Intel HBAs for example. Could you ask iastor team about this issue? Regards. On Thu, 2016-07-14 at 06:25 +, Tian, Feng wrote: > Hi, Shaveta > > We have app

Re: [edk2] [PATCH 0/5] MdePkg BaseTools: GCC optimization for X64

2016-07-14 Thread Bruce Cran
On 7/14/2016 7:16 AM, Ard Biesheuvel wrote: Patch #3 enabled -O2 optimization for X64/RELEASE all the way back to GCC44. I wonder if -Os might be a better default optimization? Or perhaps there's plenty of flash on devices nowadays and performance is more important than size? At least for

Re: [edk2] [PATCH 08/27] ShellPkg/ConsistMapping.c: Handle memory allocation failure

2016-07-14 Thread Carsey, Jaben
> -Original Message- > From: Ni, Ruiyu > Sent: Thursday, July 14, 2016 2:30 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben > Subject: [PATCH 08/27] ShellPkg/ConsistMapping.c: Handle memory > allocation failure > Importance: High > > Contributed-under: TianoCore Contribution Agreem

Re: [edk2] [PATCH 00/27] ShellPkg: Handle memory allocation failure

2016-07-14 Thread Carsey, Jaben
Please check copyright. I notice that at minimum EfiCompress.c and LoadPciRom need an update. I think #8 has an error. Replied to that email separately. Is it worth moving "IfConfig6FreeArgList" to a shared library? Looked like there were 2 copies... Otherwise for the series Reviewed-By: Ja

Re: [edk2] minimum NASM version

2016-07-14 Thread Paolo Bonzini
On 14/07/2016 19:25, Laszlo Ersek wrote: >> > Ugh, this is so wrong. :) I guess you could also use a macro that >> > expands to >> > >> >bits 32 >> >mov src, dst >> >bits 64 >> > >> > because the encoding is the same in 32-bit and 64-bit. > Nice trick :), but the point of using NA

Re: [edk2] minimum NASM version

2016-07-14 Thread Laszlo Ersek
On 07/14/16 19:16, Kinney, Michael D wrote: > Laszlo, > > It may be possible to update NASM source to be compatible with both older and > latest > version of NASM. I claim that it's not possible in this case, as long as we'd like to avoid DBs and other coding tricks (i.e., as long as we'd like t

Re: [edk2] minimum NASM version

2016-07-14 Thread Laszlo Ersek
On 07/14/16 19:14, Paolo Bonzini wrote: > > > On 14/07/2016 19:11, Laszlo Ersek wrote: >> * I didn't say, but I also tried "mov ax, ds". The SDM writes, "The >> upper 56 bits or 48 bits (respectively) of the destination >> general-purpose register are not modified by the operation". In this >

Re: [edk2] minimum NASM version

2016-07-14 Thread Kinney, Michael D
Laszlo, It may be possible to update NASM source to be compatible with both older and latest version of NASM. We would have to evaluate the current build breaks to see if that is possible or not. For VS20xx tool chains, I prefer to specify the min at 2.12.01. I think support for source leve

Re: [edk2] minimum NASM version

2016-07-14 Thread Paolo Bonzini
On 14/07/2016 19:11, Laszlo Ersek wrote: > * I didn't say, but I also tried "mov ax, ds". The SDM writes, "The > upper 56 bits or 48 bits (respectively) of the destination > general-purpose register are not modified by the operation". In this > context, those bits were known to be zero, and

Re: [edk2] minimum NASM version

2016-07-14 Thread Laszlo Ersek
On 07/14/16 18:33, Paolo Bonzini wrote: > > > On 14/07/2016 13:19, Laszlo Ersek wrote: >> The problem is that NASM wouldn't support segment register MOVs in >> 64-bit mode until the following commit: >> >> http://repo.or.cz/nasm.git/commitdiff/21d4ccc3c338 >> >> Wed, 25 Aug 2010 02:28:00 +020

Re: [edk2] minimum NASM version

2016-07-14 Thread Paolo Bonzini
On 14/07/2016 13:19, Laszlo Ersek wrote: > The problem is that NASM wouldn't support segment register MOVs in > 64-bit mode until the following commit: > > http://repo.or.cz/nasm.git/commitdiff/21d4ccc3c338 > > Wed, 25 Aug 2010 02:28:00 +0200 (24 17:28 -0700) > > However, that change was f

Re: [edk2] minimum NASM version

2016-07-14 Thread Laszlo Ersek
On 07/14/16 18:00, Andrew Fish wrote: > >> On Jul 14, 2016, at 8:47 AM, Kinney, Michael D >> wrote: >> >> Laszlo, >> >> We may have to specify a different min version based on the toolchain used. >> >> For VS20xx toolchains, we must have 2.12.01 as the minimum to support source >> level debug.

Re: [edk2] minimum NASM version

2016-07-14 Thread Laszlo Ersek
On 07/14/16 17:47, Kinney, Michael D wrote: > Laszlo, > > We may have to specify a different min version based on the toolchain used. > > For VS20xx toolchains, we must have 2.12.01 as the minimum to support source > level debug. > > If GCCxx toolchains are compatible with NASM 2.07, then I see

Re: [edk2] minimum NASM version

2016-07-14 Thread Andrew Fish
> On Jul 14, 2016, at 8:47 AM, Kinney, Michael D > wrote: > > Laszlo, > > We may have to specify a different min version based on the toolchain used. > > For VS20xx toolchains, we must have 2.12.01 as the minimum to support source > level debug. > > If GCCxx toolchains are compatible with N

Re: [edk2] minimum NASM version

2016-07-14 Thread Kinney, Michael D
Laszlo, We may have to specify a different min version based on the toolchain used. For VS20xx toolchains, we must have 2.12.01 as the minimum to support source level debug. If GCCxx toolchains are compatible with NASM 2.07, then I see no reason to not document it that way. Mike > -Origi

Re: [edk2] minimum NASM version

2016-07-14 Thread Laszlo Ersek
On 07/14/16 16:51, Michael Zimmermann wrote: > Hi, > > if it would be very important to support that old version of NASM you > could just write "raw" assembler by putting the needed instructions as > word's within the executable code. Edk2 has prided itself on supporting several versions of sever

Re: [edk2] minimum NASM version

2016-07-14 Thread Laszlo Ersek
On 07/14/16 16:28, Gao, Liming wrote: > Laszlo: > > Sorry. I didn’t mention my version. I use 2.12.01 to verify all > changes. In 2.12, it adds support of Codeview version 8 (cv8) debug > format for win32 and win64 formats in the COFF backend. We need this > feature to get cv8 debug. I understa

Re: [edk2] [PATCH 0/5] MdePkg BaseTools: GCC optimization for X64

2016-07-14 Thread Ard Biesheuvel
On 14 July 2016 at 16:42, Gao, Liming wrote: > Ard: > On patch 4, the visibility 'hidden' GCC pragma globally. Does it work > together with other mode, such as large? Or it only works with small and pic? > I want to clarify this change has no negative impact. The #if checks for 'defined(__pic

Re: [edk2] minimum NASM version

2016-07-14 Thread Michael Zimmermann
Hi, if it would be very important to support that old version of NASM you could just write "raw" assembler by putting the needed instructions as word's within the executable code. changing the min requirement seems more proper though :) Thanks Michael On Thu, Jul 14, 2016 at 4:28 PM, Gao, Limin

Re: [edk2] [PATCH 0/5] MdePkg BaseTools: GCC optimization for X64

2016-07-14 Thread Gao, Liming
Ard: On patch 4, the visibility 'hidden' GCC pragma globally. Does it work together with other mode, such as large? Or it only works with small and pic? I want to clarify this change has no negative impact. On patch 5, I don't see any change for IA32 arch. is there no mode for IA32 arch? He

Re: [edk2] [PATCHv4 2/2] ArmJuno: Correct AXI->PCIe translation comments

2016-07-14 Thread Leif Lindholm
On Thu, Jul 14, 2016 at 09:19:09AM -0500, Jeremy Linton wrote: > On 07/14/2016 09:16 AM, Ard Biesheuvel wrote: > >On 14 July 2016 at 15:58, Jeremy Linton wrote: > >>The AXI<->PCIe translation comments are out of date with > >>respect to the code. In the first case the AXI master port > >>is incorr

Re: [edk2] minimum NASM version

2016-07-14 Thread Gao, Liming
Laszlo: Sorry. I didn't mention my version. I use 2.12.01 to verify all changes. In 2.12, it adds support of Codeview version 8 (cv8) debug format for win32 and win64 formats in the COFF backend. We need this feature to get cv8 debug. But, this version will report the error message: nasm: fat

Re: [edk2] [PATCHv4 2/2] ArmJuno: Correct AXI->PCIe translation comments

2016-07-14 Thread Jeremy Linton
On 07/14/2016 09:16 AM, Ard Biesheuvel wrote: On 14 July 2016 at 15:58, Jeremy Linton wrote: The AXI<->PCIe translation comments are out of date with respect to the code. In the first case the AXI master port is incorrectly called a slave. In the second case the the translation direction indica

Re: [edk2] [PATCHv4 2/2] ArmJuno: Correct AXI->PCIe translation comments

2016-07-14 Thread Ard Biesheuvel
On 14 July 2016 at 15:58, Jeremy Linton wrote: > The AXI<->PCIe translation comments are out of date with > respect to the code. In the first case the AXI master port > is incorrectly called a slave. In the second case the the > translation direction indicated for the slave port is the > wrong dir

[edk2] [PATCHv4 0/2] ArmJuno: Correct AXI<->PCI translations

2016-07-14 Thread Jeremy Linton
The PCIe PIO translation is incorrect on the Juno, correct that. While we are updating that module correct the comments to more accurately reflect the code and what is actually happening. Jeremy Linton (2): ArmJuno: fix Juno PIO host bridge mapping ArmJuno: Correct AXI->PCIe translation commen

Re: [edk2] PCI performance issue

2016-07-14 Thread Cohen, Eugene
I've been down this road before... Network performance (on non-coherent DMA architectures) can be affected by: 1. Excessive double buffering caused by unaligned buffers (PCI BusMasterRead / BusMasterWrite cases) 2. Excessive accesses to uncached buffers (like PCI common buffer cases) 3. Packet l

Re: [edk2] [PATCHv4 0/2] ArmJuno: Correct AXI<->PCI translations

2016-07-14 Thread Ryan Harkin
On 14 July 2016 at 15:09, Leif Lindholm wrote: > Thanks Jeremy. > > If Ryan's happy with this change, I'm happy to push it. > Yep, fine. I tested v3 (I think) and it worked fine. > Regards, > > Leif > > On 14 July 2016 at 14:58, Jeremy Linton wrote: >> The PCIe PIO translation is incorrect on

Re: [edk2] [PATCHv4 0/2] ArmJuno: Correct AXI<->PCI translations

2016-07-14 Thread Leif Lindholm
Thanks Jeremy. If Ryan's happy with this change, I'm happy to push it. Regards, Leif On 14 July 2016 at 14:58, Jeremy Linton wrote: > The PCIe PIO translation is incorrect on the Juno, correct that. > While we are updating that module correct the comments to more > accurately reflect the code

Re: [edk2] [Patch 0/2] Fix bug in TCP which not sending out ACK

2016-07-14 Thread Cohen, Eugene
Series Reviewed-By: Eugene Cohen Thank you for your ongoing help with our TCP issues, it is much appreciated. Eugene > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Wu, Jiaxin > Sent: Tuesday, July 12, 2016 8:12 PM > To: Fu, Siyuan ; edk2-

[edk2] [PATCHv4 2/2] ArmJuno: Correct AXI->PCIe translation comments

2016-07-14 Thread Jeremy Linton
The AXI<->PCIe translation comments are out of date with respect to the code. In the first case the AXI master port is incorrectly called a slave. In the second case the the translation direction indicated for the slave port is the wrong direction. Correct both of these comments to reflect what th

[edk2] [PATCHv4 1/2] ArmJuno: fix Juno PIO host bridge mapping

2016-07-14 Thread Jeremy Linton
The Juno PIO mapping is 8M, so it should be using a 32-bit PIO address translation. Further, PIO addresses should start at 0 and be translated to/from the ARM MMIO region. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeremy Linton Reviewed-by: Leif Lindholm --- ArmPlat

Re: [edk2] PCI performance issue

2016-07-14 Thread Shaveta Leekha
Ok, I can try that !! Thanks and Regards, Shaveta -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Thursday, July 14, 2016 7:11 PM To: Shaveta Leekha Cc: edk2-devel@lists.01.org; Linaro UEFI Mailman List Subject: Re: PCI performance issue On 14 July 20

Re: [edk2] PCI performance issue

2016-07-14 Thread Ard Biesheuvel
On 14 July 2016 at 15:29, Shaveta Leekha wrote: > But I have not tested the code (software) on any other hardware/board. > As I have not yet ported PCI code on any other board yet. > I would recommend to base your expectations not on U-Boot but on UEFI running on a different architecture using si

Re: [edk2] PCI performance issue

2016-07-14 Thread Shaveta Leekha
But I have not tested the code (software) on any other hardware/board. As I have not yet ported PCI code on any other board yet. Regards, Shaveta -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Shaveta Leekha Sent: Thursday, July 14, 2016 6:57 P

Re: [edk2] PCI performance issue

2016-07-14 Thread Shaveta Leekha
Hi Ard, Tftp have been tested on u-boot and Linux on same platform/board (the hardware on which tftp is tested on UEFI) And it takes around 1 min(or even lesser) in getting this big file (initrd image : around 30MB) over PCI using Tftp. So the issue is not with hardware, its somewhere in (PCI

[edk2] [PATCH 2/5] MdePkg: Enable new MS VA intrinsics for GNUC x86 64bits build

2016-07-14 Thread Ard Biesheuvel
From: "Shi, Steven" Both GCC and LLVM 3.8 64bits support new variable argument (VA) intrinsics for Microsoft ABI, enable these new VA intrinsics for GNUC family 64bits code build. These VA intrinsics are only permitted use in 64bits code, so not use them in 32bits code build. The original 32bits

Re: [edk2] PCI performance issue

2016-07-14 Thread Ard Biesheuvel
On 14 July 2016 at 15:05, Shaveta Leekha wrote: > Hi, > > > > > > I have been working on PCI controller driver performance (Root Bridge) for > my ARMv8 platform. I had integrated my PciHostBridgeDxe code with > MdeModulePkg/Bus/Pci/PciBusDxe. Have followed PCI Host bridge resource > allocation and

Re: [edk2] [PATCH 0/5] MdePkg BaseTools: GCC optimization for X64

2016-07-14 Thread Ard Biesheuvel
On 14 July 2016 at 15:16, Ard Biesheuvel wrote: > This series is not an attempt to steal Steven's thunder. I was merely > inspired by some of the changes he is proposing for GCC 5 and Clang > support, which I noticed would be applicable to older versions of GCC > as well. > > The first patch fixes

[edk2] [PATCH 1/5] MdePkg: avoid __builtin_unreachable() on GCC v4.4

2016-07-14 Thread Ard Biesheuvel
GCC v4.4 does not implement __builtin_unreachable(), so avoid using it when building with this version or earlier. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- MdePkg/Include/Base.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a

[edk2] [PATCH 5/5] BaseTools/tools_def: switch GCC/X64 to the PIC small model

2016-07-14 Thread Ard Biesheuvel
The ordinary small code model for x86_64 cannot be used in UEFI, since it assumes the executable is loaded in the first 2 GB of memory. Therefore, we use the large model instead, which can execute anywhere, but uses absolute 64-bit wide quantities for all symbol references, which is costly in terms

[edk2] [PATCH 0/5] MdePkg BaseTools: GCC optimization for X64

2016-07-14 Thread Ard Biesheuvel
This series is not an attempt to steal Steven's thunder. I was merely inspired by some of the changes he is proposing for GCC 5 and Clang support, which I noticed would be applicable to older versions of GCC as well. The first patch fixes the issue that __builtin_unreachable() is not implemented b

[edk2] [PATCH 4/5] MdePkg X64: force 'hidden' visibility when building with -fpic

2016-07-14 Thread Ard Biesheuvel
When building position independent (PIC) ELF objects, the GCC compiler assumes that each symbol with external linkage may potentially end up being exported from a shared library, which means that each of those symbols may be subject to symbol preemption, i.e., the executable linking to the shared l

[edk2] [PATCH 3/5] BaseTools/tools_def: enable O2 optimization for GCC X64 builds

2016-07-14 Thread Ard Biesheuvel
Now that we switched to the __builtin_ms_va_list VA_LIST type for GCC/X64, we can trust the compiler to do the right thing even under optimization, and so we can enable -O2 optimization all the way back to GCC44. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel

[edk2] PCI performance issue

2016-07-14 Thread Shaveta Leekha
Hi, I have been working on PCI controller driver performance (Root Bridge) for my ARMv8 platform. I had integrated my PciHostBridgeDxe code with MdeModulePkg/Bus/Pci/PciBusDxe. Have followed PCI Host bridge resource allocation and Root bridge IO protocol, as used in some other existing PCI

Re: [edk2] minimum NASM version

2016-07-14 Thread Laszlo Ersek
On 07/14/16 13:19, Laszlo Ersek wrote: > It seems that before NASM 2.10, there's simply no way to access segment > registers in 64-bit mode. I propose that we upgrade the following > comment in BaseTools: > >> diff --git a/BaseTools/Conf/tools_def.template >> b/BaseTools/Conf/tools_def.template

[edk2] minimum NASM version

2016-07-14 Thread Laszlo Ersek
Hi, yesterday I set up a VS2015x86 toolchain for test-building OVMF. I also resurrected my Fedora virtual machines that are dedicated to test-building OVMF with GCC44-GCC49 toolchains. I've found some C language build errors already, and I'm progressing through them slowly. However, one "killer"

[edk2] [PATCH 23/27] ShellPkg/UefiShellLib: Handle memory allocation failure

2016-07-14 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey --- ShellPkg/Library/UefiShellLib/UefiShellLib.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/ShellPkg/Library/UefiShellLib/UefiShellLib.c b/ShellPkg/Library/Uef

[edk2] [PATCH 01/27] ShellPkg/Shell.c: Handle memory allocation failure

2016-07-14 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey --- ShellPkg/Application/Shell/Shell.c | 27 +++ 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/ShellPkg/Application/Shell/Shell.c b/ShellPkg/Application/Shel

[edk2] [PATCH 21/27] ShellPkg/Cp: Handle memory allocation failure

2016-07-14 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey --- ShellPkg/Library/UefiShellLevel2CommandsLib/Cp.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Cp.c b/Shell

[edk2] [PATCH 19/27] ShellPkg/If: Handle memory allocation failure

2016-07-14 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey --- ShellPkg/Library/UefiShellLevel1CommandsLib/If.c | 95 +--- 1 file changed, 53 insertions(+), 42 deletions(-) diff --git a/ShellPkg/Library/UefiShellLevel1CommandsLib/If.c b

[edk2] [PATCH 18/27] ShellPkg/For: Handle memory allocation failure

2016-07-14 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey --- ShellPkg/Library/UefiShellLevel1CommandsLib/For.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/ShellPkg/Library/UefiShellLevel1CommandsLib/For.c b/ShellPkg/Li

[edk2] [PATCH 20/27] ShellPkg/Cd: Handle memory allocation failure

2016-07-14 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey --- ShellPkg/Library/UefiShellLevel2CommandsLib/Cd.c | 34 +++- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Cd.c b

[edk2] [PATCH 00/27] ShellPkg: Handle memory allocation failure

2016-07-14 Thread Ruiyu Ni
The patch serials remove almost all assertions on memory allocation result, replaces with the error handling code. https://github.com/niruiyu/edk2/commits/shell_assert Ruiyu Ni (27): ShellPkg/Shell.c: Handle memory allocation failure ShellPkg/IsVolatileEnv: Handle memory allocation failure

[edk2] [PATCH 24/27] ShellPkg/IfConfig: Handle memory allocation failure

2016-07-14 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey --- .../UefiShellNetwork1CommandsLib/Ifconfig.c| 77 -- .../UefiShellNetwork1CommandsLib.uni | 1 + 2 files changed, 58 insertions(+), 20 deletions(-) diff

[edk2] [PATCH 22/27] ShellPkg/Mv: Handle memory allocation failure

2016-07-14 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey --- ShellPkg/Library/UefiShellLevel2CommandsLib/Mv.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Mv.c b/ShellPkg/Li

[edk2] [PATCH 25/27] ShellPkg/UefiShellLib.c: Handle memory allocation failure

2016-07-14 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey --- ShellPkg/Library/UefiShellLib/UefiShellLib.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/ShellPkg/Library/UefiShellLib/UefiShellLib.c b/ShellPkg/Library/UefiS

[edk2] [PATCH 26/27] ShellPkg/Ifconfig6: Handle memory allocation failure

2016-07-14 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey --- .../UefiShellNetwork2CommandsLib/Ifconfig6.c | 75 -- .../UefiShellNetwork2CommandsLib.uni | 2 + 2 files changed, 56 insertions(+), 21 deletions(-) diff

[edk2] [PATCH 17/27] ShellPkg/DrvDiag: Handle memory allocation failure

2016-07-14 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey --- ShellPkg/Library/UefiShellDriver1CommandsLib/DrvDiag.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/ShellPkg/Library/UefiShellDriver1CommandsLib/DrvDiag.

[edk2] [PATCH 27/27] ShellPkg/Ping6: Handle memory allocation failure

2016-07-14 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey --- ShellPkg/Library/UefiShellNetwork2CommandsLib/Ping6.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ping6.c b/ShellPkg/Li

[edk2] [PATCH 13/27] ShellPkg/LoadPciRom: Handle memory allocation failure

2016-07-14 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey --- ShellPkg/Library/UefiShellDebug1CommandsLib/LoadPciRom.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/LoadPciRom.c b/Shell

[edk2] [PATCH 15/27] ShellPkg/DevTree: Handle memory allocation failure

2016-07-14 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey --- ShellPkg/Library/UefiShellDriver1CommandsLib/DevTree.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/ShellPkg/Library/UefiShellDriver1CommandsLib/DevTree.c b/

[edk2] [PATCH 05/27] ShellPkg/Dp: Handle memory allocation failure

2016-07-14 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey --- ShellPkg/Library/UefiDpLib/Dp.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/ShellPkg/Library/UefiDpLib/Dp.c b/ShellPkg/Library/UefiDpLib/Dp.c index 4bad3c2..75c7d11

[edk2] [PATCH 16/27] ShellPkg/DrvCfg: Handle memory allocation failure

2016-07-14 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey --- ShellPkg/Library/UefiShellDriver1CommandsLib/DrvCfg.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/ShellPkg/Library/UefiShellDriver1CommandsLib/DrvCfg.c

[edk2] [PATCH 12/27] ShellPkg/EfiDecompress: Handle memory allocation failure

2016-07-14 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey --- .../UefiShellDebug1CommandsLib/EfiDecompress.c | 52 -- 1 file changed, 28 insertions(+), 24 deletions(-) diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/EfiDeco

  1   2   >