Re: [edk2] [PATCH 1/5] ArmVirtPkg/PciHostBridgeDxe: don't set linux, pci-probe-only DT property

2016-08-23 Thread Ard Biesheuvel
On 23 August 2016 at 23:23, Laszlo Ersek wrote: > On 08/22/16 02:35, Ard Biesheuvel wrote: >> Setting the linux,pci-probe-only was intended to align OSes booting via >> DT with OSes booting via ACPI in the way they honor the PCI configuration >> performed by the firmware. However, ACPI on arm64 do

Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency

2016-08-23 Thread Zeng, Star
On 2016/8/24 11:27, Laszlo Ersek wrote: On 08/23/16 22:39, Zeng, Star wrote: On 2016/8/23 23:33, Laszlo Ersek wrote: On 08/18/16 22:57, Zeng, Star wrote: On 2016/8/19 10:45, Zeng, Star wrote: On 2016/8/19 10:26, Laszlo Ersek wrote: On 08/19/16 04:00, Fan, Jeff wrote: Laszlo, I could revert

Re: [edk2] incorrected set variable size in InitSmmProfileCallBack of UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c

2016-08-23 Thread wang xiaofeng
Jiewen, Thanks for the information. At 2016-08-24 11:56:48, "Yao, Jiewen" wrote: >Hi >That is done by design. We just need save the *pointer* to variable region, >not the *content*. >The content is in EfiReservedMemoryType memory. > >An OS application can get this pointer and parse the da

Re: [edk2] incorrected set variable size in InitSmmProfileCallBack of UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c

2016-08-23 Thread Yao, Jiewen
Hi That is done by design. We just need save the *pointer* to variable region, not the *content*. The content is in EfiReservedMemoryType memory. An OS application can get this pointer and parse the data pointed by mSmmProfileBase Thank you Yao Jiewen From: edk2-devel [mailto:edk2-devel-boun..

[edk2] incorrected set variable size in InitSmmProfileCallBack of UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c

2016-08-23 Thread wang xiaofeng
Hi Jeff, Not sure whether you owns SmmProfile.c. I found the following logic is incorrect. sizeof(mSmmProfileBase) is 8, we should use sizeof(SMM_PROFILE_HEADER). Otherwise the variable size is incorrect | gRT->SetVariable ( | | | SMM_PROFILE_NAME, | | | &gEfiCallerIdGuid, | | | EFI_VARIA

Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency

2016-08-23 Thread Laszlo Ersek
On 08/23/16 22:39, Zeng, Star wrote: > On 2016/8/23 23:33, Laszlo Ersek wrote: >> On 08/18/16 22:57, Zeng, Star wrote: >>> On 2016/8/19 10:45, Zeng, Star wrote: On 2016/8/19 10:26, Laszlo Ersek wrote: > On 08/19/16 04:00, Fan, Jeff wrote: >> Laszlo, >> >> I could revert this pa

Re: [edk2] [patch] ShellPkg: Fix the incorrect return status in function FindFiles()

2016-08-23 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni > -Original Message- > From: Bi, Dandan > Sent: Wednesday, August 24, 2016 11:13 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Carsey, Jaben > Subject: [patch] ShellPkg: Fix the incorrect return status in function > FindFiles() > > According to the latest she

[edk2] [Patch] MdeModulePkg UefiBootManagerLib: Add OptioalData for boot option.

2016-08-23 Thread Eric Dong
When generate boot option by BDS, always append Optional data which specify it's generated by BDS. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong Cc: Ruiyu Ni --- MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 4 ++-- 1 file changed, 2 insertions(+), 2 dele

[edk2] [patch] ShellPkg: Fix the incorrect return status in function FindFiles()

2016-08-23 Thread Dandan Bi
According to the latest shell spec, in function FindFiles(), when no files were found, it should return EFI_NOT_FOUND. But current codes don't follow the spec. This patch is to fix this issue. Cc: Ruiyu Ni Cc: Jaben Carsey Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Da

Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency

2016-08-23 Thread Zeng, Star
On 2016/8/23 23:33, Laszlo Ersek wrote: On 08/18/16 22:57, Zeng, Star wrote: On 2016/8/19 10:45, Zeng, Star wrote: On 2016/8/19 10:26, Laszlo Ersek wrote: On 08/19/16 04:00, Fan, Jeff wrote: Laszlo, I could revert this patch firstly. Thank you, that would be very kind. Could you please d

Re: [edk2] [PATCH 0/6] PiDxeS3BootScriptLib: Support multiple PCI segment

2016-08-23 Thread Laszlo Ersek
On 08/19/16 03:35, Star Zeng wrote: > Support multiple PCI segment for PCI_CONFIG2 opcodes. > > PiDxeS3BootScriptLib needs to be updated to consume PciSegmentLib > instead of PciLib. That means platforms need to add PciSegmentLib > declaration like below in platform dsc if the PciSegmentLib was >

Re: [edk2] [PATCH 1/5] ArmVirtPkg/PciHostBridgeDxe: don't set linux, pci-probe-only DT property

2016-08-23 Thread Laszlo Ersek
On 08/22/16 02:35, Ard Biesheuvel wrote: > Setting the linux,pci-probe-only was intended to align OSes booting via > DT with OSes booting via ACPI in the way they honor the PCI configuration > performed by the firmware. However, ACPI on arm64 does not currently honor > the firmware's PCI configurat

Re: [edk2] [PATCH 3/5] ArmVirtPkg/ArmVirtQemu: switch to generic PciHostBridgeDxe

2016-08-23 Thread Ard Biesheuvel
On 22 August 2016 at 08:35, Ard Biesheuvel wrote: > Wire up the FdtPciHostBridgeLib introduced in the previous patch > to the generic PciHostBridgeDxe implementation, and drop the special > ArmVirtPkg version. The former's dependency on gEfiCpuIo2ProtocolGuid > is satisfied by adding ArmPciCpuIo2D

Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency

2016-08-23 Thread Laszlo Ersek
On 08/18/16 22:57, Zeng, Star wrote: > On 2016/8/19 10:45, Zeng, Star wrote: >> On 2016/8/19 10:26, Laszlo Ersek wrote: >>> On 08/19/16 04:00, Fan, Jeff wrote: Laszlo, I could revert this patch firstly. >>> >>> Thank you, that would be very kind. >>> Could you please dig out the

Re: [edk2] [Patch 0/3] Use PcdAcpiS3Enable in CpuS3DataDxe and PiSmmCpuDxeSmm

2016-08-23 Thread Laszlo Ersek
On 08/18/16 03:09, Michael Kinney wrote: > Update CpuS3DataDxe and PiSmmCpuDxeSmm to consume PcdAcpiS3Enable. > If this PCD is disabled, then skip the S3 related logic in modules. > Also update PiSmmCpuDxeSmm to move S3 related code to CpuS3.c. > > Star Zeng (3): > UefiCpuPkg/CpuS3DataDxe: Consu

Re: [edk2] [PATCH 3/3] Revert "ShellPkg: Move FindFirstCharacter/GetNextParameter to ShellCommandLib"

2016-08-23 Thread Shah, Tapan
Series Reviewed By: Tapan Shah -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Monday, August 22, 2016 9:56 PM To: edk2-devel@lists.01.org Cc: Jaben Carsey Subject: [edk2] [PATCH 3/3] Revert "ShellPkg: Move FindFirstCharacter/GetN

[edk2] Question on iBFT for iSCSI

2016-08-23 Thread Subramanian, Sriram (EG Servers Platform SW)
All, The IScsiDxe implementation in EDK2 publishes the iBFT with the target IP address to which it connected to, and not the configured IP. These IPs will be the same if there is no iSCSI redirection. However, if the configured target redirects the initiator to another target (as part of iSCSI

Re: [edk2] OVMF not booting when built with GCC5 toolset?

2016-08-23 Thread Shi, Steven
It's confirmed it is a GCC6 regression bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70955 Steven Shi Intel\SSG\STO\UEFI Firmware Tel: +86 021-61166522 iNet: 821-6522 From: Shi, Steven Sent: Tuesday, August 23, 2016 4:10 PM To: 'Bruce Cran' ; 'Michael Zimmermann' Cc: 'edk2-devel-01' Subj

Re: [edk2] [PATCH 2/6] MdeModulePkg PiDxeS3BootScriptLib: Support multiple PCI segment

2016-08-23 Thread Zeng, Star
Mike, I am not sure about you said "so those functions can be simpler and smaller", could you help explain it more? ScriptPciCfg2Read() and ScriptPciCfg2Write() are for PCI_CONFIG2 opcodes. ScriptPciCfgRead() and ScriptPciCfgWrite() are for PCI_CONFIG opcodes. In current patch, ScriptPciCfgRead

Re: [edk2] OVMF not booting when built with GCC5 toolset?

2016-08-23 Thread Shi, Steven
Hi Cran, This issue might be a GCC6 LTO regression bug, and I've filed a bug to GCC community as below. Please don't use the GCC6 with edk2 GCC5 toolchain for now, the GCC5 (gcc-5) should works. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77341 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=5