Re: [edk2] [PATCH] IntelFsp2WrapperPkg: Add a PCD to control if signaling first event.

My thinking is to define mask for ALL APIs, not 3. We have 5 APIs, and 3 sub API for notify phase. How about this : # BIT0~15 is for function: # BIT0 - Mask TempRamInit # BIT1 - Mask MemoryInit # BIT2 - Mask TempRamExit # BIT3 - Mask SiliconInit # BIT4 - Mask NotifyPhase # BIT16~32 is

Re: [edk2] [PATCH] IntelFsp2WrapperPkg: Add a PCD to control if signaling first event.

I am OK with bit mask PCD. Now only 3 APIs in this driver. Do we really need UINT64? Thanks, Guo From: Yao, Jiewen Sent: Friday, October 21, 2016 4:23 PM To: Dong, Guo ; Mudusuru, Giri P ; edk2-devel@lists.01.org Cc: Ma, Maurice

Re: [edk2] [PATCH] IntelSiliconPkg: Add GUIDs for SMBIOS data HOB and VBT data

Thanks for the patch. I have 2 minor comments: 1) below update seems unnecessary. It makes me confused. We did not change anything right? Can we skip it? - DEC_SPECIFICATION = 0x00010005 - PACKAGE_NAME = IntelSiliconPkg - PACKAGE_GUID =

Re: [edk2] [PATCH] IntelFsp2WrapperPkg: Add a PCD to control if signaling first event.

Understood. I agree that is a valid usage model. So how about we define a bit mask for every function? Such as "PcdFspApiSkipMask|UINT64" - I am open on any naming proposal. In the future we may need skip some other functions such as InitTempRam or TempRamExit. Thank you Yao Jiewen From:

Re: [edk2] [Bug 164] Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC files

I remember our deprecation process is: 1) Core defines DISABLE_NEW_DEPRECATED_INTERFACES and puts a deprecated content in it. (Platform does not use DISABLE_NEW_DEPRECATED_INTERFACES and deprecated function can still be used at this moment. But we strongly recommend a platform doing clean

Re: [edk2] [Bug 164] Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC files

On 10/22/16 00:10, Jordan Justen wrote: > On 2016-10-21 14:02:44, Laszlo Ersek wrote: >> Honestly, I imagined that DISABLE_NEW_DEPRECATED_INTERFACES would be >> temporary in the edk2 tree. That is, it's a means so we can gradually >> transition with all the in-tree stuff to a deprecationless code

Re: [edk2] [Bug 164] Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC files

On 2016-10-21 14:02:44, Laszlo Ersek wrote: > On 10/21/16 22:39, Jordan Justen wrote: > > On 2016-10-21 13:20:49, Andrew Fish wrote: > >>Thus the option is to DISABLE_DEPRECATED_INTERFACES as that maintains > >>backward compatibility. > > > > In order to support UDK releases, maybe

[edk2] [PATCH 15/19] ArmVirtPkg/FdtPciPcdProducerLib: eliminate unchecked PcdSetXX() calls

These are deprecated / disabled under the DISABLE_NEW_DEPRECATED_INTERFACES feature test macro. Introduce a variable called PcdStatus, and use it to assert the success of these operations (there is no reason for them to fail here). Cc: Ard Biesheuvel Ref:

[edk2] [PATCH 17/19] ArmPkg/ArmDisassemblerLib: replace AsciiStrCat() with AsciiStrCatS()

AsciiStrCat() is deprecated / disabled under the DISABLE_NEW_DEPRECATED_INTERFACES feature test macro. The "Str" variable serves no particular purpose in the MRegList() and ThumbMRegList() functions; replace it with the pointed-to "mMregListStr" / "mThumbMregListStr" global variable (as

[edk2] [PATCH 14/19] ArmVirtPkg/ArmVirtTimerFdtClientLib: eliminate unchecked PcdSetXX() calls

These are deprecated / disabled under the DISABLE_NEW_DEPRECATED_INTERFACES feature test macro. Introduce a variable called PcdStatus, and use it to assert the success of these operations (there is no reason for them to fail here). Cc: Ard Biesheuvel Ref:

[edk2] [PATCH 11/19] ArmVirtPkg/ArmVirtGicArchLib: eliminate unchecked PcdSetXX() calls

These are deprecated / disabled under the DISABLE_NEW_DEPRECATED_INTERFACES feature test macro. Introduce a variable called PcdStatus, and use it to assert the success of these operations (there is no reason for them to fail here). Cc: Ard Biesheuvel Ref:

[edk2] [PATCH 13/19] ArmVirtPkg/ArmVirtPlatformLib: eliminate unchecked PcdSetXX() calls

These are deprecated / disabled under the DISABLE_NEW_DEPRECATED_INTERFACES feature test macro. Introduce a variable called PcdStatus, and use it to assert the success of these operations (there is no reason for them to fail here). Cc: Ard Biesheuvel Ref:

[edk2] [PATCH 18/19] ArmPkg/DefaultExceptionHandlerLib: replace AsciiStrCat() with AsciiStrCatS()

AsciiStrCat() is deprecated / disabled under the DISABLE_NEW_DEPRECATED_INTERFACES feature test macro. The caller of CpsrString() is required to pass in "ReturnStr" with 32 CHAR8 elements. (DefaultExceptionHandler() complies with this.) "Str" is used to build "ReturnStr" gradually. Just before

[edk2] [PATCH 19/19] ArmVirtPkg: disable deprecated interfaces

At this point no code in ArmVirtPkg (and apparently no code outside of ArmVirtPkg that the ArmVirt binaries depend on) uses the deprecated APIs, so we can disable them in the common platform DSC include file: BaseLib: - StrCpy - StrnCpy - StrCat - StrnCat - UnicodeStrToAsciiStr - AsciiStrCpy -

[edk2] [PATCH 16/19] ArmVirtPkg/PlatformBootManagerLib: eliminate unchecked PcdSetXX() calls

These are deprecated / disabled under the DISABLE_NEW_DEPRECATED_INTERFACES feature test macro. Introduce a variable called PcdStatus, and use it to assert the success of these operations (there is no reason for them to fail here). Cc: Ard Biesheuvel Ref:

[edk2] [PATCH 10/19] OvmfPkg: disable deprecated interfaces

At this point no code in OvmfPkg (and apparently no code outside of OvmfPkg that OVMF depends on) uses the deprecated APIs, so we can disable them in the platform DSC files: BaseLib: - StrCpy - StrnCpy - StrCat - StrnCat - UnicodeStrToAsciiStr - AsciiStrCpy - AsciiStrnCpy - AsciiStrCat -

[edk2] [PATCH 08/19] OvmfPkg/PlatformPei: eliminate unchecked PcdSetXX() calls

These are deprecated / disabled under the DISABLE_NEW_DEPRECATED_INTERFACES feature test macro. Introduce a variable called PcdStatus, and use it to assert the success of these operations (there is no reason for them to fail here). Cc: Anthony PERARD Cc: Gary Lin

[edk2] [PATCH 12/19] ArmVirtPkg/ArmVirtPL031FdtClientLib: eliminate unchecked PcdSetXX() calls

These are deprecated / disabled under the DISABLE_NEW_DEPRECATED_INTERFACES feature test macro. Introduce a variable called PcdStatus, and use it to assert the success of these operations (there is no reason for them to fail here). Cc: Ard Biesheuvel Ref:

[edk2] [PATCH 05/19] OvmfPkg/PlatformBootManagerLib: eliminate unchecked PcdSetXX() calls

These are deprecated / disabled under the DISABLE_NEW_DEPRECATED_INTERFACES feature test macro. Introduce a variable called PcdStatus, and use it to assert the success of these operations (there is no reason for them to fail here). Cc: Anthony PERARD Cc: Gary Lin

[edk2] [PATCH 00/19] OvmfPkg, ArmVirtPkg: leave deprecated interfaces behind

This series intends to solve the following BZs: -- OvmfPkg: Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC files -- ArmVirtPkg: Add the build option "/D

[edk2] [PATCH 04/19] OvmfPkg/EmuVariableFvbRuntimeDxe: eliminate unchecked PcdSetXX() calls

These are deprecated / disabled under the DISABLE_NEW_DEPRECATED_INTERFACES feature test macro. Introduce a variable called PcdStatus, and use it to assert the success of these operations (there is no reason for them to fail here). Cc: Anthony PERARD Cc: Gary Lin

[edk2] [PATCH 06/19] OvmfPkg/SmbiosVersionLib: eliminate unchecked PcdSetXX() calls

These are deprecated / disabled under the DISABLE_NEW_DEPRECATED_INTERFACES feature test macro. Introduce a variable called PcdStatus, and use it to assert the success of these operations (there is no reason for them to fail here). Cc: Ard Biesheuvel Cc: Jordan Justen

[edk2] [PATCH 07/19] OvmfPkg/PlatformDxe: eliminate unchecked PcdSetXX() calls

These are deprecated / disabled under the DISABLE_NEW_DEPRECATED_INTERFACES feature test macro. Introduce a variable called PcdStatus, and use it to assert the success of these operations (there is no reason for them to fail here). Cc: Jordan Justen Ref:

[edk2] [PATCH 09/19] OvmfPkg/QemuFlashFvbServicesRuntimeDxe: eliminate unchecked PcdSetXX() calls

These are deprecated / disabled under the DISABLE_NEW_DEPRECATED_INTERFACES feature test macro. Introduce a variable called PcdStatus, and use it to assert the success of these operations (there is no reason for them to fail here). Cc: Jordan Justen Ref:

[edk2] [PATCH 03/19] OvmfPkg/XenBusDxe: eliminate AsciiStrCat() calls

AsciiStrCat() is deprecated / disabled under the DISABLE_NEW_DEPRECATED_INTERFACES feature test macro. Replace AsciiStrCat() with AsciiSPrint(). Spell out the (already existent) PrintLib dependency in the INF file. Add an explicit ASSERT() to document that XenStoreJoin() assumes that the pool

[edk2] [PATCH 02/19] OvmfPkg/XenBusDxe: eliminate AsciiStrCpy() calls

AsciiStrCpy() is deprecated / disabled under the DISABLE_NEW_DEPRECATED_INTERFACES feature test macro. Cc: Anthony PERARD Cc: Gary Lin Cc: Jordan Justen Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=166

[edk2] [PATCH 01/19] MdePkg/DebugLib.h: add ASSERT_RETURN_ERROR()

ASSERT_EFI_ERROR() cannot be used in BASE type modules because - the replacement text calls EFI_ERROR(), - EFI_ERROR() is defined in "MdePkg/Include/Uefi/UefiBaseType.h", - the inclusion of "UefiBaseType.h" is not required for BASE type modules. While ASSERT (!RETURN_ERROR (StatusParameter))

Re: [edk2] [Bug 164] Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC files

On 10/21/16 22:39, Jordan Justen wrote: > On 2016-10-21 13:20:49, Andrew Fish wrote: >> On Oct 21, 2016, at 12:58 PM, Jordan Justen >> wrote: >> On 2016-10-21 12:37:21, Ard Biesheuvel wrote: >> >>I don't remember seeing any discussion regarding >>

Re: [edk2] [Bug 164] Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC files

On 21 October 2016 at 21:40, Laszlo Ersek wrote: > On 10/21/16 22:19, Ard Biesheuvel wrote: >> On 21 October 2016 at 21:14, Laszlo Ersek wrote: >>> On 10/21/16 21:58, Jordan Justen wrote: On 2016-10-21 12:37:21, Ard Biesheuvel wrote: > I don't

Re: [edk2] [Bug 164] Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC files

> On Oct 21, 2016, at 1:54 PM, Andrew Fish wrote: > >> >> On Oct 21, 2016, at 1:39 PM, Jordan Justen wrote: >> >> On 2016-10-21 13:20:49, Andrew Fish wrote: >>>On Oct 21, 2016, at 12:58 PM, Jordan Justen >>>

Re: [edk2] [Bug 164] Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC files

> On Oct 21, 2016, at 1:39 PM, Jordan Justen wrote: > > On 2016-10-21 13:20:49, Andrew Fish wrote: >> On Oct 21, 2016, at 12:58 PM, Jordan Justen >> wrote: >> On 2016-10-21 12:37:21, Ard Biesheuvel wrote: >> >> I don't

Re: [edk2] [Bug 164] Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC files

On 10/21/16 22:19, Ard Biesheuvel wrote: > On 21 October 2016 at 21:14, Laszlo Ersek wrote: >> On 10/21/16 21:58, Jordan Justen wrote: >>> On 2016-10-21 12:37:21, Ard Biesheuvel wrote: I don't remember seeing any discussion regarding DISABLE_NEW_DEPRECATED_INTERFACES

Re: [edk2] [Bug 164] Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC files

On 2016-10-21 13:20:49, Andrew Fish wrote: > On Oct 21, 2016, at 12:58 PM, Jordan Justen > wrote: > On 2016-10-21 12:37:21, Ard Biesheuvel wrote: > >I don't remember seeing any discussion regarding >DISABLE_NEW_DEPRECATED_INTERFACES on

Re: [edk2] [Bug 164] Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC files

> On Oct 21, 2016, at 12:58 PM, Jordan Justen wrote: > > On 2016-10-21 12:37:21, Ard Biesheuvel wrote: >> I don't remember seeing any discussion regarding >> DISABLE_NEW_DEPRECATED_INTERFACES on the list, so I am a bit surprised >> seeing these bugs being filed and

Re: [edk2] [Bug 164] Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC files

On 21 October 2016 at 21:14, Laszlo Ersek wrote: > On 10/21/16 21:58, Jordan Justen wrote: >> On 2016-10-21 12:37:21, Ard Biesheuvel wrote: >>> I don't remember seeing any discussion regarding >>> DISABLE_NEW_DEPRECATED_INTERFACES on the list, so I am a bit surprised >>> seeing

Re: [edk2] [Bug 164] Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC files

On 10/21/16 21:58, Jordan Justen wrote: > On 2016-10-21 12:37:21, Ard Biesheuvel wrote: >> I don't remember seeing any discussion regarding >> DISABLE_NEW_DEPRECATED_INTERFACES on the list, so I am a bit surprised >> seeing these bugs being filed and assigned. >> > > I agree. > > Also, the

Re: [edk2] [Bug 164] Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC files

On 2016-10-21 12:37:21, Ard Biesheuvel wrote: > I don't remember seeing any discussion regarding > DISABLE_NEW_DEPRECATED_INTERFACES on the list, so I am a bit surprised > seeing these bugs being filed and assigned. > I agree. Also, the terminology seems confusing. 'new deprecated' seems like a

Re: [edk2] [Bug 164] Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC files

I actually sent a patch for Arm some time ago: https://lists.01.org/pipermail/edk2-devel/2016-August/000489.html Thanks Michael On Fri, Oct 21, 2016 at 9:37 PM, Ard Biesheuvel wrote: > I don't remember seeing any discussion regarding >

Re: [edk2] [Bug 164] Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC files

I don't remember seeing any discussion regarding DISABLE_NEW_DEPRECATED_INTERFACES on the list, so I am a bit surprised seeing these bugs being filed and assigned. Before making any such changes, I would like a strong commitment from other package owners that deprecating an interface brings along

Re: [edk2] question about a compressed Ffs3 file inside FFS2 filesystem

Star, Thanks. That was the issue and that fixed the problem. How about adding an assert in PeiServicesLib? MdePkg\Library\PeiServicesLib\PeiServicesLib.c ~ line 642 add the assert for the else case. if (FvFormat != NULL) { CopyGuid (>FvFormat, FvFormat); } else { CopyGuid

[edk2] [PATCH] IntelSiliconPkg: Add GUIDs for SMBIOS data HOB and VBT data

Add gIntelSmbiosDataHobGuid and gIntelGraphicsVbtDataGuid GUIDs Cc: Jiewen Yao Cc: Star Zeng Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Giri P Mudusuru

Re: [edk2] [RESEND PATCH] ARMPkg: Unify the GIC base address variables as 64-bit

Hi Dennis, On 21 October 2016 at 06:50, Dennis Chen wrote: > Since ACPI spec defines the GIC base addresses (CPU interface, > Distributor and Redistributor*GICv3 only*) as 64-bit, so we should > define these corresponding base address variables as 64-bit instead of > 32-bit.

Re: [edk2] [RESEND PATCH] ArmVirtPkg: Bit width adaption in ASSERT()

On 21 October 2016 at 09:02, Laszlo Ersek wrote: > On 10/21/16 07:50, Dennis Chen wrote: >> Since All the GIC base address variables has been aligned to 64-bit, it >> doesn't make sense to continue use MAX_UINT32 in ASSERT() statement, so >> this patch uses MAX_UINTN to adapt

Re: [edk2] [PATCH] SecurityPkg: SmmTcg2PhysicalPresenceLib: Fix coding style issue

Reviewed-by: Dandan Bi Thanks, Dandan -Original Message- From: Zhang, Chao B Sent: Friday, October 21, 2016 1:25 PM To: edk2-devel@lists.01.org Cc: Bi, Dandan ; Long, Qin ; Zhang, Chao B Subject:

Re: [edk2] [RESEND PATCH] ArmVirtPkg: Bit width adaption in ASSERT()

On 10/21/16 07:50, Dennis Chen wrote: > Since All the GIC base address variables has been aligned to 64-bit, it > doesn't make sense to continue use MAX_UINT32 in ASSERT() statement, so > this patch uses MAX_UINTN to adapt to this kind of change. > > Contributed-under: TianoCore Contribution

[edk2] [PATCH v2] Edk2Setup.bat: Support building platforms with Python source

Following the same approach as toolsetup.bat: If build.exe, TargetTool.exe, Trim.exe or GenFds.exe is missing, run its Python source instead. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Cinnamon Shia --- Edk2Setup.bat | 36

[edk2] [PATCH] IntelFsp2Pkg: Changes to return FSP API error return status

Changed the FSPMemoryInitDone, FspSiliconInitDone and FspTempRamInitDone functions to return FSP API error status instead of always returning success. Cc: Maurice Ma Cc: Jiewen Yao Cc: Giri P Mudusuru Contributed-under:

Re: [edk2] [PATCH] IntelFsp2Pkg: Added changes to enable FPDT performance measurements

Reviewed-by: Giri P Mudusuru > -Original Message- > From: Yarlagadda, Satya P > Sent: Thursday, October 20, 2016 10:49 PM > To: edk2-devel@lists.01.org > Cc: Ma, Maurice ; Yao, Jiewen > ; Mudusuru, Giri P

Re: [edk2] [PATCH] SecurityPkg: SmmTcg2PhysicalPresenceLib: Fix coding style issue

Reviewed-by: Qin Long > -Original Message- > From: Zhang, Chao B > Sent: Friday, October 21, 2016 1:25 PM > To: edk2-devel@lists.01.org > Cc: Bi, Dandan ; Long, Qin ; > Zhang, Chao B > Subject: [PATCH]

[edk2] [PATCH] ArmPkg: Assign the real INTID value for sanity check

Current implementation doesn't assign the INTID value readed from GICC_IAR to the @InterruptId parameter in case of GICv3, thus make the sanity check of the INTID in the caller becomes untrustworthy, this patch is trying to re-assign the @InterruptId to mitigate this issue. Contributed-under:

Re: [edk2] [PATCH] IntelFsp2Pkg: Added changes to enable FPDT performance measurements

Reviewed-by: jiewen@intel.com > -Original Message- > From: Yarlagadda, Satya P > Sent: Friday, October 21, 2016 1:49 PM > To: edk2-devel@lists.01.org > Cc: Ma, Maurice ; Yao, Jiewen > ; Mudusuru, Giri P > Subject: