Re: [edk2] NvmExpressDxe async application crash with UDK debugger

Arka, Could you please share us your test code? Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Arka Sharma Sent: Wednesday, April 12, 2017 12:59 PM To: edk2-devel@lists.01.org Subject: [edk2] NvmExpressDxe async application crash

[edk2] NvmExpressDxe async application crash with UDK debugger

Hi, I am testing async io in NvmExpressDxe. The target system is Asrock Z97 which I have connected to host with serial port where UDK debugger is running. So my application does following 1. CreateEvent 2. Call Passthru 3. CmdSent++; 4. Repeat 1-3 until not ready from driver 5. while (CmdRecd <

Re: [edk2] [PATCH v5 3/3] OvmfPkg/QemuVideoDxe: VMWare SVGA device support

On Fri, Apr 7, 2017 at 10:46 PM, Laszlo Ersek wrote: > On 04/07/17 08:25, Phil Dennis-Jordan wrote: >> From: Phil Dennis-Jordan >> >> In addition to the QXL, Cirrus, etc. VGA adapters, Qemu also implements >> a basic version of VMWare's SVGA display device.

Re: [edk2] [PATCH v3 0/5] Fix undefined behavior in signed left shift

PS: lt's a typo on pkg name: IntelFWMdlPkg/IdeBusDxe: Fix undefined behavior in signed left shift -Original Message- From: Tian, Feng Sent: Wednesday, April 12, 2017 9:53 AM To: Wu, Hao A ; edk2-devel@lists.01.org; guoh...@huawei.com Cc: Tian, Feng

Re: [edk2] [PATCH v3 0/5] Fix undefined behavior in signed left shift

Series reviewed-by: Feng Tian -Original Message- From: Wu, Hao A Sent: Wednesday, April 12, 2017 9:52 AM To: edk2-devel@lists.01.org; guoh...@huawei.com Cc: Wu, Hao A ; Tian, Feng Subject: [PATCH v3 0/5] Fix undefined

[edk2] [PATCH v3 5/5] IntelFWMdlPkg/IdeBusDxe: Fix undefined behavior in signed left shift

In function AtapiReadCapacity(), the following expression: IdeDev->BlkIo.Media->LastBlock = (Data.LastLba3 << 24) | (Data.LastLba2 << 16) | (Data.LastLba1 << 8) | Data.LastLba0; (There is also a similar case in this function.) will involve undefined behavior in signed left shift

[edk2] [PATCH v3 0/5] Fix undefined behavior in signed left shift

After searching the whole code base, more cases are found related with: 'LastLba3 << 24' Send a new patch series (V3 based on the patch for ScsiDisk) to fix the suspicious undefined behavior in signed left shift. Cc: Feng Tian Hao Wu (5): MdeModulePkg/ScsiDiskDxe: Fix

[edk2] [PATCH v3 3/5] MdeModulePkg/UfsBlkIoPei: Fix undefined behavior in signed left shift

In function UfsBlockIoPeimGetMediaInfo(), the following expression: Private->Media[DeviceIndex].LastBlock = (Capacity16.LastLba3 << 24) | (Capacity16.LastLba2 << 16) | (Capacity16.LastLba1 << 8) | Capacity16.LastLba0; (There is also a similar case in this function.) will involve undefined

[edk2] [PATCH v3 4/5] MdeModulePkg/UsbBotPei: Fix undefined behavior in signed left shift

In function PeiUsbReadCapacity(), the following expression: LastBlock = (Data.LastLba3 << 24) | (Data.LastLba2 << 16) | (Data.LastLba1 << 8) | Data.LastLba0; (There is also a similar case in function PeiUsbReadFormattedCapacity().) will involve undefined behavior in signed left shift

[edk2] [PATCH v3 1/5] MdeModulePkg/ScsiDiskDxe: Fix undefined behavior in signed left shift

In function GetMediaInfo(), the following expression: ScsiDiskDevice->BlkIo.Media->LastBlock = (Capacity10->LastLba3 << 24) | (Capacity10->LastLba2 << 16) | (Capacity10->LastLba1 << 8) |

[edk2] [PATCH v3 2/5] MdeModulePkg/IdeBusPei: Fix undefined behavior in signed left shift

In function ReadCapacity(), the following expression: MediaInfo->LastBlock = (Data.LastLba3 << 24) | (Data.LastLba2 << 16) | (Data.LastLba1 << 8) | Data.LastLba0; (There is also a similar case in this function.) will involve undefined behavior in signed left shift operations. Since

Re: [edk2] Future of EBL (is there one?)

Hi Andrew, On Tue, Apr 11, 2017 at 07:57:13AM -0700, Andrew Fish wrote: > > On Apr 11, 2017, at 2:44 AM, Leif Lindholm wrote: > > This email was brought about by Ard's spring cleaning. > > > > EBL (EmbeddedPkg/Ebl/) is (to the best of my understanding) a sort of > >

[edk2] [PATCH] ArmVirtPkg/ArmVirtXen: remove ARM BdsLib library class resolution

Remove the library class resolution for ARM's BdsLib: no included module actually depends on it, and it will be removed shortly. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmVirtPkg/ArmVirtXen.dsc | 2 -- 1 file changed,

Re: [edk2] [PATCH v3 0/3] ArmPlatformPkg: FVP spring cleaning -- EDK2 edition

On 10 April 2017 at 17:33, Leif Lindholm wrote: > On Mon, Apr 10, 2017 at 05:21:49PM +0100, Ard Biesheuvel wrote: >> This v3 of the ArmPlatformPkg now only contains FVP changes. TC2 and Juno >> will receive a similar treatment once we have sorted out how the loading of

Re: [edk2] [RFC 0/3] Structure PCD value assignment in DEC/DSC

Hi Laszlo, I agree that the feature request should go into Bugzilla right away. I would like to the discussion on the RFC conclude before we enter spec and code Bugzilla entries, because based on feedback to the RFC the specific spec and tool changes may need some adjustments. Thanks, Mike >

Re: [edk2] [RFC 0/3] Structure PCD value assignment in DEC/DSC

On 04/11/17 17:16, Liming Gao wrote: > Requirment: Map VOID* PCD to C structure > 1. When PCD is configured as DynamicHii, it will be map to one EFI variable. > If PCD is VOID*, it can map to the > whole EFI variable. Most EFI variable data are defined as C structure. > 2. Some PCDs are

[edk2] [RFC 3/3] TestPkg: Show Structure PCD value assignment

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- TestPkg/Include/Guid/Test.h| 31 ++ TestPkg/StructuredPcdValueGenerator.py | 702 + TestPkg/TestPkg.dec| 44 +++

[edk2] [RFC 2/3] BaseTools: Add PcdValueCommon logic into CommonLib

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- BaseTools/Source/C/Common/GNUmakefile | 3 +- BaseTools/Source/C/Common/Makefile | 3 +- BaseTools/Source/C/Common/PcdValueCommon.c | 601 +

[edk2] [RFC 1/3] BaseTools: Update Makefile to work at absolute path

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- BaseTools/Source/C/Makefiles/app.makefile | 2 +- BaseTools/Source/C/Makefiles/ms.app | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

[edk2] [RFC 0/3] Structure PCD value assignment in DEC/DSC

Requirment: Map VOID* PCD to C structure 1. When PCD is configured as DynamicHii, it will be map to one EFI variable. If PCD is VOID*, it can map to the whole EFI variable. Most EFI variable data are defined as C structure. 2. Some PCDs are designed as C style structure, such as

Re: [edk2] Future of EBL (is there one?)

> On Apr 11, 2017, at 2:44 AM, Leif Lindholm wrote: > > Hi all, > > This email was brought about by Ard's spring cleaning. > > EBL (EmbeddedPkg/Ebl/) is (to the best of my understanding) a sort of > lightweight alternative to UEFI Shell, especially for serial console

Re: [edk2] Using USB-Ethernet adapter in UEFI on an arm64 platform

I see. Thank you for your input. I wish I could use Realtek device, but they have only x86 based binaries available, whereas I need arm64... Anyway, I can port Linux driver to the Uefi. Thank you, Vladimir On Apr 10, 2017 6:53 PM, "Tian, Feng" wrote: Ax88772b driver's

Re: [edk2] [patch] NetworkPkg: Add check logic for iSCSI driver.

Reviewed-by: Jiaxin Wu Thanks, Jiaxin > -Original Message- > From: Zhang, Lubo > Sent: Thursday, April 6, 2017 4:58 PM > To: edk2-devel@lists.01.org > Cc: Wu, Jiaxin ; Ye, Ting ; Fu, > Siyuan > Subject:

Re: [edk2] [PATCH v2] MdeModulePkg/ScsiDiskDxe: Fix undefined behavior in signed left shift

On 04/11/17 03:29, Hao Wu wrote: > In function GetMediaInfo(), the following expression: > ScsiDiskDevice->BlkIo.Media->LastBlock = (Capacity10->LastLba3 << 24) | > (Capacity10->LastLba2 << 16) | >

Re: [edk2] Array out of bounds write

Hi Naveen, Please feel free for the below coding, the array should never over bound since the buffer has been allocated before using it. FragCount = (HeaderSize != NULL) ? 2 : 1; TxLength = sizeof (EFI_UDP6_TRANSMIT_DATA) + (FragCount - 1) * sizeof (EFI_UDP6_FRAGMENT_DATA);

Re: [edk2] What happens if I have 2 DNS in the OFFER packet

Hi Jiaxin, Thank you very much. Regards, Naveen -Original Message- From: Wu, Jiaxin [mailto:jiaxin...@intel.com] Sent: Tuesday, April 11, 2017 5:06 PM To: Santhapur Naveen; edk2-devel@lists.01.org Subject: RE: What happens if I have 2 DNS in the OFFER packet Ok, I will try it

Re: [edk2] What happens if I have 2 DNS in the OFFER packet

Ok, I will try it tomorrow morning, then update it to you. Thanks report. Thanks, Jiaxin > -Original Message- > From: Santhapur Naveen [mailto:nave...@amiindia.co.in] > Sent: Tuesday, April 11, 2017 7:32 PM > To: Wu, Jiaxin ; edk2-devel@lists.01.org > Subject: RE:

Re: [edk2] What happens if I have 2 DNS in the OFFER packet

Hi Jiaxin, Yeah, I've been using 'ifconfig -s eth0 dhcp' from shell to set the IP address. Regards, Naveen -Original Message- From: Wu, Jiaxin [mailto:jiaxin...@intel.com] Sent: Tuesday, April 11, 2017 5:00 PM To: Santhapur Naveen; edk2-devel@lists.01.org Subject: RE: What

Re: [edk2] What happens if I have 2 DNS in the OFFER packet

Hi Naveen, Do you use the "ifconfig -s eth0 dhcp" command to set the IP address? For Ip4config2 protocol, no matter how many DNS in offer packet, all of will be configured (See Ip4Config2OnDhcp4Complete). Thanks, Jiaxin > -Original Message- > From: edk2-devel

Re: [edk2] [PATCH] ArmPlatformPkg/EblCmdLib: remove dependency on deprecared ARM BdsLib

On 11 April 2017 at 12:18, Evan Lloyd wrote: > Minor typo in title: "deprecared" should probably be deprecated? > Thanks Evan -- I spotted that myself, so I managed to fix it before pushing. > -Original Message- > From: edk2-devel

Re: [edk2] [PATCH] ArmPlatformPkg/EblCmdLib: remove dependency on deprecared ARM BdsLib

Minor typo in title: "deprecared" should probably be deprecated? -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard Biesheuvel Sent: 11 April 2017 10:15 To: edk2-devel@lists.01.org; leif.lindh...@linaro.org Cc: ryan.har...@linaro.org;

[edk2] Future of EBL (is there one?)

Hi all, This email was brought about by Ard's spring cleaning. EBL (EmbeddedPkg/Ebl/) is (to the best of my understanding) a sort of lightweight alternative to UEFI Shell, especially for serial console only embedded devices. Probably because this was included in some existing ARM platforms in

[edk2] What happens if I have 2 DNS in the OFFER packet

Hi all, I've been facing an issue which is "IP is not assigned to the SUT if the received OFFER packet contains 2 DNS entries." I don't have the environment with me. When I compared the Wireshark log in success and failure cases sent to me, I see no differences except

Re: [edk2] [PATCH] ArmPlatformPkg/EblCmdLib: remove dependency on deprecared ARM BdsLib

On Tue, Apr 11, 2017 at 10:14:34AM +0100, Ard Biesheuvel wrote: > The EBL alternative shell depends indirectly on the deprecated ARM > BdsLib via EblCmdLib, which only uses a single helper function that > can easily be cloned. So clone it, and remove the dependency. > > Contributed-under:

[edk2] [PATCH] ArmPlatformPkg/EblCmdLib: remove dependency on deprecared ARM BdsLib

The EBL alternative shell depends indirectly on the deprecated ARM BdsLib via EblCmdLib, which only uses a single helper function that can easily be cloned. So clone it, and remove the dependency. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel

Re: [edk2] [PATCH 2/3] SecurityPkg: Error Level is not used correctly

Reviewed-by: jiewen@intel.com > -Original Message- > From: Fan, Jeff > Sent: Monday, April 10, 2017 2:20 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen > Subject: [PATCH 2/3] SecurityPkg: Error Level is not used correctly > > Cc: Jiewen Yao

Re: [edk2] [Patch] SecurityPkg/SecurityPkg.dec: Update PcdPkcs7CertBuffer PCD.

Reviewed-by: jiewen@intel.com From: Long, Qin Sent: Tuesday, April 11, 2017 4:12 PM To: Yao, Jiewen ; Dong, Eric ; Zhang, Chao B Cc: edk2-devel@lists.01.org Subject: [edk2] [Patch] SecurityPkg/SecurityPkg.dec: Update

[edk2] [Patch] SecurityPkg/SecurityPkg.dec: Update PcdPkcs7CertBuffer PCD.

(The patch file contains a line longer than 998 characters, then "git send-email" failed. The patch was also available at https://github.com/qloong/edk2/commit/c45c7ccc97647d217bbad2a3e303ea4a5f3151a7) (Will submit another BZ request to support CRLF in PCD data for better indents). This patch

[edk2] [patch] BaseTools/ECC: Add a new checkpoint

Add a new checkpoint to check if the SMM communication parameter has a correct buffer type. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: hesschen --- BaseTools/Source/Python/Ecc/Check.py | 141 +++

[edk2] Array out of bounds write

Hello all, In the file PxeBcSupport.c of NetworkPkg there is EFI_STATUS PxeBcUdp4Write ( { ... // // Arrange one fragment buffer for data, and another fragment buffer for header if has. // FragCount = (HeaderSize != NULL) ?

Re: [edk2] [Patch] BaseTools/Pkcs7Sign: Update the test certificates & Readme.md

Yes. It will be another patch to update the sample PCD data. > -Original Message- > From: Yao, Jiewen > Sent: Tuesday, April 11, 2017 4:00 PM > To: Long, Qin; Dong, Eric > Cc: edk2-devel@lists.01.org > Subject: RE: [Patch] BaseTools/Pkcs7Sign: Update the test certificates & > Readme.md >

Re: [edk2] [Patch] BaseTools/Pkcs7Sign: Update the test certificates & Readme.md

Reviewed-by: jiewen@intel.com Do we also need update the default PCD definition in SecurityPkg? Thank you Yao Jiewen > -Original Message- > From: Long, Qin > Sent: Tuesday, April 11, 2017 3:56 PM > To: Yao, Jiewen ; Dong, Eric > Cc:

[edk2] [Patch] BaseTools/Pkcs7Sign: Update the test certificates & Readme.md

The old TestRoot certificate used for Pkcs7Sign is not compliant to Root CA certificate requirement with incorrect basic constraints and key usage setting. When OpenSSL in CryptoPkg was updated from 1.0.2xx to the latest 1.1.0xx, the CA certificate checking was enforced for more extension

Re: [edk2] [PATCH 3/3] UefiCpuPkg: Error Level is not used correctly

Reviewed-by: Feng Tian -Original Message- From: Fan, Jeff Sent: Monday, April 10, 2017 2:20 PM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Yao, Jiewen Subject: [PATCH 3/3] UefiCpuPkg: Error Level is not used correctly

Re: [edk2] [PATCH 1/3] MdeModulePkg: Error Level is not used correctly

Reviewed-by: Feng Tian -Original Message- From: Fan, Jeff Sent: Monday, April 10, 2017 2:20 PM To: edk2-devel@lists.01.org Cc: Tian, Feng Subject: [PATCH 1/3] MdeModulePkg: Error Level is not used correctly Cc: Feng Tian

Re: [edk2] 答复: [ScsiDiskDxe] Implict type conversion bug

Hi Gary, Thanks for the reporting, I will take a look at all the cases you mentioned. Best Regards, Hao Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Guoheyi > Sent: Tuesday, April 11, 2017 3:05 PM > To: Zeng, Star;

[edk2] 答复: [ScsiDiskDxe] Implict type conversion bug

Hi Star, I searched " LastLba3" in EDK2 code and found there were some other code similar to this one, could you please check whether they need to be fixed as well? IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/Atapi.c: IdeDev->BlkIo.Media->LastBlock = (Data.LastLba3 << 24) |

[edk2] [PATCH 2/2] BaseTools: Fix re-build issue after tools_def/build_rule updated.

From: Derek Lin Add tools_def.txt and build_rule.txt to workspace autogen timestamp file. Now it will not skip autogen if this two file is updated. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Derek Lin Reviewed-by: Yonghong Zhu

[edk2] [PATCH 1/2] BaseTools: Fix build fail after clean or cleanall target.

From: Derek Lin Remove module AutoGenTimeStamp file during clean or cleanall. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Derek Lin Reviewed-by: Yonghong Zhu ---

Re: [edk2] [patch] BaseTools/ECC: Change check rule for Ifndef statement

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Chen, Hesheng Sent: Monday, April 10, 2017 10:57 AM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong Subject: [patch] BaseTools/ECC: Change check rule for Ifndef