Re: [edk2] [edk2-InfSpecification PATCH] Remove ModuleType from [LibraryClasses] section

Reviewed-by: Liming Gao > -Original Message- > From: Kinney, Michael D > Sent: Saturday, May 27, 2017 10:28 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Zhu, Yonghong > ; Shaw, Kevin W >

Re: [edk2] Pressing ESC from "PXE windows Boot manager" causes ASSERT

Hi Karunakar, We have identified it's the 3rd part NBP file (wdsmgfw.efi) bug. I've updated my detailed analysis in the corresponding Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=571 Thanks, Jiaxin > -Original Message- > From: Karunakar P

[edk2] [edk2-BuildSpecification PATCH] Add EBNF for --pcd flag command line flag

https://bugzilla.tianocore.org/show_bug.cgi?id=523 GitHub branch for review: * https://github.com/mdkinney/edk2-BuildSpecification/tree/Bugzilla_523_EbnfPcdCommandLineOption GitHub word diff view of the patches in this series: * [1/1]

[edk2] [edk2-BuildSpecification PATCH] Add EBNF for --pcd flag command line flag

https://bugzilla.tianocore.org/show_bug.cgi?id=523 Cc: Liming Gao Cc: Yonghong Zhu Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael Kinney ---

Re: [edk2] [PATCH] MdePkg/DevicePathLib: Reverse the byte order of BD_ADDR for Bluetooth

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Wu, Hao A > Sent: Saturday, May 27, 2017 10:32 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Ni, Ruiyu ; > Kinney, Michael D ; Gao,

[edk2] [edk2-BuildSpecification PATCH] Add BrotliCompress and Pkcs7Sign GUIDed tools

https://bugzilla.tianocore.org/show_bug.cgi?id=517 Cc: Liming Gao Cc: Yonghong Zhu Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael Kinney ---

[edk2] [edk2-BuildSpecification PATCH] Add BrotliCompress and Pkcs7Sign GUIDed tools

https://bugzilla.tianocore.org/show_bug.cgi?id=517 GitHub branch for review: * https://github.com/mdkinney/edk2-BuildSpecification/tree/Bugzilla_517_GuidedToolsBrotliPkcs7Sign GitHub word diff view of the patches in this series: * [1/1]

[edk2] [edk2-BuildSpecification PATCH] Update Precedence of PCD Values

https://bugzilla.tianocore.org/show_bug.cgi?id=518 Cc: Liming Gao Cc: Yonghong Zhu Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael Kinney ---

[edk2] [edk2-BuildSpecification PATCH] Update Precedence of PCD Values

https://bugzilla.tianocore.org/show_bug.cgi?id=518 GitHub branch for review: * https://github.com/mdkinney/edk2-BuildSpecification/tree/Bugzilla_518_UpdatePrecedenceOfPcdValues GitHub word diff view of the patches in this series: * [1/1]

Re: [edk2] [PATCH v3 0/3] Enable X2APIC after MP service is ready

Please remove the extra space in patch 1/3 when you check in. Reviewed-by: Eric Dong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jeff Fan Sent: Friday, May 26, 2017 9:12 PM To: edk2-devel@lists.01.org Subject: [edk2]

[edk2] [edk2-BuildSpecification PATCH] Clarify that values of unused PCD are not evaluated

https://bugzilla.tianocore.org/show_bug.cgi?id=481 Cc: Liming Gao Cc: Yonghong Zhu Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael Kinney ---

[edk2] [edk2-BuildSpecification PATCH] Clarify that values of unused PCD are not evaluated

https://bugzilla.tianocore.org/show_bug.cgi?id=481 GitHub branch for review: * https://github.com/mdkinney/edk2-BuildSpecification/tree/Bugzilla_481_NoValueCheckOnUnreferrencedPcd GitHub word diff view of the patches in this series: * [1/1]

[edk2] [PATCH] MdePkg/DevicePathLib: Reverse the byte order of BD_ADDR for Bluetooth

For the following two functions: DevPathFromTextBluetooth() DevPathToTextBluetooth() The Bluetooth device address "UINT8 Address[6]" is displayed with the order from Address[5] to Address[0]. This commit reverses the order. Cc: Ruiyu Ni Cc: Michael D Kinney

[edk2] [edk2-InfSpecification PATCH] Remove ModuleType from [LibraryClasses] section

bugzilla.tianocore.org/show_bug.cgi?id=548 Cc: Liming Gao Cc: Yonghong Zhu Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael Kinney ---

[edk2] [edk2-InfSpecification PATCH] Remove ModuleType from [LibraryClasses] section

bugzilla.tianocore.org/show_bug.cgi?id=548 GitHub branch for review: * https://github.com/mdkinney/edk2-InfSpecification/tree/Bugzilla_548_RemoveModuleTypeFromLibraryClasses GitHub word diff view of the patches in this series: * [1/1]

[edk2] [edk2-InfSpecification PATCH] Clarify that PCD values may come from the build command line

https://bugzilla.tianocore.org/show_bug.cgi?id=522 Cc: Liming Gao Cc: Yonghong Zhu Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael Kinney ---

[edk2] [edk2-InfSpecification PATCH] Clarify that PCD values may come from the build command line

GitHub branch for review: * https://github.com/mdkinney/edk2-InfSpecification/tree/Bugzilla_522_AddPcdValueFromCommandLine GitHub word diff view of the patches in this series: * [1/1] https://github.com/mdkinney/edk2-InfSpecification/commit/a7412993bd49ded0cc7069913bc5008d782a3597?w=1

Re: [edk2] [PATCH v6 04/17] OvmfPkg/BaseMemcryptSevLib: Add SEV helper library

Agree. Per my understanding this driver is only needed for virtualization firmware, it is not needed for a real platform firmware. Putting it to OVMF makes more sense. Thank you Yao Jiewen From: Brijesh Singh [mailto:brijesh.si...@amd.com] Sent: Saturday, May 27, 2017 5:07 AM To: Justen,

Re: [edk2] [PATCH 2/8] DuetPkg/FvbRuntimeService: correct NumOfLba vararg type in EraseBlocks()

Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Thursday, May 18, 2017 11:04 PM > To: edk2-devel-01 > Cc: Ni, Ruiyu; Justen, Jordan L > Subject: [edk2]

Re: [edk2] [PATCH 4/8] Nt32Pkg/FvbServicesRuntimeDxe: correct NumOfLba vararg type in EraseBlocks()

Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Thursday, May 18, 2017 11:04 PM > To: edk2-devel-01 > Cc: Ni, Ruiyu; Justen, Jordan L > Subject: [edk2]

[edk2] [edk2-InfSpecification PATCH] Add LIB to supported file types in [Binaries] section

https://bugzilla.tianocore.org/show_bug.cgi?id=463 GitHub branch for review: * https://github.com/mdkinney/edk2-InfSpecification/tree/Bugzilla_463_AddLibToBinaries GitHub word diff view of the patches in this series: * [1/1]

[edk2] [edk2-InfSpecification PATCH] Add LIB to supported file types in [Binaries] section

https://bugzilla.tianocore.org/show_bug.cgi?id=463 Cc: Laszlo Ersek Cc: Liming Gao Cc: Yonghong Zhu Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael Kinney

Re: [edk2] [Patch] SourceLevelDebugPkg/SecPeiDebugAgentLib: Fix duplicate symbol

Felix, Yes. I agree. I will work on a Bugzilla issue for this topic and I prefer the idea of updating Base.h to check _MSC_VER value. The one challenge is that 'static' could be added in front of GLOBAL_REMOVE_IF_UNREFERENCED, and it will build correctly with VS2012 and newer, but would fail

Re: [edk2] [Patch] SourceLevelDebugPkg/SecPeiDebugAgentLib: Fix duplicate symbol

Another option to support older VS tool chains is to define GLOBAL_REMOVE_IF_UNREFERENCED as __declspec(selectany) only for these tool chains. One way to do it is to use _MSC_VER macro: #if _MSC_VER < #define GLOBAL_REMOVE_IF_UNREFERENCED __declspec(selectany) #endif Alternatively

Re: [edk2] [PATCH v6 10/17] OvmfPkg/QemuFwCfgLib: Provide Pei and Dxe specific library

On 2017-05-26 07:43:58, Brijesh Singh wrote: > Current QemuFwCfgLib.inf is used in both Pei and Dxe phases. Add Pei > and Dxe inf file to provide a seperate QemuFwCfgLib instances for Pei > and Dxe phases. > > We usually have 1 rather than 2 blank lines before the signature block. 10-16

Re: [edk2] [PATCH v6 04/17] OvmfPkg/BaseMemcryptSevLib: Add SEV helper library

Hi Jordan, I don't have any strong feeling on where this lib should go, but since SEV (Secure Encrypted Virtualization) feature is applicable only when are building/booting the OVMF platform hence I thought OVMF is the right place for it. Thanks Brijesh On 05/26/2017 03:54 PM, Jordan Justen

Re: [edk2] [PATCH v6 00/17] x86: Secure Encrypted Virtualization (AMD)

On 2017-05-26 07:43:48, Brijesh Singh wrote: > Changes since v4: > - decouple IoMmu protocol implementation from AmdSevDxe into a seperate >IoMmuDxe driver. And introduce a placeholder protocol to provide the >dependency support for the dependent modules. I think you split IoMmuDxe out

Re: [edk2] [PATCH v6 04/17] OvmfPkg/BaseMemcryptSevLib: Add SEV helper library

Jiewen, Jeff, Brijesh, Is there a reason this shouldn't go under UefiCpuPkg rather than OvmfPkg? -Jordan On 2017-05-26 07:43:52, Brijesh Singh wrote: > Add Secure Encrypted Virtualization (SEV) helper library. > The library provides the routines to: > - set or clear memory encryption bit for a

Re: [edk2] [PATCH] Copy bus scanning workaround from ARM Juno PCIe driver.

On 26 May 2017 at 16:50, Leif Lindholm wrote: > On Wed, May 24, 2017 at 07:03:10AM -0700, Ard Biesheuvel wrote: >> (+ Leif) >> >> On 24 May 2017 at 01:34, Scott Telford wrote: >> > Hi Ard, >> > >> > Firstly, this patch was meant for my edk2-staging

Re: [edk2] [PATCH 8/8] Vlv2TbltDevicePkg/FvbRuntimeDxe: correct NumOfLba vararg type in EraseBlocks()

David, On 05/19/17 03:49, Wei, David wrote: > Reviewed-by: zwei4 > > > Thanks, > David Wei thanks for committing & pushing this patch on my behalf -- I've been waiting for the rest of the reviews to trickle in. I figured I'd push the

Re: [edk2] [PATCH] Copy bus scanning workaround from ARM Juno PCIe driver.

On Wed, May 24, 2017 at 07:03:10AM -0700, Ard Biesheuvel wrote: > (+ Leif) > > On 24 May 2017 at 01:34, Scott Telford wrote: > > Hi Ard, > > > > Firstly, this patch was meant for my edk2-staging branch, not > > mainline edk2 - sorry, forgot to edit the subject line! > > Ah

Re: [edk2] [staging/cadence-aarch64] Add readme for cadence-aarch64 branch

On Mon, May 15, 2017 at 05:33:43PM +0100, Scott Telford wrote: > Announcing the creation of a new edk2-staging branch for Cadence peripheral > hardware support in AArch64 platforms. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Scott Telford

[edk2] [PATCH v6 13/17] OvmfPkg/QemuFwCfgLib: Implement SEV internal functions for PEI phase

Cc: Jordan Justen Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Brijesh Singh Reviewed-by: Laszlo Ersek --- OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgPeiLib.inf | 1 +

[edk2] [PATCH v6 17/17] OvmfPkg: update PciHostBridgeDxe to use PlatformHasIoMmuLib

This patch enables PciHostBridgeDxe driver to use Platform IoMMU detection library to ensure that PciHostBridgeDxe is run after platform IoMmuDxe driver has checked whether platform need to install IOMMU protocol provider. Cc: Jordan Justen Cc: Laszlo Ersek

[edk2] [PATCH v6 12/17] OvmfPkg/QemuFwCfgLib: Implement SEV internal function for SEC phase

Cc: Jordan Justen Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Brijesh Singh Reviewed-by: Laszlo Ersek --- OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgSec.c | 57

[edk2] [PATCH v6 11/17] OvmfPkg/QemuFwCfgLib: Prepare for SEV support

Add SEV specific internal functions which will be used while intergrating the SEV support into QemuFwCfgLib. Cc: Jordan Justen Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Brijesh Singh

[edk2] [PATCH v6 16/17] OvmfPkg/QemuFwCfgLib: Add SEV support

When SEV is enabled, use a bounce buffer to perform the DMA operation. Cc: Jordan Justen Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Brijesh Singh Reviewed-by: Laszlo Ersek

[edk2] [PATCH v6 14/17] OvmfPkg/QemuFwCfgLib: Implement SEV internal function for Dxe phase

When SEV is enabled, the DMA must be performed on unencrypted pages. So when get asked to perfom FWCFG DMA read or write, we allocate a intermediate (bounce buffer) unencrypted buffer and use this buffer for DMA read or write. Cc: Jordan Justen Cc: Laszlo Ersek

[edk2] [PATCH v6 08/17] OvmfPkg: Add PlatformHasIoMmuLib

Add the shorter-term library instance outlined in the previous patch to OvmfPkg, so that we can imbue PciHostBridgeDxe with a protocol dependency on gEdkiiIoMmuProtocolGuid OR gIoMmuAbsentProtocolGuid. Cc: Jordan Justen Cc: Laszlo Ersek

[edk2] [PATCH v6 15/17] OvmfPkg/QemuFwCfgLib: Add option to dynamic alloc FW_CFG_DMA Access

Update InternalQemuFwCfgDmaBytes() to work with DMA Access pointer. The change provides the flexibility to dynamically allocate the "Access" when SEV is enabled. Cc: Jordan Justen Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement

[edk2] [PATCH v6 10/17] OvmfPkg/QemuFwCfgLib: Provide Pei and Dxe specific library

Current QemuFwCfgLib.inf is used in both Pei and Dxe phases. Add Pei and Dxe inf file to provide a seperate QemuFwCfgLib instances for Pei and Dxe phases. Cc: Jordan Justen Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0

[edk2] [PATCH v6 09/17] OvmfPkg: Add IoMmuDxe driver

The IOMMU protocol driver provides capabilities to set a DMA access attribute and methods to allocate, free, map and unmap the DMA memory for the PCI Bus devices. Due to security reasons all DMA operations inside the SEV guest must be performed on shared (i.e unencrypted) pages. The IOMMU

[edk2] [PATCH v6 06/17] OvmfPkg: Add AmdSevDxe driver

When SEV is enabled, the MMIO memory range must be mapped as unencrypted (i.e C-bit cleared). We need to clear the C-bit for MMIO GCD entries in order to cover the ranges that were added during the PEI phase (through memory resource descriptor HOBs). Additionally, the NonExistent ranges are

[edk2] [PATCH v6 07/17] OvmfPkg: Introduce IoMmuAbsent Protocol GUID

Platforms that optionally provide an IOMMU protocol should do so by including a DXE driver (usually called IoMmuDxe) that produces either the IOMMU protocol -- if the underlying capabilities are available --, or gIoMmuAbsentProtocolGuid, to signal that the IOMMU capability detection completed with

[edk2] [PATCH v6 04/17] OvmfPkg/BaseMemcryptSevLib: Add SEV helper library

Add Secure Encrypted Virtualization (SEV) helper library. The library provides the routines to: - set or clear memory encryption bit for a given memory region. - query whether SEV is enabled. Cc: Jordan Justen Cc: Laszlo Ersek Contributed-under:

[edk2] [PATCH v6 05/17] OvmfPkg/PlatformPei: Set memory encryption PCD when SEV is enabled

Secure Encrypted Virtualization (SEV) guest VMs have the concept of private and shared memory. Private memory is encrypted with the guest-specific key, while shared memory may be encrypted with hypervisor key. Certain types of memory (namely instruction pages and guest page tables) are always

[edk2] [PATCH v6 03/17] OvmfPkg: Update dsc to use IoLib from BaseIoLibIntrinsicSev.inf

When SEV is enabled then we must unroll the rep String I/O instructions. The patch updates dsc file to use SEV version of IoLib inf. The main difference between BaseIoLibIntrinsic.inf and BaseIoLibIntrinsicSev.inf is, SEV version checks if its running under SEV enabled guest, If so then it unroll

[edk2] [PATCH v6 01/17] UefiCpuPkg: Define AMD Memory Encryption specific CPUID and MSR

The patch defines AMD's Memory Encryption Information CPUID leaf and SEV status MSR. The complete description for CPUID leaf is available in APM volume 2, Section 15.34. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Jeff Fan Cc:

[edk2] [PATCH v6 02/17] OvmfPkg/ResetVector: Set C-bit when building initial page table

SEV guest VMs have the concept of private and shared memory. Private memory is encrypted with the guest-specific key, while shared memory may be encrypted with hypervisor key. Certain types of memory (namely instruction pages and guest page tables) are always treated as private memory by the

[edk2] [PATCH v6 00/17] x86: Secure Encrypted Virtualization (AMD)

The patch series provides support for AMD's new Secure Encrypted Virtualization (SEV) feature. SEV is an extension to the AMD-V architecture which supports running multiple VMs under the control of a hypervisor. The SEV feature allows the memory contents of a virtual machine (VM) to be

[edk2] [PATCH v3 3/3] UefiCpuPkg/MpInitLib: Force to enable X2APIC if CPU number > 255

Cc: Michael D Kinney Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan --- UefiCpuPkg/Library/MpInitLib/MpLib.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff

[edk2] [PATCH v3 2/3] UefiCpuPkg/MpInitLib: Check APIC mode change around AP function

If APIC ID values are changed during AP functions execution, we need to update new APIC ID values in local data structure accordingly. But if APIC mode change happened during AP function execution, we do not support APIC ID value changed. Cc: Michael D Kinney Cc:

[edk2] [PATCH v3 0/3] Enable X2APIC after MP service is ready

https://bugzilla.tianocore.org/show_bug.cgi?id=575 v2: Updated #1 comments v3: 1. Remove ASSERT() in #1 if X2APIC enable but user configuration is FALSE. 2. Add #3 to force X2APIC mode if CPU number > 255. Jeff Fan (3): UefiCpuPkg/CpuCommonFeaturesLib: Support X2APIC enable

[edk2] [PATCH v3 1/3] UefiCpuPkg/CpuCommonFeaturesLib: Support X2APIC enable

Current X2APIC is enabled in MpInitLib (used by CpuMpPei and CpuDxe) to follow SDM suggestion. That means we only enable X2APIC if we found there are any initial CPU ID value >= 255. This patch is to provide one chance for platform to enable X2APIC even there is no any initial CPU ID value >=

Re: [edk2] [Patch] SourceLevelDebugPkg/SecPeiDebugAgentLib: Fix duplicate symbol

On 05/26/17 07:29, Gao, Liming wrote: > Mike: > I think build performance is also a key point. I prefer to add this > option in NOOPT target. After add this option, we can build edk2 > packages to detect those duplicated issues. OK, how about this: - MSFT toolchains: do the two step linking that

Re: [edk2] [Patch] SourceLevelDebugPkg/SecPeiDebugAgentLib: Fix duplicate symbol

Mike: Yes. /Gw option is added since VS2013. The older VS version can't use this option. I suggest we always define GLOBAL_REMOVE_IF_UNREFERENCED as empty, and drop this size optimization for the older version MS compiler. I collect its size of OvmfIa32X64 DEBUG tip with VS2015 tool chain on.

[edk2] AARCH64 : C Model Small Alignment requirements

Hello Edk2 team, We are facing a compilation error in our ARMV8 based NXP board. We are using c model small with GCC49 and GCC5. "WriteSections64(): %s due to its size (> 1 MB), this module requires 4 KB section alignment." With below GCC options, this error is not observed [BuildOptions]

Re: [edk2] [Patch] SourceLevelDebugPkg/SecPeiDebugAgentLib: Fix duplicate symbol

Liming, I agree with /Gw. That works for newer versions of VS. We will need to adjust the behavior of GLOBAL_REMOVE_IF_UNREFERENCED based on VS version as well. We can not define GLOBAL_REMOVE_IF_UNREFERENCED to static. We also use this macro for globals that are required to be exported from

Re: [edk2] Unmount and mount a mass storage from shell

Hi Jaben, Thanks a lot for input. My necessity for unmount-mount is that, the USB client is a Linux storage gadget, which needs to be remounted to get the updated/new files created by Linux. Anyhow, now I'm doing this programmatically by copying mount command code from older shell. :) One more