[edk2] [PATCH v2 0/2] Avoid reading undefined contents in PrintLib

2017-05-30 Thread Hao Wu
V2 changes: Refines the code logic to replace the 'if else' statments with the '? :' operator. V1 history: This series add logic to avoid reading content beyond a ASCII format string. Cc: Jiewen Yao Cc: Liming Gao Cc: Michael Kinney Hao Wu (2): MdePkg/BasePrintLib: Avoid reading content bey

[edk2] [PATCH v2 2/2] MdeModulePkg/PrintLib: Avoid reading content beyond the format string

2017-05-30 Thread Hao Wu
https://bugzilla.tianocore.org/show_bug.cgi?id=567 In functions DxePrintLibPrint2ProtocolVaListToBaseList() and InternalPrintLibSPrintMarker(), when processing ASCII format strings, if the format string walker pointer 'Format' is pointing at the end of the format string (i.e. '\0'), the following

[edk2] [PATCH v2 1/2] MdePkg/BasePrintLib: Avoid reading content beyond the format string

2017-05-30 Thread Hao Wu
https://bugzilla.tianocore.org/show_bug.cgi?id=567 In function BasePrintLibSPrintMarker(), when processing ASCII format strings, if the format string walker pointer 'Format' is pointing at the end of the format string (i.e. '\0'), the following expression: *(Format + 1) will read an undefined valu

Re: [edk2] [edk2-DscSpecification PATCH v2] Update Precedence of PCD Values

2017-05-30 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Kinney, Michael D Sent: Wednesday, May 31, 2017 2:00 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong ; Shaw, Kevin W Subject: [edk2-DscSpecification PATCH v2] Update Precedence of PCD Values

Re: [edk2] [edk2-DscSpecification PATCH] Update Precedence of PCD Values

2017-05-30 Thread Kinney, Michael D
Yonghong, Thanks for the feedback. I have sent V2 with these corrections. Mike -Original Message- From: Zhu, Yonghong Sent: Tuesday, May 30, 2017 6:41 PM To: Kinney, Michael D ; edk2-devel@lists.01.org Cc: Gao, Liming ; Shaw, Kevin W ; Zhu, Yonghong Subject: RE: [edk2-DscSpecificatio

[edk2] [edk2-DscSpecification PATCH v2] Update Precedence of PCD Values

2017-05-30 Thread Michael Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=519 Cc: Liming Gao Cc: Yonghong Zhu Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael Kinney --- 2_dsc_overview/28_pcd_section_processing.md | 56 ++--- README.md

[edk2] [edk2-DscSpecification PATCH v2] Update Precedence of PCD Values

2017-05-30 Thread Michael Kinney
New in V2 == * Remove extra 'p' character typo * Clarify that arch specific PCD values can be used for all PCD access methods https://bugzilla.tianocore.org/show_bug.cgi?id=519 GitHub branch for review: * https://github.com/mdkinney/edk2-DscSpecification/tree/r_Bugzilla_519_UpdatePreced

Re: [edk2] [PATCH] Maintainers.txt: Update maintainers for DuetPkg & Nt32Pkg

2017-05-30 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Wu, Hao A > Sent: Wednesday, May 31, 2017 9:55 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Ni, Ruiyu > Subject: [PATCH] Maintainers.txt: Update maintainers for DuetPkg & > Nt32Pkg > > Cc: Ruiyu Ni > Contributed-under

[edk2] [edk2-staging/BaseToolsOpt]: Add new branch BaseToolsOpt

2017-05-30 Thread Gao, Liming
Hi All, I would like to add new branch BaseToolsOpt in edk2-staging for BaseTools build performance optimization. Here is its Readme.MD. Please help review. Readme.MD: This branch is used to optimize BaseTools build performance. It bases on edk2 repo UDK2017 branch. The branch owner: Gao, Lim

[edk2] [edk2-staging/StructurePcd]: Add new branch StructurePcd

2017-05-30 Thread Gao, Liming
Hi All, Some RFC have been sent on Structure PCD feature. I would like to add new branch StructurePcd in edk2-staging and add POC code to show structure PCD idea and usage. Here is its Readme.MD. Please help review. Readme.MD: This branch is used to enable Structure PCD feature. The branch ow

Re: [edk2] [PATCH] MdeModulePkg/Xhci: Fill the 'interval' field for ISO endpoint context

2017-05-30 Thread Wu, Hao A
> -Original Message- > From: Zeng, Star > Sent: Wednesday, May 31, 2017 11:27 AM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Wu, Hao A; Baranee; Zeng, Star > Subject: RE: [edk2] [PATCH] MdeModulePkg/Xhci: Fill the 'interval' field for > ISO > endpoint context > > Reviewed-by: Star Zeng

Re: [edk2] Unmount and mount a mass storage from shell

2017-05-30 Thread GN Keshava
Hi Jaben, Thanks a lot for your input. As I have mentioned in previous mail, I'm facing an issue now, that, If I reconnect my client device, the mass storage is not able to mount again automatically. Here is few more details. Expecting some help on this : I connect the the client device to UEFI

Re: [edk2] [PATCH] MdeModulePkg/Xhci: Fill the 'interval' field for ISO endpoint context

2017-05-30 Thread Zeng, Star
Reviewed-by: Star Zeng BTW: Could you add the reference to the bugzilla link in the commit log? Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hao Wu Sent: Wednesday, May 31, 2017 9:48 AM To: edk2-devel@lists.01.org Cc: Wu, Hao A ;

[edk2] [PATCH] MdeModulePkg/Xhci: Remove TRB when canceling Async Int Transfer

2017-05-30 Thread Ruiyu Ni
Some USB devices don't report data periodically through Int Transfer. They report data only when be asked. If the TRB is not removed from the XHCI HW, when next time HOST asks data again, the data is reported but consumed by the previous TRB, which results the HOST thinks data never comes. Contrib

Re: [edk2] [edk2-BuildSpecification PATCH] Update Precedence of PCD Values

2017-05-30 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Kinney, Michael D Sent: Saturday, May 27, 2017 11:44 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong ; Shaw, Kevin W Subject: [edk2-BuildSpecification PATCH] Update Precedence of PCD Values

Re: [edk2] [Qemu-devel] [PATCH v3 1/4] ACPI: Add APEI GHES Table Generation support

2017-05-30 Thread gengdongjiu
Laszlo, very sorry for that, it was my mistake that missing your name. when I reply mail, I copy the "CC" list to the mail reply list, but forget to copy the "To" list. I will check your comments in detailed later and reply you. thanks again. On 2017/5/30 0:03, Laszlo Ersek wrote: > Hi, > >

[edk2] [PATCH] Maintainers.txt: Update maintainers for DuetPkg & Nt32Pkg

2017-05-30 Thread Hao Wu
Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- Maintainers.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index f412b65691..39b5b67857 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -90,6 +90,7 @@

Re: [edk2] [edk2-InfSpecification PATCH] Clarify that PCD values may come from the build command line

2017-05-30 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Kinney, Michael D Sent: Saturday, May 27, 2017 9:35 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong ; Shaw, Kevin W Subject: [edk2-InfSpecification PATCH] Clarify that PCD values may come fr

Re: [edk2] [edk2-BuildSpecification PATCH] Clarify that values of unused PCD are not evaluated

2017-05-30 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Kinney, Michael D Sent: Saturday, May 27, 2017 11:09 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong ; Shaw, Kevin W Subject: [edk2-BuildSpecification PATCH] Clarify that values of unused PC

Re: [edk2] [edk2-InfSpecification PATCH] Add LIB to supported file types in [Binaries] section

2017-05-30 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Kinney, Michael D Sent: Saturday, May 27, 2017 8:49 AM To: edk2-devel@lists.01.org Cc: Laszlo Ersek ; Gao, Liming ; Zhu, Yonghong ; Shaw, Kevin W Subject: [edk2-InfSpecification PATCH] Add LIB to supported

Re: [edk2] [edk2-BuildSpecification PATCH] Add BrotliCompress and Pkcs7Sign GUIDed tools

2017-05-30 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Kinney, Michael D Sent: Saturday, May 27, 2017 12:04 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong ; Shaw, Kevin W Subject: [edk2-BuildSpecification PATCH] Add BrotliCompress and Pkcs7Sign

[edk2] [PATCH] MdeModulePkg/Xhci: Fill the 'interval' field for ISO endpoint context

2017-05-30 Thread Hao Wu
The commit fills the 'Interval' field of the Endpoint Context data for isochronous endpoints. It will resolve the error when a Configure Endpoint Command is sent to an isochronous endpoint. Cc: Star Zeng Cc: Baranee Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu -

Re: [edk2] [edk2-DscSpecification PATCH] Allow mixed PCD access methods

2017-05-30 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Kinney, Michael D Sent: Sunday, May 28, 2017 4:03 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong ; Shaw, Kevin W Subject: [edk2-DscSpecification PATCH] Allow mixed PCD access methods https

Re: [edk2] [edk2-DscSpecification PATCH] Update Precedence of PCD Values

2017-05-30 Thread Zhu, Yonghong
Hi Mike, 1. Is this 'p' typo error is sentence "DSC file, p FeatureFlag, PatchableInModule or FixedAtBuild PCD value"? 2. How about remove the "FeatureFlag, PatchableInModule or FixedAtBuild" from below sentence since current Dynamic/DynamicEx also can have the specific arch info. "DSC file, a

Re: [edk2] [edk2-FdfSpecification PATCH] Update Precedence of PCD Values

2017-05-30 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Kinney, Michael D Sent: Sunday, May 28, 2017 2:10 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong ; Shaw, Kevin W Subject: [edk2-FdfSpecification PATCH] Update Precedence of PCD Values http

Re: [edk2] Localization help need: national symbols are not displayed on BIOS screen after adding a new language

2017-05-30 Thread Kinney, Michael D
Nikolay, I suspect you do not have the glyphs to support the Unicode characters you are attempting to display. The default HII Font Package is produced by the module: MdeModulePkg\Universal\Console\GraphicsConsoleDxe The file LaffStd.c contains the glyphs required for some Unicode characters.

[edk2] Localization help need: national symbols are not displayed on BIOS screen after adding a new language

2017-05-30 Thread Nikolay Bodunov
Hello I added 3 new languages in MdeModulePks/Application/UiApp example from EDK2 and I got a problem with strings output. Using Nt32Pkg emulator with Win 7. My problem is: when I add Russian language, I also add new string on that language to existing token, but I can't see that string shown on

Re: [edk2] Using a generic PciHostBridgeDxe driver for a multi-PCIe-domain platform

2017-05-30 Thread Vladimir Olovyannikov
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: May-30-17 1:17 PM > To: Vladimir Olovyannikov; edk2-devel@lists.01.org > Cc: Ard Biesheuvel > Subject: Re: [edk2] Using a generic PciHostBridgeDxe driver for a > multi-PCIe- > domain platform > > On 05/30/17 21:04,

Re: [edk2] Using a generic PciHostBridgeDxe driver for a multi-PCIe-domain platform

2017-05-30 Thread Laszlo Ersek
On 05/30/17 21:04, Vladimir Olovyannikov wrote: > So basically my PciHostBridgeLib should treat hostbridges as > rootbridges with different segments in this case? In my opinion, yes. I would actually put it as treat the set of sole root bridges on all the host bridges as multiple root bridg

Re: [edk2] Using a generic PciHostBridgeDxe driver for a multi-PCIe-domain platform

2017-05-30 Thread Vladimir Olovyannikov
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: May-30-17 11:50 AM > To: Vladimir Olovyannikov; edk2-devel@lists.01.org > Cc: Ard Biesheuvel > Subject: Re: [edk2] Using a generic PciHostBridgeDxe driver for a > multi-PCIe- > domain platform > > On 05/30/17 20:32

Re: [edk2] Using a generic PciHostBridgeDxe driver for a multi-PCIe-domain platform

2017-05-30 Thread Laszlo Ersek
On 05/30/17 20:32, Laszlo Ersek wrote: > On 05/30/17 18:23, Vladimir Olovyannikov wrote: >> Hi, >> >> I've started PCIe stack implementation design for an armv8 aarch64 >> platform. >> The platform's PCIe represents several host bridges, and each hostbridge >> has one rootbridge. >> They do not sha

Re: [edk2] Using a generic PciHostBridgeDxe driver for a multi-PCIe-domain platform

2017-05-30 Thread Laszlo Ersek
On 05/30/17 18:23, Vladimir Olovyannikov wrote: > Hi, > > I've started PCIe stack implementation design for an armv8 aarch64 > platform. > The platform's PCIe represents several host bridges, and each hostbridge > has one rootbridge. > They do not share any resources between each other. > Looking

Re: [edk2] Using a generic PciHostBridgeDxe driver for a multi-PCIe-domain platform

2017-05-30 Thread Vladimir Olovyannikov
> -Original Message- > From: Bill Paul [mailto:wp...@windriver.com] > Sent: May-30-17 10:34 AM > To: edk2-de...@ml01.01.org > Cc: Vladimir Olovyannikov; Ard Biesheuvel; edk2-de...@ml01.01.org > Subject: Re: [edk2] Using a generic PciHostBridgeDxe driver for a multi-PCIe- > domain platform >

Re: [edk2] Using a generic PciHostBridgeDxe driver for a multi-PCIe-domain platform

2017-05-30 Thread Bill Paul
Of all the gin joints in all the towns in all the world, Vladimir Olovyannikov had to walk into mine at 09:49:16 on Tuesday 30 May 2017 and say: > > -Original Message- > > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > > Sent: May-30-17 9:35 AM > > To: Vladimir Olovyannikov > >

Re: [edk2] Using a generic PciHostBridgeDxe driver for a multi-PCIe-domain platform

2017-05-30 Thread Vladimir Olovyannikov
> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: May-30-17 9:35 AM > To: Vladimir Olovyannikov > Cc: edk2-devel@lists.01.org > Subject: Re: Using a generic PciHostBridgeDxe driver for a > multi-PCIe-domain > platform > > On 30 May 2017 at 16:23, Vladimi

Re: [edk2] Using a generic PciHostBridgeDxe driver for a multi-PCIe-domain platform

2017-05-30 Thread Ard Biesheuvel
On 30 May 2017 at 16:23, Vladimir Olovyannikov wrote: > Hi, > > I've started PCIe stack implementation design for an armv8 aarch64 > platform. > The platform's PCIe represents several host bridges, and each hostbridge > has one rootbridge. > They do not share any resources between each other. > Lo

[edk2] Using a generic PciHostBridgeDxe driver for a multi-PCIe-domain platform

2017-05-30 Thread Vladimir Olovyannikov
Hi, I've started PCIe stack implementation design for an armv8 aarch64 platform. The platform's PCIe represents several host bridges, and each hostbridge has one rootbridge. They do not share any resources between each other. Looking into the PciHostBridgeDxe implementation I can see that it suppo

Re: [edk2] Unmount and mount a mass storage from shell

2017-05-30 Thread Carsey, Jaben
I think that you will always need to inform the UEFI Shell of the change. It is not designed to automatically do detection of added/removed/changed devices. I think that your solution to use the code from mount makes the most sense. -Jaben From: GN Keshava [mailto:keshava...@gmail.com] Sent: T

Re: [edk2] [PATCH] Copy bus scanning workaround from ARM Juno PCIe driver.

2017-05-30 Thread Ard Biesheuvel
On 29 May 2017 at 16:14, Scott Telford wrote: >> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >> Sent: 26 May 2017 18:38 >> To: Leif Lindholm >> Cc: Scott Telford ; edk2-devel@lists.01.org > de...@ml01.01.org>; Tian, Feng ; Zeng, Star >> >> Subject: Re: [edk2] [PATCH] Copy bus scannin