Re: [edk2] Disable BIOS menu or set password EDK2

Zach, Please remove the UiApp.inf from FDF file, you can get a no-UI firmware image. Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Zach Smith > Sent: Friday, July 28, 2017 12:14 AM > To: Andrew Fish > Cc:

Re: [edk2] [RFC v1 0/3] Add VIRTIO_F_IOMMU_PLATFORM support

Hi Andrew, On 07/27/2017 04:38 PM, Andrew Fish wrote: Brijesh, If you look in the UEFI Spec 13.4 EFI PCI I/O Protocol there is a good write on DMA. DMA Bus Master Read Operation = Call Map() for EfiPciIoOperationBusMasterRead. Program the DMA Bus Master with the

Re: [edk2] [RFC v1 0/3] Add VIRTIO_F_IOMMU_PLATFORM support

On 07/27/2017 04:31 PM, Ard Biesheuvel wrote: On 27 Jul 2017, at 21:55, Brijesh Singh wrote: On 07/27/2017 02:00 PM, Brijesh Singh wrote: This distribution of operations seems wrong. The key point is that AllocateBuffer() *need not* result in a buffer that is

Re: [edk2] [RFC v1 0/3] Add VIRTIO_F_IOMMU_PLATFORM support

> On Jul 27, 2017, at 2:31 PM, Ard Biesheuvel wrote: > >> >> On 27 Jul 2017, at 21:55, Brijesh Singh wrote: >> >> >> >> On 07/27/2017 02:00 PM, Brijesh Singh wrote: >> > This distribution of operations seems wrong. The key point is

Re: [edk2] [RFC v1 0/3] Add VIRTIO_F_IOMMU_PLATFORM support

> On 27 Jul 2017, at 21:55, Brijesh Singh wrote: > > > > On 07/27/2017 02:00 PM, Brijesh Singh wrote: > This distribution of operations seems wrong. The key point is that AllocateBuffer() *need not* result in a buffer that is immediately usable, and that

Re: [edk2] [RFC v1 0/3] Add VIRTIO_F_IOMMU_PLATFORM support

On 07/27/2017 02:00 PM, Brijesh Singh wrote: This distribution of operations seems wrong. The key point is that AllocateBuffer() *need not* result in a buffer that is immediately usable, and that client code is required to call Map() *unconditionally*, even if BusMasterCommonBuffer is the

Re: [edk2] [RFC v1 0/3] Add VIRTIO_F_IOMMU_PLATFORM support

On 07/27/2017 12:56 PM, Ard Biesheuvel wrote: On 27 July 2017 at 18:16, Laszlo Ersek wrote: On 07/27/17 16:21, Brijesh Singh wrote: Hi Laszlo, (5.3) All virtio driver code should treat VIRTIO_F_IOMMU_PLATFORM simply in parallel with VIRTIO_F_VERSION_1, and don't act

Re: [edk2] [RFC v1 0/3] Add VIRTIO_F_IOMMU_PLATFORM support

On 27 July 2017 at 18:16, Laszlo Ersek wrote: > On 07/27/17 16:21, Brijesh Singh wrote: >> Hi Laszlo, >> >> >>> >>> (5.3) All virtio driver code should treat VIRTIO_F_IOMMU_PLATFORM >>> simply in parallel with VIRTIO_F_VERSION_1, and don't act upon >>> VIRTIO_F_IOMMU_PLATFORM

Re: [edk2] [RFC v1 0/3] Add VIRTIO_F_IOMMU_PLATFORM support

On 07/27/17 16:21, Brijesh Singh wrote: > Hi Laszlo, > > >> >> (5.3) All virtio driver code should treat VIRTIO_F_IOMMU_PLATFORM >> simply in parallel with VIRTIO_F_VERSION_1, and don't act upon >> VIRTIO_F_IOMMU_PLATFORM in any special shape or form. So basically >> this is just my point (3) from

Re: [edk2] [PATCH 1/2] MdePkg/BaseLib: Add IsNodeInList() function.

Hi Liming, Comments are inline. Thanks for your response! Regards, Marvin. > -Original Message- > From: Gao, Liming [mailto:liming@intel.com] > Sent: Thursday, July 27, 2017 5:32 PM > To: marvin.haeu...@outlook.com; edk2-devel@lists.01.org > Cc: Kinney, Michael D

Re: [edk2] Disable BIOS menu or set password EDK2

Andrew, Would that be Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc? I do see the line: $(PLATFORM_PACKAGE)/UiApp/UiApp.inf Thanks, Zach On Thu, Jul 27, 2017 at 11:08 AM, Andrew Fish wrote: > > On Jul 27, 2017, at 8:59 AM, Zach Smith wrote: > > I believe

Re: [edk2] Disable BIOS menu or set password EDK2

> On Jul 27, 2017, at 8:59 AM, Zach Smith wrote: > > I believe MdeModulePkg UiApp is used, because the following lines appear in > MdeModulePkg.dsc: > > MdeModulePkg/Application/UiApp/UiApp.inf > MdeModulePkg/Universal/BdsDxe/BdsDxe.inf > > However, in

Re: [edk2] Disable BIOS menu or set password EDK2

I believe MdeModulePkg UiApp is used, because the following lines appear in MdeModulePkg.dsc: MdeModulePkg/Application/UiApp/UiApp.inf MdeModulePkg/Universal/BdsDxe/BdsDxe.inf However, in IntelFrameworkModulePkg.dsc, there is the line: IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf So

Re: [edk2] Disable BIOS menu or set password EDK2

You need to check Platform DSC/FDF to see whether UiApp is used. If MdeModulePkg BdsDxe and UiApp are used, you can remove UiApp from DSC/FDF. If IntelFrameworkModulePkg BdsDxe is used, it includes Bds and UiApp both. It is not easy to disable BIOS menu. Thanks Liming From: Zach Smith

Re: [edk2] Disable BIOS menu or set password EDK2

Liming, I believe I found UiApp, but how can I remov it? Can I just remove Vlv2TbltDevicePkg//UiApp/UiApp.inf? Thanks, Zach On Thu, Jul 27, 2017 at 10:45 AM, Zach Smith wrote: > Liming, > > I believe I found UiApp, but how can I remov it? Can I just remove >

Re: [edk2] [PATCH 1/2] MdePkg/BaseLib: Add IsNodeInList() function.

Marvin: Once this API is exposed as the public library API, what code will you update to consume this API? And, for the patch, I have two comments. 1) Original logic uses PcdVerifyNodeInList to turn on the verification of NodeInList. New logic always turns on it. Because this check takes

Re: [edk2] [PATCH] MdePkg/SecPeiDxeTimerLibCpu: Consume UefiCpuPkg LAPIC code.

Hey Liming, Thanks for your answer! Sorry, it seems like I indeed had a typo in the build command and accidentially built with 2005 instead of 2015. It builds fine with VS2015, though I still think the mask value is incorrect. After all it includes the first nibble of ApicBaseHi on 64-bit

Re: [edk2] [PATCH] MdePkg/SecPeiDxeTimerLibCpu: Consume UefiCpuPkg LAPIC code.

Marvin: I build this library on IA32 with VS2013x86 and VS2015x86. They can pass build. Could you let me know how to reproduce the compiler issue? Then, we can further provide the patch to fix it. Thanks Liming > -Original Message- > From: edk2-devel

Re: [edk2] Disable BIOS menu or set password EDK2

Zach: UDK2015 is a little old. Edk2 trunk has separated UiApp from BDS. UiApp is for BIOS menu. To remove UiApp can disable BIOS menu. On password, edk2 trunk SecurityPkg\Tcg\Opal\OpalPasswordDxe provides the real implementation for Opal supported devices.. You can refer to it for your

Re: [edk2] [RFC v1 0/3] Add VIRTIO_F_IOMMU_PLATFORM support

Hi Laszlo, (5.3) All virtio driver code should treat VIRTIO_F_IOMMU_PLATFORM simply in parallel with VIRTIO_F_VERSION_1, and don't act upon VIRTIO_F_IOMMU_PLATFORM in any special shape or form. So basically this is just my point (3) from above. (5.4) There are three VIRTIO_DEVICE_PROTOCOL

Re: [edk2] [PATCH v3 2/2] EmbeddedPkg: add Android boot device path and guid

On Thu, Jul 27, 2017 at 06:07:20PM +0800, Jun Nie wrote: > The device path specifies where to load android boot image. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jun Nie Reviewed-by: Leif Lindholm > --- >

Re: [edk2] [PATCH v3 1/2] EmbeddedPkg/AndroidBoot: boot android kernel from storage

On Thu, Jul 27, 2017 at 06:07:19PM +0800, Jun Nie wrote: > Add an android kernel loader that could load kernel from storage > device. This patch is from Haojian's code as below link. The minor > change is that alternative dtb is searched in second loader binary > of Android bootimage if dtb is not

Re: [edk2] [PATCH] MdePkg/SecPeiDxeTimerLibCpu: Consume UefiCpuPkg LAPIC code.

Hey Liming, Old and new because sizeof (UINTN) is what matters. Thanks, Marvin. > -Original Message- > From: Gao, Liming [mailto:liming@intel.com] > Sent: Thursday, July 27, 2017 3:19 PM > To: marvin.haeu...@outlook.com; edk2-devel@lists.01.org > Cc: Kinney, Michael D

Re: [edk2] [PATCH] UefiCpuPkg: Add BOOLEAN casts to return statements.

Hey Liming, I would without a doubt vote for VS2005 to be deprecated, especially when it isn't even tested anymore. Who would be in charge of that? The BaseTools maintainers? If it won't be deprecated, I think merging the changes should be done to support all supported toolchains. Regards,

Re: [edk2] [PATCH] MdePkg/SecPeiDxeTimerLibCpu: Consume UefiCpuPkg LAPIC code.

Marvin: Do you meet with the compiler issue on the old VS tool chain? Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Marvin > H?user > Sent: Wednesday, July 26, 2017 4:34 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael

Re: [edk2] [PATCH] UefiCpuPkg: Add BOOLEAN casts to return statements.

Marvin: Yes. They are too old. We have no verification for them. Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Marvin > H?user > Sent: Wednesday, July 26, 2017 4:36 PM > To: edk2-devel@lists.01.org > Cc: Fan, Jeff

[edk2] bus number padding [was: MdeModulePkg/PciBus: Avoid hang when BUS pad resource is not in top]

Hello Ray, please excuse me for hijacking this thread a little bit, but I'm very happy that you happen to be looking at this exact part of the code, which is also what I've been discussing with Marcel and Aleksandr (CC'd) due to a different reason. (The relevant sub-thread is at Allow RedHat

[edk2] [PATCH v3 2/2] EmbeddedPkg: add Android boot device path and guid

The device path specifies where to load android boot image. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jun Nie --- EmbeddedPkg/EmbeddedPkg.dec | 2 ++ 1 file changed, 2 insertions(+) diff --git a/EmbeddedPkg/EmbeddedPkg.dec

[edk2] [PATCH v3 1/2] EmbeddedPkg/AndroidBoot: boot android kernel from storage

Add an android kernel loader that could load kernel from storage device. This patch is from Haojian's code as below link. The minor change is that alternative dtb is searched in second loader binary of Android bootimage if dtb is not found after Linux kernel.

[edk2] [PATCH] ShellPkg/setvar: Check the duplicate flag

From: LI Huajing Signed-off-by: Huajing Li Reviewed-by: Ruiyu Ni --- ShellPkg/Library/UefiShellDebug1CommandsLib/SetVar.c | 4 .../Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.uni | 1 + 2