In PI spec 1.5, System Management Mode name has been changed to Management
mode,
it also change all SMM related driver name to avoid use SMI/SmRam/SMM keywords.
This patch series add new definition which use Management mode nomenclature.
Also in order to maintain continuity, this patch also us
In PI 1.5 version, system management mode name(SMM) has been changed
to Management Mode(MM). It impacts the current code which still use
SMM/Smram/SMI keywords. This patch add new definition which use
MM/MmRam/MMI keywords to follow new spec definitions.
Cc: Michael D Kinney
Cc: Liming Gao
Contr
In PI 1.5 version, system management mode name(SMM) has been changed
to Management Mode(MM). It impacts the current code which still use
SMM/Smram/SMI keywords. This patch update the original files which
related to old SMM modules, also keep the compatible with old SMM
related drivers.
Cc: Michael
Comment in line.
From: Wang, Jian J
Sent: Monday, August 28, 2017 11:24 AM
To: Yao, Jiewen ; edk2-devel@lists.01.org
Subject: RE: [edk2] [PATCH 0/2] Implement NULL pointer detection feature
1) I think this feature should be 'FALSE' by default. I forgot to reset
its default value. This feat
Laszlo:
I will update the patch with your comments.
Ard:
We collect the size impact in Ovmf platform. Its impact is small. So, my
patch enable this option for all targets. Below is the data collected on
OvmfIa32X64.dsc with GCC5 tool chain. Raw image is a little bigger. But, the
compresse
1) I think this feature should be 'FALSE' by default. I forgot to reset
its default value. This feature makes use of page mechanism to detect NULL
pointer. So any ARCH doesn't support paging in EDK-II can't use it. Currently
validated platform includes VLV2 and Denlow. Let me know if all pl
Reviewed-by: Eric Dong
-Original Message-
From: Bi, Dandan
Sent: Friday, August 25, 2017 10:59 AM
To: edk2-devel@lists.01.org
Cc: Dong, Eric ; Gao, Liming
Subject: [patch] IntelFrameworkModulePkg/LegacyBootMaintUiLib: Add NULL pointer
check
mLegacyBootOptionPrivate pointer is initiali
Thank you to enable this feature.
I have 2 comments, after a very quick review.
1) I notice it is enabled by default
"gEfiMdeModulePkgTokenSpaceGuid.PcdNullPointerDetection|TRUE".
Would you please provide the information on how many open source platforms are
validated?
Such as, IA platf
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=681
For string opcode,when checking the valid string length,
it should exclude the Null-terminated character.
And for string in NameValue storage, need to exclude
the varname and the need to convert the Config string
length to Unicode string leng
This feature is for debug purpose which helps to detect potential
NULL pointer access in code at run-time in SMM mode.
Cc: Eric Dong
Cc: Star Zeng
Cc: Jiewen Yao
Suggested-by: Wolman, Ayellet
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Wang, Jian J
---
UefiCpuPkg/P
This feature is for debug purpose which helps to detect potential
NULL pointer access in code at run-time.
Cc: Star Zeng
Cc: Jiewen Yao
Cc: Eric Dong
Suggested-by: Wolman, Ayellet
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Wang, Jian J
---
MdeModulePkg/Core/Dxe/Dx
This patch is the implementation of NULL pointer detection feature,
which is one of the small features of Special Pool.
Wang, Jian J (2):
Implement NULL pointer detection for EDK-II Core
Implement NULL pointer detection for EDK-II SMM Core and driver
MdeModulePkg/Core/Dxe/DxeMain.inf
Thanks. :)
Pushed this patch at
https://github.com/tianocore/edk2/commit/714c2603018a99a514c42c2b511c821f30ba9cdf.
And sent the patch at
https://lists.01.org/pipermail/edk2-devel/2017-August/013768.html for the
definition movement.
Star
-Original Message-
From: edk2-devel [mailto:edk2-d
Originally (before 714c2603018a99a514c42c2b511c821f30ba9cdf),
mPhysicalAddressBits was only defined in X64 PageTbl.c, after
714c2603018a99a514c42c2b511c821f30ba9cdf, mPhysicalAddressBits is
also defined in Ia32 PageTbl.c, then mPhysicalAddressBits is used in
ConvertMemoryPageAttributes() for addres
VirtioBlkDxe driver has been updated to use IOMMU-like member functions
from VIRTIO_DEVICE_PROTOCOL to translate the system physical address to
device address. We do not need to do anything special when
VIRTIO_F_IOMMU_PLATFORM bit is present hence treat it in parallel with
VIRTIO_F_VERSION_1.
Cc:
When device is behind the IOMMU then driver need to pass the device
address when programing the bus master. The patch uses VirtioRingMap() to
map the VRING system physical address to device address.
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Tom Lendacky
Cc: Laszlo Ersek
Contributed-under: Tiano
The patch updates the VirtioBlkDxe to use IOMMU-like member functions to map
the system physical address to device address for buffers (including vring,
device specific request and response pointed by vring descriptor, and any
furter memory reference by those request and response).
Cc: Ard Biesheu
When device is behind the IOMMU, driver is require to pass the device
address of virtio request, response and any memory referenced by those
request/response to the bus master.
The patch uses IOMMU-like member functions from VIRTIO_DEVICE_PROTOCOL to
map request and response buffers system physica
On 8/27/17 5:05 PM, Laszlo Ersek wrote:
[...]
> (4) I think we should be careful with BusMasterCommonBuffer operations
> similarly to BusMasterWrite operations -- populate first, map second.
>
> This is to avoid exposing any stale data, even for a short window, to
> the device.
>
> Speaking in
On 08/27/17 22:40, Laszlo Ersek wrote:
> This patch is functionally correct. I'd like to request three stylistic
> improvements:
>
> On 08/25/17 23:43, Brijesh Singh wrote:
>> When device is behind the IOMMU, driver is require to pass the device
>> address of virtio request, response and any memor
This patch is functionally correct. I'd like to request three stylistic
improvements:
On 08/25/17 23:43, Brijesh Singh wrote:
> When device is behind the IOMMU, driver is require to pass the device
> address of virtio request, response and any memory referenced by those
> request/response to the b
On 08/25/17 23:43, Brijesh Singh wrote:
> VirtioBlkDxe driver has been updated to use IOMMU-like member functions
> from VIRTIO_DEVICE_PROTOCOL to translate the system physical address to
> device address. We do not need to do anything special when
> VIRTIO_F_IOMMU_PLATFORM bit is present hence tre
On 08/25/17 23:43, Brijesh Singh wrote:
> When device is behind the IOMMU then driver need to pass the device
> address when programing the bus master. The patch uses VirtioRingMap() to
> map the VRING system physical address to device address.
>
> Cc: Ard Biesheuvel
> Cc: Jordan Justen
> Cc: To
On 08/26/17 04:24, Zeng, Star wrote:
> Laszlo,
>
> I am ok to centralize the definition in the patch(V2 will cover it), how
> about PiSmmCpuDxeSmm.c?
Because I have now tested this patch (see below), at this point my
preference would be that you commit v1 as-is, and then post a separate
patch to
24 matches
Mail list logo