Re: [edk2] Creating EFI System Partition

On 06/15/2018 11:01 AM, Andrew Fish wrote: > >> On Jun 15, 2018, at 6:17 AM, Rod Smith > > wrote: >> >> but AFAIK, any common tool for creating a FAT32 filesystem should >> work. I generally do it with mkdosfs in Linux, but equivalent tools >> in macOS, Windows, or

Re: [edk2] [PATCH edk2-platforms 1/3] Platform/Socionext/DeveloperBox: add support for persistent capsules

On Thu, Jun 07, 2018 at 01:32:01PM +0200, Ard Biesheuvel wrote: > Add support for PersistAcrossReset capsules, by setting the associated > PCD, and by enabling the warm reboot implementation that reenters PEI > with interrupts, caches and MMU disabled. > > Contributed-under: TianoCore

Re: [edk2] [PATCH v4 0/4] MdeModulePkg ArmPkg: support for persistent capsules and progress reporting

On 13 June 2018 at 10:08, Ard Biesheuvel wrote: > This is the delta of code required to implement PersistAcrossReset on ARM > systems, and to wire up the capsule handling routines in a way that makes > the new progress reporting code do something meaningful on such platforms. > > Changes since

Re: [edk2] [PATCH v2] MdeModulePkg: Enable SATA Controller PCI mem space

On Fri, Jun 15, 2018 at 03:26:54PM +, Evan Lloyd wrote: > Hi Ard, Zeng > > > -Original Message- > > From: Ard Biesheuvel > > Sent: 15 June 2018 15:17 > > To: Sami Mujawar > > Cc: edk2-devel@lists.01.org; Zeng, Star ; Eric Dong > > ; Ruiyu Ni ; Leif Lindholm > > ; Matteo Carlini ; >

Re: [edk2] [PATCH v2] MdeModulePkg: Enable SATA Controller PCI mem space

On 15 June 2018 at 17:26, Evan Lloyd wrote: > Hi Ard, Zeng > >> -Original Message- >> From: Ard Biesheuvel >> Sent: 15 June 2018 15:17 >> To: Sami Mujawar >> Cc: edk2-devel@lists.01.org; Zeng, Star ; Eric Dong >> ; Ruiyu Ni ; Leif Lindholm >> ; Matteo Carlini ; >> Stephanie Hughes-Fitt

Re: [edk2] [PATCH v2] MdeModulePkg: Enable SATA Controller PCI mem space

Hi Ard, Zeng > -Original Message- > From: Ard Biesheuvel > Sent: 15 June 2018 15:17 > To: Sami Mujawar > Cc: edk2-devel@lists.01.org; Zeng, Star ; Eric Dong > ; Ruiyu Ni ; Leif Lindholm > ; Matteo Carlini ; > Stephanie Hughes-Fitt ; Evan Lloyd > ; Thomas Abraham ; > nd > Subject: Re:

Re: [edk2] Creating EFI System Partition

Sorry Rod, called you Rob. I blame pre coffee emailing. My bad. Thanks, Andrew Fish > On Jun 15, 2018, at 8:01 AM, Andrew Fish wrote: > > > >> On Jun 15, 2018, at 6:17 AM, Rod Smith > > wrote: >> >> On 06/14/2018 08:35 PM, Robinson, Herbie wrote: >>> I have

Re: [edk2] Creating EFI System Partition

> On Jun 15, 2018, at 6:17 AM, Rod Smith wrote: > > On 06/14/2018 08:35 PM, Robinson, Herbie wrote: >> I have been tasked with implementing EFI boot in our VOS operating >> system (in a panic, nobody bothered to tell us ahead of time that >> legacy boot was being dropped from the BIOS on our

Re: [edk2] [PATCH v2] MdeModulePkg: Enable SATA Controller PCI mem space

On 15 June 2018 at 16:13, Sami Mujawar wrote: > The SATA controller driver crashes while accessing the > PCI memory [AHCI Base Registers (ABAR)], as the PCI memory > space is not enabled. > > Enable the PCI memory space access to prevent the SATA > Controller driver from crashing. > >

[edk2] [PATCH v2] MdeModulePkg: Enable SATA Controller PCI mem space

The SATA controller driver crashes while accessing the PCI memory [AHCI Base Registers (ABAR)], as the PCI memory space is not enabled. Enable the PCI memory space access to prevent the SATA Controller driver from crashing. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH v1 0/2] ArmPkg/ArmScmiDxe: Fix a bug uncovered with the new SCP firmware

This series fixes a bug in the ArmScmiDxe which was revealed while testing with the new SCP firmware. The changes can be seen at https://github.com/girishpathak/edk2/tree/281_scmi_fix_v1 Girish Pathak (2): ArmPkg/ArmScmiDxe: Fix ASSERT error in SCMI DXE ArmPkg/ArmScmiDxe: Dynamically

[edk2] [PATCH v1 1/2] ArmPkg/ArmScmiDxe: Fix ASSERT error in SCMI DXE

This change fixes a bug in the SCMI DXE which is observed with the upcoming release of the SCP firmware. The PROTOCOL_ID_MASK (0xF) which is used to generate an index in the ProtocolInitFxns is wrong because protocol ids can be anywhere in 0x10 - 15 or 0x80 - FF range. This mask generates the

[edk2] [PATCH v1 2/2] ArmPkg/ArmScmiDxe: Dynamically allocate buffer for protocol ids

Dynamically allocate the buffer to receive the SCMI protocol list. This makes MAX_PROTOCOLS redundant, so it is removed. It also fixes one minor code alignment issue and removes an unused macro PROTOCOL_MASK. Change-Id: Idc5880d4fb7b5c674f5fb7dce1198a7cad0303a7 Contributed-under: TianoCore

Re: [edk2] [PATCH v4 1/4] MdeModulePkg/CapsuleRuntimeDxe: clean the capsule payload to DRAM

Reviewed-by: jiewen@intel.com > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Friday, June 15, 2018 3:52 AM > To: Zeng, Star > Cc: edk2-devel@lists.01.org; leif.lindh...@linaro.org; Yao, Jiewen > ; Kinney, Michael D > Subject: Re: [PATCH v4

Re: [edk2] [PATCH v1] MdeModulePkg: Enable SATA Controller PCI mem space

Hi Zeng, Please find my response marked [SAMI] below. Regards, Sami Mujawar -Original Message- From: Zeng, Star Sent: 15 June 2018 10:42 AM To: Sami Mujawar ; edk2-devel@lists.01.org Cc: ruiyu...@intel.com; nd ; Stephanie Hughes-Fitt ; eric.d...@intel.com;

Re: [edk2] Creating EFI System Partition

On 06/14/2018 08:35 PM, Robinson, Herbie wrote: > I have been tasked with implementing EFI boot in our VOS operating > system (in a panic, nobody bothered to tell us ahead of time that > legacy boot was being dropped from the BIOS on our latest hardware). > I think we have a pretty good handle on

Re: [edk2] [PATCH edk2-platforms v2 2/2] Platform/ARM/Sgi: Pick ACPI tables to install based on platform ID

On 15 June 2018 at 14:00, Chandni Cherukuri wrote: > Use the platform ID and config ID values from the platform ID > HOB to choose the right set of ACPI tables to be installed. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Chandni Cherukuri > --- >

Re: [edk2] [PATCH edk2-platforms v2 1/2] Platform/ARM/Sgi: Install a Platform ID HOB

On 15 June 2018 at 14:00, Chandni Cherukuri wrote: > On SGI platforms, the trusted firmware executes prior to > the SEC phase. It supplies to the SEC phase a pointer to > a fdt, that contains platform specific information such as > part number and config number of the SGI platform. The > platform

Re: [edk2] [PATCH edk2-platforms v2 0/2] ARM Dynamic Configuration

On Fri, Jun 15, 2018 at 05:30:00PM +0530, Chandni Cherukuri wrote: > On SGI platforms, the trusted firmware executes prior to the SEC > phase. It supplies to the SEC phase, a pointer to a HW CONFIG fdt > in the x1 which contains platform specific information such as part > number and config number

Re: [edk2] [PATCH 1/2] Platform/ARM/Sgi: Install a Platform ID HOB

On Fri, Jun 15, 2018 at 3:48 PM, Leif Lindholm wrote: > > Just some minor formatting points in addition to the comment on Ard's > reply.. > > On Fri, Jun 15, 2018 at 11:25:31AM +0530, Chandni Cherukuri wrote: > > On SGI platforms, the trusted firmware executes prior to > > the SEC phase. It

[edk2] FMP Capsule vs PMCI PLDM FW Update binaries

Hi, The DMTF group is coming up with a new way to update FW on PCI devices via BMC - DSP0267. The method expects the FW binary to carry a pre-defined header that makes it easier for BMC to perform the necessary actions. Currently some of the OEM/ODMs are already releasing FW payloads that can be

[edk2] [PATCH edk2-platforms v2 2/2] Platform/ARM/Sgi: Pick ACPI tables to install based on platform ID

Use the platform ID and config ID values from the platform ID HOB to choose the right set of ACPI tables to be installed. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chandni Cherukuri --- Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 33

[edk2] [PATCH edk2-platforms v2 0/2] ARM Dynamic Configuration

On SGI platforms, the trusted firmware executes prior to the SEC phase. It supplies to the SEC phase, a pointer to a HW CONFIG fdt in the x1 which contains platform specific information such as part number and config number of the SGI platform. The HW CONFIG FDT would look as, /dts-v1/; / {

[edk2] [PATCH edk2-platforms v2 1/2] Platform/ARM/Sgi: Install a Platform ID HOB

On SGI platforms, the trusted firmware executes prior to the SEC phase. It supplies to the SEC phase a pointer to a fdt, that contains platform specific information such as part number and config number of the SGI platform. The platform code that executes during the SEC phase creates a PPI that

Re: [edk2] [PATCH v3 2/2] ArmPlatformPkg: Include PL011UartClock Lib

On 12 June 2018 at 22:14, Udit Kumar wrote: > This patch gets PL011 baud rate clock from > pl011 uart clock lib instead of Pcd. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Udit Kumar Reviewed-by: Ard Biesheuvel Pushed as

Re: [edk2] [PATCH v4 1/4] MdeModulePkg/CapsuleRuntimeDxe: clean the capsule payload to DRAM

On 14 June 2018 at 02:54, Zeng, Star wrote: > With 'EFIAPI' removed from IsPersistAcrossResetCapsuleSupported and > CapsuleCacheWriteBack definitions, Reviewed-by: Star Zeng > . > > You can wait a little more time in case Jiewen/Mike has comments. > Thank you Star. I will push these by the

Re: [edk2] [PATCH edk2-platforms v2 0/2]DeveloperBox: prepare for expanding the capsule payload

On 13 June 2018 at 20:56, Leif Lindholm wrote: > On Wed, Jun 13, 2018 at 06:28:24PM +0200, Ard Biesheuvel wrote: >> We intend to start distributing firmware update capsules that include the SCP >> firmware partition. In order to allow for more flexibility regarding whether >> a capsule contains

Re: [edk2] [PATCH 2/2] Platform/ARM/Sgi: Pick ACPI tables to install based on platform ID

On Fri, Jun 15, 2018 at 11:25:32AM +0530, Chandni Cherukuri wrote: > Use the platform ID and config ID values from the platform ID > HOB to choose the right set of ACPI tables to be installed. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Chandni Cherukuri > --- >

Re: [edk2] [PATCH 1/2] Platform/ARM/Sgi: Install a Platform ID HOB

Just some minor formatting points in addition to the comment on Ard's reply.. On Fri, Jun 15, 2018 at 11:25:31AM +0530, Chandni Cherukuri wrote: > On SGI platforms, the trusted firmware executes prior to > the SEC phase. It supplies to the SEC phase a pointer to > a fdt, that contains platform

Re: [edk2] [PATCH v1] MdeModulePkg: Enable SATA Controller PCI mem space

Generally, the patch is good to me. Some comments below. On 2018/6/14 19:38, Sami Mujawar wrote: The SATA controller driver crashes while accessing the PCI memory, as the PCI memory space is not enabled. The code "accessing the PCI memory" you mentioned here is the AhciReadReg in the

Re: [edk2] [PATCH 1/2] Platform/ARM/Sgi: Install a Platform ID HOB

On Fri, Jun 15, 2018 at 08:19:35AM +0200, Ard Biesheuvel wrote: > On 15 June 2018 at 08:16, Ard Biesheuvel wrote: > >> diff --git > >> a/Platform/ARM/SgiPkg/Library/SgiPlatformPeiLib/SgiPlatformPeiLib.inf > >> b/Platform/ARM/SgiPkg/Library/SgiPlatformPeiLib/SgiPlatformPeiLib.inf > >> new file

[edk2] [Patch] FDF Spec: clean up to support for FILE statement

Update the format in [FV], [Capsule] and [Rule] section. Cc: Liming Gao Cc: Michael Kinney Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- 2_fdf_design_discussion/26_[capsule]_sections.md | 4 ++--

[edk2] [PATCH 3/4] MdeModulePkg: Add GUID for recovery capsule on NVM Express devices

Cc: Star Zeng Cc: Eric Dong Cc: Ruiyu Ni Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Hao Wu --- MdeModulePkg/Include/Guid/RecoveryDevice.h | 9 + MdeModulePkg/MdeModulePkg.dec | 3 +++ 2 files changed, 12 insertions(+) diff

[edk2] [PATCH 0/4] Add PEI BlockIo support for NVM Express devices

The series is also available at: https://github.com/hwu25/edk2/tree/nvme_pei_blockio The series will add the PEI BlockIo support for NVM Express devices. A new EDKII PEI NVME host controller PPI will be introduced. It will provide the caller with the MMIO BAR address and the device path

[edk2] [PATCH 2/4] MdeModulePkg/NvmExpressPei: Add the NVME device PEI BlockIo support

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=256 This commit adds the PEI BlockIo support for NVM Express devices. The driver will consume the EDKII_NVM_EXPRESS_HOST_CONTROLLER_PPI for NVM Express host controllers within the system. And then produces the BlockIo(2) PPIs for each

[edk2] [PATCH 4/4] FatPkg/FatPei: Add the recognition of recovery capsule on NVME device

The driver now can recognize the BlockIo2 PPI for NVM Express devices. And support identifying the recovery capsule on those devices. Cc: Ruiyu Ni Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Hao Wu --- FatPkg/FatPei/FatLiteApi.c | 6 +-

[edk2] [PATCH 1/4] MdeModulePkg: Add definitions for EDKII PEI NVME host controller PPI

Introduces the below PPI: struct EDKII_NVM_EXPRESS_HOST_CONTROLLER_PPI { EDKII_NVM_EXPRESS_HC_GET_MMIO_BAR GetNvmeHcMmioBar; EDKII_NVM_EXPRESS_HC_GET_DEVICE_PATHGetNvmeHcDevicePath; }; The GetNvmeHcMmioBar service will provide the caller with the MMIO BAR address of each NVMe HC

Re: [edk2] [PATCH 1/2] Platform/ARM/Sgi: Install a Platform ID HOB

On 15 June 2018 at 08:16, Ard Biesheuvel wrote: > Hello Chandni, > > On 15 June 2018 at 07:55, Chandni Cherukuri wrote: >> On SGI platforms, the trusted firmware executes prior to >> the SEC phase. It supplies to the SEC phase a pointer to >> a fdt, that contains platform specific information

Re: [edk2] [PATCH 2/2] Platform/ARM/Sgi: Pick ACPI tables to install based on platform ID

Hello Chandni, On 15 June 2018 at 07:55, Chandni Cherukuri wrote: > Use the platform ID and config ID values from the platform ID > HOB to choose the right set of ACPI tables to be installed. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Chandni Cherukuri > --- >

Re: [edk2] [PATCH 1/2] Platform/ARM/Sgi: Install a Platform ID HOB

Hello Chandni, On 15 June 2018 at 07:55, Chandni Cherukuri wrote: > On SGI platforms, the trusted firmware executes prior to > the SEC phase. It supplies to the SEC phase a pointer to > a fdt, that contains platform specific information such as > part number and config number of the SGI