[edk2] 答复: Is the PEI Core MP Safe? UefiCpuPkg seems to think so calling GetFirstGuidHob on the APs?

Andrew, Not all services are permitted for AP routines. For example, MP->WhoAmI() could be invoked by AP by specified Current implementation should be safe. I also agree with IDT entry solution, as we did in DebugAgentLib. Thanks! Jeff 发件人: Andrew Fish 发送时间: 2018年6月21日

Re: [edk2] [PATCH v2 0/2] ArmPkg/ArmScmiDxe: Fix a bug uncovered with the new SCP firmware

On 19 June 2018 at 15:53, Girish Pathak wrote: > This patch series addresses comments on the original > https://github.com/girishpathak/edk2/tree/281_scmi_fix_v1 > > This series fixes a bug in the ArmScmiDxe which was revealed while > testing with the new SCP firmware. > > The changes can be seen

Re: [edk2] [Patch V3] FDF Spec: clean up the and usage in spec

Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Friday, June 22, 2018 10:09 AM >To: edk2-devel@lists.01.org >Cc: Kinney, Michael D ; Shaw, Kevin W >; Gao, Liming >Subject: [edk2] [Patch V3] FDF Spec:

Re: [edk2] unknown section type handling in ElfConvert

Hi Michael, We can update the VerboseMsg to same with the comment. We don't want to copy the unknown section. Best Regards, Zhu Yonghong -Original Message- From: Michael Zimmermann [mailto:sigmaepsilo...@gmail.com] Sent: Friday, June 08, 2018 11:46 PM To: edk2-devel-01 Cc: Zhu, Yongh

Re: [edk2] [PATCH v1] Readme.md: add Socionext SynQuacer in Supported Platforms

On 21 June 2018 at 05:13, wrote: > From: Masahisa Kojima > > Socionext SynQuacer(SC2A11) was already supported and > Developerbox(Linaro's 96Boards EE compliant board) is > publicly available. > Let's add in Supported Platforms. > > Signed-off-by: Masahisa Kojima Reviewed-by: Ard Biesheuvel

Re: [edk2] [PATCH v3 05/20] BaseTools: Use the python3-range functions

Hi Gary, Patch 03 used some Tab characters, Patch 17 has some Trailing whitespace. You can use the BaseTools\Scripts\PatchCheck.py to check its format. I try to build OVMF platform, it directly report error: from .BuildReport import BuildReport ValueError: Attempted relative import in non-packag

Re: [edk2] [PATCH v2 2/4] MdeModulePkg/NvmExpressPei: Add the NVME device PEI BlockIo support

On 6/22/2018 10:38 AM, Hao Wu wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=256 This commit adds the PEI BlockIo support for NVM Express devices. The driver will consume the EDKII_NVM_EXPRESS_HOST_CONTROLLER_PPI for NVM Express host controllers within the system. And then produces

Re: [edk2] [PATCH v2 1/4] MdeModulePkg: Add definitions for EDKII PEI NVME host controller PPI

On 6/22/2018 10:38 AM, Hao Wu wrote: Introduces the below PPI: struct EDKII_NVM_EXPRESS_HOST_CONTROLLER_PPI { EDKII_NVM_EXPRESS_HC_GET_MMIO_BAR GetNvmeHcMmioBar; EDKII_NVM_EXPRESS_HC_GET_DEVICE_PATHGetNvmeHcDevicePath; }; The GetNvmeHcMmioBar service will provide the caller with

Re: [edk2] [Patch][edk2-platforms/devel-IntelAtomProcessorE3900] Set BIOS LOCK

Reviewed-by: david@intel.com Thanks, David Wei Intel SSG/STO/UEFI BIOS -Original Message- From: Guo, Mang Sent: Friday, June 22, 2018 11:22 AM To: edk2-devel@lists.01.org Cc: Wei, David Subject: [Patch][edk2-platforms/devel-IntelAtomProcessorE3900]

[edk2] [Patch][edk2-platforms/devel-MinnowBoardMax-UDK2017] UART COM INT3511

Add sub-device under HS-UART 1 controller to report HS-UART as COM port. The _HID of the sub-device is INT3511. The design follows below Intel white paper: https://www.intel.com/content/dam/www/public/us/en/documents/white-papers/enabling-multi-com-port-white-paper.pdf Contributed-under: TianoCor

[edk2] [Patch][edk2-platforms/devel-IntelAtomProcessorE3900] Set BIOS LOCK

Set BIOS LOCK default value from 'disable' to 'enable' to meet security requirement. Cc: zwei4 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Guo Mang --- .../Common/PlatformSettings/PlatformSetupDxe/SouthClusterConfig.vfi | 6 +++--- 1 file changed, 3 insertions(+), 3

Re: [edk2] [Patch] MdeModulePkg BdsDxe: Correct VariableLockProtocol usage to match code logic

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Gao, Liming > Sent: Monday, June 18, 2018 10:58 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Zeng, Star > Subject: [Patch] MdeModulePkg BdsDxe: Correct VariableLockProtocol usage > to match code logic > > BdsEntry mark

[edk2] [PATCH v2 4/4] FatPkg/FatPei: Add the recognition of recovery capsule on NVME device

The driver now can recognize the BlockIo2 PPI for NVM Express devices. And support identifying the recovery capsule on those devices. Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Hao Wu Reviewed-by: Ruiyu Ni --- FatPkg/FatPei/FatLiteApi.c | 6 +- Fa

[edk2] [PATCH v2 1/4] MdeModulePkg: Add definitions for EDKII PEI NVME host controller PPI

Introduces the below PPI: struct EDKII_NVM_EXPRESS_HOST_CONTROLLER_PPI { EDKII_NVM_EXPRESS_HC_GET_MMIO_BAR GetNvmeHcMmioBar; EDKII_NVM_EXPRESS_HC_GET_DEVICE_PATHGetNvmeHcDevicePath; }; The GetNvmeHcMmioBar service will provide the caller with the MMIO BAR address of each NVMe HC wit

[edk2] [PATCH v2 2/4] MdeModulePkg/NvmExpressPei: Add the NVME device PEI BlockIo support

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=256 This commit adds the PEI BlockIo support for NVM Express devices. The driver will consume the EDKII_NVM_EXPRESS_HOST_CONTROLLER_PPI for NVM Express host controllers within the system. And then produces the BlockIo(2) PPIs for each controller

[edk2] [PATCH v2 3/4] MdeModulePkg: Add GUID for recovery capsule on NVM Express devices

Cc: Eric Dong Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Hao Wu Reviewed-by: Ruiyu Ni Reviewed-by: Star Zeng --- MdeModulePkg/Include/Guid/RecoveryDevice.h | 9 + MdeModulePkg/MdeModulePkg.dec | 3 +++ 2 files changed, 12 inserti

[edk2] [PATCH v2 0/4] Add PEI BlockIo support for NVM Express devices

The series is also available at: https://github.com/hwu25/edk2/tree/nvme_pei_blockio_v2 V2 updates: Patch 1/4: A. Remove the unnecessary input parameter 'PeiServices' from the 2 services of the EDKII PEI NVME host controller PPI. B. Fix typo of 'DevicePathLenth' to 'DevicePathLength' within the

[edk2] [Patch] BaseTools tools_def.template: Ignore link warning 4281 for VS2017

VS2017 reports warning LNK4281: undesirable base address 0x0 for x64 image; set base address above 4GB for best ASLR optimization. edk2 build always sets baes address to zero as default. So, ignore this link warning. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Ga

Re: [edk2] [Patch V2] SecurityPkg: Cache TPM interface type info

Reviewed-by: Long Qin Please correct the typos: + @retval EFI_SUCCESS DTPM2.0 instance is registered, or system dose not surpport registr DTPM2.0 instance

[edk2] [Patch V3] FDF Spec: clean up the and usage in spec

V3: recreate the patch base on latest version ::= {"PCD(" ")"} {} {} ::= {} {"$(NAMED_GUID)"} Cc: Liming Gao Cc: Michael Kinney Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- 3_edk_ii_fdf_file_format/32_fdf_definition.md |

Re: [edk2] [PATCH v3 05/20] BaseTools: Use the python3-range functions

On Thu, Jun 21, 2018 at 12:40:29PM +, Zhu, Yonghong wrote: > Hi Gary, > > Python 2.7 doesn't have the module builtins, if we apply this patch now, it > will cause build failure on Python 2.7. > Urhh, I thought it's a "built-in" module but it's actually from python-future. I'll revert this p

Re: [edk2] [Patch] MdeModulePkg BootMaintenanceManagerUiLib: Move refresh boot option later

Reviewed-by: Eric Dong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Thursday, June 21, 2018 8:06 PM To: edk2-devel@lists.01.org Cc: Xu, WeiX Subject: [edk2] [Patch] MdeModulePkg BootMaintenanceManagerUiLib: Move refresh boot

Re: [edk2] [PATCH v1 1/1] BaseTools/tools_def: Add WINGCC49 support

Yes. GCC49_ARM_PREFIX can be reused. The difference in GCC49 and GCC49xASL is ASL compiler. Their GCC part is same. > -Original Message- > From: Chris Co [mailto:christopher...@microsoft.com] > Sent: Friday, June 22, 2018 9:28 AM > To: Gao, Liming ; edk2-devel@lists.01.org > Cc: Zhu, Yon

Re: [edk2] [PATCH 2/4] MdeModulePkg/NvmExpressPei: Add the NVME device PEI BlockIo support

I think the code needs 1. Remove the check to S3 boot mode. 2. Use DEBUG_BLKIO in block read function. Thanks, Star -Original Message- From: Wu, Hao A Sent: Friday, June 15, 2018 3:04 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Zeng, Star ; Dong, Eric ; Ni, Ruiyu ; Yao, Jiewen Subj

Re: [edk2] [PATCH 3/4] MdeModulePkg: Add GUID for recovery capsule on NVM Express devices

Reviewed-by: Star Zeng -Original Message- From: Wu, Hao A Sent: Friday, June 15, 2018 3:04 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Zeng, Star ; Dong, Eric ; Ni, Ruiyu ; Yao, Jiewen Subject: [PATCH 3/4] MdeModulePkg: Add GUID for recovery capsule on NVM Express devices Cc: Sta

Re: [edk2] [PATCH 1/4] MdeModulePkg: Add definitions for EDKII PEI NVME host controller PPI

Please fix typo 'DevicePathLenth' to 'DevicePathLength'. With that, Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Wu, Hao A Sent: Friday, June 15, 2018 3:04 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Zeng, Star ; Dong, Eric ; Ni, Ruiyu ; Yao, Jiewen Subject: [PATC

[edk2] [Patch V2] SecurityPkg: Cache TPM interface type info

Cache TPM interface type info to avoid excessive interface ID register read Cc: Long Qin Cc: Yao Jiewen Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhang, Chao B --- SecurityPkg/Include/Library/Tpm2DeviceLib.h| 12 +++- .../Library/Tpm2DeviceLibDTpm/Tpm2Devic

Re: [edk2] [PATCH v1 1/1] BaseTools/tools_def: Add WINGCC49 support

> -Original Message- > From: Gao, Liming > Sent: Wednesday, June 20, 2018 9:56 PM > To: Chris Co ; edk2-devel@lists.01.org > Cc: Zhu, Yonghong ; Leif Lindholm > > Subject: RE: [PATCH v1 1/1] BaseTools/tools_def: Add WINGCC49 support > > Chris: > I suggest to name this tool chain as GCC

Re: [edk2] [platforms: PATCH v3 00/25] Armada hardware description rework

2018-06-21 17:06 GMT+02:00 Leif Lindholm : > > On Tue, Jun 19, 2018 at 12:58:19AM +0200, Marcin Wojtas wrote: > > Hi, > > > > The third version of the patchset comes with the single Signed-off-by, > > Reviewed-by's and corrected double parentheses in one of the headers. > > For the details, please

Re: [edk2] [PATCH v3 01/20] BaseTools: Fix a typo in ini.py

Reviewed-by: Jaben Carsey Note: I am not a maintainer of BaseTools and do not push commits for it :) > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Gary Lin > Sent: Wednesday, June 20, 2018 9:43 PM > To: edk2-devel@lists.01.org > Cc: Carse

Re: [edk2] [platforms: PATCH v3 00/25] Armada hardware description rework

On Tue, Jun 19, 2018 at 12:58:19AM +0200, Marcin Wojtas wrote: > Hi, > > The third version of the patchset comes with the single Signed-off-by, > Reviewed-by's and corrected double parentheses in one of the headers. > For the details, please check the changelog below. > > The patches are availabl

Re: [edk2] [PATCH] ArmPkg/ArmMmuLib ARM: fix Mva to use idx instead of table base

On 20 June 2018 at 21:09, Ard Biesheuvel wrote: > On 20 June 2018 at 18:39, Ard Biesheuvel wrote: >> On 19 June 2018 at 22:52, Chris Co wrote: >>> Hi, >>> >>> Just checking if there is anything needed on my end to get this patch >>> merged in. >>> >> >> Well, the patch looks obviously correct,

Re: [edk2] [PATCH v2 2/2] ArmPkg/ArmMmuLib ARM: assume page tables are in writeback cacheable memory

On 21 June 2018 at 16:01, Leif Lindholm wrote: > On Thu, Jun 21, 2018 at 10:13:15AM +0200, Ard Biesheuvel wrote: >> Given that these days, our ARM port only supports ARMv7 and later, we >> can assume that the page table walker's memory accesses are cache >> coherent, and so there is no need to per

Re: [edk2] [PATCH v2 2/2] ArmPkg/ArmMmuLib ARM: assume page tables are in writeback cacheable memory

On Thu, Jun 21, 2018 at 10:13:15AM +0200, Ard Biesheuvel wrote: > Given that these days, our ARM port only supports ARMv7 and later, we > can assume that the page table walker's memory accesses are cache > coherent, and so there is no need to perform cache maintenance. It > does require the page ta

Re: [edk2] [PATCH v3 05/20] BaseTools: Use the python3-range functions

Hi Gary, Python 2.7 doesn't have the module builtins, if we apply this patch now, it will cause build failure on Python 2.7. Best Regards, Zhu Yonghong -Original Message- From: Gary Lin [mailto:g...@suse.com] Sent: Thursday, June 21, 2018 12:44 PM To: edk2-devel@lists.01.org Cc: Zhu,

Re: [edk2] [PATCH edk2-platforms v1][platforms/devel-dynamictables] Platform/ARM: Fix OEM Table ID length in DSDT

On Wed, Jun 20, 2018 at 05:42:54PM +0100, Sami Mujawar wrote: > The OEM Table ID length cannot be more than 8 characters. > Moreover, the ACPICA iASL compiler patch "Add error messages > for ACPI tables with bad OEM and OEM Table IDs" dated > 13 April 2018 [20180413] > (https://github.com/acpica/ac

[edk2] [Patch] MdeModulePkg BootMaintenanceManagerUiLib: Move refresh boot option later

Constructor is too early that ConnectAll() may not do. Move refresh boot option in form open. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Xu WeiX Reviewed-by: Liming Gao --- MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenance.c | 3 +-- 1 file changed,

Re: [edk2] [PATCH] ArmPkg/ArmMmuLib ARM: remove cache maintenance of block mapping contents

Replying to this one rather than the new patches, to keep the thread going. On Thu, Jun 21, 2018 at 08:21:22AM +0200, Ard Biesheuvel wrote: > On 21 June 2018 at 00:05, Leif Lindholm wrote: > > On Wed, Jun 20, 2018 at 09:10:07PM +0200, Ard Biesheuvel wrote: > >> Peculiarly enough, the current page

Re: [edk2] [PATCH 2/4] MdeModulePkg/NvmExpressPei: Add the NVME device PEI BlockIo support

> -Original Message- > From: Ni, Ruiyu > Sent: Thursday, June 21, 2018 3:46 PM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Zeng, Star; Dong, Eric; Yao, Jiewen > Subject: RE: [PATCH 2/4] MdeModulePkg/NvmExpressPei: Add the NVME > device PEI BlockIo support > > 2 minor comments. Ray, Th

Re: [edk2] [PATCH 1/4] MdeModulePkg: Add definitions for EDKII PEI NVME host controller PPI

Hi Ray, Thanks for the feedbacks. I will propose a V2 version of the series according to your comments. Best Regards, Hao Wu > -Original Message- > From: Ni, Ruiyu > Sent: Thursday, June 21, 2018 3:36 PM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Zeng, Star; Dong, Eric; Yao, Jiewen

[edk2] [PATCH v2 1/2] ArmPkg/ArmMmuLib ARM: remove cache maintenance of block mapping contents

Peculiarly enough, the current page table manipulation code takes it upon itself to write back and invalidate the memory contents covered by section mappings when their memory attributes change. It is not generally the case that data must be written back when such a change occurs, even when switchi

[edk2] [PATCH v2 0/2] ArmMmuLib ARM: remove cache maintenance

Follow up series to v2 'ArmMmuLib ARM: remove cache maintenance of block mapping contents' Patch #1 updated to remove more cache maintenance of memory *content* Patch #2 added to remove cache maintenance of page table entries themselves, and to remove support for storing page tables in memory tha

[edk2] [PATCH v2 2/2] ArmPkg/ArmMmuLib ARM: assume page tables are in writeback cacheable memory

Given that these days, our ARM port only supports ARMv7 and later, we can assume that the page table walker's memory accesses are cache coherent, and so there is no need to perform cache maintenance. It does require the page tables themselves to reside in memory mapped as writeback cacheable so ASS

Re: [edk2] [Patch] BaseTools: remove the unneeded code

Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhu, >Yonghong >Sent: Wednesday, June 13, 2018 9:13 AM >To: edk2-devel@lists.01.org >Subject: [edk2] [Patch] BaseTools: remove the unneeded code > >Do a clean up to remove t

Re: [edk2] [Patch] BaseTools: Enhance BaseTools supports FeaturePcd usage in VFR file

Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhu, >Yonghong >Sent: Tuesday, June 19, 2018 9:11 AM >To: edk2-devel@lists.01.org >Subject: [edk2] [Patch] BaseTools: Enhance BaseTools supports FeaturePcd >usage in VFR fil

Re: [edk2] [PATCH 3/4] MdeModulePkg: Add GUID for recovery capsule on NVM Express devices

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Wu, Hao A > Sent: Friday, June 15, 2018 3:04 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Zeng, Star ; > Dong, Eric ; Ni, Ruiyu ; Yao, > Jiewen > Subject: [PATCH 3/4] MdeModulePkg: Add GUID for recovery capsule on > NVM

Re: [edk2] [PATCH 4/4] FatPkg/FatPei: Add the recognition of recovery capsule on NVME device

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Wu, Hao A > Sent: Friday, June 15, 2018 3:04 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Ni, Ruiyu ; Yao, > Jiewen > Subject: [PATCH 4/4] FatPkg/FatPei: Add the recognition of recovery capsule > on NVME device > > The

Re: [edk2] [PATCH 2/4] MdeModulePkg/NvmExpressPei: Add the NVME device PEI BlockIo support

2 minor comments. Thanks/Ray > -Original Message- > From: Wu, Hao A > Sent: Friday, June 15, 2018 3:04 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Zeng, Star ; > Dong, Eric ; Ni, Ruiyu ; Yao, > Jiewen > Subject: [PATCH 2/4] MdeModulePkg/NvmExpressPei: Add the NVME > device PEI Blo

Re: [edk2] [PATCH 1/4] MdeModulePkg: Add definitions for EDKII PEI NVME host controller PPI

Thanks/Ray > -Original Message- > From: Wu, Hao A > Sent: Friday, June 15, 2018 3:04 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Zeng, Star ; > Dong, Eric ; Ni, Ruiyu ; Yao, > Jiewen > Subject: [PATCH 1/4] MdeModulePkg: Add definitions for EDKII PEI NVME > host controller PPI >