Reviewed-by: zwei4
Thanks,
David Wei
Intel SSG/STO/UEFI BIOS
-Original Message-
From: Guo, Mang
Sent: Thursday, June 28, 2018 9:48 AM
To: edk2-devel@lists.01.org
Cc: Wei, David ; Yao, Jiewen
Subject:
Call InstallReadyToLock after PlatformBdsConnectConsole and ProcessCapsules in
flash update boot mode to fix capsule update failure issue.
CC: Wei, David
CC: Yao, Jiewen
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Guo Mang
---
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=952
Cc: Anbazhagan Baraneedharan
Cc: Star Zeng
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao Wu
---
MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.c | 4 ++--
MdeModulePkg/Bus/Sd/SdDxe/SdDxe.c | 4 ++--
2
Correction:
Should be V1 of the patch.
Best Regards,
Hao Wu
> -Original Message-
> From: Wu, Hao A
> Sent: Thursday, June 28, 2018 9:39 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A; Zeng, Star; Shi, Steven; Dong, Eric
> Subject: [PATCH v2] MdeModulePkg/AtaPassThru: Add missing NULL
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=916
Within function AtaAtapiPassThruStart():
Add missing NULL pointer check for variable 'Instance' under the
'ErrorExit' code logics.
Cc: Star Zeng
Cc: Steven Shi
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.1
1) add a property so others can access needed data
2) change GenMake to use property
3) add local variable in GenMake to speed up access
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
> -Original Message-
> From: Chris Co
> Sent: Wednesday, June 27, 2018 11:23 AM
> To: 'Evan Lloyd' ; 'edk2-devel@lists.01.org' de...@lists.01.org>; 'Liming Gao'
> Cc: 'Leif Lindholm' ; Sami Mujawar
>
> Subject: RE: [PATCH v1 1/1] BaseTools/Trim: Canonicalize filepaths to fix
>
Hi Liming, Michael,
Looks like this patchset
(https://lists.01.org/pipermail/edk2-devel/2018-April/024255.html) is not yet
in edk2.
Can you let me know if you need anything else from me before this patchset can
be merged, please?
Regards,
Sami Mujawar
-Original Message-
From: Gao,
Forgot to add that I'll try out the os.path.normpath/normcase to see if this
will work.
> -Original Message-
> From: Chris Co
> Sent: Wednesday, June 27, 2018 11:13 AM
> To: 'Evan Lloyd' ; edk2-devel@lists.01.org; Liming
> Gao
> Cc: Leif Lindholm ; Sami Mujawar
>
> Subject: RE: [PATCH
Hi Liming, Evan,
I have attached an example of a generated DSDT.iii file which gets processed
using Trim. It will give us a concrete example of what these changes do.
The first line has its #line directive stripped and the filepath saved as the
PreProcessedFile. In GCC49, the filepath was:
On 06/27/2018 11:59 AM, Laszlo Ersek wrote:
On 06/27/18 18:34, Brijesh Singh wrote:
On 06/27/2018 07:54 AM, Laszlo Ersek wrote:
On 06/26/18 21:46, Brijesh Singh wrote:
After that, any access
to the flash will end up going through the encryption engine. I did try
hacking EDK2 to restore
On 06/27/18 18:34, Brijesh Singh wrote:
> On 06/27/2018 07:54 AM, Laszlo Ersek wrote:
>> On 06/26/18 21:46, Brijesh Singh wrote:
>>> After that, any access
>>> to the flash will end up going through the encryption engine. I did try
>>> hacking EDK2 to restore the C-bit
>>
>> (I continue to be
Signed-off-by: Evan Lloyd
> -Original Message-
> From: Sami Mujawar
> Sent: 27 June 2018 17:49
> To: edk2-devel@lists.01.org
> Cc: Arvind Chauhan ; Daniil Egranov
> ; Thomas Abraham
> ; leif.lindh...@linaro.org; Evan Lloyd
> ; Matteo Carlini ;
> Stephanie Hughes-Fitt ; nd
>
>
Signed-off-by: Evan Lloyd
> -Original Message-
> From: Sami Mujawar
> Sent: 27 June 2018 17:48
> To: edk2-devel@lists.01.org
> Cc: leif.lindh...@linaro.org; Evan Lloyd ; Matteo
> Carlini ; Stephanie Hughes-Fitt
> ; nd
> Subject: [staging/dynamictables PATCH v1 0/5] Fix issues reported
Fixed function documentation issues reported by ecc tool.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sami Mujawar
---
Notes:
v1:
- Fix ecc tool reported issues [SAMI]
The ecc tool reports that the Header comment section must
have Abstract information.
Added a brief module description to the file header.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sami Mujawar
---
The changes can be seen at
The ecc tool reports that the Header comment section must
have Abstract information.
Added a brief module description to the file header.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sami Mujawar
---
Notes:
v1:
- Fix ecc tool reported issues
Fixed function documentation issues reported by ecc tool.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sami Mujawar
---
Notes:
v1:
- Fix ecc tool reported issues [SAMI]
Fixed the 'There should be no initialization of a variable
as part of its declaration Variable Name' errors reported
by the ecc tool.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sami Mujawar
---
Notes:
v1:
- Fix ecc tool reported issues
Fixed the 'There should be no initialization of a variable
as part of its declaration Variable Name' errors reported
by the ecc tool.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sami Mujawar
---
Notes:
v1:
- Fix ecc tool reported issues
This patch series fixes the issues reported by the ecc tool.
The changes can be seen at
https://github.com/samimujawar/edk2-platforms/tree/290_fix_ecc_issues_v1
Sami Mujawar (6):
Platform/ARM: FVP: Add module info to file header
Platform/ARM: FVP: Fix function documentation
Platform/ARM:
Fixed the 'There should be no initialization of a variable
as part of its declaration Variable Name' errors reported
by the ecc tool.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sami Mujawar
---
Notes:
v1:
- Fix ecc tool reported issues
The ecc tool reports that the Header comment section must
have Abstract information.
Added a brief module description to the file header.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sami Mujawar
---
The changes can be seen at
Fixed function documentation issues reported by ecc tool.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sami Mujawar
---
Notes:
v1:
- Fix ecc tool reported issues [SAMI]
The ALIGN32 macro had undesired side effects when used with binary
operators and was generating compilation errors.
Added brackets to fix this issue.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sami Mujawar
---
Notes:
v1:
- Fix macro side effect
This patch series fixes the issues reported by the ecc tool.
The changes can be seen at
https://github.com/samimujawar/edk2-staging/tree/290_fix_ecc_issues_v1
Sami Mujawar (5):
DynamicTablesPkg: Add module info to file header
DynamicTablesPkg: Fix function documentation
DynamicTablesPkg:
Fixed variable naming issues reported by the ecc tool.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sami Mujawar
---
Notes:
v1:
- Fix ecc tool reported issues [SAMI]
On 06/27/2018 11:34 AM, Brijesh Singh wrote:
I think (2) will solve the complete issue, we still need to figure how
I meant to say (2) will *not* solve the complete issue !
___
edk2-devel mailing list
edk2-devel@lists.01.org
Thanks for the quick feedback Laszlo !
On 06/27/2018 07:54 AM, Laszlo Ersek wrote:
On 06/26/18 21:46, Brijesh Singh wrote:
Problem statement:
--
Fedora-28 contains 4.16 kernel -- which has all the required support to
run as an SEV guest. When the installer is launched from
Create the 2 comparison objects once outside the loop.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/AutoGen/AutoGen.py | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git
Hi Liming:
Thanks for catching this. Reviewed-by: Chao Zhang
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming
Gao
Sent: Wednesday, June 27, 2018 10:49 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch] SecurityPkg Tpm2DeviceLibDTpm:
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao
---
SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2DeviceLibDTpm.c | 2 +-
SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2InstanceLibDTpm.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
On 06/26/18 21:46, Brijesh Singh wrote:
> Problem statement:
> --
> Fedora-28 contains 4.16 kernel -- which has all the required support to
> run as an SEV guest. When the installer is launched from SEV guest then
> it fails to install the bootloader. The installer was failing to
On 06/27/18 08:00, Ni, Ruiyu wrote:
> On 6/27/2018 2:57 AM, Laszlo Ersek wrote:
>> Second, even assuming that PushCpuMpData() and PopCpuMpData() are
>> atomic, the order in which APs complete the AP procedure is not
>> deterministic, and it need not be the exact reverse of the entry order.
>> We
Hi Chris.
Firstly, thank you: this is a useful, pragmatic solution to an major annoyance.
I personally think it unfortunate that the GCC guys can't be bothered to fix
their compiler, but ...
> -Original Message-
> From: edk2-devel On Behalf Of Chris Co
> Sent: 27 June 2018 04:58
> To:
Replace "<>" with "!=" to be compatible with python3.
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Source/Python/Workspace/DscBuildData.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Per PEP237(*), 'long' is unified with 'int' and removed from python3.
* To make the script compatible with both python2 and python3,
'type(0L)' is replaced with 'type(sys.maxsize + 1)'. In python2,
the number is 'long', while it's 'int' in python3. We can remove
the workaround after moving
This is the follow-up patch set for my previous python3 patch series:
https://lists.01.org/pipermail/edk2-devel/2018-June/026499.html
* A replacement of "<>" is missed in the previous series, and this is
fixed in this patch set.
* The previous patch to unify long and int caused the build
When PYTHON_DEFAULT is set as "python3", the bash scripts in PosixLike
will perfer python3. Currently, this is for the evaluation of the python3
support and errors from the python3 interperter are expected.
For example, to build OvmfPkg with python3:
$ export PYTHON_DEFAULT=python3
$
Sami, Evan? I think we need your input/review here.
On Wed, Jun 27, 2018 at 03:58:06AM +, Chris Co wrote:
> When using Linaro GCC5+ arm-eabi toolchain on Windows, the generated
> DSDT.iii contains a canonicalized ("\.\" removed and lower case)
> filepath for the preprocessed DSDT.i file in
Please ignore this incorrect patch.
--
Thanks,
Ray
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Reviewed-by: Liming Gao
>-Original Message-
>From: Zhu, Yonghong
>Sent: Wednesday, June 27, 2018 2:17 PM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming ; Kinney, Michael D
>; Shaw, Kevin W
>Subject: [Patch] FDF spec: document WEAK_ALIGNMENT attribute
>
>WEAK_ALIGNMENT FV attribute is
On Mon, Jun 25, 2018 at 12:44:21PM +0800, Zhang, Chao B wrote:
> Directly transition from CMD completion to CMD Ready state if device
> supports IdleByPass
>
> Cc: Long Qin
> Cc: Yao Jiewen
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Chao Zhang
> Signed-off-by:
Today's MpInitLib PEI implementation directly calls
PeiServices->GetHobList() from AP which may cause racing issue.
This patch fixes this issue by storing the CpuMpData to memory
preceding IDT. Pointer to PeiServices pointer is stored there,
so after AP procedure returns, the PeiServices pointer
HttpBodyParserCallback function is to parse the HTTP(S) message body so as to
confirm whether there is the next message header. But it doesn't record the
parsing message data/length correctly.
This patch is refine the parsing logic so as to fix the potential failure.
Cc: Ye Ting
Cc: Fu Siyuan
On 27 June 2018 at 09:04, Ming Huang wrote:
> Optimize pcie space for promoting usage rate.Change regions order
> of NA-Pcie2 and NB-Pcie1 to MEM-ECAM-IO in DAW,so MemoryRegion
> can satisfy the requirement of larger address alignment.
>
OK, so I suppose it is the ECAM shift mode that is forcing
On 27 June 2018 at 09:04, Ming Huang wrote:
> Fix the issue of onboard Nic not work kerenl with AMD GPU and
> NVME SSD in board. The GPU don't support 64 MSI, so need to
> allocate INTx, but the default interrupt number 255 is invalid,
> so Change all the PCI Device interrupt number to 0.
>
On 27 June 2018 at 09:04, Ming Huang wrote:
> From: Jason Zhang
>
> 1. During test PCIe mcs9922 UART card, the card can't
>work because the IO ATU config is overlap by Cfg0/Cfg1
>ATU address.
> 2. After adjust the ATU windows, Cfg0/Cfg1 config as below:
> Cfg0 is equal to "ECAM +
The patch seems good to me.
Reviewed-by: Hao Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Bi, Dandan
> Sent: Wednesday, June 27, 2018 2:16 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming; Wu, Hao A
> Subject: [patch] MdeModulePkg/PerformanceLib: Add NULL pointer check
>
>
On 27 June 2018 at 09:04, Ming Huang wrote:
> The edk2 commit bacfd6e let CpuDxe running latter. CpuDxe should run early.
> CpuDxe is needed by gDS->SetMemorySpaceAttributes, and
> gDS->SetMemorySpaceAttributes is invoked by several drivers.
>
> Add several drives to APRIORI scope for
Yonghong:
Below statement is wrong. Please remove it. FTW region header must be filled
with guid 9e58292b-7c68-497d-a0ce6500fd9f1b95. This GUID is not FileSystemGuid.
+The `VariableSignatureGuid`, `VariabeRegionSize` and `FtwWorkingSpaceSize` must
+exist when `FileSystemGuid` value is same as
The product name getting from BMC is not suitable.
It may cause ambiguity.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
Signed-off-by: Heyi Guo
---
Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunction.c
| 1 -
1 file
The MemLimit is wrong when the Private->BusLimit equal 0xFF.
This patch fix enumerating device plug in switch cart failed issue.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
Signed-off-by: Heyi Guo
---
Fix the issue of onboard Nic not work kerenl with AMD GPU and
NVME SSD in board. The GPU don't support 64 MSI, so need to
allocate INTx, but the default interrupt number 255 is invalid,
so Change all the PCI Device interrupt number to 0.
Contributed-under: TianoCore Contribution Agreement 1.1
From: Jason Zhang
1. During test PCIe mcs9922 UART card, the card can't
work because the IO ATU config is overlap by Cfg0/Cfg1
ATU address.
2. After adjust the ATU windows, Cfg0/Cfg1 config as below:
Cfg0 is equal to "ECAM + (BusBase, 0, 0)"
Cfg1 is equal to "ECAM + (BusBase + 2,
Optimize pcie space for promoting usage rate.Change regions order
of NA-Pcie2 and NB-Pcie1 to MEM-ECAM-IO in DAW,so MemoryRegion
can satisfy the requirement of larger address alignment.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
Signed-off-by: Heyi Guo
---
The edk2 commit bacfd6e let CpuDxe running latter. CpuDxe should run early.
CpuDxe is needed by gDS->SetMemorySpaceAttributes, and
gDS->SetMemorySpaceAttributes is invoked by several drivers.
Add several drives to APRIORI scope for implementing the ordering.
Contributed-under: TianoCore
Installing OS by iso is supported by edk2 commit(824b6e3b5f).
Code can also be found in github:
https://github.com/hisilicon/OpenPlatformPkg.git
branch: platforms-20180627
Jason Zhang (1):
Hisilicon/D03/D05: Correct ATU Cfg0/Cfg1 base address
Ming Huang (5):
Hisilicon/D0x: Fix invoke
Reviewed-by: Liming Gao
>-Original Message-
>From: Bi, Dandan
>Sent: Wednesday, June 27, 2018 2:16 PM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming ; Zeng, Star
>Subject: [patch] MdeModulePkg/PiSmmCore: Remove SMM Perf entry
>
>The perf measurement entry in SmmEntryPoint function
Chris:
Could you provide the generated Makefile for DSDT.asl? I would like to see
what command is generated in Makefile to handle DSDT.asl.
Thanks
Liming
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
>Chris Co
>Sent: Wednesday, June 27,
The perf measurement entry in SmmEntryPoint function
doesn't have significant meaning. So remove it now.
Cc: Liming Gao
Cc: Star Zeng
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi
---
MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 4
1 file changed, 4
1. Add NULL pointer check for the "Guid" parameter
when handle FPDT_DUAL_GUID_STRING_EVENT_TYPE.
2. Make the code logic in DxeCore/SmmCore/PeiPerformanceLib
aligned when handle FPDT_DUAL_GUID_STRING_EVENT_TYPE.
Cc: Liming Gao
Cc: Hao Wu
Contributed-under: TianoCore Contribution Agreement
WEAK_ALIGNMENT FV attribute is supported by GenFds, but is not
documented in the FDF specification.
Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=892
Cc: Liming Gao
Cc: Michael Kinney
Cc: Kevin W Shaw
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu
On 6/27/2018 2:57 AM, Laszlo Ersek wrote:
Second, even assuming that PushCpuMpData() and PopCpuMpData() are
atomic, the order in which APs complete the AP procedure is not
deterministic, and it need not be the exact reverse of the entry order.
We may have the following order, for example:
- AP
64 matches
Mail list logo
