Re: [edk2] Reg: Intel Rangley Support in EDK

2018-07-13 Thread You, Benjamin
Hi Dhanasekar, The Coreboot UEFI Payload does support serial and terminal. As Nate said below, there may be some configuration issue causing the display not correctly formatted through serial terminal. I also agree with Nate that since your board does not have a VGA connection, you might have

Re: [edk2] Reg: Intel Rangley Support in EDK

2018-07-13 Thread Desimone, Nathaniel L
Hi Dhanasekar, I don't know very much about coreboot or the coreboot UEFI payload, so I won't be able to help you much with that. From what you mention in your message it sounds like either the coreboot UEFI payload does not include the TerminalDxe driver, there is a configuration issue with

Re: [edk2] [PATCH v1] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS2017 compilation errors

2018-07-13 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey Adding Eric Dong also. > -Original Message- > From: AlexeiFedorov [mailto:alexei.fedo...@arm.com] > Sent: Friday, July 13, 2018 8:17 AM > To: edk2-devel@lists.01.org > Cc: ard.biesheu...@linaro.org; leif.lindh...@linaro.org; > matteo.carl...@arm.com;

[edk2] [PATCH v1] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS2017 compilation errors

2018-07-13 Thread AlexeiFedorov
This patch fixes VS2017 compilation errors for UefiShellAcpiViewCommandLib\Parsers\Gtdt\GtdtParser.c and UefiShellAcpiViewCommandLib\Parsers\Xsdt\XsdtParser.c reported in https://bugzilla.tianocore.org/show_bug.cgi?id=985 https://bugzilla.tianocore.org/show_bug.cgi?id=986 Contributed-under:

Re: [edk2] [PATCH v2 00/16] BaseTools: Adopt absolute import

2018-07-13 Thread Carsey, Jaben
Nice. Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Gary Lin > Sent: Friday, July 13, 2018 3:19 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [PATCH v2 00/16] BaseTools: Adopt absolute

[edk2] [PATCH v2 09/10] StandaloneMmPkg: Add CPU driver suitable for ARM Platforms.

2018-07-13 Thread Sughosh Ganu
From: Supreeth Venkatesh This patch adds a simple CPU driver that exports the EFI_MM_CONFIGURATION_PROTOCOL to allow registration of the Standalone MM Foundation entry point. It preserves the existing notification mechanism for the configuration protocol. Contributed-under: TianoCore

[edk2] [PATCH v2 10/10] StandaloneMmPkg: Describe the declaration and definition files.

2018-07-13 Thread Sughosh Ganu
From: Supreeth Venkatesh This patch describes the package declarations and definitions for creating standalone management mode image with core/foundation and drivers. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh Reviewed-by: Achin Gupta

[edk2] [PATCH v2 08/10] StandaloneMmPkg: Add an AArch64 specific entry point library.

2018-07-13 Thread Sughosh Ganu
From: Supreeth Venkatesh The Standalone MM environment runs in S-EL0 in AArch64 on ARM Standard Platforms and is initialised during the SEC phase. ARM Trusted firmware in EL3 is responsible for initialising the architectural context for S-EL0 and loading the Standalone MM image. The memory

[edk2] [PATCH v2 06/10] StandaloneMmPkg: MM driver entry point library.

2018-07-13 Thread Sughosh Ganu
From: Supreeth Venkatesh This patch implements module entry point library for Standalone management mode (MM) Drivers. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh Reviewed-by: Achin Gupta Reviewed-by: Jiewen Yao Signed-off-by: Sughosh Ganu ---

[edk2] [PATCH v2 04/10] StandaloneMmPkg/MemoryAllocationLib: Add MM memory allocation library.

2018-07-13 Thread Sughosh Ganu
From: Supreeth Venkatesh This patch implements management mode memory allocation services. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh Reviewed-by: Achin Gupta Reviewed-by: Jiewen Yao Signed-off-by: Sughosh Ganu ---

[edk2] [PATCH v2 03/10] StandaloneMmPkg/MemLib: Add Standalone MM instance of memory check library.

2018-07-13 Thread Sughosh Ganu
From: Supreeth Venkatesh MM memory check library library implementation. This library consumes MM_ACCESS_PROTOCOL to get MMRAM information. In order to use this library instance, the platform should produce all MMRAM range via MM_ACCESS_PROTOCOL, including the range for firmware (like MM Core

[edk2] [PATCH v2 02/10] StandaloneMmPkg/FvLib: Add a common FV Library for management mode.

2018-07-13 Thread Sughosh Ganu
From: Supreeth Venkatesh This patch implements a firmware volume library that can be used by the Standalone management mode core module to parse the firmware volume. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh Reviewed-by: Achin Gupta Reviewed-by:

[edk2] [PATCH v2 05/10] StandaloneMmPkg/HobLib: Add HOB Library for management mode.

2018-07-13 Thread Sughosh Ganu
From: Supreeth Venkatesh The Standalone MM environment is initialized during the SEC phase on ARM Standard Platforms. The MM Core driver implements an entry point module which is architecture specific and runs prior to the generic core driver code. The former creates a Hob list that the latter

[edk2] [PATCH v2 01/10] StandaloneMmPkg: Delete StandaloneMmPkg file.

2018-07-13 Thread Sughosh Ganu
From: Supreeth Venkatesh This patch deletes "StandaloneMmPkg" which was created as a file intially. This patch enables creation of "StandaloneMmPkg" as a folder. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh Reviewed-by: Achin Gupta Reviewed-by:

[edk2] [PATCH v2 00/10] Standalone Management Mode Core Interface for AARCH64 Platforms

2018-07-13 Thread Sughosh Ganu
The following patch series adds StandaloneMM core interface for aarch64 platforms. Following earlier comments from Jeiwen [1], the patch series has been split into three parts and this series handles StandaloneMMPkg related changes. [1] -

Re: [edk2] [PATCH v2] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS2017 compilation errors

2018-07-13 Thread Carsey, Jaben
This patch look good, and with this the v1 looks good, but I don't see a single patch that I could apply and push. Can you send out a single patch with all the changes? -Jaben > -Original Message- > From: AlexeiFedorov [mailto:alexei.fedo...@arm.com] > Sent: Friday, July 13, 2018 4:06

Re: [edk2] [platforms: PATCH 1/6] Marvell/Library: ComPhyLib: Configure SATA, SGMII and SFI in ARM-TF

2018-07-13 Thread Ard Biesheuvel
On 13 July 2018 at 16:09, Marcin Wojtas wrote: > From: Grzegorz Jaszczyk > > Replace all ComPhy initialization with appropriate smc calls. It will > result with triggering synchronous exception that is handled by Secure > Monitor code in EL3. Then the Secure Monitor code will dispatch each smc >

[edk2] [platforms: PATCH 3/6] Marvell/Library: ComPhyLib: Configure RXAUI in ARM-TF

2018-07-13 Thread Marcin Wojtas
From: Grzegorz Jaszczyk Replace the comphy initialization for RXAUI with appropriate SMC call, so the firmware will execute required serdes configuration. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Library/ComPhyLib/ComPhyLib.h |

[edk2] [platforms: PATCH 5/6] Marvell/Library: ComPhyLib: Clean up the library after rework

2018-07-13 Thread Marcin Wojtas
From: Grzegorz Jaszczyk Because all ComPhy related initialization was moved to ARM-TF all register definitions and some related routines/structures became unused. This commit removes them. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas ---

[edk2] [platforms: PATCH 6/6] Marvell/Library: ComPhyLib: Remove both PHY and PIPE selector config

2018-07-13 Thread Marcin Wojtas
From: Grzegorz Jaszczyk Now the ComPhy configuration is handled in ARM-TF, therefore there is no need to configure PHY or PIPE selector in UEFI. Remove unused code. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas ---

[edk2] [platforms: PATCH 4/6] Marvell/Library: ComPhyLib: Configure USB in ARM-TF

2018-07-13 Thread Marcin Wojtas
From: Grzegorz Jaszczyk Replace the comphy initialization for USB with appropriate SMC call, so the firmware will execute required serdes configuration. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Library/ComPhyLib/ComPhyCp110.c |

[edk2] [platforms: PATCH 0/6] Armada7k8k ComPhy rework

2018-07-13 Thread Marcin Wojtas
Hi, This patchset makes use of the feature present in newest, publicly available ARM-TF of the Armada7k8k SoCs (https://github.com/MarvellEmbeddedProcessors/atf-marvell/commits/atf-v1.4-armada-18.06) which is a common configuration of the serdes lanes. It is triggered by the users

[edk2] [platforms: PATCH 2/6] Marvell/Library: ComPhyLib: Configure PCIE in ARM-TF

2018-07-13 Thread Marcin Wojtas
From: Grzegorz Jaszczyk Replace the ComPhy initialization for PCIE with appropriate SMC call, so the firmware will execute required serdes configuration. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas ---

[edk2] [platforms: PATCH 1/6] Marvell/Library: ComPhyLib: Configure SATA, SGMII and SFI in ARM-TF

2018-07-13 Thread Marcin Wojtas
From: Grzegorz Jaszczyk Replace all ComPhy initialization with appropriate smc calls. It will result with triggering synchronous exception that is handled by Secure Monitor code in EL3. Then the Secure Monitor code will dispatch each smc call (by parsing the smc function identifier) and trigger

Re: [edk2] Inquiry regarding early DxeIplPeim loading.

2018-07-13 Thread Marvin H?user
Hey Star, Thank you very much for your reply. Interesting, that is basically the case I described as "insane" because I did not consider any platform to allow S3 resume without memory initialization. So, this code definitely makes sense. You are right, according to the specification, moving it

[edk2] [PATCH v1] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS2017 compilation errors

2018-07-13 Thread AlexeiFedorov
From: AlexeiFedorov This patch fixes VS2017 compilation errors for UefiShellAcpiViewCommandLib\Parsers\Gtdt\GtdtParser.c and UefiShellAcpiViewCommandLib\Parsers\Xsdt\XsdtParser.c reported in https://bugzilla.tianocore.org/show_bug.cgi?id=985 https://bugzilla.tianocore.org/show_bug.cgi?id=986

[edk2] [PATCH v2] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS2017 compilation errors

2018-07-13 Thread AlexeiFedorov
Please find v2 patch which corrects local variable name SigPtr to SignaturePtr. This patch fixes VS2017 compilation errors for UefiShellAcpiViewCommandLib\Parsers\Gtdt\GtdtParser.c and UefiShellAcpiViewCommandLib\Parsers\Xsdt\XsdtParser.c reported in

[edk2] [PATCH v2 16/16] BaseTools: Use absolute import in Scripts

2018-07-13 Thread Gary Lin
Based on "futurize -f libfuturize.fixes.fix_absolute_import Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Yonghong Zhu Cc: Liming Gao Signed-off-by: Gary Lin --- BaseTools/Scripts/PackageDocumentTools/plugins/EdkPlugins/basemodel/doxygen.py | 3 ++-

[edk2] [PATCH v2 15/16] BaseTools: Use absolute import in Workspace

2018-07-13 Thread Gary Lin
Based on "futurize -f libfuturize.fixes.fix_absolute_import Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Yonghong Zhu Cc: Liming Gao Signed-off-by: Gary Lin --- BaseTools/Source/Python/Workspace/DscBuildData.py | 9 +

[edk2] [PATCH v2 14/16] BaseTools: Use absolute import in UPT

2018-07-13 Thread Gary Lin
Based on "futurize -f libfuturize.fixes.fix_absolute_import Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Yonghong Zhu Cc: Liming Gao Signed-off-by: Gary Lin --- BaseTools/Source/Python/UPT/Library/Parsing.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[edk2] [PATCH v2 13/16] BaseTools: Use absolute import in Table

2018-07-13 Thread Gary Lin
Based on "futurize -f libfuturize.fixes.fix_absolute_import Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Yonghong Zhu Cc: Liming Gao Signed-off-by: Gary Lin --- BaseTools/Source/Python/Table/TableDataModel.py | 3 ++- BaseTools/Source/Python/Table/TableDec.py| 3 ++-

[edk2] [PATCH v2 12/16] BaseTools: Use absolute import in Eot

2018-07-13 Thread Gary Lin
Based on "futurize -f libfuturize.fixes.fix_absolute_import Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Yonghong Zhu Cc: Liming Gao Signed-off-by: Gary Lin --- BaseTools/Source/Python/Eot/CParser.py | 5 +++-- BaseTools/Source/Python/Eot/CodeFragmentCollector.py

[edk2] [PATCH v2 11/16] BaseTools: Use absolute import in Ecc

2018-07-13 Thread Gary Lin
Based on "futurize -f libfuturize.fixes.fix_absolute_import Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Yonghong Zhu Cc: Liming Gao Signed-off-by: Gary Lin --- BaseTools/Source/Python/Ecc/CParser.py | 5 ++-- BaseTools/Source/Python/Ecc/Check.py

[edk2] [PATCH v2 10/16] BaseTools: Treat Ecc.py as a python module

2018-07-13 Thread Gary Lin
Since Ecc.py import modules from its own directory, add "-m" to the python parameters so that they can import its own modules after adopting absolute import. Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Yonghong Zhu Cc: Liming Gao Signed-off-by: Gary Lin Signed-off-by: Gary Lin

[edk2] [PATCH v2 09/16] BaseTools: Use absolute import in Common

2018-07-13 Thread Gary Lin
Based on "futurize -f libfuturize.fixes.fix_absolute_import Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Yonghong Zhu Cc: Liming Gao Signed-off-by: Gary Lin --- BaseTools/Source/Python/Common/Database.py | 8 BaseTools/Source/Python/Common/EdkLogger.py

[edk2] [PATCH v2 05/16] BaseTools: Move ImageBinDict to GenFdsGlobalVariable.py

2018-07-13 Thread Gary Lin
Move "ImageBinDict" from GenFds.py to GenFdsGlobalVariable.py so that we can remove the requirement to import GenFds.GenFds in Capsule.py, Fd.py and Fv.py. This breaks the following circular imports: * GenFds.FdfParser => GenFds.Capsule => GenFds.GenFds => GenFds.FdfParser * GenFds.FdfParser =>

[edk2] [PATCH v2 08/16] BaseTools: Use absolute import in BPDG

2018-07-13 Thread Gary Lin
Based on "futurize -f libfuturize.fixes.fix_absolute_import Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Yonghong Zhu Cc: Liming Gao Signed-off-by: Gary Lin --- BaseTools/Source/Python/BPDG/BPDG.py | 5 +++-- BaseTools/Source/Python/BPDG/GenVpd.py | 3 ++- 2 files changed, 5

[edk2] [PATCH v2 06/16] BaseTools: Use absolute import in AutoGen

2018-07-13 Thread Gary Lin
Based on "futurize -f libfuturize.fixes.fix_absolute_import Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Yonghong Zhu Cc: Liming Gao Signed-off-by: Gary Lin --- BaseTools/Source/Python/AutoGen/AutoGen.py| 17 + BaseTools/Source/Python/AutoGen/GenC.py

[edk2] [PATCH v2 02/16] BaseTools: Use absolute import in GenFds

2018-07-13 Thread Gary Lin
Based on "futurize -f libfuturize.fixes.fix_absolute_import" Since circular import is not allowed after adopting absolute import, the following changes are applied to break the circles. * BaseTools/Source/Python/GenFds/Capsule.py - Delay "from .GenFds import GenFds" until GenCapsule() -

[edk2] [PATCH v2 07/16] BaseTools: Treat BPDG.py as a python module

2018-07-13 Thread Gary Lin
Since BPDG.py import modules from its own directory, add "-m" to the python parameters so that they can import its own modules after adopting absolute import. Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Yonghong Zhu Cc: Liming Gao Signed-off-by: Gary Lin ---

[edk2] [PATCH v2 03/16] BaseTools: Move OverrideAttribs to OptRomInfStatement.py

2018-07-13 Thread Gary Lin
Move "class OverrideAttribs" to OptRomInfStatement.py to remove "import OptionRom" which may form a circular import: GenFds.OptionRom => GenFds.OptRomInfStatement => GenFds.OptionRom Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Yonghong Zhu Cc: Liming Gao Signed-off-by: Gary Lin

[edk2] [PATCH v2 01/16] BaseTools: Treat GenFds.py as a python module

2018-07-13 Thread Gary Lin
Since GenFds.py import modules from its own directory, add "-m" to the python parameters so that they can import its own modules after adopting absolute import. Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Yonghong Zhu Cc: Liming Gao Signed-off-by: Gary Lin ---

[edk2] [PATCH v2 00/16] BaseTools: Adopt absolute import

2018-07-13 Thread Gary Lin
v2: Treat BPDG and Ecc as python modules since they use the modules in its own directory This patch series is based on "libfuturize.fixes.fix_absolute_import" to adopt abolute import since relative import is not allowed in python3. The command is applied to BaseTools modules individually.

[edk2] [PATCH v2 04/16] BaseTools: Move FindExtendTool to GenFdsGlobalVariable.py

2018-07-13 Thread Gary Lin
Importing "FindExtendTool" from GenFds.GenFds could create the following circular imports: * GenFds.FdfParser => GenFds.Capsule => GenFds.GenFds => GenFds.FdfParser * GenFds.FdfParser => GenFds.Fd => GenFds.Fv => GenFds.AprioriSection => GenFds.FfsFileStatement => GenFds.GuidSection =>

Re: [edk2] [PATCH v1] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS2017 compilation errors

2018-07-13 Thread Leif Lindholm
+ Jaben, Ruiyu. On Fri, Jul 13, 2018 at 11:07:21AM +0100, AlexeiFedorov wrote: > This patch fixes VS2017 compilation errors for > UefiShellAcpiViewCommandLib\Parsers\Gtdt\GtdtParser.c > and > UefiShellAcpiViewCommandLib\Parsers\Xsdt\XsdtParser.c > reported in >

[edk2] [PATCH v1] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS2017 compilation errors

2018-07-13 Thread AlexeiFedorov
This patch fixes VS2017 compilation errors for UefiShellAcpiViewCommandLib\Parsers\Gtdt\GtdtParser.c and UefiShellAcpiViewCommandLib\Parsers\Xsdt\XsdtParser.c reported in https://bugzilla.tianocore.org/show_bug.cgi?id=985 https://bugzilla.tianocore.org/show_bug.cgi?id=986 Contributed-under:

Re: [edk2] Inquiry regarding early DxeIplPeim loading.

2018-07-13 Thread Zeng, Star
Marvin, You can check SHA-1: ebaafbe62c70309d0ceb44a0c4199093d0a823c4. It is for the case "Allow S3 Resume without having installed permanent memory (via InstallPeiMemory)" (PI Mantis 1532, you can search the sentence in PI spec) requested by HP. Yes before

Re: [edk2] [platforms: PATCH v3 5/6] Marvell/Library: Implement common ArmadaIcuLib

2018-07-13 Thread Leif Lindholm
On Fri, Jul 13, 2018 at 10:49:41AM +0200, Marcin Wojtas wrote: > ICU (Interrupt Consolidation Unit) is a mechanism, > that allows to send-message based interrupts from the > CP110 unit (South Bridge) to the Application Processor > hardware block. After dispatching the interrupts in the > GIC are

[edk2] [PATCH 6/6] MdeModulePkg CapsuleApp: Use EFI_UNSUPPORTED for incorrect Argc case

2018-07-13 Thread Star Zeng
Align code to use EFI_UNSUPPORTED for all incorrect Argc cases. Cc: Michael D Kinney Cc: Jiewen Yao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- MdeModulePkg/Application/CapsuleApp/CapsuleApp.c | 15 --- 1 file changed, 8

[edk2] [PATCH 4/6] MdeModulePkg CapsuleApp: Show clear message when option is unrecognized

2018-07-13 Thread Star Zeng
Cc: Michael D Kinney Cc: Jiewen Yao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- MdeModulePkg/Application/CapsuleApp/CapsuleApp.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

[edk2] [PATCH 3/6] MdeModulePkg CapsuleApp: Do not parse bits in CapsuleFlags of ESRT

2018-07-13 Thread Star Zeng
According to UEFI spec, only bits 0-15 of CapsuleFlags are meaningful and CapsuleGuid specific, CAPSULE_FLAGS_PERSIST_ACROSS_RESET CAPSULE_FLAGS_POPULATE_SYSTEM_TABLE/CAPSULE_FLAGS_INITIATE_RESET defined in UEFI spec are in bits 16-31, they should not be parsed in CapsuleFlags of ESRT.

[edk2] [PATCH 5/6] MdeModulePkg CapsuleApp: Check capsule header before using its Flags

2018-07-13 Thread Star Zeng
Cc: Michael D Kinney Cc: Jiewen Yao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- MdeModulePkg/Application/CapsuleApp/CapsuleApp.c | 38 1 file changed, 38 insertions(+) diff --git

[edk2] [PATCH 2/6] MdeModulePkg CapsuleApp: Fix memory leak in DumpFmpImage()

2018-07-13 Thread Star Zeng
Image buffer should be freed after using. Cc: Michael D Kinney Cc: Jiewen Yao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- MdeModulePkg/Application/CapsuleApp/CapsuleDump.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[edk2] [PATCH 0/6] CapsuleApp: Some enhancements

2018-07-13 Thread Star Zeng
Cc: Michael D Kinney Cc: Jiewen Yao Cc: Yonghong Zhu Star Zeng (6): MdeModulePkg CapsuleApp: Check Arg count for -P GET option MdeModulePkg CapsuleApp: Fix memory leak in DumpFmpImage() MdeModulePkg CapsuleApp: Do not parse bits in CapsuleFlags of ESRT MdeModulePkg CapsuleApp: Show

[edk2] [PATCH 1/6] MdeModulePkg CapsuleApp: Check Arg count for -P GET option

2018-07-13 Thread Star Zeng
Also add help info for CapsuleApp -P GET option. Cc: Michael D Kinney Cc: Jiewen Yao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- MdeModulePkg/Application/CapsuleApp/CapsuleApp.c | 19 +++ 1 file changed, 15

[edk2] [platforms: PATCH v3 5/6] Marvell/Library: Implement common ArmadaIcuLib

2018-07-13 Thread Marcin Wojtas
ICU (Interrupt Consolidation Unit) is a mechanism, that allows to send-message based interrupts from the CP110 unit (South Bridge) to the Application Processor hardware block. After dispatching the interrupts in the GIC are generated. This patch adds a basic version of the library, that allows to

Re: [edk2] [platforms: PATCH v2 5/6] Marvell/Library: Implement common ArmadaIcuLib

2018-07-13 Thread Leif Lindholm
On Fri, Jul 13, 2018 at 10:12:12AM +0200, Marcin Wojtas wrote: > ICU (Interrupt Consolidation Unit) is a mechanism, > that allows to send-message based interrupts from the > CP110 unit (South Bridge) to the Application Processor > hardware block. After dispatching the interrupts in the > GIC are

Re: [edk2] [PATCH edk2-non-osi v1 0/1] Fix invoke SetMemorySpaceAttributes error bug

2018-07-13 Thread Ming
在 13/07/2018 15:33, Ard Biesheuvel 写道: > On 4 July 2018 at 09:49, Ming Huang wrote: >> Code can also be found in github: >> https://github.com/hisilicon/OpenPlatformPkg.git >> branch: edk2-non-osi-20180627-v1 >> > > Can this be pulled independently from the v3 of the other series? > Yes, it

[edk2] [PATCH edk2-platforms v3 6/6] Hisilicon/D0x: Correct smbios product name

2018-07-13 Thread Ming Huang
The product name getting from BMC is not suitable. It may cause ambiguity. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Signed-off-by: Heyi Guo --- Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunction.c | 1 - 1 file

[edk2] [PATCH edk2-platforms v3 3/6] Hisilicon/D0x: Fix SetAtuConfig1RW bug

2018-07-13 Thread Ming Huang
The MemLimit is wrong when the Private->BusLimit equal 0xFF. This patch fix enumerating device plug in switch cart failed issue. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Signed-off-by: Heyi Guo ---

[edk2] [PATCH edk2-platforms v3 5/6] Hisilicon/D05/Pcie: optimize two pcie ports space

2018-07-13 Thread Ming Huang
Optimize pcie space for promoting usage rate.Change regions order of NA-Pcie2 and NB-Pcie1 to MEM-ECAM-IO in DAW,so MemoryRegion can satisfy the requirement of larger address alignment. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Signed-off-by: Heyi Guo ---

[edk2] [PATCH edk2-platforms v3 1/6] Hisilicon/D0x: Fix invoke SetMemorySpaceAttributes error bug

2018-07-13 Thread Ming Huang
The edk2 commit bacfd6e let CpuDxe running latter. CpuDxe is needed by gDS->SetMemorySpaceAttributes, and gDS->SetMemorySpaceAttributes is invoked by some drivers. This issue can solve by adding Depex on gEfiCpuArchProtocolGuid to RealTimeClockLib. Contributed-under: TianoCore Contribution

[edk2] [PATCH edk2-platforms v3 4/6] Hisilicon/D05: Add PlatformMiscDxe driver

2018-07-13 Thread Ming Huang
Fix the issue of onboard Nic not work kerenl with AMD GPU and NVME SSD in board. The GPU don't support 64 MSI, so need to allocate INTx, but the default interrupt number 255 is invalid, so Change all the PCI Device interrupt number to 0. Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [PATCH edk2-platforms v3 0/6] Improve D0x platforms and bug fix

2018-07-13 Thread Ming Huang
The major features of this patchset include: 1 Fix invoke SetMemorySpaceAttributes error bug 2 Correct ATU Cfg0/Cfg1 base address 3 Fix SetAtuConfig1RW bug 4 Add PlatformMiscDxe driver 5 optimize two pcie prots space 6 Correct smbios product name BTW: 1 D06 source will upstream in July; 2

[edk2] [PATCH edk2-platforms v3 2/6] Hisilicon/D03/D05: Correct ATU Cfg0/Cfg1 base address

2018-07-13 Thread Ming Huang
From: Jason Zhang 1. During test PCIe mcs9922 UART card, the card can't work because the IO ATU config is overlap by Cfg0/Cfg1 ATU address. 2. After adjust the ATU windows, Cfg0/Cfg1 config as below: Cfg0 is equal to "ECAM + (BusBase, 0, 0)" Cfg1 is equal to "ECAM + (BusBase + 2,

[edk2] [platforms: PATCH v2 2/6] Marvell/Library: Introduce ArmadaIcuLib class

2018-07-13 Thread Marcin Wojtas
ICU (Interrupt Consolidation Unit) is a mechanism, that allows to send a message-based interrupts from the CP110 unit (South Bridge) to the Application Processor hardware block. After dispatching the interrupts in the GIC are generated. This patch adds a basic version of the library, that allows

[edk2] [platforms: PATCH v2 4/6] Marvell/Library: Armada7k8kSoCDescLib: Introduce ICU information

2018-07-13 Thread Marcin Wojtas
This patch introduces new library callback (ArmadaSoCDescIcuGet ()), which dynamically allocates and fills MV_SOC_ICU_DESC structure with the SoC description of ICU (Interrupt Consolidation Unit). Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas ---

[edk2] [platforms: PATCH v2 1/6] Marvell/Armada70x0Db: Set correct CP110 count

2018-07-13 Thread Marcin Wojtas
As a preparation for adding the ICU (Interrupt Consolidation Unit) library implementation a correct CP110 count is required. Do it for Armada70x0Db and fix depending XHCI/AHCI PCD's accordingly. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Ard

[edk2] [platforms: PATCH v2 3/6] Marvell/Library: Armada7k8kSoCDescLib: Enable getting CP base address

2018-07-13 Thread Marcin Wojtas
For upcoming patches there is a need to get the CP110 base address, introduce according getter function for it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Include/Library/ArmadaSoCDescLib.h | 9 +

[edk2] [platforms: PATCH v2 5/6] Marvell/Library: Implement common ArmadaIcuLib

2018-07-13 Thread Marcin Wojtas
ICU (Interrupt Consolidation Unit) is a mechanism, that allows to send-message based interrupts from the CP110 unit (South Bridge) to the Application Processor hardware block. After dispatching the interrupts in the GIC are generated. This patch adds a basic version of the library, that allows to

[edk2] [platforms: PATCH v2 0/6] Armada7k8k ICU support

2018-07-13 Thread Marcin Wojtas
Hi, The second version of the ICU patchset brings all corrections according to all review remarks. They were mostly style / naming - detailed list can be found in the changelog below. The patches are available in the github:

[edk2] [platforms: PATCH v2 6/6] Marvell/Armada7k8k: Enable ICU configuration

2018-07-13 Thread Marcin Wojtas
This patch enables the ICU (Interrupt Consolidation Unit) configuration in the common platform initialization driver. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Ard Biesheuvel --- Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc

Re: [edk2] [PATCH edk2-non-osi v1 0/1] Fix invoke SetMemorySpaceAttributes error bug

2018-07-13 Thread Ard Biesheuvel
On 4 July 2018 at 09:49, Ming Huang wrote: > Code can also be found in github: > https://github.com/hisilicon/OpenPlatformPkg.git > branch: edk2-non-osi-20180627-v1 > Can this be pulled independently from the v3 of the other series? > Ming Huang (1): > Hisilicon/D0x: Fix invoke

Re: [edk2] [PATCH edk2-platforms v2 1/6] Hisilicon/D0x: Fix invoke SetMemorySpaceAttributes error bug

2018-07-13 Thread Ming
在 13/07/2018 14:46, Ard Biesheuvel 写道: > On 12 July 2018 at 10:50, Ming wrote: >> >> >> 在 11/07/2018 22:19, Ard Biesheuvel 写道: >>> On 4 July 2018 at 09:51, Ming Huang wrote: The edk2 commit bacfd6e let CpuDxe running latter. CpuDxe is needed by gDS->SetMemorySpaceAttributes, and

Re: [edk2] [PATCH edk2-platforms] Platform/Comcast/RDKQemu: incorporating ArmVirtQemu changes

2018-07-13 Thread Ard Biesheuvel
On 12 July 2018 at 07:54, Moorthy Baskaravenkatraman wrote: > Incorporated ArmVirtQemu latest changes into RDK Qemu platform > - DevicePathLib library class added in Dxe Core > - NvVarStoreFormattedLib added in VariableRuntimeDxe > - DevicePathLib and PcdLib library classes added

Re: [edk2] [platforms: PATCH 6/6] Marvell/Armada7k8k: Enable ICU configuration

2018-07-13 Thread Ard Biesheuvel
On 12 July 2018 at 09:40, Marcin Wojtas wrote: > This patch enables the ICU (Interrupt Consolidation Unit) > configuration in the common platform initialization driver. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marcin Wojtas Reviewed-by: Ard Biesheuvel > ---

Re: [edk2] [platforms: PATCH 4/6] Marvell/Library: Armada7k8kSoCDescLib: Introduce ICU information

2018-07-13 Thread Ard Biesheuvel
On 12 July 2018 at 09:39, Marcin Wojtas wrote: > This patch introduces new library callback (ArmadaSoCDescIcuGet ()), > which dynamically allocates and fills MV_SOC_ICU_DESC structure with > the SoC description of ICU (Interrupt Consolidation Unit). > > Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH edk2-platforms v2 1/6] Hisilicon/D0x: Fix invoke SetMemorySpaceAttributes error bug

2018-07-13 Thread Ard Biesheuvel
On 12 July 2018 at 10:50, Ming wrote: > > > 在 11/07/2018 22:19, Ard Biesheuvel 写道: >> On 4 July 2018 at 09:51, Ming Huang wrote: >>> The edk2 commit bacfd6e let CpuDxe running latter. >>> CpuDxe is needed by gDS->SetMemorySpaceAttributes, and >>> gDS->SetMemorySpaceAttributes is invoked by some

Re: [edk2] [PATCH 0/2] ArmVirtPkg/ArmVirtQemu: enable the IPv6 stack

2018-07-13 Thread Ard Biesheuvel
On 13 July 2018 at 01:41, Laszlo Ersek wrote: > Repo: https://github.com/lersek/edk2.git > Branch: armvirt_ipv6_bz1007 > > Tested the "-D NETWORK_IP6_ENABLE" ArmVirtQemu build with PXEv4, PXEv6, > HTTPv4, HTTPv6 netboot. > > Build-tested the ArmVirtQemuKernel build (32- and 64-bit), and the >