[edk2] [PATCH] MdePkg: Add the missing spec version information for header files

2018-08-21 Thread shenglei
Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei --- MdePkg/Include/Protocol/AbsolutePointer.h| 3 +++ MdePkg/Include/Protocol/AcpiSystemDescriptionTable.h | 3 +++ MdePkg/Include/Protocol/AcpiTable.h

[edk2] [Patch][edk2-platforms/devel-IntelAtomProcessorE3900] MinnowBoard3 Module UART

2018-08-21 Thread Guo, Mang
1. Change MinnowBoard3 Module UART number from 0 to 2. 2. Add zero checking before SetVariable to avoid seting variable each time boot. Cc: David Wei Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Guo Mang --- .../Board/UP2/BoardInitDxe/BoardInitDxe.c| 20 +++

Re: [edk2] [PATCH] MdeModulePkg UhciPei: Remove a redundant function

2018-08-21 Thread Zeng, Star
It is changing EhciPei but not UhciPei, please update the title. Reviewed-by: Star Zeng with the title updated. Thanks, Star -Original Message- From: Zhang, Shenglei Sent: Wednesday, August 22, 2018 9:50 AM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric Subject: [PATCH] MdeMo

Re: [edk2] [PATCH 3/4] NetworkPkg/TlsAuthConfigDxe: fix TlsCaCertificate attributes retrieval

2018-08-21 Thread Wu, Jiaxin
Reviewed-by: Wu Jiaxin Thanks, Jiaxin > -Original Message- > From: Li, Songpeng > Sent: Monday, August 20, 2018 2:29 PM > To: Laszlo Ersek ; edk2-devel-01 de...@lists.01.org> > Cc: Wu, Jiaxin ; Fu, Siyuan > Subject: RE: [PATCH 3/4] NetworkPkg/TlsAuthConfigDxe: fix TlsCaCertificate > at

Re: [edk2] [PATCH edk2-platforms v2 11/43] Platform/Hisilicon/D06: Add M41T83RealTimeClockLib

2018-08-21 Thread Leif Lindholm
On Tue, Aug 14, 2018 at 04:08:31PM +0800, Ming Huang wrote: > Add M41T83RealTimeClockLib for RTC. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > --- > Platform/Hisilicon/D06/D06.dsc > | 1 + > Silicon/H

Re: [edk2] [PATCH edk2-platforms v2 10/43] Hisilicon/D06: Add several base file for D06

2018-08-21 Thread Leif Lindholm
On Tue, Aug 14, 2018 at 04:08:30PM +0800, Ming Huang wrote: > Add several base head files and add several build > files for D06. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang All my comments have been addressed, so: Reviewed-by: Leif Lindholm > --- >

Re: [edk2] [PATCH edk2-platforms v3 17/36] Hisilicon/I2C: Fix a typo issue

2018-08-21 Thread Leif Lindholm
Err, that was 13, 14 and 17 in v3. In v2, it's 20, 21, 24. (I pushed the right patches, I just replied to the wrong email.) On Tue, Aug 21, 2018 at 10:45:44PM +0100, Leif Lindholm wrote: > Patches 13, 14 and 17/43 are just cleanup and refactoring of I2C > library. It can (and should) go in befor

Re: [edk2] [PATCH edk2-platforms v3 17/36] Hisilicon/I2C: Fix a typo issue

2018-08-21 Thread Leif Lindholm
Patches 13, 14 and 17/43 are just cleanup and refactoring of I2C library. It can (and should) go in before D06 support. For the three patches: Reviewed-by: Leif Lindholm Pushed as 4e6af5fa1b..342330470f. On Thu, Aug 16, 2018 at 08:12:20PM +0800, Ming Huang wrote: > Modify spedd to Speed. > > C

Re: [edk2] [PATCH edk2-platforms v3 32/36] Silicon/Hisilicon/Setup: Support SPCR table switch

2018-08-21 Thread Leif Lindholm
On Thu, Aug 16, 2018 at 08:12:35PM +0800, Ming Huang wrote: > If install SPCR table, KVM will not output while install or boot > some OS, like ubuntu, so add SPCR switch setup item and set it > disable by default. This one was supposed to be replaced with EmbeddedPkg/Drivers/ConsolePrefDxe, right?

Re: [edk2] [PATCH edk2-platforms v2 01/43] Silicon/Hisilicon: Modify the MRC interface for other module

2018-08-21 Thread Leif Lindholm
On Tue, Aug 14, 2018 at 04:08:21PM +0800, Ming Huang wrote: > This patch is to unify D0x. Add pGBL_INTERFACE struct define > and remove useless interfece. Replace DMRC pGblData with pGblInterface; interfece -> interface I will fix that up on commit. Reviewed-by: Leif Lindholm > Contributed-und

Re: [edk2] [PATCH edk2-platforms v2 05/43] Silicon/Hisilicon/D0x: Move RAS macro to PlatformArch.h

2018-08-21 Thread Leif Lindholm
This one needs to be rebased onto the modified 3/43. I have no other issues with it, so when you resubmit: Reviewed-by: Leif Lindholm On Tue, Aug 14, 2018 at 04:08:25PM +0800, Ming Huang wrote: > From: Sun Yuanchen > > Move some RAS macros definition to PlatformArch.h for > unifying D0x > > Co

Re: [edk2] [PATCH V2] BaseTools: Fix regression issue by b23414f6540d

2018-08-21 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: Zhu, Yonghong > Sent: Monday, August 20, 2018 10:33 PM > To: Feng, YunhuaX ; edk2-devel@lists.01.org > Cc: Gao, Liming ; Carsey, Jaben > ; Zhu, Yonghong > Subject: RE: [PATCH V2] BaseTools: Fix regression issue by b23414f6540d > Impo

Re: [edk2] [PATCH v2 3/4] UefiCpuPkg/CpuDxe: implement non-stop mode for uefi

2018-08-21 Thread Laszlo Ersek
I only have some superficial comments here. On 08/21/18 05:05, Jian J Wang wrote: >> v2 changes: >>n/a > > Same as SMM profile feature, a special #PF is used to set page attribute > to 'present' and a special #DB handler to reset it back to 'not-present', > right after the instruction causing

Re: [edk2] [PATCH v2 2/4] UefiCpuPkg/CpuExceptionHandlerLib: Setup single step in #PF handler

2018-08-21 Thread Laszlo Ersek
On 08/21/18 05:05, Jian J Wang wrote: >> v2 changes: >>n/a > > Once the #PF handler has set the page to be 'present', there should > be a way to reset it to 'not-present'. 'TF' bit in EFLAGS can be used > for this purpose. 'TF' bit will be set in interrupted function context > so that it can b

Re: [edk2] [PATCH v2 0/4] Support non-stop mode in heap guard and null detection

2018-08-21 Thread Laszlo Ersek
On 08/21/18 05:05, Jian J Wang wrote: >> v2 changes: >>fix GCC build error > > Background: > Heap Guard and NULL Pointer Detection are very useful features to detect > code flaw in EDK II. If an issue is detected, #PF exception will be > triggered and the BIOS will enter into dead loop, which

Re: [edk2] [PATCH v2 4/7] MdePkg: Remove an unused PCD

2018-08-21 Thread Laszlo Ersek
On 08/21/18 03:35, shenglei wrote: > The PCD below is unused, so it has been removed from inf. > gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask > > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: shenglei > ---

Re: [edk2] [PATCH 3/4] NetworkPkg/TlsAuthConfigDxe: fix TlsCaCertificate attributes retrieval

2018-08-21 Thread Laszlo Ersek
On 08/20/18 08:29, Li, Songpeng wrote: > It worked on my end. > > Tested-by: Songpeng Li Thank you! Jiaxin, Siyuan, are you guys OK with this patch? Thanks Laszlo >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Friday, August 17, 2018 10:36 PM >> To: ed

Re: [edk2] [edk2-wiki PATCH 0/2] document the Soft and Hard Feature Freezes

2018-08-21 Thread Laszlo Ersek
On 08/16/18 16:51, Laszlo Ersek wrote: > The recently added "EDK II Release Planning" wiki page refers to the > Soft and Hard Feature Freezes, but the definitions are missing. This > series provides them, and updates the planning page to link them. > > The pages can be read "live" in my wiki clone

Re: [edk2] [Patch] MdeModulePkg/PiSmmCore: Check valid memory range.

2018-08-21 Thread Dong, Eric
Hi Star, Good catch. I tried to boot an test platform and it passed. I assume it has cases to free the smm memory. Seems like actually it doesn't. I will add test code to verify the patch and send v2 change. Thanks, Eric > -Original Message- > From: Zeng, Star > Sent: Tuesday, August 21

[edk2] [Patch v2] MdeModulePkg/PiSmmCore: Check valid memory range.

2018-08-21 Thread Eric Dong
Call BS.AllocatePages in DXE driver and call SMM FreePages with the address of the buffer allocated in the DXE driver. SMM FreePages success and add a non-SMRAM range into SMM heap list. This is not an expected behavior. SMM FreePages should return error for this case and not free the pages. V2

[edk2] [PATCH edk-platforms v1 4/4] Platform/HiKey: enable usb driver

2018-08-21 Thread Haojian Zhuang
Enable Designware USB 2.0 device driver on HiKey platform. It's used in Android Fastboot App. Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Haojian Zhuang --- Platform/Hisilicon/HiKey/HiKey.dec | 2 ++ Platform/Hisilicon/HiKey/HiKe

[edk2] [PATCH edk-platforms v1 3/4] Platform/HiKey: add fastboot platform driver

2018-08-21 Thread Haojian Zhuang
Implement Android Fastboot protocol on HiKey platform. Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Haojian Zhuang --- Platform/Hisilicon/HiKey/HiKeyFastbootDxe/HiKeyFastbootDxe.inf | 61 ++ Platform/Hisilicon/HiKey/HiKeyFastbootD

[edk2] [PATCH edk-platforms v1 2/4] Platform/HiKey: add usb platform driver

2018-08-21 Thread Haojian Zhuang
Implement DwUsb protocol in the usb platform driver on HiKey platform. Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Haojian Zhuang --- Platform/Hisilicon/HiKey/HiKeyUsbDxe/HiKeyUsbDxe.inf | 46 Platform/Hisilicon/HiKey/HiKeyU

[edk2] [PATCH edk-platforms v1 1/4] Platform/HiKey: add more register definitions

2018-08-21 Thread Haojian Zhuang
These register definitions are used in USB device driver. Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Haojian Zhuang --- Silicon/Hisilicon/Hi6220/Include/Hi6220.h | 53 1 file changed, 53 insertions(+) diff -

[edk2] [PATCH v1 1/1] EmbeddedPkg/Drivers: add DwUsbDxe

2018-08-21 Thread Haojian Zhuang
Add Designware USB 2.0 device driver that is used on HiKey platform. Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Haojian Zhuang --- EmbeddedPkg/Drivers/DwUsbDxe/DwUsbDxe.dec | 45 + EmbeddedPkg/Drivers/DwUsbDxe/DwUsbDxe.inf | 52

Re: [edk2] [patch] MdeModulePkg/SmmCorePerfLib: Add DxeServicesLib library class in INF

2018-08-21 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Bi, Dandan Sent: Tuesday, August 21, 2018 4:57 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zeng, Star Subject: [patch] MdeModulePkg/SmmCorePerfLib: Add DxeServicesLib library class in INF REF: https://bugzilla.tianocore.org/show_bug

Re: [edk2] [Patch] MdeModulePkg/PiSmmCore: Check valid memory range.

2018-08-21 Thread Zeng, Star
Hi Eric, About + EFI_PHYSICAL_ADDRESS Last; + Last = Memory + EFI_PAGES_TO_SIZE (NumberOfPages); Shouldn't "-1" be also added like the code below in ConvertSmmMemoryMapEntry()? EFI_PHYSICAL_ADDRESS End; End = Memory + EFI_PAGES_TO_SIZE(NumberOfPages) - 1; Could you double check the

[edk2] [patch] MdeModulePkg/SmmCorePerfLib: Add DxeServicesLib library class in INF

2018-08-21 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1100 SmmCorePerformanceLib consume the DxeServicesLib, but miss to add the library class in INF file. This patch is to fix this issue. Cc: Liming Gao Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan B

[edk2] [Patch][edk2-platforms/devel-IntelAtomProcessorE3900] Add /C build option

2018-08-21 Thread Guo, Mang
Add /C build option for Module FAB C board Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Guo Mang --- BuildBIOS.bat | 1 + Platform/BroxtonPlatformPkg/BuildBxtBios.bat | 26 +++--- Platform/BroxtonPlatformPkg/B

[edk2] [PATCH 2/2] MdeModulePkg: Update SMBIOS PCDs to 3.2.0

2018-08-21 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1099 Cc: Liming Gao Cc: Dandan Bi Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- MdeModulePkg/MdeModulePkg.dec | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[edk2] [PATCH 1/2] MdePkg SmBios.h: Add SMBIOS 3.2.0 definitions

2018-08-21 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1099 Add SMBIOS 3.2.0 definitions according to www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.2.0.pdf. Processor Information (Type 4): - SMBIOSCR00163: add socket LGA2066 - SMBIOSCR00173: add Intel Core i9 - SMBIOSCR00176: add ne

[edk2] [PATCH 0/2] Add SMBIOS 3.2.0 definitions

2018-08-21 Thread Star Zeng
https://bugzilla.tianocore.org/show_bug.cgi?id=1099 This patch series updates 1. MdePkg/Include/IndustryStandard/Smbios.h 2. gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosVersion and gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosDocRev Star Zeng (2): MdePkg SmBios.h: Add SMBIOS 3.2.0 definitions MdeMod