Then AddEmulator and RemoveEmulator will be like below.
typedef
EFI_STATUS
(EFIAPI *EDKII_PECOFF_IMAGE_EMULATOR_ADD_EMULATOR) (
IN EDKII_PECOFF_IMAGE_EMULATOR_PROTOCOL*This,
IN PECOFF_IMAGE_EMULATOR
*Emulator
);
typedef
The input param String of AsciiStrStr() requires a pointer to
Null-terminated string, however in HttpUtilitiesParse(),
the Buffersize before AllocateZeroPool() is equal to the size
of TCP header, after the CopyMem(), it might not end with
Null-terminator. It might cause memory access overflow.
Mike,
Good idea.
You prefer to introduce a new feature PCD for this with default value = TRUE?
Could we group the emulator APIs to one structure like below? And add a Version
field for potential further extension?
typedef struct {
UINTN Version;
The input param String of AsciiStrStr() requires a pointer to
Null-terminated string, however in HttpTcpReceiveHeader(),
the Buffersize before AllocateZeroPool() is equal to the size
of TCP header, after the CopyMem(), it might not end with
Null-terminator. It might cause memory access
The input param String of AsciiStrStr() requires a pointer to
Null-terminated string, however in HttpTcpReceiveHeader() and
HttpUtilitiesParse(), the Buffersize before AllocateZeroPool()
is equal to the size of TCP header, after the CopyMem(), it
might not end with Null-terminator. It might
Thanks Star, I have committed the patch since it resolves the VS2012 build
error.
> -Original Message-
> From: Zeng, Star
> Sent: Friday, September 28, 2018 10:31 AM
> To: Wu, Jiaxin ; edk2-devel@lists.01.org
> Cc: Ye, Ting ; Fu, Siyuan ; Carsey,
> Jaben ; Zeng, Star
> Subject: RE:
Reviewed-by: Star Zeng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chasel,
Chiu
Sent: Friday, September 28, 2018 10:38 AM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen ; Zeng, Star
Subject: [edk2] [PATCH] IntelFsp2(Wrapper)Pkg: Revert from
Reviewed-by: Fu Siyuan
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Songpeng Li
> Sent: Friday, September 28, 2018 9:57 AM
> To: edk2-devel@lists.01.org
> Cc: Fu, Siyuan ; Wu, Jiaxin
> Subject: [edk2] [PATCH 2/2]
Commit formats had issues so reverted 9 commits
from IntelFsp2Pkg and IntelFsp2WrapperPkg.
Will re-submit them with correct formats.
Cc: Jiewen Yao
Cc: Star Zeng
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Chasel Chiu
---
IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
Reviewed-by: Star Zeng
-Original Message-
From: Wu, Jiaxin
Sent: Thursday, September 27, 2018 10:42 PM
To: edk2-devel@lists.01.org
Cc: Ye, Ting ; Fu, Siyuan ; Carsey,
Jaben ; Zeng, Star ; Wu, Jiaxin
Subject: [Patch] ShellPkg/TftpDynamicCommand: Fix the potentially uninitialized
Reviewed-by: Fu Siyuan
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Songpeng Li
> Sent: Friday, September 28, 2018 9:57 AM
> To: edk2-devel@lists.01.org
> Cc: Fu, Siyuan ; Wu, Jiaxin
> Subject: [edk2] [PATCH 1/2] NetworkPkg/HttpDxe: fix
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Guo Mang
---
Platform/BroxtonPlatformPkg/BiosId.env | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform/BroxtonPlatformPkg/BiosId.env
b/Platform/BroxtonPlatformPkg/BiosId.env
index 5619b36..b23f15a
The input param String of AsciiStrStr() requires a pointer to
Null-terminated string, however in HttpTcpReceiveHeader() and
HttpUtilitiesParse(), the Buffersize before AllocateZeroPool()
is equal to the size of TCP header, after the CopyMem(), it
might not end with Null-terminator. It might
The input param String of AsciiStrStr() requires a pointer to
Null-terminated string, however in HttpTcpReceiveHeader(),
the Buffersize before AllocateZeroPool() is equal to the size
of TCP header, after the CopyMem(), it might not end with
Null-terminator. It might cause memory access
The input param String of AsciiStrStr() requires a pointer to
Null-terminated string, however in HttpUtilitiesParse(),
the Buffersize before AllocateZeroPool() is equal to the size
of TCP header, after the CopyMem(), it might not end with
Null-terminator. It might cause memory access overflow.
Reviewed-by: Liming Gao
> -Original Message-
> From: Guo, Dongao
> Sent: Wednesday, September 26, 2018 5:46 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [PATCH] MdeModulePkg/RegularExpressionDxe: modify inf to pass vs
> 2012 build
>
> add /wd4703 for passing VS 2012
Reviewed-by: Liming Gao
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Yonghong Zhu
> Sent: Monday, September 17, 2018 4:17 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [edk2] [Patch] BaseTools: remove the not used
Reviewed-by: Liming Gao
> -Original Message-
> From: Zhu, Yonghong
> Sent: Tuesday, September 25, 2018 4:58 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming ; Kinney, Michael D
> ; Shaw, Kevin W
> Subject: [Patch] Build Spec: Add some clarification of Build report section
>
> 1. Add
Reviewed-by: Liming Gao
> -Original Message-
> From: Zhu, Yonghong
> Sent: Tuesday, September 25, 2018 4:37 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming ; Kinney, Michael D
> ; Shaw, Kevin W
> Subject: [Patch] Build Spec: Update EBNF of --pcd for String type to at least
> one
Hi Ard,
Yes. I think it is simpler if an emulator module registers
one machine type at a time. If an emulator module wants
to do a single registration and that registration supports
multiple machine types, then the emulator implementation
is more complex, but it is still feasible.
I think I
On 09/27/18 13:45, Laszlo Ersek wrote:
> On 09/27/18 12:59, Marc-André Lureau wrote:
>> Hi,
>>
>> According to "TCG Platform Reset Attack Mitigation Specification", if
>> MOR bit is set, "it must initiate a vendor-specific method that
>> overwrites all of system memory and the processor caches"
>>
Why divide by sizeof(UINT8)? sizeof() always returns the size in bytes.
Index is type UINTN, so it will always be >=0, so I do
think the loop will ever exit.
Mike
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-
> boun...@lists.01.org] On Behalf Of Songpeng Li
> Sent:
Reviewed-by: David Wei
Thanks,
David Wei
Intel SSG/STO/UEFI BIOS
-Original Message-
From: Guo, Mang
Sent: Thursday, September 27, 2018 5:59 PM
To: edk2-devel@lists.01.org
Cc: Wei, David
Subject: [Patch][edk2-platforms/devel-IntelAtomProcessorE3900]
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1217
Local variable 'Mtftp4Token' might be uninitialized when error happen. This
patch is to
resolve the issue.
Cc: Ye Ting
Cc: Fu Siyuan
Cc: Carsey Jaben
Cc: Zeng Star
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by:
+Joakim
Joakim,
Please help to answer below query from Michael regarding licensing
concerns for using Global Platform specs content in OP-TEE.
Regards,
Sumit
On Wed, 26 Sep 2018 at 23:32, Kinney, Michael D
wrote:
>
> Ard,
>
> I think it depends on the license behind the click
> through.
>
>
On 09/27/18 12:59, Marc-André Lureau wrote:
> Hi,
>
> According to "TCG Platform Reset Attack Mitigation Specification", if
> MOR bit is set, "it must initiate a vendor-specific method that
> overwrites all of system memory and the processor caches"
>
> In
Hi,
According to "TCG Platform Reset Attack Mitigation Specification", if
MOR bit is set, "it must initiate a vendor-specific method that
overwrites all of system memory and the processor caches"
In QuarkPlatformPkg/Platform/Pei/PlatformInit/MemoryCallback.c and
On 27 September 2018 at 02:48, Zeng, Star wrote:
> Yes. This idea also came to my mind last night, then no need introduce
> PeCoffEmulatorDxe and no platform change is needed.
>
The only problem with this approach is that we cannot keep track of
which emulator returned TRUE for IsSupported(),
On 09/27/18 11:28, Shao, Ming wrote:
> Hi Laszlo,
>
> I build Ruiyu's code with gcc 4.8.5 as X64. And got below disassembled
> code:
>
> [cid:image002.jpg@01D45686.AFEDF140]
>
> So I didn't see register used as both destination and source of xadd
> instruction.
>
> Then I build your patch, and got
Set TPM Device setup option to non-configurable. The default value of TPM
device is disable.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Guo Mang
CC: David Wei
CC: Mike Wu
---
.../Common/PlatformSettings/PlatformSetupDxe/Security.vfi | 4 +++-
1 file
Hi Laszlo,
I build Ruiyu's code with gcc 4.8.5 as X64. And got below disassembled code:
[cid:image001.jpg@01D45689.F8A3F530]
So I didn't see register used as both destination and source of xadd
instruction.
Then I build your patch, and got exactly the same disassembled code.
Both
The variable in memory is stored as little endian, so the byte 0 is actually
stored in the last byte in memory.
Best,
Songpeng
> -Original Message-
> From: Fu, Siyuan
> Sent: Thursday, September 27, 2018 3:51 PM
> To: Li, Songpeng ; edk2-devel@lists.01.org
> Cc: Wu, Jiaxin ; Gao,
Hi, Songpeng
According to the iSCSI text device note in UEFI spec, the byte 0 of LUN should
come first, seems there is no problem in original code logic. Could you please
double confirm that?
"The LUN is an 8 byte array that is displayed in hexadecimal format
with byte 0 first (i.e.,
On 9/27/2018 3:13 PM, edk2-devel-boun...@lists.01.org wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1215
This issue is caused by commit 5267926134d17e86672b84fd57b438f05ffa68e1.
Jian J Wang (2):
Nt32Pkg/Nt32Pkg.dsc: override PCD default to avoid boot failure
Introduce initial support for fast boot and related feature flags. This is
targeted for fixed hardware configuration systems which care less about BDS
phase console and dynamic detection, where a headless-like boot is acceptable.
When fast boot flag is turned ON, some features will be disabled
In DevPathToTextiSCSI(), ISCSIDevPath->Lun is printed in reversed orders.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1216
Cc: Fu Siyuan
Cc: Wu Jiaxin
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Songpeng Li
---
Reviewed-by: Star Zeng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org]
Sent: Thursday, September 27, 2018 3:14 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [PATCH 0/2] Fix Nt32Pkg/EmulatorPkg boot failure
REF:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1215
This issue is caused by commit 5267926134d17e86672b84fd57b438f05ffa68e1.
The reason is this commit changed the condition of building page table
in DxeIpl. The code before it will only build page table for the sake
of PcdSetNxForStack. This
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1215
This issue is caused by commit 5267926134d17e86672b84fd57b438f05ffa68e1.
The reason is this commit changed the condition of building page table
in DxeIpl. The code before it will only build page table for the sake
of PcdSetNxForStack. This
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1215
This issue is caused by commit 5267926134d17e86672b84fd57b438f05ffa68e1.
Jian J Wang (2):
Nt32Pkg/Nt32Pkg.dsc: override PCD default to avoid boot failure
EmulatorPkg/EmulatorPkg.dsc: override PCD default to avoid boot
failure
Good to know.
From: Jorge Fernandez Monteagudo [mailto:jorg...@cirsa.com]
Sent: Thursday, September 27, 2018 2:53 PM
To: Yao, Jiewen ; Zhang, Chao B ;
edk2-devel@lists.01.org
Subject: Re: Tianocore and TPM2 pcr values
Studying the kernel code it seems that it's a warning. The error 2314
Studying the kernel code it seems that it's a warning. The error 2314
(TPM2_RC_TESTING)
is a warning because a testing is already running and it's detected and it
returns immediately
to shorten boot time.
De: Jorge Fernandez Monteagudo
Enviado: jueves, 27 de
The selftest is done by the kernel but I suspect he expect something to be done
before the
selftest but I'm not sure what... The coreboot code is the same for the test
I've done with SeaBIOS
and Tianocore.
>From the kernel code:
/**
* tpm2_do_selftest() - ensure that all self tests have
May I know who does the self test? coreboot ? or SeaBIOS?
Thank you
Yao Jiewen
From: Jorge Fernandez Monteagudo [mailto:jorg...@cirsa.com]
Sent: Thursday, September 27, 2018 2:12 PM
To: Yao, Jiewen ; Zhang, Chao B ;
edk2-devel@lists.01.org
Subject: Re: Tianocore and TPM2 pcr values
Hi, the
Reviewed-by: Guo Mang mailto:mang@intel.com>>
Thanks,
Mang
From: Steele, Kelly
Sent: Saturday, September 22, 2018 2:30 AM
To: edk2-devel@lists.01.org
Cc: Wei, David; Guo, Mang
Subject: [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Dynamic debug
UART
>From
Hi, the only remaining issue is this dmesg TPM error trace I get when booting
with the UEFI payload
but not present when SeaBIOS is used:
[0.390995] tpm_tis 00:02: 2.0 TPM (device-id 0x1A, rev-id 16)
[0.399957] tpm tpm0: A TPM error (2314) occurred attempting the self test
but I don't
Reviewed-by: Guo Mang mailto:mang@intel.com>>
Thanks,
Mang
From: Steele, Kelly
Sent: Saturday, September 22, 2018 2:29 AM
To: edk2-devel@lists.01.org
Cc: Wei, David; Guo, Mang
Subject: [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] FDF has unused
PCDs
>From
47 matches
Mail list logo
